GridCal 5.1.21__tar.gz → 5.1.23__tar.gz

{GridCal-5.1.21 → GridCal-5.1.23}/GridCal/ExecuteGridCal.py

@@ -1,17 +1,19 @@
-# This file is part of GridCal.
+# GridCal
+# Copyright (C) 2015 - 2024 Santiago Peñate Vera
 #
-# GridCal is free software: you can redistribute it and/or modify
-# it under the terms of the GNU General Public License as published by
-# the Free Software Foundation, either version 3 of the License, or
-# (at your option) any later version.
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU Lesser General Public
+# License as published by the Free Software Foundation; either
+# version 3 of the License, or (at your option) any later version.
 #
-# GridCal is distributed in the hope that it will be useful,
+# This program is distributed in the hope that it will be useful,
 # but WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-# GNU General Public License for more details.
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+# Lesser General Public License for more details.
 #
-# You should have received a copy of the GNU General Public License
-# along with GridCal.  If not, see <http://www.gnu.org/licenses/>.
+# You should have received a copy of the GNU Lesser General Public License
+# along with this program; if not, write to the Free Software Foundation,
+# Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
 import os
 import sys
 import ctypes

{GridCal-5.1.21 → GridCal-5.1.23}/GridCal/Gui/Diagrams/MapWidget/Branches/map_line_container.py

@@ -59,12 +59,12 @@ class MapLineContainer(GenericDiagramWidget):
                                       editor=editor,
                                       draw_labels=draw_labels)
 
-        self.editor: GridMapWidget = editor  # re assign to make clear the editor type
+        self.editor: GridMapWidget = editor  # reassign to make clear the editor type
 
         self.nodes_list: List[NodeGraphicItem] = list()
         self.segments_list: List[MapLineSegment] = list()
         self.enabled = True
-        self.original = True
+        self.original = True  # TODO: Que es esto?
 
     def setWidthScale(self, val: float):
         """

{GridCal-5.1.21 → GridCal-5.1.23}/GridCal/Gui/Diagrams/MapWidget/Substation/substation_graphic_item.py

@@ -18,8 +18,8 @@ from __future__ import annotations
 from typing import List, TYPE_CHECKING, Tuple
 from PySide6 import QtWidgets
 from PySide6.QtWidgets import (QApplication, QMenu, QGraphicsSceneContextMenuEvent, QGraphicsSceneMouseEvent,
-                               QGraphicsRectItem, QGraphicsEllipseItem)
-from PySide6.QtCore import Qt, QPointF, QPoint
+                               QGraphicsRectItem)
+from PySide6.QtCore import Qt, QPointF
 from PySide6.QtGui import QBrush, QColor, QCursor
 from GridCal.Gui.Diagrams.MapWidget.Substation.node_template import NodeTemplate
 from GridCal.Gui.GuiFunctions import add_menu_entry
@@ -88,7 +88,9 @@ class SubstationGraphicItem(QGraphicsRectItem, NodeTemplate):
         # self.resize(r)
         self.setAcceptHoverEvents(True)  # Enable hover events for the item
         # self.setFlag(QtWidgets.QGraphicsItem.GraphicsItemFlag.ItemIsMovable)  # Allow moving the node
-        self.setFlag(self.GraphicsItemFlag.ItemIsSelectable)  # Allow selecting the node
+        self.setFlag(
+            self.GraphicsItemFlag.ItemIsSelectable | QGraphicsRectItem.ItemIsMovable)  # Allow selecting the node
+
         self.setCursor(QCursor(Qt.PointingHandCursor))
 
         # Create a pen with reduced line width
@@ -136,25 +138,15 @@ class SubstationGraphicItem(QGraphicsRectItem, NodeTemplate):
         for i, vl_graphics in enumerate(sorted_objects):
             vl_graphics.setZValue(i)
 
-    def updatePosition(self) -> None:
-        """
-
-        :return: 
-        """
-        real_position = self.pos()
-        center_point = self.getPos()
-        # self.x = center_point.x() + real_position.x()
-        # self.y = center_point.y() + real_position.y()
-        self.needsUpdate = True
-
-    def updateDiagram(self):
+    def update_diagram(self):
         """
-        
+        Updates the element position in the diagram (to save)
         :return: 
         """
         lat, long = self.editor.to_lat_lon(self.rect().x(), self.rect().y())
 
-        # print(f'Updating SE position id:{self.api_object.idtag}, lat:{lat}, lon:{long}')
+        self.lat = lat
+        self.lon = long
 
         self.editor.update_diagram_element(device=self.api_object,
                                            latitude=lat,
@@ -163,8 +155,8 @@ class SubstationGraphicItem(QGraphicsRectItem, NodeTemplate):
 
     def get_center_pos(self) -> QPointF:
         """
-
-        :return:
+        Get the center position
+        :return: QPointF
         """
         x = self.rect().x() + self.rect().width() / 2
         y = self.rect().y() + self.rect().height() / 2
@@ -186,16 +178,16 @@ class SubstationGraphicItem(QGraphicsRectItem, NodeTemplate):
             for vl_graphics in self.voltage_level_graphics:
                 vl_graphics.center_on_substation()
 
-            self.updateDiagram()  # always update
+            self.update_diagram()  # always update
 
     def mousePressEvent(self, event: QGraphicsSceneMouseEvent):
         """
         Event handler for mouse press events.
         """
         super().mousePressEvent(event)
-        selected_items = self.editor.map.view._scene.selectedItems()
-        if len(selected_items) < 2:
-            self.setSelected(True)
+        # selected_items = self.editor.map.view.selected_items()
+        # if len(selected_items) < 2:
+        self.setSelected(True)
 
         event.setAccepted(True)
         self.editor.map.view.disableMove = True
@@ -211,14 +203,13 @@ class SubstationGraphicItem(QGraphicsRectItem, NodeTemplate):
                                              DeviceType.ZoneDevice: self.editor.circuit.get_zones(),
                                          })
 
-
     def mouseReleaseEvent(self, event: QGraphicsSceneMouseEvent):
         """
         Event handler for mouse release events.
         """
         # super().mouseReleaseEvent(event)
         self.editor.disableMove = True
-        self.updateDiagram()  # always update
+        self.update_diagram()  # always update
         print("SE mouse release")
 
     def hoverEnterEvent(self, event: QtWidgets.QGraphicsSceneHoverEvent) -> None:
@@ -252,7 +243,7 @@ class SubstationGraphicItem(QGraphicsRectItem, NodeTemplate):
                        function_ptr=self.add_voltage_level)
 
         add_menu_entry(menu=menu,
-                       text="Create line",
+                       text="Create line from here",
                        icon_path="",
                        function_ptr=self.create_new_line)
 
@@ -276,15 +267,13 @@ class SubstationGraphicItem(QGraphicsRectItem, NodeTemplate):
                        icon_path="",
                        function_ptr=self.new_substation_diagram)
 
-
-
         menu.exec_(event.screenPos())
 
     def create_new_line(self):
         """
         Create a new line in the map wizard
         """
-        self.editor.createNewLineWizard()
+        self.editor.create_new_line_wizard()
 
     def add_function(self):
         """
@@ -319,7 +308,7 @@ class SubstationGraphicItem(QGraphicsRectItem, NodeTemplate):
 
         pass
 
-    def remove_function(self):
+    def remove_function(self) -> None:
         """
         Function to be called when Action 1 is selected.
         """

{GridCal-5.1.21 → GridCal-5.1.23}/GridCal/Gui/Diagrams/MapWidget/Tiles/tiles.py

@@ -23,6 +23,7 @@ from GridCal.Gui.Diagrams.MapWidget.Tiles.tile_worker import TileWorker
 def log(val: str):
     print(val)
 
+
 # # set how old disk-cache tiles can be before we re-request them from the
 # # server.  this is the number of days old a tile is before we re-request.
 # # if 'None', never re-request tiles after first satisfied request.

{GridCal-5.1.21 → GridCal-5.1.23}/GridCal/Gui/Diagrams/MapWidget/grid_map_widget.py

@@ -56,6 +56,7 @@ import GridCalEngine.Devices.Diagrams.palettes as palettes
 from GridCal.Gui.Diagrams.graphics_manager import ALL_MAP_GRAPHICS
 from GridCal.Gui.Diagrams.MapWidget.Tiles.tiles import Tiles
 from GridCal.Gui.Diagrams.base_diagram_widget import BaseDiagramWidget
+from GridCal.Gui.messages import error_msg
 
 MAP_BRANCH_GRAPHIC_TYPES = Union[
     MapAcLine, MapDcLine, MapHvdcLine, MapFluidPathLine
@@ -457,53 +458,60 @@ class GridMapWidget(BaseDiagramWidget):
         if it1 == it2:
             return 0
 
-        newline = Line()
-        newline.set_data_from(it1.line_container.api_object)
+        new_line = Line()
+        new_line.set_data_from(it1.line_container.api_object)
         # ln1 = self.api_object.copy()
 
-        better_first, better_second, busfrom, busto = compare_options(it1, it2)
+        better_first, better_second, bus_from, bus_to = compare_options(it1, it2)
 
         first_list = better_first.line_container.api_object.locations.data
         second_list = better_second.line_container.api_object.locations.data
 
-        newline.locations.data = first_list + second_list
+        new_line.locations.data = first_list + second_list
 
-        newline.bus_from = busfrom
-        newline.bus_to = busto
+        new_line.bus_from = bus_from
+        new_line.bus_to = bus_to
 
         idx = 0
         for nod in better_first.line_container.nodes_list:
-            newline.locations.data[idx].lat = nod.lat
-            newline.locations.data[idx].long = nod.lon
+            new_line.locations.data[idx].lat = nod.lat
+            new_line.locations.data[idx].long = nod.lon
             idx = idx + 1
 
         for nod in better_second.line_container.nodes_list:
-            newline.locations.data[idx].lat = nod.lat
-            newline.locations.data[idx].long = nod.lon
+            new_line.locations.data[idx].lat = nod.lat
+            new_line.locations.data[idx].long = nod.lon
             idx = idx + 1
 
-        newL = self.add_api_line(newline, original=False)
+        self.add_api_line(new_line, original=False)
+        self.circuit.add_line(new_line)
 
         better_first.line_container.disable_line()
         better_second.line_container.disable_line()
 
-    def createNewLineWizard(self):
+    def get_selected_substations(self) -> List[SubstationGraphicItem]:
+        """
+        Get the selected substations graphics
+        :return: List[SubstationGraphicItem]
+        """
+        return [s for s in self.map.view.selected_items() if isinstance(s, SubstationGraphicItem)]
+
+    def create_new_line_wizard(self):
         """
         Create a new line in the map with dialogues
         """
 
-        selected_items = self.map.view._scene.selectedItems()
-        selectedItems = []
-        for item in selected_items:
-            selectedItems.append(item)
+        selected_items = self.get_selected_substations()
 
-        if len(selectedItems) < 2:
-            return 0
+        if len(selected_items) != 2:
+            error_msg(text="Please select two substations", title="Create new line")
+            return None
 
-        it1: SubstationGraphicItem = selectedItems[0]
-        it2: SubstationGraphicItem = selectedItems[1]
+        it1: SubstationGraphicItem = selected_items[0]
+        it2: SubstationGraphicItem = selected_items[1]
 
         if it1 == it2:
+            error_msg(text="Somehow the two substations are the same :(", title="Create new line")
             return None
 
         dialog = NewMapLineDialogue(grid=self.circuit, se_from=it1.api_object, se_to=it2.api_object)
@@ -512,8 +520,12 @@ class GridMapWidget(BaseDiagramWidget):
             bus1 = dialog.bus_from()
             bus2 = dialog.bus_to()
             if bus1 is not None and bus2 is not None:
-                newline = Line(bus_from=bus1, bus_to=bus2)
-                self.add_api_line(newline, original=True)
+                new_line = Line(bus_from=bus1, bus_to=bus2)
+                self.add_api_line(new_line, original=True)
+                self.circuit.add_line(new_line)
+            else:
+                error_msg(text="Some of the buses was None :(", title="Create new line")
+                return None
 
     def removeNode(self, node: NodeGraphicItem):
         """
@@ -570,8 +582,7 @@ class GridMapWidget(BaseDiagramWidget):
         # create the nodes
         line_container.draw_all()
 
-        # there is not need to add to the scene
-
+        # there is nt need to add to the scene
         return line_container
 
     def add_api_dc_line(self, api_object: DcLine, original: bool = True) -> MapDcLine:
@@ -752,24 +763,16 @@ class GridMapWidget(BaseDiagramWidget):
         for idtag, graphic_object in dev_dict.items():
             graphic_object.sort_voltage_levels()
 
-    def add_object_to_the_schematic(
-            self,
-            elm: ALL_DEV_TYPES,
-            injections_by_bus: Union[None, Dict[Bus, Dict[DeviceType, List[INJECTION_DEVICE_TYPES]]]] = None,
-            injections_by_fluid_node: Union[None, Dict[FluidNode, Dict[DeviceType, List[FLUID_TYPES]]]] = None,
-            injections_by_cn: Union[None, Dict[Bus, Dict[DeviceType, List[INJECTION_DEVICE_TYPES]]]] = None,
-            logger: Logger = Logger()):
+    def add_object_to_the_schematic(self, elm: ALL_DEV_TYPES, logger: Logger = Logger()):
         """
 
         :param elm:
-        :param injections_by_bus:
-        :param injections_by_fluid_node:
-        :param injections_by_cn:
         :param logger:
         :return:
         """
+        graphic_obj = self.graphics_manager.query(elm=elm)
 
-        if self.graphics_manager.query(elm=elm) is None:
+        if graphic_obj is None:
 
             if isinstance(elm, Substation):
                 self.add_api_substation(api_object=elm,
@@ -797,31 +800,35 @@ class GridMapWidget(BaseDiagramWidget):
                                             lon=substation_graphics.lon,
                                             lat=substation_graphics.lat)
 
-            elif isinstance(elm, FluidNode):
-
-                if injections_by_fluid_node is None:
-                    injections_by_fluid_node = self.circuit.get_injection_devices_grouped_by_fluid_node()
-
-                # TODO: maybe new thing?
-                self.add_api_fluid_node(node=elm,
-                                        injections_by_tpe=injections_by_fluid_node.get(elm, dict()))
-
             elif isinstance(elm, Line):
-                self.add_api_line(elm)
+                line_container = self.add_api_line(elm)
+                for segment in line_container.segments_list:
+                    self.add_to_scene(graphic_object=segment)
 
             elif isinstance(elm, DcLine):
-                self.add_api_dc_line(elm)
+                line_container = self.add_api_dc_line(elm)
+                for segment in line_container.segments_list:
+                    self.add_to_scene(graphic_object=segment)
 
             elif isinstance(elm, HvdcLine):
-                self.add_api_hvdc_line(elm)
+                line_container = self.add_api_hvdc_line(elm)
+                for segment in line_container.segments_list:
+                    self.add_to_scene(graphic_object=segment)
 
             elif isinstance(elm, FluidPath):
-                self.add_api_fluid_path(elm)
+                line_container = self.add_api_fluid_path(elm)
+                for segment in line_container.segments_list:
+                    self.add_to_scene(graphic_object=segment)
 
             else:
-                pass
+                logger.add_warning("Unsupported device class",
+                                   device_class=elm.device_type.value,
+                                   device=elm.name)
 
         else:
+
+            self.add_to_scene(graphic_obj)
+
             logger.add_warning("Device already added", device_class=elm.device_type.value, device=elm.name)
 
     def dropEvent(self, event: QDropEvent):
@@ -842,7 +849,6 @@ class GridMapWidget(BaseDiagramWidget):
             # print(f"Dropped at x:{x0}, y:{y0}, lat:{lat}, lon:{lon}")
 
             if obj_type == self.library_model.get_substation_mime_data():
-
                 api_object = Substation(name=f"Substation {self.circuit.get_substation_number()}",
                                         latitude=lat,
                                         longitude=lon)

{GridCal-5.1.21 → GridCal-5.1.23}/GridCal/Gui/Diagrams/MapWidget/map_widget.py

@@ -30,12 +30,12 @@ ygeo: latitude
 from __future__ import annotations
 from typing import List, Union, Tuple, Callable, TYPE_CHECKING
 from enum import Enum
-from PySide6.QtCore import Qt, QTimer, QEvent, QPointF, QRectF
+from PySide6.QtCore import Qt, QTimer, QEvent, QPointF
 from PySide6.QtGui import (QPainter, QColor, QPixmap, QCursor,
                            QMouseEvent, QKeyEvent, QWheelEvent,
                            QResizeEvent, QEnterEvent, QPaintEvent, QDragEnterEvent, QDragMoveEvent, QDropEvent)
 from PySide6.QtWidgets import (QSizePolicy, QWidget, QGraphicsScene, QGraphicsView, QVBoxLayout,
-                               QGraphicsSceneMouseEvent)
+                               QGraphicsSceneMouseEvent, QGraphicsItem)
 
 from GridCal.Gui.Diagrams.MapWidget.Tiles.tiles import Tiles
 
@@ -83,7 +83,7 @@ class MapScene(QGraphicsScene):
         :param event:
         :return:
         """
-        print(f"Scene released at {event.scenePos()}")
+        # print(f"Scene released at {event.scenePos()}")
         super().mouseReleaseEvent(event)
 
     def mouseMoveEvent(self, event: QGraphicsSceneMouseEvent) -> None:
@@ -134,6 +134,13 @@ class MapView(QGraphicsView):
 
         self.scale(initial_zoom_factor, initial_zoom_factor)
 
+    def selected_items(self) -> List[QGraphicsItem]:
+        """
+        Get the selected items
+        :return:
+        """
+        return self._scene.selectedItems()
+
     def mousePressEvent(self, event: QMouseEvent):
         """
 
@@ -489,7 +496,7 @@ class MapWidget(QWidget):
                 while abs(self.view.schema_zoom - 0.015625) > 0.00001:
                     self.view.schema_zoom = self.view.schema_zoom / self.view.map_widget.zoom_factor
                     self.view.scale(1.0 / self.view.map_widget.zoom_factor, 1.0 / self.view.map_widget.zoom_factor)
-                self.GotoLevelAndPosition(level=0, longitude=None, latitude=None)
+                self.GotoLevelAndPosition(level=0, longitude=0, latitude=0)
 
     @property
     def max_level(self):
@@ -606,6 +613,7 @@ class MapWidget(QWidget):
 
         elif b == Qt.MouseButton.LeftButton:
             self.left_mbutton_down = True
+            self.editor.object_editor_table.setModel(None)
 
         elif b == Qt.MouseButton.MiddleButton:
             self.mid_mbutton_down = True
@@ -614,7 +622,8 @@ class MapWidget(QWidget):
             self.right_mbutton_down = True
 
         else:
-            print('mousePressEvent: unknown button')
+            pass
+            # print('mousePressEvent: unknown button')
 
     def mouseReleaseEvent(self, event: QMouseEvent) -> None:
         """
@@ -657,7 +666,8 @@ class MapWidget(QWidget):
             self.right_mbutton_down = False
 
         else:
-            print('mouseReleaseEvent: unknown button')
+            pass
+            # print('mouseReleaseEvent: unknown button')
 
     def mouseDoubleClickEvent(self, event: QMouseEvent):
         """
@@ -675,7 +685,8 @@ class MapWidget(QWidget):
         elif b == Qt.RightButton:
             pass
         else:
-            print('mouseDoubleClickEvent: unknown button')
+            pass
+            # print('mouseDoubleClickEvent: unknown button')
 
     def mouseMoveEvent(self, event: QMouseEvent):
         """
@@ -1816,11 +1827,11 @@ class MapWidget(QWidget):
         exist in the new tileset.
         """
 
-        print('ChangeTileSet: tile_src=%s' % str(tile_src))
+        # print('ChangeTileSet: tile_src=%s' % str(tile_src))
 
         # get level and geo position of view centre
         level, longitude, latitude = self.get_level_and_position()
-        print('level=%s, geo=(%s, %s)' % (str(level), str(longitude), str(latitude)))
+        # print('level=%s, geo=(%s, %s)' % (str(level), str(longitude), str(latitude)))
 
         # remember old tileset
         old_tileset = self.tile_src

{GridCal-5.1.21 → GridCal-5.1.23}/GridCal/Gui/Diagrams/SchematicWidget/Branches/transformer2w_graphics.py

@@ -24,7 +24,7 @@ from GridCal.Gui.messages import yes_no_question
 from GridCal.Gui.Diagrams.SchematicWidget.Branches.transformer_editor import TransformerEditor
 from GridCal.Gui.Diagrams.SchematicWidget.Branches.transformer_taps_editor import TransformerTapsEditor
 from GridCalEngine.Devices.Branches.transformer import Transformer2W, TransformerType
-from GridCalEngine.enumerations import DeviceType
+from GridCalEngine.enumerations import DeviceType, TapModuleControl
 
 if TYPE_CHECKING:  # Only imports the below statements during type checking
     from GridCal.Gui.Diagrams.SchematicWidget.schematic_widget import SchematicWidget
@@ -107,6 +107,16 @@ class TransformerGraphicItem(LineGraphicTemplateItem):
                            function_ptr=self.tap_down,
                            icon_path=":/Icons/icons/down.svg")
 
+            add_menu_entry(menu=menu,
+                           text="Control V from",
+                           function_ptr=self.control_v_from,
+                           icon_path=":/Icons/icons/edit.svg")
+
+            add_menu_entry(menu=menu,
+                           text="Control V to",
+                           function_ptr=self.control_v_to,
+                           icon_path=":/Icons/icons/edit.svg")
+
             menu.addSeparator()
 
             add_menu_entry(menu=menu,
@@ -240,3 +250,19 @@ class TransformerGraphicItem(LineGraphicTemplateItem):
         Set one tap down
         """
         self.api_object.tap_down()
+
+    def control_v_from(self):
+        """
+
+        :return:
+        """
+        self.api_object.regulation_bus = self.api_object.bus_from
+        self.api_object.tap_module_control_mode = TapModuleControl.Vm
+
+    def control_v_to(self):
+        """
+
+        :return:
+        """
+        self.api_object.regulation_bus = self.api_object.bus_to
+        self.api_object.tap_module_control_mode = TapModuleControl.Vm

{GridCal-5.1.21 → GridCal-5.1.23}/GridCal/Gui/Diagrams/SchematicWidget/Branches/upfc_graphics.py

@@ -21,6 +21,7 @@ from PySide6.QtWidgets import QMenu
 from GridCal.Gui.GuiFunctions import add_menu_entry
 from GridCal.Gui.Diagrams.SchematicWidget.terminal_item import BarTerminalItem
 from GridCalEngine.Devices.Branches.upfc import UPFC
+from GridCalEngine.enumerations import TapModuleControl
 from GridCal.Gui.Diagrams.SchematicWidget.Branches.line_graphics_template import LineGraphicTemplateItem
 
 if TYPE_CHECKING:  # Only imports the below statements during type checking
@@ -90,6 +91,18 @@ class UpfcGraphicItem(LineGraphicTemplateItem):
 
             menu.addSeparator()
 
+            add_menu_entry(menu=menu,
+                           text="Control V from",
+                           function_ptr=self.control_v_from,
+                           icon_path=":/Icons/icons/edit.svg")
+
+            add_menu_entry(menu=menu,
+                           text="Control V to",
+                           function_ptr=self.control_v_to,
+                           icon_path=":/Icons/icons/edit.svg")
+
+            menu.addSeparator()
+
             ra6 = menu.addAction('Plot profiles')
             plot_icon = QIcon()
             plot_icon.addPixmap(QPixmap(":/Icons/icons/plot.svg"))
@@ -108,7 +121,22 @@ class UpfcGraphicItem(LineGraphicTemplateItem):
             ra5.setIcon(ra5_icon)
             ra5.triggered.connect(self.assign_status_to_profile)
 
-
             menu.exec_(event.screenPos())
         else:
             pass
+
+    def control_v_from(self):
+        """
+
+        :return:
+        """
+        self.api_object.regulation_bus = self.api_object.bus_from
+        self.api_object.tap_module_control_mode = TapModuleControl.Vm
+
+    def control_v_to(self):
+        """
+
+        :return:
+        """
+        self.api_object.regulation_bus = self.api_object.bus_to
+        self.api_object.tap_module_control_mode = TapModuleControl.Vm

{GridCal-5.1.21 → GridCal-5.1.23}/GridCal/Gui/Diagrams/SchematicWidget/Branches/vsc_graphics.py

@@ -21,6 +21,7 @@ from PySide6.QtWidgets import QMenu
 from GridCal.Gui.GuiFunctions import add_menu_entry
 from GridCal.Gui.Diagrams.SchematicWidget.terminal_item import BarTerminalItem, RoundTerminalItem
 from GridCalEngine.Devices.Branches.vsc import VSC
+from GridCalEngine.enumerations import TapModuleControl
 from GridCal.Gui.Diagrams.SchematicWidget.Branches.line_graphics_template import LineGraphicTemplateItem
 
 if TYPE_CHECKING:  # Only imports the below statements during type checking
@@ -95,6 +96,18 @@ class VscGraphicItem(LineGraphicTemplateItem):
 
             menu.addSeparator()
 
+            add_menu_entry(menu=menu,
+                           text="Control V from",
+                           function_ptr=self.control_v_from,
+                           icon_path=":/Icons/icons/edit.svg")
+
+            add_menu_entry(menu=menu,
+                           text="Control V to",
+                           function_ptr=self.control_v_to,
+                           icon_path=":/Icons/icons/edit.svg")
+
+            menu.addSeparator()
+
             ra6 = menu.addAction('Plot profiles')
             plot_icon = QIcon()
             plot_icon.addPixmap(QPixmap(":/Icons/icons/plot.svg"))
@@ -125,3 +138,19 @@ class VscGraphicItem(LineGraphicTemplateItem):
         """
 
         pass
+
+    def control_v_from(self):
+        """
+
+        :return:
+        """
+        self.api_object.regulation_bus = self.api_object.bus_from
+        self.api_object.tap_module_control_mode = TapModuleControl.Vm
+
+    def control_v_to(self):
+        """
+
+        :return:
+        """
+        self.api_object.regulation_bus = self.api_object.bus_to
+        self.api_object.tap_module_control_mode = TapModuleControl.Vm