GeneralManager 0.57.1__tar.gz → 0.57.3__tar.gz

{generalmanager-0.57.1/src/GeneralManager.egg-info → generalmanager-0.57.3}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: GeneralManager
-Version: 0.57.1
+Version: 0.57.3
 Summary: Modular Django-based data management framework with ORM, GraphQL, fine-grained permissions, rule validation, calculations and caching.
 Author-email: Tim Kleindick <tkleindick@yahoo.de>
 License: MIT License

{generalmanager-0.57.1 → generalmanager-0.57.3}/pyproject.toml

@@ -4,7 +4,7 @@ build-backend = "setuptools.build_meta"
 
 [project]
 name = "GeneralManager"
-version = "0.57.1"
+version = "0.57.3"
 description = "Modular Django-based data management framework with ORM, GraphQL, fine-grained permissions, rule validation, calculations and caching."
 readme = "README.md"
 authors = [{ name = "Tim Kleindick", email = "tkleindick@yahoo.de" }]

{generalmanager-0.57.1 → generalmanager-0.57.3/src/GeneralManager.egg-info}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: GeneralManager
-Version: 0.57.1
+Version: 0.57.3
 Summary: Modular Django-based data management framework with ORM, GraphQL, fine-grained permissions, rule validation, calculations and caching.
 Author-email: Tim Kleindick <tkleindick@yahoo.de>
 License: MIT License

{generalmanager-0.57.1 → generalmanager-0.57.3}/src/general_manager/api/graphql_search.py

@@ -69,6 +69,31 @@ GrapheneReadMapper = Callable[
 SearchResolverPayload = dict[str, object]
 SearchHitEntry = tuple[float | None, SearchHit, GeneralManager]
 SortableValue = float | datetime | str | None
+_BAD_USER_INPUT_CODE = "BAD_USER_INPUT"
+_PAGE_MUST_BE_POSITIVE = "page must be a positive integer."
+_PAGE_SIZE_MUST_BE_POSITIVE = "pageSize must be a positive integer."
+
+
+def _resolve_search_pagination(
+    page: int | None,
+    page_size: int | None,
+) -> tuple[int, int]:
+    """
+    Resolve omitted search pagination arguments and reject non-positive values.
+    """
+    current_page = 1 if page is None else page
+    limit = 10 if page_size is None else page_size
+    if current_page <= 0:
+        raise GraphQLError(
+            _PAGE_MUST_BE_POSITIVE,
+            extensions={"code": _BAD_USER_INPUT_CODE},
+        )
+    if limit <= 0:
+        raise GraphQLError(
+            _PAGE_SIZE_MUST_BE_POSITIVE,
+            extensions={"code": _BAD_USER_INPUT_CODE},
+        )
+    return current_page, limit
 
 
 # ---------------------------------------------------------------------------
@@ -803,15 +828,14 @@ def register_search_query(
         The resolver parses user filters, validates configured filter keys,
         searches each selected manager type, instantiates manager objects from
         hit identification, applies read permission filters/instance checks, and
-        returns paginated authorized manager instances. ``page`` and
-        ``page_size`` values that are ``None`` or falsey fall back to ``1`` and
-        ``10`` respectively. Backend raw payloads are collected once per backend
-        request in the ``raw`` list.
+        returns paginated authorized manager instances. Omitted ``page`` and
+        ``page_size`` values default to ``1`` and ``10`` respectively. Supplied
+        non-positive values raise a ``GraphQLError``. Backend raw payloads are
+        collected once per backend request in the ``raw`` list.
         """
         index_name = index or "global"
-        limit = page_size or 10
-        current_page = page or 1
-        offset = max(current_page - 1, 0) * limit
+        current_page, limit = _resolve_search_pagination(page, page_size)
+        offset = (current_page - 1) * limit
         parsed_filters = parse_search_filters(filters)
         if parsed_filters:
             try:

{generalmanager-0.57.1 → generalmanager-0.57.3}/src/general_manager/factory/auto_factory.py

@@ -105,12 +105,12 @@ class AutoFactory(DjangoModelFactory[modelsModel]):
 
     The factory inspects the bound ORM interface, fills missing model fields with
     generated values or declared defaults, applies many-to-many relations after
-    model construction, and wraps created objects back into GeneralManager
-    instances. Build strategy returns Django model instances; create strategy
-    returns manager wrappers. Subclasses are generated with an ORM interface that
-    provides ``handle_custom_fields()``, ``input_fields``,
-    ``format_identification()``, and ``_parent_class`` for created-object
-    wrapping.
+    saved creation, and wraps created objects back into GeneralManager instances.
+    Build strategy returns unsaved Django model instances and skips
+    many-to-many assignment; create strategy returns manager wrappers.
+    Subclasses are generated with an ORM interface that provides
+    ``handle_custom_fields()``, ``input_fields``, ``format_identification()``,
+    and ``_parent_class`` for created-object wrapping.
     """
 
     interface: type[OrmInterfaceBase[models.Model]]
@@ -127,14 +127,11 @@ class AutoFactory(DjangoModelFactory[modelsModel]):
         caller-supplied values already present in `params` win. factory_boy then
         dispatches to `_build()` or `_create()`, where many-to-many values are
         stripped from constructor kwargs and foreign-key/one-to-one values are
-        coerced before `_adjustmentMethod` is called. After model construction,
-        this hook applies many-to-many assignments from the original `params`
-        and wraps created models into manager instances for create strategy.
-
-        Many-to-many assignment is attempted for both build and create strategy.
-        Django requires saved instances for many-to-many `.set(...)`; therefore
-        build calls with explicit or generated many-to-many values are
-        unsupported and may raise Django's unsaved-instance relation error.
+        coerced before `_adjustmentMethod` is called. Create strategy then
+        applies many-to-many assignments from the original `params` to saved
+        models and wraps them into manager instances. Build strategy returns the
+        unsaved model instance(s) without attempting many-to-many assignment,
+        even when explicit or declared many-to-many values were supplied.
 
         Parameters:
             strategy (Literal["build", "create"]): "build" returns unsaved model instance(s); "create" saves model instance(s) and returns GeneralManager wrapper(s).
@@ -202,8 +199,10 @@ class AutoFactory(DjangoModelFactory[modelsModel]):
             for item in obj:
                 if not isinstance(item, models.Model):
                     raise InvalidGeneratedObjectError()
-                cls._handle_many_to_many_fields_after_creation(item, params)
-        else:
+            if strategy == "create":
+                for item in obj:
+                    cls._handle_many_to_many_fields_after_creation(item, params)
+        elif strategy == "create":
             cls._handle_many_to_many_fields_after_creation(obj, params)
         if strategy == "create":
             return cls._wrap_generated_objects(obj)
@@ -214,7 +213,11 @@ class AutoFactory(DjangoModelFactory[modelsModel]):
         cls, obj: models.Model, attrs: FactoryParams
     ) -> None:
         """
-        Assign related objects to many-to-many fields after creation/building.
+        Assign related objects to many-to-many fields after saved creation.
+
+        Build strategy returns unsaved models and must skip this method because
+        Django many-to-many managers require the source instance to have a
+        primary key before `.set(...)` can be used.
 
         Parameters:
             obj (models.Model): Instance whose many-to-many relations should be populated.