BmorricalDjangoWorkflows 2.1.2__tar.gz → 2.1.3__tar.gz

{bmorricaldjangoworkflows-2.1.2 → bmorricaldjangoworkflows-2.1.3}/BmorricalDjangoWorkflows.egg-info/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: BmorricalDjangoWorkflows
-Version: 2.1.2
+Version: 2.1.3
 Summary: Reusable Django Workflows
 Home-page: https://github.com/Bmorrical/django-workflows
 Author: Bradley Morrical

{bmorricaldjangoworkflows-2.1.2 → bmorricaldjangoworkflows-2.1.3}/PKG-INFO

@@ -1,6 +1,6 @@
 Metadata-Version: 2.4
 Name: BmorricalDjangoWorkflows
-Version: 2.1.2
+Version: 2.1.3
 Summary: Reusable Django Workflows
 Home-page: https://github.com/Bmorrical/django-workflows
 Author: Bradley Morrical

bmorricaldjangoworkflows-2.1.3/VERSION

@@ -0,0 +1 @@
+2.1.3

{bmorricaldjangoworkflows-2.1.2 → bmorricaldjangoworkflows-2.1.3}/django_workflows/users/services/auth_flow.py

@@ -609,11 +609,9 @@ def update_user(user: Any, data: dict[str, Any]) -> UserUpdateResult:
             )
 
     email_value = data.get("email")
-    username_value = data.get("username")
-    if email_value is not None or username_value is not None:
-        next_email = email_value if email_value is not None else username_value
-        user.username = next_email
-        user.email = next_email
+    if email_value is not None:
+        user.username = email_value
+        user.email = email_value
         processed_update = True
         user_fields_updated = True
 

{bmorricaldjangoworkflows-2.1.2 → bmorricaldjangoworkflows-2.1.3}/django_workflows/users/views.py

@@ -276,8 +276,8 @@ class UserListView(APIView):
 
 # Route: GET /user/
 # Route: PATCH /user/
-# PATCH body params: optional id, username, email, firstName, lastName, password, isActive, optional groups as [{name, enabled}]
-# Notes: when id is omitted the authenticated user is updated; updating another user by id requires the User Manager group
+# PATCH body params: optional id, email, firstName, lastName, password, isActive, optional groups as [{name, enabled}]
+# Notes: when id is omitted the authenticated user is updated; updating another user by id requires the User Manager group; username stays aligned to email
 class UserDetailView(APIView):
     permission_classes = [IsAuthenticated]
 

{bmorricaldjangoworkflows-2.1.2 → bmorricaldjangoworkflows-2.1.3}/tests/test_auth_flow.py

@@ -1526,6 +1526,10 @@ class AuthFlowTests(TestCase):
         self.assertTrue(result.success)
         self.assertEqual(user.first_name, "Updated")
         self.assertEqual(user.last_name, "Person")
+        self.assertEqual(user.username, "member@example.com")
+        self.assertEqual(user.email, "member@example.com")
+        user.set_password.assert_not_called()
+        user.save.assert_called_once()
         mock_sync_user_groups.assert_not_called()
 
     @patch.object(auth_flow, "_get_group_model")
@@ -1607,6 +1611,26 @@ class AuthFlowTests(TestCase):
         self.assertEqual(result.message, "groups must be a list of objects with name and enabled.")
         user.save.assert_not_called()
 
+    def test_update_user_ignores_username_when_email_is_omitted(self):
+        user = SimpleNamespace(
+            username="member@example.com",
+            email="member@example.com",
+            first_name="Member",
+            last_name="User",
+            is_active=True,
+            groups=SimpleNamespace(add=MagicMock(), remove=MagicMock()),
+            save=MagicMock(),
+            set_password=MagicMock(),
+        )
+
+        result = auth_flow.update_user(user, {"username": "updated@example.com"})
+
+        self.assertFalse(result.success)
+        self.assertEqual(result.message, "No valid fields provided.")
+        self.assertEqual(user.username, "member@example.com")
+        self.assertEqual(user.email, "member@example.com")
+        user.save.assert_not_called()
+
     def test_update_user_returns_conflict_when_save_hits_integrity_error(self):
         user = SimpleNamespace(
             username="member@example.com",
@@ -1623,7 +1647,6 @@ class AuthFlowTests(TestCase):
             user,
             {
                 "email": "taken@example.com",
-                "username": "taken@example.com",
             },
         )
 

{bmorricaldjangoworkflows-2.1.2 → bmorricaldjangoworkflows-2.1.3}/tests/test_user_views.py

@@ -373,7 +373,6 @@ class PackageUserDetailViewTest(SimpleTestCase):
             data={
                 "id": 9,
                 "email": "target@example.com",
-                "username": "target@example.com",
                 "isActive": 1,
                 "groups": [{"name": "Time Entry User", "enabled": True}],
             },
@@ -402,7 +401,6 @@ class PackageUserDetailViewTest(SimpleTestCase):
             data={
                 "id": 9,
                 "email": "member@example.com",
-                "username": "member@example.com",
                 "firstName": "Updated",
             },
         )

bmorricaldjangoworkflows-2.1.2/VERSION

@@ -1 +0,0 @@
-2.1.2