spiderly 19.10.0 → 19.10.1

package/agent/docs/angular-customization/index.md

@@ -205,6 +205,8 @@ new Column({ field: 'total', name: 'Total', filterType: 'numeric',
 
 It receives a `CellClickEvent` — `{ id, field, row, value, displayValue, element, originalEvent }`, where `value` is the raw cell value and `displayValue` is the formatted text shown. Only columns that set it become clickable (they get a `cursor`/hover affordance), and the click stops propagation so it does **not** also trigger `navigateOnRowClick`. Anchor overlays with `element` — it's the clicked `<td>`, captured synchronously, so it stays valid inside an async handler (`originalEvent.currentTarget` is null once dispatch ends). Not applied to editable cells. (Reusing one popover across rows is the `show()` + `align()` case shown in the snippet above — bare `show()` swaps content but won't move an already-open panel.)
 
+Style the popover's content at your component's SCSS **top level**, never nested under `:host` — PrimeNG appends the open popover to `document.body`, where `:host`-scoped rules (compiled to `[_nghost] … [_ngcontent]` descendant selectors) silently stop matching; top-level rules keep the `[_ngcontent]` scoping that travels with the moved nodes.
+
 ### Custom Toolbar Actions
 
 Project an `<ng-template spiderlyDataTableActions>` to add your own buttons (or any markup) to the table's toolbar, alongside the built-in Clear Filters / Export to Excel / Reload / Delete Selected buttons. Import `SpiderlyDataTableActionsDirective` in the consuming component.

package/agent/skills/spiderly-upgrade/SKILL.md

@@ -31,7 +31,12 @@ Follow Spiderly's fail-loudly convention: every refused-to-start condition exits
 
    > Working tree must be clean before upgrading. Commit or stash your changes first — the upgrade will make many edits, and a clean tree is your `git restore .` safety net.
 
-4. **Detect current version.** Read all `Spiderly.*` `PackageReference` `Version=` values across every csproj, plus the `"spiderly"` value in `Frontend/package.json`. They should agree. If they drift, list the values and ask the user which to treat as "current".
+4. **Detect current version.** Versions live in one of two places — check for **Central Package Management first**:
+
+   - **CPM (`Directory.Packages.props` exists next to or above the csprojs):** versions are `<PackageVersion Include="Spiderly.X" Version="..." />` there, and the csprojs carry **versionless** `<PackageReference Include="Spiderly.X" />`. Reading `Version=` off the csprojs finds nothing — don't conclude "not a Spiderly app".
+   - **Classic:** `Version=` on each csproj's `PackageReference`.
+
+   Read whichever applies, plus the `"spiderly"` value in `Frontend/package.json`. They should agree. If they drift, list the values and ask the user which to treat as "current". Record which layout you found — Step 6 bumps the same place.
 
 5. **Multi-solution monorepo.** If multiple Backend dirs (each with their own Spiderly refs) exist, ask the user which one to upgrade. One app per invocation.
 
@@ -39,7 +44,7 @@ Follow Spiderly's fail-loudly convention: every refused-to-start condition exits
 
 - If arg is `latest` or omitted: WebFetch `https://api.nuget.org/v3-flatcontainer/spiderly.shared/index.json`, parse the `versions` array, pick the highest stable (no `-` suffix), confirm with the user.
 - Otherwise validate the arg as `X.Y.Z` (or `X.Y.Z-preview.N` if the user is explicitly opting into a preview — warn that preview release notes are usually thin).
-- Reject downgrades: if target < current, exit `Downgrades are not supported. To downgrade, edit Spiderly.* PackageReference Version= attributes and the "spiderly" npm dep manually, then run dotnet restore and npm install.`
+- Reject downgrades: if target < current, exit `Downgrades are not supported. To downgrade, edit the Spiderly.* versions (Directory.Packages.props under CPM, otherwise the csproj PackageReference Version= attributes) and the "spiderly" npm dep manually, then run dotnet restore and npm install.`
 - Reject no-op: if target == current, exit `Already on {version}.`
 
 ## Step 3 — Fetch what changed
@@ -94,7 +99,7 @@ Code edits (N items affect you):
 Manual steps after upgrade:
   - <step the agent can't do for you>
 
-Version bumps: Spiderly.*  19.5.0 → 21.2.0  (4 csproj + Frontend/package.json[ + .claude/settings.json legacy-plugin removal])
+Version bumps: Spiderly.*  19.5.0 → 21.2.0  (Directory.Packages.props | 4 csproj + Frontend/package.json[ + .claude/settings.json legacy-plugin removal])
 
 After approval: apply → bump → migrate guidance + config → restore + install (parallel) → build → agent-sync. Up to 2 build-fix retries on failure.
 ```
@@ -108,7 +113,19 @@ Present the plan and ask the user explicitly. Don't proceed without a clear yes.
 In this order. A failure at any step is a hard stop until the recovery procedure in Step 7.
 
 1. **Code edits.** Apply each plan item via Edit. Read each target file first.
-2. **Version bumps.** Iterate the csproj list cached in Step 1: rewrite every `<PackageReference Include="Spiderly.X" Version="OLD" />` to the new version. Rewrite `"spiderly": "OLD"` in `Frontend/package.json`. Don't re-glob.
+2. **Version bumps.** Bump the layout detected in Step 1.4:
+
+   - **CPM:** rewrite each `<PackageVersion Include="Spiderly.X" Version="OLD" />` in `Directory.Packages.props`. The csprojs need no edit — that is the point of CPM, and adding a `Version=` there is an error (`NU1008`).
+   - **Classic:** iterate the csproj list cached in Step 1 and rewrite every `<PackageReference Include="Spiderly.X" Version="OLD" />`.
+
+   Then rewrite `"spiderly": "OLD"` in `Frontend/package.json`. Don't re-glob.
+
+   **If the app commits `packages.lock.json` files** (`RestorePackagesWithLockFile`), the restore in item 5 updates them — but only for the current OS's resolution graph. Apps whose CI restores in `--locked-mode` on linux must regenerate the locks under the **linux SDK image**, or a macOS-only regeneration ships a lock that CI rejects. Add it to the manual steps:
+
+   ```bash
+   docker run --rm -v "$PWD:/src" -v <cache-volume>:/root/.nuget/packages -w /src \
+     mcr.microsoft.com/dotnet/sdk:<version> dotnet restore <Solution>.sln --force
+   ```
 3. **Migrate agent guidance off the legacy plugin.** Spiderly's AI-agent guidance now ships *inside* the `spiderly` npm package (projected by `spiderly agent-sync` in item 7 below), replacing the old `spiderly@spiderly` Claude Code plugin. If `.claude/settings.json` contains `extraKnownMarketplaces.spiderly` and/or `enabledPlugins."spiderly@spiderly"`, remove just those keys (leave any other settings intact; delete the file only if it becomes an empty `{}`). No settings file or no spiderly entries → skip.
 4. **Migrate `spiderly.json` → `.spiderly/config.json`.** Recent Spiderly moved the generator/api config out of a root `spiderly.json` into `.spiderly/config.json`. If the app has a `spiderly.json` registered via `<AdditionalFiles Include="spiderly.json" />`, `git mv` it to `.spiderly/config.json` and rewrite that csproj line to `<AdditionalFiles Include=".spiderly/config.json" />`. No `spiderly.json` → skip.
 5. **Restore packages in parallel.** Same message, two Bash calls: `dotnet restore` in Backend and `npm install` in Frontend. They share no locks. If either fails, surface the actual error and exit.

package/fesm2022/spiderly.mjs

@@ -5421,6 +5421,8 @@ const unauthorizedInterceptor = (req, next) => {
         if (!config.production) {
             console.error(err);
         }
+        // TODO: type this as an ApiError interface (TS mirror of ApiErrorDTO, next to errors/api-error-codes.ts)
+        // so message/errorCode/traceId reads of the cross-language contract are compile-checked, not conventional.
         let errorResponse = err.error;
         if (request.responseType !== 'json' && typeof err.error === 'string') {
             try {
@@ -5430,31 +5432,36 @@ const unauthorizedInterceptor = (req, next) => {
                 errorResponse = null;
             }
         }
+        // ApiErrorDTO.traceId is present only on reportable errors, so this is a no-op everywhere else —
+        // the server decides which responses carry a support reference, never this status-code chain.
+        const withReference = (detail) => errorResponse?.traceId
+            ? `${detail} ${translocoService.translate('ErrorReference', { traceId: errorResponse.traceId })}`
+            : detail;
         if (err.status === 0) {
             // Server unreachable; defer so the message isn't lost during a shutdown/refresh race.
             setTimeout(() => {
-                messageService.warningMessage(translocoService.translate('ServerLostConnectionDetails'), translocoService.translate('ServerLostConnectionTitle'));
+                messageService.warningMessage(withReference(translocoService.translate('ServerLostConnectionDetails')), translocoService.translate('ServerLostConnectionTitle'));
             }, 100);
         }
         else if (err.status === 400) {
-            messageService.warningMessage(errorResponse?.message ?? translocoService.translate('BadRequestDetails'), translocoService.translate('Warning'));
+            messageService.warningMessage(withReference(errorResponse?.message ?? translocoService.translate('BadRequestDetails')), translocoService.translate('Warning'));
         }
         else if (err.status === 401) {
             if (errorResponse?.errorCode === ApiErrorCodes.InvalidToken) {
                 authService.clearSession(); // expired/invalid session — drop it; guards send the user to login
             }
             else {
-                messageService.warningMessage(errorResponse?.message ?? translocoService.translate('LoginRequired'), translocoService.translate('Warning'));
+                messageService.warningMessage(withReference(errorResponse?.message ?? translocoService.translate('LoginRequired')), translocoService.translate('Warning'));
             }
         }
         else if (err.status === 403) {
-            messageService.warningMessage(translocoService.translate('PermissionErrorDetails'), translocoService.translate('PermissionErrorTitle'));
+            messageService.warningMessage(withReference(translocoService.translate('PermissionErrorDetails')), translocoService.translate('PermissionErrorTitle'));
         }
         else if (err.status === 404) {
-            messageService.warningMessage(translocoService.translate('NotFoundDetails'), translocoService.translate('NotFoundTitle'));
+            messageService.warningMessage(withReference(translocoService.translate('NotFoundDetails')), translocoService.translate('NotFoundTitle'));
         }
         else {
-            messageService.errorMessage(translocoService.translate('UnexpectedErrorDetails'), translocoService.translate('UnexpectedErrorTitle'));
+            messageService.errorMessage(withReference(translocoService.translate('UnexpectedErrorDetails')), translocoService.translate('UnexpectedErrorTitle'));
         }
     };
     return next(req).pipe(catchError((err) => {