solidity-argus 0.5.10 → 0.6.1

package/src/tools/slither-tool.ts

@@ -1,5 +1,13 @@
 import { createHash } from "node:crypto"
-import { existsSync, mkdtempSync, readFileSync, rmSync, writeFileSync } from "node:fs"
+import {
+  existsSync,
+  mkdtempSync,
+  readdirSync,
+  readFileSync,
+  rmSync,
+  statSync,
+  writeFileSync,
+} from "node:fs"
 import { tmpdir } from "node:os"
 import { dirname, isAbsolute, join, resolve } from "node:path"
 import { type ToolContext, tool } from "@opencode-ai/plugin"
@@ -63,6 +71,8 @@ export type SlitherAnalyzeResult = {
   executionTime: number
   errors: string[]
   error?: string
+  hint?: string
+  suggested_command?: string
 }
 
 function mapSeverity(impact?: string): FindingSeverity {
@@ -151,6 +161,50 @@ function shouldTryFlattenFallback(errors: string[], stderr: string): boolean {
   return FALLBACK_TRIGGERS.some((trigger) => combined.includes(trigger))
 }
 
+function isMixedPragmaSlitherFailure(errors: string[], stderr: string): boolean {
+  const combined = [...errors, stderr].join(" ")
+  return (
+    /(CryticCompileError|Slither exited with code 1)/i.test(combined) &&
+    /(solc|pragma|requires different compiler version|different compiler version|compiler version)/i.test(
+      combined,
+    )
+  )
+}
+
+function containsSolidityFile(dir: string): boolean {
+  try {
+    for (const entry of readdirSync(dir)) {
+      const fullPath = join(dir, entry)
+      const stat = statSync(fullPath)
+      if (stat.isFile() && entry.endsWith(".sol")) return true
+      if (stat.isDirectory() && containsSolidityFile(fullPath)) return true
+    }
+  } catch {
+    return false
+  }
+  return false
+}
+
+function mixedPragmaDiagnostics(
+  args: SlitherArgs,
+  projectDir: string,
+  errors: string[],
+  stderr: string,
+): Pick<SlitherAnalyzeResult, "hint" | "suggested_command"> | undefined {
+  if (!isMixedPragmaSlitherFailure(errors, stderr)) return undefined
+
+  const target = resolve(projectDir, args.target)
+  const srcCandidate = join(target, "src")
+  const suggestion =
+    existsSync(srcCandidate) && containsSolidityFile(srcCandidate) ? srcCandidate : undefined
+  return {
+    hint: "Try narrowing target to a single-pragma subdirectory and check foundry.toml/remappings for mixed compiler or vendored dependency scope issues.",
+    suggested_command: suggestion
+      ? buildCommand({ ...args, target: suggestion }).join(" ")
+      : undefined,
+  }
+}
+
 const parseSolcVersion = parseSolcVersionShared
 const extractContractNames = extractContractNamesShared
 const hasBinary = hasBinaryShared
@@ -488,7 +542,8 @@ export async function executeSlitherAnalyze(
       payload = JSON.parse(runResult.stdout) as SlitherPayload
     } catch (error) {
       const message = error instanceof Error ? error.message : "Unknown parse error"
-      if (args.via_ir || shouldTryFlattenFallback(errors, runResult.stderr)) {
+      const diagnostics = mixedPragmaDiagnostics(args, projectDir, errors, runResult.stderr)
+      if (!diagnostics && (args.via_ir || shouldTryFlattenFallback(errors, runResult.stderr))) {
         const fallbackResult = await flattenFallback(args, context, {
           ...getDefaultFlattenDeps(),
           runCommand,
@@ -503,6 +558,7 @@ export async function executeSlitherAnalyze(
         executionTime: Date.now() - startedAt,
         errors,
         error: `Slither output parse error: ${message}`,
+        ...diagnostics,
       }
     }
 
@@ -513,9 +569,12 @@ export async function executeSlitherAnalyze(
     const findings = parseFindings(payload)
     const success = findings.length > 0 || (runResult.exitCode === 0 && payload.success !== false)
 
+    const diagnostics = mixedPragmaDiagnostics(args, projectDir, errors, runResult.stderr)
+
     if (
       !success &&
       findings.length === 0 &&
+      !diagnostics &&
       (args.via_ir || shouldTryFlattenFallback(errors, runResult.stderr))
     ) {
       const fallbackResult = await flattenFallback(args, context, {
@@ -532,6 +591,7 @@ export async function executeSlitherAnalyze(
       findings,
       executionTime: Date.now() - startedAt,
       errors,
+      ...diagnostics,
     }
   } catch (error) {
     const message = error instanceof Error ? error.message : "Unknown error"