shieldcortex 4.13.1 → 4.14.0

package/scripts/lib/project-key.mjs

@@ -143,6 +143,12 @@ export function deriveProjectKey(cwd) {
     }
   }
 
+  // Hot path post-#42 fix: this branch should only fire outside any git repo
+  // or when origin parsing fails. If users see this often after upgrading,
+  // the helper itself needs another look.
+  if (process.env.SHIELDCORTEX_DEBUG) {
+    process.stderr.write(`[shieldcortex deriveProjectKey] basename fallback for cwd=${cwd}\n`);
+  }
   return basename;
 }
 

package/scripts/pre-compact-hook.mjs

@@ -20,6 +20,7 @@ import { saveAutoExtractedMemory } from './lib/save-memory.mjs';
 import { readTranscriptText } from './lib/transcript-reader.mjs';
 import { getAutoMemoryConfig } from './lib/auto-memory-config.mjs';
 import { recordHookInvocation } from './lib/telemetry.mjs';
+import { deriveProjectKey } from './lib/project-key.mjs';
 
 // Database paths (with legacy fallback)
 const NEW_DB_DIR = join(homedir(), '.shieldcortex');
@@ -62,39 +63,6 @@ const CATEGORY_EXTRACTION_THRESHOLDS = {
   custom: 0.45,
 };
 
-// ==================== PROJECT DETECTION (Mirrors src/context/project-context.ts) ====================
-
-/** Directories to skip when extracting project name from path */
-const SKIP_DIRECTORIES = [
-  'src', 'lib', 'dist', 'build', 'out',
-  'node_modules', '.git', '.next', '.cache',
-  'test', 'tests', '__tests__', 'spec',
-  'bin', 'scripts', 'config', 'public', 'static',
-];
-
-/**
- * Extract project name from a file path.
- * Skips common directory names that don't represent projects.
- */
-function extractProjectFromPath(path) {
-  if (!path) return null;
-
-  const segments = path.split(/[/\\]/).filter(Boolean);
-  if (segments.length === 0) return null;
-
-  // Start from the end and find first non-skipped segment
-  for (let i = segments.length - 1; i >= 0; i--) {
-    const segment = segments[i];
-    if (!SKIP_DIRECTORIES.includes(segment.toLowerCase())) {
-      // Skip hidden directories (starting with .)
-      if (segment.startsWith('.')) continue;
-      return segment;
-    }
-  }
-
-  return null;
-}
-
 // Maximum memories to auto-create per compaction.
 // Dropped 5 → 2 in v4.11.0 for the same reason thresholds were raised.
 const MAX_AUTO_MEMORIES = 2;
@@ -520,7 +488,7 @@ process.stdin.on('end', () => {
     const hookData = JSON.parse(input || '{}');
 
     const trigger = hookData.trigger || 'unknown';
-    const project = extractProjectFromPath(hookData.cwd);
+    const project = deriveProjectKey(hookData.cwd);
     const autoMemConfig = getAutoMemoryConfig();
 
     // Extract conversation text from hook data

package/scripts/session-end-hook.mjs

@@ -29,6 +29,7 @@ import { saveAutoExtractedMemory } from './lib/save-memory.mjs';
 import { readTranscriptText } from './lib/transcript-reader.mjs';
 import { getAutoMemoryConfig } from './lib/auto-memory-config.mjs';
 import { recordHookInvocation } from './lib/telemetry.mjs';
+import { deriveProjectKey } from './lib/project-key.mjs';
 
 // Database paths (with legacy fallback)
 const NEW_DB_DIR = join(homedir(), '.shieldcortex');
@@ -64,29 +65,6 @@ const CATEGORY_EXTRACTION_THRESHOLDS = {
   custom: 0.35,
 };
 
-// ==================== PROJECT DETECTION ====================
-
-const SKIP_DIRECTORIES = [
-  'src', 'lib', 'dist', 'build', 'out',
-  'node_modules', '.git', '.next', '.cache',
-  'test', 'tests', '__tests__', 'spec',
-  'bin', 'scripts', 'config', 'public', 'static',
-];
-
-function extractProjectFromPath(path) {
-  if (!path) return null;
-  const segments = path.split(/[/\\]/).filter(Boolean);
-  if (segments.length === 0) return null;
-  for (let i = segments.length - 1; i >= 0; i--) {
-    const segment = segments[i];
-    if (!SKIP_DIRECTORIES.includes(segment.toLowerCase())) {
-      if (segment.startsWith('.')) continue;
-      return segment;
-    }
-  }
-  return null;
-}
-
 // ==================== DYNAMIC THRESHOLD ====================
 
 function getMemoryStats(db) {
@@ -442,7 +420,7 @@ process.stdin.on('end', () => {
     const hookData = JSON.parse(input || '{}');
 
     const reason = hookData.reason || 'unknown';
-    const project = extractProjectFromPath(hookData.cwd);
+    const project = deriveProjectKey(hookData.cwd);
     const autoMemConfig = getAutoMemoryConfig();
 
     // Config gate: opt-in (default off). Preserves the historical default

package/scripts/stop-hook.mjs

@@ -24,6 +24,7 @@ import { saveAutoExtractedMemory } from './lib/save-memory.mjs';
 import { readTranscriptText } from './lib/transcript-reader.mjs';
 import { getAutoMemoryConfig } from './lib/auto-memory-config.mjs';
 import { recordHookInvocation } from './lib/telemetry.mjs';
+import { deriveProjectKey } from './lib/project-key.mjs';
 
 // Sentinel directory for once-per-session "disabled" log lines. Without this
 // the stop hook bails silently on every turn when autoMemory.enableStop is
@@ -89,28 +90,6 @@ const CATEGORY_EXTRACTION_THRESHOLDS = {
   custom: 0.45,
 };
 
-// ==================== PROJECT DETECTION ====================
-
-const SKIP_DIRECTORIES = [
-  'src', 'lib', 'dist', 'build', 'out',
-  'node_modules', '.git', '.next', '.cache',
-  'test', 'tests', '__tests__', 'spec',
-  'bin', 'scripts', 'config', 'public', 'static',
-];
-
-function extractProjectFromPath(p) {
-  if (!p) return null;
-  const segments = p.split(/[/\\]/).filter(Boolean);
-  for (let i = segments.length - 1; i >= 0; i--) {
-    const segment = segments[i];
-    if (!SKIP_DIRECTORIES.includes(segment.toLowerCase())) {
-      if (segment.startsWith('.')) continue;
-      return segment;
-    }
-  }
-  return null;
-}
-
 // ==================== SALIENCE (mirrors pre-compact) ====================
 
 const ARCHITECTURE_KEYWORDS = ['architecture','design','pattern','structure','system','database','api','schema','model','framework','stack','microservice','monolith','serverless','infrastructure'];
@@ -273,18 +252,17 @@ function getDynamicThreshold(count, max) {
   return 0.25;
 }
 
-// ==================== TURN COUNT (cheap, partial-read) ====================
+// ==================== TRANSCRIPT PEEK (cheap, partial-read) ====================
 
 /**
- * Count assistant turns in the last `windowBytes` of the transcript.
- * Doesn't parse — just counts occurrences of the assistant role marker.
- * That's a very rough approximation but it's enough for sample-every-N
- * decisions and an order of magnitude cheaper than full JSON parse.
+ * Read the last `windowBytes` of the transcript as raw text and count
+ * assistant-role markers. Used for both the modulo sampling gate and the
+ * salience-bypass probe — one disk read serves both decisions.
  */
-function countAssistantTurns(transcriptPath, windowBytes) {
-  if (!transcriptPath) return 0;
+function peekRecentTranscript(transcriptPath, windowBytes) {
+  if (!transcriptPath) return { turnCount: 0, raw: '' };
   const resolved = transcriptPath.replace(/^~/, homedir());
-  if (!existsSync(resolved)) return 0;
+  if (!existsSync(resolved)) return { turnCount: 0, raw: '' };
   try {
     const stat = statSync(resolved);
     const bytes = Math.min(stat.size, windowBytes);
@@ -297,14 +275,33 @@ function countAssistantTurns(transcriptPath, windowBytes) {
     } finally {
       closeSync(fd);
     }
-    // Each assistant message line carries `"role":"assistant"` (or `"type":"assistant"`).
-    // Count occurrences of either marker — close enough for sampling decisions.
-    return (raw.match(/"role":"assistant"|"type":"assistant"/g) || []).length;
+    const turnCount = (raw.match(/"role":"assistant"|"type":"assistant"/g) || []).length;
+    return { turnCount, raw };
   } catch {
-    return 0;
+    return { turnCount: 0, raw: '' };
   }
 }
 
+/**
+ * Cheap salience probe over the recent transcript window. A turn is "salient"
+ * (and worth bypassing the modulo gate for) when:
+ *   - it carries a fenced code block — strong signal of code work / errors / diffs
+ *   - or ≥2 keyword categories hit (architecture, error, decision, learning,
+ *     pattern, code-reference)
+ */
+function isSalientWindow(rawText) {
+  if (!rawText) return false;
+  if (/```/.test(rawText)) return true;
+  let hits = 0;
+  if (detectKeywords(rawText, ARCHITECTURE_KEYWORDS)) hits++;
+  if (detectKeywords(rawText, ERROR_KEYWORDS)) hits++;
+  if (detectKeywords(rawText, DECISION_KEYWORDS)) hits++;
+  if (detectKeywords(rawText, LEARNING_KEYWORDS)) hits++;
+  if (detectKeywords(rawText, PATTERN_KEYWORDS)) hits++;
+  if (detectCodeReferences(rawText)) hits++;
+  return hits >= 2;
+}
+
 // ==================== MAIN ====================
 
 let input = '';
@@ -346,13 +343,20 @@ process.stdin.on('end', () => {
 
     const samplingTurns = autoMemConfig.stopHookSamplingTurns;
     const windowBytes = autoMemConfig.stopHookWindowBytes;
-
-    const turnCount = countAssistantTurns(hookData.transcript_path, windowBytes);
-    if (turnCount === 0 || turnCount % samplingTurns !== 0) {
-      // Off-sample. Surface the sampling decision to stderr so the
-      // "1-in-N turns" behaviour stops being invisible (was a discoverability
-      // gap flagged in #41) — and still record telemetry so the dashboard
-      // shows the hook is actually wired and active.
+    const salienceBypassEnabled = autoMemConfig.stopHookSalienceBypass;
+
+    // Use a smaller window for the cheap peek so off-sample turns stay fast.
+    // The full extraction below still uses the configured windowBytes.
+    const peekBytes = Math.min(32 * 1024, windowBytes);
+    const peek = peekRecentTranscript(hookData.transcript_path, peekBytes);
+    const turnCount = peek.turnCount;
+    const onSample = turnCount > 0 && turnCount % samplingTurns === 0;
+    const salientBypass = salienceBypassEnabled && !onSample && isSalientWindow(peek.raw);
+
+    if (!onSample && !salientBypass) {
+      // Off-sample, no salience bypass. Surface the sampling decision to stderr
+      // so the "1-in-N turns" behaviour stops being invisible (#41), and still
+      // record telemetry so the dashboard shows the hook is wired and active.
       console.error(`[shieldcortex stop-hook] telemetry-only turn=${turnCount}/${samplingTurns}`);
       if (existsSync(DB_PATH)) {
         try {
@@ -371,7 +375,7 @@ process.stdin.on('end', () => {
       process.exit(0);
     }
 
-    const project = extractProjectFromPath(hookData.cwd);
+    const project = deriveProjectKey(hookData.cwd);
     const transcriptOut = readTranscriptText(hookData.transcript_path, {
       maxBytes: windowBytes,
       maxLines: autoMemConfig.maxTranscriptLines,
@@ -409,7 +413,8 @@ process.stdin.on('end', () => {
             console.error(`[stop] Failed to save "${memory.title}": ${err.message}`);
           }
         }
-        console.error(`[stop] Sampled turn=${turnCount}: ${extractedCount} memories extracted`);
+        const sampleReason = salientBypass ? `bypass=salience turn=${turnCount}` : `turn=${turnCount}`;
+        console.error(`[stop] Sampled ${sampleReason}: ${extractedCount} memories extracted`);
       }
     }
   } catch (err) {