prosemirror-menu 1.3.1 → 1.3.2

package/CHANGELOG.md

@@ -1,3 +1,9 @@
+## 1.3.2 (2026-04-17)
+
+### Bug fixes
+
+Give menu buttons a `type=button` attribute to make sure they don't try to submit surrounding forms.
+
 ## 1.3.1 (2026-04-15)
 
 ### Bug fixes

package/dist/index.cjs

@@ -28,6 +28,7 @@ function getIcon(root, icon) {
   var doc = (root.nodeType == 9 ? root : root.ownerDocument) || document;
   var node = doc.createElement("button");
   node.className = prefix$2;
+  node.type = "button";
   if (icon.path) {
     var path = icon.path,
       width = icon.width,
@@ -77,7 +78,9 @@ var MenuItem = function () {
     key: "render",
     value: function render(view) {
       var spec = this.spec;
-      var dom = spec.render ? spec.render(view) : spec.icon ? getIcon(view.root, spec.icon) : spec.label ? crel("button", null, translate(view, spec.label)) : null;
+      var dom = spec.render ? spec.render(view) : spec.icon ? getIcon(view.root, spec.icon) : spec.label ? crel("button", {
+        type: "button"
+      }, translate(view, spec.label)) : null;
       if (!dom) throw new RangeError("MenuItem without icon or label property");
       if (spec.title) {
         var title = typeof spec.title === "function" ? spec.title(view.state) : spec.title;
@@ -155,6 +158,7 @@ var Dropdown = function () {
       this.focusables = content.focusables;
       var win = view.dom.ownerDocument.defaultView || window;
       var btn = crel("button", {
+        type: "button",
         "class": prefix$1 + "-dropdown " + (this.options["class"] || ""),
         style: this.options.css,
         "aria-haspopup": "menu",
@@ -336,6 +340,7 @@ var DropdownSubmenu = function () {
       this.focusables = items.focusables;
       var win = view.dom.ownerDocument.defaultView || window;
       var btn = crel("button", {
+        type: "button",
         "class": prefix$1 + "-submenu-label"
       }, translate(view, this.options.label || ""));
       var wrap = crel("div", {

package/dist/index.js

@@ -16,6 +16,7 @@ function getIcon(root, icon) {
     let doc = (root.nodeType == 9 ? root : root.ownerDocument) || document;
     let node = doc.createElement("button");
     node.className = prefix$2;
+    node.type = "button";
     if (icon.path) {
         let { path, width, height } = icon;
         let name = "pm-icon-" + hashPath(path).toString(16);
@@ -78,7 +79,7 @@ class MenuItem {
         let spec = this.spec;
         let dom = spec.render ? spec.render(view)
             : spec.icon ? getIcon(view.root, spec.icon)
-                : spec.label ? crel("button", null, translate(view, spec.label))
+                : spec.label ? crel("button", { type: "button" }, translate(view, spec.label))
                     : null;
         if (!dom)
             throw new RangeError("MenuItem without icon or label property");
@@ -169,6 +170,7 @@ class Dropdown {
         this.focusables = content.focusables;
         let win = view.dom.ownerDocument.defaultView || window;
         let btn = crel("button", {
+            type: "button",
             class: prefix$1 + "-dropdown " + (this.options.class || ""),
             style: this.options.css,
             "aria-haspopup": "menu",
@@ -354,7 +356,7 @@ class DropdownSubmenu {
         let items = renderDropdownItems(this.content, view);
         this.focusables = items.focusables;
         let win = view.dom.ownerDocument.defaultView || window;
-        let btn = crel("button", { class: prefix$1 + "-submenu-label" }, translate(view, this.options.label || ""));
+        let btn = crel("button", { type: "button", class: prefix$1 + "-submenu-label" }, translate(view, this.options.label || ""));
         let wrap = crel("div", { class: prefix$1 + "-submenu-wrap" }, btn, crel("div", { class: prefix$1 + "-submenu" }, items.dom));
         let listeningOnClose = null;
         let openSubmenu = (e) => {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "prosemirror-menu",
-  "version": "1.3.1",
+  "version": "1.3.2",
   "description": "Simple menu elements for ProseMirror",
   "type": "module",
   "main": "dist/index.cjs",

package/src/icons.ts

@@ -17,6 +17,7 @@ export function getIcon(
   let doc = (root.nodeType == 9 ? root as Document : root.ownerDocument) || document
   let node = doc.createElement("button")
   node.className = prefix
+  node.type = "button"
   if ((icon as any).path) {
     let {path, width, height} = icon as {path: string, width: number, height: number}
     let name = "pm-icon-" + hashPath(path).toString(16)

package/src/menu.ts

@@ -37,7 +37,7 @@ export class MenuItem<E extends HTMLElement = HTMLButtonElement> implements Menu
     let spec = this.spec
     let dom = spec.render ? spec.render(view)
         : spec.icon ? getIcon(view.root, spec.icon)
-        : spec.label ? crel("button", null, translate(view, spec.label)) as HTMLButtonElement
+        : spec.label ? crel("button", {type: "button"}, translate(view, spec.label)) as HTMLButtonElement
         : null
     if (!dom) throw new RangeError("MenuItem without icon or label property")
     if (spec.title) {
@@ -189,6 +189,7 @@ export class Dropdown implements MenuElement {
 
     let btn = crel(
       "button", {
+        type: "button",
         class: prefix + "-dropdown " + (this.options.class || ""),
         style: this.options.css,
         "aria-haspopup": "menu",
@@ -382,7 +383,7 @@ export class DropdownSubmenu implements MenuElement {
     this.focusables = items.focusables
     let win = view.dom.ownerDocument.defaultView || window
 
-    let btn = crel("button", {class: prefix + "-submenu-label"}, translate(view, this.options.label || ""))
+    let btn = crel("button", {type: "button", class: prefix + "-submenu-label"}, translate(view, this.options.label || ""))
     let wrap = crel("div", {class: prefix + "-submenu-wrap"}, btn,
                     crel("div", {class: prefix + "-submenu"}, items.dom))
     let listeningOnClose: (() => void) | null = null