prosemirror-menu 1.3.0 → 1.3.2

package/CHANGELOG.md

@@ -1,3 +1,15 @@
+## 1.3.2 (2026-04-17)
+
+### Bug fixes
+
+Give menu buttons a `type=button` attribute to make sure they don't try to submit surrounding forms.
+
+## 1.3.1 (2026-04-15)
+
+### Bug fixes
+
+Move focus to button before closing a submenu, to avoid focus moving back to the document root.
+
 ## 1.3.0 (2026-02-17)
 
 ### New features

package/CONTRIBUTING.md

@@ -12,7 +12,7 @@ Community discussion, questions, and informal bug reporting is done on the
 ## Submitting bug reports
 
 Report bugs on the
-[GitHub issue tracker](http://github.com/prosemirror/prosemirror/issues).
+[issue tracker](https://code.haverbeke.berlin/prosemirror/prosemirror/issues).
 Before reporting a bug, please read these pointers.
 
 - The issue tracker is for *bugs*, not requests for help. Questions
@@ -34,21 +34,28 @@ Before reporting a bug, please read these pointers.
 
 ## Contributing code
 
-- Make sure you have a [GitHub Account](https://github.com/signup/free)
+Code generated by a language model is not welcome in this project.
+Please don't waste my time with it.
 
-- Fork the relevant repository
-  ([how to fork a repo](https://help.github.com/articles/fork-a-repo))
+If you want to make a change that involves a significant overhaul of
+the code or introduces a user-visible new feature, create an
+[issue](https://code.haverbeke.berlin/prosemirror/prosemirror/issues/)
+first with your proposal.
+
+- Make sure you have a [Codeberg](https://codeberg.org/user/sign_up)
+  or [GitHub](https://github.com/signup/free) account.
+  
+- Use that to create a [code.haverbeke.berlin
+  account](https://code.haverbeke.berlin/user/login).
+
+- Fork the relevant repository.
 
 - Create a local checkout of the code. You can use the
-  [main repository](https://github.com/prosemirror/prosemirror) to
+  [main repository](https://code.haverbeke.berlin/prosemirror/prosemirror) to
   easily check out all core modules.
 
 - Make your changes, and commit them
 
-- Follow the code style of the rest of the project (see below). Run
-  `npm run lint` (in the main repository checkout) to make sure that
-  the linter is happy.
-
 - If your changes are easy to test or likely to regress, add tests in
   the relevant `test/` directory. Either put them in an existing
   `test-*.js` file, if they fit there, or add a new file.
@@ -56,13 +63,13 @@ Before reporting a bug, please read these pointers.
 - Make sure all tests pass. Run `npm run test` to verify tests pass
   (you will need Node.js v6+).
 
-- Submit a pull request ([how to create a pull request](https://help.github.com/articles/fork-a-repo)).
-  Don't put more than one feature/fix in a single pull request.
+- Submit a pull request. Don't put more than one feature/fix in a
+  single pull request.
 
 By contributing code to ProseMirror you
 
  - Agree to license the contributed code under the project's [MIT
-   license](https://github.com/ProseMirror/prosemirror/blob/master/LICENSE).
+   license](https://code.haverbeke.berlin/prosemirror/prosemirror/blob/main/LICENSE).
 
  - Confirm that you have the right to contribute and license the code
    in question. (Either you hold all rights on the code, or the rights
@@ -82,19 +89,16 @@ By contributing code to ProseMirror you
 - Follow the surrounding code when it comes to spacing, brace
   placement, etc.
 
-- Brace-less single-statement bodies are encouraged (whenever they
-  don't impact readability).
+- Brace-less single-statement bodies are encouraged whenever they
+  don't impact readability.
 
-- [getdocs](https://github.com/marijnh/getdocs)-style doc comments
+- [getdocs-ts](https://code.haverbeke.berlin/marijn/getdocs-ts)-style doc comments
   above items that are part of the public API.
 
 - When documenting non-public items, you can put the type after a
   single colon, so that getdocs doesn't pick it up and add it to the
   API reference.
 
-- The linter (`npm run lint`) complains about unused variables and
-  functions. Prefix their names with an underscore to muffle it.
-
 - ProseMirror does *not* follow JSHint or JSLint prescribed style.
   Patches that try to 'fix' code to pass one of these linters will not
   be accepted.

package/README.md

@@ -1,6 +1,6 @@
 # prosemirror-menu
 
-[ [**WEBSITE**](https://prosemirror.net) | [**ISSUES**](https://github.com/prosemirror/prosemirror-menu/issues) | [**FORUM**](https://discuss.prosemirror.net) | [**GITTER**](https://gitter.im/ProseMirror/prosemirror) ]
+[ [**WEBSITE**](https://prosemirror.net) | [**ISSUES**](https://code.haverbeke.berlin/prosemirror/prosemirror-menu/issues) | [**FORUM**](https://discuss.prosemirror.net) | [**GITTER**](https://gitter.im/ProseMirror/prosemirror) ]
 
 This is a non-core example module for [ProseMirror](https://prosemirror.net).
 ProseMirror is a well-behaved rich semantic content editor based on
@@ -19,10 +19,10 @@ ProseMirror, publish your fork, and if it works for me, I'll gladly
 deprecate this in favor of your module.
 
 This code is released under an
-[MIT license](https://github.com/prosemirror/prosemirror/tree/master/LICENSE).
+[MIT license](https://code.haverbeke.berlin/prosemirror/prosemirror/src/branch/main/LICENSE).
 There's a [forum](http://discuss.prosemirror.net) for general
 discussion and support requests, and the
-[Github bug tracker](https://github.com/prosemirror/prosemirror-menu/issues)
+[bug tracker](https://code.haverbeke.berlin/prosemirror/prosemirror-menu/issues)
 is the place to report issues.
 
 ## Documentation
@@ -31,7 +31,7 @@ This module defines a number of building blocks for ProseMirror menus,
 along with a [menu bar](#menu.menuBar) implementation.
 
 When using this module, you should make sure its
-[`style/menu.css`](https://github.com/ProseMirror/prosemirror-menu/blob/master/style/menu.css)
+[`style/menu.css`](https://code.haverbeke.berlin/prosemirror/prosemirror-menu/src/branch/main/style/menu.css)
 file is loaded into your page.
 
 ### interface MenuElement

package/dist/index.cjs

@@ -28,6 +28,7 @@ function getIcon(root, icon) {
   var doc = (root.nodeType == 9 ? root : root.ownerDocument) || document;
   var node = doc.createElement("button");
   node.className = prefix$2;
+  node.type = "button";
   if (icon.path) {
     var path = icon.path,
       width = icon.width,
@@ -77,7 +78,9 @@ var MenuItem = function () {
     key: "render",
     value: function render(view) {
       var spec = this.spec;
-      var dom = spec.render ? spec.render(view) : spec.icon ? getIcon(view.root, spec.icon) : spec.label ? crel("button", null, translate(view, spec.label)) : null;
+      var dom = spec.render ? spec.render(view) : spec.icon ? getIcon(view.root, spec.icon) : spec.label ? crel("button", {
+        type: "button"
+      }, translate(view, spec.label)) : null;
       if (!dom) throw new RangeError("MenuItem without icon or label property");
       if (spec.title) {
         var title = typeof spec.title === "function" ? spec.title(view.state) : spec.title;
@@ -155,6 +158,7 @@ var Dropdown = function () {
       this.focusables = content.focusables;
       var win = view.dom.ownerDocument.defaultView || window;
       var btn = crel("button", {
+        type: "button",
         "class": prefix$1 + "-dropdown " + (this.options["class"] || ""),
         style: this.options.css,
         "aria-haspopup": "menu",
@@ -190,8 +194,8 @@ var Dropdown = function () {
             if (keyboardMoveFocus(_this, event, "vertical")) ;else if (event.key === "Escape") {
               event.preventDefault();
               event.stopPropagation();
-              close();
               btn.focus();
+              close();
             }
           });
           open.node.addEventListener("focusout", function () {
@@ -336,6 +340,7 @@ var DropdownSubmenu = function () {
       this.focusables = items.focusables;
       var win = view.dom.ownerDocument.defaultView || window;
       var btn = crel("button", {
+        type: "button",
         "class": prefix$1 + "-submenu-label"
       }, translate(view, this.options.label || ""));
       var wrap = crel("div", {

package/dist/index.js

@@ -16,6 +16,7 @@ function getIcon(root, icon) {
     let doc = (root.nodeType == 9 ? root : root.ownerDocument) || document;
     let node = doc.createElement("button");
     node.className = prefix$2;
+    node.type = "button";
     if (icon.path) {
         let { path, width, height } = icon;
         let name = "pm-icon-" + hashPath(path).toString(16);
@@ -78,7 +79,7 @@ class MenuItem {
         let spec = this.spec;
         let dom = spec.render ? spec.render(view)
             : spec.icon ? getIcon(view.root, spec.icon)
-                : spec.label ? crel("button", null, translate(view, spec.label))
+                : spec.label ? crel("button", { type: "button" }, translate(view, spec.label))
                     : null;
         if (!dom)
             throw new RangeError("MenuItem without icon or label property");
@@ -169,6 +170,7 @@ class Dropdown {
         this.focusables = content.focusables;
         let win = view.dom.ownerDocument.defaultView || window;
         let btn = crel("button", {
+            type: "button",
             class: prefix$1 + "-dropdown " + (this.options.class || ""),
             style: this.options.css,
             "aria-haspopup": "menu",
@@ -208,8 +210,8 @@ class Dropdown {
                     else if (event.key === "Escape") {
                         event.preventDefault();
                         event.stopPropagation();
-                        close();
                         btn.focus();
+                        close();
                     }
                 });
                 open.node.addEventListener("focusout", () => {
@@ -354,7 +356,7 @@ class DropdownSubmenu {
         let items = renderDropdownItems(this.content, view);
         this.focusables = items.focusables;
         let win = view.dom.ownerDocument.defaultView || window;
-        let btn = crel("button", { class: prefix$1 + "-submenu-label" }, translate(view, this.options.label || ""));
+        let btn = crel("button", { type: "button", class: prefix$1 + "-submenu-label" }, translate(view, this.options.label || ""));
         let wrap = crel("div", { class: prefix$1 + "-submenu-wrap" }, btn, crel("div", { class: prefix$1 + "-submenu" }, items.dom));
         let listeningOnClose = null;
         let openSubmenu = (e) => {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "prosemirror-menu",
-  "version": "1.3.0",
+  "version": "1.3.2",
   "description": "Simple menu elements for ProseMirror",
   "type": "module",
   "main": "dist/index.cjs",
@@ -25,7 +25,7 @@
   ],
   "repository": {
     "type": "git",
-    "url": "git://github.com/prosemirror/prosemirror-menu.git"
+    "url": "git+https://code.haverbeke.berlin/prosemirror/prosemirror-menu.git"
   },
   "dependencies": {
     "crelt": "^1.0.0",

package/src/README.md

@@ -1,6 +1,6 @@
 # prosemirror-menu
 
-[ [**WEBSITE**](https://prosemirror.net) | [**ISSUES**](https://github.com/prosemirror/prosemirror-menu/issues) | [**FORUM**](https://discuss.prosemirror.net) | [**GITTER**](https://gitter.im/ProseMirror/prosemirror) ]
+[ [**WEBSITE**](https://prosemirror.net) | [**ISSUES**](https://code.haverbeke.berlin/prosemirror/prosemirror-menu/issues) | [**FORUM**](https://discuss.prosemirror.net) | [**GITTER**](https://gitter.im/ProseMirror/prosemirror) ]
 
 This is a non-core example module for [ProseMirror](https://prosemirror.net).
 ProseMirror is a well-behaved rich semantic content editor based on
@@ -19,10 +19,10 @@ ProseMirror, publish your fork, and if it works for me, I'll gladly
 deprecate this in favor of your module.
 
 This code is released under an
-[MIT license](https://github.com/prosemirror/prosemirror/tree/master/LICENSE).
+[MIT license](https://code.haverbeke.berlin/prosemirror/prosemirror/src/branch/main/LICENSE).
 There's a [forum](http://discuss.prosemirror.net) for general
 discussion and support requests, and the
-[Github bug tracker](https://github.com/prosemirror/prosemirror-menu/issues)
+[bug tracker](https://code.haverbeke.berlin/prosemirror/prosemirror-menu/issues)
 is the place to report issues.
 
 ## Documentation
@@ -31,7 +31,7 @@ This module defines a number of building blocks for ProseMirror menus,
 along with a [menu bar](#menu.menuBar) implementation.
 
 When using this module, you should make sure its
-[`style/menu.css`](https://github.com/ProseMirror/prosemirror-menu/blob/master/style/menu.css)
+[`style/menu.css`](https://code.haverbeke.berlin/prosemirror/prosemirror-menu/src/branch/main/style/menu.css)
 file is loaded into your page.
 
 @MenuElement

package/src/icons.ts

@@ -17,6 +17,7 @@ export function getIcon(
   let doc = (root.nodeType == 9 ? root as Document : root.ownerDocument) || document
   let node = doc.createElement("button")
   node.className = prefix
+  node.type = "button"
   if ((icon as any).path) {
     let {path, width, height} = icon as {path: string, width: number, height: number}
     let name = "pm-icon-" + hashPath(path).toString(16)

package/src/menu.ts

@@ -37,7 +37,7 @@ export class MenuItem<E extends HTMLElement = HTMLButtonElement> implements Menu
     let spec = this.spec
     let dom = spec.render ? spec.render(view)
         : spec.icon ? getIcon(view.root, spec.icon)
-        : spec.label ? crel("button", null, translate(view, spec.label)) as HTMLButtonElement
+        : spec.label ? crel("button", {type: "button"}, translate(view, spec.label)) as HTMLButtonElement
         : null
     if (!dom) throw new RangeError("MenuItem without icon or label property")
     if (spec.title) {
@@ -189,6 +189,7 @@ export class Dropdown implements MenuElement {
 
     let btn = crel(
       "button", {
+        type: "button",
         class: prefix + "-dropdown " + (this.options.class || ""),
         style: this.options.css,
         "aria-haspopup": "menu",
@@ -228,8 +229,8 @@ export class Dropdown implements MenuElement {
           } else if (event.key === "Escape") {
             event.preventDefault()
             event.stopPropagation()
-            close()
             btn.focus()
+            close()
           }
         })
         open.node.addEventListener("focusout", () => {
@@ -382,7 +383,7 @@ export class DropdownSubmenu implements MenuElement {
     this.focusables = items.focusables
     let win = view.dom.ownerDocument.defaultView || window
 
-    let btn = crel("button", {class: prefix + "-submenu-label"}, translate(view, this.options.label || ""))
+    let btn = crel("button", {type: "button", class: prefix + "-submenu-label"}, translate(view, this.options.label || ""))
     let wrap = crel("div", {class: prefix + "-submenu-wrap"}, btn,
                     crel("div", {class: prefix + "-submenu"}, items.dom))
     let listeningOnClose: (() => void) | null = null