prebid.js 7.29.0 → 7.30.0

package/test/spec/modules/onetagBidAdapter_spec.js

@@ -1,8 +1,8 @@
 import { spec, isValid, hasTypeVideo, isSchainValid } from 'modules/onetagBidAdapter.js';
 import { expect } from 'chai';
-import {find} from 'src/polyfill.js';
+import { find } from 'src/polyfill.js';
 import { BANNER, VIDEO } from 'src/mediaTypes.js';
-import {INSTREAM, OUTSTREAM} from 'src/video.js';
+import { INSTREAM, OUTSTREAM } from 'src/video.js';
 
 describe('onetag', function () {
   function createBid() {
@@ -122,14 +122,14 @@ describe('onetag', function () {
       it('Should return true when correct multi format bid is passed', function () {
         expect(spec.isBidRequestValid(createMultiFormatBid())).to.be.true;
       });
-      it('Should split multi format bid into two single format bid with same bidId', function() {
-        const bids = JSON.parse(spec.buildRequests([ createMultiFormatBid() ]).data).bids;
+      it('Should split multi format bid into two single format bid with same bidId', function () {
+        const bids = JSON.parse(spec.buildRequests([createMultiFormatBid()]).data).bids;
         expect(bids.length).to.equal(2);
         expect(bids[0].bidId).to.equal(bids[1].bidId);
       });
-      it('Should retrieve correct request bid when extracting video request data', function() {
+      it('Should retrieve correct request bid when extracting video request data', function () {
         const requestBid = createMultiFormatBid();
-        const multiFormatRequest = spec.buildRequests([ requestBid ]);
+        const multiFormatRequest = spec.buildRequests([requestBid]);
         const serverResponse = {
           body: {
             bids: [
@@ -173,24 +173,30 @@ describe('onetag', function () {
       const data = JSON.parse(d);
       it('Should contain all keys', function () {
         expect(data).to.be.an('object');
-        expect(data).to.include.all.keys('location', 'referrer', 'masked', 'sHeight', 'sWidth', 'docHeight', 'wHeight', 'wWidth', 'oHeight', 'oWidth', 'aWidth', 'aHeight', 'sLeft', 'sTop', 'hLength', 'bids', 'docHidden', 'xOffset', 'yOffset', 'timing', 'version');
-        expect(data.location).to.be.a('string');
-        expect(data.masked).to.be.oneOf([0, 1, 2]);
+        expect(data).to.include.all.keys('location', 'referrer', 'stack', 'numIframes', 'sHeight', 'sWidth', 'docHeight', 'wHeight', 'wWidth', 'oHeight', 'oWidth', 'aWidth', 'aHeight', 'sLeft', 'sTop', 'hLength', 'bids', 'docHidden', 'xOffset', 'yOffset', 'networkConnectionType', 'networkEffectiveConnectionType', 'timing', 'version');
+        expect(data.location).to.satisfy(function (value) {
+          return value === null || typeof value === 'string';
+        });
         expect(data.referrer).to.satisfy(referrer => referrer === null || typeof referrer === 'string');
+        expect(data.stack).to.be.an('array');
+        expect(data.numIframes).to.be.a('number');
         expect(data.sHeight).to.be.a('number');
         expect(data.sWidth).to.be.a('number');
         expect(data.wWidth).to.be.a('number');
         expect(data.wHeight).to.be.a('number');
         expect(data.oHeight).to.be.a('number');
         expect(data.oWidth).to.be.a('number');
-        expect(data.ancestorOrigin).to.satisfy(function (value) {
-          return value === null || typeof value === 'string';
-        });
         expect(data.aWidth).to.be.a('number');
         expect(data.aHeight).to.be.a('number');
         expect(data.sLeft).to.be.a('number');
         expect(data.sTop).to.be.a('number');
         expect(data.hLength).to.be.a('number');
+        expect(data.networkConnectionType).to.satisfy(function (value) {
+          return value === null || typeof value === 'string'
+        });
+        expect(data.networkEffectiveConnectionType).to.satisfy(function (value) {
+          return value === null || typeof value === 'string'
+        });
         expect(data.bids).to.be.an('array');
         expect(data.version).to.have.all.keys('prebid', 'adapter');
         const bids = data['bids'];
@@ -231,14 +237,14 @@ describe('onetag', function () {
           expect(bid.pubId).to.be.a('string');
         }
       });
-    } catch (e) {}
+    } catch (e) { }
     it('Returns empty data if no valid requests are passed', function () {
       serverRequest = spec.buildRequests([]);
       let dataString = serverRequest.data;
       try {
         let dataObj = JSON.parse(dataString);
         expect(dataObj.bids).to.be.an('array').that.is.empty;
-      } catch (e) {}
+      } catch (e) { }
     });
     it('should send GDPR consent data', function () {
       let consentString = 'consentString';
@@ -287,7 +293,7 @@ describe('onetag', function () {
         let dataItem = interpretedResponse[i];
         expect(dataItem).to.include.all.keys('requestId', 'cpm', 'width', 'height', 'ttl', 'creativeId', 'netRevenue', 'currency', 'meta', 'dealId');
         if (dataItem.meta.mediaType === VIDEO) {
-          const {context} = find(requestData.bids, (item) => item.bidId === dataItem.requestId);
+          const { context } = find(requestData.bids, (item) => item.bidId === dataItem.requestId);
           if (context === INSTREAM) {
             expect(dataItem).to.include.all.keys('videoCacheKey', 'vastUrl');
             expect(dataItem.vastUrl).to.be.a('string');
@@ -321,7 +327,7 @@ describe('onetag', function () {
   describe('getUserSyncs', function () {
     const sync_endpoint = 'https://onetag-sys.com/usync/';
     it('Returns an iframe if iframeEnabled is true', function () {
-      const syncs = spec.getUserSyncs({iframeEnabled: true});
+      const syncs = spec.getUserSyncs({ iframeEnabled: true });
       expect(syncs).to.be.an('array');
       expect(syncs.length).to.equal(1);
       expect(syncs[0].type).to.equal('iframe');
@@ -383,16 +389,16 @@ describe('onetag', function () {
       expect(isSchainValid(undefined)).to.be.false;
     });
     it('Should return false when schain is missing nodes key', function () {
-      const schain = {'otherKey': 'otherValue'};
+      const schain = { 'otherKey': 'otherValue' };
       expect(isSchainValid(schain)).to.be.false;
     });
     it('Should return false when schain is missing one of the required SupplyChainNode attribute', function () {
-      const missingAsiNode = {'sid': '00001', 'hp': 1};
-      const missingSidNode = {'asi': 'indirectseller.com', 'hp': 1};
-      const missingHpNode = {'asi': 'indirectseller.com', 'sid': '00001'};
-      expect(isSchainValid({'config': {'nodes': [missingAsiNode]}})).to.be.false;
-      expect(isSchainValid({'config': {'nodes': [missingSidNode]}})).to.be.false;
-      expect(isSchainValid({'config': {'nodes': [missingHpNode]}})).to.be.false;
+      const missingAsiNode = { 'sid': '00001', 'hp': 1 };
+      const missingSidNode = { 'asi': 'indirectseller.com', 'hp': 1 };
+      const missingHpNode = { 'asi': 'indirectseller.com', 'sid': '00001' };
+      expect(isSchainValid({ 'config': { 'nodes': [missingAsiNode] } })).to.be.false;
+      expect(isSchainValid({ 'config': { 'nodes': [missingSidNode] } })).to.be.false;
+      expect(isSchainValid({ 'config': { 'nodes': [missingHpNode] } })).to.be.false;
     });
     it('Should return true when schain contains all required attributes', function () {
       const validSchain = {

package/test/spec/modules/topicsFpdModule_spec.js

@@ -1,4 +1,12 @@
-import {getTopics, getTopicsData, processFpd, hasGDPRConsent, getCachedTopics, receiveMessage, topicStorageName} from '../../../modules/topicsFpdModule.js';
+import {
+  getTopics,
+  getTopicsData,
+  processFpd,
+  hasGDPRConsent,
+  getCachedTopics,
+  receiveMessage,
+  topicStorageName
+} from '../../../modules/topicsFpdModule.js';
 import {deepClone, safeJSONParse} from '../../../src/utils.js';
 import {gdprDataHandler} from 'src/adapterManager.js';
 import {getCoreStorageManager} from 'src/storageManager.js';
@@ -9,14 +17,14 @@ describe('getTopicsData', () => {
       topic,
       taxonomyVersion: taxv,
       modelVersion: modelv
-    }
+    };
   }
 
   function byTaxClass(segments) {
     return segments.reduce((memo, segment) => {
       memo[`${segment.ext.segtax}:${segment.ext.segclass}`] = segment;
       return memo;
-    }, {})
+    }, {});
   }
 
   [
@@ -146,16 +154,16 @@ describe('getTopicsData', () => {
         Object.entries(byTaxClass(actual)).forEach(([key, datum]) => {
           sinon.assert.match(datum, expected[key]);
           expect(datum.name).to.equal('mockName');
-        })
+        });
       });
 
       it('should not set name if null', () => {
         getTopicsData(null, topics).forEach((data) => {
           expect(data.hasOwnProperty('name')).to.be.false;
-        })
-      })
-    })
-  })
+        });
+      });
+    });
+  });
 });
 
 describe('getTopics', () => {
@@ -169,11 +177,13 @@ describe('getTopics', () => {
     'document that throws on featurePolicy': {
       browsingTopics: sinon.stub(),
       get featurePolicy() {
-        throw new Error()
+        throw new Error();
       }
     },
     'document that throws on browsingTopics': {
-      browsingTopics: sinon.stub().callsFake(() => { throw new Error(); }),
+      browsingTopics: sinon.stub().callsFake(() => {
+        throw new Error();
+      }),
       featurePolicy: {
         allowsFeature: sinon.stub().returns(true)
       }
@@ -183,11 +193,11 @@ describe('getTopics', () => {
       return getTopics(doc).then((topics) => {
         expect(topics).to.eql([]);
       });
-    })
+    });
   });
 
   it('should call `document.browsingTopics` when allowed', () => {
-    const topics = ['t1', 't2']
+    const topics = ['t1', 't2'];
     return getTopics({
       browsingTopics: sinon.stub().returns(Promise.resolve(topics)),
       featurePolicy: {
@@ -195,9 +205,9 @@ describe('getTopics', () => {
       }
     }).then((actual) => {
       expect(actual).to.eql(topics);
-    })
-  })
-})
+    });
+  });
+});
 
 describe('processFpd', () => {
   const mockData = [
@@ -244,7 +254,7 @@ describe('Topics Module GDPR consent check', () => {
   let gdprDataHdlrStub;
   beforeEach(() => {
     gdprDataHdlrStub = sinon.stub(gdprDataHandler, 'getConsentData');
-  })
+  });
 
   afterEach(() => {
     gdprDataHdlrStub.restore();
@@ -261,7 +271,7 @@ describe('Topics Module GDPR consent check', () => {
     expect(hasGDPRConsent()).to.equal(false);
   });
 
-  it("should return true when GDPR doesn't apply", () => {
+  it('should return true when GDPR doesn\'t apply', () => {
     const consentString = 'CPi8wgAPi8wgAADABBENCrCsAP_AAH_AAAAAISNB7D==';
     const consentConfig = {
       consentString: consentString,
@@ -365,7 +375,7 @@ describe('getCachedTopics()', () => {
   const evt = {
     data: '{"segment":{"domain":"ads.pubmatic.com","topics":[{"configVersion":"chrome.1","modelVersion":"2206021246","taxonomyVersion":"1","topic":165,"version":"chrome.1:1:2206021246"}],"bidder":"pubmatic"},"date":1669743901858}',
     origin: 'https://ads.pubmatic.com'
-  }
+  };
 
   let gdprDataHdlrStub;
   beforeEach(() => {
@@ -378,14 +388,23 @@ describe('getCachedTopics()', () => {
   });
 
   it('should return segments for bidder if GDPR consent is true and there is cached segments stored which is not expired', () => {
-    let storedSegments = '[["pubmatic",{"2206021246":{"ext":{"segtax":600,"segclass":"2206021246"},"segment":[{"id":"243"},{"id":"265"}],"name":"ads.pubmatic.com"},"lastUpdated":1669719242027}]]';
+    const storedSegments = JSON.stringify(
+      [['pubmatic', {
+        '2206021246': {
+          'ext': {'segtax': 600, 'segclass': '2206021246'},
+          'segment': [{'id': '243'}, {'id': '265'}],
+          'name': 'ads.pubmatic.com'
+        },
+        'lastUpdated': new Date().getTime()
+      }]]
+    );
     storage.setDataInLocalStorage(topicStorageName, storedSegments);
     gdprDataHdlrStub.returns(consentConfig);
     assert.deepEqual(getCachedTopics(), expected);
   });
 
   it('should return empty segments for bidder if GDPR consent is true and there is cached segments stored which is expired', () => {
-    let storedSegments = '[["pubmatic",{"2206021246":{"ext":{"segtax":600,"segclass":"2206021246"},"segment":[{"id":"243"},{"id":"265"}],"name":"ads.pubmatic.com"},"lastUpdated":1659719242027}]]';
+    let storedSegments = '[["pubmatic",{"2206021246":{"ext":{"segtax":600,"segclass":"2206021246"},"segment":[{"id":"243"},{"id":"265"}],"name":"ads.pubmatic.com"},"lastUpdated":10}]]';
     storage.setDataInLocalStorage(topicStorageName, storedSegments);
     gdprDataHdlrStub.returns(consentConfig);
     assert.deepEqual(getCachedTopics(), []);
@@ -394,7 +413,7 @@ describe('getCachedTopics()', () => {
   it('should stored segments if receiveMessage event is triggerred with segment data', () => {
     return processFpd({}, {global: {}}, {data: Promise.resolve(mockData)})
       .then(({global}) => {
-        receiveMessage(evt)
+        receiveMessage(evt);
         let segments = new Map(safeJSONParse(storage.getDataFromLocalStorage(topicStorageName)));
         expect(segments.has('pubmatic')).to.equal(true);
       });
@@ -410,4 +429,4 @@ describe('getCachedTopics()', () => {
         expect(segments.get('pubmatic')[2206021246].segment.length).to.equal(1);
       });
   });
-})
+});