node-red-contrib-modbus-modpackqt 3.3.19 → 3.3.20

package/CHANGELOG.md

@@ -4,6 +4,20 @@ All notable changes to **node-red-contrib-modbus-modpackqt** are documented
 here. This project follows [Semantic Versioning](https://semver.org/) — pin a
 major version (`^2.0.0`) in production.
 
+## [3.3.20] — 2026-05-10
+
+### Fixed
+
+- **Slave-read / slave-write Slave Server dropdown now actually
+  finds the slave-server nodes on the canvas.** The picker walks
+  three Node-RED APIs (`eachNode`, `eachConfig`, `filterNodes`)
+  and dedupes — robust against the API quirks that left the list
+  empty even with deployed slave-server nodes present.
+- Added a refresh button next to the dropdown so you can reload
+  without closing the dialog after dropping a new slave-server.
+- Hint text now reports how many slave servers were found, or
+  tells you what to do if none.
+
 ## [3.3.19] — 2026-05-10
 
 ### Changed

package/nodes/lib/probe-runtime.js

@@ -18,7 +18,7 @@
 const http = require('http');
 const { URL } = require('url');
 
-const PALETTE_VERSION = '3.3.19';
+const PALETTE_VERSION = '3.3.20';
 const DEFAULT_PORT = parseInt(process.env.MODPACKQT_PROBE_PORT, 10) || 8502;
 const BIND_HOST    = process.env.MODPACKQT_PROBE_HOST || '127.0.0.1';
 const PORT_RETRY   = 5;

package/nodes/modpackqt-slave-read.html

@@ -18,14 +18,38 @@
     },
     paletteLabel: 'modbus slave read',
     oneditprepare: function () {
+      const node = this;
       const $sel = $('#node-input-slaveServerId');
-      $sel.empty().append('<option value="">— select a slave server node —</option>');
-      RED.nodes.eachNode(function (n) {
-        if (n.type === 'modpackqt-slave-server') {
-          const label = (n.name || (':' + n.bindPort + ' #' + n.unitId));
-          $('<option>').val(n.id).text(label).appendTo($sel);
+      const $hint = $('#modpackqt-slave-read-hint');
+      const reload = function () {
+        const seen = new Set();
+        const found = [];
+        const addIfMatch = function (n) {
+          if (!n || seen.has(n.id)) return;
+          if (n.type === 'modpackqt-slave-server') { seen.add(n.id); found.push(n); }
+        };
+        try { RED.nodes.eachNode(addIfMatch); } catch (_) {}
+        try { RED.nodes.eachConfig(addIfMatch); } catch (_) {}
+        try {
+          if (typeof RED.nodes.filterNodes === 'function') {
+            RED.nodes.filterNodes({ type: 'modpackqt-slave-server' }).forEach(addIfMatch);
+          }
+        } catch (_) {}
+        $sel.empty().append('<option value="">— select a slave server node —</option>');
+        if (!found.length) {
+          $hint.html('No <b>modbus slave server</b> nodes on the canvas yet. Drop one, click Deploy, then reopen this dialog.');
+        } else {
+          found.forEach(function (n) {
+            const tag = ':' + (n.bindPort || 1502) + ' #' + (n.unitId || 1);
+            const label = n.name ? (n.name + ' — ' + tag) : tag;
+            $('<option>').val(n.id).text(label).appendTo($sel);
+          });
+          $hint.text('Pick a modbus slave server node from the canvas. ' + found.length + ' available.');
         }
-      });
+        if (node.slaveServerId) $sel.val(node.slaveServerId);
+      };
+      reload();
+      $('#modpackqt-slave-read-refresh').on('click', function (e) { e.preventDefault(); reload(); });
     }
   });
 </script>
@@ -37,9 +61,10 @@
   </div>
   <div class="form-row">
     <label for="node-input-slaveServerId"><i class="fa fa-server"></i> Slave Server</label>
-    <select id="node-input-slaveServerId" style="width:70%"></select>
+    <select id="node-input-slaveServerId" style="width:65%"></select>
+    <button type="button" id="modpackqt-slave-read-refresh" class="red-ui-button" title="Reload" style="margin-left:4px"><i class="fa fa-refresh"></i></button>
   </div>
-  <div class="form-tips" style="font-size:11px;color:#6b7280;margin:-8px 0 12px 105px">
+  <div id="modpackqt-slave-read-hint" class="form-tips" style="font-size:11px;color:#6b7280;margin:-8px 0 12px 105px">
     Pick a <b>modbus slave server</b> node from the canvas. Deploy the flow first if the list is empty.
   </div>
   <div class="form-row">

package/nodes/modpackqt-slave-write.html

@@ -18,14 +18,41 @@
     },
     paletteLabel: 'modbus slave write',
     oneditprepare: function () {
+      const node = this;
       const $sel = $('#node-input-slaveServerId');
-      $sel.empty().append('<option value="">— select a slave server node —</option>');
-      RED.nodes.eachNode(function (n) {
-        if (n.type === 'modpackqt-slave-server') {
-          const label = (n.name || (':' + n.bindPort + ' #' + n.unitId));
-          $('<option>').val(n.id).text(label).appendTo($sel);
+      const $hint = $('#modpackqt-slave-write-hint');
+      const reload = function () {
+        const seen = new Set();
+        const found = [];
+        const addIfMatch = function (n) {
+          if (!n || seen.has(n.id)) return;
+          if (n.type === 'modpackqt-slave-server') { seen.add(n.id); found.push(n); }
+        };
+        // Walk every known source — eachNode (regular flow nodes), eachConfig
+        // (configs) and filterNodes (everything by type) — to be robust against
+        // Node-RED API quirks where freshly-added nodes might miss one list.
+        try { RED.nodes.eachNode(addIfMatch); } catch (_) {}
+        try { RED.nodes.eachConfig(addIfMatch); } catch (_) {}
+        try {
+          if (typeof RED.nodes.filterNodes === 'function') {
+            RED.nodes.filterNodes({ type: 'modpackqt-slave-server' }).forEach(addIfMatch);
+          }
+        } catch (_) {}
+        $sel.empty().append('<option value="">— select a slave server node —</option>');
+        if (!found.length) {
+          $hint.html('No <b>modbus slave server</b> nodes on the canvas yet. Drop one, click Deploy, then reopen this dialog.');
+        } else {
+          found.forEach(function (n) {
+            const tag = ':' + (n.bindPort || 1502) + ' #' + (n.unitId || 1);
+            const label = n.name ? (n.name + ' — ' + tag) : tag;
+            $('<option>').val(n.id).text(label).appendTo($sel);
+          });
+          $hint.text('Pick a modbus slave server node from the canvas. ' + found.length + ' available.');
         }
-      });
+        if (node.slaveServerId) $sel.val(node.slaveServerId);
+      };
+      reload();
+      $('#modpackqt-slave-write-refresh').on('click', function (e) { e.preventDefault(); reload(); });
     }
   });
 </script>
@@ -37,9 +64,10 @@
   </div>
   <div class="form-row">
     <label for="node-input-slaveServerId"><i class="fa fa-server"></i> Slave Server</label>
-    <select id="node-input-slaveServerId" style="width:70%"></select>
+    <select id="node-input-slaveServerId" style="width:65%"></select>
+    <button type="button" id="modpackqt-slave-write-refresh" class="red-ui-button" title="Reload" style="margin-left:4px"><i class="fa fa-refresh"></i></button>
   </div>
-  <div class="form-tips" style="font-size:11px;color:#6b7280;margin:-8px 0 12px 105px">
+  <div id="modpackqt-slave-write-hint" class="form-tips" style="font-size:11px;color:#6b7280;margin:-8px 0 12px 105px">
     Pick a <b>modbus slave server</b> node from the canvas. Deploy the flow first if the list is empty.
   </div>
   <div class="form-row">

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "node-red-contrib-modbus-modpackqt",
-  "version": "3.3.19",
+  "version": "3.3.20",
   "description": "Modbus commissioning, testing & analysis tools for Node-RED. Embedded Modbus TCP/RTU master + slave server, FC1/FC2/FC3/FC4 reads, FC5/FC6/FC15/FC16 writes, built-in slave register store, and a passive traffic monitor for debugging. 100% free, MIT, no usage limits. By ModPackQT — open the matching web console at modpackqt.com for register decoding, simulation and AI assistance.",
   "keywords": [
     "node-red",