msgpackr 1.9.4 → 1.9.5-debug.1

package/dist/test.js

@@ -1635,8 +1635,13 @@
 							if (Array.isArray(value)) {
 								packArray(value);
 							} else {
-								if (value.toJSON) // use this as an alternate mechanism for expressing how to serialize
-									return pack(value.toJSON());
+								// use this as an alternate mechanism for expressing how to serialize
+								if (value.toJSON) {
+									const json = value.toJSON();
+									// if for some reason value.toJSON returns itself it'll loop forever
+									if (json !== value)
+										return pack(json)
+								}
 								
 								// if there is a writeFunction, use it, otherwise just encode as undefined
 								if (type === 'function')
@@ -2858,11 +2863,16 @@
 					objectLiteralProperties.push('__proto__:this');
 				}
 				let toObject = (new Function(...args, 'return function(s){return{' + objectLiteralProperties.join(',') + '}}')).apply(null, properties.map(prop => prop.get));
-				Object.defineProperty(prototype, 'toJSON', {
-					value(omitUnderscoredProperties) {
-						return toObject.call(this, this[sourceSymbol]);
-					}
-				});
+				try {
+					Object.defineProperty(prototype, 'toJSON', {
+						value(omitUnderscoredProperties) {
+							return toObject.call(this, this[sourceSymbol]);
+						}
+					});
+				} catch(error) {
+					error.message += ' setting properties ' + JSON.stringify(properties);
+					throw error;
+				}
 			} else {
 				Object.defineProperty(prototype, 'toJSON', {
 					value(omitUnderscoredProperties) {
@@ -4098,6 +4108,17 @@
 			assert.deepEqual(values, [[1,0,1], [2,1,2], [3,2,3], [4,3,4]]);
 		});
 
+		test('pack toJSON returning this', () => {
+			class Serializable {
+				someData = [1, 2, 3, 4]
+				toJSON() {
+					return this
+				}
+			}
+			const serialized = pack(new Serializable);
+			const deserialized = unpack(serialized);
+			assert.deepStrictEqual(deserialized, { someData: [1, 2, 3, 4] });
+		});
 	});
 	suite('msgpackr performance tests', function(){
 		test('performance JSON.parse', function() {