msgpackr 1.7.0-alpha3 → 1.7.0-alpha4

package/pack.js

@@ -15,7 +15,7 @@ let targetView
 let position = 0
 let safeEnd
 let bundledStrings = null
-let writeStructSlots, prepareStructures
+let writeStructSlots
 const MAX_BUNDLE_SIZE = 0xf000
 const hasNonLatin = /[\u0080-\uFFFF]/
 export const RECORD_SYMBOL = Symbol('record-id')
@@ -149,7 +149,7 @@ export class Packr extends Unpackr {
 				if (structures) {
 					if (serializationsSinceTransitionRebuild < 10)
 						serializationsSinceTransitionRebuild++
-					let sharedLength = structures.sharedLength || maxSharedStructures
+					let sharedLength = structures.sharedLength || 0
 					if (structures.length > sharedLength)
 						structures.length = sharedLength
 					if (transitionsCount > 10000) {
@@ -168,10 +168,9 @@ export class Packr extends Unpackr {
 					if (hasSharedUpdate && packr.saveStructures) {
 						// we can't rely on start/end with REUSE_BUFFER_MODE since they will (probably) change when we save
 						let returnBuffer = target.subarray(start, position)
-						let newSharedData = prepareStructures ? prepareStructures(structures, packr) : structures;
-						if (packr.saveStructures(newSharedData, newSharedData.isCompatible || packr.lastNamedStructuresLength || 0) === false) {
+						let newSharedData = prepareStructures(structures, packr);
+						if (packr.saveStructures(newSharedData, newSharedData.isCompatible) === false) {
 							// get updated structures and try again if the update failed
-							packr._mergeStructures(packr.getStructures())
 							return packr.pack(value)
 						}
 						packr.lastNamedStructuresLength = sharedLength
@@ -694,7 +693,7 @@ export class Packr extends Unpackr {
 		const writeStruct = (object, safePrototype) => {
 			let newPosition = writeStructSlots(object, target, position, structures, makeRoom, (value, newPosition, notifySharedUpdate) => {
 				if (notifySharedUpdate)
-					hasSharedUpdate = true;
+					return hasSharedUpdate = true;
 				position = newPosition;
 				if (start > 0) {
 					pack(value);
@@ -946,6 +945,15 @@ export function addExtension(extension) {
 	}
 	unpackAddExtension(extension)
 }
+function prepareStructures(structures, packr) {
+	structures.isCompatible = (existingStructures) => {
+		let compatible = !existingStructures || ((packr.lastNamedStructuresLength || 0) === existingStructures.length)
+		if (!compatible) // we want to merge these existing structures immediately since we already have it and we are in the right transaction
+			packr._mergeStructures(existingStructures);
+		return compatible;
+	}
+	return structures
+}
 export function setWriteStructSlots(writeSlots, makeStructures) {
 	writeStructSlots = writeSlots;
 	prepareStructures = makeStructures;

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "msgpackr",
   "author": "Kris Zyp",
-  "version": "1.7.0-alpha3",
+  "version": "1.7.0-alpha4",
   "description": "Ultra-fast MessagePack implementation with extensions for records and structured cloning",
   "license": "MIT",
   "types": "./index.d.ts",

package/struct.js

@@ -62,7 +62,6 @@ setWriteStructSlots(writeStruct, prepareStructures);
 function writeStruct(object, target, position, structures, makeRoom, pack, packr) {
 	let typedStructs = packr.typedStructs || (packr.typedStructs = []);
 	// note that we rely on pack.js to load stored structures before we get to this point
-	packr.lastTypedStructuresLength = typedStructs.length;
 	let targetView = target.dataView;
 	let refsStartPosition = (typedStructs.lastStringStart || 100) + position;
 	let safeEnd = target.length - 10;
@@ -415,6 +414,8 @@ function onLoadedStructures(sharedData) {
 	if (!(sharedData instanceof Map))
 		return sharedData;
 	let typed = sharedData.get('typed') || [];
+	if (Object.isFrozen(typed))
+		typed = typed.map(structure => structure.slice(0));
 	let named = sharedData.get('named');
 	let transitions = Object.create(null);
 	for (let i = 0, l = typed.length; i < l; i++) {
@@ -442,6 +443,7 @@ function onLoadedStructures(sharedData) {
 	}
 	typed.transitions = transitions;
 	this.typedStructs = typed;
+	this.lastTypedStructuresLength = typed.length;
 	return named;
 }
 var sourceSymbol = Symbol('source')
@@ -473,7 +475,7 @@ function readStruct(src, position, srcEnd, unpackr) {
 	}
 	var construct = structure.construct;
 	if (!construct) {
-		construct = structure.construct = function() {
+		construct = structure.construct = function LazyObject() {
 		}
 		var prototype = construct.prototype;
 		Object.defineProperty(prototype, 'toJSON', {
@@ -555,7 +557,7 @@ function readStruct(src, position, srcEnd, unpackr) {
 							next = next.next;
 						}
 						if (end == null)
-							end = srcEnd - refStart;
+							end = source.srcEnd - refStart;
 						if (source.srcString) {
 							return source.srcString.slice(ref, end);
 						}
@@ -571,7 +573,7 @@ function readStruct(src, position, srcEnd, unpackr) {
 									asciiEnd = null;
 							} while((next = next.next));
 							if (asciiEnd == null)
-								asciiEnd = srcEnd - refStart
+								asciiEnd = source.srcEnd - refStart
 							source.srcString = src.toString('latin1', refStart, refStart + asciiEnd);
 							return source.srcString.slice(ref, end);
 						}
@@ -606,7 +608,7 @@ function readStruct(src, position, srcEnd, unpackr) {
 							next = next.next;
 						}
 						if (end == null)
-							end = srcEnd - refStart;
+							end = source.srcEnd - refStart;
 						if (type === UTF8) {
 							return src.toString('utf8', ref + refStart, end + refStart);
 						} else {
@@ -690,18 +692,21 @@ function prepareStructures(structures, packr) {
 	structMap.set('typed', packr.typedStructs);
 	let lastTypedStructuresLength = packr.lastTypedStructuresLength || 0;
 	structMap.isCompatible = existing => {
+		let compatible = true;
 		if (existing instanceof Map) {
 			let named = existing.get('named') || [];
 			if (named.length !== (packr.lastNamedStructuresLength || 0))
-				return false;
+				compatible = false;
 			let typed = existing.get('typed') || [];
 			if (typed.length !== lastTypedStructuresLength)
-				return false;
+				compatible = false;
 		} else if (existing instanceof Array) {
 			if (existing.length !== (packr.lastNamedStructuresLength || 0))
-				return false;
+				compatible = false;
 		}
-		return true;
+		if (!compatible)
+			packr._mergeStructures(existing);
+		return compatible;
 	};
 	packr.lastTypedStructuresLength = packr.typedStructs?.length;
 	return structMap;

package/unpack.js

@@ -142,6 +142,8 @@ export class Unpackr {
 		if (onLoadedStructures)
 			loadedStructures = onLoadedStructures.call(this, loadedStructures);
 		loadedStructures = loadedStructures || []
+		if (Object.isFrozen(loadedStructures))
+			loadedStructures = loadedStructures.map(structure => structure.slice(0))
 		for (let i = 0, l = loadedStructures.length; i < l; i++) {
 			let structure = loadedStructures[i]
 			if (structure) {