mongoose 6.8.0 → 6.8.2

package/lib/connection.js

@@ -196,7 +196,7 @@ Connection.prototype.collections;
  *
  * #### Example:
  *
- *     mongoose.createConnection('mongodb://localhost:27017/mydb').name; // "mydb"
+ *     mongoose.createConnection('mongodb://127.0.0.1:27017/mydb').name; // "mydb"
  *
  * @property name
  * @memberOf Connection
@@ -253,7 +253,7 @@ Connection.prototype.id;
  *
  * #### Example:
  *
- *     const db = mongoose.createConnection('mongodb://localhost:27017/mydb');
+ *     const db = mongoose.createConnection('mongodb://127.0.0.1:27017/mydb');
  *     db.plugin(() => console.log('Applied'));
  *     db.plugins.length; // 1
  *
@@ -277,7 +277,7 @@ Object.defineProperty(Connection.prototype, 'plugins', {
  *
  * #### Example:
  *
- *     mongoose.createConnection('mongodb://localhost:27017/mydb').host; // "localhost"
+ *     mongoose.createConnection('mongodb://127.0.0.1:27017/mydb').host; // "127.0.0.1"
  *
  * @property host
  * @memberOf Connection
@@ -297,7 +297,7 @@ Object.defineProperty(Connection.prototype, 'host', {
  *
  * #### Example:
  *
- *     mongoose.createConnection('mongodb://localhost:27017/mydb').port; // 27017
+ *     mongoose.createConnection('mongodb://127.0.0.1:27017/mydb').port; // 27017
  *
  * @property port
  * @memberOf Connection
@@ -316,7 +316,7 @@ Object.defineProperty(Connection.prototype, 'port', {
  *
  * #### Example:
  *
- *     mongoose.createConnection('mongodb://val:psw@localhost:27017/mydb').user; // "val"
+ *     mongoose.createConnection('mongodb://val:psw@127.0.0.1:27017/mydb').user; // "val"
  *
  * @property user
  * @memberOf Connection
@@ -335,7 +335,7 @@ Object.defineProperty(Connection.prototype, 'user', {
  *
  * #### Example:
  *
- *     mongoose.createConnection('mongodb://val:psw@localhost:27017/mydb').pass; // "psw"
+ *     mongoose.createConnection('mongodb://val:psw@127.0.0.1:27017/mydb').pass; // "psw"
  *
  * @property pass
  * @memberOf Connection
@@ -539,7 +539,7 @@ Connection.prototype.dropCollection = _wrapConnHelper(function dropCollection(co
  *
  * #### Example:
  *
- *     const conn = mongoose.createConnection('mongodb://localhost:27017/mydb');
+ *     const conn = mongoose.createConnection('mongodb://127.0.0.1:27017/mydb');
  *     // Deletes the entire 'mydb' database
  *     await conn.dropDatabase();
  *
@@ -1109,7 +1109,7 @@ Connection.prototype.collection = function(name, options) {
  *
  * #### Example:
  *
- *     const db = mongoose.createConnection('mongodb://localhost:27017/mydb');
+ *     const db = mongoose.createConnection('mongodb://127.0.0.1:27017/mydb');
  *     db.plugin(() => console.log('Applied'));
  *     db.plugins.length; // 1
  *
@@ -1367,7 +1367,7 @@ Connection.prototype.watch = function(pipeline, options) {
  *
  * #### Example:
  *
- *     const conn = await mongoose.createConnection('mongodb://localhost:27017/test').
+ *     const conn = await mongoose.createConnection('mongodb://127.0.0.1:27017/test').
  *       asPromise();
  *     conn.readyState; // 1, means Mongoose is connected
  *
@@ -1440,7 +1440,7 @@ Connection.prototype.optionsProvideAuthenticationData = function(options) {
  *
  * #### Example:
  *
- *     const conn = await mongoose.createConnection('mongodb://localhost:27017/test').
+ *     const conn = await mongoose.createConnection('mongodb://127.0.0.1:27017/test').
  *       asPromise();
  *
  *     conn.getClient(); // MongoClient { ... }
@@ -1460,7 +1460,7 @@ Connection.prototype.getClient = function getClient() {
  *
  * #### Example:
  *
- *     const client = await mongodb.MongoClient.connect('mongodb://localhost:27017/test');
+ *     const client = await mongodb.MongoClient.connect('mongodb://127.0.0.1:27017/test');
  *
  *     const conn = mongoose.createConnection().setClient(client);
  *
@@ -1538,7 +1538,7 @@ Connection.prototype.syncIndexes = async function syncIndexes(options = {}) {
  * #### Example:
  *
  *     // Connect to `initialdb` first
- *     const conn = await mongoose.createConnection('mongodb://localhost:27017/initialdb').asPromise();
+ *     const conn = await mongoose.createConnection('mongodb://127.0.0.1:27017/initialdb').asPromise();
  *
  *     // Creates an un-cached connection to `mydb`
  *     const db = conn.useDb('mydb');

package/lib/document.js

@@ -4655,7 +4655,7 @@ Document.prototype.getChanges = function() {
  * Returns a copy of this document with a deep clone of `_doc` and `$__`.
  *
  * @return {Document} a copy of this document
- * @api private
+ * @api public
  * @method $clone
  * @memberOf Document
  * @instance

package/lib/helpers/common.js

@@ -106,6 +106,7 @@ updatePath: '${recursion.raw.path}'`);
       modifiedPaths(val, path + key, result, recursion);
     }
   }
+  recursion.trace.delete(update);
 
   return result;
 }

package/lib/helpers/model/discriminator.js

@@ -1,6 +1,7 @@
 'use strict';
 
 const Mixed = require('../../schema/mixed');
+const applyBuiltinPlugins = require('../schema/applyBuiltinPlugins');
 const defineKey = require('../document/compile').defineKey;
 const get = require('../get');
 const utils = require('../../utils');
@@ -40,6 +41,8 @@ module.exports = function discriminator(model, name, schema, tiedValue, applyPlu
     model.base._applyPlugins(schema, {
       skipTopLevel: !applyPluginsToDiscriminators
     });
+  } else if (!mergeHooks) {
+    applyBuiltinPlugins(schema);
   }
 
   const key = model.schema.options.discriminatorKey;

package/lib/helpers/populate/assignRawDocsToIdStructure.js

@@ -43,6 +43,8 @@ function assignRawDocsToIdStructure(rawIds, resultDocs, resultOrder, options, re
 
   let i = 0;
   const len = rawIds.length;
+  const hasResultArrays = Object.values(resultOrder).find(o => Array.isArray(o));
+
   for (i = 0; i < len; ++i) {
     id = rawIds[i];
 
@@ -77,7 +79,8 @@ function assignRawDocsToIdStructure(rawIds, resultDocs, resultOrder, options, re
       if (doc) {
         if (sorting) {
           const _resultOrder = resultOrder[sid];
-          if (Array.isArray(_resultOrder) && Array.isArray(doc) && _resultOrder.length === doc.length) {
+          if (hasResultArrays) {
+            // If result arrays, rely on the MongoDB server response for ordering
             newOrder.push(doc);
           } else {
             newOrder[_resultOrder] = doc;

package/lib/helpers/populate/assignVals.js

@@ -253,6 +253,8 @@ function valueFilter(val, assignmentOpts, populateOptions, allIds) {
       const _allIds = Array.isArray(allIds) ? allIds[i] : allIds;
       if (!isPopulatedObject(subdoc) && (!populateOptions.retainNullValues || subdoc != null) && !userSpecifiedTransform) {
         continue;
+      } else if (!populateOptions.retainNullValues && subdoc == null) {
+        continue;
       } else if (userSpecifiedTransform) {
         subdoc = transform(isPopulatedObject(subdoc) ? subdoc : null, _allIds);
       }

package/lib/helpers/query/castUpdate.js

@@ -84,6 +84,14 @@ module.exports = function castUpdate(schema, obj, options, context, filter) {
     const op = ops[i];
     val = ret[op];
     hasDollarKey = hasDollarKey || op.startsWith('$');
+    const toUnset = {};
+    if (val != null) {
+      for (const key of Object.keys(val)) {
+        if (val[key] === undefined) {
+          toUnset[key] = 1;
+        }
+      }
+    }
 
     if (val &&
         typeof val === 'object' &&
@@ -100,6 +108,10 @@ module.exports = function castUpdate(schema, obj, options, context, filter) {
 
     if (op.startsWith('$') && utils.isEmptyObject(val)) {
       delete ret[op];
+      if (op === '$set' && !utils.isEmptyObject(toUnset)) {
+        // Unset all undefined values
+        ret['$unset'] = toUnset;
+      }
     }
   }
 

package/lib/helpers/schema/applyBuiltinPlugins.js

@@ -0,0 +1,12 @@
+'use strict';
+
+const builtinPlugins = require('../../plugins');
+
+module.exports = function applyBuiltinPlugins(schema) {
+  for (const plugin of Object.values(builtinPlugins)) {
+    plugin(schema, { deduplicate: true });
+  }
+  schema.plugins = Object.values(builtinPlugins).
+    map(fn => ({ fn, opts: { deduplicate: true } })).
+    concat(schema.plugins);
+};

package/lib/helpers/update/castArrayFilters.js

@@ -37,14 +37,36 @@ function _castArrayFilters(arrayFilters, schema, strictQuery, updatedPathsByFilt
     if (filter == null) {
       throw new Error(`Got null array filter in ${arrayFilters}`);
     }
-    for (const key of Object.keys(filter)) {
-      if (key === '$and' || key === '$or') {
+    const keys = Object.keys(filter).filter(key => filter[key] != null);
+    if (keys.length === 0) {
+      continue;
+    }
+
+    const firstKey = keys[0];
+    if (firstKey === '$and' || firstKey === '$or') {
+      for (const key of keys) {
         _castArrayFilters(filter[key], schema, strictQuery, updatedPathsByFilter, query);
-        continue;
-      }
-      if (filter[key] == null) {
-        continue;
       }
+      continue;
+    }
+    const dot = firstKey.indexOf('.');
+    const filterWildcardPath = dot === -1 ? firstKey : firstKey.substring(0, dot);
+    if (updatedPathsByFilter[filterWildcardPath] == null) {
+      continue;
+    }
+    const baseFilterPath = cleanPositionalOperators(
+      updatedPathsByFilter[filterWildcardPath]
+    );
+
+    const baseSchematype = getPath(schema, baseFilterPath);
+    let filterBaseSchema = baseSchematype != null ? baseSchematype.schema : null;
+    if (filterBaseSchema != null &&
+        filterBaseSchema.discriminators != null &&
+        filter[filterWildcardPath + '.' + filterBaseSchema.options.discriminatorKey]) {
+      filterBaseSchema = filterBaseSchema.discriminators[filter[filterWildcardPath + '.' + filterBaseSchema.options.discriminatorKey]] || filterBaseSchema;
+    }
+
+    for (const key of keys) {
       if (updatedPathsByFilter[key] === null) {
         continue;
       }
@@ -52,21 +74,25 @@ function _castArrayFilters(arrayFilters, schema, strictQuery, updatedPathsByFilt
         continue;
       }
       const dot = key.indexOf('.');
-      let filterPath = dot === -1 ?
-        updatedPathsByFilter[key] + '.0' :
-        updatedPathsByFilter[key.substring(0, dot)] + '.0' + key.substring(dot);
-      if (filterPath == null) {
-        throw new Error(`Filter path not found for ${key}`);
+
+      let filterPathRelativeToBase = dot === -1 ? null : key.substring(dot);
+      let schematype;
+      if (filterPathRelativeToBase == null || filterBaseSchema == null) {
+        schematype = baseSchematype;
+      } else {
+        // If there are multiple array filters in the path being updated, make sure
+        // to replace them so we can get the schema path.
+        filterPathRelativeToBase = cleanPositionalOperators(filterPathRelativeToBase);
+        schematype = getPath(filterBaseSchema, filterPathRelativeToBase);
       }
 
-      // If there are multiple array filters in the path being updated, make sure
-      // to replace them so we can get the schema path.
-      filterPath = cleanPositionalOperators(filterPath);
-      const schematype = getPath(schema, filterPath);
       if (schematype == null) {
         if (!strictQuery) {
           return;
         }
+        const filterPath = filterPathRelativeToBase == null ?
+          baseFilterPath + '.0' :
+          baseFilterPath + '.0' + filterPathRelativeToBase;
         // For now, treat `strictQuery = true` and `strictQuery = 'throw'` as
         // equivalent for casting array filters. `strictQuery = true` doesn't
         // quite work in this context because we never want to silently strip out

package/lib/index.js

@@ -19,21 +19,17 @@ const Types = require('./types');
 const Query = require('./query');
 const Model = require('./model');
 const applyPlugins = require('./helpers/schema/applyPlugins');
+const builtinPlugins = require('./plugins');
 const driver = require('./driver');
 const promiseOrCallback = require('./helpers/promiseOrCallback');
 const legacyPluralize = require('./helpers/pluralize');
 const utils = require('./utils');
 const pkg = require('../package.json');
 const cast = require('./cast');
-const removeSubdocs = require('./plugins/removeSubdocs');
-const saveSubdocs = require('./plugins/saveSubdocs');
-const trackTransaction = require('./plugins/trackTransaction');
-const validateBeforeSave = require('./plugins/validateBeforeSave');
 
 const Aggregate = require('./aggregate');
 const PromiseProvider = require('./promise_provider');
 const printStrictQueryWarning = require('./helpers/printStrictQueryWarning');
-const shardingPlugin = require('./plugins/sharding');
 const trusted = require('./helpers/query/trusted').trusted;
 const sanitizeFilter = require('./helpers/query/sanitizeFilter');
 const isBsonType = require('./helpers/isBsonType');
@@ -108,13 +104,7 @@ function Mongoose(options) {
     configurable: false,
     enumerable: true,
     writable: false,
-    value: [
-      [saveSubdocs, { deduplicate: true }],
-      [validateBeforeSave, { deduplicate: true }],
-      [shardingPlugin, { deduplicate: true }],
-      [removeSubdocs, { deduplicate: true }],
-      [trackTransaction, { deduplicate: true }]
-    ]
+    value: Object.values(builtinPlugins).map(plugin => ([plugin, { deduplicate: true }]))
   });
 }
 
@@ -198,26 +188,28 @@ Mongoose.prototype.setDriver = function setDriver(driver) {
  *     mongoose.set({ debug: true, autoIndex: false }); // set multiple options at once
  *
  * Currently supported options are:
- * - 'applyPluginsToChildSchemas': `true` by default. Set to false to skip applying global plugins to child schemas
- * - 'applyPluginsToDiscriminators': `false` by default. Set to true to apply global plugins to discriminator schemas. This typically isn't necessary because plugins are applied to the base schema and discriminators copy all middleware, methods, statics, and properties from the base schema.
- * - 'autoCreate': Set to `true` to make Mongoose call [`Model.createCollection()`](/docs/api/model.html#model_Model-createCollection) automatically when you create a model with `mongoose.model()` or `conn.model()`. This is useful for testing transactions, change streams, and other features that require the collection to exist.
- * - 'autoIndex': `true` by default. Set to false to disable automatic index creation for all models associated with this Mongoose instance.
- * - 'debug': If `true`, prints the operations mongoose sends to MongoDB to the console. If a writable stream is passed, it will log to that stream, without colorization. If a callback function is passed, it will receive the collection name, the method name, then all arguments passed to the method. For example, if you wanted to replicate the default logging, you could output from the callback `Mongoose: ${collectionName}.${methodName}(${methodArgs.join(', ')})`.
- * - 'returnOriginal': If `false`, changes the default `returnOriginal` option to `findOneAndUpdate()`, `findByIdAndUpdate`, and `findOneAndReplace()` to false. This is equivalent to setting the `new` option to `true` for `findOneAndX()` calls by default. Read our [`findOneAndUpdate()` tutorial](/docs/tutorials/findoneandupdate.html) for more information.
- * - 'bufferCommands': enable/disable mongoose's buffering mechanism for all connections and models
- * - 'cloneSchemas': `false` by default. Set to `true` to `clone()` all schemas before compiling into a model.
- * - 'timestamps.createdAt.immutable': `true` by default. If `false`, it will change the `createdAt` field to be [`immutable: false`](https://mongoosejs.com/docs/api/schematype.html#schematype_SchemaType-immutable) which means you can update the `createdAt`
- * - 'maxTimeMS': If set, attaches [maxTimeMS](https://docs.mongodb.com/manual/reference/operator/meta/maxTimeMS/) to every query
- * - 'objectIdGetter': `true` by default. Mongoose adds a getter to MongoDB ObjectId's called `_id` that returns `this` for convenience with populate. Set this to false to remove the getter.
- * - 'overwriteModels': Set to `true` to default to overwriting models with the same name when calling `mongoose.model()`, as opposed to throwing an `OverwriteModelError`.
- * - 'returnOriginal': If `false`, changes the default `returnOriginal` option to `findOneAndUpdate()`, `findByIdAndUpdate`, and `findOneAndReplace()` to false. This is equivalent to setting the `new` option to `true` for `findOneAndX()` calls by default. Read our [`findOneAndUpdate()` tutorial](/docs/tutorials/findoneandupdate.html) for more information.
- * - 'runValidators': `false` by default. Set to true to enable [update validators](/docs/validation.html#update-validators) for all validators by default.
- * - 'sanitizeFilter': `false` by default. Set to true to enable the [sanitization of the query filters](/docs/api/mongoose.html#mongoose_Mongoose-sanitizeFilter) against query selector injection attacks by wrapping any nested objects that have a property whose name starts with `$` in a `$eq`.
- * - 'selectPopulatedPaths': `true` by default. Set to false to opt out of Mongoose adding all fields that you `populate()` to your `select()`. The schema-level option `selectPopulatedPaths` overwrites this one.
- * - 'strict': `true` by default, may be `false`, `true`, or `'throw'`. Sets the default strict mode for schemas.
- * - 'strictQuery': same value as 'strict' by default (`true`), may be `false`, `true`, or `'throw'`. Sets the default [strictQuery](/docs/guide.html#strictQuery) mode for schemas. The default value will be switched back to `false` in Mongoose 7, use `mongoose.set('strictQuery', false);` if you want to prepare for the change.
- * - 'toJSON': `{ transform: true, flattenDecimals: true }` by default. Overwrites default objects to [`toJSON()`](/docs/api/document.html#document_Document-toJSON), for determining how Mongoose documents get serialized by `JSON.stringify()`
- * - 'toObject': `{ transform: true, flattenDecimals: true }` by default. Overwrites default objects to [`toObject()`](/docs/api/document.html#document_Document-toObject)
+ * - `allowDiskUse`: Set to `true` to set `allowDiskUse` to true to all aggregation operations by default.
+ * - `applyPluginsToChildSchemas`: `true` by default. Set to false to skip applying global plugins to child schemas
+ * - `applyPluginsToDiscriminators`: `false` by default. Set to true to apply global plugins to discriminator schemas. This typically isn't necessary because plugins are applied to the base schema and discriminators copy all middleware, methods, statics, and properties from the base schema.
+ * - `autoCreate`: Set to `true` to make Mongoose call [`Model.createCollection()`](/docs/api/model.html#model_Model-createCollection) automatically when you create a model with `mongoose.model()` or `conn.model()`. This is useful for testing transactions, change streams, and other features that require the collection to exist.
+ * - `autoIndex`: `true` by default. Set to false to disable automatic index creation for all models associated with this Mongoose instance.
+ * - `bufferCommands`: enable/disable mongoose's buffering mechanism for all connections and models
+ * - `bufferTimeoutMS`: If bufferCommands is on, this option sets the maximum amount of time Mongoose buffering will wait before throwing an error. If not specified, Mongoose will use 10000 (10 seconds).
+ * - `cloneSchemas`: `false` by default. Set to `true` to `clone()` all schemas before compiling into a model.
+ * - `debug`: If `true`, prints the operations mongoose sends to MongoDB to the console. If a writable stream is passed, it will log to that stream, without colorization. If a callback function is passed, it will receive the collection name, the method name, then all arguments passed to the method. For example, if you wanted to replicate the default logging, you could output from the callback `Mongoose: ${collectionName}.${methodName}(${methodArgs.join(', ')})`.
+ * - `id`: If `true`, adds a `id` virtual to all schemas unless overwritten on a per-schema basis.
+ * - `timestamps.createdAt.immutable`: `true` by default. If `false`, it will change the `createdAt` field to be [`immutable: false`](https://mongoosejs.com/docs/api/schematype.html#schematype_SchemaType-immutable) which means you can update the `createdAt`
+ * - `maxTimeMS`: If set, attaches [maxTimeMS](https://docs.mongodb.com/manual/reference/operator/meta/maxTimeMS/) to every query
+ * - `objectIdGetter`: `true` by default. Mongoose adds a getter to MongoDB ObjectId's called `_id` that returns `this` for convenience with populate. Set this to false to remove the getter.
+ * - `overwriteModels`: Set to `true` to default to overwriting models with the same name when calling `mongoose.model()`, as opposed to throwing an `OverwriteModelError`.
+ * - `returnOriginal`: If `false`, changes the default `returnOriginal` option to `findOneAndUpdate()`, `findByIdAndUpdate`, and `findOneAndReplace()` to false. This is equivalent to setting the `new` option to `true` for `findOneAndX()` calls by default. Read our [`findOneAndUpdate()` tutorial](/docs/tutorials/findoneandupdate.html) for more information.
+ * - `runValidators`: `false` by default. Set to true to enable [update validators](/docs/validation.html#update-validators) for all validators by default.
+ * - `sanitizeFilter`: `false` by default. Set to true to enable the [sanitization of the query filters](/docs/api/mongoose.html#mongoose_Mongoose-sanitizeFilter) against query selector injection attacks by wrapping any nested objects that have a property whose name starts with `$` in a `$eq`.
+ * - `selectPopulatedPaths`: `true` by default. Set to false to opt out of Mongoose adding all fields that you `populate()` to your `select()`. The schema-level option `selectPopulatedPaths` overwrites this one.
+ * - `strict`: `true` by default, may be `false`, `true`, or `'throw'`. Sets the default strict mode for schemas.
+ * - `strictQuery`: same value as 'strict' by default (`true`), may be `false`, `true`, or `'throw'`. Sets the default [strictQuery](/docs/guide.html#strictQuery) mode for schemas. The default value will be switched back to `false` in Mongoose 7, use `mongoose.set('strictQuery', false);` if you want to prepare for the change.
+ * - `toJSON`: `{ transform: true, flattenDecimals: true }` by default. Overwrites default objects to [`toJSON()`](/docs/api/document.html#document_Document-toJSON), for determining how Mongoose documents get serialized by `JSON.stringify()`
+ * - `toObject`: `{ transform: true, flattenDecimals: true }` by default. Overwrites default objects to [`toObject()`](/docs/api/document.html#document_Document-toObject)
  *
  * @param {String|Object} key The name of the option or a object of multiple key-value pairs
  * @param {String|Function|Boolean} value The value of the option, unused if "key" is a object
@@ -309,22 +301,22 @@ Mongoose.prototype.get = Mongoose.prototype.set;
  * #### Example:
  *
  *     // with mongodb:// URI
- *     db = mongoose.createConnection('mongodb://user:pass@localhost:port/database');
+ *     db = mongoose.createConnection('mongodb://user:pass@127.0.0.1:port/database');
  *
  *     // and options
  *     const opts = { db: { native_parser: true }}
- *     db = mongoose.createConnection('mongodb://user:pass@localhost:port/database', opts);
+ *     db = mongoose.createConnection('mongodb://user:pass@127.0.0.1:port/database', opts);
  *
  *     // replica sets
- *     db = mongoose.createConnection('mongodb://user:pass@localhost:port,anotherhost:port,yetanother:port/database');
+ *     db = mongoose.createConnection('mongodb://user:pass@127.0.0.1:port,anotherhost:port,yetanother:port/database');
  *
  *     // and options
  *     const opts = { replset: { strategy: 'ping', rs_name: 'testSet' }}
- *     db = mongoose.createConnection('mongodb://user:pass@localhost:port,anotherhost:port,yetanother:port/database', opts);
+ *     db = mongoose.createConnection('mongodb://user:pass@127.0.0.1:port,anotherhost:port,yetanother:port/database', opts);
  *
  *     // initialize now, connect later
  *     db = mongoose.createConnection();
- *     db.openUri('localhost', 'database', port, [opts]);
+ *     db.openUri('127.0.0.1', 'database', port, [opts]);
  *
  * @param {String} uri mongodb URI to connect to
  * @param {Object} [options] passed down to the [MongoDB driver's `connect()` function](https://mongodb.github.io/node-mongodb-native/4.9/interfaces/MongoClientOptions.html), except for 4 mongoose-specific options explained below.
@@ -367,10 +359,10 @@ Mongoose.prototype.createConnection = function(uri, options, callback) {
  *
  * #### Example:
  *
- *     mongoose.connect('mongodb://user:pass@localhost:port/database');
+ *     mongoose.connect('mongodb://user:pass@127.0.0.1:port/database');
  *
  *     // replica sets
- *     const uri = 'mongodb://user:pass@localhost:port,anotherhost:port,yetanother:port/mydatabase';
+ *     const uri = 'mongodb://user:pass@127.0.0.1:port,anotherhost:port,yetanother:port/mydatabase';
  *     mongoose.connect(uri);
  *
  *     // with options
@@ -786,7 +778,7 @@ Mongoose.prototype.__defineSetter__('connection', function(v) {
  *     mongoose.connections.length; // 1, just the default connection
  *     mongoose.connections[0] === mongoose.connection; // true
  *
- *     mongoose.createConnection('mongodb://localhost:27017/test');
+ *     mongoose.createConnection('mongodb://127.0.0.1:27017/test');
  *     mongoose.connections.length; // 2
  *
  * @memberOf Mongoose

package/lib/model.js

@@ -36,6 +36,7 @@ const assignVals = require('./helpers/populate/assignVals');
 const castBulkWrite = require('./helpers/model/castBulkWrite');
 const createPopulateQueryFilter = require('./helpers/populate/createPopulateQueryFilter');
 const getDefaultBulkwriteResult = require('./helpers/getDefaultBulkwriteResult');
+const getSchemaDiscriminatorByValue = require('./helpers/discriminator/getSchemaDiscriminatorByValue');
 const discriminator = require('./helpers/model/discriminator');
 const firstKey = require('./helpers/firstKey');
 const each = require('./helpers/each');
@@ -1570,14 +1571,14 @@ Model.diffIndexes = function diffIndexes(options, callback) {
       const schemaIndexes = getRelatedSchemaIndexes(model, schema.indexes());
 
       const toDrop = getIndexesToDrop(schema, schemaIndexes, dbIndexes);
-      const toCreate = getIndexesToCreate(schema, schemaIndexes, dbIndexes);
+      const toCreate = getIndexesToCreate(schema, schemaIndexes, dbIndexes, toDrop);
 
       cb(null, { toDrop, toCreate });
     });
   });
 };
 
-function getIndexesToCreate(schema, schemaIndexes, dbIndexes) {
+function getIndexesToCreate(schema, schemaIndexes, dbIndexes, toDrop) {
   const toCreate = [];
 
   for (const [schemaIndexKeysObject, schemaIndexOptions] of schemaIndexes) {
@@ -1589,7 +1590,10 @@ function getIndexesToCreate(schema, schemaIndexes, dbIndexes) {
       if (isDefaultIdIndex(index)) {
         continue;
       }
-      if (isIndexEqual(schemaIndexKeysObject, options, index)) {
+      if (
+        isIndexEqual(schemaIndexKeysObject, options, index) &&
+        !toDrop.includes(index.name)
+      ) {
         found = true;
         break;
       }
@@ -1887,6 +1891,12 @@ function _ensureIndexes(model, options, callback) {
       indexOptions.background = options.background;
     }
 
+    if ('toCreate' in options) {
+      if (options.toCreate.length === 0) {
+        return done();
+      }
+    }
+
     model.collection.createIndex(indexFields, indexOptions, utils.tick(function(err, name) {
       indexSingleDone(err, indexFields, indexOptions, name);
       if (err) {
@@ -4465,7 +4475,11 @@ Model.validate = function validate(obj, pathsToValidate, context, callback) {
   }
 
   return this.db.base._promiseOrCallback(callback, cb => {
-    const schema = this.schema;
+    let schema = this.schema;
+    const discriminatorKey = schema.options.discriminatorKey;
+    if (schema.discriminators != null && obj != null && obj[discriminatorKey] != null) {
+      schema = getSchemaDiscriminatorByValue(schema, obj[discriminatorKey]) || schema;
+    }
     let paths = Object.keys(schema.paths);
 
     if (pathsToValidate != null) {

package/lib/plugins/index.js

@@ -0,0 +1,7 @@
+'use strict';
+
+exports.removeSubdocs = require('./removeSubdocs');
+exports.saveSubdocs = require('./saveSubdocs');
+exports.sharding = require('./sharding');
+exports.trackTransaction = require('./trackTransaction');
+exports.validateBeforeSave = require('./validateBeforeSave');

package/lib/query.js

@@ -370,17 +370,33 @@ Query.prototype.clone = function clone() {
  *
  * #### Example:
  *
- *     query.slice('comments', 5);
- *     query.slice('comments', -5);
- *     query.slice('comments', [10, 5]);
- *     query.where('comments').slice(5);
- *     query.where('comments').slice([-10, 5]);
+ *     query.slice('comments', 5); // Returns the first 5 comments
+ *     query.slice('comments', -5); // Returns the last 5 comments
+ *     query.slice('comments', [10, 5]); // Returns the first 5 comments after the 10-th
+ *     query.where('comments').slice(5); // Returns the first 5 comments
+ *     query.where('comments').slice([-10, 5]); // Returns the first 5 comments after the 10-th to last
+ *
+ * **Note:** If the absolute value of the number of elements to be sliced is greater than the number of elements in the array, all array elements will be returned.
+ *
+ *      // Given `arr`: [1, 2, 3, 4, 5, 6, 7, 8, 9, 10]
+ *      query.slice('arr', 20); // Returns [1, 2, 3, 4, 5, 6, 7, 8, 9, 10]
+ *      query.slice('arr', -20); // Returns [1, 2, 3, 4, 5, 6, 7, 8, 9, 10]
+ *
+ * **Note:** If the number of elements to skip is positive and greater than the number of elements in the array, an empty array will be returned.
+ *
+ *      // Given `arr`: [1, 2, 3, 4, 5, 6, 7, 8, 9, 10]
+ *      query.slice('arr', [20, 5]); // Returns []
+ *
+ * **Note:** If the number of elements to skip is negative and its absolute value is greater than the number of elements in the array, the starting position is the start of the array.
+ *
+ *      // Given `arr`: [1, 2, 3, 4, 5, 6, 7, 8, 9, 10]
+ *      query.slice('arr', [-20, 5]); // Returns [1, 2, 3, 4, 5]
  *
  * @method slice
  * @memberOf Query
  * @instance
  * @param {String} [path]
- * @param {Number} val number/range of elements to slice
+ * @param {Number|Array} val number of elements to slice or array with number of elements to skip and number of elements to slice
  * @return {Query} this
  * @see mongodb https://www.mongodb.org/display/DOCS/Retrieving+a+Subset+of+Fields#RetrievingaSubsetofFields-RetrievingaSubrangeofArrayElements
  * @see $slice https://docs.mongodb.org/manual/reference/projection/slice/#prj._S_slice

package/lib/schema.js

@@ -1250,6 +1250,9 @@ Schema.prototype.interpretAsType = function(path, obj, options) {
         if (options.hasOwnProperty('strict')) {
           childSchemaOptions.strict = options.strict;
         }
+        if (options.hasOwnProperty('strictQuery')) {
+          childSchemaOptions.strictQuery = options.strictQuery;
+        }
 
         if (this._userProvidedOptions.hasOwnProperty('_id')) {
           childSchemaOptions._id = this._userProvidedOptions._id;

package/lib/types/map.js

@@ -180,7 +180,7 @@ class MongooseMap extends Map {
     }
 
     this.set(key, undefined);
-    super.delete(key);
+    return super.delete(key);
   }
 
   /**

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "mongoose",
   "description": "Mongoose MongoDB ODM",
-  "version": "6.8.0",
+  "version": "6.8.2",
   "author": "Guillermo Rauch <guillermo@learnboost.com>",
   "keywords": [
     "mongodb",
@@ -36,7 +36,7 @@
     "acquit-ignore": "0.2.0",
     "acquit-require": "0.1.1",
     "assert-browserify": "2.0.0",
-    "axios": "1.2.0",
+    "axios": "1.1.3",
     "babel-loader": "8.2.5",
     "benchmark": "2.1.4",
     "bluebird": "3.7.2",
@@ -61,9 +61,8 @@
     "q": "1.5.1",
     "sinon": "15.0.0",
     "stream-browserify": "3.0.0",
-    "ts-benchmark": "^1.1.10",
     "tsd": "0.25.0",
-    "typescript": "4.8.4",
+    "typescript": "4.9.4",
     "uuid": "9.0.0",
     "webpack": "5.75.0"
   },
@@ -100,8 +99,7 @@
     "test-tsd": "node ./test/types/check-types-filename && tsd",
     "tdd": "mocha ./test/*.test.js --inspect --watch --recursive --watch-files ./**/*.{js,ts}",
     "test-coverage": "nyc --reporter=html --reporter=text npm test",
-    "ts-benchmark": "ts-benchmark -p ./benchmarks/typescript/simple -f 17/100000 18 29 32",
-    "ts-benchmark-watch": "ts-benchmark -p ./benchmarks/typescript/simple -w ./types -i -s -f 17/100000 18 29 32 -b master"
+    "ts-benchmark": "cd ./benchmarks/typescript/simple && npm install && npm run benchmark | node ../../../scripts/tsc-diagnostics-check"
   },
   "main": "./index.js",
   "types": "./types/index.d.ts",

package/scripts/tsc-diagnostics-check.js

@@ -0,0 +1,15 @@
+'use strict';
+
+const fs = require('fs');
+
+const stdin = fs.readFileSync(0).toString('utf8');
+const maxInstantiations = isNaN(process.argv[2]) ? 100000 : parseInt(process.argv[2], 10);
+
+console.log(stdin);
+
+const numInstantiations = parseInt(stdin.match(/Instantiations:\s+(\d+)/)[1], 10);
+if (numInstantiations > maxInstantiations) {
+  throw new Error(`Instantiations ${numInstantiations} > max ${maxInstantiations}`);
+}
+
+process.exit(0);