eslint-plugin-n 17.15.1 → 17.16.2

package/lib/rules/callback-return.js

@@ -3,6 +3,7 @@
  * See LICENSE file in root directory for full license.
  */
 "use strict"
+const { getSourceCode } = require("../util/eslint-compat")
 
 /** @type {import('eslint').Rule.RuleModule} */
 module.exports = {
@@ -27,7 +28,7 @@ module.exports = {
 
     create(context) {
         const callbacks = context.options[0] || ["callback", "cb", "next"]
-        const sourceCode = context.sourceCode ?? context.getSourceCode() // TODO: just use context.sourceCode when dropping eslint < v9
+        const sourceCode = getSourceCode(context)
 
         /**
          * Find the closest parent matching a list of types.

package/lib/rules/exports-style.js

@@ -5,6 +5,7 @@
 "use strict"
 
 const { hasParentNode } = require("../util/has-parent-node.js")
+const { getSourceCode, getScope } = require("../util/eslint-compat")
 
 /*istanbul ignore next */
 /**
@@ -302,7 +303,7 @@ module.exports = {
         const batchAssignAllowed = Boolean(
             context.options[1] != null && context.options[1].allowBatchAssign
         )
-        const sourceCode = context.sourceCode ?? context.getSourceCode() // TODO: just use context.sourceCode when dropping eslint < v9
+        const sourceCode = getSourceCode(context)
 
         /**
          * Gets the location info of reports.
@@ -426,8 +427,8 @@ module.exports = {
         }
 
         return {
-            "Program:exit"(node) {
-                const scope = sourceCode.getScope?.(node) ?? context.getScope() //TODO: remove context.getScope() when dropping support for ESLint < v9
+            "Program:exit"() {
+                const scope = getScope(context)
 
                 switch (mode) {
                     case "module.exports":

package/lib/rules/global-require.js

@@ -4,6 +4,8 @@
  */
 "use strict"
 
+const { getScope, getAncestors } = require("../util/eslint-compat")
+
 const ACCEPTABLE_PARENTS = [
     "AssignmentExpression",
     "VariableDeclarator",
@@ -59,26 +61,18 @@ module.exports = {
     },
 
     create(context) {
-        const sourceCode = context.sourceCode ?? context.getSourceCode() // TODO: just use context.sourceCode when dropping eslint < v9
-
         return {
             CallExpression(node) {
-                const currentScope =
-                    sourceCode.getScope?.(node) ?? context.getScope() //TODO: remove context.getScope() when dropping support for ESLint < v9
+                const currentScope = getScope(context, node)
 
                 if (
                     node.callee.type === "Identifier" &&
                     node.callee.name === "require" &&
                     !isShadowed(currentScope, node.callee)
                 ) {
-                    const isGoodRequire = (
-                        sourceCode.getAncestors?.(node) ??
-                        context.getAncestors()
-                    ) // TODO: remove context.getAncestors() when dropping support for ESLint < v9
-                        .every(
-                            parent =>
-                                ACCEPTABLE_PARENTS.indexOf(parent.type) > -1
-                        )
+                    const isGoodRequire = getAncestors(context, node).every(
+                        parent => ACCEPTABLE_PARENTS.indexOf(parent.type) > -1
+                    )
 
                     if (!isGoodRequire) {
                         context.report({ node, messageId: "unexpected" })

package/lib/rules/handle-callback-err.js

@@ -4,6 +4,8 @@
  */
 "use strict"
 
+const { getScope } = require("../util/eslint-compat")
+
 /** @type {import('eslint').Rule.RuleModule} */
 module.exports = {
     meta: {
@@ -25,7 +27,6 @@ module.exports = {
     },
 
     create(context) {
-        const sourceCode = context.sourceCode ?? context.getSourceCode() // TODO: just use context.sourceCode when dropping eslint < v9
         const errorArgument = context.options[0] || "err"
 
         /**
@@ -71,7 +72,7 @@ module.exports = {
          * @returns {void}
          */
         function checkForError(node) {
-            const scope = sourceCode.getScope?.(node) ?? context.getScope() //TODO: remove context.getScope() when dropping support for ESLint < v9
+            const scope = getScope(context, node)
             const parameters = getParameters(scope)
             const firstParameter = parameters[0]
 

package/lib/rules/hashbang.js

@@ -11,6 +11,7 @@ const getConvertPath = require("../util/get-convert-path")
 const { getPackageJson } = require("../util/get-package-json")
 const getNpmignore = require("../util/get-npmignore")
 const { isBinFile } = require("../util/is-bin-file")
+const { getSourceCode } = require("../util/eslint-compat")
 
 const ENV_SHEBANG = "#!/usr/bin/env"
 const NODE_SHEBANG = `${ENV_SHEBANG} {{executableName}}\n`
@@ -51,8 +52,9 @@ function isNodeShebang(shebang, executableName) {
  */
 function getExpectedExecutableName(context) {
     const extension = path.extname(context.filename ?? context.getFilename())
-    /** @type {{ executableMap: Record<string, string> }} */
-    const { executableMap = {} } = context.options?.[0] ?? {}
+    const { executableMap = {} } =
+        /** @type {[{ executableMap: Record<string, string> }]} */
+        (context.options)?.[0] ?? {}
 
     return executableMap[extension] ?? "node"
 }
@@ -119,7 +121,7 @@ module.exports = {
         },
     },
     create(context) {
-        const sourceCode = context.sourceCode ?? context.getSourceCode() // TODO: just use context.sourceCode when dropping eslint < v9
+        const sourceCode = getSourceCode(context)
         const filePath = context.filename ?? context.getFilename()
         if (filePath === "<input>") {
             return {}

package/lib/rules/no-deprecated-api.js

@@ -15,6 +15,7 @@ const getConfiguredNodeVersion = require("../util/get-configured-node-version")
 const getSemverRange = require("../util/get-semver-range")
 const extendTrackmapWithNodePrefix = require("../util/extend-trackmap-with-node-prefix")
 const unprefixNodeColon = require("../util/unprefix-node-colon")
+const { getScope } = require("../util/eslint-compat")
 
 /** @typedef {import('../unsupported-features/types.js').DeprecatedInfo} DeprecatedInfo */
 /**
@@ -737,7 +738,10 @@ function toName(type, path) {
  * @returns {ParsedOptions} Parsed options
  */
 function parseOptions(context) {
-    const raw = context.options[0] || {}
+    const raw = /** @type {{
+        ignoreModuleItems?: string[];
+        ignoreGlobalItems?: string[];
+    }} */ (context.options[0] || {})
     const version = getConfiguredNodeVersion(context)
     const ignoredModuleItems = new Set(raw.ignoreModuleItems || [])
     const ignoredGlobalItems = new Set(raw.ignoreGlobalItems || [])
@@ -820,10 +824,9 @@ module.exports = {
             })
         }
 
-        const sourceCode = context.sourceCode ?? context.getSourceCode() // TODO: just use context.sourceCode when dropping eslint < v9
         return {
-            "Program:exit"(node) {
-                const scope = sourceCode.getScope?.(node) ?? context.getScope() //TODO: remove context.getScope() when dropping support for ESLint < v9
+            "Program:exit"() {
+                const scope = getScope(context)
 
                 const tracker = new ReferenceTracker(scope, {
                     mode: "legacy",

package/lib/rules/no-exports-assign.js

@@ -5,6 +5,7 @@
 "use strict"
 
 const { findVariable } = require("@eslint-community/eslint-utils")
+const { getScope } = require("../util/eslint-compat")
 
 /**
  * @param {import('estree').Node} node
@@ -61,11 +62,9 @@ module.exports = {
         type: "problem",
     },
     create(context) {
-        const sourceCode = context.sourceCode ?? context.getSourceCode() // TODO: just use context.sourceCode when dropping eslint < v9
-
         return {
             AssignmentExpression(node) {
-                const scope = sourceCode.getScope?.(node) ?? context.getScope() //TODO: remove context.getScope() when dropping support for ESLint < v9
+                const scope = getScope(context)
 
                 if (
                     !isExports(node.left, scope) ||

package/lib/rules/no-path-concat.js

@@ -11,6 +11,7 @@ const {
     getStringIfConstant,
 } = require("@eslint-community/eslint-utils")
 const { hasParentNode } = require("../util/has-parent-node.js")
+const { getSourceCode } = require("../util/eslint-compat")
 
 /**
  * Get the first char of the specified template element.
@@ -195,7 +196,7 @@ module.exports = {
     create(context) {
         return {
             "Program:exit"(programNode) {
-                const sourceCode = context.sourceCode ?? context.getSourceCode() // TODO: just use context.sourceCode when dropping eslint < v9
+                const sourceCode = getSourceCode(context)
                 const globalScope =
                     sourceCode.getScope?.(programNode) ?? context.getScope()
                 const tracker = new ReferenceTracker(globalScope)

package/lib/rules/no-unsupported-features/es-syntax.js

@@ -10,6 +10,7 @@ const rangeSubset = require("semver/ranges/subset")
 const getConfiguredNodeVersion = require("../../util/get-configured-node-version")
 const getSemverRange = require("../../util/get-semver-range")
 const mergeVisitorsInPlace = require("../../util/merge-visitors-in-place")
+const { getScope } = require("../../util/eslint-compat")
 /** @type {Record<string, ESSyntax>} */
 const features = require("./es-syntax.json")
 
@@ -113,8 +114,7 @@ function normalizeScope(initialScope, node) {
  * @returns {boolean}
  */
 function isStrict(context, node) {
-    const sourceCode = context.sourceCode ?? context.getSourceCode() // TODO: just use context.sourceCode when dropping eslint < v9
-    const scope = sourceCode.getScope?.(node) ?? context.getScope() //TODO: remove context.getScope() when dropping support for ESLint < v9
+    const scope = getScope(context)
     return normalizeScope(scope, node).isStrict
 }
 

package/lib/rules/prefer-node-protocol.js

@@ -4,12 +4,13 @@
  */
 "use strict"
 
+const { getStringIfConstant } = require("@eslint-community/eslint-utils")
+
 const { Range } = require("semver")
 
 const getConfiguredNodeVersion = require("../util/get-configured-node-version")
-const visitImport = require("../util/visit-import")
-const visitRequire = require("../util/visit-require")
-const mergeVisitorsInPlace = require("../util/merge-visitors-in-place")
+const stripImportPathParams = require("../util/strip-import-path-params")
+
 const {
     NodeBuiltinModules,
 } = require("../unsupported-features/node-builtins.js")
@@ -27,6 +28,104 @@ const messageId = "preferNodeProtocol"
 const supportedRangeForEsm = new Range("^12.20.0 || >= 14.13.1")
 const supportedRangeForCjs = new Range("^14.18.0 || >= 16.0.0")
 
+/**
+ * @param {import('estree').Node} [node]
+ * @returns {node is import('estree').Literal}
+ */
+function isStringLiteral(node) {
+    return node?.type === "Literal" && typeof node.type === "string"
+}
+
+/**
+ * @param {import('eslint').Rule.RuleContext} context
+ * @param {import('../util/import-target.js').ModuleStyle} moduleStyle
+ * @returns {boolean}
+ */
+function isEnablingThisRule(context, moduleStyle) {
+    const version = getConfiguredNodeVersion(context)
+
+    // Only check Node.js version because this rule is meaningless if configured Node.js version doesn't match semver range.
+    if (!version.intersects(supportedRangeForEsm)) {
+        return false
+    }
+
+    // Only check when using `require`
+    if (
+        moduleStyle === "require" &&
+        !version.intersects(supportedRangeForCjs)
+    ) {
+        return false
+    }
+
+    return true
+}
+
+/**
+ * @param {import('estree').Node} node
+ * @returns {boolean}
+ **/
+function isValidRequireArgument(node) {
+    const rawName = getStringIfConstant(node)
+    if (typeof rawName !== "string") {
+        return false
+    }
+
+    const name = stripImportPathParams(rawName)
+    if (!isBuiltin(name)) {
+        return false
+    }
+
+    return true
+}
+
+/**
+ * @param {import('estree').Node | null | undefined} node
+ * @param {import('eslint').Rule.RuleContext} context
+ * @param {import('../util/import-target.js').ModuleStyle} moduleStyle
+ */
+function validate(node, context, moduleStyle) {
+    if (node == null) {
+        return
+    }
+
+    if (!isEnablingThisRule(context, moduleStyle)) {
+        return
+    }
+
+    if (!isStringLiteral(node)) {
+        return
+    }
+
+    if (moduleStyle === "require" && !isValidRequireArgument(node)) {
+        return
+    }
+
+    if (
+        !("value" in node) ||
+        typeof node.value !== "string" ||
+        node.value.startsWith("node:") ||
+        !isBuiltin(node.value) ||
+        !isBuiltin(`node:${node.value}`)
+    ) {
+        return
+    }
+
+    context.report({
+        node,
+        messageId,
+        data: {
+            moduleName: node.value,
+        },
+        fix(fixer) {
+            const firstCharacterIndex = (node?.range?.[0] ?? 0) + 1
+            return fixer.replaceTextRange(
+                [firstCharacterIndex, firstCharacterIndex],
+                "node:"
+            )
+        },
+    })
+}
+
 /** @type {import('eslint').Rule.RuleModule} */
 module.exports = {
     meta: {
@@ -52,139 +151,36 @@ module.exports = {
         type: "suggestion",
     },
     create(context) {
-        /**
-         * @param {import('estree').Node} node
-         * @param {object} options
-         * @param {string} options.name
-         * @param {number} options.argumentsLength
-         * @returns {node is import('estree').CallExpression}
-         */
-        function isCallExpression(node, { name, argumentsLength }) {
-            if (node?.type !== "CallExpression") {
-                return false
-            }
-
-            if (node.optional) {
-                return false
-            }
-
-            if (node.arguments.length !== argumentsLength) {
-                return false
-            }
-
-            if (
-                node.callee.type !== "Identifier" ||
-                node.callee.name !== name
-            ) {
-                return false
-            }
-
-            return true
-        }
-
-        /**
-         * @param {import('estree').Node} [node]
-         * @returns {node is import('estree').Literal}
-         */
-        function isStringLiteral(node) {
-            return node?.type === "Literal" && typeof node.type === "string"
-        }
-
-        /**
-         * @param {import('estree').Node | undefined} node
-         * @returns {node is import('estree').CallExpression}
-         */
-        function isStaticRequire(node) {
-            return (
-                node != null &&
-                isCallExpression(node, {
-                    name: "require",
-                    argumentsLength: 1,
-                }) &&
-                isStringLiteral(node.arguments[0])
-            )
-        }
-
-        /**
-         * @param {import('eslint').Rule.RuleContext} context
-         * @param {import('../util/import-target.js').ModuleStyle} moduleStyle
-         * @returns {boolean}
-         */
-        function isEnablingThisRule(context, moduleStyle) {
-            const version = getConfiguredNodeVersion(context)
-
-            // Only check Node.js version because this rule is meaningless if configured Node.js version doesn't match semver range.
-            if (!version.intersects(supportedRangeForEsm)) {
-                return false
-            }
-
-            // Only check when using `require`
-            if (
-                moduleStyle === "require" &&
-                !version.intersects(supportedRangeForCjs)
-            ) {
-                return false
-            }
-
-            return true
-        }
+        return {
+            CallExpression(node) {
+                if (node.type !== "CallExpression") {
+                    return
+                }
+
+                if (
+                    node.optional ||
+                    node.arguments.length !== 1 ||
+                    node.callee.type !== "Identifier" ||
+                    node.callee.name !== "require"
+                ) {
+                    return
+                }
+
+                return validate(node.arguments[0], context, "require")
+            },
 
-        /** @type {import('../util/import-target.js')[]} */
-        const targets = []
-        return [
-            visitImport(context, { includeCore: true }, importTargets => {
-                targets.push(...importTargets)
-            }),
-            visitRequire(context, { includeCore: true }, requireTargets => {
-                targets.push(
-                    ...requireTargets.filter(target =>
-                        isStaticRequire(target.node.parent)
-                    )
-                )
-            }),
-            {
-                "Program:exit"() {
-                    for (const { node, moduleStyle } of targets) {
-                        if (!isEnablingThisRule(context, moduleStyle)) {
-                            continue
-                        }
-
-                        if (node.type === "TemplateLiteral") {
-                            continue
-                        }
-
-                        if (
-                            !("value" in node) ||
-                            typeof node.value !== "string" ||
-                            node.value.startsWith("node:") ||
-                            !isBuiltin(node.value) ||
-                            !isBuiltin(`node:${node.value}`)
-                        ) {
-                            continue
-                        }
-
-                        context.report({
-                            node,
-                            messageId,
-                            data: {
-                                moduleName: node.value,
-                            },
-                            fix(fixer) {
-                                const firstCharacterIndex =
-                                    (node?.range?.[0] ?? 0) + 1
-                                return fixer.replaceTextRange(
-                                    [firstCharacterIndex, firstCharacterIndex],
-                                    "node:"
-                                )
-                            },
-                        })
-                    }
-                },
+            ExportAllDeclaration(node) {
+                return validate(node.source, context, "import")
             },
-        ].reduce(
-            (mergedVisitor, thisVisitor) =>
-                mergeVisitorsInPlace(mergedVisitor, thisVisitor),
-            {}
-        )
+            ExportNamedDeclaration(node) {
+                return validate(node.source, context, "import")
+            },
+            ImportDeclaration(node) {
+                return validate(node.source, context, "import")
+            },
+            ImportExpression(node) {
+                return validate(node.source, context, "import")
+            },
+        }
     },
 }

package/lib/rules/prefer-promises/dns.js

@@ -9,6 +9,7 @@ const {
     CONSTRUCT,
     ReferenceTracker,
 } = require("@eslint-community/eslint-utils")
+const { getScope } = require("../../util/eslint-compat")
 
 /** @type {import('@eslint-community/eslint-utils').TraceMap<boolean>} */
 const dns = {
@@ -57,9 +58,8 @@ module.exports = {
 
     create(context) {
         return {
-            "Program:exit"(node) {
-                const sourceCode = context.sourceCode ?? context.getSourceCode() // TODO: just use context.sourceCode when dropping eslint < v9
-                const scope = sourceCode.getScope?.(node) ?? context.getScope() //TODO: remove context.getScope() when dropping support for ESLint < v9
+            "Program:exit"() {
+                const scope = getScope(context)
                 const tracker = new ReferenceTracker(scope, { mode: "legacy" })
                 const references = [
                     ...tracker.iterateCjsReferences(traceMap),

package/lib/rules/prefer-promises/fs.js

@@ -5,6 +5,7 @@
 "use strict"
 
 const { CALL, ReferenceTracker } = require("@eslint-community/eslint-utils")
+const { getScope } = require("../../util/eslint-compat")
 
 /** @type {import('@eslint-community/eslint-utils').TraceMap<boolean>} */
 const traceMap = {
@@ -55,9 +56,8 @@ module.exports = {
 
     create(context) {
         return {
-            "Program:exit"(node) {
-                const sourceCode = context.sourceCode ?? context.getSourceCode() // TODO: just use context.sourceCode when dropping eslint < v9
-                const scope = sourceCode.getScope?.(node) ?? context.getScope() //TODO: remove context.getScope() when dropping support for ESLint < v9
+            "Program:exit"() {
+                const scope = getScope(context)
                 const tracker = new ReferenceTracker(scope, { mode: "legacy" })
                 const references = [
                     ...tracker.iterateCjsReferences(traceMap),

package/lib/util/check-prefer-global.js

@@ -5,7 +5,7 @@
 "use strict"
 
 const { ReferenceTracker } = require("@eslint-community/eslint-utils")
-
+const { getScope } = require("../util/eslint-compat")
 /**
  * @typedef TraceMap
  * @property {import('@eslint-community/eslint-utils').TraceMap<boolean>} globals
@@ -36,9 +36,7 @@ class Verifier {
      */
     verifyToPreferGlobals() {
         const { context, traceMap } = this
-        const sourceCode = context.sourceCode ?? context.getSourceCode() // TODO: just use context.sourceCode when dropping eslint < v9
-        const scope =
-            sourceCode.getScope?.(sourceCode.ast) ?? context.getScope() //TODO: remove context.getScope() when dropping support for ESLint < v9
+        const scope = getScope(context)
         const tracker = new ReferenceTracker(scope, {
             mode: "legacy",
         })
@@ -57,9 +55,7 @@ class Verifier {
      */
     verifyToPreferModules() {
         const { context, traceMap } = this
-        const sourceCode = context.sourceCode ?? context.getSourceCode() // TODO: just use context.sourceCode when dropping eslint < v9
-        const scope =
-            sourceCode.getScope?.(sourceCode.ast) ?? context.getScope() //TODO: remove context.getScope() when dropping support for ESLint < v9
+        const scope = getScope(context)
         const tracker = new ReferenceTracker(scope)
 
         for (const { node } of tracker.iterateGlobalReferences(

package/lib/util/check-restricted.js

@@ -96,7 +96,9 @@ function createRestrictions(defs) {
  * @returns {void}
  */
 exports.checkForRestriction = function checkForRestriction(context, targets) {
-    const restrictions = createRestrictions(context.options[0])
+    const restrictions = createRestrictions(
+        /** @type {string[]} */ (context.options[0])
+    )
 
     for (const target of targets) {
         const restriction = restrictions.find(r => r.match(target))

package/lib/util/check-unsupported-builtins.js

@@ -10,6 +10,7 @@ const getConfiguredNodeVersion = require("./get-configured-node-version")
 const getSemverRange = require("./get-semver-range")
 const unprefixNodeColon = require("./unprefix-node-colon")
 const semverRangeSubset = require("semver/ranges/subset")
+const { getScope } = require("../util/eslint-compat")
 
 /**
  * Parses the options.
@@ -21,7 +22,10 @@ const semverRangeSubset = require("semver/ranges/subset")
  * }>} Parsed value.
  */
 function parseOptions(context) {
-    const raw = context.options[0] || {}
+    const raw = /** @type {{
+     *   ignores?: string[];
+     *   allowExperimental?: boolean;
+     * }} */ (context.options[0] || {})
     const version = getConfiguredNodeVersion(context)
     const ignores = new Set(raw.ignores || [])
     const allowExperimental = raw.allowExperimental ?? false
@@ -86,8 +90,7 @@ module.exports.checkUnsupportedBuiltins = function checkUnsupportedBuiltins(
     traceMap
 ) {
     const options = parseOptions(context)
-    const sourceCode = context.sourceCode ?? context.getSourceCode() // TODO: just use context.sourceCode when dropping eslint < v9
-    const scope = sourceCode.getScope?.(sourceCode.ast) ?? context.getScope() //TODO: remove context.getScope() when dropping support for ESLint < v9
+    const scope = getScope(context)
     const tracker = new ReferenceTracker(scope, { mode: "legacy" })
     const references = [
         ...tracker.iterateCjsReferences(traceMap.modules ?? {}),

package/lib/util/eslint-compat.js

@@ -0,0 +1,43 @@
+/**
+ * @fileoverview Utilities for eslint compatibility.
+ * @see https://eslint.org/docs/latest/use/migrate-to-9.0.0#removed-context-methods
+ * @author aladdin-add<weiran.zsd@outlook.com>
+ */
+"use strict"
+
+/** @import { Rule } from 'eslint' */
+/** @typedef {import('estree').Node} Node */
+
+exports.getSourceCode = function (/** @type Rule.RuleContext */ context) {
+    return context.sourceCode || context.getSourceCode()
+}
+
+exports.getScope = function (
+    /** @type {Rule.RuleContext} */ context,
+    /** @type {Node} */ node
+) {
+    const sourceCode = exports.getSourceCode(context)
+    return sourceCode.getScope?.(node || sourceCode.ast) || context.getScope()
+}
+
+exports.getAncestors = function (
+    /** @type {Rule.RuleContext} */ context,
+    /** @type {Node} */ node
+) {
+    const sourceCode = exports.getSourceCode(context)
+    return sourceCode.getAncestors?.(node) || context.getAncestors()
+}
+
+exports.getCwd = function (/** @type {Rule.RuleContext} */ context) {
+    return context.cwd || context.getCwd()
+}
+
+exports.getPhysicalFilename = function (
+    /** @type {Rule.RuleContext} */ context
+) {
+    return context.physicalFilename || context.getPhysicalFilename?.()
+}
+
+exports.getFilename = function (/** @type {Rule.RuleContext} */ context) {
+    return context.filename || context.getFilename?.()
+}

package/lib/util/get-allow-modules.js

@@ -9,10 +9,14 @@
  */
 const DEFAULT_VALUE = []
 
+/**
+ * @typedef {{allowModules:? string[]}|undefined} Option
+ */
+
 /**
  * Gets `allowModules` property from a given option object.
  *
- * @param {{allowModules:? string[]}|undefined} option - An option object to get.
+ * @param {Option} option - An option object to get.
  * @returns {string[]|null} The `allowModules` value, or `null`.
  */
 function get(option) {
@@ -34,9 +38,9 @@ function get(option) {
  */
 module.exports = function getAllowModules(context) {
     return (
-        get(context.options[0]) ??
-        get(context.settings?.n) ??
-        get(context.settings?.node) ??
+        get(/** @type {Option} */ (context.options[0])) ??
+        get(/** @type {Option} */ (context.settings?.n)) ??
+        get(/** @type {Option} */ (context.settings?.node)) ??
         DEFAULT_VALUE
     )
 }

package/lib/util/get-configured-node-version.js

@@ -10,10 +10,14 @@ const getSemverRange = require("./get-semver-range")
 
 const fallbackRange = new Range(">=16.0.0")
 
+/**
+ * @typedef {{ version:? string } | undefined} VersionOption
+ */
+
 /**
  * Gets `version` property from a given option object.
  *
- * @param {Record<string, string>|undefined} option - An option object to get.
+ * @param {VersionOption} option - An option object to get.
  * @returns {import("semver").Range|undefined} The `allowModules` value, or `null`.
  */
 function getVersionRange(option) {
@@ -55,9 +59,11 @@ function getEnginesNode(context) {
  */
 module.exports = function getConfiguredNodeVersion(context) {
     return (
-        getVersionRange(context.options?.[0]) ??
-        getVersionRange(context.settings?.n) ??
-        getVersionRange(context.settings?.node) ??
+        getVersionRange(/** @type {VersionOption} */ (context.options?.[0])) ??
+        getVersionRange(/** @type {VersionOption} */ (context.settings?.n)) ??
+        getVersionRange(
+            /** @type {VersionOption} */ (context.settings?.node)
+        ) ??
         getEnginesNode(context) ??
         fallbackRange
     )

package/lib/util/get-convert-path.js

@@ -111,10 +111,14 @@ function combine(converters) {
     }
 }
 
+/**
+ * @typedef {{ convertPath?: ConvertPath } | undefined} ConvertPathOption
+ */
+
 /**
  * Parses `convertPath` property from a given option object.
  *
- * @param {{convertPath?: ConvertPath}|undefined} option - An option object to get.
+ * @param {ConvertPathOption} option - An option object to get.
  * @returns {Converter['convert']|null} A function which converts a path., or `null`.
  */
 function parse(option) {
@@ -148,9 +152,9 @@ function parse(option) {
  */
 module.exports = function getConvertPath(context) {
     return (
-        parse(context.options?.[0]) ??
-        parse(context.settings?.n) ??
-        parse(context.settings?.node) ??
+        parse(/** @type {ConvertPathOption} */ (context.options?.[0])) ??
+        parse(/** @type {ConvertPathOption} */ (context.settings?.n)) ??
+        parse(/** @type {ConvertPathOption} */ (context.settings?.node)) ??
         identity
     )
 }

package/lib/util/get-resolve-paths.js

@@ -10,11 +10,16 @@ const DEFAULT_VALUE = []
 /**
  * Gets `resolvePaths` property from a given option object.
  *
- * @param {{ resolvePaths: unknown[] } | undefined} option - An option object to get.
+ * @param {unknown} option - An option object to get.
  * @returns {string[] | undefined} The `allowModules` value, or `null`.
  */
 function get(option) {
-    if (Array.isArray(option?.resolvePaths)) {
+    if (
+        option != null &&
+        typeof option === "object" &&
+        "resolvePaths" in option &&
+        Array.isArray(option?.resolvePaths)
+    ) {
         return option.resolvePaths.map(String)
     }
 }

package/lib/util/get-resolver-config.js

@@ -11,10 +11,14 @@
 /** @type {ResolverConfig} */
 const DEFAULT_VALUE = {}
 
+/**
+ * @typedef {{ resolverConfig?: ResolverConfig } | undefined} ResolverConfigOption
+ */
+
 /**
  * Gets `resolverConfig` property from a given option object.
  *
- * @param {{ resolverConfig: ResolverConfig } | undefined} option - An option object to get.
+ * @param {ResolverConfigOption} option - An option object to get.
  * @returns {ResolverConfig | undefined} The `allowModules` value, or `null`.
  */
 function get(option) {
@@ -33,9 +37,11 @@ function get(option) {
  */
 module.exports = function getResolverConfig(context, optionIndex = 0) {
     return (
-        get(context.options?.[optionIndex]) ??
-        get(context.settings?.n) ??
-        get(context.settings?.node) ??
+        get(
+            /** @type {ResolverConfigOption} */ (context.options?.[optionIndex])
+        ) ??
+        get(/** @type {ResolverConfigOption} */ (context.settings?.n)) ??
+        get(/** @type {ResolverConfigOption} */ (context.settings?.node)) ??
         DEFAULT_VALUE
     )
 }

package/lib/util/get-try-extensions.js

@@ -24,11 +24,16 @@ const DEFAULT_TS_VALUE = [
 /**
  * Gets `tryExtensions` property from a given option object.
  *
- * @param {{ tryExtensions: unknown[] } | undefined} option - An option object to get.
+ * @param {unknown} option - An option object to get.
  * @returns {string[] | undefined} The `tryExtensions` value, or `null`.
  */
 function get(option) {
-    if (Array.isArray(option?.tryExtensions)) {
+    if (
+        option != null &&
+        typeof option === "object" &&
+        "tryExtensions" in option &&
+        Array.isArray(option?.tryExtensions)
+    ) {
         return option.tryExtensions.map(String)
     }
 }

package/lib/util/get-tsconfig.js

@@ -1,6 +1,7 @@
 "use strict"
 
 const { getTsconfig, parseTsconfig } = require("get-tsconfig")
+const { getPhysicalFilename, getFilename } = require("./eslint-compat")
 const fsCache = new Map()
 
 /**
@@ -30,12 +31,7 @@ function getTSConfigForFile(filename) {
  * @returns {import("get-tsconfig").TsConfigResult | null}
  */
 function getTSConfigForContext(context) {
-    // TODO: remove context.get(PhysicalFilename|Filename) when dropping eslint < v10
-    const filename =
-        context.physicalFilename ??
-        context.getPhysicalFilename?.() ??
-        context.filename ??
-        context.getFilename?.()
+    const filename = getPhysicalFilename(context) ?? getFilename(context)
 
     return getTSConfigForFile(filename)
 }

package/lib/util/get-typescript-extension-map.js

@@ -129,8 +129,12 @@ function getFromTSConfigFromFile(context) {
  */
 module.exports = function getTypescriptExtensionMap(context) {
     return (
-        get(context.options?.[0]) ||
-        get(context.settings?.n ?? context.settings?.node) ||
+        get(/** @type {Options} */ (context.options?.[0])) ||
+        get(
+            /** @type {Options} */ (
+                context.settings?.n ?? context.settings?.node
+            )
+        ) ||
         getFromTSConfigFromFile(context) ||
         PRESERVE_MAPPING
     )

package/lib/util/import-target.js

@@ -176,6 +176,20 @@ module.exports = class ImportTarget {
             return "node"
         }
 
+        // This check should be done before the RegExp that checks npm packages,
+        // because `tsconfig.json` aliases may start with `~`, `@` and this will
+        // cause imports using aliases to be treated as npm-module imports
+        // https://github.com/eslint-community/eslint-plugin-n/issues/379
+        if (isTypescript(this.context)) {
+            const aliases = getTSConfigAliases(this.context)
+            if (
+                Array.isArray(aliases) &&
+                aliases.some(alias => this.name.startsWith(alias.name))
+            ) {
+                return "relative"
+            }
+        }
+
         if (/^(@[\w~-][\w.~-]*\/)?[\w~-][\w.~-]*/.test(this.name)) {
             return "npm"
         }
@@ -331,7 +345,11 @@ module.exports = class ImportTarget {
 
         const requireResolve = resolver.create.sync(this.resolverConfig)
 
-        const cwd = this.context.settings?.cwd ?? process.cwd()
+        const cwd =
+            typeof this.context.settings?.cwd === "string"
+                ? this.context.settings?.cwd
+                : process.cwd()
+
         for (const directory of this.getPaths()) {
             const baseDir = resolve(cwd, directory)
 

package/lib/util/is-typescript.js

@@ -1,6 +1,7 @@
 "use strict"
 
 const path = require("path")
+const { getPhysicalFilename, getFilename } = require("./eslint-compat")
 
 const typescriptExtensions = [".ts", ".tsx", ".cts", ".mts"]
 
@@ -12,10 +13,7 @@ const typescriptExtensions = [".ts", ".tsx", ".cts", ".mts"]
  */
 module.exports = function isTypescript(context) {
     const sourceFileExt = path.extname(
-        context.physicalFilename ??
-            context.getPhysicalFilename?.() ??
-            context.filename ??
-            context.getFilename?.()
+        getPhysicalFilename(context) ?? getFilename(context)
     )
     return typescriptExtensions.includes(sourceFileExt)
 }

package/lib/util/visit-import.js

@@ -11,7 +11,7 @@ const getResolverConfig = require("./get-resolver-config")
 const getTryExtensions = require("./get-try-extensions")
 const ImportTarget = require("./import-target")
 const stripImportPathParams = require("./strip-import-path-params")
-
+const { getFilename } = require("./eslint-compat")
 /** @typedef {import('@typescript-eslint/typescript-estree').TSESTree.ImportDeclaration} ImportDeclaration */
 
 /**
@@ -38,9 +38,7 @@ module.exports = function visitImport(
 ) {
     /** @type {import('./import-target.js')[]} */
     const targets = []
-    const basedir = path.dirname(
-        path.resolve(context.filename ?? context.getFilename())
-    )
+    const basedir = path.dirname(path.resolve(getFilename(context)))
     const paths = getResolvePaths(context, optionIndex)
     const resolverConfig = getResolverConfig(context, optionIndex)
     const extensions = getTryExtensions(context, optionIndex)

package/lib/util/visit-require.js

@@ -16,6 +16,7 @@ const getResolverConfig = require("./get-resolver-config")
 const getTryExtensions = require("./get-try-extensions")
 const ImportTarget = require("./import-target")
 const stripImportPathParams = require("./strip-import-path-params")
+const { getScope, getFilename } = require("../util/eslint-compat")
 
 /**
  * @typedef VisitRequireOptions
@@ -39,20 +40,15 @@ module.exports = function visitRequire(
 ) {
     /** @type {import('./import-target.js')[]} */
     const targets = []
-    const basedir = path.dirname(
-        path.resolve(context.filename ?? context.getFilename())
-    )
+    const basedir = path.dirname(path.resolve(getFilename(context)))
     const paths = getResolvePaths(context)
     const resolverConfig = getResolverConfig(context)
     const extensions = getTryExtensions(context)
     const options = { basedir, paths, extensions, resolverConfig }
 
     return {
-        "Program:exit"(node) {
-            const sourceCode = context.sourceCode ?? context.getSourceCode() // TODO: just use context.sourceCode when dropping eslint < v9
-            const tracker = new ReferenceTracker(
-                sourceCode.getScope?.(node) ?? context.getScope() //TODO: remove context.getScope() when dropping support for ESLint < v9
-            )
+        "Program:exit"() {
+            const tracker = new ReferenceTracker(getScope(context))
             const references = tracker.iterateGlobalReferences({
                 require: {
                     [CALL]: true,

package/package.json

@@ -1,11 +1,12 @@
 {
     "name": "eslint-plugin-n",
-    "version": "17.15.1",
+    "version": "17.16.2",
     "description": "Additional ESLint's rules for Node.js",
     "engines": {
         "node": "^18.18.0 || ^20.9.0 || >=21.1.0"
     },
     "main": "lib/index.js",
+    "type": "commonjs",
     "types": "types/index.d.ts",
     "files": [
         "lib/",