ember-inspector 4.13.1-alpha.2024.8.9 → 4.13.1-alpha.2025.6.7

package/ember_debug/object-inspector.js

@@ -27,7 +27,7 @@ import { EmberLoader } from 'ember-debug/utils/ember/loader';
 const GlimmerComponent = (() => {
   try {
     return EmberLoader.require('@glimmer/component').default;
-  } catch (e) {
+  } catch {
     // ignore, return undefined
   }
 })();
@@ -70,14 +70,14 @@ try {
     }
     return r;
   };
-} catch (e) {
+} catch {
   try {
     // Fallback to the previous implementation
     let GlimmerReference = EmberLoader.require('@glimmer/reference');
 
     tagValue = GlimmerReference.value;
     tagValidate = GlimmerReference.validate;
-  } catch (e) {
+  } catch {
     // ignore
   }
 }
@@ -88,7 +88,7 @@ try {
   tagForProperty = metal.tagForProperty;
   // If track was not already loaded, use metal's version (the previous version)
   track = track || metal.track;
-} catch (e) {
+} catch {
   // ignore
 }
 
@@ -178,7 +178,7 @@ function getTrackedDependencies(object, property, tagInfo) {
   const dependentKeys = [];
   if (cpDesc) {
     dependentKeys.push(
-      ...(cpDesc._dependentKeys || []).map((k) => ({ name: k }))
+      ...(cpDesc._dependentKeys || []).map((k) => ({ name: k })),
     );
   }
   if (HAS_GLIMMER_TRACKING) {
@@ -309,7 +309,7 @@ export default class extends DebugPort {
                 dependentKeys = getTrackedDependencies(
                   object,
                   item.name,
-                  tracked[item.name]
+                  tracked[item.name],
                 );
                 tracked[item.name].revision = tagValue(tracked[item.name].tag);
               }
@@ -324,7 +324,7 @@ export default class extends DebugPort {
                 dependentKeys,
               });
             }
-          } catch (e) {
+          } catch {
             // dont do anything
           }
         });
@@ -332,6 +332,7 @@ export default class extends DebugPort {
     }
   }
 
+  // eslint-disable-next-line ember/classic-decorator-hooks
   init() {
     super.init();
     this.sentObjects = {};
@@ -370,7 +371,7 @@ export default class extends DebugPort {
         value = this.valueForObjectProperty(
           message.objectId,
           message.property,
-          message.mixinIndex
+          message.mixinIndex,
         );
         if (value) {
           this.sendMessage('updateProperty', value);
@@ -451,7 +452,7 @@ export default class extends DebugPort {
           }
           this.adapter.log(
             `Object Inspector error for ${error.property}`,
-            stack
+            stack,
           );
         });
       },
@@ -546,7 +547,7 @@ export default class extends DebugPort {
   sendObject(object) {
     if (!this.canSend(object)) {
       throw new Error(
-        `Can't inspect ${object}. Only Ember objects and arrays are supported.`
+        `Can't inspect ${object}. Only Ember objects and arrays are supported.`,
       );
     }
     let details = this.mixinsForObject(object);
@@ -670,7 +671,7 @@ export default class extends DebugPort {
           if (name === '(unknown)') {
             name = '(unknown mixin)';
           }
-        } catch (e) {
+        } catch {
           name = '(Unable to convert Object to string)';
         }
       }
@@ -745,7 +746,7 @@ export default class extends DebugPort {
       mixinDetails,
       errorsForObject,
       expensiveProperties,
-      tracked
+      tracked,
     );
 
     this.currentObject = { object, mixinDetails, objectId };
@@ -764,7 +765,7 @@ export default class extends DebugPort {
       value = calculateCP(
         object,
         { name: property },
-        this._errorsFor[objectId]
+        this._errorsFor[objectId],
       );
     }
 
@@ -934,7 +935,7 @@ function addProperties(properties, hash) {
     if (isComputed(hash, prop)) {
       options.isComputed = true;
       options.dependentKeys = (desc._dependentKeys || []).map((key) =>
-        key.toString()
+        key.toString(),
       );
 
       if (typeof desc.get === 'function') {
@@ -1085,7 +1086,7 @@ function calculateCPs(
   mixinDetails,
   errorsForObject,
   expensiveProperties,
-  tracked
+  tracked,
 ) {
   expensiveProperties = expensiveProperties || [];
   mixinDetails.forEach((mixin) => {
@@ -1113,7 +1114,7 @@ function calculateCPs(
             item.dependentKeys = getTrackedDependencies(
               object,
               item.name,
-              tagInfo
+              tagInfo,
             );
             tagInfo.revision = tagValue(tagInfo.tag);
           } else {
@@ -1282,7 +1283,7 @@ function getDebugInfo(object) {
       'domManager',
       'states',
       'element',
-      'targetObject'
+      'targetObject',
     );
   } else if (GlimmerComponent && object instanceof GlimmerComponent) {
     // These properties don't really exist on Glimmer Components, but
@@ -1304,7 +1305,7 @@ function calculateCP(object, item, errorsForObject) {
   delete errorsForObject[property];
   try {
     if (object instanceof ArrayProxy && property == parseInt(property)) {
-      return object.objectAt(property);
+      return object.at(property);
     }
     return item.isGetter || property.includes?.('.')
       ? object[property]

package/ember_debug/port.js

@@ -35,6 +35,7 @@ export default class extends BaseObject {
     return guidFor(this.namespace?._application, 'ember');
   }
 
+  // eslint-disable-next-line ember/classic-decorator-hooks
   init() {
     /**
      * Stores the timestamp when it was first accessed.

package/ember_debug/promise-debug.js

@@ -134,7 +134,7 @@ export default class extends DebugPort {
     }
     // Remove inspector-created promises
     uniquePromises = uniquePromises.filter(
-      (promise) => promise.label !== 'ember-inspector'
+      (promise) => promise.label !== 'ember-inspector',
     );
     const serialized = this.serializeArray(uniquePromises);
     this.sendMessage('promisesUpdated', {

package/ember_debug/route-debug.js

@@ -11,6 +11,8 @@ const { hasOwnProperty } = Object.prototype;
 
 export default class RouteDebug extends DebugPort {
   _cachedRouteTree = null;
+
+  // eslint-disable-next-line ember/classic-decorator-hooks
   init() {
     super.init();
     this.__currentURL = this.currentURL;
@@ -67,7 +69,6 @@ export default class RouteDebug extends DebugPort {
     };
   }
 
-  // eslint-disable-next-line ember/no-observers
   sendCurrentRoute() {
     const { currentPath: name, currentURL: url } = this;
     later(() => {
@@ -133,7 +134,7 @@ export default class RouteDebug extends DebugPort {
         // Module exists and found
         className = className.replace(
           new RegExp(`^/?(${prefix}|${podPrefix})/${type}s/`),
-          ''
+          '',
         );
       } else {
         // Module does not exist

package/ember_debug/services/session.js

@@ -12,7 +12,7 @@ try {
   if (typeof sessionStorage !== 'undefined') {
     SESSION_STORAGE_SUPPORTED = true;
   }
-} catch (e) {
+} catch {
   // This can be reached with the following succession of events:
   //
   //   1. On Google Chrome

package/ember_debug/utils/classify.js

@@ -18,6 +18,6 @@ export default function classify(str) {
   return parts
     .join('/')
     .replace(STRING_CLASSIFY_REGEXP_3, (match /*, separator, chr */) =>
-      match.toUpperCase()
+      match.toUpperCase(),
     );
 }

package/ember_debug/utils/ember/debug.js

@@ -9,10 +9,12 @@ try {
   inspect = module.inspect || requireModule('@ember/-internals/utils').inspect;
 } catch {
   module = Ember.Debug;
+  // eslint-disable-next-line ember/new-module-imports
   inspect = Ember.inspect;
 }
 
 if (!inspect) {
+  // eslint-disable-next-line ember/new-module-imports
   inspect = Ember.inspect;
 }
 

package/ember_debug/utils/ember/loader.js

@@ -3,7 +3,7 @@ import Ember from '../ember';
 const require = function (id) {
   try {
     return Ember.__loader.require(id);
-  } catch (e) {
+  } catch {
     return requireModule(id);
   }
 };
@@ -11,7 +11,7 @@ const require = function (id) {
 export function emberSafeRequire(id) {
   try {
     return require(id);
-  } catch (e) {
+  } catch {
     return undefined;
   }
 }

package/ember_debug/utils/ember/runloop.js

@@ -12,7 +12,9 @@ try {
   // then we need to use our own
   _backburner = module._backburner;
 } catch {
+  // eslint-disable-next-line ember/new-module-imports
   _backburner = Ember?.run?.backburner || module._backburner;
+  // eslint-disable-next-line ember/new-module-imports
   module = Ember?.run || module;
 }
 

package/ember_debug/utils/ember-object-names.js

@@ -34,7 +34,7 @@ const emberNames = new Map([
 
 if (compareVersion(VERSION, '3.27.0') === -1) {
   const TargetActionSupport = emberSafeRequire(
-    '@ember/-internals/runtime'
+    '@ember/-internals/runtime',
   )?.TargetActionSupport;
   emberNames.set(TargetActionSupport, 'TargetActionSupport Mixin');
 }
@@ -49,7 +49,7 @@ try {
   emberNames.set(Views.ViewStateSupport, 'ViewStateSupport  Mixin');
   // this one is not a Mixin, but an .extend({}), which results in a class
   emberNames.set(Views.CoreView, 'CoreView');
-} catch (e) {
+} catch {
   // do nothing
 }
 

package/ember_debug/utils/ember.js

@@ -3,7 +3,13 @@ import { emberSafeRequire } from 'ember-debug/utils/ember/loader';
 let Ember;
 
 try {
-  Ember = requireModule('ember').default;
+  Ember = requireModule('ember/barrel').default;
+} catch {
+  // pass through
+}
+
+try {
+  Ember = Ember || requireModule('ember').default;
 } catch {
   Ember = window.Ember;
 }
@@ -52,13 +58,13 @@ if (!Ember) {
   Observable = emberSafeRequire('@ember/object/observable')?.default;
   Evented = emberSafeRequire('@ember/object/evented')?.default;
   PromiseProxyMixin = emberSafeRequire(
-    '@ember/object/promise-proxy-mixin'
+    '@ember/object/promise-proxy-mixin',
   )?.default;
   Service = emberSafeRequire('@ember/service')?.default;
   EmberObject = emberSafeRequire('@ember/object')?.default;
   VERSION = emberSafeRequire('ember/version')?.default;
   ComputedProperty = emberSafeRequire(
-    '@ember/-internals/metal'
+    '@ember/-internals/metal',
   )?.ComputedProperty;
   meta = emberSafeRequire('@ember/-internals/meta')?.meta;
   set = emberSafeRequire('@ember/object')?.set;

package/ember_debug/utils/evented.js

@@ -40,7 +40,7 @@ export default class Evented {
     }
     const listeners = this[ListenersSymbol][name] || [];
     const idx = listeners.findIndex(
-      (l) => l.target === target && l.method === method
+      (l) => l.target === target && l.method === method,
     );
     if (idx >= 0) {
       listeners.splice(idx, 1);

package/ember_debug/utils/get-object-name.js

@@ -30,7 +30,7 @@ export default function getObjectName(object) {
     ) {
       try {
         name = constructor.toString();
-      } catch (e) {
+      } catch {
         name = constructor.name;
       }
     } else {
@@ -43,7 +43,7 @@ export default function getObjectName(object) {
   ) {
     try {
       name = object.toString();
-    } catch (e) {
+    } catch {
       //
     }
   }

package/ember_debug/utils/rsvp.js

@@ -12,6 +12,7 @@ try {
     module = RSVP;
   }
 } catch {
+  // eslint-disable-next-line ember/new-module-imports
   module = RSVP = Ember.RSVP;
 }
 

package/ember_debug/utils/type-check.js

@@ -91,7 +91,7 @@ export function inspect(value) {
     ) {
       try {
         return `<Object:${value.toString()}>`;
-      } catch (e) {
+      } catch {
         //
       }
     }
@@ -119,6 +119,10 @@ export function inspect(value) {
         if (typeOf(v) === 'object') {
           v = '[Object]';
         }
+        // to avoid TypeError: Cannot convert a Symbol value to a string
+        if (typeOf(v) === 'symbol') {
+          v = v.toString();
+        }
         ret.push(`${key}: ${v}`);
       }
     }

package/ember_debug/vendor/startup-wrapper.js

@@ -112,7 +112,10 @@ var EMBER_VERSIONS_SUPPORTED = {{EMBER_VERSIONS_SUPPORTED}};
 
       if (!Ember) {
         try {
-          Ember = requireModule('ember')['default'];
+          Ember = requireModule('ember/barrel')['default'];
+        } catch {}
+        try {
+          Ember = Ember || requireModule('ember')['default'];
         } catch {
           Ember = window.Ember;
         }

package/ember_debug/view-debug.js

@@ -52,6 +52,7 @@ export default class extends DebugPort {
     };
   }
 
+  // eslint-disable-next-line ember/classic-decorator-hooks
   init() {
     super.init();
 
@@ -59,11 +60,11 @@ export default class extends DebugPort {
       owner: this.getOwner(),
       retainObject: bound(
         this.objectInspector,
-        this.objectInspector.retainObject
+        this.objectInspector.retainObject,
       ),
       releaseObject: bound(
         this.objectInspector,
-        this.objectInspector.releaseObject
+        this.objectInspector.releaseObject,
       ),
       inspectNode: bound(this, this.inspectNode),
     }));

package/eslint.config.mjs

@@ -0,0 +1,172 @@
+/**
+ * Debugging:
+ *   https://eslint.org/docs/latest/use/configure/debug
+ *  ----------------------------------------------------
+ *
+ *   Print a file's calculated configuration
+ *
+ *     npx eslint --print-config path/to/file.js
+ *
+ *   Inspecting the config
+ *
+ *     npx eslint --inspect-config
+ *
+ */
+import globals from 'globals';
+import js from '@eslint/js';
+
+import ts from 'typescript-eslint';
+
+import ember from 'eslint-plugin-ember/recommended';
+
+import prettier from 'eslint-plugin-prettier/recommended';
+import qunit from 'eslint-plugin-qunit';
+import n from 'eslint-plugin-n';
+
+import babelParser from '@babel/eslint-parser';
+
+const parserOptions = {
+  esm: {
+    js: {
+      ecmaFeatures: { modules: true },
+      ecmaVersion: 'latest',
+      requireConfigFile: false,
+      babelOptions: {
+        plugins: [
+          [
+            '@babel/plugin-proposal-decorators',
+            { decoratorsBeforeExport: true },
+          ],
+        ],
+      },
+    },
+    ts: {
+      projectService: true,
+      tsconfigRootDir: import.meta.dirname,
+    },
+  },
+};
+
+export default ts.config(
+  js.configs.recommended,
+  ember.configs.base,
+  ember.configs.gjs,
+  ember.configs.gts,
+  prettier,
+  /**
+   * Ignores must be in their own object
+   * https://eslint.org/docs/latest/use/configure/ignore
+   */
+  {
+    ignores: [
+      'dist/',
+      'node_modules/',
+      'coverage/',
+      '!**/.*',
+      'vendor/',
+      'dist_prev/',
+      'skeletons/',
+      'ember_debug/vendor/startup-wrapper.js',
+    ],
+  },
+  /**
+   * https://eslint.org/docs/latest/use/configure/configuration-files#configuring-linter-options
+   */
+  {
+    linterOptions: {
+      reportUnusedDisableDirectives: 'error',
+    },
+  },
+  { rules: { 'no-prototype-builtins': 'off', 'no-useless-escape': 'off' } },
+  {
+    files: ['**/*.js'],
+    languageOptions: {
+      parser: babelParser,
+    },
+  },
+  {
+    files: ['**/*.{js,gjs}'],
+    languageOptions: {
+      parserOptions: parserOptions.esm.js,
+      globals: {
+        ...globals.browser,
+        basicContext: false,
+        requireModule: false,
+      },
+    },
+  },
+  {
+    files: ['**/*.{ts,gts}'],
+    languageOptions: {
+      parser: ember.parser,
+      parserOptions: parserOptions.esm.ts,
+    },
+    extends: [...ts.configs.recommendedTypeChecked, ember.configs.gts],
+    rules: {
+      '@typescript-eslint/no-unused-vars': [
+        'error',
+        {
+          argsIgnorePattern: '^_',
+        },
+      ],
+    },
+  },
+  {
+    files: ['tests/**/*-test.{js,gjs,ts,gts}'],
+    plugins: {
+      qunit,
+    },
+  },
+  /**
+   * CJS node files
+   */
+  {
+    files: [
+      '**/*.cjs',
+      'config/**/*.js',
+      'lib/*/index.js',
+      'scripts/**/*.js',
+      'testem.js',
+      'testem*.js',
+      '.prettierrc.js',
+      '.stylelintrc.js',
+      '.template-lintrc.js',
+      'babel.config.js',
+      'ember-cli-build.js',
+      'gulpfile.js',
+    ],
+    plugins: {
+      n,
+    },
+
+    languageOptions: {
+      sourceType: 'script',
+      ecmaVersion: 'latest',
+      globals: {
+        ...globals.node,
+        basicContext: false,
+        requireModule: false,
+      },
+    },
+  },
+  /**
+   * ESM node files
+   */
+  {
+    files: ['**/*.mjs'],
+    plugins: {
+      n,
+    },
+
+    languageOptions: {
+      sourceType: 'module',
+      ecmaVersion: 'latest',
+      parserOptions: parserOptions.esm.js,
+      globals: {
+        ...globals.node,
+        basicContext: false,
+        requireModule: false,
+      },
+    },
+  },
+);

package/gulpfile.js

@@ -5,7 +5,7 @@ const del = require('del');
 const pkg = require('./package.json');
 let versionedPane = `panes-${pkg.emberVersionsSupported[0].replace(
   /\./g,
-  '-'
+  '-',
 )}`;
 
 function compress(baseSrc, archiveName) {

package/lib/ui/addon/components/drag-handle.hbs

@@ -1,13 +1,13 @@
 {{! template-lint-disable no-pointer-down-event-binding }}
 <div
   class="drag-handle absolute top-0 bottom-0 cursor-col-resize {{
-    if this.isLeft "drag-handle--left"
-  }} {{if this.isRight "drag-handle--right"}} {{
-    if @faded "drag-handle--faded"
+    if this.isLeft "drag-handle-left"
+  }} {{if this.isRight "drag-handle-right"}} {{
+    if @faded "drag-handle-faded"
   }}"
   role="button"
   style={{this.style}}
   {{on "mousedown" this.mouseDownHandler}}
 >
-  <div class="drag-handle__border h-full pointer-events-none"></div>
+  <div class="drag-handle-border h-full pointer-events-none"></div>
 </div>

package/lib/ui/addon/components/drag-handle.js

@@ -1,8 +1,10 @@
 import { equal } from '@ember/object/computed';
+// eslint-disable-next-line ember/no-classic-components
 import Component from '@ember/component';
 import { action, computed } from '@ember/object';
 import { htmlSafe } from '@ember/template';
 
+// eslint-disable-next-line ember/no-classic-classes
 export default Component.extend({
   tagName: '',
   position: 0,
@@ -83,7 +85,7 @@ export default Component.extend({
 
   style: computed('side', 'position', 'left', function () {
     return htmlSafe(
-      this.side ? `${this.side}: ${this.position + this.left}px;` : ''
+      this.side ? `${this.side}: ${this.position + this.left}px;` : '',
     );
   }),
 

package/lib/ui/addon/components/empty-message.hbs

@@ -1,5 +1,5 @@
 <div class="empty-message flex flex-col items-center justify-center h-full text-center text-base11 text-4xl" ...attributes>
   {{svg-jar "ember-icon-empty" width="129px" height="129px"}}
-  <div class="empty-message__content pt-4 px-6">{{yield}}</div>
+  <div class="empty-message-content pt-4 px-6">{{yield}}</div>
 </div>
 

package/lib/ui/addon/components/error-page.hbs

@@ -1,13 +1,13 @@
 <div class="error-page box-border overflow-auto absolute inset-0 flex text-base13 text-md bg-base02">
-  <div class="error-page__content box-border relative m-auto px-6 pb-6 rounded bg-base00">
-    <div class="error-page__header overflow-hidden relative flex items-center font-bold text-4xl">
+  <div class="error-page-content box-border relative m-auto px-6 pb-6 rounded bg-base00">
+    <div class="error-page-header overflow-hidden relative flex items-center font-bold text-4xl">
       <div class="flex-grow pt-6">
         {{@description}}
       </div>
       <img class="tomster" src="assets/images/fishy_tomster.png" alt="Fishy Tomster">
     </div>
 
-    <div class="error-page__body pb-2">
+    <div class="error-page-body pb-2">
       <div class="font-bold">
         Here are some common reasons this happens:
       </div>

package/lib/ui/addon/components/resizable-column.js

@@ -4,7 +4,7 @@ import { htmlSafe } from '@ember/template';
 export default class ResizableColumn extends Component {
   get style() {
     return htmlSafe(
-      `-webkit-flex: none; flex: none; width: ${this.args.width}px;`
+      `-webkit-flex: none; flex: none; width: ${this.args.width}px;`,
     );
   }
 }

package/lib/ui/addon/components/toolbar-clear-button.hbs

@@ -1,6 +1,6 @@
 <button
   title="clear"
-  class="toolbar__icon-button"
+  class="toolbar-icon-button"
   ...attributes
   {{on "click" @action}}
   type="button"