dd-trace 5.54.0 → 5.55.0

package/packages/dd-trace/src/opentracing/propagation/text_map.js

@@ -239,8 +239,8 @@ class TextMapPropagator {
 
       if (typeof origin === 'string') {
         const originValue = origin
-          .replace(tracestateOriginFilter, '_')
-          .replace(/[\x3D]/g, '~')
+          .replaceAll(tracestateOriginFilter, '_')
+          .replaceAll(/[\x3D]/g, '~')
 
         state.set('o', originValue)
       }
@@ -249,12 +249,12 @@ class TextMapPropagator {
         if (!tags[key] || !key.startsWith('_dd.p.')) continue
 
         const tagKey = 't.' + key.slice(6)
-          .replace(tracestateTagKeyFilter, '_')
+          .replaceAll(tracestateTagKeyFilter, '_')
 
         const tagValue = tags[key]
           .toString()
-          .replace(tracestateTagValueFilter, '_')
-          .replace(/[\x3D]/g, '~')
+          .replaceAll(tracestateTagValueFilter, '_')
+          .replaceAll(/[\x3D]/g, '~')
 
         state.set(tagKey, tagValue)
       }
@@ -508,7 +508,7 @@ class TextMapPropagator {
             default: {
               if (!key.startsWith('t.')) continue
               const subKey = key.slice(2) // e.g. t.tid -> tid
-              const transformedValue = value.replace(/[\x7E]/gm, '=')
+              const transformedValue = value.replaceAll(/[\x7E]/gm, '=')
 
               // If subkey is tid  then do nothing because trace header tid should always be preserved
               if (subKey === 'tid') {
@@ -581,22 +581,21 @@ class TextMapPropagator {
       return {
         [b3SampledKey]: parts[0]
       }
-    } else {
-      const b3 = {
-        [b3TraceKey]: parts[0],
-        [b3SpanKey]: parts[1]
-      }
+    }
+    const b3 = {
+      [b3TraceKey]: parts[0],
+      [b3SpanKey]: parts[1]
+    }
 
-      if (parts[2]) {
-        b3[b3SampledKey] = parts[2] === '0' ? '0' : '1'
+    if (parts[2]) {
+      b3[b3SampledKey] = parts[2] === '0' ? '0' : '1'
 
-        if (parts[2] === 'd') {
-          b3[b3FlagsKey] = '1'
-        }
+      if (parts[2] === 'd') {
+        b3[b3FlagsKey] = '1'
       }
-
-      return b3
     }
+
+    return b3
   }
 
   _extractOrigin (carrier, spanContext) {

package/packages/dd-trace/src/opentracing/span.js

@@ -13,18 +13,17 @@ const { storage } = require('../../../datadog-core')
 const telemetryMetrics = require('../telemetry/metrics')
 const { channel } = require('dc-polyfill')
 const util = require('util')
+const { getEnvironmentVariable } = require('../config-helper')
 
 const tracerMetrics = telemetryMetrics.manager.namespace('tracers')
 
-const {
-  DD_TRACE_EXPERIMENTAL_STATE_TRACKING,
-  DD_TRACE_EXPERIMENTAL_SPAN_COUNTS
-} = process.env
+const DD_TRACE_EXPERIMENTAL_STATE_TRACKING = getEnvironmentVariable('DD_TRACE_EXPERIMENTAL_STATE_TRACKING')
+const DD_TRACE_EXPERIMENTAL_SPAN_COUNTS = getEnvironmentVariable('DD_TRACE_EXPERIMENTAL_SPAN_COUNTS')
 
 const unfinishedRegistry = createRegistry('unfinished')
 const finishedRegistry = createRegistry('finished')
 
-const OTEL_ENABLED = !!process.env.DD_TRACE_OTEL_ENABLED
+const OTEL_ENABLED = !!getEnvironmentVariable('DD_TRACE_OTEL_ENABLED')
 const ALLOWED = new Set(['string', 'number', 'boolean'])
 
 const integrationCounters = {
@@ -56,6 +55,8 @@ class DatadogSpan {
   constructor (tracer, processor, prioritySampler, fields, debug) {
     const operationName = fields.operationName
     const parent = fields.parent || null
+    // TODO(BridgeAR): Investigate why this is causing a performance regression
+    // eslint-disable-next-line prefer-object-spread
     const tags = Object.assign({}, fields.tags)
     const hostname = fields.hostname
 
@@ -333,7 +334,7 @@ class DatadogSpan {
         spanId: id(),
         parentId: parent._spanId,
         sampling: parent._sampling,
-        baggageItems: Object.assign({}, parent._baggageItems),
+        baggageItems: { ...parent._baggageItems },
         trace: parent._trace,
         tracestate: parent._tracestate
       })

package/packages/dd-trace/src/payload-tagging/config/index.js

@@ -2,29 +2,25 @@ const aws = require('./aws.json')
 const sdks = { aws }
 
 function getSDKRules (sdk, requestInput, responseInput) {
-  return Object.fromEntries(
-    Object.entries(sdk).map(([service, serviceRules]) => {
-      return [
-        service,
-        {
-          request: serviceRules.request.concat(requestInput || []),
-          response: serviceRules.response.concat(responseInput || []),
-          expand: serviceRules.expand || []
-        }
-      ]
-    })
-  )
+  const sdkServiceRules = {}
+  for (const [service, serviceRules] of Object.entries(sdk)) {
+    sdkServiceRules[service] = {
+      // Make a copy. Otherwise calling the function multiple times would append
+      // the rules to the same object.
+      request: [...serviceRules.request, ...requestInput],
+      response: [...serviceRules.response, ...responseInput],
+      expand: serviceRules.expand
+    }
+  }
+  return sdkServiceRules
 }
 
-function appendRules (requestInput, responseInput) {
-  return Object.fromEntries(
-    Object.entries(sdks).map(([name, sdk]) => {
-      return [
-        name,
-        getSDKRules(sdk, requestInput, responseInput)
-      ]
-    })
-  )
+function appendRules (requestInput = [], responseInput = []) {
+  const sdkRules = {}
+  for (const [name, sdk] of Object.entries(sdks)) {
+    sdkRules[name] = getSDKRules(sdk, requestInput, responseInput)
+  }
+  return sdkRules
 }
 
 module.exports = { appendRules }

package/packages/dd-trace/src/plugin_manager.js

@@ -4,17 +4,18 @@ const { channel } = require('dc-polyfill')
 const { isFalse } = require('./util')
 const plugins = require('./plugins')
 const log = require('./log')
+const { getEnvironmentVariable } = require('../../dd-trace/src/config-helper')
 
 const loadChannel = channel('dd-trace:instrumentation:load')
 
 // instrument everything that needs Plugin System V2 instrumentation
 require('../../datadog-instrumentations')
-if (process.env.AWS_LAMBDA_FUNCTION_NAME !== undefined) {
+if (getEnvironmentVariable('AWS_LAMBDA_FUNCTION_NAME') !== undefined) {
   // instrument lambda environment
   require('./lambda')
 }
 
-const { DD_TRACE_DISABLED_PLUGINS } = process.env
+const DD_TRACE_DISABLED_PLUGINS = getEnvironmentVariable('DD_TRACE_DISABLED_PLUGINS')
 
 const disabledPlugins = new Set(
   DD_TRACE_DISABLED_PLUGINS && DD_TRACE_DISABLED_PLUGINS.split(',').map(plugin => plugin.trim())
@@ -32,7 +33,7 @@ function maybeEnable (Plugin) {
   if (!Plugin || typeof Plugin !== 'function') return
   if (!pluginClasses[Plugin.id]) {
     const envName = `DD_TRACE_${Plugin.id.toUpperCase()}_ENABLED`
-    const enabled = process.env[envName.replace(/[^a-z0-9_]/ig, '_')]
+    const enabled = getEnvironmentVariable(envName.replaceAll(/[^a-z0-9_]/ig, '_'))
 
     // TODO: remove the need to load the plugin class in order to disable the plugin
     if (isFalse(enabled) || disabledPlugins.has(Plugin.id)) {

package/packages/dd-trace/src/plugins/ci_plugin.js

@@ -1,3 +1,4 @@
+const { storage } = require('../../../datadog-core')
 const {
   getTestEnvironmentMetadata,
   getTestSessionName,
@@ -73,7 +74,10 @@ module.exports = class CiPlugin extends Plugin {
     this.fileLineToProbeId = new Map()
     this.rootDir = process.cwd() // fallback in case :session:start events are not emitted
 
-    this.addSub(`ci:${this.constructor.id}:library-configuration`, ({ onDone, isParallel }) => {
+    this.addSub(`ci:${this.constructor.id}:library-configuration`, (ctx) => {
+      const { onDone, isParallel } = ctx
+      ctx.currentStore = storage('legacy').getStore()
+
       if (!this.tracer._exporter || !this.tracer._exporter.getLibraryConfiguration) {
         return onDone({ err: new Error('Test optimization was not initialized correctly') })
       }
@@ -95,6 +99,10 @@ module.exports = class CiPlugin extends Plugin {
       })
     })
 
+    this.addBind(`ci:${this.constructor.id}:test-suite:skippable`, (ctx) => {
+      return ctx.currentStore
+    })
+
     this.addSub(`ci:${this.constructor.id}:test-suite:skippable`, ({ onDone }) => {
       if (!this.tracer._exporter?.getSkippableSuites) {
         return onDone({ err: new Error('Test optimization was not initialized correctly') })
@@ -158,8 +166,12 @@ module.exports = class CiPlugin extends Plugin {
       // only for vitest
       // These are added for the worker threads to use
       if (this.constructor.id === 'vitest') {
+        // TODO: Figure out alternative ways to pass this information to the worker threads
+        // eslint-disable-next-line eslint-rules/eslint-process-env
         process.env.DD_CIVISIBILITY_TEST_SESSION_ID = this.testSessionSpan.context().toTraceId()
+        // eslint-disable-next-line eslint-rules/eslint-process-env
         process.env.DD_CIVISIBILITY_TEST_MODULE_ID = this.testModuleSpan.context().toSpanId()
+        // eslint-disable-next-line eslint-rules/eslint-process-env
         process.env.DD_CIVISIBILITY_TEST_COMMAND = this.command
       }
 
@@ -188,6 +200,10 @@ module.exports = class CiPlugin extends Plugin {
       this.telemetry.count(TELEMETRY_ITR_SKIPPED, { testLevel: 'suite' }, skippedSuites.length)
     })
 
+    this.addBind(`ci:${this.constructor.id}:known-tests`, (ctx) => {
+      return ctx.currentStore
+    })
+
     this.addSub(`ci:${this.constructor.id}:known-tests`, ({ onDone }) => {
       if (!this.tracer._exporter?.getKnownTests) {
         return onDone({ err: new Error('Test optimization was not initialized correctly') })
@@ -202,6 +218,10 @@ module.exports = class CiPlugin extends Plugin {
       })
     })
 
+    this.addBind(`ci:${this.constructor.id}:test-management-tests`, (ctx) => {
+      return ctx.currentStore
+    })
+
     this.addSub(`ci:${this.constructor.id}:test-management-tests`, ({ onDone }) => {
       if (!this.tracer._exporter?.getTestManagementTests) {
         return onDone({ err: new Error('Test optimization was not initialized correctly') })
@@ -215,6 +235,10 @@ module.exports = class CiPlugin extends Plugin {
       })
     })
 
+    this.addBind(`ci:${this.constructor.id}:modified-tests`, (ctx) => {
+      return ctx.currentStore
+    })
+
     this.addSub(`ci:${this.constructor.id}:modified-tests`, ({ onDone }) => {
       const {
         [GIT_PULL_REQUEST_BASE_BRANCH]: pullRequestBaseBranch,

package/packages/dd-trace/src/plugins/plugin.js

@@ -34,7 +34,7 @@ class StoreBinding {
     this._transform = data => {
       const store = storage('legacy').getStore()
 
-      return !store || !store.noop || data?.currentStore
+      return !store || !store.noop || (data && Object.hasOwn(data, 'currentStore'))
         ? transform(data)
         : store
     }

package/packages/dd-trace/src/plugins/util/ci.js

@@ -27,6 +27,7 @@ const {
   CI_NODE_NAME
 } = require('./tags')
 const { filterSensitiveInfoFromRepository } = require('./url')
+const { getEnvironmentVariable } = require('../../config-helper')
 
 // Receives a string with the form 'John Doe <john.doe@gmail.com>'
 // and returns { name: 'John Doe', email: 'john.doe@gmail.com' }
@@ -67,7 +68,7 @@ function normalizeRef (ref) {
   if (!ref) {
     return ref
   }
-  return ref.replace(/origin\/|refs\/heads\/|tags\//gm, '')
+  return ref.replaceAll(/origin\/|refs\/heads\/|tags\//gm, '')
 }
 
 function resolveTilde (filePath) {
@@ -76,16 +77,16 @@ function resolveTilde (filePath) {
   }
   // '~/folder/path' or '~'
   if (filePath[0] === '~' && (filePath[1] === '/' || filePath.length === 1)) {
-    return filePath.replace('~', process.env.HOME)
+    return filePath.replace('~', getEnvironmentVariable('HOME'))
   }
   return filePath
 }
 
 function getGitHubEventPayload () {
-  if (!process.env.GITHUB_EVENT_PATH) {
+  if (!getEnvironmentVariable('GITHUB_EVENT_PATH')) {
     return
   }
-  return JSON.parse(readFileSync(process.env.GITHUB_EVENT_PATH, 'utf8'))
+  return JSON.parse(readFileSync(getEnvironmentVariable('GITHUB_EVENT_PATH'), 'utf8'))
 }
 
 module.exports = {
@@ -139,11 +140,10 @@ module.exports = {
 
       tags[refKey] = ref
 
-      let finalPipelineName = ''
       if (JOB_NAME) {
         // Job names can contain parameters, e.g. jobName/KEY1=VALUE1,KEY2=VALUE2/branchName
         const jobNameAndParams = JOB_NAME.split('/')
-        finalPipelineName = jobNameAndParams.length > 1 && jobNameAndParams[1].includes('=')
+        const finalPipelineName = jobNameAndParams.length > 1 && jobNameAndParams[1].includes('=')
           ? jobNameAndParams[0]
           : JOB_NAME.replace(`/${ref}`, '')
         tags[CI_PIPELINE_NAME] = finalPipelineName
@@ -432,7 +432,7 @@ module.exports = {
         [GIT_TAG]: BITBUCKET_TAG,
         [GIT_REPOSITORY_URL]: BITBUCKET_GIT_SSH_ORIGIN || BITBUCKET_GIT_HTTP_ORIGIN,
         [CI_WORKSPACE_PATH]: BITBUCKET_CLONE_DIR,
-        [CI_PIPELINE_ID]: BITBUCKET_PIPELINE_UUID && BITBUCKET_PIPELINE_UUID.replace(/{|}/gm, ''),
+        [CI_PIPELINE_ID]: BITBUCKET_PIPELINE_UUID && BITBUCKET_PIPELINE_UUID.replaceAll(/{|}/gm, ''),
         [GIT_PULL_REQUEST_BASE_BRANCH]: BITBUCKET_PR_DESTINATION_BRANCH
       }
     }

package/packages/dd-trace/src/plugins/util/git.js

@@ -51,7 +51,7 @@ function sanitizedExec (
   try {
     let result = cp.execFileSync(cmd, flags, { stdio: 'pipe' }).toString()
     if (shouldTrim) {
-      result = result.replace(/(\r\n|\n|\r)/gm, '')
+      result = result.replaceAll(/(\r\n|\n|\r)/gm, '')
     }
     if (durationMetric) {
       distributionMetric(durationMetric.name, durationMetric.tags, Date.now() - startTime)

package/packages/dd-trace/src/plugins/util/llm.js

@@ -11,8 +11,8 @@ function normalize (text, limit = 128) {
   }
 
   text = text
-    .replace(RE_NEWLINE, String.raw`\n`)
-    .replace(RE_TAB, String.raw`\t`)
+    .replaceAll(RE_NEWLINE, String.raw`\n`)
+    .replaceAll(RE_TAB, String.raw`\t`)
 
   // In case the replace above matched, more characters were added that must now be considered.
   if (text.length > limit) {

package/packages/dd-trace/src/plugins/util/stacktrace.js

@@ -34,7 +34,14 @@ function getCallSites (constructorOpt) {
  *
  * @param {Function} constructorOpt - Function to pass along to Error.captureStackTrace
  * @param {number} [limit=Infinity] - The maximum number of frames to return
- * @returns {{ file: string, line: number, method: (string|undefined), type: (string|undefined) }[]} - A
+ * @returns {StackFrame[]} - A list of stack frames from user-land code
+ *
+ * @typedef {Object} StackFrame
+ * @property {string} file - The file path of the frame
+ * @property {number} line - The line number in the file
+ * @property {number} column - The column number in the file
+ * @property {string} [method] - The function name, if available
+ * @property {string} [type] - The type name, if available
  */
 function getUserLandFrames (constructorOpt, limit = Infinity) {
   const callsites = getCallSites(constructorOpt)

package/packages/dd-trace/src/plugins/util/test.js

@@ -2,6 +2,7 @@ const path = require('path')
 const fs = require('fs')
 const { URL } = require('url')
 const log = require('../../log')
+const { getEnvironmentVariable } = require('../../config-helper')
 
 const istanbul = require('istanbul-lib-coverage')
 const ignore = require('ignore')
@@ -284,7 +285,7 @@ module.exports = {
 // Returns pkg manager and its version, separated by '-', e.g. npm-8.15.0 or yarn-1.22.19
 function getPkgManager () {
   try {
-    return process.env.npm_config_user_agent.split(' ')[0].replace('/', '-')
+    return getEnvironmentVariable('npm_config_user_agent').split(' ')[0].replace('/', '-')
   } catch {
     return ''
   }
@@ -789,11 +790,11 @@ function addAttemptToFixStringToTestName (testName, numAttempt) {
 }
 
 function removeEfdStringFromTestName (testName) {
-  return testName.replace(EFD_TEST_NAME_REGEX, '')
+  return testName.replaceAll(EFD_TEST_NAME_REGEX, '')
 }
 
 function removeAttemptToFixStringFromTestName (testName) {
-  return testName.replace(ATTEMPT_TEST_NAME_REGEX, '')
+  return testName.replaceAll(ATTEMPT_TEST_NAME_REGEX, '')
 }
 
 function getIsFaultyEarlyFlakeDetection (projectSuites, testsBySuiteName, faultyThresholdPercentage) {

package/packages/dd-trace/src/plugins/util/user-provided-git.js

@@ -17,6 +17,7 @@ const {
 
 const { normalizeRef } = require('./ci')
 const { filterSensitiveInfoFromRepository } = require('./url')
+const { getEnvironmentVariables } = require('../../config-helper')
 
 function removeEmptyValues (tags) {
   return Object.keys(tags).reduce((filteredTags, tag) => {
@@ -59,7 +60,7 @@ function getUserProviderGitMetadata () {
     DD_GIT_PULL_REQUEST_BASE_BRANCH,
     DD_GIT_PULL_REQUEST_BASE_BRANCH_SHA,
     DD_GIT_COMMIT_HEAD_SHA
-  } = process.env
+  } = getEnvironmentVariables()
 
   const branch = normalizeRef(DD_GIT_BRANCH)
   let tag = normalizeRef(DD_GIT_TAG)

package/packages/dd-trace/src/plugins/util/web.js

@@ -421,7 +421,7 @@ function addAllowHeaders (req, res, headers) {
   ]
 
   for (const header of contextHeaders) {
-    if (~requestHeaders.indexOf(header)) {
+    if (requestHeaders.includes(header)) {
       allowHeaders.push(header)
     }
   }
@@ -530,10 +530,9 @@ function extractURL (req) {
 
   if (req.stream) {
     return `${headers[HTTP2_HEADER_SCHEME]}://${headers[HTTP2_HEADER_AUTHORITY]}${headers[HTTP2_HEADER_PATH]}`
-  } else {
-    const protocol = getProtocol(req)
-    return `${protocol}://${req.headers.host}${req.originalUrl || req.url}`
   }
+  const protocol = getProtocol(req)
+  return `${protocol}://${req.headers.host}${req.originalUrl || req.url}`
 }
 
 function getProtocol (req) {

package/packages/dd-trace/src/priority_sampler.js

@@ -5,7 +5,6 @@ const RateLimiter = require('./rate_limiter')
 const Sampler = require('./sampler')
 const { setSamplingRules } = require('./startup-log')
 const SamplingRule = require('./sampling_rule')
-const { hasOwn } = require('./util')
 
 const {
   SAMPLING_MECHANISM_DEFAULT,
@@ -40,16 +39,28 @@ const DEFAULT_KEY = 'service:,env:'
 const defaultSampler = new Sampler(AUTO_KEEP)
 
 /**
- * from config.js
- * @typedef { sampleRate: number, provenance: string, rateLimit: number, rules: SamplingRule[] } SamplingConfig
+ * PrioritySampler is responsible for determining whether a span should be sampled
+ * based on various rules, rate limits, and priorities. It supports manual and
+ * automatic sampling mechanisms and integrates with Datadog's tracing system.
  *
- * empirically defined
- * @typedef {2|-1|1|0} SamplingPriority
+ * @class PrioritySampler
+ * @typedef {import('./opentracing/span')} DatadogSpan
+ * @typedef {import('./opentracing/span_context')} DatadogSpanContext
+ * @typedef {import('./standalone/product')} PRODUCTS
+ * @typedef {2|-1|1|0} SamplingPriority Empirically defined sampling priorities.
  */
 class PrioritySampler {
   /**
-   * @param env {string}
-   * @param config {SamplingConfig}
+   * Creates an instance of PrioritySampler.
+   *
+   * @typedef {Object} SamplingConfig
+   * @property {number} [sampleRate] - The default sample rate for traces.
+   * @property {string} [provenance] - The provenance of the sampling rule (e.g., "customer", "dynamic").
+   * @property {number} [rateLimit=100] - The maximum number of traces to sample per second.
+   * @property {Array<SamplingRule>} [rules=[]] - An array of sampling rules to apply.
+   *
+   * @param {string} env - The environment name (e.g., "production", "staging").
+   * @param {SamplingConfig} config - The configuration object for sampling.
    */
   constructor (env, config) {
     this.configure(env, config)
@@ -62,9 +73,9 @@ class PrioritySampler {
    * @param opts {SamplingConfig}
    */
   configure (env, opts = {}) {
-    const { sampleRate, provenance, rateLimit = 100, rules = [] } = opts
+    const { sampleRate, provenance, rateLimit = 100, rules } = opts
     this._env = env
-    this._rules = this.#normalizeRules(rules, sampleRate, rateLimit, provenance)
+    this._rules = this.#normalizeRules(rules || [], sampleRate, rateLimit, provenance)
     this._limiter = new RateLimiter(rateLimit)
 
     log.trace(env, opts)
@@ -154,7 +165,7 @@ class PrioritySampler {
    *
    * @param span {DatadogSpan}
    * @param samplingPriority {SamplingPriority}
-   * @param product {import('./standalone/product').PRODUCTS}
+   * @param product {import('./standalone/product')}
    */
   setPriority (span, samplingPriority, product) {
     if (!span || !this.validate(samplingPriority)) return
@@ -208,18 +219,17 @@ class PrioritySampler {
    * @returns {SamplingPriority}
    */
   _getPriorityFromTags (tags, _context) {
-    if (hasOwn(tags, MANUAL_KEEP) && tags[MANUAL_KEEP] !== false) {
+    if (Object.hasOwn(tags, MANUAL_KEEP) && tags[MANUAL_KEEP] !== false) {
       return USER_KEEP
-    } else if (hasOwn(tags, MANUAL_DROP) && tags[MANUAL_DROP] !== false) {
+    } else if (Object.hasOwn(tags, MANUAL_DROP) && tags[MANUAL_DROP] !== false) {
       return USER_REJECT
-    } else {
-      const priority = Number.parseInt(tags[SAMPLING_PRIORITY], 10)
+    }
+    const priority = Number.parseInt(tags[SAMPLING_PRIORITY], 10)
 
-      if (priority === 1 || priority === 2) {
-        return USER_KEEP
-      } else if (priority === 0 || priority === -1) {
-        return USER_REJECT
-      }
+    if (priority === 1 || priority === 2) {
+      return USER_KEEP
+    } else if (priority === 0 || priority === -1) {
+      return USER_REJECT
     }
   }
 
@@ -258,7 +268,6 @@ class PrioritySampler {
    *
    * @param context {DatadogSpanContext}
    * @returns {SamplingPriority}
-   * @private
    */
   #getPriorityByAgent (context) {
     const key = `service:${context._tags[SERVICE_NAME]},env:${this._env}`
@@ -274,7 +283,6 @@ class PrioritySampler {
   /**
    *
    * @param span {DatadogSpan}
-   * @private
    * @returns {void}
    */
   #addDecisionMaker (span) {
@@ -293,30 +301,33 @@ class PrioritySampler {
   }
 
   /**
-   *
-   * @param rules {SamplingRule[]}
-   * @param sampleRate {number}
-   * @param rateLimit {number}
-   * @param provenance {string}
+   * @param {Record<string, unknown>[] | Record<string, unknown>} rules - The sampling rules to normalize.
+   * @param {number} sampleRate
+   * @param {number} rateLimit
+   * @param {string} provenance
    * @returns {SamplingRule[]}
-   * @private
    */
   #normalizeRules (rules, sampleRate, rateLimit, provenance) {
-    rules = [].concat(rules || [])
+    rules = Array.isArray(rules) ? rules.flat() : [rules]
 
     rules.push({ sampleRate, maxPerSecond: rateLimit, provenance })
 
-    return rules
-      .map(rule => ({ ...rule, sampleRate: Number.parseFloat(rule.sampleRate) }))
-      .filter(rule => !Number.isNaN(rule.sampleRate))
-      .map(SamplingRule.from)
+    const result = []
+    for (const rule of rules) {
+      const sampleRate = Number.parseFloat(rule.sampleRate)
+      // TODO(BridgeAR): Debug logging invalid rules fails our tests.
+      // Should we definitely not know about these?
+      if (!Number.isNaN(sampleRate)) {
+        result.push(SamplingRule.from({ ...rule, sampleRate }))
+      }
+    }
+    return result
   }
 
   /**
    *
    * @param span {DatadogSpan}
-   * @returns {SamplingRule}
-   * @private
+   * @returns {SamplingRule|undefined}
    */
   #findRule (span) {
     for (const rule of this._rules) {
@@ -330,7 +341,7 @@ class PrioritySampler {
   /**
    *
    * @param span {DatadogSpan}
-   * @param product {import('./standalone/product').PRODUCTS}
+   * @param product {import('./standalone/product')}
    */
   static keepTrace (span, product) {
     span?._prioritySampler?.setPriority(span, USER_KEEP, product)