cozy-harvest-lib 9.27.0 → 9.27.2

package/CHANGELOG.md

@@ -3,6 +3,28 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [9.27.2](https://github.com/cozy/cozy-libs/compare/cozy-harvest-lib@9.27.1...cozy-harvest-lib@9.27.2) (2022-10-19)
+
+
+### Bug Fixes
+
+* Reapply useVaultClient hook call in LegacyTriggerManager ([bbfb20b](https://github.com/cozy/cozy-libs/commit/bbfb20b559660d04f8a4e1c21ebc3c11cc2cc88b))
+
+
+
+
+
+## [9.27.1](https://github.com/cozy/cozy-libs/compare/cozy-harvest-lib@9.27.0...cozy-harvest-lib@9.27.1) (2022-10-11)
+
+
+### Bug Fixes
+
+* Add explicit blocked popup message ([5e6f93c](https://github.com/cozy/cozy-libs/commit/5e6f93cbe43cecc51089304ad3808fbc07793f8f))
+
+
+
+
+
 # [9.27.0](https://github.com/cozy/cozy-libs/compare/cozy-harvest-lib@9.26.18...cozy-harvest-lib@9.27.0) (2022-10-04)
 
 

package/dist/components/Popup.js

@@ -120,7 +120,12 @@ export var Popup = /*#__PURE__*/function (_PureComponent) {
        */
 
 
-      var popup = window.open(url, title, "scrollbars=yes, width=".concat(w, ", height=").concat(h, ", top=").concat(top, ", left=").concat(left)); // Puts focus on the newWindow
+      var popup = window.open(url, title, "scrollbars=yes, width=".concat(w, ", height=").concat(h, ", top=").concat(top, ", left=").concat(left));
+
+      if (!popup) {
+        throw new Error('Popup was blocked by browser. Be sure to not call showPopup asynchronously');
+      } // Puts focus on the newWindow
+
 
       if (popup.focus) {
         popup.focus();

package/dist/components/TriggerManager.js

@@ -21,6 +21,7 @@ import get from 'lodash/get';
 import compose from 'lodash/flowRight';
 import { withClient } from 'cozy-client';
 import { Account } from 'cozy-doctypes';
+import { useVaultClient } from 'cozy-keys-lib';
 import { translate } from 'cozy-ui/transpiled/react/I18n';
 import Spinner from 'cozy-ui/transpiled/react/Spinner';
 import { ModalBackButton } from 'cozy-ui/transpiled/react/Modal';
@@ -658,8 +659,17 @@ var LegacyTriggerManager = function LegacyTriggerManager(props) {
       onLoginSuccess = props.onLoginSuccess,
       onError = props.onError,
       initialTrigger = props.initialTrigger,
-      otherProps = _objectWithoutProperties(props, _excluded);
+      otherProps = _objectWithoutProperties(props, _excluded); // Since the 4.1.0 of cozy-keys-lib, we
+  // render children even if vaultClient is
+  // not defined yet. In that case we we were
+  // displaying TriggerManager without vaultClient.
+  // It was raising an error.
+  // The current fix, is to not display the
+  // TriggerManager when vaultClient is null.
 
+
+  var vaultClient = useVaultClient();
+  if (!vaultClient) return null;
   return /*#__PURE__*/React.createElement(FlowProvider, {
     onLaunch: onLaunch,
     onSuccess: onSuccess,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "cozy-harvest-lib",
-  "version": "9.27.0",
+  "version": "9.27.2",
   "description": "Provides logic, modules and components for Cozy's harvest applications.",
   "main": "dist/index.js",
   "author": "Cozy",
@@ -90,5 +90,5 @@
     "react-router-dom": "^5.0.1"
   },
   "sideEffects": false,
-  "gitHead": "72899c24a587b57b330c793f48892b2ab276e22b"
+  "gitHead": "4709feb25b56c4af02ab2426bb84fb5a771902f5"
 }

package/src/components/Popup.jsx

@@ -100,6 +100,12 @@ export class Popup extends PureComponent {
       `scrollbars=yes, width=${w}, height=${h}, top=${top}, left=${left}`
     )
 
+    if (!popup) {
+      throw new Error(
+        'Popup was blocked by browser. Be sure to not call showPopup asynchronously'
+      )
+    }
+
     // Puts focus on the newWindow
     if (popup.focus) {
       popup.focus()

package/src/components/TriggerManager.jsx

@@ -5,6 +5,7 @@ import compose from 'lodash/flowRight'
 
 import { withClient } from 'cozy-client'
 import { Account } from 'cozy-doctypes'
+import { useVaultClient } from 'cozy-keys-lib'
 
 import { translate } from 'cozy-ui/transpiled/react/I18n'
 import Spinner from 'cozy-ui/transpiled/react/Spinner'
@@ -482,6 +483,17 @@ const LegacyTriggerManager = props => {
     initialTrigger,
     ...otherProps
   } = props
+
+  // Since the 4.1.0 of cozy-keys-lib, we
+  // render children even if vaultClient is
+  // not defined yet. In that case we we were
+  // displaying TriggerManager without vaultClient.
+  // It was raising an error.
+  // The current fix, is to not display the
+  // TriggerManager when vaultClient is null.
+  const vaultClient = useVaultClient()
+  if (!vaultClient) return null
+
   return (
     <FlowProvider
       onLaunch={onLaunch}