automatasaurus 0.1.12 → 0.1.14
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/package.json +1 -1
- package/template/agents/architect/AGENT.md +0 -16
- package/template/agents/designer/AGENT.md +0 -20
- package/template/agents/developer/AGENT.md +13 -4
- package/template/commands/auto-discovery.md +14 -8
- package/template/skills/code-review/SKILL.md +6 -63
- package/template/skills/github-issues/SKILL.md +14 -0
- package/template/skills/pr-writing/SKILL.md +14 -0
package/package.json
CHANGED
|
@@ -98,22 +98,6 @@ Provide structured feedback:
|
|
|
98
98
|
|
|
99
99
|
Load the `code-review` skill for detailed guidance.
|
|
100
100
|
|
|
101
|
-
### Review Philosophy
|
|
102
|
-
|
|
103
|
-
Have a **slight bias towards moving forward** - avoid nitpicks and style debates that slow down shipping. But still request changes for legitimate problems.
|
|
104
|
-
|
|
105
|
-
**Request changes for:**
|
|
106
|
-
- Security vulnerabilities
|
|
107
|
-
- Bugs that will cause runtime errors
|
|
108
|
-
- Breaking existing functionality
|
|
109
|
-
- Missing critical requirements
|
|
110
|
-
- Significant architectural issues
|
|
111
|
-
|
|
112
|
-
**Don't block for (suggest as non-blocking instead):**
|
|
113
|
-
- Style preferences
|
|
114
|
-
- Minor refactoring opportunities (create follow-up issue)
|
|
115
|
-
- Nitpicks that don't affect functionality
|
|
116
|
-
|
|
117
101
|
### Review Process
|
|
118
102
|
|
|
119
103
|
```bash
|
|
@@ -143,26 +143,6 @@ Or if reviewing a file directly, provide feedback in conversation.
|
|
|
143
143
|
|
|
144
144
|
When reviewing a PR for UI/UX:
|
|
145
145
|
|
|
146
|
-
### Review Philosophy
|
|
147
|
-
|
|
148
|
-
Have a **slight bias towards moving forward** - avoid nitpicks over minor visual details. But still request changes for legitimate UX, design quality, or accessibility problems.
|
|
149
|
-
|
|
150
|
-
**Request changes for:**
|
|
151
|
-
- Accessibility violations (WCAG failures)
|
|
152
|
-
- Broken user flows or interactions
|
|
153
|
-
- Missing critical UI states (error, loading)
|
|
154
|
-
- Significant usability issues
|
|
155
|
-
- Confusing or misleading interfaces (users can't understand what to do)
|
|
156
|
-
- Visual hierarchy failures (nothing draws the eye, or wrong element is prominent)
|
|
157
|
-
- Design token violations (hardcoded values instead of design system tokens)
|
|
158
|
-
- Inconsistent patterns (reinventing UI that exists elsewhere in the app)
|
|
159
|
-
|
|
160
|
-
**Don't block for (suggest as non-blocking instead):**
|
|
161
|
-
- Minor spacing or alignment tweaks
|
|
162
|
-
- Color shade preferences within the design system
|
|
163
|
-
- Subjective opinions about aesthetic choices
|
|
164
|
-
- "Could be more delightful" suggestions (functional but not exceptional)
|
|
165
|
-
|
|
166
146
|
### 1. Determine Relevance
|
|
167
147
|
|
|
168
148
|
UI-relevant changes include:
|
|
@@ -249,10 +249,11 @@ Load the `pr-writing` skill for detailed guidance.
|
|
|
249
249
|
|
|
250
250
|
**Creating the PR:**
|
|
251
251
|
|
|
252
|
+
Use Write tool + `--body-file` (heredocs fail in sandboxed environments):
|
|
253
|
+
|
|
252
254
|
```bash
|
|
253
|
-
|
|
254
|
-
|
|
255
|
-
--body "**[Developer]**
|
|
255
|
+
# Step 1: Use Write tool to create .github-pr-body.md with:
|
|
256
|
+
**[Developer]**
|
|
256
257
|
|
|
257
258
|
## Summary
|
|
258
259
|
{Description}
|
|
@@ -265,7 +266,15 @@ Closes #{issue_number}
|
|
|
265
266
|
- [ ] Tester
|
|
266
267
|
|
|
267
268
|
## Testing
|
|
268
|
-
- [x] Tests passing
|
|
269
|
+
- [x] Tests passing
|
|
270
|
+
|
|
271
|
+
# Step 2: Create the PR
|
|
272
|
+
gh pr create \
|
|
273
|
+
--title "#{issue} feat: {description}" \
|
|
274
|
+
--body-file .github-pr-body.md
|
|
275
|
+
|
|
276
|
+
# Step 3: Clean up
|
|
277
|
+
rm .github-pr-body.md
|
|
269
278
|
```
|
|
270
279
|
|
|
271
280
|
After creating, update issue:
|
|
@@ -282,13 +282,10 @@ Each issue should:
|
|
|
282
282
|
- Be sized for a single PR
|
|
283
283
|
- **No type prefix in title** (e.g., "Feature:", "Bug:") - use labels instead
|
|
284
284
|
|
|
285
|
+
**Important:** Don't use heredocs (`<<EOF`) with `gh` commands - they fail in sandboxed environments. Instead, use the Write tool to create a temp file, then `--body-file`:
|
|
286
|
+
|
|
285
287
|
```bash
|
|
286
|
-
|
|
287
|
-
--title "[Concise description]" \
|
|
288
|
-
--milestone "[Milestone Name]" \
|
|
289
|
-
--label "feature" \
|
|
290
|
-
--label "ready" \
|
|
291
|
-
--body "$(cat <<'EOF'
|
|
288
|
+
# Step 1: Use Write tool to create .github-issue-body.md with:
|
|
292
289
|
## Context
|
|
293
290
|
From discovery: [link to current discovery file, e.g., discovery.md or discovery-2.md]
|
|
294
291
|
|
|
@@ -309,8 +306,17 @@ So that [benefit].
|
|
|
309
306
|
|
|
310
307
|
## Out of Scope
|
|
311
308
|
[What's NOT included]
|
|
312
|
-
|
|
313
|
-
|
|
309
|
+
|
|
310
|
+
# Step 2: Create the issue
|
|
311
|
+
gh issue create \
|
|
312
|
+
--title "[Concise description]" \
|
|
313
|
+
--milestone "[Milestone Name]" \
|
|
314
|
+
--label "feature" \
|
|
315
|
+
--label "ready" \
|
|
316
|
+
--body-file .github-issue-body.md
|
|
317
|
+
|
|
318
|
+
# Step 3: Clean up
|
|
319
|
+
rm .github-issue-body.md
|
|
314
320
|
```
|
|
315
321
|
|
|
316
322
|
---
|
|
@@ -9,43 +9,18 @@ Guidelines for performing effective code reviews that catch issues, improve code
|
|
|
9
9
|
|
|
10
10
|
## Review Mindset
|
|
11
11
|
|
|
12
|
-
|
|
13
|
-
|
|
14
|
-
**The primary goal is to get working code merged, not to achieve perfection.**
|
|
15
|
-
|
|
16
|
-
Before requesting changes, always ask yourself:
|
|
17
|
-
> "Is this feedback worth an additional review cycle?"
|
|
18
|
-
|
|
19
|
-
Most feedback should be:
|
|
20
|
-
- Approved with suggestions for the author to consider
|
|
21
|
-
- Comments for future reference, not blocking
|
|
22
|
-
- Follow-up issues for later improvement
|
|
23
|
-
|
|
24
|
-
**Reserve "Request Changes" for actual problems:**
|
|
25
|
-
- Security vulnerabilities
|
|
26
|
-
- Bugs that will cause runtime errors
|
|
27
|
-
- Breaking changes to existing functionality
|
|
28
|
-
- Missing critical requirements
|
|
29
|
-
|
|
30
|
-
**Do NOT block for:**
|
|
31
|
-
- Style preferences (unless egregiously inconsistent)
|
|
32
|
-
- "I would have done it differently"
|
|
33
|
-
- Minor optimizations that don't matter at current scale
|
|
34
|
-
- Missing tests for edge cases that are unlikely
|
|
35
|
-
- Refactoring opportunities (create a follow-up issue instead)
|
|
12
|
+
Don't hold up PRs over trivial issues — but do request changes for anything substantive.
|
|
36
13
|
|
|
37
14
|
### Goals of Code Review
|
|
38
15
|
1. **Catch real bugs** before they reach production
|
|
39
16
|
2. **Prevent security issues** - the things that actually matter
|
|
40
17
|
3. **Share knowledge** across the team
|
|
41
|
-
4. **Ship working software** - don't let perfect be the enemy of good
|
|
42
18
|
|
|
43
19
|
### The Right Attitude
|
|
44
20
|
- You're reviewing the **code**, not the person
|
|
45
21
|
- Assume good intent - the author tried their best
|
|
46
22
|
- Be a collaborator, not a gatekeeper
|
|
47
23
|
- Your job is to help ship good code, not to find fault
|
|
48
|
-
- **Velocity matters** - every review cycle has a cost
|
|
49
24
|
|
|
50
25
|
## Review Process
|
|
51
26
|
|
|
@@ -246,8 +221,6 @@ Use prefixes to indicate importance:
|
|
|
246
221
|
| **Question:** | Seeking to understand | As needed |
|
|
247
222
|
| **Praise:** | Something done well | Often! |
|
|
248
223
|
|
|
249
|
-
**Important:** Most comments should be Suggestions or Nits, not Blockers. If you find yourself writing many Blockers, reconsider whether they truly block shipping.
|
|
250
|
-
|
|
251
224
|
```markdown
|
|
252
225
|
**Blocker:** This SQL query is vulnerable to injection. (Security - must fix)
|
|
253
226
|
|
|
@@ -270,18 +243,6 @@ Use prefixes to indicate importance:
|
|
|
270
243
|
|
|
271
244
|
## Common Review Scenarios
|
|
272
245
|
|
|
273
|
-
### When You'd Do It Differently
|
|
274
|
-
|
|
275
|
-
Don't block for preference. Ask yourself:
|
|
276
|
-
- Is their way wrong, or just different?
|
|
277
|
-
- Does it work correctly?
|
|
278
|
-
- Is it maintainable?
|
|
279
|
-
|
|
280
|
-
If it's just different:
|
|
281
|
-
```markdown
|
|
282
|
-
**Note:** I might have used X approach here, but this works well too. Not blocking.
|
|
283
|
-
```
|
|
284
|
-
|
|
285
246
|
### When Something Is Missing
|
|
286
247
|
|
|
287
248
|
```markdown
|
|
@@ -305,36 +266,26 @@ Don't just point out problems:
|
|
|
305
266
|
|
|
306
267
|
## Review Response Templates
|
|
307
268
|
|
|
308
|
-
|
|
309
|
-
|
|
310
|
-
### Approve (Most Common)
|
|
269
|
+
### Approve
|
|
311
270
|
```markdown
|
|
312
271
|
**[Architect]** LGTM! Clean implementation, good test coverage.
|
|
313
272
|
|
|
314
|
-
|
|
273
|
+
Suggestions:
|
|
315
274
|
- Line 42: prefer const
|
|
316
275
|
- Consider adding a comment explaining the retry logic
|
|
317
|
-
|
|
318
|
-
Merging as-is is fine. Address these if you agree, or not - your call.
|
|
319
276
|
```
|
|
320
277
|
|
|
321
278
|
### Approve with Suggestions
|
|
322
279
|
```markdown
|
|
323
|
-
**[Architect]** Approving
|
|
280
|
+
**[Architect]** Approving with a few suggestions:
|
|
324
281
|
|
|
325
|
-
A few things to consider (can address now or in follow-up):
|
|
326
282
|
1. The validation could be more specific about what's wrong
|
|
327
283
|
2. Consider adding logging for debugging
|
|
328
|
-
|
|
329
|
-
Not blocking merge. Ship it!
|
|
330
284
|
```
|
|
331
285
|
|
|
332
|
-
### Request Changes
|
|
333
|
-
|
|
334
|
-
**Only use for genuine blockers: security issues, bugs, or missing critical functionality.**
|
|
335
|
-
|
|
286
|
+
### Request Changes
|
|
336
287
|
```markdown
|
|
337
|
-
**[Architect]**
|
|
288
|
+
**[Architect]** Found an issue that needs fixing before merge:
|
|
338
289
|
|
|
339
290
|
**Blocker:**
|
|
340
291
|
1. SQL injection vulnerability in the search query - this is a security risk
|
|
@@ -342,13 +293,6 @@ Not blocking merge. Ship it!
|
|
|
342
293
|
Everything else looks good. Happy to re-review once the security fix is in.
|
|
343
294
|
```
|
|
344
295
|
|
|
345
|
-
**Ask yourself before requesting changes:**
|
|
346
|
-
- Will this cause a production incident if shipped?
|
|
347
|
-
- Is this a security vulnerability?
|
|
348
|
-
- Does it break existing functionality?
|
|
349
|
-
|
|
350
|
-
If the answer to all three is "no", consider approving with suggestions instead.
|
|
351
|
-
|
|
352
296
|
### Decline (N/A)
|
|
353
297
|
```markdown
|
|
354
298
|
**[UI/UX]** N/A - No UI changes in this PR.
|
|
@@ -368,7 +312,6 @@ Reviewed: Backend/infrastructure changes only, no user-facing impact.
|
|
|
368
312
|
### Don't
|
|
369
313
|
- Nitpick excessively
|
|
370
314
|
- Bike-shed on minor style issues
|
|
371
|
-
- Block for preferences
|
|
372
315
|
- Be condescending
|
|
373
316
|
- Leave reviews hanging
|
|
374
317
|
|
|
@@ -87,6 +87,20 @@ gh issue edit {number} --milestone "v1.0 - Basic Cart"
|
|
|
87
87
|
|
|
88
88
|
## Issue Commands
|
|
89
89
|
|
|
90
|
+
### Sandbox Compatibility (Important)
|
|
91
|
+
|
|
92
|
+
**Don't use heredocs (`<<EOF`) with `gh` commands** - they fail in sandboxed environments because the shell can't create temp files for the heredoc content.
|
|
93
|
+
|
|
94
|
+
Instead, use the Write tool + `--body-file` pattern:
|
|
95
|
+
|
|
96
|
+
```bash
|
|
97
|
+
# 1. Use Write tool to create .github-issue-body.md with the issue body
|
|
98
|
+
# 2. Create the issue with --body-file
|
|
99
|
+
gh issue create --title "..." --body-file .github-issue-body.md
|
|
100
|
+
# 3. Clean up
|
|
101
|
+
rm .github-issue-body.md
|
|
102
|
+
```
|
|
103
|
+
|
|
90
104
|
### Before Creating an Issue
|
|
91
105
|
|
|
92
106
|
**Always check for duplicates first:**
|
|
@@ -7,6 +7,20 @@ description: Best practices for writing clear, effective pull request descriptio
|
|
|
7
7
|
|
|
8
8
|
Guidelines for writing pull request descriptions that help reviewers understand and approve changes quickly.
|
|
9
9
|
|
|
10
|
+
## Creating PRs (Sandbox Compatibility)
|
|
11
|
+
|
|
12
|
+
**Don't use heredocs (`<<EOF`) with `gh pr create`** - they fail in sandboxed environments.
|
|
13
|
+
|
|
14
|
+
Use the Write tool + `--body-file` pattern:
|
|
15
|
+
|
|
16
|
+
```bash
|
|
17
|
+
# 1. Use Write tool to create .github-pr-body.md with your PR body
|
|
18
|
+
# 2. Create the PR
|
|
19
|
+
gh pr create --title "#42 feat: Add user auth" --body-file .github-pr-body.md
|
|
20
|
+
# 3. Clean up
|
|
21
|
+
rm .github-pr-body.md
|
|
22
|
+
```
|
|
23
|
+
|
|
10
24
|
## PR Title Format
|
|
11
25
|
|
|
12
26
|
```
|