ai-advisory-board 0.3.0 → 0.4.0

package/CHANGELOG.md

@@ -1,5 +1,17 @@
 # CHANGELOG — AI Advisory Board CLI
 
+## 0.4.0
+
+### Minor Changes
+
+- 81661f9: Action items now capture the discussion context they were born from. When you add an action step to the board (UI, the extract route, or `aab actions add --discussion`), the server snapshots a `sourceContext` onto the item: the original board question, the suggesting member's name + title/expertise, their actual reasoning behind the step, their related key points, and the round number. Previously an action carried only its one-line title plus "Suggested by <member>".
+
+  The Skill Planner now receives this as a dedicated, self-describing `<source_context>` prompt block (authoritative statement of intent — it designs the skill for what the advisor _meant_, not just the literal title), and the skill-creator brief carries it through as `action.sourceContext`. In the web UI, action cards show a "↩ From discussion" link and the edit modal gains a read-only **Source** section (question, member, reasoning, key points) that deep-links back to the originating discussion.
+
+### Patch Changes
+
+- ad82fa0: fix(ui): live discussion view no longer shows false "No response" after a streaming glitch. When a live `member_response` event failed to match its typing bubble, the view left a perpetual-"No response" orphan in place and appended a misplaced duplicate of the real answer further down. `finalizeChat` now rebuilds the chat stream from the authoritative discussion record the server sends with `discussion_completed` / `discussion_gated`, so the live view matches exactly what a page reload renders.
+
 ## 0.3.0
 
 ### Minor Changes

package/dist/bin/aab.js

@@ -857,6 +857,13 @@ ${OUTPUT_CONTRACT}
 
 <input>
 <action>${opts.actionItemJson}</action>
+<source_context>
+The action title above is a one-line distillation. THIS block is the authoritative
+statement of intent: it carries the advisor's actual reasoning and the question the
+board was answering. When the title is terse or ambiguous, resolve it against this
+context \u2014 design the skill for what the advisor MEANT, not just the literal title.
+${opts.sourceContext ?? "(no discussion provenance \u2014 this action was added manually)"}
+</source_context>
 <linked_discussion_summary>${opts.discussionSummary ?? ""}</linked_discussion_summary>
 <recon>
   <pc_scan>${opts.reconResultJson}</pc_scan>
@@ -1155,6 +1162,7 @@ async function runPlanner(opts) {
     null,
     2
   );
+  const sourceContextText = opts.action.sourceContext ? buildSourceContextString(opts.action.sourceContext) : "";
   const discussionSummaryText = opts.discussionSummary ? buildDiscussionSummaryString(opts.discussionSummary) : "";
   const reconResultJson = JSON.stringify(summarizeRecon(opts.recon), null, 2);
   let attempts = 0;
@@ -1165,6 +1173,7 @@ async function runPlanner(opts) {
     attempts++;
     const prompt2 = renderSkillPlannerPrompt({
       actionItemJson,
+      sourceContext: sourceContextText,
       discussionSummary: discussionSummaryText,
       reconResultJson,
       wikiContextJson: JSON.stringify(opts.recon.wiki, null, 2),
@@ -1273,6 +1282,29 @@ function buildDiscussionSummaryString(summary) {
   if (summary.actionableInsights?.length) parts.push(`insights: ${summary.actionableInsights.slice(0, 4).join(" | ")}`);
   return parts.join("\n").slice(0, 4e3);
 }
+function buildSourceContextString(sc) {
+  if (!sc) return "";
+  const lines = [];
+  const who = [sc.memberName, sc.memberTitle].filter(Boolean).join(", ");
+  if (who || typeof sc.roundNumber === "number") {
+    const round = typeof sc.roundNumber === "number" ? ` (advisory round ${sc.roundNumber})` : "";
+    lines.push(`This action was proposed by ${who || "an advisory board member"}${round}.`);
+  }
+  if (sc.discussionQuestion?.trim()) {
+    lines.push(`The board was convened on this question: "${sc.discussionQuestion.trim()}"`);
+  }
+  if (sc.memberReasoning?.trim()) {
+    lines.push(`The advisor's reasoning behind this action:
+${sc.memberReasoning.trim()}`);
+  }
+  if (sc.relatedKeyPoints?.length) {
+    lines.push(
+      `The advisor's related key points:
+${sc.relatedKeyPoints.slice(0, 6).map((p) => `- ${p}`).join("\n")}`
+    );
+  }
+  return lines.join("\n\n").slice(0, 6e3);
+}
 function summarizeRecon(recon) {
   return {
     platform: recon.pc.platform,
@@ -9198,7 +9230,7 @@ function dedupeByTitle(items) {
 }
 function buildAnalysisPrompt(discussion) {
   const PER_RESPONSE_CAP = 4e3;
-  const allResponses = discussion.responses.map((r) => {
+  const allResponses2 = discussion.responses.map((r) => {
     const preview = r.content.length > PER_RESPONSE_CAP ? `${r.content.slice(0, PER_RESPONSE_CAP)}
 
 [\u2026truncated for extraction\u2026]` : r.content;
@@ -9219,7 +9251,7 @@ ${preview}`;
     "",
     summaryContext,
     "FULL CONVERSATION:",
-    allResponses || "(no responses)",
+    allResponses2 || "(no responses)",
     "",
     "INSTRUCTIONS:",
     "1. Extract SPECIFIC, ACTIONABLE items only \u2014 skip vague suggestions.",
@@ -9309,6 +9341,93 @@ function fallbackResult(discussion, processingTimeMs) {
   };
 }
 
+// src/core/actions/source-context.ts
+var MAX_REASONING_CHARS = 1500;
+var MAX_KEY_POINTS = 6;
+function buildSourceContext(discussion, members, opts) {
+  const response = pickResponse(discussion, opts);
+  const member = findMember(members, {
+    memberId: opts.memberId ?? response?.memberId,
+    memberName: opts.memberName ?? response?.memberName
+  });
+  const ctx = {};
+  const question = discussion.question?.trim();
+  if (question) ctx.discussionQuestion = question;
+  const memberId = response?.memberId ?? member?.id ?? opts.memberId;
+  if (memberId) ctx.memberId = memberId;
+  const memberName = response?.memberName ?? member?.name ?? opts.memberName;
+  if (memberName) ctx.memberName = memberName;
+  const memberTitle = buildMemberTitle(member);
+  if (memberTitle) ctx.memberTitle = memberTitle;
+  if (response) {
+    const reasoning = response.content?.trim();
+    if (reasoning) {
+      ctx.memberReasoning = reasoning.length > MAX_REASONING_CHARS ? reasoning.slice(0, MAX_REASONING_CHARS).trimEnd() + "\u2026" : reasoning;
+    }
+    const keyPoints = response.structuredData?.keyPoints?.filter((p) => p && p.trim());
+    if (keyPoints && keyPoints.length) {
+      ctx.relatedKeyPoints = keyPoints.slice(0, MAX_KEY_POINTS);
+    }
+    if (typeof response.roundNumber === "number") ctx.roundNumber = response.roundNumber;
+  }
+  return Object.keys(ctx).length > 0 ? ctx : void 0;
+}
+function allResponses(discussion) {
+  if (discussion.responses && discussion.responses.length > 0) return discussion.responses;
+  return (discussion.rounds ?? []).flatMap((r) => r.responses ?? []);
+}
+function pickResponse(discussion, opts) {
+  const responses = allResponses(discussion);
+  if (responses.length === 0) return void 0;
+  const hasMemberMatcher = Boolean(opts.memberId || opts.memberName);
+  const byMember = responses.filter((r) => {
+    if (opts.memberId && r.memberId === opts.memberId) return true;
+    if (opts.memberName && r.memberName === opts.memberName) return true;
+    return false;
+  });
+  const pool = hasMemberMatcher ? byMember : responses;
+  if (pool.length === 0) return void 0;
+  const wantStep = normalize(opts.stepText);
+  if (wantStep) {
+    const exact = pool.find(
+      (r) => (r.structuredData?.actionSteps ?? []).some((s) => stepsMatch(normalize(s), wantStep))
+    );
+    if (exact) return exact;
+  }
+  return hasMemberMatcher ? [...pool].sort(latestFirst)[0] : void 0;
+}
+function latestFirst(a, b) {
+  if ((b.roundNumber ?? 0) !== (a.roundNumber ?? 0)) return (b.roundNumber ?? 0) - (a.roundNumber ?? 0);
+  if ((b.turnNumber ?? 0) !== (a.turnNumber ?? 0)) return (b.turnNumber ?? 0) - (a.turnNumber ?? 0);
+  return (b.order ?? 0) - (a.order ?? 0);
+}
+function findMember(members, by) {
+  if (by.memberId) {
+    const m = members.find((x) => x.id === by.memberId);
+    if (m) return m;
+  }
+  if (by.memberName) return members.find((x) => x.name === by.memberName);
+  return void 0;
+}
+function buildMemberTitle(member) {
+  if (!member) return void 0;
+  const title = member.title?.trim();
+  const expertise = (member.expertise ?? []).filter((e) => e && e.trim()).slice(0, 3);
+  if (title && expertise.length) return `${title} \xB7 ${expertise.join(", ")}`;
+  if (title) return title;
+  if (expertise.length) return expertise.join(", ");
+  return void 0;
+}
+function normalize(s) {
+  return (s ?? "").toLowerCase().replace(/\s+/g, " ").replace(/[^a-z0-9 ]/g, "").trim();
+}
+function stepsMatch(a, b) {
+  if (!a || !b) return false;
+  if (a === b) return true;
+  const [short, long] = a.length <= b.length ? [a, b] : [b, a];
+  return long.startsWith(short) && short.length >= 12;
+}
+
 // src/core/members/ai-enhancer.ts
 init_claude_code_runner();
 init_safe_json();
@@ -10956,6 +11075,7 @@ function buildSkillCreatorBrief(opts) {
       title: opts.action.title,
       description: opts.action.description,
       priority: opts.action.priority,
+      ...opts.action.sourceContext ? { sourceContext: opts.action.sourceContext } : {},
       ...opts.action.discussionId && opts.discussionSummary ? { linkedDiscussion: { id: opts.action.discussionId, summary: opts.discussionSummary } } : {}
     },
     skillPlannerProposal: cp.proposal,
@@ -12180,6 +12300,24 @@ function coerceActionStatus(value, fallback = "pending") {
   }
   return fallback;
 }
+async function resolveSourceContext(storage, args) {
+  try {
+    const discussion = await storage.loadDiscussionById(args.discussionId);
+    if (!discussion) return void 0;
+    const members = await storage.loadBoardMembers();
+    return buildSourceContext(discussion, members, {
+      memberId: args.memberId,
+      memberName: args.memberName,
+      stepText: args.title
+    });
+  } catch (err) {
+    logger.debug("[actions] sourceContext resolution failed", {
+      discussionId: args.discussionId,
+      error: err instanceof Error ? err.message : String(err)
+    });
+    return void 0;
+  }
+}
 var DEFAULT_PORT = 3737;
 async function startUiServer(opts) {
   const port = opts.port ?? DEFAULT_PORT;
@@ -12308,15 +12446,24 @@ async function startUiServer(opts) {
       const now = nowIso();
       const priority = coerceActionPriority(body.priority);
       const status = coerceActionStatus(body.status);
+      const title = body.title.trim();
+      const discussionId = typeof body.discussionId === "string" ? body.discussionId : void 0;
+      const sourceContext = discussionId ? await resolveSourceContext(opts.storage, {
+        discussionId,
+        title,
+        memberId: body.sourceMemberId,
+        memberName: body.sourceMemberName
+      }) : void 0;
       const item = {
         id: generateUUID(),
-        discussionId: typeof body.discussionId === "string" ? body.discussionId : void 0,
-        title: body.title.trim(),
+        discussionId,
+        title,
         description: typeof body.description === "string" ? body.description : "",
         priority,
         status,
         assignedTo: typeof body.assignedTo === "string" && body.assignedTo.trim() ? body.assignedTo.trim() : void 0,
         dueDate: typeof body.dueDate === "string" && body.dueDate.trim() ? body.dueDate.trim() : void 0,
+        ...sourceContext ? { sourceContext } : {},
         createdAt: now,
         updatedAt: now
       };
@@ -12379,20 +12526,28 @@ async function startUiServer(opts) {
       const body = req.body ?? {};
       if (Array.isArray(body.accept)) {
         const created = [];
+        const members = await opts.storage.loadBoardMembers();
         for (const raw of body.accept) {
           if (!raw || typeof raw !== "object") continue;
           const cand = raw;
           if (!cand.title || typeof cand.title !== "string" || !cand.title.trim()) continue;
           const now = nowIso();
+          const title = cand.title.trim().slice(0, 200);
+          const sourceContext = buildSourceContext(discussion, members, {
+            memberId: cand.sourceMemberId,
+            memberName: cand.sourceMemberName,
+            stepText: title
+          });
           const item = {
             id: generateUUID(),
             discussionId: discussion.id,
-            title: cand.title.trim().slice(0, 200),
+            title,
             description: typeof cand.description === "string" ? cand.description : "",
             priority: coerceActionPriority(cand.priority),
             status: "pending",
             assignedTo: typeof cand.suggestedAssignee === "string" && cand.suggestedAssignee.trim() ? cand.suggestedAssignee.trim() : void 0,
             dueDate: typeof cand.suggestedDueDate === "string" && cand.suggestedDueDate.trim() ? cand.suggestedDueDate.trim() : void 0,
+            ...sourceContext ? { sourceContext } : {},
             createdAt: now,
             updatedAt: now
           };
@@ -16289,9 +16444,12 @@ function registerActionsCommand(program) {
         const dueDate = opts.due ?? "";
         const assignee = opts.assignee ?? "";
         let discussionId;
+        let sourceContext;
         if (opts.discussion) {
           const linked = await resolveDiscussion2(ctx.storage, opts.discussion);
           discussionId = linked.id;
+          const members = await ctx.storage.loadBoardMembers();
+          sourceContext = buildSourceContext(linked, members, { stepText: finalTitle });
         }
         const now = nowIso();
         const item = {
@@ -16303,6 +16461,7 @@ function registerActionsCommand(program) {
           status: "pending",
           assignedTo: assignee || void 0,
           dueDate: dueDate || void 0,
+          ...sourceContext ? { sourceContext } : {},
           createdAt: now,
           updatedAt: now
         };