account-lookup-service 17.4.1-csi-1300.4 → 17.4.1-csi-1300.6

package/CHANGELOG.md

@@ -2,6 +2,13 @@
 
 All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.
 
+### [17.3.2](https://github.com/mojaloop/account-lookup-service/compare/v17.3.1...v17.3.2) (2025-03-13)
+
+
+### Chore
+
+* bump up ([#536](https://github.com/mojaloop/account-lookup-service/issues/536)) ([dc04445](https://github.com/mojaloop/account-lookup-service/commit/dc044459e512906bcc582fbcbe30b592c0de78cb))
+
 ### [17.3.1](https://github.com/mojaloop/account-lookup-service/compare/v17.3.0...v17.3.1) (2025-03-07)
 
 

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "account-lookup-service",
   "description": "Account Lookup Service is used to validate Party and Participant lookups.",
-  "version": "17.4.1-csi-1300.4",
+  "version": "17.4.1-csi-1300.6",
   "license": "Apache-2.0",
   "author": "ModusBox",
   "contributors": [
@@ -95,7 +95,7 @@
     "@mojaloop/central-services-health": "15.0.4",
     "@mojaloop/central-services-logger": "11.6.2",
     "@mojaloop/central-services-metrics": "12.4.5",
-    "@mojaloop/central-services-shared": "18.22.4-snapshot.0",
+    "@mojaloop/central-services-shared": "18.22.4",
     "@mojaloop/central-services-stream": "11.5.1",
     "@mojaloop/database-lib": "11.1.4",
     "@mojaloop/event-sdk": "14.3.2",

package/src/domain/parties/services/GetPartiesService.js

@@ -75,7 +75,7 @@ class GetPartiesService extends BasePartiesService {
 
   async validateRequester ({ source, proxy }) {
     this.deps.stepState.inProgress('validateRequester-0')
-    const log = this.log.child({ source, method: 'validateRequester' })
+    const log = this.log.child({ source, proxy, method: 'validateRequester' })
 
     const sourceParticipant = await this.validateParticipant(source)
     if (sourceParticipant) {
@@ -92,12 +92,17 @@ class GetPartiesService extends BasePartiesService {
     const proxyParticipant = await this.validateParticipant(proxy)
     if (!proxyParticipant) {
       const errMessage = ERROR_MESSAGES.partyProxyNotFound
-      log.warn(errMessage, { proxy })
+      log.warn(errMessage)
       throw ErrorHandler.Factory.createFSPIOPError(ErrorHandler.Enums.FSPIOPErrorCodes.ID_NOT_FOUND, errMessage)
     }
 
     const isCached = await this.deps.proxyCache.addDfspIdToProxyMapping(source, proxy)
-    // think, what if isCached !== true?
+    if (!isCached) {
+      const errMessage = 'failed to addDfspIdToProxyMapping'
+      log.warn(errMessage)
+      throw ErrorHandler.Factory.createFSPIOPError(ErrorHandler.Enums.FSPIOPErrorCodes.ID_NOT_FOUND, errMessage)
+    }
+
     log.info('source is added to proxyMapping cache:', { proxy, isCached })
     return proxy
   }

package/src/domain/parties/services/PutPartiesService.js

@@ -47,8 +47,13 @@ class PutPartiesService extends BasePartiesService {
         throw ErrorHandler.Factory.createFSPIOPError(ErrorHandler.Enums.FSPIOPErrorCodes.ID_NOT_FOUND, errMessage)
       }
       const isCached = await this.deps.proxyCache.addDfspIdToProxyMapping(source, proxy)
-      // todo: think,if we should throw error if isCached === false?
-      this.log.info('addDfspIdToProxyMapping is done', { source, proxy, isCached })
+      if (!isCached) {
+        const errMessage = 'failed to addDfspIdToProxyMapping'
+        this.log.warn(errMessage, { source, proxy })
+        throw ErrorHandler.Factory.createFSPIOPError(ErrorHandler.Enums.FSPIOPErrorCodes.ID_NOT_FOUND, errMessage)
+      }
+
+      this.log.info('addDfspIdToProxyMapping is done', { source, proxy })
     }
   }