@zero-server/webrtc 0.9.8 → 0.9.9

package/lib/webrtc/signaling.js

@@ -83,6 +83,11 @@ function _countCandidatesInSdp(sdp)
  * Validate that an SDP has the required RFC 8829 attributes on every media
  * section and uses DTLS-SRTP transport.  Returns an error code string, or
  * `null` if the SDP is acceptable.
+ *
+ * Accepts both RTP/SAVPF audio/video sections (RFC 8829) and SCTP data-channel
+ * sections (RFC 8841 m=application ... UDP/DTLS/SCTP). When BUNDLE is in use
+ * (every browser since ~2018), only the first m-section is required to carry
+ * iceUfrag/icePwd; other bundled sections inherit them via a=group:BUNDLE.
  */
 function _validateSdpStructure(sdp)
 {
@@ -94,12 +99,36 @@ function _validateSdpStructure(sdp)
         return 'INVALID_SDP';
     }
     if (!desc.media || desc.media.length === 0) return 'INVALID_SDP';
+
+    // BUNDLE: collect bundled mids so per-section ice credentials are optional
+    // on every section except the first (the BUNDLE owner).
+    const bundleMids = new Set();
+    for (const a of desc.attributes || [])
+    {
+        if (a.key !== 'group') continue;
+        const parts = String(a.value || '').split(/\s+/);
+        if (parts[0] !== 'BUNDLE') continue;
+        for (let i = 1; i < parts.length; i++) bundleMids.add(parts[i]);
+    }
+
+    let firstBundleMid = null;
     for (const m of desc.media)
     {
-        if (typeof m.proto !== 'string' || !/^UDP\/TLS\/RTP\/SAVPF?$/i.test(m.proto))
-            return 'INVALID_SDP';
-        if (!m.iceUfrag || !m.icePwd) return 'INVALID_SDP';
+        if (typeof m.proto !== 'string') return 'INVALID_SDP';
+
+        // RTP audio/video (RFC 8829) OR SCTP data channels (RFC 8841).
+        const isRtp  = /^UDP\/TLS\/RTP\/SAVPF?$/i.test(m.proto);
+        const isSctp = /^(UDP|TCP)\/DTLS\/SCTP$/i.test(m.proto);
+        if (!isRtp && !isSctp) return 'INVALID_SDP';
+
         if (!m.fingerprint) return 'INVALID_SDP';
+
+        // ice-ufrag / ice-pwd: required on the BUNDLE owner; optional on
+        // every other bundled section (inherited per RFC 8843 §9.2).
+        const bundled = m.mid && bundleMids.has(m.mid);
+        if (bundled && firstBundleMid === null) firstBundleMid = m.mid;
+        const isBundleOwner = !bundled || m.mid === firstBundleMid;
+        if (isBundleOwner && (!m.iceUfrag || !m.icePwd)) return 'INVALID_SDP';
     }
     return null;
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@zero-server/webrtc",
-  "version": "0.9.8",
+  "version": "0.9.9",
   "description": "WebRTC signaling hub, TURN credentials, STUN client, SFU adapter interface.",
   "keywords": [
     "zero-server",
@@ -45,14 +45,14 @@
   },
   "sideEffects": false,
   "dependencies": {
-    "@zero-server/realtime": "0.9.8",
-    "@zero-server/auth": "0.9.8",
-    "@zero-server/observe": "0.9.8",
-    "@zero-server/errors": "0.9.8",
-    "@zero-server/middleware": "0.9.8"
+    "@zero-server/realtime": "0.9.9",
+    "@zero-server/auth": "0.9.9",
+    "@zero-server/observe": "0.9.9",
+    "@zero-server/errors": "0.9.9",
+    "@zero-server/middleware": "0.9.9"
   },
   "peerDependencies": {
-    "@zero-server/sdk": ">=0.9.8"
+    "@zero-server/sdk": ">=0.9.9"
   },
   "peerDependenciesMeta": {
     "@zero-server/sdk": {