@vanduo-oss/framework 1.3.0 → 1.3.2

package/js/components/code-snippet.js

@@ -282,19 +282,20 @@
       const codeElement = activePane.querySelector('code') || activePane;
       const code = codeElement.textContent;
 
+      let copySuccess;
       try {
         await navigator.clipboard.writeText(code);
-        this.showCopyFeedback(copyBtn, true);
+        copySuccess = true;
       } catch (_err) {
         // Fallback for older browsers
-        const success = this.fallbackCopy(code);
-        this.showCopyFeedback(copyBtn, success);
+        copySuccess = this.fallbackCopy(code);
       }
+      this.showCopyFeedback(copyBtn, copySuccess);
 
       // Dispatch event
       const event = new CustomEvent('codesnippet:copy', {
         bubbles: true,
-        detail: { snippet, code, success: true }
+        detail: { snippet, code, success: copySuccess }
       });
       snippet.dispatchEvent(event);
     },

package/js/components/dropdown.js

@@ -12,9 +12,6 @@
   const Dropdown = {
     // Store initialized dropdowns and their cleanup functions
     instances: new Map(),
-    // Typeahead state
-    _typeaheadBuffer: '',
-    _typeaheadTimer: null,
 
     /**
      * Initialize dropdown components
@@ -95,7 +92,7 @@
         cleanupFunctions.push(() => item.removeEventListener('keydown', itemKeydownHandler));
       });
 
-      this.instances.set(dropdown, { toggle, menu, cleanup: cleanupFunctions });
+      this.instances.set(dropdown, { toggle, menu, cleanup: cleanupFunctions, typeaheadBuffer: '', typeaheadTimer: null });
     },
     
     /**
@@ -249,18 +246,21 @@
         default:
           // Typeahead: jump to matching item when typing printable characters
           if (isOpen && e.key.length === 1 && !e.ctrlKey && !e.metaKey && !e.altKey) {
-            clearTimeout(this._typeaheadTimer);
-            this._typeaheadBuffer += e.key.toLowerCase();
+            // Per-instance typeahead state to avoid cross-instance corruption
+            const instance = this.instances.get(dropdown);
+            if (!instance) break;
+            clearTimeout(instance.typeaheadTimer);
+            instance.typeaheadBuffer += e.key.toLowerCase();
 
             const match = items.find(item =>
-              item.textContent.trim().toLowerCase().startsWith(this._typeaheadBuffer)
+              item.textContent.trim().toLowerCase().startsWith(instance.typeaheadBuffer)
             );
             if (match) {
               match.focus();
             }
 
-            this._typeaheadTimer = setTimeout(() => {
-              this._typeaheadBuffer = '';
+            instance.typeaheadTimer = setTimeout(() => {
+              instance.typeaheadBuffer = '';
             }, 500);
           }
           break;

package/js/components/image-box.js

@@ -274,9 +274,10 @@
       // Handle image load
       if (!this.img.complete) {
         this.img.style.opacity = '0';
-        this.img.onload = () => {
+        this._imgLoadHandler = () => {
           this.img.style.opacity = '';
         };
+        this.img.addEventListener('load', this._imgLoadHandler, { once: true });
       }
     },
 
@@ -305,6 +306,11 @@
       // Clear image after transition
       setTimeout(() => {
         if (!this.isOpen) {
+          // Clean up load handler if still pending
+          if (this._imgLoadHandler) {
+            this.img.removeEventListener('load', this._imgLoadHandler);
+            this._imgLoadHandler = null;
+          }
           this.img.src = '';
           this.img.alt = '';
         }

package/js/components/modals.js

@@ -16,6 +16,8 @@
 
     // Store trigger cleanup functions
     _triggerCleanups: [],
+    // Shared ESC key handler (installed once)
+    _sharedEscHandler: null,
 
     /**
      * Initialize modals
@@ -99,17 +101,18 @@
       backdrop.addEventListener('click', backdropClickHandler);
       cleanupFunctions.push(() => backdrop.removeEventListener('click', backdropClickHandler));
 
-      // ESC key handler
-      const escKeyHandler = (e) => {
-        if (e.key === 'Escape' && this.openModals.length > 0) {
-          const topModal = this.openModals[this.openModals.length - 1];
-          if (topModal === modal && topModal.dataset.keyboard !== 'false') {
-            this.close(topModal);
+      // ESC key handler — use a single shared handler instead of one-per-modal
+      if (!this._sharedEscHandler) {
+        this._sharedEscHandler = (e) => {
+          if (e.key === 'Escape' && this.openModals.length > 0) {
+            const topModal = this.openModals[this.openModals.length - 1];
+            if (topModal.dataset.keyboard !== 'false') {
+              this.close(topModal);
+            }
           }
-        }
-      };
-      document.addEventListener('keydown', escKeyHandler);
-      cleanupFunctions.push(() => document.removeEventListener('keydown', escKeyHandler));
+        };
+        document.addEventListener('keydown', this._sharedEscHandler);
+      }
 
       this.modals.set(modal, { backdrop, dialog, trapHandler: null, cleanup: cleanupFunctions });
     },
@@ -352,6 +355,11 @@
       // Clean up trigger listeners
       this._triggerCleanups.forEach(fn => fn());
       this._triggerCleanups = [];
+      // Remove shared ESC handler
+      if (this._sharedEscHandler) {
+        document.removeEventListener('keydown', this._sharedEscHandler);
+        this._sharedEscHandler = null;
+      }
     }
   };