@unboundcx/video-sdk-client 2.0.5 → 2.0.6

package/managers/LocalMediaManager.js

@@ -367,18 +367,16 @@ export class LocalMediaManager extends EventEmitter {
 			// Note: Audio is only available when sharing a Chrome Tab or Window (not Screen)
 			// Chrome will show an audio checkbox for Tab and Window sharing if audio is requested
 			//
-			// Video constraints: cap at 1920×1080 / 15fps so a huge external
-			// monitor or 4K display doesn't push absurd amounts of bandwidth
-			// or compute. 15fps is plenty for screen content (text + UI
-			// changes infrequently); the encoder profile in MediasoupManager
-			// uses degradationPreference="maintain-resolution" so the
-			// browser keeps the pixels sharp and drops frames if it has to.
+			// Keep video constraints minimal — only the `cursor` hint. Some
+			// Chrome versions reject frameRate / width / height on
+			// getDisplayMedia and abort the capture with an opaque
+			// "Error starting tab capture", so we let the browser pick the
+			// source's native resolution + framerate. Bandwidth is bounded
+			// downstream by the encoder profile in MediasoupManager
+			// (single-layer, max 8 Mbps, maintain-resolution preference).
 			const constraints = {
 				video: {
 					cursor: 'always',
-					width: { max: 1920 },
-					height: { max: 1080 },
-					frameRate: { ideal: 15, max: 30 },
 				},
 				// Request audio with processing disabled for system audio
 				// System audio should not have echo cancellation, noise suppression, or auto gain control

package/managers/MediasoupManager.js

@@ -532,20 +532,35 @@ export class MediasoupManager extends EventEmitter {
           } catch (err) {
             this.logger.warn("Could not set contentHint on screenshare track:", err);
           }
+          // If the captured source is bigger than 1920×1080 (4K monitor,
+          // Retina display, etc.) scale it down before encoding so we
+          // don't waste CPU on pixels nobody will see. Encode at the
+          // larger of the two dimension ratios so neither dimension
+          // exceeds 1920×1080.
+          const maxW = 1920;
+          const maxH = 1080;
+          const scaleDown = Math.max(
+            1.0,
+            baseWidth / maxW,
+            baseHeight / maxH,
+          );
+          const encWidth = Math.round(baseWidth / scaleDown);
+          const encHeight = Math.round(baseHeight / scaleDown);
+
           // Bitrate budget tuned for text crispness: ~5 Mbps at 1080p,
           // ~3 Mbps at 720p, scaled linearly for unusual sizes. Cap
           // upper at 8 Mbps so a huge external monitor doesn't blow
           // through user bandwidth.
-          const pixels = baseWidth * baseHeight;
+          const encPixels = encWidth * encHeight;
           const bitrate = Math.min(
             8_000_000,
-            Math.max(2_000_000, Math.round(pixels * 2.5)),
+            Math.max(2_000_000, Math.round(encPixels * 2.5)),
           );
           produceOptions.encodings = [
             {
               rid: "h",
               maxBitrate: bitrate,
-              scaleResolutionDownBy: 1.0,
+              scaleResolutionDownBy: scaleDown,
             },
           ];
           // degradationPreference="maintain-resolution" tells WebRTC
@@ -553,7 +568,9 @@ export class MediasoupManager extends EventEmitter {
           // — exactly what we want for text.
           produceOptions.degradationPreference = "maintain-resolution";
           this.logger.info("VIDEO_QUALITY :: screen-share encoder profile", {
-            resolution: `${baseWidth}×${baseHeight}`,
+            sourceResolution: `${baseWidth}×${baseHeight}`,
+            encodedResolution: `${encWidth}×${encHeight}`,
+            scaleDown: scaleDown.toFixed(2),
             bitrate: `${(bitrate / 1_000_000).toFixed(1)}Mbps`,
             contentHint: track.contentHint,
             degradationPreference: "maintain-resolution",

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@unboundcx/video-sdk-client",
-	"version": "2.0.5",
+	"version": "2.0.6",
 	"description": "Framework-agnostic WebRTC video meeting SDK powered by mediasoup",
 	"type": "module",
 	"main": "index.js",