@toptal/davinci-ci 3.0.1-alpha-fix-davinci-metric-aa89cb08.10 → 3.0.1-alpha-chore-improve-packages-building-23e03d25.38

package/src/commands/danger.js

@@ -1,67 +0,0 @@
-const {
-  davinciProjectConfig,
-  runSync,
-  print,
-  convertToCLIParameters,
-  files,
-} = require('@toptal/davinci-cli-shared')
-
-const commandOptions = [
-  {
-    label: 'check only, without fixing the code',
-    name: '--check',
-  },
-  {
-    label: 'checks commit message quality locally',
-    name: '--local',
-  },
-  {
-    label: 'specify custom danger file',
-    name: '--dangerfile <dangerfile>',
-  },
-]
-
-const dangerCommand = ({ options }) => {
-  print.green('Running danger check...')
-
-  const { local, dangerfile, ...rest } = options
-
-  const conventionalCommitsDangerfilePath = files.getPackageFilePath(
-    '@toptal/davinci-ci',
-    'src/configs/danger/conventional-commits/dangerfile.js'
-  )
-  const toptalCommitsDangerfilePath = files.getPackageFilePath(
-    '@toptal/davinci-ci',
-    'src/configs/danger/toptal/dangerfile.js'
-  )
-
-  let dangerfilePath = dangerfile
-
-  if (!dangerfilePath) {
-    dangerfilePath = davinciProjectConfig.master.conventionalCommits
-      ? conventionalCommitsDangerfilePath
-      : toptalCommitsDangerfilePath
-  }
-
-  runSync(
-    'yarn',
-    [
-      'danger',
-      local ? 'local' : 'ci',
-      local ? '--failOnErrors' : undefined,
-      '--dangerfile',
-      `${dangerfilePath}`,
-      ...convertToCLIParameters(rest),
-    ].filter(Boolean)
-  )
-}
-
-const dangerCommandCreator = {
-  action: dangerCommand,
-  allowUnknownOptions: true,
-  command: 'danger',
-  description: 'Run danger check',
-  options: commandOptions,
-}
-
-module.exports = dangerCommandCreator

package/src/configs/danger/conventional-commits/dangerfile.js

@@ -1,17 +0,0 @@
-const { schedule } = require('danger')
-const { davinciProjectConfig } = require('@toptal/davinci-cli-shared')
-
-const { conventionalCommits } = require('./plugins/conventional-commits')
-const { conventionalPRTitle } = require('./plugins/conventional-pr-title')
-const { checkAssigneeExist } = require('../plugins/empty-assignee')
-
-schedule(conventionalCommits)
-schedule(conventionalPRTitle)
-
-const {
-  master: { requireAssignee },
-} = davinciProjectConfig
-
-if (requireAssignee) {
-  schedule(checkAssigneeExist)
-}

package/src/configs/danger/conventional-commits/plugins/conventional-commits/index.js

@@ -1,52 +0,0 @@
-/* globals danger, fail */
-/* eslint-disable import/no-extraneous-dependencies */
-const { default: load } = require('@commitlint/load')
-const { default: lint } = require('@commitlint/lint')
-/* eslint-enable */
-const table = require('markdown-table')
-
-const { WHITELISTED_USERS } = require('../../../toptal/config')
-
-const conventionalCommits = async () => {
-  if (
-    danger.github &&
-    WHITELISTED_USERS.includes(danger.github.pr.user.login)
-  ) {
-    return
-  }
-
-  const { commits } = danger.git
-  const { rules, parserPreset } = await load({
-    extends: ['@commitlint/config-conventional'],
-  })
-
-  commits.forEach(async commit => {
-    const result = await lint(
-      commit.message,
-      rules,
-      parserPreset ? { parserOpts: parserPreset.parserOpts } : {}
-    )
-
-    if (!result.valid) {
-      if (result.errors.length > 0) {
-        let message = `The commit - ${commit.sha.trim()} doesn't conform the conventional commit guidelines. \n\n**Errors**:\n\n`
-
-        message += table([
-          ['Message'],
-          ...result.errors.map(error => [error.message]),
-        ])
-
-        message +=
-          '\n\n💡 For a guidance on how to fix this problem please refer to [https://www.conventionalcommits.org](https://www.conventionalcommits.org)'
-        message +=
-          '\n\n💡 Or you can check our [documentation](https://github.com/toptal/picasso/blob/master/docs/contribution/github-workflow.md#general-commit-message-pattern)'
-
-        fail(message)
-      }
-    }
-  })
-}
-
-module.exports = {
-  conventionalCommits,
-}

package/src/configs/danger/conventional-commits/plugins/conventional-pr-title/index.js

@@ -1,53 +0,0 @@
-/// <reference types="danger" />
-/* globals danger, fail */
-/* eslint-disable import/no-extraneous-dependencies */
-const { default: load } = require('@commitlint/load')
-const { default: lint } = require('@commitlint/lint')
-/* eslint-enable */
-const table = require('markdown-table')
-
-const { WHITELISTED_USERS } = require('../../../toptal/config')
-
-const conventionalPRTitle = async () => {
-  if (!danger.github) {
-    return
-  }
-
-  if (WHITELISTED_USERS.includes(danger.github.pr.user.login)) {
-    return
-  }
-
-  const { rules, parserPreset } = await load({
-    extends: ['@commitlint/config-conventional'],
-  })
-  const { title } = danger.github.pr
-
-  const result = await lint(
-    title,
-    rules,
-    parserPreset ? { parserOpts: parserPreset.parserOpts } : {}
-  )
-
-  if (!result.valid) {
-    if (result.errors.length > 0) {
-      let message =
-        "PR title doesn't conform the conventional commit guidelines. \n\n**Errors**:\n\n"
-
-      message += table([
-        ['Message'],
-        ...result.errors.map(error => [error.message]),
-      ])
-
-      message +=
-        '\n\n💡 For a guidance on how to fix this problem please refer to [https://www.conventionalcommits.org](https://www.conventionalcommits.org)'
-      message +=
-        '\n\n💡 Or you can check our [documentation](https://github.com/toptal/picasso/blob/master/docs/contribution/github-workflow.md#general-commit-message-pattern)'
-
-      fail(message)
-    }
-  }
-}
-
-module.exports = {
-  conventionalPRTitle,
-}

package/src/configs/danger/conventional-commits/plugins/index.js

@@ -1,7 +0,0 @@
-const { conventionalCommits } = require('./conventional-commits')
-const { conventionalPRTitle } = require('./conventional-pr-title')
-
-module.exports = {
-  conventionalCommits,
-  conventionalPRTitle,
-}

package/src/configs/danger/plugins/empty-assignee.js

@@ -1,24 +0,0 @@
-/// <reference types="danger" />
-/* globals danger, fail */
-const { davinciProjectConfig } = require('@toptal/davinci-cli-shared')
-
-const {
-  master: { requireAssigneeWhiteList = [] },
-} = davinciProjectConfig
-
-const WHITELISTED_USERS = requireAssigneeWhiteList
-const checkAssigneeExist = () => {
-  const isLocalRun = !danger.github
-
-  if (isLocalRun || WHITELISTED_USERS.includes(danger.github.pr.user.login)) {
-    return
-  }
-
-  if (!danger.github.pr.assignee || danger.github.pr.assignees.length === 0) {
-    fail('Please assign someone to this PR before merging.')
-  }
-}
-
-module.exports = {
-  checkAssigneeExist,
-}

package/src/configs/danger/toptal/config.js

@@ -1,30 +0,0 @@
-const WHITELISTED_USERS = [
-  'dependabot-preview[bot]',
-  'dependabot[bot]',
-  'toptal-devbot',
-]
-const VALID_PR_CODE_REGEX = /\[[A-Z]{1,5}-.*]\s/
-// Valid commit titles:
-// "Regular commit message"
-// "Commit with sentence. But does not end with a full-stop"
-// "[FOO-1234] Commit with prefix"
-// "[FOO] Prefix numbers can be omitted"
-// "[FOO][BAR] Prefixes can couple"
-const VALID_COMMIT_TITLE_REGEX = /^((\[[A-Z]+(-\d+)?])+ )?[A-Z]\w[^\n]*[^.]$/
-const MAX_COMMIT_LINE_LENGTH = 79
-const ENGINEERING_DOCS_LINK =
-  'https://toptal-core.atlassian.net/wiki/spaces/ENG/pages/210665897/Commit+Message+Quality'
-
-const DEFAULT_PR_TITLE_ERROR_MESSAGE = `The pull request title doesn't conform to Toptal's engineering practices. For guidance on how to fix this problem please refer [here](${ENGINEERING_DOCS_LINK})`
-const MISSING_TICKET_CODE_ERROR_MESSAGE =
-  "The pull request title is missing a Jira issue code. Correct format '[ASD-123] Add a cool feature'. If you're working without a Jira issue then add a 'no-jira' label to your pull request."
-
-module.exports = {
-  DEFAULT_PR_TITLE_ERROR_MESSAGE,
-  ENGINEERING_DOCS_LINK,
-  MAX_COMMIT_LINE_LENGTH,
-  MISSING_TICKET_CODE_ERROR_MESSAGE,
-  VALID_COMMIT_TITLE_REGEX,
-  VALID_PR_CODE_REGEX,
-  WHITELISTED_USERS,
-}

package/src/configs/danger/toptal/dangerfile.js

@@ -1,17 +0,0 @@
-const { schedule } = require('danger')
-const { davinciProjectConfig } = require('@toptal/davinci-cli-shared')
-
-const { toptalCommits } = require('./plugins/toptal-commits')
-const { toptalPRTitle } = require('./plugins/toptal-pr-title')
-const { checkAssigneeExist } = require('../plugins/empty-assignee')
-
-schedule(toptalCommits)
-schedule(toptalPRTitle)
-
-const {
-  master: { requireAssignee },
-} = davinciProjectConfig
-
-if (requireAssignee) {
-  schedule(checkAssigneeExist)
-}

package/src/configs/danger/toptal/plugins/index.js

@@ -1,7 +0,0 @@
-const { toptalCommits } = require('./toptal-commits')
-const { toptalPRTitle } = require('./toptal-pr-title')
-
-module.exports = {
-  toptalCommits,
-  toptalPRTitle,
-}

package/src/configs/danger/toptal/plugins/toptal-commits/index.js

@@ -1,73 +0,0 @@
-/* globals danger, fail */
-const {
-  MAX_COMMIT_LINE_LENGTH,
-  VALID_COMMIT_TITLE_REGEX,
-  WHITELISTED_USERS,
-} = require('../../config')
-
-const validateCommitMessage = message => {
-  const errors = []
-  const [title = '', body = ''] = message.split(/\n\n/)
-  const bodyLines = body.split(/\n/)
-  const isTitleFormatValid = VALID_COMMIT_TITLE_REGEX.test(title)
-  const isTitleLengthValid = title.length <= MAX_COMMIT_LINE_LENGTH
-  const isBodyLinesLengthValid = bodyLines.every(
-    line => line.length <= MAX_COMMIT_LINE_LENGTH
-  )
-
-  if (!isTitleFormatValid) {
-    errors.push(`- format of commit title is not correct ([read more](https://toptal-core.atlassian.net/wiki/spaces/ENG/pages/210665897/Commit+Message+Quality)): 
-  - Title should start with capital letter
-  - Title should not end with a full-stop (i.e .)\n
-  Example of a valid commit title:
-    - Regular commit message
-    - [FOO-1234] Commit with prefix
-    - [FOO][BAR] Coupled prefixes`)
-  }
-
-  if (!isTitleLengthValid) {
-    errors.push(
-      `- title is too long (max ${MAX_COMMIT_LINE_LENGTH} characters)`
-    )
-  }
-
-  if (!isBodyLinesLengthValid) {
-    errors.push(
-      `- body lines must not exceed ${MAX_COMMIT_LINE_LENGTH} characters`
-    )
-  }
-
-  return errors
-}
-
-const toptalCommits = () => {
-  if (
-    danger.github &&
-    WHITELISTED_USERS.includes(danger.github.pr.user.login)
-  ) {
-    return
-  }
-
-  const { commits } = danger.git
-
-  commits.forEach(commit => {
-    if (commit.author && WHITELISTED_USERS.includes(commit.author.name)) {
-      return
-    }
-
-    const validationErrors = validateCommitMessage(commit.message)
-
-    if (validationErrors.length) {
-      fail(
-        [
-          `Commit ${commit.sha.trim()} does not meet requirements of [Commit Message Quality](https://toptal-core.atlassian.net/wiki/spaces/ENG/pages/210665897/Commit+Message+Quality):`,
-          ...validationErrors,
-        ].join('\n')
-      )
-    }
-  })
-}
-
-module.exports = {
-  toptalCommits,
-}

package/src/configs/danger/toptal/plugins/toptal-pr-title/index.js

@@ -1,62 +0,0 @@
-/* globals danger, fail */
-const {
-  VALID_COMMIT_TITLE_REGEX,
-  VALID_PR_CODE_REGEX,
-  WHITELISTED_USERS,
-  DEFAULT_PR_TITLE_ERROR_MESSAGE,
-  MISSING_TICKET_CODE_ERROR_MESSAGE,
-} = require('../../config')
-
-const getTicketCode = text => {
-  const ticketCode = text.match(VALID_PR_CODE_REGEX)
-
-  if (!ticketCode) {
-    return
-  }
-
-  return ticketCode[0]
-}
-
-const showError = (error = DEFAULT_PR_TITLE_ERROR_MESSAGE) => {
-  fail(error)
-}
-
-const toptalPRTitle = () => {
-  if (!danger.github) {
-    return
-  }
-
-  if (WHITELISTED_USERS.includes(danger.github.pr.user.login)) {
-    return
-  }
-
-  const { title } = danger.github.pr
-  const labelNames = danger.github.issue.labels.map(({ name }) => name)
-
-  const ticketCode = getTicketCode(title)
-
-  if (!ticketCode && !labelNames.includes('no-jira')) {
-    showError(MISSING_TICKET_CODE_ERROR_MESSAGE)
-
-    return
-  }
-
-  const splitTitle = title.split(ticketCode)
-
-  if (!splitTitle.length) {
-    showError()
-
-    return
-  }
-
-  const titleText = splitTitle[splitTitle.length - 1]
-  const isTitleFormatValid = VALID_COMMIT_TITLE_REGEX.test(titleText)
-
-  if (!isTitleFormatValid) {
-    showError()
-  }
-}
-
-module.exports = {
-  toptalPRTitle,
-}

package/src/configs/docker/Dockerfile

@@ -1,30 +0,0 @@
-FROM node:14
-
-ARG NPM_TOKEN
-ENV NPM_TOKEN ${NPM_TOKEN}
-
-# Change default 'node' user id to match jenkins CI user id
-# so when we will be running container from CI it would have
-# all necessary rights for npm/yarn publish
-RUN groupmod -g 469 node && usermod -u 469 -g 469 node
-
-WORKDIR /app
-RUN chown -R node /app
-
-USER node
-
-# Add github.com to known ssh hosts
-RUN mkdir ~/.ssh
-RUN ssh-keyscan github.com >> ~/.ssh/known_hosts
-
-# Needs to be updated for publishing package to npm
-RUN printf '//registry.npmjs.org/:_authToken=${NPM_TOKEN}\nalways-auth=true\n' > .npmrc
-RUN yarn config set registry https://registry.npmjs.org
-
-# Enables layer caching
-COPY --chown=node:node package.json yarn.lock ./
-RUN yarn install --frozen-lockfile --network-timeout 120000
-
-COPY --chown=node:node . /app
-
-RUN yarn build

package/src/configs/docker/Dockerfile.gha-deploy

@@ -1,33 +0,0 @@
-# Create the image with Nginx environment.
-FROM nginx:alpine
-
-# Copy results from the dist folder to the image.
-ARG DIST_FOLDER
-RUN [ -z "$DIST_FOLDER" ] && echo "DIST_FOLDER is required" && exit 1 || true
-COPY $DIST_FOLDER /usr/share/nginx/html
-
-# Remove source maps from the production build
-RUN find /usr/share/nginx/html -name "*.map" -type f -delete
-
-# Copy the entrypoint.
-ARG ENV_RUNTIME_ENTRYPOINT
-RUN [ -z "$ENV_RUNTIME_ENTRYPOINT" ] && echo "ENV_RUNTIME_ENTRYPOINT is required" && exit 1 || true
-COPY $ENV_RUNTIME_ENTRYPOINT /usr/local/bin/env-runtime.entrypoint.sh
-RUN chmod +x /usr/local/bin/env-runtime.entrypoint.sh
-
-# version is used in build process, so the value won't be available here otherwise
-ARG VERSION
-RUN [ -z "$VERSION" ] && echo "VERSION is required" && exit 1 || true
-ENV DAVINCI_RELEASE_VERSION $VERSION
-
-RUN echo $VERSION > /usr/share/nginx/html/REVISION.txt
-
-# Copy configuration file for Nginx and replace the default one.
-ARG NGINX_CONFIG
-RUN [ -z "$NGINX_CONFIG" ] && echo "NGINX_CONFIG is required" && exit 1 || true
-COPY $NGINX_CONFIG /etc/nginx/conf.d/default.conf
-
-# Entry point to provide Run Time Environment Variables for the App.
-ENTRYPOINT ["/usr/local/bin/env-runtime.entrypoint.sh"]
-
-CMD ["nginx", "-g", "daemon off;"]

package/src/configs/docker/Dockerfile.release

@@ -1,28 +0,0 @@
-ARG VERSION
-ARG REPO_NAME
-
-FROM gcr.io/toptal-hub/${REPO_NAME}:${VERSION} as builder
-
-FROM nginx:alpine
-
-ARG ENV_RUNTIME_ENTRYPOINT
-
-COPY --from=builder /app/dist /usr/share/nginx/html
-COPY --from=builder /app/node_modules/@toptal/davinci-ci/src/configs/docker/nginx-vhost.conf /etc/nginx/conf.d/default.conf
-
-# Remove source maps from the production build
-RUN find /usr/share/nginx/html -name "*.map" -type f -delete
-
-# Copy the entrypoint to prepare env variables
-# example davinci/packages/ci/scr/configs/docker/env-runtime.entrypoint.sh
-COPY ${ENV_RUNTIME_ENTRYPOINT} /usr/local/bin/env-runtime.entrypoint.sh
-
-# version is used in build process, so the value won't be available here otherwise
-ARG VERSION
-ENV DAVINCI_RELEASE_VERSION $VERSION
-
-RUN echo $VERSION > /usr/share/nginx/html/REVISION.txt
-
-ENTRYPOINT ["/usr/local/bin/env-runtime.entrypoint.sh"]
-
-CMD ["nginx", "-g", "daemon off;"]

package/src/configs/docker/Dockerfile.storybook

@@ -1,20 +0,0 @@
-# Create the image with Nginx environment.
-FROM nginx:alpine
-
-# Copy results from the dist folder to the image.
-ARG DIST_FOLDER
-RUN [ -z "$DIST_FOLDER" ] && echo "DIST_FOLDER is required" && exit 1 || true
-COPY $DIST_FOLDER /usr/share/nginx/html/storybook
-
-# version is used in build process, so the value won't be available here otherwise
-ARG VERSION
-RUN [ -z "$VERSION" ] && echo "VERSION is required" && exit 1 || true
-
-RUN echo $VERSION > /usr/share/nginx/html/REVISION.txt
-
-# Copy configuration file for Nginx and replace the default one.
-ARG NGINX_CONFIG
-RUN [ -z "$NGINX_CONFIG" ] && echo "NGINX_CONFIG is required" && exit 1 || true
-COPY $NGINX_CONFIG /etc/nginx/conf.d/default.conf
-
-CMD ["nginx", "-g", "daemon off;"]

package/src/configs/docker/env-runtime.entrypoint.sh

@@ -1,47 +0,0 @@
-#!/bin/sh -e
-
-# This bash script takes required Environment Variables of current process
-# and put them into `index.html` file which is an entry-point of the application.
-# By this way we provide run time variables to a precompiled JS code.
-
-# This is how a place which contains `run time` variables may look in `index.html`
-#
-# window.TP = {
-#   env: '%REACT_APP_ENV_NAME%',
-#   graphql_url: '%REACT_APP_GRAPHQL_URI%'
-# }
-
-# keep in sync with index.html
-VARS_PREFIX="DAVINCI_"
-INDEX_FILE="/usr/share/nginx/html/index.html"
-
-VARS="$(env | grep $VARS_PREFIX | awk -F = '{print $1}')"
-
-# trim whitespaces
-REQUIRED_VARS="$(echo "$VARS" | xargs -n1 | sed 's/^//g')"
-
-# trim whitespaces and prepend $ to every var above
-ENVSUBST_KNOWN_VARS="$(echo "$VARS" | xargs -n1 | sed 's/^/\$/g')"
-
-# replace all the placeholders %VARIABLE_NAME% with the actual value of the variable
-for placeholder in $REQUIRED_VARS
-do
-  value=`printenv "$placeholder"`
-  # any character after 's' in sed is used as a separator
-  # https://stackoverflow.com/a/16790877/1611414
-  sed -i "s|%${placeholder}%|$value|g" $INDEX_FILE
-done
-
-MISSING_VARS="$(cat $INDEX_FILE | grep "%$VARS_PREFIX.*%" | sed 's/.*%\(.*\)%.*/\1/g')"
-
-if [ -n "$MISSING_VARS" ]; then
-  for placeholder in $MISSING_VARS
-  do
-    if ! printenv "$placeholder" > /dev/null; then
-      echo "Variable '$placeholder' is not set. Exiting..."
-      exit 1
-    fi
-  done
-fi
-
-exec "$@"

package/src/configs/docker/nginx-vhost-storybook.conf

@@ -1,20 +0,0 @@
-server {
-  listen       80;
-  server_name  localhost;
-  root   /usr/share/nginx/html/storybook;
-
-  location / {
-    try_files $uri $uri/ index.html;
-    index index.html;
-  }
-
-  location ~ \.(js|png|svg|jpg|gif)$ {
-		try_files $uri $uri/ =404;
-	}
-
-  # redirect server error pages to the static page /50x.html
-  error_page   500 502 503 504  /50x.html;
-  location = /50x.html {
-    root   /usr/share/nginx/html;
-  }
-}

package/src/configs/docker/nginx-vhost.conf

@@ -1,18 +0,0 @@
-# When you are redirecting to any url, which is handled by react-router
-# on nginx we need special configuration to handle those
-# and don't just return 404
-server {
-  listen       80;
-  server_name  localhost;
-  
-  index index.html;
-  root   /usr/share/nginx/html;
-
-  location ~ \.(js|css)$ {
-    # allow returning 404s for assets
-  }
-
-  location / {
-    try_files $uri /index.html;
-  }
-}