@toptal/davinci-ci 3.0.1-alpha-chore-improve-packages-building-14e3a950.51 → 3.0.2-alpha-chore-improve-packages-building-4fb91e1f.10

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@toptal/davinci-ci",
-  "version": "3.0.1-alpha-chore-improve-packages-building-14e3a950.51+14e3a950",
+  "version": "3.0.2-alpha-chore-improve-packages-building-4fb91e1f.10+4fb91e1f",
   "description": "Continuos integrations tools for frontend projects",
   "publishConfig": {
     "access": "public"
@@ -16,9 +16,10 @@
   "bin": {
     "davinci-ci": "./bin/davinci-ci.js"
   },
-  "main": "./dist/index.js",
+  "main": "src/index.js",
   "files": [
-    "dist"
+    "dist",
+    "src"
   ],
   "repository": {
     "type": "git",
@@ -35,9 +36,9 @@
   "dependencies": {
     "@commitlint/cli": "^17.0.2",
     "@commitlint/config-conventional": "^17.1.0",
-    "@toptal/davinci-cli-shared": "1.10.1-alpha-chore-improve-packages-building-14e3a950.65+14e3a950",
+    "@toptal/davinci-cli-shared": "1.10.2-alpha-chore-improve-packages-building-4fb91e1f.10+4fb91e1f",
     "danger": "^11.0.7",
     "markdown-table": "^2.0.0"
   },
-  "gitHead": "14e3a950bb266b648fbb1a786694ebb0a5b79004"
+  "gitHead": "4fb91e1f662d67db54bd398517433d8c4b994732"
 }

package/src/commands/danger.js

@@ -0,0 +1,67 @@
+const {
+  davinciProjectConfig,
+  runSync,
+  print,
+  convertToCLIParameters,
+  files,
+} = require('@toptal/davinci-cli-shared')
+
+const commandOptions = [
+  {
+    label: 'check only, without fixing the code',
+    name: '--check',
+  },
+  {
+    label: 'checks commit message quality locally',
+    name: '--local',
+  },
+  {
+    label: 'specify custom danger file',
+    name: '--dangerfile <dangerfile>',
+  },
+]
+
+const dangerCommand = ({ options }) => {
+  print.green('Running danger check...')
+
+  const { local, dangerfile, ...rest } = options
+
+  const conventionalCommitsDangerfilePath = files.getPackageFilePath(
+    '@toptal/davinci-ci',
+    'src/configs/danger/conventional-commits/dangerfile.js'
+  )
+  const toptalCommitsDangerfilePath = files.getPackageFilePath(
+    '@toptal/davinci-ci',
+    'src/configs/danger/toptal/dangerfile.js'
+  )
+
+  let dangerfilePath = dangerfile
+
+  if (!dangerfilePath) {
+    dangerfilePath = davinciProjectConfig.master.conventionalCommits
+      ? conventionalCommitsDangerfilePath
+      : toptalCommitsDangerfilePath
+  }
+
+  runSync(
+    'yarn',
+    [
+      'danger',
+      local ? 'local' : 'ci',
+      local ? '--failOnErrors' : undefined,
+      '--dangerfile',
+      `${dangerfilePath}`,
+      ...convertToCLIParameters(rest),
+    ].filter(Boolean)
+  )
+}
+
+const dangerCommandCreator = {
+  action: dangerCommand,
+  allowUnknownOptions: true,
+  command: 'danger',
+  description: 'Run danger check',
+  options: commandOptions,
+}
+
+module.exports = dangerCommandCreator

package/src/configs/danger/conventional-commits/dangerfile.js

@@ -0,0 +1,17 @@
+const { schedule } = require('danger')
+const { davinciProjectConfig } = require('@toptal/davinci-cli-shared')
+
+const { conventionalCommits } = require('./plugins/conventional-commits')
+const { conventionalPRTitle } = require('./plugins/conventional-pr-title')
+const { checkAssigneeExist } = require('../plugins/empty-assignee')
+
+schedule(conventionalCommits)
+schedule(conventionalPRTitle)
+
+const {
+  master: { requireAssignee },
+} = davinciProjectConfig
+
+if (requireAssignee) {
+  schedule(checkAssigneeExist)
+}

package/src/configs/danger/conventional-commits/plugins/conventional-commits/index.js

@@ -0,0 +1,52 @@
+/* globals danger, fail */
+/* eslint-disable import/no-extraneous-dependencies */
+const { default: load } = require('@commitlint/load')
+const { default: lint } = require('@commitlint/lint')
+/* eslint-enable */
+const table = require('markdown-table')
+
+const { WHITELISTED_USERS } = require('../../../toptal/config')
+
+const conventionalCommits = async () => {
+  if (
+    danger.github &&
+    WHITELISTED_USERS.includes(danger.github.pr.user.login)
+  ) {
+    return
+  }
+
+  const { commits } = danger.git
+  const { rules, parserPreset } = await load({
+    extends: ['@commitlint/config-conventional'],
+  })
+
+  commits.forEach(async commit => {
+    const result = await lint(
+      commit.message,
+      rules,
+      parserPreset ? { parserOpts: parserPreset.parserOpts } : {}
+    )
+
+    if (!result.valid) {
+      if (result.errors.length > 0) {
+        let message = `The commit - ${commit.sha.trim()} doesn't conform the conventional commit guidelines. \n\n**Errors**:\n\n`
+
+        message += table([
+          ['Message'],
+          ...result.errors.map(error => [error.message]),
+        ])
+
+        message +=
+          '\n\n💡 For a guidance on how to fix this problem please refer to [https://www.conventionalcommits.org](https://www.conventionalcommits.org)'
+        message +=
+          '\n\n💡 Or you can check our [documentation](https://github.com/toptal/picasso/blob/master/docs/contribution/github-workflow.md#general-commit-message-pattern)'
+
+        fail(message)
+      }
+    }
+  })
+}
+
+module.exports = {
+  conventionalCommits,
+}

package/src/configs/danger/conventional-commits/plugins/conventional-pr-title/index.js

@@ -0,0 +1,53 @@
+/// <reference types="danger" />
+/* globals danger, fail */
+/* eslint-disable import/no-extraneous-dependencies */
+const { default: load } = require('@commitlint/load')
+const { default: lint } = require('@commitlint/lint')
+/* eslint-enable */
+const table = require('markdown-table')
+
+const { WHITELISTED_USERS } = require('../../../toptal/config')
+
+const conventionalPRTitle = async () => {
+  if (!danger.github) {
+    return
+  }
+
+  if (WHITELISTED_USERS.includes(danger.github.pr.user.login)) {
+    return
+  }
+
+  const { rules, parserPreset } = await load({
+    extends: ['@commitlint/config-conventional'],
+  })
+  const { title } = danger.github.pr
+
+  const result = await lint(
+    title,
+    rules,
+    parserPreset ? { parserOpts: parserPreset.parserOpts } : {}
+  )
+
+  if (!result.valid) {
+    if (result.errors.length > 0) {
+      let message =
+        "PR title doesn't conform the conventional commit guidelines. \n\n**Errors**:\n\n"
+
+      message += table([
+        ['Message'],
+        ...result.errors.map(error => [error.message]),
+      ])
+
+      message +=
+        '\n\n💡 For a guidance on how to fix this problem please refer to [https://www.conventionalcommits.org](https://www.conventionalcommits.org)'
+      message +=
+        '\n\n💡 Or you can check our [documentation](https://github.com/toptal/picasso/blob/master/docs/contribution/github-workflow.md#general-commit-message-pattern)'
+
+      fail(message)
+    }
+  }
+}
+
+module.exports = {
+  conventionalPRTitle,
+}

package/src/configs/danger/conventional-commits/plugins/index.js

@@ -0,0 +1,7 @@
+const { conventionalCommits } = require('./conventional-commits')
+const { conventionalPRTitle } = require('./conventional-pr-title')
+
+module.exports = {
+  conventionalCommits,
+  conventionalPRTitle,
+}

package/src/configs/danger/plugins/empty-assignee.js

@@ -0,0 +1,24 @@
+/// <reference types="danger" />
+/* globals danger, fail */
+const { davinciProjectConfig } = require('@toptal/davinci-cli-shared')
+
+const {
+  master: { requireAssigneeWhiteList = [] },
+} = davinciProjectConfig
+
+const WHITELISTED_USERS = requireAssigneeWhiteList
+const checkAssigneeExist = () => {
+  const isLocalRun = !danger.github
+
+  if (isLocalRun || WHITELISTED_USERS.includes(danger.github.pr.user.login)) {
+    return
+  }
+
+  if (!danger.github.pr.assignee || danger.github.pr.assignees.length === 0) {
+    fail('Please assign someone to this PR before merging.')
+  }
+}
+
+module.exports = {
+  checkAssigneeExist,
+}

package/src/configs/danger/toptal/config.js

@@ -0,0 +1,30 @@
+const WHITELISTED_USERS = [
+  'dependabot-preview[bot]',
+  'dependabot[bot]',
+  'toptal-devbot',
+]
+const VALID_PR_CODE_REGEX = /\[[A-Z]{1,5}-.*]\s/
+// Valid commit titles:
+// "Regular commit message"
+// "Commit with sentence. But does not end with a full-stop"
+// "[FOO-1234] Commit with prefix"
+// "[FOO] Prefix numbers can be omitted"
+// "[FOO][BAR] Prefixes can couple"
+const VALID_COMMIT_TITLE_REGEX = /^((\[[A-Z]+(-\d+)?])+ )?[A-Z]\w[^\n]*[^.]$/
+const MAX_COMMIT_LINE_LENGTH = 79
+const ENGINEERING_DOCS_LINK =
+  'https://toptal-core.atlassian.net/wiki/spaces/ENG/pages/210665897/Commit+Message+Quality'
+
+const DEFAULT_PR_TITLE_ERROR_MESSAGE = `The pull request title doesn't conform to Toptal's engineering practices. For guidance on how to fix this problem please refer [here](${ENGINEERING_DOCS_LINK})`
+const MISSING_TICKET_CODE_ERROR_MESSAGE =
+  "The pull request title is missing a Jira issue code. Correct format '[ASD-123] Add a cool feature'. If you're working without a Jira issue then add a 'no-jira' label to your pull request."
+
+module.exports = {
+  DEFAULT_PR_TITLE_ERROR_MESSAGE,
+  ENGINEERING_DOCS_LINK,
+  MAX_COMMIT_LINE_LENGTH,
+  MISSING_TICKET_CODE_ERROR_MESSAGE,
+  VALID_COMMIT_TITLE_REGEX,
+  VALID_PR_CODE_REGEX,
+  WHITELISTED_USERS,
+}

package/src/configs/danger/toptal/dangerfile.js

@@ -0,0 +1,17 @@
+const { schedule } = require('danger')
+const { davinciProjectConfig } = require('@toptal/davinci-cli-shared')
+
+const { toptalCommits } = require('./plugins/toptal-commits')
+const { toptalPRTitle } = require('./plugins/toptal-pr-title')
+const { checkAssigneeExist } = require('../plugins/empty-assignee')
+
+schedule(toptalCommits)
+schedule(toptalPRTitle)
+
+const {
+  master: { requireAssignee },
+} = davinciProjectConfig
+
+if (requireAssignee) {
+  schedule(checkAssigneeExist)
+}

package/src/configs/danger/toptal/plugins/index.js

@@ -0,0 +1,7 @@
+const { toptalCommits } = require('./toptal-commits')
+const { toptalPRTitle } = require('./toptal-pr-title')
+
+module.exports = {
+  toptalCommits,
+  toptalPRTitle,
+}

package/src/configs/danger/toptal/plugins/toptal-commits/index.js

@@ -0,0 +1,73 @@
+/* globals danger, fail */
+const {
+  MAX_COMMIT_LINE_LENGTH,
+  VALID_COMMIT_TITLE_REGEX,
+  WHITELISTED_USERS,
+} = require('../../config')
+
+const validateCommitMessage = message => {
+  const errors = []
+  const [title = '', body = ''] = message.split(/\n\n/)
+  const bodyLines = body.split(/\n/)
+  const isTitleFormatValid = VALID_COMMIT_TITLE_REGEX.test(title)
+  const isTitleLengthValid = title.length <= MAX_COMMIT_LINE_LENGTH
+  const isBodyLinesLengthValid = bodyLines.every(
+    line => line.length <= MAX_COMMIT_LINE_LENGTH
+  )
+
+  if (!isTitleFormatValid) {
+    errors.push(`- format of commit title is not correct ([read more](https://toptal-core.atlassian.net/wiki/spaces/ENG/pages/210665897/Commit+Message+Quality)): 
+  - Title should start with capital letter
+  - Title should not end with a full-stop (i.e .)\n
+  Example of a valid commit title:
+    - Regular commit message
+    - [FOO-1234] Commit with prefix
+    - [FOO][BAR] Coupled prefixes`)
+  }
+
+  if (!isTitleLengthValid) {
+    errors.push(
+      `- title is too long (max ${MAX_COMMIT_LINE_LENGTH} characters)`
+    )
+  }
+
+  if (!isBodyLinesLengthValid) {
+    errors.push(
+      `- body lines must not exceed ${MAX_COMMIT_LINE_LENGTH} characters`
+    )
+  }
+
+  return errors
+}
+
+const toptalCommits = () => {
+  if (
+    danger.github &&
+    WHITELISTED_USERS.includes(danger.github.pr.user.login)
+  ) {
+    return
+  }
+
+  const { commits } = danger.git
+
+  commits.forEach(commit => {
+    if (commit.author && WHITELISTED_USERS.includes(commit.author.name)) {
+      return
+    }
+
+    const validationErrors = validateCommitMessage(commit.message)
+
+    if (validationErrors.length) {
+      fail(
+        [
+          `Commit ${commit.sha.trim()} does not meet requirements of [Commit Message Quality](https://toptal-core.atlassian.net/wiki/spaces/ENG/pages/210665897/Commit+Message+Quality):`,
+          ...validationErrors,
+        ].join('\n')
+      )
+    }
+  })
+}
+
+module.exports = {
+  toptalCommits,
+}

package/src/configs/danger/toptal/plugins/toptal-commits/toptal-commits.test.js

@@ -0,0 +1,128 @@
+const { toptalCommits } = require('.')
+
+const prepareCommitsWithMessages = (messages = []) => ({
+  commits: messages.map(message => ({
+    message,
+    sha: '123',
+  })),
+})
+
+describe('commit danger plugin', () => {
+  beforeEach(() => {
+    global.fail = jest.fn()
+    global.danger = {
+      github: {
+        pr: {
+          user: {
+            login: 'user',
+          },
+        },
+      },
+    }
+  })
+
+  afterEach(() => {
+    global.fail = undefined
+    global.danger = undefined
+  })
+
+  it('commit with title only', () => {
+    global.danger.git = prepareCommitsWithMessages(['Hello world'])
+    toptalCommits()
+
+    expect(global.fail).toHaveBeenCalledTimes(0)
+  })
+
+  it('commit with title and body', () => {
+    global.danger.git = prepareCommitsWithMessages([
+      'Hello world\n\nSome commit body here.',
+    ])
+    toptalCommits()
+
+    expect(global.fail).toHaveBeenCalledTimes(0)
+  })
+
+  it('commit with multi-line body', () => {
+    global.danger.git = prepareCommitsWithMessages([
+      'Hello world\n\nFirst line of commit body\nSecond line of commit body',
+    ])
+    toptalCommits()
+
+    expect(global.fail).toHaveBeenCalledTimes(0)
+  })
+
+  it('commit with title longer than allowed', () => {
+    global.danger.git = prepareCommitsWithMessages([
+      'This commit message is a teeny tiny bit longer than allowed length of 79 characters',
+    ])
+    toptalCommits()
+
+    expect(global.fail).toHaveBeenCalledTimes(1)
+  })
+
+  it('commit with body lines longer than allowed', () => {
+    global.danger.git = prepareCommitsWithMessages([
+      'Short commit title\n\nBut this body line commit message is a bit longer than allowed length of 79 characters\nAnd this one is fine again.',
+    ])
+    toptalCommits()
+
+    expect(global.fail).toHaveBeenCalledTimes(1)
+  })
+
+  it('commit message not starting with an uppercase letter', () => {
+    global.danger.git = prepareCommitsWithMessages([
+      '23432 starts with a number',
+      'starts with a lowercase letter',
+      '* starts with a symbol',
+      ' starts with a space',
+    ])
+    toptalCommits()
+
+    expect(global.fail).toHaveBeenCalledTimes(4)
+  })
+
+  it('commit message ending with a period in title', () => {
+    global.danger.git = prepareCommitsWithMessages([
+      'Commit title ending with period.',
+    ])
+    toptalCommits()
+
+    expect(global.fail).toHaveBeenCalledTimes(1)
+  })
+
+  it('commit without a blank line between title and body', () => {
+    global.danger.git = prepareCommitsWithMessages([
+      'Commit title\nBody without a blank line after title',
+    ])
+    toptalCommits()
+
+    expect(global.fail).toHaveBeenCalledTimes(1)
+  })
+
+  it('valid commit titles', () => {
+    global.danger.git = prepareCommitsWithMessages([
+      'Regular commit title',
+      'Commit with sentence. But does not end with a full-stop',
+      '[FOO-1234] Commit with prefix',
+      '[FOO] Prefix numbers can be omitted',
+      '[FOO][BAR] Prefixes can couple',
+      '[FOO-1234][BAR] Mixed prefixes',
+      '[FOO-1234][BAR-123][BAZ] Everything. Together',
+    ])
+    toptalCommits()
+
+    expect(global.fail).toHaveBeenCalledTimes(0)
+  })
+
+  it('invalid commit title prefixes', () => {
+    global.danger.git = prepareCommitsWithMessages([
+      '[FOO-1234] commit with lowercase',
+      '[FOO-BAR] Prefix with letter after dash',
+      '[FOO] [BAR] Prefixes with space between',
+      '[FOO]Prefix without space',
+    ])
+    toptalCommits()
+
+    expect(global.fail).toHaveBeenCalledTimes(4)
+  })
+})

package/src/configs/danger/toptal/plugins/toptal-pr-title/index.js

@@ -0,0 +1,62 @@
+/* globals danger, fail */
+const {
+  VALID_COMMIT_TITLE_REGEX,
+  VALID_PR_CODE_REGEX,
+  WHITELISTED_USERS,
+  DEFAULT_PR_TITLE_ERROR_MESSAGE,
+  MISSING_TICKET_CODE_ERROR_MESSAGE,
+} = require('../../config')
+
+const getTicketCode = text => {
+  const ticketCode = text.match(VALID_PR_CODE_REGEX)
+
+  if (!ticketCode) {
+    return
+  }
+
+  return ticketCode[0]
+}
+
+const showError = (error = DEFAULT_PR_TITLE_ERROR_MESSAGE) => {
+  fail(error)
+}
+
+const toptalPRTitle = () => {
+  if (!danger.github) {
+    return
+  }
+
+  if (WHITELISTED_USERS.includes(danger.github.pr.user.login)) {
+    return
+  }
+
+  const { title } = danger.github.pr
+  const labelNames = danger.github.issue.labels.map(({ name }) => name)
+
+  const ticketCode = getTicketCode(title)
+
+  if (!ticketCode && !labelNames.includes('no-jira')) {
+    showError(MISSING_TICKET_CODE_ERROR_MESSAGE)
+
+    return
+  }
+
+  const splitTitle = title.split(ticketCode)
+
+  if (!splitTitle.length) {
+    showError()
+
+    return
+  }
+
+  const titleText = splitTitle[splitTitle.length - 1]
+  const isTitleFormatValid = VALID_COMMIT_TITLE_REGEX.test(titleText)
+
+  if (!isTitleFormatValid) {
+    showError()
+  }
+}
+
+module.exports = {
+  toptalPRTitle,
+}

package/src/configs/danger/toptal/plugins/toptal-pr-title/toptal-pr-title.test.js

@@ -0,0 +1,68 @@
+const { toptalPRTitle } = require('.')
+const {
+  MISSING_TICKET_CODE_ERROR_MESSAGE,
+  DEFAULT_PR_TITLE_ERROR_MESSAGE,
+} = require('../../config')
+
+const VALID_PR_TITLE = '[ASD-123] Hello world'
+const INVALID_PR_TITLE = '[ASD-123] hello world'
+const NO_TICKET_CODE_PR_TITLE = 'Hello world'
+
+describe('commit danger plugin', () => {
+  beforeEach(() => {
+    global.fail = jest.fn()
+    global.danger = {
+      github: {
+        issue: {
+          labels: [{ name: 'My Team' }],
+        },
+        pr: {
+          title: '',
+          user: {
+            login: 'user',
+          },
+        },
+      },
+    }
+  })
+
+  afterEach(() => {
+    global.fail = undefined
+    global.danger = undefined
+  })
+
+  it('should pass valid PR title', () => {
+    global.danger.github.pr.title = VALID_PR_TITLE
+
+    toptalPRTitle()
+
+    expect(global.fail).toHaveBeenCalledTimes(0)
+  })
+
+  it('should fail PR title with missing ticket code', () => {
+    global.danger.github.pr.title = NO_TICKET_CODE_PR_TITLE
+
+    toptalPRTitle()
+
+    expect(global.fail).toHaveBeenCalledTimes(1)
+    expect(global.fail).toHaveBeenCalledWith(MISSING_TICKET_CODE_ERROR_MESSAGE)
+  })
+
+  it('should pass valid PR title with missing ticket code and no-jira label', () => {
+    global.danger.github.pr.title = NO_TICKET_CODE_PR_TITLE
+    global.danger.github.issue.labels = [{ name: 'no-jira' }]
+
+    toptalPRTitle()
+
+    expect(global.fail).toHaveBeenCalledTimes(0)
+  })
+
+  it('should fail invalid PR title', () => {
+    global.danger.github.pr.title = INVALID_PR_TITLE
+
+    toptalPRTitle()
+
+    expect(global.fail).toHaveBeenCalledTimes(1)
+    expect(global.fail).toHaveBeenCalledWith(DEFAULT_PR_TITLE_ERROR_MESSAGE)
+  })
+})

package/src/configs/docker/Dockerfile

@@ -0,0 +1,30 @@
+FROM node:14
+
+ARG NPM_TOKEN
+ENV NPM_TOKEN ${NPM_TOKEN}
+
+# Change default 'node' user id to match jenkins CI user id
+# so when we will be running container from CI it would have
+# all necessary rights for npm/yarn publish
+RUN groupmod -g 469 node && usermod -u 469 -g 469 node
+
+WORKDIR /app
+RUN chown -R node /app
+
+USER node
+
+# Add github.com to known ssh hosts
+RUN mkdir ~/.ssh
+RUN ssh-keyscan github.com >> ~/.ssh/known_hosts
+
+# Needs to be updated for publishing package to npm
+RUN printf '//registry.npmjs.org/:_authToken=${NPM_TOKEN}\nalways-auth=true\n' > .npmrc
+RUN yarn config set registry https://registry.npmjs.org
+
+# Enables layer caching
+COPY --chown=node:node package.json yarn.lock ./
+RUN yarn install --frozen-lockfile --network-timeout 120000
+
+COPY --chown=node:node . /app
+
+RUN yarn build