@talkpilot/core-db 1.2.0 → 1.2.2

package/src/talkpilot/clients/index.ts

@@ -1,2 +1,2 @@
-export * from "./clients.getters";
-export * from "./clients.types";
+export * from "./clients.getters";
+export * from "./clients.types";

package/src/talkpilot/clientsConfig/__tests__/clientsConfig.getters.spec.ts

@@ -0,0 +1,53 @@
+import { describe, it, expect, beforeEach, afterEach } from "@jest/globals";
+import {
+  getClientsConfigCollection,
+  updateProductConfig,
+} from "../clientsConfig.getters";
+
+describe("updateProductConfig", () => {
+  beforeEach(async () => {
+    await getClientsConfigCollection().deleteMany({});
+  });
+
+  afterEach(async () => {
+    await getClientsConfigCollection().deleteMany({});
+  });
+
+  it("should update partial fields using correct dot notation", async () => {
+    const clientId = "client-123";
+    const collection = getClientsConfigCollection();
+
+    await collection.insertOne({
+      clientId,
+      products: {
+        websiteTalk: {
+          language: "English",
+          companyName: "OldCorp",
+          defaultBaseUrl: "https://old-url.com",
+          logoUrl: "",
+          timezone: "UTC",
+        },
+      },
+    } as any);
+
+    const updates = { language: "Hebrew", companyName: "TestCorp" };
+    await updateProductConfig(clientId, "websiteTalk", updates);
+
+    const updatedDoc = await collection.findOne({ clientId });
+
+    expect(updatedDoc).toBeDefined();
+    expect(updatedDoc?.products.websiteTalk?.language).toBe("Hebrew");
+    expect(updatedDoc?.products.websiteTalk?.companyName).toBe("TestCorp");
+    expect(updatedDoc?.products.websiteTalk?.defaultBaseUrl).toBe(
+      "https://old-url.com",
+    );
+  });
+
+  it("should throw an error if no client config is found", async () => {
+    await expect(
+      updateProductConfig("invalid-client", "websiteTalk", {
+        language: "English",
+      }),
+    ).rejects.toThrow("No client config found for clientId: invalid-client");
+  });
+});

package/src/talkpilot/clientsConfig/__tests__/clientsConfig.spec.ts

@@ -1,106 +1,197 @@
-import {
-  createClientConfigDoc,
-  getClientConfig,
-} from "../clientsConfig.getters";
-import { createClientConfig } from "../../../test-utils/factories";
-
-describe("db.clientsConfig", () => {
-  describe("getClientConfig", () => {
-    it("should return client config by clientId", async () => {
-      const clientId = "test-client-id";
-      const clientConfig = createClientConfig({
-        clientId,
-        language: "Hebrew",
-        products: { feature1: true, feature2: false } as any,
-      });
-
-      await createClientConfigDoc(clientConfig);
-
-      const result = await getClientConfig(clientId);
-
-      expect(result).toMatchObject({
-        clientId,
-        language: "Hebrew",
-        products: { feature1: true, feature2: false },
-      });
-    });
-
-    it("should support websiteTalk product config", async () => {
-      const clientId = "websiteTalk-test";
-      const clientConfig = createClientConfig({
-        clientId,
-        products: {
-          websiteTalk: {
-            logoUrl: "https://cdn.example.com/branding/acme/logo.png",
-            companyName: "Acme Ltd",
-            timezone: "Asia/Jerusalem",
-            language: "he",
-            defaultBaseUrl: "https://acme.example",
-            scheduler: {
-              type: "cron",
-              schedule: "0 9 * * 1-5"
-           },
-          },
-        },
-      });
-
-      await createClientConfigDoc(clientConfig);
-
-      const result = await getClientConfig(clientId);
-
-      expect(result).toMatchObject({
-        clientId,
-        products: {
-          websiteTalk: {
-            logoUrl: "https://cdn.example.com/branding/acme/logo.png",
-            companyName: "Acme Ltd",
-            timezone: "Asia/Jerusalem",
-            language: "he",
-            defaultBaseUrl: "https://acme.example",
-            scheduler: {
-              type: "cron",
-            },
-          },
-        },
-      });
-    });
-
-    it("should return null for non-existent clientId", async () => {
-      const result = await getClientConfig("non-existent-client");
-      expect(result).toBeNull();
-    });
-
-    it("should support communications config", async () => {
-      const clientId = "communications-test";
-      const clientConfig = createClientConfig({
-        clientId,
-        communications: {
-          sendGrid: {
-            emailTo: ["test@example.com"],
-            templateId: "temp-123",
-            senderId: "sender-123",
-          },
-          sms: {},
-          whatsapp: {},
-        },
-      });
-
-      await createClientConfigDoc(clientConfig);
-
-      const result = await getClientConfig(clientId);
-
-      expect(result).toMatchObject({
-        clientId,
-        communications: {
-          sendGrid: {
-            emailTo: ["test@example.com"],
-            templateId: "temp-123",
-            senderId: "sender-123",
-          },
-          sms: {},
-          whatsapp: {},
-        },
-      });
-    });
-  });
-});
+import {
+  createClientConfigDoc,
+  getClientConfig,
+} from "../clientsConfig.getters";
+import { createClientConfig } from "../../../test-utils/factories";
+
+describe("db.clientsConfig", () => {
+  describe("getClientConfig", () => {
+    it("should return client config by clientId", async () => {
+      const clientId = "test-client-id";
+      const clientConfig = createClientConfig({
+        clientId,
+        language: "Hebrew",
+        products: { feature1: true, feature2: false } as any,
+      });
+
+      await createClientConfigDoc(clientConfig);
+
+      const result = await getClientConfig(clientId);
+
+      expect(result).toMatchObject({
+        clientId,
+        language: "Hebrew",
+        products: { feature1: true, feature2: false },
+      });
+    });
+
+    it("should support websiteTalk product config", async () => {
+      const clientId = "websiteTalk-test";
+      const clientConfig = createClientConfig({
+        clientId,
+        products: {
+          websiteTalk: {
+            logoUrl: "https://cdn.example.com/branding/acme/logo.png",
+            companyName: "Acme Ltd",
+            timezone: "Asia/Jerusalem",
+            language: "he",
+            defaultBaseUrl: "https://acme.example",
+            scheduler: {
+              type: "cron",
+              schedule: "0 9 * * 1-5",
+            },
+          },
+        },
+      });
+
+      await createClientConfigDoc(clientConfig);
+
+      const result = await getClientConfig(clientId);
+
+      expect(result).toMatchObject({
+        clientId,
+        products: {
+          websiteTalk: {
+            logoUrl: "https://cdn.example.com/branding/acme/logo.png",
+            companyName: "Acme Ltd",
+            timezone: "Asia/Jerusalem",
+            language: "he",
+            defaultBaseUrl: "https://acme.example",
+            scheduler: {
+              type: "cron",
+            },
+          },
+        },
+      });
+    });
+
+    it("should return null for non-existent clientId", async () => {
+      const result = await getClientConfig("non-existent-client");
+      expect(result).toBeNull();
+    });
+
+    it("given moked_106 with both toolsPrompts when saved and retrieved then both prompts are persisted", async () => {
+      // Given
+      const clientId = "tools-prompts-both";
+      const clientConfig = createClientConfig({
+        clientId,
+        products: {
+          municipal: {
+            cityName: "ashdod",
+            timezone: "Asia/Jerusalem",
+            moked_106: {
+              toolsPrompts: {
+                findSubjectsSystemPrompt: "Custom subjects prompt",
+                findStreetsSystemPrompt: "Custom streets prompt",
+              },
+            },
+          },
+        },
+      });
+
+      // When
+      await createClientConfigDoc(clientConfig);
+      const result = await getClientConfig(clientId);
+
+      // Then
+      expect(result?.products.municipal?.moked_106?.toolsPrompts).toMatchObject(
+        {
+          findSubjectsSystemPrompt: "Custom subjects prompt",
+          findStreetsSystemPrompt: "Custom streets prompt",
+        },
+      );
+    });
+
+    it("given moked_106 with findSubjectsSystemPrompt only when saved and retrieved then findStreetsSystemPrompt is undefined", async () => {
+      // Given
+      const clientId = "tools-prompts-subjects-only";
+      const clientConfig = createClientConfig({
+        clientId,
+        products: {
+          municipal: {
+            cityName: "ashdod",
+            timezone: "Asia/Jerusalem",
+            moked_106: {
+              toolsPrompts: {
+                findSubjectsSystemPrompt: "Subjects only prompt",
+              },
+            },
+          },
+        },
+      });
+
+      // When
+      await createClientConfigDoc(clientConfig);
+      const result = await getClientConfig(clientId);
+
+      // Then
+      expect(
+        result?.products.municipal?.moked_106?.toolsPrompts
+          ?.findSubjectsSystemPrompt,
+      ).toBe("Subjects only prompt");
+      expect(
+        result?.products.municipal?.moked_106?.toolsPrompts
+          ?.findStreetsSystemPrompt,
+      ).toBeUndefined();
+    });
+
+    it("given moked_106 without toolsPrompts when saved and retrieved then toolsPrompts is undefined", async () => {
+      // Given
+      const clientId = "tools-prompts-absent";
+      const clientConfig = createClientConfig({
+        clientId,
+        products: {
+          municipal: {
+            cityName: "ashdod",
+            timezone: "Asia/Jerusalem",
+            moked_106: {
+              avoidSaveTickets: true,
+            },
+          },
+        },
+      });
+
+      // When
+      await createClientConfigDoc(clientConfig);
+      const result = await getClientConfig(clientId);
+
+      // Then
+      expect(
+        result?.products.municipal?.moked_106?.toolsPrompts,
+      ).toBeUndefined();
+    });
+
+    it("should support communications config", async () => {
+      const clientId = "communications-test";
+      const clientConfig = createClientConfig({
+        clientId,
+        communications: {
+          sendGrid: {
+            emailTo: ["test@example.com"],
+            templateId: "temp-123",
+            senderId: "sender-123",
+          },
+          sms: {},
+          whatsapp: {},
+        },
+      });
+
+      await createClientConfigDoc(clientConfig);
+
+      const result = await getClientConfig(clientId);
+
+      expect(result).toMatchObject({
+        clientId,
+        communications: {
+          sendGrid: {
+            emailTo: ["test@example.com"],
+            templateId: "temp-123",
+            senderId: "sender-123",
+          },
+          sms: {},
+          whatsapp: {},
+        },
+      });
+    });
+  });
+});

package/src/talkpilot/clientsConfig/clientsConfig.getters.ts

@@ -1,44 +1,55 @@
-import { ClientConfigDoc, getDb, findClientByPhoneNumber } from "../index";
-import { Collection } from "mongodb";
-
-export const getClientsConfigCollection = (): Collection<ClientConfigDoc> => {
-  return getDb().collection<ClientConfigDoc>("clientsConfig");
-};
-
-export const getClientConfig = (clientId: string) => {
-  return getClientsConfigCollection().findOne({ clientId });
-};
-
-export const getClientConfigByPhone = async (phone: string) => {
-  const client = await findClientByPhoneNumber(phone);
-  if (!client) return null;
-  return getClientConfig(client.clientId);
-};
-
-export const createClientConfigDoc = async (
-  clientConfig: ClientConfigDoc,
-): Promise<void> => {
-  await getClientsConfigCollection().insertOne(clientConfig);
-};
-
-export async function updateWebsitalkDefaultBaseUrl(
-  clientId: string,
-  defaultBaseUrl: string,
-): Promise<void> {
-  try {
-    const result = await getClientsConfigCollection().updateOne(
-      { clientId },
-      { $set: { "products.websiteTalk.defaultBaseUrl": defaultBaseUrl } },
-    );
-
-    if (result.matchedCount === 0) {
-      throw new Error(`No client config found for clientId: ${clientId}`);
-    }
-  } catch (error) {
-   console.error(
-      `[core-db] Error updating defaultBaseUrl for client: ${clientId}`,
-      error
-    );
-    throw error;
-  }
-}
+import {
+  ClientConfigDoc,
+  getDb,
+  findClientByPhoneNumber,
+  Products,
+  KNOWN_PRODUCT_KEYS,
+  KnownProductKey,
+} from "../index";
+import { Collection } from "mongodb";
+
+export const getClientsConfigCollection = (): Collection<ClientConfigDoc> => {
+  return getDb().collection<ClientConfigDoc>("clientsConfig");
+};
+
+export const getClientConfig = (clientId: string) => {
+  return getClientsConfigCollection().findOne({ clientId });
+};
+
+export const getClientConfigByPhone = async (phone: string) => {
+  const client = await findClientByPhoneNumber(phone);
+  if (!client) return null;
+  return getClientConfig(client.clientId);
+};
+
+export const createClientConfigDoc = async (
+  clientConfig: ClientConfigDoc,
+): Promise<void> => {
+  await getClientsConfigCollection().insertOne(clientConfig);
+};
+
+export async function updateProductConfig<K extends KnownProductKey>(
+  clientId: string,
+  productKey: K,
+  updates: Partial<Products[K]>,
+): Promise<void> {
+  if (!KNOWN_PRODUCT_KEYS.includes(productKey as KnownProductKey)) {
+    throw new Error(
+      `Invalid product key: "${productKey}". Must be one of: ${KNOWN_PRODUCT_KEYS.join(", ")}`,
+    );
+  }
+
+  const setOperations: Record<string, unknown> = {};
+  for (const [key, value] of Object.entries(updates)) {
+    setOperations[`products.${productKey}.${key}`] = value;
+  }
+
+  const result = await getClientsConfigCollection().updateOne(
+    { clientId },
+    { $set: setOperations },
+  );
+
+  if (result.matchedCount === 0) {
+    throw new Error(`No client config found for clientId: ${clientId}`);
+  }
+}