@sun-asterisk/sunlint 1.2.2 → 1.3.0

package/config/engines/eslint-rule-mapping.json

@@ -1,74 +0,0 @@
-{
-  "C005": [
-    "max-statements-per-line",
-    "complexity"
-  ],
-  "C006": [
-    "func-names",
-    "func-name-matching",
-    "@typescript-eslint/naming-convention"
-  ],
-  "C007": [
-    "spaced-comment",
-    "no-inline-comments",
-    "no-warning-comments"
-  ],
-  "C012": [
-    "consistent-return",
-    "no-void",
-    "@typescript-eslint/no-confusing-void-expression"
-  ],
-  "C014": [
-    "no-new",
-    "no-new-wrappers",
-    "@typescript-eslint/no-unnecessary-constructor"
-  ],
-  "C015": [
-    "@typescript-eslint/naming-convention",
-    "camelcase"
-  ],
-  "C019": [
-    "no-console",
-    "no-alert",
-    "no-debugger"
-  ],
-  "C031": [
-    "no-implicit-coercion",
-    "eqeqeq",
-    "@typescript-eslint/strict-boolean-expressions"
-  ],
-  "C032": [
-    "no-new",
-    "@typescript-eslint/no-floating-promises",
-    "no-constructor-return"
-  ],
-  "C033": [
-    "prefer-const",
-    "no-var",
-    "@typescript-eslint/prefer-readonly"
-  ],
-  "C034": [
-    "no-global-assign",
-    "no-implicit-globals",
-    "@typescript-eslint/no-namespace"
-  ],
-  "C035": [
-    "no-empty-catch",
-    "@typescript-eslint/no-unused-vars"
-  ],
-  "C037": [
-    "consistent-return",
-    "@typescript-eslint/explicit-function-return-type",
-    "@typescript-eslint/explicit-module-boundary-types"
-  ],
-  "C038": [
-    "import/no-dynamic-require",
-    "import/order",
-    "@typescript-eslint/no-var-requires"
-  ],
-  "C040": [
-    "no-duplicate-imports",
-    "import/no-duplicates",
-    "@typescript-eslint/no-duplicate-imports"
-  ]
-}

package/config/testing/test-s005-working.ts

@@ -1,22 +0,0 @@
-function doAdminTask() {}
-function doAction() {}
-function isAuthenticated(req: any): boolean {
-  return true;
-}
-
-function doPost(request: any, response: any) { // ❌
-  const origin = request.getHeader("Origin");
-
-  if (origin === "https://admin.example.com") {
-    doAdminTask();
-  }
-}
-
-function doPost_safe(request: any, response: any) { // ✅
-  const origin = request.getHeader("Origin");
-  console.log("Origin:", origin);
-
-  if (isAuthenticated(request)) {
-    doAction();
-  }
-}

package/rules/common/C029_catch_block_logging/analyzer-backup.js

@@ -1,426 +0,0 @@
-const fs = require('fs');
-cons  async analyze(files, language, options = {}) {
-    // Use Smart Pipeline as primary choice
-    if (this.smartPipeline) {
-      console.log('🎯 C029: Using Smart Pipeline (3-stage analysis)...');
-      return await this.smartPipeline.analyze(files, language, options);
-    } else if (this.astAnalyzer) {
-      console.log('🚀 C029: Using AST-enhanced analysis...');
-      return await this.astAnalyzer.analyze(files, language, options);
-    } else {
-      console.log('🔍 C029: Using regex-based analysis...');
-      return await this.analyzeWithRegex(files, language, options);
-    }
-  }ire('path');
-const { PatternMatcher } = require('../../utils/pattern-matchers');
-const { RuleHelper } = require('../../utils/rule-helpers');
-
-class C029Analyzer {
-  constructor() {
-    this.ruleId = 'C029';
-    this.ruleName = 'Enhanced Catch Block Error Logging';
-    this.description = 'Mọi catch block phải log nguyên nhân lỗi đầy đủ và bảo toàn context (Smart Pipeline 3-stage analysis)';
-    
-    // Load Smart Pipeline as primary analyzer
-    this.smartPipeline = null;
-    
-    try {
-      this.smartPipeline = require('./analyzer-smart-pipeline.js');
-      console.log('🎯 C029: Smart Pipeline loaded (3-stage: Regex → AST → Data Flow)');
-    } catch (error) {
-      console.warn('⚠️ C029: Smart Pipeline failed, falling back:', error.message);
-      
-      // Fallback to simpler analyzers
-      try {
-        this.astAnalyzer = require('./ast-analyzer.js');
-        console.log('🚀 C029: AST analyzer loaded (hybrid approach)');
-      } catch (error) {
-        console.warn('⚠️ C029: AST analyzer failed:', error.message);
-      }
-    }
-  }
-
-  async analyze(files, language, options = {}) {
-    // Use Smart Pipeline as primary choice
-    if (this.smartPipeline) {
-      console.log('🎯 C029: Using Smart Pipeline (3-stage analysis)...');
-      return await this.smartPipeline.analyze(files, language, options);
-    } else if (this.astAnalyzer) {
-      console.log('🚀 C029: Using AST-enhanced analysis...');
-      return await this.astAnalyzer.analyze(files, language, options);
-    } else {
-      console.log('🔍 C029: Using regex-based analysis...');
-      return await this.analyzeWithRegex(files, language, options);
-    }
-  }
-      console.log('🧠 C029: Using Data Flow analysis (IDE-level)...');
-      return await this.dataFlowAnalyzer.analyze(files, language, options);
-    } else if (this.astAnalyzer) {
-      console.log('� C029: Using AST-enhanced analysis...');
-      return await this.astAnalyzer.analyze(files, language, options);
-    } else {
-      console.log('🔍 C029: Using regex-based analysis...');
-      return await this.analyzeWithRegex(files, language, options);
-    }
-  }
-
-  async analyzeWithRegex(files, language, options = {}) {
-    const violations = [];
-    
-    for (const filePath of files) {
-      if (options.verbose) {
-        console.log(`🔍 Running pattern analysis on ${path.basename(filePath)}`);
-      }
-      
-      try {
-        const content = fs.readFileSync(filePath, 'utf8');
-        const fileViolations = await this.analyzeFile(filePath, content, language, options);
-        violations.push(...fileViolations);
-      } catch (error) {
-        console.warn(`⚠️ Failed to analyze ${filePath}: ${error.message}`);
-      }
-    }
-    
-    return violations;
-  }
-
-  async analyzeFile(filePath, content, language, config) {
-    switch (language) {
-      case 'typescript':
-      case 'javascript':
-        return this.analyzeTypeScript(filePath, content, config);
-      default:
-        return [];
-    }
-  }
-
-  async analyzeTypeScript(filePath, content, config) {
-    const violations = [];
-    const lines = content.split('\n');
-
-    // Focus on core functionality - only detect truly silent catch blocks
-    violations.push(...this.findSilentCatchBlocks(lines, filePath));
-    // Disabled strict checks to reduce false positives:
-    // violations.push(...this.findInadequateErrorLogging(lines, filePath));
-    // violations.push(...this.findMissingErrorContext(lines, filePath));
-
-    return violations;
-  }
-
-  /**
-   * Core functionality from ESLint C029 - detect silent catch blocks
-   */
-  findSilentCatchBlocks(lines, filePath) {
-    const violations = [];
-    
-    lines.forEach((line, index) => {
-      const lineNumber = index + 1;
-      const trimmedLine = line.trim();
-
-      // Detect catch block start
-      if (this.isCatchBlockStart(trimmedLine)) {
-        const catchBlockInfo = this.extractCatchBlockInfo(lines, index);
-        
-        if (catchBlockInfo.isEmpty) {
-          violations.push({
-            ruleId: this.ruleId,
-            file: filePath,
-            line: lineNumber,
-            column: line.indexOf('catch') + 1,
-            message: 'Empty catch block - error is silently ignored',
-            severity: 'error',
-            code: trimmedLine,
-            type: 'empty_catch_block',
-            confidence: 1.0,
-            suggestion: 'Add error logging or rethrowing in catch block'
-          });
-        } else if (!catchBlockInfo.hasLoggingOrRethrow) {
-          violations.push({
-            ruleId: this.ruleId,
-            file: filePath,
-            line: lineNumber,
-            column: line.indexOf('catch') + 1,
-            message: 'Catch block must log error or rethrow - silent error handling hides bugs',
-            severity: 'error',
-            code: trimmedLine,
-            type: 'silent_catch_block',
-            confidence: 0.9,
-            suggestion: 'Add error logging (console.error, logger.error) or rethrow the error'
-          });
-        }
-      }
-    });
-
-    return violations;
-  }
-
-  /**
-   * SunLint enhanced functionality - detect inadequate error logging
-   */
-  findInadequateErrorLogging(lines, filePath) {
-    const violations = [];
-    
-    lines.forEach((line, index) => {
-      const lineNumber = index + 1;
-      const trimmedLine = line.trim();
-
-      if (this.isCatchBlockStart(trimmedLine)) {
-        const catchBlockInfo = this.extractCatchBlockInfo(lines, index);
-        
-        if (catchBlockInfo.hasLoggingOrRethrow && !catchBlockInfo.hasAdequateLogging) {
-          violations.push({
-            ruleId: this.ruleId,
-            file: filePath,
-            line: lineNumber,
-            column: line.indexOf('catch') + 1,
-            message: 'Error logging should include error message, stack trace, and context',
-            severity: 'warning',
-            code: trimmedLine,
-            type: 'inadequate_error_logging',
-            confidence: 0.8,
-            suggestion: 'Include error.message, error.stack, and relevant context in error logging'
-          });
-        }
-      }
-    });
-
-    return violations;
-  }
-
-  /**
-   * SunLint enhanced functionality - detect missing error context
-   * DISABLED: Too strict, causing false positives
-   */
-  findMissingErrorContext(lines, filePath) {
-    // Disabled to reduce false positives
-    return [];
-    
-    /* Original strict implementation:
-    const violations = [];
-    
-    lines.forEach((line, index) => {
-      const lineNumber = index + 1;
-      const trimmedLine = line.trim();
-
-      if (this.isCatchBlockStart(trimmedLine)) {
-        const catchBlockInfo = this.extractCatchBlockInfo(lines, index);
-        
-        if (catchBlockInfo.hasLoggingOrRethrow && !catchBlockInfo.hasContextualLogging) {
-          violations.push({
-            ruleId: this.ruleId,
-            file: filePath,
-            line: lineNumber,
-            column: line.indexOf('catch') + 1,
-            message: 'Error logging should include operational context (function name, input parameters)',
-            severity: 'info',
-            code: trimmedLine,
-            type: 'missing_error_context',
-            confidence: 0.7,
-            suggestion: 'Include function name, input parameters, and operational context in error logging'
-          });
-        }
-      }
-    });
-
-    return violations;
-    */
-  }
-
-  isCatchBlockStart(line) {
-    return line.includes('catch (') || line.includes('catch(');
-  }
-
-  extractCatchBlockInfo(lines, startIndex) {
-    const catchBlockLines = [];
-    let braceDepth = 0;
-    let foundCatchBrace = false;
-
-    for (let i = startIndex; i < lines.length; i++) {
-      const line = lines[i];
-      catchBlockLines.push(line);
-      
-      // Check if this is the catch line with opening brace
-      if (this.isCatchBlockStart(line.trim())) {
-        // Count braces in the catch line itself
-        for (const char of line) {
-          if (char === '{') {
-            foundCatchBrace = true;
-            braceDepth = 1; // Start counting from 1 for the catch block
-          }
-        }
-      } else if (foundCatchBrace) {
-        // Count braces in subsequent lines
-        for (const char of line) {
-          if (char === '{') {
-            braceDepth++;
-          } else if (char === '}') {
-            braceDepth--;
-          }
-        }
-        
-        // If we've closed all braces, we're done
-        if (braceDepth === 0) {
-          break;
-        }
-      }
-    }
-
-    const content = catchBlockLines.join('\n').toLowerCase();
-    const originalContent = catchBlockLines.join('\n');
-    
-    return {
-      isEmpty: this.isCatchBlockEmpty(catchBlockLines),
-      hasLoggingOrRethrow: this.hasLoggingOrRethrow(content, originalContent),
-      hasAdequateLogging: this.hasAdequateErrorLogging(content, originalContent),
-      hasContextualLogging: this.hasContextualErrorLogging(content, originalContent)
-    };
-  }
-
-  isCatchBlockEmpty(catchBlockLines) {
-    if (catchBlockLines.length === 0) return true;
-    
-    // Join all lines and find the content between braces
-    const fullContent = catchBlockLines.join('\n');
-    
-    // Find the opening brace and closing brace
-    let openBraceIndex = fullContent.indexOf('{');
-    let closeBraceIndex = fullContent.lastIndexOf('}');
-    
-    if (openBraceIndex === -1 || closeBraceIndex === -1) {
-      return true; // Malformed catch block
-    }
-    
-    // Extract body content between braces
-    const bodyContent = fullContent.substring(openBraceIndex + 1, closeBraceIndex).trim();
-    
-    // Remove comments and whitespace
-    const cleanedBody = bodyContent
-      .replace(/\/\*[\s\S]*?\*\//g, '') // Remove block comments
-      .replace(/\/\/.*$/gm, '') // Remove line comments
-      .replace(/\s+/g, ' ') // Normalize whitespace
-      .trim();
-    
-    return cleanedBody.length === 0;
-  }
-
-  hasLoggingOrRethrow(content, originalContent) {
-    // Check for throw statements
-    if (content.includes('throw ') || content.includes('throw;')) {
-      return true;
-    }
-
-    // Check for test assertions - valid form of error handling
-    const testPatterns = [
-      'expect(',
-      'assert(',
-      'tobeinstanceof',
-      'toequal(',
-      'tohavebeencalled',
-      'toBe(',
-      'toHaveBeenCalledWith'
-    ];
-
-    const hasTestAssertions = testPatterns.some(pattern => 
-      content.includes(pattern.toLowerCase()) || originalContent.toLowerCase().includes(pattern.toLowerCase())
-    );
-
-    if (hasTestAssertions) {
-      return true;
-    }
-
-    // Check for Redux/async thunk error handling
-    const reduxErrorHandlers = [
-      'handleaxioserror',
-      'rejectwithvalue',
-      'dispatch(',
-      'seterror(',
-      'return value',
-      'return rejectwithvalue'
-    ];
-
-    const hasReduxHandling = reduxErrorHandlers.some(pattern => 
-      content.includes(pattern.toLowerCase()) || originalContent.toLowerCase().includes(pattern.toLowerCase())
-    );
-
-    if (hasReduxHandling) {
-      return true;
-    }
-
-    // Check for logging patterns (expanded from original)
-    const loggingPatterns = [
-      'console.error',
-      'console.log',
-      'console.warn',
-      'logger.error',
-      'log.error',
-      'logger.warn',
-      'log.warn',
-      'winston.error',
-      'bunyan.error',
-      'pino.error',
-      '.error(',
-      '.warn(',
-      '.log('
-    ];
-
-    // Accept basic error logging - don't require context
-    const hasBasicLogging = loggingPatterns.some(pattern => 
-      content.includes(pattern) || originalContent.includes(pattern)
-    );
-
-    return hasBasicLogging;
-  }
-
-  hasAdequateErrorLogging(content, originalContent) {
-    // Check for error properties being logged
-    const errorProperties = [
-      'error.message',
-      'error.stack',
-      'err.message',
-      'err.stack',
-      'e.message',
-      'e.stack',
-      'error.name',
-      'error.cause'
-    ];
-
-    const hasErrorProperties = errorProperties.some(prop => 
-      content.includes(prop) || originalContent.includes(prop)
-    );
-
-    // Check for comprehensive error logging
-    const hasLogging = this.hasLoggingOrRethrow(content, originalContent);
-    
-    return hasLogging && hasErrorProperties;
-  }
-
-  hasContextualErrorLogging(content, originalContent) {
-    // Check for contextual information in logging
-    const contextualPatterns = [
-      'function',
-      'method',
-      'operation',
-      'input',
-      'parameters',
-      'context',
-      'state',
-      'request',
-      'response',
-      'userId',
-      'sessionId',
-      'transactionId'
-    ];
-
-    // Check if logging includes contextual information
-    const hasContextualInfo = contextualPatterns.some(pattern => 
-      content.includes(pattern) || originalContent.includes(pattern)
-    );
-
-    // Check for template literals or string concatenation (indicates contextual logging)
-    const hasTemplateLogging = originalContent.includes('${') || originalContent.includes('" + ') || originalContent.includes("' + ");
-
-    return hasContextualInfo || hasTemplateLogging;
-  }
-}
-
-module.exports = new C029Analyzer();

package/rules/common/C029_catch_block_logging/analyzer-fixed.js

@@ -1,130 +0,0 @@
-/**
- * C029 Analyzer - Smart Pipeline Integration
- * 
- * This analyzer forwards to the Smart Pipeline for superior accuracy and performance
- */
-
-const fs = require('fs');
-const path = require('path');
-
-class C029Analyzer {
-  constructor() {
-    this.ruleId = 'C029';
-    this.ruleName = 'Enhanced Catch Block Error Logging';
-    this.description = 'Mọi catch block phải log nguyên nhân lỗi đầy đủ và bảo toàn context (Smart Pipeline 3-stage analysis)';
-    
-    // Load Smart Pipeline as primary analyzer
-    this.smartPipeline = null;
-    
-    try {
-      const SmartPipelineClass = require('./analyzer-smart-pipeline.js');
-      this.smartPipeline = new SmartPipelineClass();
-      console.log('🎯 C029: Smart Pipeline loaded (3-stage: Regex → AST → Data Flow)');
-    } catch (error) {
-      console.warn('⚠️ C029: Smart Pipeline failed, using fallback:', error.message);
-      this.smartPipeline = null;
-    }
-  }
-
-  async analyze(files, language, options = {}) {
-    // Use Smart Pipeline as primary choice
-    if (this.smartPipeline) {
-      console.log('🎯 C029: Using Smart Pipeline (3-stage analysis)...');
-      return await this.smartPipeline.analyze(files, language, options);
-    } else {
-      console.log('🔍 C029: Using fallback regex analysis...');
-      return await this.analyzeWithRegex(files, language, options);
-    }
-  }
-
-  async analyzeWithRegex(files, language, options = {}) {
-    const violations = [];
-    
-    for (const filePath of files) {
-      if (options.verbose) {
-        console.log(`🔍 C029 Regex: Processing ${path.basename(filePath)}...`);
-      }
-      
-      try {
-        const content = fs.readFileSync(filePath, 'utf8');
-        const fileViolations = await this.analyzeFile(filePath, content, language);
-        violations.push(...fileViolations);
-      } catch (error) {
-        console.warn(`⚠️ C029: Error processing ${filePath}:`, error.message);
-      }
-    }
-    
-    return violations;
-  }
-
-  async analyzeFile(filePath, content, language) {
-    const violations = [];
-    const lines = content.split('\n');
-    
-    for (let i = 0; i < lines.length; i++) {
-      const line = lines[i];
-      
-      // Simple catch block detection
-      if (line.includes('catch') && line.includes('(')) {
-        const catchBlock = this.extractCatchBlock(lines, i);
-        
-        if (this.isCatchBlockEmpty(catchBlock.content)) {
-          violations.push({
-            file: filePath,
-            line: i + 1,
-            column: line.indexOf('catch') + 1,
-            message: 'Empty catch block detected',
-            severity: 'error',
-            ruleId: this.ruleId,
-            type: 'empty_catch'
-          });
-        }
-      }
-    }
-    
-    return violations;
-  }
-
-  extractCatchBlock(lines, startIndex) {
-    const content = [];
-    let braceCount = 0;
-    let inBlock = false;
-    
-    for (let i = startIndex; i < lines.length; i++) {
-      const line = lines[i];
-      content.push(line);
-      
-      for (const char of line) {
-        if (char === '{') {
-          braceCount++;
-          inBlock = true;
-        } else if (char === '}') {
-          braceCount--;
-          if (braceCount === 0 && inBlock) {
-            return { content, endIndex: i };
-          }
-        }
-      }
-    }
-    
-    return { content, endIndex: startIndex };
-  }
-
-  isCatchBlockEmpty(content) {
-    const blockContent = content.join('\n');
-    
-    // Remove comments and whitespace
-    const cleanContent = blockContent
-      .replace(/\/\*[\s\S]*?\*\//g, '') // Remove multi-line comments
-      .replace(/\/\/.*$/gm, '') // Remove single-line comments
-      .replace(/\s+/g, ' ') // Normalize whitespace
-      .trim();
-    
-    // Check if only contains catch declaration and braces
-    const hasOnlyStructure = /^catch\s*\([^)]*\)\s*\{\s*\}$/.test(cleanContent);
-    
-    return hasOnlyStructure;
-  }
-}
-
-module.exports = C029Analyzer;