@ronin/compiler 0.16.4-leo-ron-1099-1-experimental-372 → 0.16.4

package/README.md

@@ -127,12 +127,7 @@ new Transaction(queries, {
   // Instead of returning an array of parameters for every statement (which allows for
   // preventing SQL injections), all parameters are inlined directly into the SQL strings.
   // This option should only be used if the generated SQL will be manually verified.
-  inlineParams: true,
-
-  // By default, the compiler relies on dynamic column default values for computing the
-  // values of all meta fields (such as `id`, `ronin.createdAt`, etc). In order to compute
-  // those values at the time of insertion instead, use this option.
-  inlineDefaults: true
+  inlineParams: true
 });
 ```
 

package/dist/index.d.ts

@@ -404,10 +404,6 @@ interface TransactionOptions {
      * separating them out into a dedicated `params` array.
      */
     inlineParams?: boolean;
-    /**
-     * Whether to compute default field values as part of the generated statement.
-     */
-    inlineDefaults?: boolean;
 }
 declare class Transaction {
     #private;

package/dist/index.js

@@ -23,12 +23,6 @@ var RAW_FIELD_TYPES = ["string", "number", "boolean"];
 var CURRENT_TIME_EXPRESSION = {
   [QUERY_SYMBOLS.EXPRESSION]: `strftime('%Y-%m-%dT%H:%M:%f', 'now') || 'Z'`
 };
-var ID_EXPRESSION = (idPrefix) => ({
-  // Since default values in SQLite cannot rely on other columns, we unfortunately
-  // cannot rely on the `idPrefix` column here. Instead, we need to inject it directly
-  // into the expression as a static string.
-  [QUERY_SYMBOLS.EXPRESSION]: `'${idPrefix}_' || lower(substr(hex(randomblob(12)), 1, 16))`
-});
 var MOUNTING_PATH_SUFFIX = /(.*?)(\{(\d+)\})?$/;
 var composeMountingPath = (single, key, mountingPath) => {
   if (key === "ronin_root") {
@@ -263,9 +257,7 @@ var handleBeforeOrAfter = (model, statementParams, queryType, instructions) => {
 };
 
 // src/instructions/including.ts
-var handleIncluding = (models, model, statementParams, single, instruction, options = {
-  inlineDefaults: false
-}) => {
+var handleIncluding = (models, model, statementParams, single, instruction, options = {}) => {
   let statement = "";
   let tableSubQuery;
   for (const ephemeralFieldSlug in instruction) {
@@ -301,7 +293,7 @@ var handleIncluding = (models, model, statementParams, single, instruction, opti
         },
         models,
         statementParams,
-        { parentModel: model, inlineDefaults: options.inlineDefaults }
+        { parentModel: model }
       );
       relatedTableSelector = `(${subSelect.main.statement})`;
     }
@@ -330,7 +322,7 @@ var handleIncluding = (models, model, statementParams, single, instruction, opti
         statementParams,
         subSingle,
         modifiableQueryInstructions.including,
-        { mountingPath: subMountingPath, inlineDefaults: options.inlineDefaults }
+        { mountingPath: subMountingPath }
       );
       statement += ` ${subIncluding.statement}`;
     }
@@ -375,7 +367,7 @@ var handleOrderedBy = (model, instruction) => {
 };
 
 // src/instructions/selecting.ts
-var handleSelecting = (models, model, statementParams, single, instructions, options = { inlineDefaults: false }) => {
+var handleSelecting = (models, model, statementParams, single, instructions, options = {}) => {
   let isJoining = false;
   const selectedFields = filterSelectedFields(
     model,
@@ -403,8 +395,7 @@ var handleSelecting = (models, model, statementParams, single, instructions, opt
         const subQueryModel = getModelBySlug(models, queryModel);
         if (queryType === "count") {
           const subSelect = compileQueryInput(symbol2.value, models, statementParams, {
-            parentModel: { ...model, tableAlias: model.table },
-            inlineDefaults: options.inlineDefaults
+            parentModel: { ...model, tableAlias: model.table }
           });
           selectedFields.push({
             slug: key,
@@ -466,23 +457,16 @@ var handleSelecting = (models, model, statementParams, single, instructions, opt
 };
 
 // src/instructions/to.ts
-var handleTo = (models, model, statementParams, queryType, dependencyStatements, instructions, options) => {
+var handleTo = (models, model, statementParams, queryType, dependencyStatements, instructions, parentModel) => {
   const { with: withInstruction, to: toInstruction } = instructions;
   const defaultFields = {};
-  const inlineDefaultInsertionFields = queryType === "add" && options?.inlineDefaults;
-  if (inlineDefaultInsertionFields) {
-    defaultFields.id = toInstruction.id || ID_EXPRESSION(model.idPrefix);
-  }
-  if (queryType === "add" || queryType === "set" || toInstruction.ronin) {
-    const defaults = {
-      // If records are being created, set their creation time.
-      ...inlineDefaultInsertionFields ? { createdAt: CURRENT_TIME_EXPRESSION } : {},
+  if (queryType === "set" || toInstruction.ronin) {
+    defaultFields.ronin = {
       // If records are being updated, bump their update time.
-      ...queryType === "set" || inlineDefaultInsertionFields ? { updatedAt: CURRENT_TIME_EXPRESSION } : {},
+      ...queryType === "set" ? { updatedAt: CURRENT_TIME_EXPRESSION } : {},
       // Allow for overwriting the default values provided above.
       ...toInstruction.ronin
     };
-    if (Object.keys(defaults).length > 0) defaultFields.ronin = defaults;
   }
   const symbol = getQuerySymbol(toInstruction);
   if (symbol?.type === "query") {
@@ -508,10 +492,7 @@ var handleTo = (models, model, statementParams, queryType, dependencyStatements,
       });
       statement2 = `(${columns.join(", ")}) `;
     }
-    statement2 += compileQueryInput(symbol.value, models, statementParams, {
-      // biome-ignore lint/complexity/useSimplifiedLogicExpression: This is needed.
-      inlineDefaults: options?.inlineDefaults || false
-    }).main.statement;
+    statement2 += compileQueryInput(symbol.value, models, statementParams).main.statement;
     return statement2;
   }
   Object.assign(toInstruction, defaultFields);
@@ -539,8 +520,7 @@ var handleTo = (models, model, statementParams, queryType, dependencyStatements,
           },
           models,
           [],
-          // biome-ignore lint/complexity/useSimplifiedLogicExpression: This is needed.
-          { returning: false, inlineDefaults: options?.inlineDefaults || false }
+          { returning: false }
         ).main;
         dependencyStatements.push({ ...query, after: true });
       };
@@ -561,7 +541,7 @@ var handleTo = (models, model, statementParams, queryType, dependencyStatements,
     }
   }
   let statement = composeConditions(models, model, statementParams, "to", toInstruction, {
-    parentModel: options?.parentModel,
+    parentModel,
     type: queryType === "add" ? "fields" : void 0
   });
   if (queryType === "add") {
@@ -572,7 +552,7 @@ var handleTo = (models, model, statementParams, queryType, dependencyStatements,
       "to",
       toInstruction,
       {
-        parentModel: options?.parentModel,
+        parentModel,
         type: "values"
       }
     );
@@ -645,11 +625,7 @@ var compileQueryInput = (defaultQuery, models, statementParams, options) => {
     models,
     dependencyStatements,
     statementParams,
-    defaultQuery,
-    {
-      // biome-ignore lint/complexity/useSimplifiedLogicExpression: This is needed.
-      inlineDefaults: options?.inlineDefaults || false
-    }
+    defaultQuery
   );
   if (query === null)
     return { dependencies: [], main: dependencyStatements[0], selectedFields: [] };
@@ -679,9 +655,7 @@ var compileQueryInput = (defaultQuery, models, statementParams, options) => {
     {
       selecting: instructions?.selecting,
       including: instructions?.including
-    },
-    // biome-ignore lint/complexity/useSimplifiedLogicExpression: This is needed.
-    { inlineDefaults: options?.inlineDefaults || false }
+    }
   );
   let statement = "";
   switch (queryType) {
@@ -735,7 +709,7 @@ var compileQueryInput = (defaultQuery, models, statementParams, options) => {
       queryType,
       dependencyStatements,
       { with: instructions.with, to: instructionValue },
-      options
+      options?.parentModel
     );
     statement += `${toStatement} `;
   }
@@ -1484,7 +1458,12 @@ var getSystemFields = (idPrefix) => [
     name: "ID",
     type: "string",
     slug: "id",
-    defaultValue: ID_EXPRESSION(idPrefix)
+    defaultValue: {
+      // Since default values in SQLite cannot rely on other columns, we unfortunately
+      // cannot rely on the `idPrefix` column here. Instead, we need to inject it directly
+      // into the expression as a static string.
+      [QUERY_SYMBOLS.EXPRESSION]: `'${idPrefix}_' || lower(substr(hex(randomblob(12)), 1, 16))`
+    }
   },
   {
     name: "RONIN - Created At",
@@ -1643,7 +1622,7 @@ var formatModelEntity = (type, entities) => {
   });
   return entries ? Object.fromEntries(entries) : void 0;
 };
-var handleSystemModel = (models, dependencyStatements, action, inlineDefaults, systemModel, newModel) => {
+var handleSystemModel = (models, dependencyStatements, action, systemModel, newModel) => {
   const { system: _, ...systemModelClean } = systemModel;
   const query = {
     [action]: { model: action === "create" ? systemModelClean : systemModelClean.slug }
@@ -1652,10 +1631,10 @@ var handleSystemModel = (models, dependencyStatements, action, inlineDefaults, s
     const { system: _2, ...newModelClean } = newModel;
     query.alter.to = newModelClean;
   }
-  const statement = compileQueryInput(query, models, [], { inlineDefaults });
+  const statement = compileQueryInput(query, models, []);
   dependencyStatements.push(...statement.dependencies);
 };
-var handleSystemModels = (models, dependencyStatements, previousModel, newModel, inlineDefaults) => {
+var handleSystemModels = (models, dependencyStatements, previousModel, newModel) => {
   const currentSystemModels = models.filter(({ system }) => {
     return system?.model === newModel.id;
   });
@@ -1679,32 +1658,19 @@ var handleSystemModels = (models, dependencyStatements, previousModel, newModel,
     const exists = newSystemModels.find(matchSystemModels.bind(null, systemModel));
     if (exists) {
       if (exists.slug !== systemModel.slug) {
-        handleSystemModel(
-          models,
-          dependencyStatements,
-          "alter",
-          inlineDefaults,
-          systemModel,
-          exists
-        );
+        handleSystemModel(models, dependencyStatements, "alter", systemModel, exists);
       }
       continue;
     }
-    handleSystemModel(models, dependencyStatements, "drop", inlineDefaults, systemModel);
+    handleSystemModel(models, dependencyStatements, "drop", systemModel);
   }
   for (const systemModel of newSystemModels) {
     const exists = currentSystemModels.find(matchSystemModels.bind(null, systemModel));
     if (exists) continue;
-    handleSystemModel(
-      models,
-      dependencyStatements,
-      "create",
-      inlineDefaults,
-      systemModel
-    );
+    handleSystemModel(models, dependencyStatements, "create", systemModel);
   }
 };
-var transformMetaQuery = (models, dependencyStatements, statementParams, query, options) => {
+var transformMetaQuery = (models, dependencyStatements, statementParams, query) => {
   const { queryType } = splitQuery(query);
   const subAltering = "alter" in query && query.alter && !("to" in query.alter);
   const action = subAltering && query.alter ? Object.keys(query.alter).filter((key) => key !== "model")[0] : queryType;
@@ -1777,9 +1743,7 @@ var transformMetaQuery = (models, dependencyStatements, statementParams, query,
               }
             }
           };
-          transformMetaQuery(models, dependencyStatements, null, query2, {
-            inlineDefaults: options.inlineDefaults
-          });
+          transformMetaQuery(models, dependencyStatements, null, query2);
         }
       }
       const modelWithObjects = Object.assign({}, modelWithPresets);
@@ -1789,13 +1753,7 @@ var transformMetaQuery = (models, dependencyStatements, statementParams, query,
       }
       queryTypeDetails = { with: modelWithObjects };
       getSystemModels(models, modelWithPresets).map((systemModel) => {
-        return handleSystemModel(
-          models,
-          dependencyStatements,
-          "create",
-          options.inlineDefaults,
-          systemModel
-        );
+        return handleSystemModel(models, dependencyStatements, "create", systemModel);
       });
     }
     if (action === "alter" && model) {
@@ -1818,26 +1776,14 @@ var transformMetaQuery = (models, dependencyStatements, statementParams, query,
         },
         to: modelWithPresets
       };
-      handleSystemModels(
-        models,
-        dependencyStatements,
-        modelBeforeUpdate2,
-        model,
-        options.inlineDefaults
-      );
+      handleSystemModels(models, dependencyStatements, modelBeforeUpdate2, model);
     }
     if (action === "drop" && model) {
       models.splice(models.indexOf(model), 1);
       dependencyStatements.push({ statement: `DROP TABLE "${model.table}"`, params: [] });
       queryTypeDetails = { with: { slug } };
       models.filter(({ system }) => system?.model === model.id).map((systemModel) => {
-        return handleSystemModel(
-          models,
-          dependencyStatements,
-          "drop",
-          options.inlineDefaults,
-          systemModel
-        );
+        return handleSystemModel(models, dependencyStatements, "drop", systemModel);
       });
     }
     const modelSlug2 = "to" in queryTypeDetails ? queryTypeDetails?.to?.slug : "with" in queryTypeDetails ? queryTypeDetails?.with?.slug : void 0;
@@ -1985,8 +1931,7 @@ var transformMetaQuery = (models, dependencyStatements, statementParams, query,
       const effectStatements = trigger.effects.map((effectQuery) => {
         return compileQueryInput(effectQuery, models, null, {
           returning: false,
-          parentModel: existingModel,
-          inlineDefaults: options.inlineDefaults
+          parentModel: existingModel
         }).main.statement;
       });
       statementParts.push("BEGIN");
@@ -2021,13 +1966,7 @@ var transformMetaQuery = (models, dependencyStatements, statementParams, query,
       targetEntity.splice(targetEntityIndex, 1);
     }
   }
-  handleSystemModels(
-    models,
-    dependencyStatements,
-    modelBeforeUpdate,
-    existingModel,
-    options.inlineDefaults
-  );
+  handleSystemModels(models, dependencyStatements, modelBeforeUpdate, existingModel);
   return {
     set: {
       model: {
@@ -2090,9 +2029,7 @@ var Transaction = class {
       const { dependencies, main, selectedFields } = compileQueryInput(
         query,
         modelsWithPresets,
-        options?.inlineParams ? null : [],
-        // biome-ignore lint/complexity/useSimplifiedLogicExpression: This is needed.
-        { inlineDefaults: options?.inlineDefaults || false }
+        options?.inlineParams ? null : []
       );
       const preDependencies = dependencies.filter(({ after }) => !after);
       const postDependencies = dependencies.map(({ after, ...rest }) => after ? rest : null).filter((item) => item != null);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@ronin/compiler",
-  "version": "0.16.4-leo-ron-1099-1-experimental-372",
+  "version": "0.16.4",
   "type": "module",
   "description": "Compiles RONIN queries to SQL statements.",
   "publishConfig": {