@player-ui/async-node-plugin 0.8.0-next.0 → 0.8.0-next.10

package/src/index.test.ts

@@ -1,453 +1,569 @@
-import { expect, test } from "vitest";
+import { expect, test, describe } from "vitest";
 import { Node, InProgressState, ViewInstance } from "@player-ui/player";
-import { Player } from "@player-ui/player";
+import { Player, Parser } from "@player-ui/player";
 import { waitFor } from "@testing-library/react";
 import { AsyncNodePlugin, AsyncNodePluginPlugin } from "./index";
 
-const basicFRFWithActions = {
-  id: "test-flow",
-  views: [
-    {
-      id: "my-view",
-      actions: [
-        {
-          asset: {
-            id: "action-0",
-            type: "action",
-            value: "{{foo.bar}}",
+describe("view", () => {
+  const basicFRFWithActions = {
+    id: "test-flow",
+    views: [
+      {
+        id: "my-view",
+        actions: [
+          {
+            asset: {
+              id: "action-0",
+              type: "action",
+              value: "{{foo.bar}}",
+            },
           },
+          {
+            id: "nodeId",
+            async: "true",
+          },
+        ],
+      },
+    ],
+    navigation: {
+      BEGIN: "FLOW_1",
+      FLOW_1: {
+        startState: "VIEW_1",
+        VIEW_1: {
+          state_type: "VIEW",
+          ref: "my-view",
+          transitions: {},
         },
-        {
-          id: "nodeId",
-          async: "true",
-        },
-      ],
-    },
-  ],
-  navigation: {
-    BEGIN: "FLOW_1",
-    FLOW_1: {
-      startState: "VIEW_1",
-      VIEW_1: {
-        state_type: "VIEW",
-        ref: "my-view",
-        transitions: {},
       },
     },
-  },
-};
+  };
 
-const asyncNodeTest = async (resolvedValue: any) => {
-  const plugin = new AsyncNodePlugin({
-    plugins: [new AsyncNodePluginPlugin()],
-  });
+  const asyncNodeTest = async (resolvedValue: any) => {
+    const plugin = new AsyncNodePlugin({
+      plugins: [new AsyncNodePluginPlugin()],
+    });
 
-  let deferredResolve: ((value: any) => void) | undefined;
+    let deferredResolve: ((value: any) => void) | undefined;
 
-  plugin.hooks.onAsyncNode.tap("test", async (node: Node.Async) => {
-    return new Promise((resolve) => {
-      deferredResolve = resolve; // Promise would be resolved only once
-    });
-  });
+    let updateContent: any;
 
-  let updateNumber = 0;
+    plugin.hooks.onAsyncNode.tap(
+      "test",
+      async (node: Node.Async, update: (content: any) => void) => {
+        const result = new Promise((resolve) => {
+          deferredResolve = resolve; // Promise would be resolved only once
+        });
 
-  const player = new Player({ plugins: [plugin] });
+        updateContent = update;
+        // Return the result to follow the same mechanism as before
+        return result;
+      },
+    );
+
+    let updateNumber = 0;
+
+    const player = new Player({ plugins: [plugin] });
 
-  let viewInstance: ViewInstance | undefined;
+    let viewInstance: ViewInstance | undefined;
 
-  player.hooks.viewController.tap("async-node-test", (vc) => {
-    vc.hooks.view.tap("async-node-test", (view) => {
-      viewInstance = view;
-      view.hooks.onUpdate.tap("async-node-test", () => {
-        updateNumber++;
+    player.hooks.viewController.tap("async-node-test", (vc) => {
+      vc.hooks.view.tap("async-node-test", (view) => {
+        viewInstance = view;
+        view.hooks.onUpdate.tap("async-node-test", () => {
+          updateNumber++;
+        });
       });
     });
-  });
 
-  player.start(basicFRFWithActions as any);
+    player.start(basicFRFWithActions as any);
 
-  let view = (player.getState() as InProgressState).controllers.view.currentView
-    ?.lastUpdate;
+    let view = (player.getState() as InProgressState).controllers.view
+      .currentView?.lastUpdate;
 
-  expect(view).toBeDefined();
-  expect(view?.actions[0].asset.type).toBe("action");
-  expect(view?.actions[1]).toBeUndefined();
+    expect(view).toBeDefined();
+    expect(view?.actions[0].asset.type).toBe("action");
+    expect(view?.actions[1]).toBeUndefined();
 
-  await waitFor(() => {
-    expect(deferredResolve).toBeDefined();
-  });
+    await waitFor(() => {
+      expect(deferredResolve).toBeDefined();
+    });
 
-  // Consumer responds with null/undefined
-  if (deferredResolve) {
-    deferredResolve(resolvedValue);
-  }
+    // Consumer responds with null/undefined
+    if (deferredResolve) {
+      deferredResolve(resolvedValue);
+    }
 
-  await waitFor(() => {
-    expect(updateNumber).toBe(2);
-  });
+    await waitFor(() => {
+      expect(updateNumber).toBe(1);
+    });
+
+    view = (player.getState() as InProgressState).controllers.view.currentView
+      ?.lastUpdate;
+
+    expect(view?.actions[0].asset.type).toBe("action");
+    expect(view?.actions.length).toBe(1);
 
-  view = (player.getState() as InProgressState).controllers.view.currentView
-    ?.lastUpdate;
+    // Consumer responds with null/undefined
+    if (deferredResolve) {
+      updateContent(resolvedValue);
+    }
+
+    //Even after an update, the view should not change as we are deleting the resolved node if there is no view update
+    await waitFor(() => {
+      expect(updateNumber).toBe(1);
+    });
 
-  expect(view?.actions[0].asset.type).toBe("action");
-  expect(view?.actions.length).toBe(1);
+    view = (player.getState() as InProgressState).controllers.view.currentView
+      ?.lastUpdate;
 
-  viewInstance?.update();
+    expect(view?.actions[0].asset.type).toBe("action");
+    expect(view?.actions.length).toBe(1);
+  };
 
-  await waitFor(() => {
-    expect(updateNumber).toBe(3);
+  test("should return current node view when the resolved node is null", async () => {
+    await asyncNodeTest(null);
   });
 
-  view = (player.getState() as InProgressState).controllers.view.currentView
-    ?.lastUpdate;
+  test("should return current node view when the resolved node is undefined", async () => {
+    await asyncNodeTest(undefined);
+  });
 
-  expect(view?.actions[0].asset.type).toBe("action");
-  expect(view?.actions.length).toBe(1);
-};
+  test("can handle multiple updates through callback mechanism", async () => {
+    const plugin = new AsyncNodePlugin({
+      plugins: [new AsyncNodePluginPlugin()],
+    });
 
-test("should return current node view when the resolved node is null", async () => {
-  await asyncNodeTest(null);
-});
+    let deferredResolve: ((value: any) => void) | undefined;
 
-test("should return current node view when the resolved node is undefined", async () => {
-  await asyncNodeTest(undefined);
-});
+    let updateContent: any;
 
-test("replaces async nodes with provided node", async () => {
-  const plugin = new AsyncNodePlugin({
-    plugins: [new AsyncNodePluginPlugin()],
-  });
+    plugin.hooks.onAsyncNode.tap(
+      "test",
+      async (node: Node.Async, update: (content: any) => void) => {
+        const result = new Promise((resolve) => {
+          deferredResolve = resolve; // Promise would be resolved only once
+        });
 
-  let deferredResolve: ((value: any) => void) | undefined;
+        updateContent = update;
+        // Return the result to follow the same mechanism as before
+        return result;
+      },
+    );
 
-  plugin.hooks.onAsyncNode.tap("test", async (node: Node.Async) => {
-    return new Promise((resolve) => {
-      deferredResolve = resolve;
-    });
-  });
-  let updateNumber = 0;
+    let updateNumber = 0;
 
-  const player = new Player({ plugins: [plugin] });
+    const player = new Player({ plugins: [plugin] });
 
-  player.hooks.viewController.tap("async-node-test", (vc) => {
-    vc.hooks.view.tap("async-node-test", (view) => {
-      view.hooks.onUpdate.tap("async-node-test", (update) => {
-        updateNumber++;
+    player.hooks.viewController.tap("async-node-test", (vc) => {
+      vc.hooks.view.tap("async-node-test", (view) => {
+        view.hooks.onUpdate.tap("async-node-test", (update) => {
+          updateNumber++;
+        });
       });
     });
-  });
 
-  player.start(basicFRFWithActions as any);
+    player.start(basicFRFWithActions as any);
 
-  let view = (player.getState() as InProgressState).controllers.view.currentView
-    ?.lastUpdate;
+    let view = (player.getState() as InProgressState).controllers.view
+      .currentView?.lastUpdate;
 
-  expect(view).toBeDefined();
-  expect(view?.actions[0].asset.type).toBe("action");
-  expect(view?.actions[1]).toBeUndefined();
-  expect(updateNumber).toBe(1);
+    expect(view).toBeDefined();
+    expect(view?.actions[1]).toBeUndefined();
 
-  await waitFor(() => {
-    expect(deferredResolve).toBeDefined();
-  });
+    await waitFor(() => {
+      expect(updateNumber).toBe(1);
+      expect(deferredResolve).toBeDefined();
+    });
 
-  if (deferredResolve) {
-    deferredResolve({
-      asset: {
-        id: "next-label-action",
-        type: "action",
-        value: "dummy value",
-      },
+    if (deferredResolve) {
+      deferredResolve({
+        asset: {
+          id: "next-label-action",
+          type: "action",
+          value: "dummy value",
+        },
+      });
+    }
+
+    await waitFor(() => {
+      expect(updateNumber).toBe(2);
     });
-  }
 
-  await waitFor(() => {
+    view = (player.getState() as InProgressState).controllers.view.currentView
+      ?.lastUpdate;
+
+    expect(view?.actions[0].asset.type).toBe("action");
+    expect(view?.actions[1].asset.type).toBe("action");
     expect(updateNumber).toBe(2);
-  });
 
-  view = (player.getState() as InProgressState).controllers.view.currentView
-    ?.lastUpdate;
+    if (deferredResolve) {
+      updateContent(null);
+    }
 
-  expect(view?.actions[0].asset.type).toBe("action");
-  expect(view?.actions[1].asset.type).toBe("action");
-});
+    await waitFor(() => {
+      expect(updateNumber).toBe(3);
+    });
 
-test("replaces async nodes with multi node", async () => {
-  const plugin = new AsyncNodePlugin({
-    plugins: [new AsyncNodePluginPlugin()],
-  });
+    view = (player.getState() as InProgressState).controllers.view.currentView
+      ?.lastUpdate;
 
-  let deferredResolve: ((value: any) => void) | undefined;
+    expect(view?.actions[0].asset.type).toBe("action");
+    expect(view?.actions[1]).toBeUndefined();
+  });
 
-  plugin.hooks.onAsyncNode.tap("test", async (node) => {
-    return new Promise((resolve) => {
-      deferredResolve = resolve;
+  test("replaces async nodes with provided node", async () => {
+    const plugin = new AsyncNodePlugin({
+      plugins: [new AsyncNodePluginPlugin()],
     });
-  });
 
-  let updateNumber = 0;
+    let deferredResolve: ((value: any) => void) | undefined;
+
+    plugin.hooks.onAsyncNode.tap("test", async (node: Node.Async) => {
+      return new Promise((resolve) => {
+        deferredResolve = resolve;
+      });
+    });
+    let updateNumber = 0;
 
-  const player = new Player({ plugins: [plugin] });
+    const player = new Player({ plugins: [plugin] });
 
-  player.hooks.viewController.tap("async-node-test", (vc) => {
-    vc.hooks.view.tap("async-node-test", (view) => {
-      view.hooks.onUpdate.tap("async-node-test", (update) => {
-        updateNumber++;
+    player.hooks.viewController.tap("async-node-test", (vc) => {
+      vc.hooks.view.tap("async-node-test", (view) => {
+        view.hooks.onUpdate.tap("async-node-test", (update) => {
+          updateNumber++;
+        });
       });
     });
-  });
 
-  player.start(basicFRFWithActions as any);
+    player.start(basicFRFWithActions as any);
 
-  let view = (player.getState() as InProgressState).controllers.view.currentView
-    ?.lastUpdate;
+    let view = (player.getState() as InProgressState).controllers.view
+      .currentView?.lastUpdate;
 
-  expect(view).toBeDefined();
-  expect(view?.actions[1]).toBeUndefined();
-  expect(updateNumber).toBe(1);
+    expect(view).toBeDefined();
+    expect(view?.actions[0].asset.type).toBe("action");
+    expect(view?.actions[1]).toBeUndefined();
+    expect(updateNumber).toBe(1);
 
-  await waitFor(() => {
-    expect(deferredResolve).toBeDefined();
-  });
+    await waitFor(() => {
+      expect(deferredResolve).toBeDefined();
+    });
 
-  if (deferredResolve) {
-    deferredResolve([
-      {
+    if (deferredResolve) {
+      deferredResolve({
         asset: {
-          id: "value-1",
-          type: "text",
-          value: "1st value in the multinode",
-        },
-      },
-      {
-        asset: {
-          id: "value-2",
-          type: "text",
-          value: "2nd value in the multinode",
+          id: "next-label-action",
+          type: "action",
+          value: "dummy value",
         },
-      },
-    ]);
-  }
-
-  await waitFor(() => {
-    expect(updateNumber).toBe(2);
-  });
+      });
+    }
 
-  view = (player.getState() as InProgressState).controllers.view.currentView
-    ?.lastUpdate;
+    await waitFor(() => {
+      expect(updateNumber).toBe(2);
+    });
 
-  expect(view?.actions[0].asset.type).toBe("action");
-  expect(view?.actions[1].asset.type).toBe("text");
-  expect(view?.actions[2].asset.type).toBe("text");
-});
+    view = (player.getState() as InProgressState).controllers.view.currentView
+      ?.lastUpdate;
 
-test("replaces async nodes with chained multiNodes", async () => {
-  const plugin = new AsyncNodePlugin({
-    plugins: [new AsyncNodePluginPlugin()],
+    expect(view?.actions[0].asset.type).toBe("action");
+    expect(view?.actions[1].asset.type).toBe("action");
   });
 
-  let deferredResolve: ((value: any) => void) | undefined;
-
-  plugin.hooks.onAsyncNode.tap("test", async (node: Node.Async) => {
-    return new Promise((resolve) => {
-      deferredResolve = resolve;
+  test("replaces async nodes with multi node", async () => {
+    const plugin = new AsyncNodePlugin({
+      plugins: [new AsyncNodePluginPlugin()],
     });
-  });
-  let updateNumber = 0;
 
-  const player = new Player({ plugins: [plugin] });
+    let deferredResolve: ((value: any) => void) | undefined;
 
-  player.hooks.viewController.tap("async-node-test", (vc) => {
-    vc.hooks.view.tap("async-node-test", (view) => {
-      view.hooks.onUpdate.tap("async-node-test", (update) => {
-        updateNumber++;
+    plugin.hooks.onAsyncNode.tap("test", async (node) => {
+      return new Promise((resolve) => {
+        deferredResolve = resolve;
       });
     });
-  });
 
-  player.start(basicFRFWithActions as any);
+    let updateNumber = 0;
+
+    const player = new Player({ plugins: [plugin] });
+
+    player.hooks.viewController.tap("async-node-test", (vc) => {
+      vc.hooks.view.tap("async-node-test", (view) => {
+        view.hooks.onUpdate.tap("async-node-test", (update) => {
+          updateNumber++;
+        });
+      });
+    });
 
-  let view = (player.getState() as InProgressState).controllers.view.currentView
-    ?.lastUpdate;
+    player.start(basicFRFWithActions as any);
 
-  expect(view).toBeDefined();
-  expect(view?.actions[1]).toBeUndefined();
+    let view = (player.getState() as InProgressState).controllers.view
+      .currentView?.lastUpdate;
 
-  await waitFor(() => {
+    expect(view).toBeDefined();
+    expect(view?.actions[1]).toBeUndefined();
     expect(updateNumber).toBe(1);
-    expect(deferredResolve).toBeDefined();
-  });
 
-  if (deferredResolve) {
-    deferredResolve([
-      {
-        asset: {
-          id: "value-1",
-          type: "text",
-          value: "1st value in the multinode",
+    await waitFor(() => {
+      expect(deferredResolve).toBeDefined();
+    });
+
+    if (deferredResolve) {
+      deferredResolve([
+        {
+          asset: {
+            id: "value-1",
+            type: "text",
+            value: "1st value in the multinode",
+          },
         },
-      },
-      {
-        id: "another-async",
-        async: true,
-      },
-    ]);
-  }
+        {
+          asset: {
+            id: "value-2",
+            type: "text",
+            value: "2nd value in the multinode",
+          },
+        },
+      ]);
+    }
 
-  await waitFor(() => {
-    expect(updateNumber).toBe(2);
+    await waitFor(() => {
+      expect(updateNumber).toBe(2);
+    });
+
+    view = (player.getState() as InProgressState).controllers.view.currentView
+      ?.lastUpdate;
+
+    expect(view?.actions[0].asset.type).toBe("action");
+    expect(view?.actions[1].asset.type).toBe("text");
+    expect(view?.actions[2].asset.type).toBe("text");
   });
 
-  view = (player.getState() as InProgressState).controllers.view.currentView
-    ?.lastUpdate;
+  test("replaces async nodes with chained multiNodes", async () => {
+    const plugin = new AsyncNodePlugin({
+      plugins: [new AsyncNodePluginPlugin()],
+    });
 
-  expect(view?.actions[0].asset.type).toBe("action");
-  expect(view?.actions[1].asset.type).toBe("text");
-  expect(view?.actions[2]).toBeUndefined();
-  expect(updateNumber).toBe(2);
+    let deferredResolve: ((value: any) => void) | undefined;
 
-  if (deferredResolve) {
-    deferredResolve([
-      {
-        asset: {
-          id: "value-2",
-          type: "text",
-          value: "2nd value in the multinode",
+    plugin.hooks.onAsyncNode.tap("test", async (node: Node.Async) => {
+      return new Promise((resolve) => {
+        deferredResolve = resolve;
+      });
+    });
+    let updateNumber = 0;
+
+    const player = new Player({ plugins: [plugin] });
+
+    player.hooks.viewController.tap("async-node-test", (vc) => {
+      vc.hooks.view.tap("async-node-test", (view) => {
+        view.hooks.onUpdate.tap("async-node-test", (update) => {
+          updateNumber++;
+        });
+      });
+    });
+
+    player.start(basicFRFWithActions as any);
+
+    let view = (player.getState() as InProgressState).controllers.view
+      .currentView?.lastUpdate;
+
+    expect(view).toBeDefined();
+    expect(view?.actions[1]).toBeUndefined();
+
+    await waitFor(() => {
+      expect(updateNumber).toBe(1);
+      expect(deferredResolve).toBeDefined();
+    });
+
+    if (deferredResolve) {
+      deferredResolve([
+        {
+          asset: {
+            id: "value-1",
+            type: "text",
+            value: "1st value in the multinode",
+          },
         },
-      },
-      {
-        asset: {
-          id: "value-3",
-          type: "text",
-          value: "3rd value in the multinode",
+        {
+          id: "another-async",
+          async: true,
         },
-      },
-    ]);
-  }
+      ]);
+    }
 
-  await waitFor(() => {
-    expect(updateNumber).toBe(3);
-  });
+    await waitFor(() => {
+      expect(updateNumber).toBe(2);
+    });
 
-  view = (player.getState() as InProgressState).controllers.view.currentView
-    ?.lastUpdate;
+    view = (player.getState() as InProgressState).controllers.view.currentView
+      ?.lastUpdate;
 
-  expect(view?.actions[0].asset.type).toBe("action");
-  expect(view?.actions[1].asset.type).toBe("text");
-  expect(view?.actions[2].asset.type).toBe("text");
-  expect(view?.actions[3].asset.type).toBe("text");
-});
+    expect(view?.actions[0].asset.type).toBe("action");
+    expect(view?.actions[1].asset.type).toBe("text");
+    expect(view?.actions[2]).toBeUndefined();
+    expect(updateNumber).toBe(2);
+
+    if (deferredResolve) {
+      deferredResolve([
+        {
+          asset: {
+            id: "value-2",
+            type: "text",
+            value: "2nd value in the multinode",
+          },
+        },
+        {
+          asset: {
+            id: "value-3",
+            type: "text",
+            value: "3rd value in the multinode",
+          },
+        },
+      ]);
+    }
+
+    await waitFor(() => {
+      expect(updateNumber).toBe(3);
+    });
+
+    view = (player.getState() as InProgressState).controllers.view.currentView
+      ?.lastUpdate;
 
-test("replaces async nodes with chained multiNodes singular", async () => {
-  const plugin = new AsyncNodePlugin({
-    plugins: [new AsyncNodePluginPlugin()],
+    expect(view?.actions[0].asset.type).toBe("action");
+    expect(view?.actions[1].asset.type).toBe("text");
+    expect(view?.actions[2].asset.type).toBe("text");
+    expect(view?.actions[3].asset.type).toBe("text");
   });
 
-  let deferredResolve: ((value: any) => void) | undefined;
+  test("replaces async nodes with chained multiNodes singular", async () => {
+    const plugin = new AsyncNodePlugin({
+      plugins: [new AsyncNodePluginPlugin()],
+    });
+
+    let deferredResolve: ((value: any) => void) | undefined;
 
-  plugin.hooks.onAsyncNode.tap("test", async (node: Node.Async) => {
-    return new Promise((resolve) => {
-      deferredResolve = resolve;
+    plugin.hooks.onAsyncNode.tap("test", async (node: Node.Async) => {
+      return new Promise((resolve) => {
+        deferredResolve = resolve;
+      });
     });
-  });
-  let updateNumber = 0;
+    let updateNumber = 0;
 
-  const player = new Player({ plugins: [plugin] });
+    const player = new Player({ plugins: [plugin] });
 
-  player.hooks.viewController.tap("async-node-test", (vc) => {
-    vc.hooks.view.tap("async-node-test", (view) => {
-      view.hooks.onUpdate.tap("async-node-test", (update) => {
-        updateNumber++;
+    player.hooks.viewController.tap("async-node-test", (vc) => {
+      vc.hooks.view.tap("async-node-test", (view) => {
+        view.hooks.onUpdate.tap("async-node-test", (update) => {
+          updateNumber++;
+        });
       });
     });
-  });
 
-  player.start(basicFRFWithActions as any);
+    player.start(basicFRFWithActions as any);
 
-  let view = (player.getState() as InProgressState).controllers.view.currentView
-    ?.lastUpdate;
+    let view = (player.getState() as InProgressState).controllers.view
+      .currentView?.lastUpdate;
 
-  expect(view).toBeDefined();
-  expect(view?.actions[1]).toBeUndefined();
+    expect(view).toBeDefined();
+    expect(view?.actions[1]).toBeUndefined();
 
-  await waitFor(() => {
-    expect(updateNumber).toBe(1);
-    expect(deferredResolve).toBeDefined();
-  });
+    await waitFor(() => {
+      expect(updateNumber).toBe(1);
+      expect(deferredResolve).toBeDefined();
+    });
 
-  if (deferredResolve) {
-    deferredResolve([
-      {
-        asset: {
-          id: "value-1",
-          type: "text",
-          value: "1st value in the multinode",
+    if (deferredResolve) {
+      deferredResolve([
+        {
+          asset: {
+            id: "value-1",
+            type: "text",
+            value: "1st value in the multinode",
+          },
         },
-      },
-      {
-        id: "another-async",
-        async: true,
-      },
-    ]);
-  }
+        {
+          id: "another-async",
+          async: true,
+        },
+      ]);
+    }
 
-  await waitFor(() => {
-    expect(updateNumber).toBe(2);
-  });
+    await waitFor(() => {
+      expect(updateNumber).toBe(2);
+    });
 
-  view = (player.getState() as InProgressState).controllers.view.currentView
-    ?.lastUpdate;
+    view = (player.getState() as InProgressState).controllers.view.currentView
+      ?.lastUpdate;
 
-  expect(view?.actions[0].asset.type).toBe("action");
-  expect(view?.actions[1].asset.type).toBe("text");
-  expect(view?.actions[2]).toBeUndefined();
+    expect(view?.actions[0].asset.type).toBe("action");
+    expect(view?.actions[1].asset.type).toBe("text");
+    expect(view?.actions[2]).toBeUndefined();
 
-  if (deferredResolve) {
-    deferredResolve({
-      asset: {
-        id: "value-2",
-        type: "text",
-        value: "2nd value in the multinode",
-      },
+    if (deferredResolve) {
+      deferredResolve({
+        asset: {
+          id: "value-2",
+          type: "text",
+          value: "2nd value in the multinode",
+        },
+      });
+    }
+
+    await waitFor(() => {
+      expect(updateNumber).toBe(3);
     });
-  }
 
-  await waitFor(() => {
-    expect(updateNumber).toBe(3);
+    view = (player.getState() as InProgressState).controllers.view.currentView
+      ?.lastUpdate;
+
+    expect(view?.actions[0].asset.type).toBe("action");
+    expect(view?.actions[1].asset.type).toBe("text");
+    expect(view?.actions[2].asset.type).toBe("text");
   });
 
-  view = (player.getState() as InProgressState).controllers.view.currentView
-    ?.lastUpdate;
+  test("should call onAsyncNode hook when async node is encountered", async () => {
+    const plugin = new AsyncNodePlugin({
+      plugins: [new AsyncNodePluginPlugin()],
+    });
 
-  expect(view?.actions[0].asset.type).toBe("action");
-  expect(view?.actions[1].asset.type).toBe("text");
-  expect(view?.actions[2].asset.type).toBe("text");
-});
+    let localNode: Node.Async;
+    plugin.hooks.onAsyncNode.tap("test", async (node: Node.Async) => {
+      if (node !== null) {
+        // assigns node value to a local variable
+        localNode = node;
+      }
 
-test("should call onAsyncNode hook when async node is encountered", async () => {
-  const plugin = new AsyncNodePlugin({
-    plugins: [new AsyncNodePluginPlugin()],
-  });
+      return new Promise((resolve) => {
+        resolve("Promise resolved");
+      });
+    });
 
-  let localNode: Node.Async;
-  plugin.hooks.onAsyncNode.tap("test", async (node: Node.Async) => {
-    if (node !== null) {
-      // assigns node value to a local variable
-      localNode = node;
-    }
+    const player = new Player({ plugins: [plugin] });
+
+    player.start(basicFRFWithActions as any);
 
-    return new Promise((resolve) => {
-      resolve("Promise resolved");
+    await waitFor(() => {
+      expect(localNode.id).toStrictEqual("nodeId");
+      expect(localNode.type).toStrictEqual("async");
     });
   });
+});
+
+describe("parser", () => {
+  test("missing node-id parent async node", async () => {
+    const parser = new Parser();
+    new AsyncNodePluginPlugin().applyParser(parser);
+    const parsedAST = parser.parseObject({ async: "true" });
 
-  const player = new Player({ plugins: [plugin] });
+    expect(parsedAST).toStrictEqual(null);
+  });
 
-  player.start(basicFRFWithActions as any);
+  test("missing node-id child async node", async () => {
+    const parser = new Parser();
+    new AsyncNodePluginPlugin().applyParser(parser);
+    const parsedAST = parser.parseObject({ fields: { async: "true" } });
 
-  await waitFor(() => {
-    expect(localNode.id).toStrictEqual("nodeId");
-    expect(localNode.type).toStrictEqual("async");
+    expect(parsedAST).toStrictEqual(null);
   });
 });