@player-tools/json-language-service 0.9.0 → 0.9.1--canary.189.4062

package/dist/cjs/index.cjs

@@ -1040,7 +1040,7 @@ function createValidationVisitor(ctx, sdk) {
           ctx.addViolation({
             node: findErrorNode(assetNode, issue.node),
             message: `Asset Validation Error - ${issue.type}: ${issue.message}`,
-            severity: import_vscode_languageserver_types6.DiagnosticSeverity.Error
+            severity: issue.severity ?? import_vscode_languageserver_types6.DiagnosticSeverity.Error
           });
         }
       });
@@ -1263,6 +1263,16 @@ var XLRPlugin = class {
 
 // ../../../../../../../../../../execroot/_main/bazel-out/k8-fastbuild/bin/language/json-language-service/src/plugins/duplicate-id-plugin.ts
 var import_vscode_languageserver_types7 = require("vscode-languageserver-types");
+var checkParentTemplate = (node, depth = 0) => {
+  if (node.parent) {
+    if (isPropertyNode(node.parent) && node.parent.keyNode.value === "template") {
+      depth += 1;
+      return checkParentTemplate(node.parent, depth);
+    }
+    return checkParentTemplate(node.parent, depth);
+  }
+  return depth;
+};
 var generateID = (node) => {
   if (!node || node.type === "view") {
     return "";
@@ -1313,6 +1323,25 @@ var createValidationVisitor2 = (ctx) => {
       }
       const assetIDMap = viewInfo.get(view);
       const idInfo = assetIDMap?.get(id);
+      const templateDepth = checkParentTemplate(assetNode);
+      if (templateDepth > 0) {
+        const expectedIndexElements = [];
+        for (let i = 0; i < templateDepth; i++) {
+          expectedIndexElements.push(`_index${i === 0 ? "" : i}_`);
+        }
+        const missingIndexSegments = expectedIndexElements.filter(
+          (e) => !id.includes(e)
+        );
+        if (missingIndexSegments.length !== 0) {
+          ctx.addViolation({
+            node: assetNode,
+            severity: import_vscode_languageserver_types7.DiagnosticSeverity.Error,
+            message: `The id for this templated elements is missing the following index segments: ${missingIndexSegments.join(
+              ", "
+            )}`
+          });
+        }
+      }
       if (idInfo) {
         if (!idInfo.handled) {
           const origViolation = createViolation(idInfo.original);
@@ -1659,43 +1688,47 @@ var applyAssetWrapperOrSwitch = (node, capability) => {
   })(node, capability);
 };
 var applyValueRefs = (node, capability) => {
-  return (0, import_xlr_sdk.simpleTransformGenerator)("object", "Assets", (inputNode) => {
-    const xlrNode = { ...inputNode };
-    for (const key in xlrNode.properties) {
-      if (key === "id" || key === "type") {
-        continue;
-      }
-      const value = xlrNode.properties[key];
-      if (value.node.type === "or") {
-        value.node.or.push({
-          type: "ref",
-          ref: "ExpressionRef"
-        });
-        value.node.or.push({
-          type: "ref",
-          ref: "BindingRef"
-        });
-      } else if ((0, import_xlr_utils.isPrimitiveTypeNode)(value.node)) {
-        const newUnionType = {
-          type: "or",
-          description: value.node.description,
-          or: [
-            value.node,
-            {
-              type: "ref",
-              ref: "ExpressionRef"
-            },
-            {
-              type: "ref",
-              ref: "BindingRef"
-            }
-          ]
-        };
-        value.node = newUnionType;
+  return (0, import_xlr_sdk.simpleTransformGenerator)(
+    "object",
+    ["Assets", "Views"],
+    (inputNode) => {
+      const xlrNode = { ...inputNode };
+      for (const key in xlrNode.properties) {
+        if (key === "id") {
+          continue;
+        }
+        const value = xlrNode.properties[key];
+        if (value.node.type === "or") {
+          value.node.or.push({
+            type: "ref",
+            ref: "ExpressionRef"
+          });
+          value.node.or.push({
+            type: "ref",
+            ref: "BindingRef"
+          });
+        } else if ((0, import_xlr_utils.isPrimitiveTypeNode)(value.node)) {
+          const newUnionType = {
+            type: "or",
+            description: value.node.description,
+            or: [
+              value.node,
+              {
+                type: "ref",
+                ref: "ExpressionRef"
+              },
+              {
+                type: "ref",
+                ref: "BindingRef"
+              }
+            ]
+          };
+          value.node = newUnionType;
+        }
       }
+      return xlrNode;
     }
-    return xlrNode;
-  })(node, capability);
+  )(node, capability);
 };
 var applyTemplateProperty = (node, capability) => {
   return (0, import_xlr_sdk.simpleTransformGenerator)(