@pagopa/dx-savemoney 0.3.0 → 0.3.1

package/dist/azure/__tests__/utils.test.js

@@ -0,0 +1,181 @@
+/**
+ * Tests for matchesTags() — verifies AND-logic tag filtering:
+ * 1. No filter (undefined/empty) → always include the resource.
+ * 2. Exact key-value match → include.
+ * 3. Key missing on resource → exclude.
+ * 4. Key present but wrong value → exclude.
+ * 5. Multiple tags: all match → include; any mismatch → exclude.
+ *
+ * Tests for getMetric() cache behaviour:
+ * 6. resetMetricsCache() clears state between runs.
+ * 7. Concurrent calls for the same key coalesce into one network call.
+ * 8. A failed call is cached as a fulfilled null result (not retried silently).
+ */
+import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
+import { _metricsCacheSize, getMetric, matchesTags, resetMetricsCache, } from "../utils.js";
+function makeResource(tags) {
+    return { id: "r1", name: "res", tags };
+}
+describe("matchesTags", () => {
+    describe("when no filter is provided", () => {
+        it("returns true for undefined filterTags", () => {
+            expect(matchesTags(makeResource({ env: "prod" }), undefined)).toBe(true);
+        });
+        it("returns true for empty Map", () => {
+            expect(matchesTags(makeResource({ env: "prod" }), new Map())).toBe(true);
+        });
+        it("returns true even when resource has no tags", () => {
+            expect(matchesTags(makeResource(), undefined)).toBe(true);
+        });
+    });
+    describe("single tag filter", () => {
+        it("returns true when tag key and value match exactly", () => {
+            expect(matchesTags(makeResource({ env: "prod" }), new Map([["env", "prod"]]))).toBe(true);
+        });
+        it("returns false when tag key is missing from resource", () => {
+            expect(matchesTags(makeResource({ app: "myapp" }), new Map([["env", "prod"]]))).toBe(false);
+        });
+        it("returns false when tag key exists but value differs", () => {
+            expect(matchesTags(makeResource({ env: "dev" }), new Map([["env", "prod"]]))).toBe(false);
+        });
+        it("returns false when resource has no tags at all", () => {
+            expect(matchesTags(makeResource(), new Map([["env", "prod"]]))).toBe(false);
+        });
+        it("is case-sensitive for tag values", () => {
+            expect(matchesTags(makeResource({ env: "Prod" }), new Map([["env", "prod"]]))).toBe(false);
+        });
+    });
+    describe("multiple tag filters (AND logic)", () => {
+        it("returns true when all filter tags match", () => {
+            const resource = makeResource({
+                env: "prod",
+                region: "italy",
+                team: "dx",
+            });
+            expect(matchesTags(resource, new Map([
+                ["env", "prod"],
+                ["team", "dx"],
+            ]))).toBe(true);
+        });
+        it("returns false when one of the filter tags is missing", () => {
+            const resource = makeResource({ env: "prod" });
+            expect(matchesTags(resource, new Map([
+                ["env", "prod"],
+                ["team", "dx"],
+            ]))).toBe(false);
+        });
+        it("returns false when one of the filter tags has the wrong value", () => {
+            const resource = makeResource({ env: "prod", team: "backend" });
+            expect(matchesTags(resource, new Map([
+                ["env", "prod"],
+                ["team", "dx"],
+            ]))).toBe(false);
+        });
+        it("returns false when both filter tags have wrong values", () => {
+            const resource = makeResource({ env: "dev", team: "backend" });
+            expect(matchesTags(resource, new Map([
+                ["env", "prod"],
+                ["team", "dx"],
+            ]))).toBe(false);
+        });
+    });
+});
+// ── metrics cache ──────────────────────────────────────────────────────────
+function makeFailingMonitorClient(calls = []) {
+    return {
+        metrics: {
+            list: vi.fn().mockImplementation(async () => {
+                calls.push(1);
+                throw new Error("network error");
+            }),
+        },
+    };
+}
+function makeMonitorClient(returnValue, calls = []) {
+    return {
+        metrics: {
+            list: vi.fn().mockImplementation(async () => {
+                calls.push(1);
+                if (returnValue === null) {
+                    return { value: [] };
+                }
+                return {
+                    value: [
+                        {
+                            timeseries: [{ data: [{ average: returnValue }] }],
+                        },
+                    ],
+                };
+            }),
+        },
+    };
+}
+describe("getMetric — in-memory cache", () => {
+    beforeEach(() => {
+        resetMetricsCache();
+    });
+    afterEach(() => {
+        vi.restoreAllMocks();
+    });
+    it("resetMetricsCache clears all cached entries", async () => {
+        const calls = [];
+        const client = makeMonitorClient(42, calls);
+        await getMetric(client, "/res/1", "Percentage CPU", "Average", 7);
+        expect(_metricsCacheSize()).toBe(1);
+        resetMetricsCache();
+        expect(_metricsCacheSize()).toBe(0);
+    });
+    it("does not call the API a second time for the same key", async () => {
+        const calls = [];
+        const client = makeMonitorClient(10, calls);
+        await getMetric(client, "/res/1", "Percentage CPU", "Average", 7);
+        await getMetric(client, "/res/1", "Percentage CPU", "Average", 7);
+        expect(calls.length).toBe(1);
+    });
+    it("concurrent calls for the same key coalesce into one network call", async () => {
+        const calls = [];
+        const client = makeMonitorClient(5, calls);
+        await Promise.all([
+            getMetric(client, "/res/2", "Network In Total", "Average", 30),
+            getMetric(client, "/res/2", "Network In Total", "Average", 30),
+            getMetric(client, "/res/2", "Network In Total", "Average", 30),
+        ]);
+        expect(calls.length).toBe(1);
+    });
+    it("different keys result in separate network calls", async () => {
+        const calls = [];
+        const client = makeMonitorClient(1, calls);
+        await getMetric(client, "/res/a", "Percentage CPU", "Average", 7);
+        await getMetric(client, "/res/b", "Percentage CPU", "Average", 7);
+        expect(calls.length).toBe(2);
+    });
+    it("returns null and caches the null result when no data points are available", async () => {
+        const calls = [];
+        const client = makeMonitorClient(null, calls);
+        const first = await getMetric(client, "/res/3", "Percentage CPU", "Average", 7);
+        const second = await getMetric(client, "/res/3", "Percentage CPU", "Average", 7);
+        expect(first).toBeNull();
+        expect(second).toBeNull();
+        expect(calls.length).toBe(1);
+    });
+    it("a failing call is cached and returns null on retry", async () => {
+        const calls = [];
+        const client = makeFailingMonitorClient(calls);
+        const first = await getMetric(client, "/res/4", "Percentage CPU", "Average", 7);
+        const second = await getMetric(client, "/res/4", "Percentage CPU", "Average", 7);
+        // Both calls return null (error is swallowed by getMetric)
+        expect(first).toBeNull();
+        expect(second).toBeNull();
+        // Only one actual network call despite two getMetric calls
+        expect(calls.length).toBe(1);
+    });
+    it("after resetMetricsCache the API is called again", async () => {
+        const calls = [];
+        const client = makeMonitorClient(7, calls);
+        await getMetric(client, "/res/5", "Percentage CPU", "Average", 7);
+        resetMetricsCache();
+        await getMetric(client, "/res/5", "Percentage CPU", "Average", 7);
+        expect(calls.length).toBe(2);
+    });
+});
+//# sourceMappingURL=utils.test.js.map

package/dist/azure/__tests__/utils.test.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"utils.test.js","sourceRoot":"","sources":["../../../src/azure/__tests__/utils.test.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;GAYG;AAIH,OAAO,EAAE,SAAS,EAAE,UAAU,EAAE,QAAQ,EAAE,MAAM,EAAE,EAAE,EAAE,EAAE,EAAE,MAAM,QAAQ,CAAC;AAEzE,OAAO,EACL,iBAAiB,EACjB,SAAS,EACT,WAAW,EAEX,iBAAiB,GAClB,MAAM,aAAa,CAAC;AAErB,SAAS,YAAY,CAAC,IAA6B;IACjD,OAAO,EAAE,EAAE,EAAE,IAAI,EAAE,IAAI,EAAE,KAAK,EAAE,IAAI,EAAE,CAAC;AACzC,CAAC;AAED,QAAQ,CAAC,aAAa,EAAE,GAAG,EAAE;IAC3B,QAAQ,CAAC,4BAA4B,EAAE,GAAG,EAAE;QAC1C,EAAE,CAAC,uCAAuC,EAAE,GAAG,EAAE;YAC/C,MAAM,CAAC,WAAW,CAAC,YAAY,CAAC,EAAE,GAAG,EAAE,MAAM,EAAE,CAAC,EAAE,SAAS,CAAC,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;QAC3E,CAAC,CAAC,CAAC;QAEH,EAAE,CAAC,4BAA4B,EAAE,GAAG,EAAE;YACpC,MAAM,CAAC,WAAW,CAAC,YAAY,CAAC,EAAE,GAAG,EAAE,MAAM,EAAE,CAAC,EAAE,IAAI,GAAG,EAAE,CAAC,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;QAC3E,CAAC,CAAC,CAAC;QAEH,EAAE,CAAC,6CAA6C,EAAE,GAAG,EAAE;YACrD,MAAM,CAAC,WAAW,CAAC,YAAY,EAAE,EAAE,SAAS,CAAC,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;QAC5D,CAAC,CAAC,CAAC;IACL,CAAC,CAAC,CAAC;IAEH,QAAQ,CAAC,mBAAmB,EAAE,GAAG,EAAE;QACjC,EAAE,CAAC,mDAAmD,EAAE,GAAG,EAAE;YAC3D,MAAM,CACJ,WAAW,CAAC,YAAY,CAAC,EAAE,GAAG,EAAE,MAAM,EAAE,CAAC,EAAE,IAAI,GAAG,CAAC,CAAC,CAAC,KAAK,EAAE,MAAM,CAAC,CAAC,CAAC,CAAC,CACvE,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;QACf,CAAC,CAAC,CAAC;QAEH,EAAE,CAAC,qDAAqD,EAAE,GAAG,EAAE;YAC7D,MAAM,CACJ,WAAW,CAAC,YAAY,CAAC,EAAE,GAAG,EAAE,OAAO,EAAE,CAAC,EAAE,IAAI,GAAG,CAAC,CAAC,CAAC,KAAK,EAAE,MAAM,CAAC,CAAC,CAAC,CAAC,CACxE,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC;QAChB,CAAC,CAAC,CAAC;QAEH,EAAE,CAAC,qDAAqD,EAAE,GAAG,EAAE;YAC7D,MAAM,CACJ,WAAW,CAAC,YAAY,CAAC,EAAE,GAAG,EAAE,KAAK,EAAE,CAAC,EAAE,IAAI,GAAG,CAAC,CAAC,CAAC,KAAK,EAAE,MAAM,CAAC,CAAC,CAAC,CAAC,CACtE,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC;QAChB,CAAC,CAAC,CAAC;QAEH,EAAE,CAAC,gDAAgD,EAAE,GAAG,EAAE;YACxD,MAAM,CAAC,WAAW,CAAC,YAAY,EAAE,EAAE,IAAI,GAAG,CAAC,CAAC,CAAC,KAAK,EAAE,MAAM,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,IAAI,CAClE,KAAK,CACN,CAAC;QACJ,CAAC,CAAC,CAAC;QAEH,EAAE,CAAC,kCAAkC,EAAE,GAAG,EAAE;YAC1C,MAAM,CACJ,WAAW,CAAC,YAAY,CAAC,EAAE,GAAG,EAAE,MAAM,EAAE,CAAC,EAAE,IAAI,GAAG,CAAC,CAAC,CAAC,KAAK,EAAE,MAAM,CAAC,CAAC,CAAC,CAAC,CACvE,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC;QAChB,CAAC,CAAC,CAAC;IACL,CAAC,CAAC,CAAC;IAEH,QAAQ,CAAC,kCAAkC,EAAE,GAAG,EAAE;QAChD,EAAE,CAAC,yCAAyC,EAAE,GAAG,EAAE;YACjD,MAAM,QAAQ,GAAG,YAAY,CAAC;gBAC5B,GAAG,EAAE,MAAM;gBACX,MAAM,EAAE,OAAO;gBACf,IAAI,EAAE,IAAI;aACX,CAAC,CAAC;YACH,MAAM,CACJ,WAAW,CACT,QAAQ,EACR,IAAI,GAAG,CAAC;gBACN,CAAC,KAAK,EAAE,MAAM,CAAC;gBACf,CAAC,MAAM,EAAE,IAAI,CAAC;aACf,CAAC,CACH,CACF,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;QACf,CAAC,CAAC,CAAC;QAEH,EAAE,CAAC,sDAAsD,EAAE,GAAG,EAAE;YAC9D,MAAM,QAAQ,GAAG,YAAY,CAAC,EAAE,GAAG,EAAE,MAAM,EAAE,CAAC,CAAC;YAC/C,MAAM,CACJ,WAAW,CACT,QAAQ,EACR,IAAI,GAAG,CAAC;gBACN,CAAC,KAAK,EAAE,MAAM,CAAC;gBACf,CAAC,MAAM,EAAE,IAAI,CAAC;aACf,CAAC,CACH,CACF,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC;QAChB,CAAC,CAAC,CAAC;QAEH,EAAE,CAAC,+DAA+D,EAAE,GAAG,EAAE;YACvE,MAAM,QAAQ,GAAG,YAAY,CAAC,EAAE,GAAG,EAAE,MAAM,EAAE,IAAI,EAAE,SAAS,EAAE,CAAC,CAAC;YAChE,MAAM,CACJ,WAAW,CACT,QAAQ,EACR,IAAI,GAAG,CAAC;gBACN,CAAC,KAAK,EAAE,MAAM,CAAC;gBACf,CAAC,MAAM,EAAE,IAAI,CAAC;aACf,CAAC,CACH,CACF,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC;QAChB,CAAC,CAAC,CAAC;QAEH,EAAE,CAAC,uDAAuD,EAAE,GAAG,EAAE;YAC/D,MAAM,QAAQ,GAAG,YAAY,CAAC,EAAE,GAAG,EAAE,KAAK,EAAE,IAAI,EAAE,SAAS,EAAE,CAAC,CAAC;YAC/D,MAAM,CACJ,WAAW,CACT,QAAQ,EACR,IAAI,GAAG,CAAC;gBACN,CAAC,KAAK,EAAE,MAAM,CAAC;gBACf,CAAC,MAAM,EAAE,IAAI,CAAC;aACf,CAAC,CACH,CACF,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC;QAChB,CAAC,CAAC,CAAC;IACL,CAAC,CAAC,CAAC;AACL,CAAC,CAAC,CAAC;AAEH,8EAA8E;AAE9E,SAAS,wBAAwB,CAAC,QAAkB,EAAE;IACpD,OAAO;QACL,OAAO,EAAE;YACP,IAAI,EAAE,EAAE,CAAC,EAAE,EAAE,CAAC,kBAAkB,CAAC,KAAK,IAAI,EAAE;gBAC1C,KAAK,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC;gBACd,MAAM,IAAI,KAAK,CAAC,eAAe,CAAC,CAAC;YACnC,CAAC,CAAC;SACH;KACF,CAAC;AACJ,CAAC;AAED,SAAS,iBAAiB,CACxB,WAA0B,EAC1B,QAAkB,EAAE;IAEpB,OAAO;QACL,OAAO,EAAE;YACP,IAAI,EAAE,EAAE,CAAC,EAAE,EAAE,CAAC,kBAAkB,CAAC,KAAK,IAAI,EAAE;gBAC1C,KAAK,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC;gBACd,IAAI,WAAW,KAAK,IAAI,EAAE,CAAC;oBACzB,OAAO,EAAE,KAAK,EAAE,EAAE,EAAE,CAAC;gBACvB,CAAC;gBACD,OAAO;oBACL,KAAK,EAAE;wBACL;4BACE,UAAU,EAAE,CAAC,EAAE,IAAI,EAAE,CAAC,EAAE,OAAO,EAAE,WAAW,EAAE,CAAC,EAAE,CAAC;yBACnD;qBACF;iBACF,CAAC;YACJ,CAAC,CAAC;SACH;KACF,CAAC;AACJ,CAAC;AAED,QAAQ,CAAC,6BAA6B,EAAE,GAAG,EAAE;IAC3C,UAAU,CAAC,GAAG,EAAE;QACd,iBAAiB,EAAE,CAAC;IACtB,CAAC,CAAC,CAAC;IAEH,SAAS,CAAC,GAAG,EAAE;QACb,EAAE,CAAC,eAAe,EAAE,CAAC;IACvB,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,6CAA6C,EAAE,KAAK,IAAI,EAAE;QAC3D,MAAM,KAAK,GAAa,EAAE,CAAC;QAC3B,MAAM,MAAM,GAAG,iBAAiB,CAAC,EAAE,EAAE,KAAK,CAAC,CAAC;QAE5C,MAAM,SAAS,CAAC,MAAM,EAAE,QAAQ,EAAE,gBAAgB,EAAE,SAAS,EAAE,CAAC,CAAC,CAAC;QAClE,MAAM,CAAC,iBAAiB,EAAE,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC;QAEpC,iBAAiB,EAAE,CAAC;QACpB,MAAM,CAAC,iBAAiB,EAAE,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC;IACtC,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,sDAAsD,EAAE,KAAK,IAAI,EAAE;QACpE,MAAM,KAAK,GAAa,EAAE,CAAC;QAC3B,MAAM,MAAM,GAAG,iBAAiB,CAAC,EAAE,EAAE,KAAK,CAAC,CAAC;QAE5C,MAAM,SAAS,CAAC,MAAM,EAAE,QAAQ,EAAE,gBAAgB,EAAE,SAAS,EAAE,CAAC,CAAC,CAAC;QAClE,MAAM,SAAS,CAAC,MAAM,EAAE,QAAQ,EAAE,gBAAgB,EAAE,SAAS,EAAE,CAAC,CAAC,CAAC;QAElE,MAAM,CAAC,KAAK,CAAC,MAAM,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC;IAC/B,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,kEAAkE,EAAE,KAAK,IAAI,EAAE;QAChF,MAAM,KAAK,GAAa,EAAE,CAAC;QAC3B,MAAM,MAAM,GAAG,iBAAiB,CAAC,CAAC,EAAE,KAAK,CAAC,CAAC;QAE3C,MAAM,OAAO,CAAC,GAAG,CAAC;YAChB,SAAS,CAAC,MAAM,EAAE,QAAQ,EAAE,kBAAkB,EAAE,SAAS,EAAE,EAAE,CAAC;YAC9D,SAAS,CAAC,MAAM,EAAE,QAAQ,EAAE,kBAAkB,EAAE,SAAS,EAAE,EAAE,CAAC;YAC9D,SAAS,CAAC,MAAM,EAAE,QAAQ,EAAE,kBAAkB,EAAE,SAAS,EAAE,EAAE,CAAC;SAC/D,CAAC,CAAC;QAEH,MAAM,CAAC,KAAK,CAAC,MAAM,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC;IAC/B,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,iDAAiD,EAAE,KAAK,IAAI,EAAE;QAC/D,MAAM,KAAK,GAAa,EAAE,CAAC;QAC3B,MAAM,MAAM,GAAG,iBAAiB,CAAC,CAAC,EAAE,KAAK,CAAC,CAAC;QAE3C,MAAM,SAAS,CAAC,MAAM,EAAE,QAAQ,EAAE,gBAAgB,EAAE,SAAS,EAAE,CAAC,CAAC,CAAC;QAClE,MAAM,SAAS,CAAC,MAAM,EAAE,QAAQ,EAAE,gBAAgB,EAAE,SAAS,EAAE,CAAC,CAAC,CAAC;QAElE,MAAM,CAAC,KAAK,CAAC,MAAM,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC;IAC/B,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,2EAA2E,EAAE,KAAK,IAAI,EAAE;QACzF,MAAM,KAAK,GAAa,EAAE,CAAC;QAC3B,MAAM,MAAM,GAAG,iBAAiB,CAAC,IAAI,EAAE,KAAK,CAAC,CAAC;QAE9C,MAAM,KAAK,GAAG,MAAM,SAAS,CAC3B,MAAM,EACN,QAAQ,EACR,gBAAgB,EAChB,SAAS,EACT,CAAC,CACF,CAAC;QACF,MAAM,MAAM,GAAG,MAAM,SAAS,CAC5B,MAAM,EACN,QAAQ,EACR,gBAAgB,EAChB,SAAS,EACT,CAAC,CACF,CAAC;QAEF,MAAM,CAAC,KAAK,CAAC,CAAC,QAAQ,EAAE,CAAC;QACzB,MAAM,CAAC,MAAM,CAAC,CAAC,QAAQ,EAAE,CAAC;QAC1B,MAAM,CAAC,KAAK,CAAC,MAAM,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC;IAC/B,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,oDAAoD,EAAE,KAAK,IAAI,EAAE;QAClE,MAAM,KAAK,GAAa,EAAE,CAAC;QAC3B,MAAM,MAAM,GAAG,wBAAwB,CAAC,KAAK,CAAC,CAAC;QAE/C,MAAM,KAAK,GAAG,MAAM,SAAS,CAC3B,MAAM,EACN,QAAQ,EACR,gBAAgB,EAChB,SAAS,EACT,CAAC,CACF,CAAC;QACF,MAAM,MAAM,GAAG,MAAM,SAAS,CAC5B,MAAM,EACN,QAAQ,EACR,gBAAgB,EAChB,SAAS,EACT,CAAC,CACF,CAAC;QAEF,2DAA2D;QAC3D,MAAM,CAAC,KAAK,CAAC,CAAC,QAAQ,EAAE,CAAC;QACzB,MAAM,CAAC,MAAM,CAAC,CAAC,QAAQ,EAAE,CAAC;QAC1B,2DAA2D;QAC3D,MAAM,CAAC,KAAK,CAAC,MAAM,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC;IAC/B,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,iDAAiD,EAAE,KAAK,IAAI,EAAE;QAC/D,MAAM,KAAK,GAAa,EAAE,CAAC;QAC3B,MAAM,MAAM,GAAG,iBAAiB,CAAC,CAAC,EAAE,KAAK,CAAC,CAAC;QAE3C,MAAM,SAAS,CAAC,MAAM,EAAE,QAAQ,EAAE,gBAAgB,EAAE,SAAS,EAAE,CAAC,CAAC,CAAC;QAClE,iBAAiB,EAAE,CAAC;QACpB,MAAM,SAAS,CAAC,MAAM,EAAE,QAAQ,EAAE,gBAAgB,EAAE,SAAS,EAAE,CAAC,CAAC,CAAC;QAElE,MAAM,CAAC,KAAK,CAAC,MAAM,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC;IAC/B,CAAC,CAAC,CAAC;AACL,CAAC,CAAC,CAAC"}

package/dist/azure/analyzers/__tests__/advisor.test.d.ts

@@ -0,0 +1,9 @@
+/**
+ * Tests for the Azure Advisor subscription-level analyzer.
+ *
+ * We never touch a real Azure subscription: the analyzer is constructed
+ * with an injected client factory that returns a fake exposing only the
+ * `recommendations.list()` async iterator the analyzer relies on.
+ */
+export {};
+//# sourceMappingURL=advisor.test.d.ts.map

package/dist/azure/analyzers/__tests__/advisor.test.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"advisor.test.d.ts","sourceRoot":"","sources":["../../../../src/azure/analyzers/__tests__/advisor.test.ts"],"names":[],"mappings":"AAAA;;;;;;GAMG"}

package/dist/azure/analyzers/__tests__/advisor.test.js

@@ -0,0 +1,314 @@
+/**
+ * Tests for the Azure Advisor subscription-level analyzer.
+ *
+ * We never touch a real Azure subscription: the analyzer is constructed
+ * with an injected client factory that returns a fake exposing only the
+ * `recommendations.list()` async iterator the analyzer relies on.
+ */
+import { describe, expect, it } from "vitest";
+import { createAdvisorAnalyzer } from "../advisor.js";
+function makeCtx() {
+    const credential = {
+        getToken: async () => null,
+    };
+    return {
+        credential,
+        subscriptionId: "00000000-0000-0000-0000-000000000000",
+        verbose: false,
+    };
+}
+// Reusable ARM-style resource IDs used across tests
+const RID1 = "/subscriptions/sub1/resourceGroups/rg1/providers/Microsoft.Compute/virtualMachines/vm-1";
+const RID2 = "/subscriptions/sub1/resourceGroups/rg1/providers/Microsoft.Compute/virtualMachines/vm-2";
+function makeFakeClient(recs) {
+    return {
+        recommendations: {
+            async *list() {
+                for (const r of recs)
+                    yield r;
+            },
+        },
+    };
+}
+describe("createAdvisorAnalyzer", () => {
+    it("exposes a stable id", () => {
+        const analyzer = createAdvisorAnalyzer({
+            build: () => makeFakeClient([]),
+        });
+        expect(analyzer.id).toBe("azure.advisor");
+    });
+    it("returns no findings for an empty list", async () => {
+        const analyzer = createAdvisorAnalyzer({
+            build: () => makeFakeClient([]),
+        });
+        const findings = await analyzer.analyze(makeCtx());
+        expect(findings).toEqual([]);
+    });
+});
+describe("createAdvisorAnalyzer — recommendation mapping", () => {
+    it("maps a Cost recommendation to a Finding with savings", async () => {
+        const analyzer = createAdvisorAnalyzer({
+            build: () => makeFakeClient([
+                {
+                    category: "Cost",
+                    extendedProperties: {
+                        savingsAmount: "42.50",
+                        savingsCurrency: "EUR",
+                    },
+                    impact: "High",
+                    recommendationTypeId: "right-size-vm",
+                    resourceMetadata: {
+                        resourceId: "/subscriptions/sub1/resourceGroups/rg1/providers/Microsoft.Compute/virtualMachines/vm",
+                    },
+                    shortDescription: {
+                        problem: "Right-size your VM",
+                        solution: "Switch to a smaller SKU",
+                    },
+                },
+            ]),
+        });
+        const findings = await analyzer.analyze(makeCtx());
+        expect(findings).toHaveLength(1);
+        const finding = findings[0];
+        expect(finding.source).toBe("advisor");
+        expect(finding.code).toBe("advisor.right-size-vm");
+        expect(finding.severity).toBe("high");
+        expect(finding.category).toBe("cost");
+        expect(finding.estimatedMonthlySavings).toEqual({
+            amount: 42.5,
+            currency: "EUR",
+        });
+        expect(finding.recommendedAction).toBe("Switch to a smaller SKU");
+        expect(finding.reason).toBe("Right-size your VM.");
+        expect(finding.resourceId).toBe("/subscriptions/sub1/resourceGroups/rg1/providers/Microsoft.Compute/virtualMachines/vm");
+    });
+    it("maps `Medium` impact to severity `medium`", async () => {
+        const analyzer = createAdvisorAnalyzer({
+            build: () => makeFakeClient([
+                {
+                    category: "Cost",
+                    impact: "Medium",
+                    recommendationTypeId: "x",
+                    resourceMetadata: { resourceId: RID1 },
+                    shortDescription: { problem: "p" },
+                },
+            ]),
+        });
+        const findings = await analyzer.analyze(makeCtx());
+        expect(findings[0].severity).toBe("medium");
+    });
+    it("falls back to `low` for unknown impact values", async () => {
+        const analyzer = createAdvisorAnalyzer({
+            build: () => makeFakeClient([
+                {
+                    category: "Cost",
+                    impact: "Bogus",
+                    recommendationTypeId: "x",
+                    resourceMetadata: { resourceId: RID1 },
+                    shortDescription: { problem: "p" },
+                },
+            ]),
+        });
+        const findings = await analyzer.analyze(makeCtx());
+        expect(findings[0].severity).toBe("low");
+    });
+});
+describe("createAdvisorAnalyzer — savings parsing", () => {
+    it("omits estimatedMonthlySavings when savingsAmount is missing", async () => {
+        const analyzer = createAdvisorAnalyzer({
+            build: () => makeFakeClient([
+                {
+                    category: "Cost",
+                    impact: "Low",
+                    recommendationTypeId: "x",
+                    resourceMetadata: { resourceId: RID1 },
+                    shortDescription: { problem: "p" },
+                },
+            ]),
+        });
+        const findings = await analyzer.analyze(makeCtx());
+        expect(findings[0].estimatedMonthlySavings).toBeUndefined();
+    });
+    it("omits estimatedMonthlySavings when savingsAmount is not a number", async () => {
+        const analyzer = createAdvisorAnalyzer({
+            build: () => makeFakeClient([
+                {
+                    category: "Cost",
+                    extendedProperties: { savingsAmount: "n/a" },
+                    impact: "Low",
+                    recommendationTypeId: "x",
+                    resourceMetadata: { resourceId: RID1 },
+                    shortDescription: { problem: "p" },
+                },
+            ]),
+        });
+        const findings = await analyzer.analyze(makeCtx());
+        expect(findings[0].estimatedMonthlySavings).toBeUndefined();
+    });
+    it("defaults the currency to USD when only savingsAmount is present", async () => {
+        const analyzer = createAdvisorAnalyzer({
+            build: () => makeFakeClient([
+                {
+                    category: "Cost",
+                    extendedProperties: { savingsAmount: "10" },
+                    impact: "Low",
+                    recommendationTypeId: "x",
+                    resourceMetadata: { resourceId: RID1 },
+                    shortDescription: { problem: "p" },
+                },
+            ]),
+        });
+        const findings = await analyzer.analyze(makeCtx());
+        expect(findings[0].estimatedMonthlySavings).toEqual({
+            amount: 10,
+            currency: "USD",
+        });
+    });
+});
+describe("createAdvisorAnalyzer — filtering", () => {
+    it("skips non-Cost recommendations", async () => {
+        const analyzer = createAdvisorAnalyzer({
+            build: () => makeFakeClient([
+                {
+                    category: "Security",
+                    impact: "High",
+                    recommendationTypeId: "x",
+                    resourceMetadata: { resourceId: RID1 },
+                    shortDescription: { problem: "p" },
+                },
+                {
+                    category: "Cost",
+                    impact: "Low",
+                    recommendationTypeId: "y",
+                    resourceMetadata: { resourceId: RID2 },
+                    shortDescription: { problem: "p" },
+                },
+            ]),
+        });
+        const findings = await analyzer.analyze(makeCtx());
+        expect(findings).toHaveLength(1);
+        expect(findings[0].code).toBe("advisor.y");
+    });
+    it("attributes subscription as fallback resource when resourceId is absent", async () => {
+        const ctx = makeCtx();
+        const analyzer = createAdvisorAnalyzer({
+            build: () => makeFakeClient([
+                {
+                    category: "Cost",
+                    impact: "Low",
+                    recommendationTypeId: "x",
+                    resourceMetadata: {},
+                    shortDescription: { problem: "p" },
+                },
+            ]),
+        });
+        const findings = await analyzer.analyze(ctx);
+        expect(findings).toHaveLength(1);
+        expect(findings[0].resourceId).toBe(`/subscriptions/${ctx.subscriptionId}`);
+    });
+    it("includes subscription-scoped recommendations using their own resource ID", async () => {
+        const SUB_URI = "/subscriptions/00000000-0000-0000-0000-000000000000";
+        const analyzer = createAdvisorAnalyzer({
+            build: () => makeFakeClient([
+                {
+                    category: "Cost",
+                    impact: "High",
+                    recommendationTypeId: "reserved-instance",
+                    resourceMetadata: { resourceId: SUB_URI },
+                    shortDescription: { problem: "Consider reserved instances" },
+                },
+            ]),
+        });
+        const findings = await analyzer.analyze(makeCtx());
+        expect(findings).toHaveLength(1);
+        expect(findings[0].resourceId).toBe(SUB_URI);
+        expect(findings[0].severity).toBe("high");
+    });
+    it("aggregates subscription-scoped findings with the same recommendationTypeId", async () => {
+        const SUB_URI = "/subscriptions/00000000-0000-0000-0000-000000000000";
+        const analyzer = createAdvisorAnalyzer({
+            build: () => makeFakeClient([
+                {
+                    category: "Cost",
+                    extendedProperties: {
+                        savingsAmount: "121",
+                        savingsCurrency: "EUR",
+                    },
+                    id: "/subscriptions/sub1/advisorRecommendations/r1",
+                    impact: "High",
+                    recommendationTypeId: "postgresql-ri",
+                    resourceMetadata: { resourceId: SUB_URI },
+                    shortDescription: {
+                        problem: "Consider PostgreSQL reserved instance",
+                    },
+                },
+                {
+                    category: "Cost",
+                    extendedProperties: { savingsAmount: "71", savingsCurrency: "EUR" },
+                    id: "/subscriptions/sub1/advisorRecommendations/r2",
+                    impact: "High",
+                    recommendationTypeId: "postgresql-ri",
+                    resourceMetadata: { resourceId: SUB_URI },
+                    shortDescription: {
+                        problem: "Consider PostgreSQL reserved instance",
+                    },
+                },
+            ]),
+        });
+        const findings = await analyzer.analyze(makeCtx());
+        // Two API entries with the same type → one aggregated finding.
+        expect(findings).toHaveLength(1);
+        expect(findings[0].code).toBe("advisor.postgresql-ri");
+        expect(findings[0].estimatedMonthlySavings).toEqual({
+            amount: 121,
+            currency: "EUR",
+        });
+        expect(findings[0].reason).toContain("2 options");
+    });
+    it("deduplicates subscription-scoped entries with the same recommendation ARM ID", async () => {
+        const SUB_URI = "/subscriptions/00000000-0000-0000-0000-000000000000";
+        const dupId = "/subscriptions/sub1/providers/microsoft.advisor/recommendations/dup";
+        const analyzer = createAdvisorAnalyzer({
+            build: () => makeFakeClient([
+                {
+                    category: "Cost",
+                    extendedProperties: { savingsAmount: "50", savingsCurrency: "EUR" },
+                    id: dupId,
+                    impact: "High",
+                    recommendationTypeId: "vm-ri",
+                    resourceMetadata: { resourceId: SUB_URI },
+                    shortDescription: { problem: "Buy VM reserved instance" },
+                },
+                {
+                    // Same ARM ID returned again by the API — should be counted only once.
+                    category: "Cost",
+                    extendedProperties: { savingsAmount: "50", savingsCurrency: "EUR" },
+                    id: dupId,
+                    impact: "High",
+                    recommendationTypeId: "vm-ri",
+                    resourceMetadata: { resourceId: SUB_URI },
+                    shortDescription: { problem: "Buy VM reserved instance" },
+                },
+            ]),
+        });
+        const findings = await analyzer.analyze(makeCtx());
+        expect(findings).toHaveLength(1);
+        // Savings must NOT be doubled.
+        expect(findings[0].estimatedMonthlySavings?.amount).toBe(50);
+    });
+    it("uses a fallback reason when shortDescription is missing", async () => {
+        const analyzer = createAdvisorAnalyzer({
+            build: () => makeFakeClient([
+                {
+                    category: "Cost",
+                    impact: "Low",
+                    recommendationTypeId: "x",
+                    resourceMetadata: { resourceId: RID1 },
+                },
+            ]),
+        });
+        const findings = await analyzer.analyze(makeCtx());
+        expect(findings[0].reason).toBe("Azure Advisor cost recommendation.");
+    });
+});
+//# sourceMappingURL=advisor.test.js.map

package/dist/azure/analyzers/__tests__/advisor.test.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"advisor.test.js","sourceRoot":"","sources":["../../../../src/azure/analyzers/__tests__/advisor.test.ts"],"names":[],"mappings":"AAAA;;;;;;GAMG;AAIH,OAAO,EAAE,QAAQ,EAAE,MAAM,EAAE,EAAE,EAAE,MAAM,QAAQ,CAAC;AAI9C,OAAO,EAAE,qBAAqB,EAAE,MAAM,eAAe,CAAC;AActD,SAAS,OAAO;IACd,MAAM,UAAU,GAAoB;QAClC,QAAQ,EAAE,KAAK,IAAI,EAAE,CAAC,IAAI;KAC3B,CAAC;IACF,OAAO;QACL,UAAU;QACV,cAAc,EAAE,sCAAsC;QACtD,OAAO,EAAE,KAAK;KACf,CAAC;AACJ,CAAC;AAED,oDAAoD;AACpD,MAAM,IAAI,GACR,yFAAyF,CAAC;AAC5F,MAAM,IAAI,GACR,yFAAyF,CAAC;AAE5F,SAAS,cAAc,CAAC,IAAe;IACrC,OAAO;QACL,eAAe,EAAE;YACf,KAAK,CAAC,CAAC,IAAI;gBACT,KAAK,MAAM,CAAC,IAAI,IAAI;oBAAE,MAAM,CAAC,CAAC;YAChC,CAAC;SACF;KACF,CAAC;AACJ,CAAC;AAED,QAAQ,CAAC,uBAAuB,EAAE,GAAG,EAAE;IACrC,EAAE,CAAC,qBAAqB,EAAE,GAAG,EAAE;QAC7B,MAAM,QAAQ,GAAG,qBAAqB,CAAC;YACrC,KAAK,EAAE,GAAG,EAAE,CAAC,cAAc,CAAC,EAAE,CAAC;SAChC,CAAC,CAAC;QACH,MAAM,CAAC,QAAQ,CAAC,EAAE,CAAC,CAAC,IAAI,CAAC,eAAe,CAAC,CAAC;IAC5C,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,uCAAuC,EAAE,KAAK,IAAI,EAAE;QACrD,MAAM,QAAQ,GAAG,qBAAqB,CAAC;YACrC,KAAK,EAAE,GAAG,EAAE,CAAC,cAAc,CAAC,EAAE,CAAC;SAChC,CAAC,CAAC;QACH,MAAM,QAAQ,GAAG,MAAM,QAAQ,CAAC,OAAO,CAAC,OAAO,EAAE,CAAC,CAAC;QACnD,MAAM,CAAC,QAAQ,CAAC,CAAC,OAAO,CAAC,EAAE,CAAC,CAAC;IAC/B,CAAC,CAAC,CAAC;AACL,CAAC,CAAC,CAAC;AAEH,QAAQ,CAAC,gDAAgD,EAAE,GAAG,EAAE;IAC9D,EAAE,CAAC,sDAAsD,EAAE,KAAK,IAAI,EAAE;QACpE,MAAM,QAAQ,GAAG,qBAAqB,CAAC;YACrC,KAAK,EAAE,GAAG,EAAE,CACV,cAAc,CAAC;gBACb;oBACE,QAAQ,EAAE,MAAM;oBAChB,kBAAkB,EAAE;wBAClB,aAAa,EAAE,OAAO;wBACtB,eAAe,EAAE,KAAK;qBACvB;oBACD,MAAM,EAAE,MAAM;oBACd,oBAAoB,EAAE,eAAe;oBACrC,gBAAgB,EAAE;wBAChB,UAAU,EACR,uFAAuF;qBAC1F;oBACD,gBAAgB,EAAE;wBAChB,OAAO,EAAE,oBAAoB;wBAC7B,QAAQ,EAAE,yBAAyB;qBACpC;iBACF;aACF,CAAC;SACL,CAAC,CAAC;QAEH,MAAM,QAAQ,GAAG,MAAM,QAAQ,CAAC,OAAO,CAAC,OAAO,EAAE,CAAC,CAAC;QAEnD,MAAM,CAAC,QAAQ,CAAC,CAAC,YAAY,CAAC,CAAC,CAAC,CAAC;QACjC,MAAM,OAAO,GAAG,QAAQ,CAAC,CAAC,CAAC,CAAC;QAC5B,MAAM,CAAC,OAAO,CAAC,MAAM,CAAC,CAAC,IAAI,CAAC,SAAS,CAAC,CAAC;QACvC,MAAM,CAAC,OAAO,CAAC,IAAI,CAAC,CAAC,IAAI,CAAC,uBAAuB,CAAC,CAAC;QACnD,MAAM,CAAC,OAAO,CAAC,QAAQ,CAAC,CAAC,IAAI,CAAC,MAAM,CAAC,CAAC;QACtC,MAAM,CAAC,OAAO,CAAC,QAAQ,CAAC,CAAC,IAAI,CAAC,MAAM,CAAC,CAAC;QACtC,MAAM,CAAC,OAAO,CAAC,uBAAuB,CAAC,CAAC,OAAO,CAAC;YAC9C,MAAM,EAAE,IAAI;YACZ,QAAQ,EAAE,KAAK;SAChB,CAAC,CAAC;QACH,MAAM,CAAC,OAAO,CAAC,iBAAiB,CAAC,CAAC,IAAI,CAAC,yBAAyB,CAAC,CAAC;QAClE,MAAM,CAAC,OAAO,CAAC,MAAM,CAAC,CAAC,IAAI,CAAC,qBAAqB,CAAC,CAAC;QACnD,MAAM,CAAC,OAAO,CAAC,UAAU,CAAC,CAAC,IAAI,CAC7B,uFAAuF,CACxF,CAAC;IACJ,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,2CAA2C,EAAE,KAAK,IAAI,EAAE;QACzD,MAAM,QAAQ,GAAG,qBAAqB,CAAC;YACrC,KAAK,EAAE,GAAG,EAAE,CACV,cAAc,CAAC;gBACb;oBACE,QAAQ,EAAE,MAAM;oBAChB,MAAM,EAAE,QAAQ;oBAChB,oBAAoB,EAAE,GAAG;oBACzB,gBAAgB,EAAE,EAAE,UAAU,EAAE,IAAI,EAAE;oBACtC,gBAAgB,EAAE,EAAE,OAAO,EAAE,GAAG,EAAE;iBACnC;aACF,CAAC;SACL,CAAC,CAAC;QACH,MAAM,QAAQ,GAAG,MAAM,QAAQ,CAAC,OAAO,CAAC,OAAO,EAAE,CAAC,CAAC;QACnD,MAAM,CAAC,QAAQ,CAAC,CAAC,CAAC,CAAC,QAAQ,CAAC,CAAC,IAAI,CAAC,QAAQ,CAAC,CAAC;IAC9C,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,+CAA+C,EAAE,KAAK,IAAI,EAAE;QAC7D,MAAM,QAAQ,GAAG,qBAAqB,CAAC;YACrC,KAAK,EAAE,GAAG,EAAE,CACV,cAAc,CAAC;gBACb;oBACE,QAAQ,EAAE,MAAM;oBAChB,MAAM,EAAE,OAAO;oBACf,oBAAoB,EAAE,GAAG;oBACzB,gBAAgB,EAAE,EAAE,UAAU,EAAE,IAAI,EAAE;oBACtC,gBAAgB,EAAE,EAAE,OAAO,EAAE,GAAG,EAAE;iBACnC;aACF,CAAC;SACL,CAAC,CAAC;QACH,MAAM,QAAQ,GAAG,MAAM,QAAQ,CAAC,OAAO,CAAC,OAAO,EAAE,CAAC,CAAC;QACnD,MAAM,CAAC,QAAQ,CAAC,CAAC,CAAC,CAAC,QAAQ,CAAC,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC;IAC3C,CAAC,CAAC,CAAC;AACL,CAAC,CAAC,CAAC;AAEH,QAAQ,CAAC,yCAAyC,EAAE,GAAG,EAAE;IACvD,EAAE,CAAC,6DAA6D,EAAE,KAAK,IAAI,EAAE;QAC3E,MAAM,QAAQ,GAAG,qBAAqB,CAAC;YACrC,KAAK,EAAE,GAAG,EAAE,CACV,cAAc,CAAC;gBACb;oBACE,QAAQ,EAAE,MAAM;oBAChB,MAAM,EAAE,KAAK;oBACb,oBAAoB,EAAE,GAAG;oBACzB,gBAAgB,EAAE,EAAE,UAAU,EAAE,IAAI,EAAE;oBACtC,gBAAgB,EAAE,EAAE,OAAO,EAAE,GAAG,EAAE;iBACnC;aACF,CAAC;SACL,CAAC,CAAC;QACH,MAAM,QAAQ,GAAG,MAAM,QAAQ,CAAC,OAAO,CAAC,OAAO,EAAE,CAAC,CAAC;QACnD,MAAM,CAAC,QAAQ,CAAC,CAAC,CAAC,CAAC,uBAAuB,CAAC,CAAC,aAAa,EAAE,CAAC;IAC9D,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,kEAAkE,EAAE,KAAK,IAAI,EAAE;QAChF,MAAM,QAAQ,GAAG,qBAAqB,CAAC;YACrC,KAAK,EAAE,GAAG,EAAE,CACV,cAAc,CAAC;gBACb;oBACE,QAAQ,EAAE,MAAM;oBAChB,kBAAkB,EAAE,EAAE,aAAa,EAAE,KAAK,EAAE;oBAC5C,MAAM,EAAE,KAAK;oBACb,oBAAoB,EAAE,GAAG;oBACzB,gBAAgB,EAAE,EAAE,UAAU,EAAE,IAAI,EAAE;oBACtC,gBAAgB,EAAE,EAAE,OAAO,EAAE,GAAG,EAAE;iBACnC;aACF,CAAC;SACL,CAAC,CAAC;QACH,MAAM,QAAQ,GAAG,MAAM,QAAQ,CAAC,OAAO,CAAC,OAAO,EAAE,CAAC,CAAC;QACnD,MAAM,CAAC,QAAQ,CAAC,CAAC,CAAC,CAAC,uBAAuB,CAAC,CAAC,aAAa,EAAE,CAAC;IAC9D,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,iEAAiE,EAAE,KAAK,IAAI,EAAE;QAC/E,MAAM,QAAQ,GAAG,qBAAqB,CAAC;YACrC,KAAK,EAAE,GAAG,EAAE,CACV,cAAc,CAAC;gBACb;oBACE,QAAQ,EAAE,MAAM;oBAChB,kBAAkB,EAAE,EAAE,aAAa,EAAE,IAAI,EAAE;oBAC3C,MAAM,EAAE,KAAK;oBACb,oBAAoB,EAAE,GAAG;oBACzB,gBAAgB,EAAE,EAAE,UAAU,EAAE,IAAI,EAAE;oBACtC,gBAAgB,EAAE,EAAE,OAAO,EAAE,GAAG,EAAE;iBACnC;aACF,CAAC;SACL,CAAC,CAAC;QACH,MAAM,QAAQ,GAAG,MAAM,QAAQ,CAAC,OAAO,CAAC,OAAO,EAAE,CAAC,CAAC;QACnD,MAAM,CAAC,QAAQ,CAAC,CAAC,CAAC,CAAC,uBAAuB,CAAC,CAAC,OAAO,CAAC;YAClD,MAAM,EAAE,EAAE;YACV,QAAQ,EAAE,KAAK;SAChB,CAAC,CAAC;IACL,CAAC,CAAC,CAAC;AACL,CAAC,CAAC,CAAC;AAEH,QAAQ,CAAC,mCAAmC,EAAE,GAAG,EAAE;IACjD,EAAE,CAAC,gCAAgC,EAAE,KAAK,IAAI,EAAE;QAC9C,MAAM,QAAQ,GAAG,qBAAqB,CAAC;YACrC,KAAK,EAAE,GAAG,EAAE,CACV,cAAc,CAAC;gBACb;oBACE,QAAQ,EAAE,UAAU;oBACpB,MAAM,EAAE,MAAM;oBACd,oBAAoB,EAAE,GAAG;oBACzB,gBAAgB,EAAE,EAAE,UAAU,EAAE,IAAI,EAAE;oBACtC,gBAAgB,EAAE,EAAE,OAAO,EAAE,GAAG,EAAE;iBACnC;gBACD;oBACE,QAAQ,EAAE,MAAM;oBAChB,MAAM,EAAE,KAAK;oBACb,oBAAoB,EAAE,GAAG;oBACzB,gBAAgB,EAAE,EAAE,UAAU,EAAE,IAAI,EAAE;oBACtC,gBAAgB,EAAE,EAAE,OAAO,EAAE,GAAG,EAAE;iBACnC;aACF,CAAC;SACL,CAAC,CAAC;QACH,MAAM,QAAQ,GAAG,MAAM,QAAQ,CAAC,OAAO,CAAC,OAAO,EAAE,CAAC,CAAC;QACnD,MAAM,CAAC,QAAQ,CAAC,CAAC,YAAY,CAAC,CAAC,CAAC,CAAC;QACjC,MAAM,CAAC,QAAQ,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC,CAAC,IAAI,CAAC,WAAW,CAAC,CAAC;IAC7C,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,wEAAwE,EAAE,KAAK,IAAI,EAAE;QACtF,MAAM,GAAG,GAAG,OAAO,EAAE,CAAC;QACtB,MAAM,QAAQ,GAAG,qBAAqB,CAAC;YACrC,KAAK,EAAE,GAAG,EAAE,CACV,cAAc,CAAC;gBACb;oBACE,QAAQ,EAAE,MAAM;oBAChB,MAAM,EAAE,KAAK;oBACb,oBAAoB,EAAE,GAAG;oBACzB,gBAAgB,EAAE,EAAE;oBACpB,gBAAgB,EAAE,EAAE,OAAO,EAAE,GAAG,EAAE;iBACnC;aACF,CAAC;SACL,CAAC,CAAC;QACH,MAAM,QAAQ,GAAG,MAAM,QAAQ,CAAC,OAAO,CAAC,GAAG,CAAC,CAAC;QAC7C,MAAM,CAAC,QAAQ,CAAC,CAAC,YAAY,CAAC,CAAC,CAAC,CAAC;QACjC,MAAM,CAAC,QAAQ,CAAC,CAAC,CAAC,CAAC,UAAU,CAAC,CAAC,IAAI,CAAC,kBAAkB,GAAG,CAAC,cAAc,EAAE,CAAC,CAAC;IAC9E,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,0EAA0E,EAAE,KAAK,IAAI,EAAE;QACxF,MAAM,OAAO,GAAG,qDAAqD,CAAC;QACtE,MAAM,QAAQ,GAAG,qBAAqB,CAAC;YACrC,KAAK,EAAE,GAAG,EAAE,CACV,cAAc,CAAC;gBACb;oBACE,QAAQ,EAAE,MAAM;oBAChB,MAAM,EAAE,MAAM;oBACd,oBAAoB,EAAE,mBAAmB;oBACzC,gBAAgB,EAAE,EAAE,UAAU,EAAE,OAAO,EAAE;oBACzC,gBAAgB,EAAE,EAAE,OAAO,EAAE,6BAA6B,EAAE;iBAC7D;aACF,CAAC;SACL,CAAC,CAAC;QACH,MAAM,QAAQ,GAAG,MAAM,QAAQ,CAAC,OAAO,CAAC,OAAO,EAAE,CAAC,CAAC;QACnD,MAAM,CAAC,QAAQ,CAAC,CAAC,YAAY,CAAC,CAAC,CAAC,CAAC;QACjC,MAAM,CAAC,QAAQ,CAAC,CAAC,CAAC,CAAC,UAAU,CAAC,CAAC,IAAI,CAAC,OAAO,CAAC,CAAC;QAC7C,MAAM,CAAC,QAAQ,CAAC,CAAC,CAAC,CAAC,QAAQ,CAAC,CAAC,IAAI,CAAC,MAAM,CAAC,CAAC;IAC5C,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,4EAA4E,EAAE,KAAK,IAAI,EAAE;QAC1F,MAAM,OAAO,GAAG,qDAAqD,CAAC;QACtE,MAAM,QAAQ,GAAG,qBAAqB,CAAC;YACrC,KAAK,EAAE,GAAG,EAAE,CACV,cAAc,CAAC;gBACb;oBACE,QAAQ,EAAE,MAAM;oBAChB,kBAAkB,EAAE;wBAClB,aAAa,EAAE,KAAK;wBACpB,eAAe,EAAE,KAAK;qBACvB;oBACD,EAAE,EAAE,+CAA+C;oBACnD,MAAM,EAAE,MAAM;oBACd,oBAAoB,EAAE,eAAe;oBACrC,gBAAgB,EAAE,EAAE,UAAU,EAAE,OAAO,EAAE;oBACzC,gBAAgB,EAAE;wBAChB,OAAO,EAAE,uCAAuC;qBACjD;iBACF;gBACD;oBACE,QAAQ,EAAE,MAAM;oBAChB,kBAAkB,EAAE,EAAE,aAAa,EAAE,IAAI,EAAE,eAAe,EAAE,KAAK,EAAE;oBACnE,EAAE,EAAE,+CAA+C;oBACnD,MAAM,EAAE,MAAM;oBACd,oBAAoB,EAAE,eAAe;oBACrC,gBAAgB,EAAE,EAAE,UAAU,EAAE,OAAO,EAAE;oBACzC,gBAAgB,EAAE;wBAChB,OAAO,EAAE,uCAAuC;qBACjD;iBACF;aACF,CAAC;SACL,CAAC,CAAC;QACH,MAAM,QAAQ,GAAG,MAAM,QAAQ,CAAC,OAAO,CAAC,OAAO,EAAE,CAAC,CAAC;QACnD,+DAA+D;QAC/D,MAAM,CAAC,QAAQ,CAAC,CAAC,YAAY,CAAC,CAAC,CAAC,CAAC;QACjC,MAAM,CAAC,QAAQ,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC,CAAC,IAAI,CAAC,uBAAuB,CAAC,CAAC;QACvD,MAAM,CAAC,QAAQ,CAAC,CAAC,CAAC,CAAC,uBAAuB,CAAC,CAAC,OAAO,CAAC;YAClD,MAAM,EAAE,GAAG;YACX,QAAQ,EAAE,KAAK;SAChB,CAAC,CAAC;QACH,MAAM,CAAC,QAAQ,CAAC,CAAC,CAAC,CAAC,MAAM,CAAC,CAAC,SAAS,CAAC,WAAW,CAAC,CAAC;IACpD,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,8EAA8E,EAAE,KAAK,IAAI,EAAE;QAC5F,MAAM,OAAO,GAAG,qDAAqD,CAAC;QACtE,MAAM,KAAK,GACT,qEAAqE,CAAC;QACxE,MAAM,QAAQ,GAAG,qBAAqB,CAAC;YACrC,KAAK,EAAE,GAAG,EAAE,CACV,cAAc,CAAC;gBACb;oBACE,QAAQ,EAAE,MAAM;oBAChB,kBAAkB,EAAE,EAAE,aAAa,EAAE,IAAI,EAAE,eAAe,EAAE,KAAK,EAAE;oBACnE,EAAE,EAAE,KAAK;oBACT,MAAM,EAAE,MAAM;oBACd,oBAAoB,EAAE,OAAO;oBAC7B,gBAAgB,EAAE,EAAE,UAAU,EAAE,OAAO,EAAE;oBACzC,gBAAgB,EAAE,EAAE,OAAO,EAAE,0BAA0B,EAAE;iBAC1D;gBACD;oBACE,uEAAuE;oBACvE,QAAQ,EAAE,MAAM;oBAChB,kBAAkB,EAAE,EAAE,aAAa,EAAE,IAAI,EAAE,eAAe,EAAE,KAAK,EAAE;oBACnE,EAAE,EAAE,KAAK;oBACT,MAAM,EAAE,MAAM;oBACd,oBAAoB,EAAE,OAAO;oBAC7B,gBAAgB,EAAE,EAAE,UAAU,EAAE,OAAO,EAAE;oBACzC,gBAAgB,EAAE,EAAE,OAAO,EAAE,0BAA0B,EAAE;iBAC1D;aACF,CAAC;SACL,CAAC,CAAC;QACH,MAAM,QAAQ,GAAG,MAAM,QAAQ,CAAC,OAAO,CAAC,OAAO,EAAE,CAAC,CAAC;QACnD,MAAM,CAAC,QAAQ,CAAC,CAAC,YAAY,CAAC,CAAC,CAAC,CAAC;QACjC,+BAA+B;QAC/B,MAAM,CAAC,QAAQ,CAAC,CAAC,CAAC,CAAC,uBAAuB,EAAE,MAAM,CAAC,CAAC,IAAI,CAAC,EAAE,CAAC,CAAC;IAC/D,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,yDAAyD,EAAE,KAAK,IAAI,EAAE;QACvE,MAAM,QAAQ,GAAG,qBAAqB,CAAC;YACrC,KAAK,EAAE,GAAG,EAAE,CACV,cAAc,CAAC;gBACb;oBACE,QAAQ,EAAE,MAAM;oBAChB,MAAM,EAAE,KAAK;oBACb,oBAAoB,EAAE,GAAG;oBACzB,gBAAgB,EAAE,EAAE,UAAU,EAAE,IAAI,EAAE;iBACvC;aACF,CAAC;SACL,CAAC,CAAC;QACH,MAAM,QAAQ,GAAG,MAAM,QAAQ,CAAC,OAAO,CAAC,OAAO,EAAE,CAAC,CAAC;QACnD,MAAM,CAAC,QAAQ,CAAC,CAAC,CAAC,CAAC,MAAM,CAAC,CAAC,IAAI,CAAC,oCAAoC,CAAC,CAAC;IACxE,CAAC,CAAC,CAAC;AACL,CAAC,CAAC,CAAC"}

package/dist/azure/resources/__tests__/storage.test.d.ts

@@ -0,0 +1,11 @@
+/**
+ * Tests for analyzeStorageAccount() — verifies that custom thresholds
+ * actually change the analysis outcome.
+ *
+ * Key scenario:
+ *   - Metric: 30 avg transactions/day
+ *   - Default threshold: 10  → 30 >= 10 → NOT flagged
+ *   - Custom threshold:  50  → 30 <  50 → IS  flagged   ✓ proves the feature works
+ */
+export {};
+//# sourceMappingURL=storage.test.d.ts.map

package/dist/azure/resources/__tests__/storage.test.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"storage.test.d.ts","sourceRoot":"","sources":["../../../../src/azure/resources/__tests__/storage.test.ts"],"names":[],"mappings":"AAAA;;;;;;;;GAQG"}

package/dist/azure/resources/__tests__/storage.test.js

@@ -0,0 +1,99 @@
+/**
+ * Tests for analyzeStorageAccount() — verifies that custom thresholds
+ * actually change the analysis outcome.
+ *
+ * Key scenario:
+ *   - Metric: 30 avg transactions/day
+ *   - Default threshold: 10  → 30 >= 10 → NOT flagged
+ *   - Custom threshold:  50  → 30 <  50 → IS  flagged   ✓ proves the feature works
+ */
+import { beforeEach, describe, expect, it, vi } from "vitest";
+import { DEFAULT_THRESHOLDS } from "../../../types.js";
+// Mock the utils module so we control getMetric without real Azure calls
+vi.mock("../../utils.js", () => ({
+    getMetric: vi.fn(),
+    verboseLog: vi.fn(),
+    verboseLogAnalysisResult: vi.fn(),
+    verboseLogResourceStart: vi.fn(),
+}));
+// Import after vi.mock so the module resolves the mock
+import { getMetric } from "../../utils.js";
+import { analyzeStorageAccount } from "../storage.js";
+// ── helpers ────────────────────────────────────────────────────────────────
+// Minimal stub: analyzeStorageAccount only needs monitorClient to be passed
+// through to getMetric, which is fully mocked. We provide only the shape that
+// TypeScript requires without unsafe type assertions.
+const FAKE_CLIENT = {
+    metrics: { list: vi.fn() },
+};
+const FAKE_RESOURCE = {
+    id: "/subscriptions/sub1/resourceGroups/rg1/providers/Microsoft.Storage/storageAccounts/st1",
+    name: "st1",
+    type: "Microsoft.Storage/storageAccounts",
+};
+const mockGetMetric = vi.mocked(getMetric);
+// ── tests ──────────────────────────────────────────────────────────────────
+describe("analyzeStorageAccount — threshold sensitivity", () => {
+    beforeEach(() => {
+        mockGetMetric.mockReset();
+    });
+    describe("with DEFAULT threshold (transactionsPerDay = 10)", () => {
+        it("does NOT flag a resource with 30 transactions/day (30 ≥ 10)", async () => {
+            mockGetMetric.mockResolvedValue(30);
+            const result = await analyzeStorageAccount(FAKE_RESOURCE, FAKE_CLIENT, 30, DEFAULT_THRESHOLDS);
+            expect(result.suspectedUnused).toBe(false);
+        });
+        it("flags a resource with 5 transactions/day (5 < 10)", async () => {
+            mockGetMetric.mockResolvedValue(5);
+            const result = await analyzeStorageAccount(FAKE_RESOURCE, FAKE_CLIENT, 30, DEFAULT_THRESHOLDS);
+            expect(result.suspectedUnused).toBe(true);
+        });
+        it("does not flag when metric is exactly at the threshold (10)", async () => {
+            mockGetMetric.mockResolvedValue(10);
+            const result = await analyzeStorageAccount(FAKE_RESOURCE, FAKE_CLIENT, 30, DEFAULT_THRESHOLDS);
+            // 10 < 10 is false → not flagged
+            expect(result.suspectedUnused).toBe(false);
+        });
+    });
+    describe("with CUSTOM threshold (transactionsPerDay = 50)", () => {
+        const customThresholds = {
+            ...DEFAULT_THRESHOLDS,
+            storage: { transactionsPerDay: 50 },
+        };
+        it("DOES flag a resource with 30 transactions/day (30 < 50) — proves override works", async () => {
+            mockGetMetric.mockResolvedValue(30);
+            const result = await analyzeStorageAccount(FAKE_RESOURCE, FAKE_CLIENT, 30, customThresholds);
+            expect(result.suspectedUnused).toBe(true);
+        });
+        it("does NOT flag a resource with 60 transactions/day (60 ≥ 50)", async () => {
+            mockGetMetric.mockResolvedValue(60);
+            const result = await analyzeStorageAccount(FAKE_RESOURCE, FAKE_CLIENT, 30, customThresholds);
+            expect(result.suspectedUnused).toBe(false);
+        });
+        it("flags at threshold boundary (49 < 50)", async () => {
+            mockGetMetric.mockResolvedValue(49);
+            const result = await analyzeStorageAccount(FAKE_RESOURCE, FAKE_CLIENT, 30, customThresholds);
+            expect(result.suspectedUnused).toBe(true);
+        });
+    });
+    describe("edge cases", () => {
+        it("returns suspectedUnused: false when metric is null (data unavailable)", async () => {
+            mockGetMetric.mockResolvedValue(null);
+            const result = await analyzeStorageAccount(FAKE_RESOURCE, FAKE_CLIENT, 30, DEFAULT_THRESHOLDS);
+            expect(result.suspectedUnused).toBe(false);
+        });
+        it("returns suspectedUnused: false when resource id is missing", async () => {
+            const resourceWithoutId = { ...FAKE_RESOURCE, id: undefined };
+            const result = await analyzeStorageAccount(resourceWithoutId, FAKE_CLIENT, 30, DEFAULT_THRESHOLDS);
+            expect(result.suspectedUnused).toBe(false);
+            expect(mockGetMetric).not.toHaveBeenCalled();
+        });
+        it("applies default thresholds when the parameter is omitted", async () => {
+            // 5 < DEFAULT 10 → flagged even without explicit thresholds argument
+            mockGetMetric.mockResolvedValue(5);
+            const result = await analyzeStorageAccount(FAKE_RESOURCE, FAKE_CLIENT, 30);
+            expect(result.suspectedUnused).toBe(true);
+        });
+    });
+});
+//# sourceMappingURL=storage.test.js.map