@pagopa/dx-savemoney 0.2.6 → 0.3.1

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pagopa/dx-savemoney",
-  "version": "0.2.6",
+  "version": "0.3.1",
   "type": "module",
   "description": "Azure resource analyzer for finding unused or cost-inefficient resources.",
   "repository": {
@@ -27,6 +27,7 @@
     "DX"
   ],
   "dependencies": {
+    "@azure/arm-advisor": "^3.2.0",
     "@azure/arm-appcontainers": "^3.0.0",
     "@azure/arm-appservice": "^17.0.0",
     "@azure/arm-compute": "^23.3.0",
@@ -35,6 +36,7 @@
     "@azure/arm-resources": "^7.0.0",
     "@azure/identity": "^4.13.1",
     "@logtape/logtape": "^1.3.8",
+    "cli-table3": "^0.6.5",
     "js-yaml": "^4.1.1",
     "p-limit": "^7.3.0",
     "zod": "^4.4.2"
@@ -43,11 +45,11 @@
     "@tsconfig/node24": "24.0.4",
     "@types/js-yaml": "^4.0.9",
     "@types/node": "^22.19.17",
-    "@vitest/coverage-v8": "^3.2.4",
+    "@vitest/coverage-v8": "^4.1.8",
     "eslint": "^10.3.0",
     "prettier": "3.8.3",
     "typescript": "~5.9.3",
-    "vitest": "^3.2.4",
+    "vitest": "^4.1.8",
     "@pagopa/eslint-config": "^6.0.4"
   },
   "scripts": {

package/src/azure/__tests__/analyzer-tags.test.ts

@@ -0,0 +1,74 @@
+/**
+ * Unit tests for tag-filter behavior on Advisor findings.
+ *
+ * These tests exercise the pure helper used by the Azure analyzer
+ * orchestrator to keep filtering semantics explicit and stable.
+ */
+
+import { describe, expect, it } from "vitest";
+
+import type { Finding } from "../../finding.js";
+
+import { shouldIncludeAdvisorFindingForTags } from "../analyzer.js";
+
+function mkFinding(resourceId: string, source: Finding["source"]): Finding {
+  return {
+    category: "cost",
+    code: `${source}.test`,
+    reason: "Test finding.",
+    resourceId,
+    severity: "low",
+    source,
+  };
+}
+
+describe("shouldIncludeAdvisorFindingForTags", () => {
+  it("includes all findings when no tag filter is active", () => {
+    const finding = mkFinding(
+      "/subscriptions/sub1/resourceGroups/rg1/providers/Microsoft.Compute/virtualMachines/vm1",
+      "advisor",
+    );
+
+    expect(
+      shouldIncludeAdvisorFindingForTags(finding, new Set<string>(), false),
+    ).toBe(true);
+  });
+
+  it("keeps subscription-level Advisor findings global even with tag filters", () => {
+    const finding = mkFinding("/subscriptions/sub1", "advisor");
+
+    expect(
+      shouldIncludeAdvisorFindingForTags(finding, new Set<string>(), true),
+    ).toBe(true);
+  });
+
+  it("includes resource-level Advisor findings only when resource id is tag-matched", () => {
+    const finding = mkFinding(
+      "/subscriptions/sub1/resourceGroups/rg1/providers/Microsoft.Compute/virtualMachines/vm1",
+      "advisor",
+    );
+
+    const taggedResourceIds = new Set<string>([
+      "/subscriptions/sub1/resourcegroups/rg1/providers/microsoft.compute/virtualmachines/vm1",
+    ]);
+
+    expect(
+      shouldIncludeAdvisorFindingForTags(finding, taggedResourceIds, true),
+    ).toBe(true);
+  });
+
+  it("excludes resource-level Advisor findings when resource id is not tag-matched", () => {
+    const finding = mkFinding(
+      "/subscriptions/sub1/resourceGroups/rg1/providers/Microsoft.Compute/virtualMachines/vm2",
+      "advisor",
+    );
+
+    const taggedResourceIds = new Set<string>([
+      "/subscriptions/sub1/resourcegroups/rg1/providers/microsoft.compute/virtualmachines/vm1",
+    ]);
+
+    expect(
+      shouldIncludeAdvisorFindingForTags(finding, taggedResourceIds, true),
+    ).toBe(false);
+  });
+});

package/src/azure/__tests__/report.test.ts

@@ -52,7 +52,7 @@ const LOW_ENTRY = makeEntry(
 // ── helpers ────────────────────────────────────────────────────────────────
 
 function allLogs(spy: ReturnType<typeof vi.spyOn>) {
-  return spy.mock.calls.map((c) => c[0] as string).join("\n");
+  return spy.mock.calls.map((c: string[]) => c[0]).join("\n");
 }
 
 // ── tests ──────────────────────────────────────────────────────────────────
@@ -95,10 +95,8 @@ describe("generateReport — lint format", () => {
   it("splits a multi-sentence reason into separate findings", async () => {
     // Reason has two sentences separated by '. '
     await generateReport([HIGH_ENTRY], "lint");
-    const calls = logSpy.mock.calls.map(
-      (c) => (c[0] as string | undefined) ?? "",
-    );
-    const findingLines = calls.filter((l) => l.startsWith("  "));
+    const calls = logSpy.mock.calls.map((c: string[]) => c[0] ?? "");
+    const findingLines = calls.filter((l: string) => l.startsWith("  "));
     // "VM is deallocated." and "No disk activity detected." → 2 findings
     expect(findingLines.length).toBe(2);
   });
@@ -131,8 +129,39 @@ describe("generateReport — lint format", () => {
 
   it("prints nothing but the summary for an empty report", async () => {
     await generateReport([], "lint");
-    const calls = logSpy.mock.calls.map((c) => c[0] as string);
+    const calls = logSpy.mock.calls.map((c: string[]) => c[0]);
     expect(calls).toHaveLength(1);
     expect(calls[0]).toContain("0 issues found");
   });
 });
+
+describe("generateReport — table format", () => {
+  let logSpy: ReturnType<typeof vi.spyOn>;
+
+  beforeEach(() => {
+    logSpy = vi.spyOn(console, "log").mockImplementation(() => undefined);
+  });
+
+  afterEach(() => {
+    vi.restoreAllMocks();
+  });
+
+  it("renders without throwing for an empty report", async () => {
+    await expect(generateReport([], "table")).resolves.toBeUndefined();
+    // Table is always printed; the summary line ("0 issues found") follows.
+    expect(logSpy.mock.calls.length).toBeGreaterThanOrEqual(1);
+    const output = logSpy.mock.calls
+      .map((c: string[]) => String(c[0]))
+      .join("\n");
+    expect(output).toContain("0 issues found");
+  });
+
+  it("includes resource name and reason in the rendered table", async () => {
+    await generateReport([HIGH_ENTRY], "table");
+    const output = logSpy.mock.calls
+      .map((c: string[]) => String(c[0]))
+      .join("\n");
+    expect(output).toContain("vm-high");
+    expect(output).toContain("VM is deallocated");
+  });
+});