@pagopa/dx-savemoney 0.2.6 → 0.3.1

package/dist/azure/__tests__/utils.test.js

@@ -0,0 +1,181 @@
+/**
+ * Tests for matchesTags() — verifies AND-logic tag filtering:
+ * 1. No filter (undefined/empty) → always include the resource.
+ * 2. Exact key-value match → include.
+ * 3. Key missing on resource → exclude.
+ * 4. Key present but wrong value → exclude.
+ * 5. Multiple tags: all match → include; any mismatch → exclude.
+ *
+ * Tests for getMetric() cache behaviour:
+ * 6. resetMetricsCache() clears state between runs.
+ * 7. Concurrent calls for the same key coalesce into one network call.
+ * 8. A failed call is cached as a fulfilled null result (not retried silently).
+ */
+import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
+import { _metricsCacheSize, getMetric, matchesTags, resetMetricsCache, } from "../utils.js";
+function makeResource(tags) {
+    return { id: "r1", name: "res", tags };
+}
+describe("matchesTags", () => {
+    describe("when no filter is provided", () => {
+        it("returns true for undefined filterTags", () => {
+            expect(matchesTags(makeResource({ env: "prod" }), undefined)).toBe(true);
+        });
+        it("returns true for empty Map", () => {
+            expect(matchesTags(makeResource({ env: "prod" }), new Map())).toBe(true);
+        });
+        it("returns true even when resource has no tags", () => {
+            expect(matchesTags(makeResource(), undefined)).toBe(true);
+        });
+    });
+    describe("single tag filter", () => {
+        it("returns true when tag key and value match exactly", () => {
+            expect(matchesTags(makeResource({ env: "prod" }), new Map([["env", "prod"]]))).toBe(true);
+        });
+        it("returns false when tag key is missing from resource", () => {
+            expect(matchesTags(makeResource({ app: "myapp" }), new Map([["env", "prod"]]))).toBe(false);
+        });
+        it("returns false when tag key exists but value differs", () => {
+            expect(matchesTags(makeResource({ env: "dev" }), new Map([["env", "prod"]]))).toBe(false);
+        });
+        it("returns false when resource has no tags at all", () => {
+            expect(matchesTags(makeResource(), new Map([["env", "prod"]]))).toBe(false);
+        });
+        it("is case-sensitive for tag values", () => {
+            expect(matchesTags(makeResource({ env: "Prod" }), new Map([["env", "prod"]]))).toBe(false);
+        });
+    });
+    describe("multiple tag filters (AND logic)", () => {
+        it("returns true when all filter tags match", () => {
+            const resource = makeResource({
+                env: "prod",
+                region: "italy",
+                team: "dx",
+            });
+            expect(matchesTags(resource, new Map([
+                ["env", "prod"],
+                ["team", "dx"],
+            ]))).toBe(true);
+        });
+        it("returns false when one of the filter tags is missing", () => {
+            const resource = makeResource({ env: "prod" });
+            expect(matchesTags(resource, new Map([
+                ["env", "prod"],
+                ["team", "dx"],
+            ]))).toBe(false);
+        });
+        it("returns false when one of the filter tags has the wrong value", () => {
+            const resource = makeResource({ env: "prod", team: "backend" });
+            expect(matchesTags(resource, new Map([
+                ["env", "prod"],
+                ["team", "dx"],
+            ]))).toBe(false);
+        });
+        it("returns false when both filter tags have wrong values", () => {
+            const resource = makeResource({ env: "dev", team: "backend" });
+            expect(matchesTags(resource, new Map([
+                ["env", "prod"],
+                ["team", "dx"],
+            ]))).toBe(false);
+        });
+    });
+});
+// ── metrics cache ──────────────────────────────────────────────────────────
+function makeFailingMonitorClient(calls = []) {
+    return {
+        metrics: {
+            list: vi.fn().mockImplementation(async () => {
+                calls.push(1);
+                throw new Error("network error");
+            }),
+        },
+    };
+}
+function makeMonitorClient(returnValue, calls = []) {
+    return {
+        metrics: {
+            list: vi.fn().mockImplementation(async () => {
+                calls.push(1);
+                if (returnValue === null) {
+                    return { value: [] };
+                }
+                return {
+                    value: [
+                        {
+                            timeseries: [{ data: [{ average: returnValue }] }],
+                        },
+                    ],
+                };
+            }),
+        },
+    };
+}
+describe("getMetric — in-memory cache", () => {
+    beforeEach(() => {
+        resetMetricsCache();
+    });
+    afterEach(() => {
+        vi.restoreAllMocks();
+    });
+    it("resetMetricsCache clears all cached entries", async () => {
+        const calls = [];
+        const client = makeMonitorClient(42, calls);
+        await getMetric(client, "/res/1", "Percentage CPU", "Average", 7);
+        expect(_metricsCacheSize()).toBe(1);
+        resetMetricsCache();
+        expect(_metricsCacheSize()).toBe(0);
+    });
+    it("does not call the API a second time for the same key", async () => {
+        const calls = [];
+        const client = makeMonitorClient(10, calls);
+        await getMetric(client, "/res/1", "Percentage CPU", "Average", 7);
+        await getMetric(client, "/res/1", "Percentage CPU", "Average", 7);
+        expect(calls.length).toBe(1);
+    });
+    it("concurrent calls for the same key coalesce into one network call", async () => {
+        const calls = [];
+        const client = makeMonitorClient(5, calls);
+        await Promise.all([
+            getMetric(client, "/res/2", "Network In Total", "Average", 30),
+            getMetric(client, "/res/2", "Network In Total", "Average", 30),
+            getMetric(client, "/res/2", "Network In Total", "Average", 30),
+        ]);
+        expect(calls.length).toBe(1);
+    });
+    it("different keys result in separate network calls", async () => {
+        const calls = [];
+        const client = makeMonitorClient(1, calls);
+        await getMetric(client, "/res/a", "Percentage CPU", "Average", 7);
+        await getMetric(client, "/res/b", "Percentage CPU", "Average", 7);
+        expect(calls.length).toBe(2);
+    });
+    it("returns null and caches the null result when no data points are available", async () => {
+        const calls = [];
+        const client = makeMonitorClient(null, calls);
+        const first = await getMetric(client, "/res/3", "Percentage CPU", "Average", 7);
+        const second = await getMetric(client, "/res/3", "Percentage CPU", "Average", 7);
+        expect(first).toBeNull();
+        expect(second).toBeNull();
+        expect(calls.length).toBe(1);
+    });
+    it("a failing call is cached and returns null on retry", async () => {
+        const calls = [];
+        const client = makeFailingMonitorClient(calls);
+        const first = await getMetric(client, "/res/4", "Percentage CPU", "Average", 7);
+        const second = await getMetric(client, "/res/4", "Percentage CPU", "Average", 7);
+        // Both calls return null (error is swallowed by getMetric)
+        expect(first).toBeNull();
+        expect(second).toBeNull();
+        // Only one actual network call despite two getMetric calls
+        expect(calls.length).toBe(1);
+    });
+    it("after resetMetricsCache the API is called again", async () => {
+        const calls = [];
+        const client = makeMonitorClient(7, calls);
+        await getMetric(client, "/res/5", "Percentage CPU", "Average", 7);
+        resetMetricsCache();
+        await getMetric(client, "/res/5", "Percentage CPU", "Average", 7);
+        expect(calls.length).toBe(2);
+    });
+});
+//# sourceMappingURL=utils.test.js.map

package/dist/azure/__tests__/utils.test.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"utils.test.js","sourceRoot":"","sources":["../../../src/azure/__tests__/utils.test.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;GAYG;AAIH,OAAO,EAAE,SAAS,EAAE,UAAU,EAAE,QAAQ,EAAE,MAAM,EAAE,EAAE,EAAE,EAAE,EAAE,MAAM,QAAQ,CAAC;AAEzE,OAAO,EACL,iBAAiB,EACjB,SAAS,EACT,WAAW,EAEX,iBAAiB,GAClB,MAAM,aAAa,CAAC;AAErB,SAAS,YAAY,CAAC,IAA6B;IACjD,OAAO,EAAE,EAAE,EAAE,IAAI,EAAE,IAAI,EAAE,KAAK,EAAE,IAAI,EAAE,CAAC;AACzC,CAAC;AAED,QAAQ,CAAC,aAAa,EAAE,GAAG,EAAE;IAC3B,QAAQ,CAAC,4BAA4B,EAAE,GAAG,EAAE;QAC1C,EAAE,CAAC,uCAAuC,EAAE,GAAG,EAAE;YAC/C,MAAM,CAAC,WAAW,CAAC,YAAY,CAAC,EAAE,GAAG,EAAE,MAAM,EAAE,CAAC,EAAE,SAAS,CAAC,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;QAC3E,CAAC,CAAC,CAAC;QAEH,EAAE,CAAC,4BAA4B,EAAE,GAAG,EAAE;YACpC,MAAM,CAAC,WAAW,CAAC,YAAY,CAAC,EAAE,GAAG,EAAE,MAAM,EAAE,CAAC,EAAE,IAAI,GAAG,EAAE,CAAC,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;QAC3E,CAAC,CAAC,CAAC;QAEH,EAAE,CAAC,6CAA6C,EAAE,GAAG,EAAE;YACrD,MAAM,CAAC,WAAW,CAAC,YAAY,EAAE,EAAE,SAAS,CAAC,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;QAC5D,CAAC,CAAC,CAAC;IACL,CAAC,CAAC,CAAC;IAEH,QAAQ,CAAC,mBAAmB,EAAE,GAAG,EAAE;QACjC,EAAE,CAAC,mDAAmD,EAAE,GAAG,EAAE;YAC3D,MAAM,CACJ,WAAW,CAAC,YAAY,CAAC,EAAE,GAAG,EAAE,MAAM,EAAE,CAAC,EAAE,IAAI,GAAG,CAAC,CAAC,CAAC,KAAK,EAAE,MAAM,CAAC,CAAC,CAAC,CAAC,CACvE,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;QACf,CAAC,CAAC,CAAC;QAEH,EAAE,CAAC,qDAAqD,EAAE,GAAG,EAAE;YAC7D,MAAM,CACJ,WAAW,CAAC,YAAY,CAAC,EAAE,GAAG,EAAE,OAAO,EAAE,CAAC,EAAE,IAAI,GAAG,CAAC,CAAC,CAAC,KAAK,EAAE,MAAM,CAAC,CAAC,CAAC,CAAC,CACxE,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC;QAChB,CAAC,CAAC,CAAC;QAEH,EAAE,CAAC,qDAAqD,EAAE,GAAG,EAAE;YAC7D,MAAM,CACJ,WAAW,CAAC,YAAY,CAAC,EAAE,GAAG,EAAE,KAAK,EAAE,CAAC,EAAE,IAAI,GAAG,CAAC,CAAC,CAAC,KAAK,EAAE,MAAM,CAAC,CAAC,CAAC,CAAC,CACtE,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC;QAChB,CAAC,CAAC,CAAC;QAEH,EAAE,CAAC,gDAAgD,EAAE,GAAG,EAAE;YACxD,MAAM,CAAC,WAAW,CAAC,YAAY,EAAE,EAAE,IAAI,GAAG,CAAC,CAAC,CAAC,KAAK,EAAE,MAAM,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,IAAI,CAClE,KAAK,CACN,CAAC;QACJ,CAAC,CAAC,CAAC;QAEH,EAAE,CAAC,kCAAkC,EAAE,GAAG,EAAE;YAC1C,MAAM,CACJ,WAAW,CAAC,YAAY,CAAC,EAAE,GAAG,EAAE,MAAM,EAAE,CAAC,EAAE,IAAI,GAAG,CAAC,CAAC,CAAC,KAAK,EAAE,MAAM,CAAC,CAAC,CAAC,CAAC,CACvE,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC;QAChB,CAAC,CAAC,CAAC;IACL,CAAC,CAAC,CAAC;IAEH,QAAQ,CAAC,kCAAkC,EAAE,GAAG,EAAE;QAChD,EAAE,CAAC,yCAAyC,EAAE,GAAG,EAAE;YACjD,MAAM,QAAQ,GAAG,YAAY,CAAC;gBAC5B,GAAG,EAAE,MAAM;gBACX,MAAM,EAAE,OAAO;gBACf,IAAI,EAAE,IAAI;aACX,CAAC,CAAC;YACH,MAAM,CACJ,WAAW,CACT,QAAQ,EACR,IAAI,GAAG,CAAC;gBACN,CAAC,KAAK,EAAE,MAAM,CAAC;gBACf,CAAC,MAAM,EAAE,IAAI,CAAC;aACf,CAAC,CACH,CACF,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;QACf,CAAC,CAAC,CAAC;QAEH,EAAE,CAAC,sDAAsD,EAAE,GAAG,EAAE;YAC9D,MAAM,QAAQ,GAAG,YAAY,CAAC,EAAE,GAAG,EAAE,MAAM,EAAE,CAAC,CAAC;YAC/C,MAAM,CACJ,WAAW,CACT,QAAQ,EACR,IAAI,GAAG,CAAC;gBACN,CAAC,KAAK,EAAE,MAAM,CAAC;gBACf,CAAC,MAAM,EAAE,IAAI,CAAC;aACf,CAAC,CACH,CACF,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC;QAChB,CAAC,CAAC,CAAC;QAEH,EAAE,CAAC,+DAA+D,EAAE,GAAG,EAAE;YACvE,MAAM,QAAQ,GAAG,YAAY,CAAC,EAAE,GAAG,EAAE,MAAM,EAAE,IAAI,EAAE,SAAS,EAAE,CAAC,CAAC;YAChE,MAAM,CACJ,WAAW,CACT,QAAQ,EACR,IAAI,GAAG,CAAC;gBACN,CAAC,KAAK,EAAE,MAAM,CAAC;gBACf,CAAC,MAAM,EAAE,IAAI,CAAC;aACf,CAAC,CACH,CACF,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC;QAChB,CAAC,CAAC,CAAC;QAEH,EAAE,CAAC,uDAAuD,EAAE,GAAG,EAAE;YAC/D,MAAM,QAAQ,GAAG,YAAY,CAAC,EAAE,GAAG,EAAE,KAAK,EAAE,IAAI,EAAE,SAAS,EAAE,CAAC,CAAC;YAC/D,MAAM,CACJ,WAAW,CACT,QAAQ,EACR,IAAI,GAAG,CAAC;gBACN,CAAC,KAAK,EAAE,MAAM,CAAC;gBACf,CAAC,MAAM,EAAE,IAAI,CAAC;aACf,CAAC,CACH,CACF,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC;QAChB,CAAC,CAAC,CAAC;IACL,CAAC,CAAC,CAAC;AACL,CAAC,CAAC,CAAC;AAEH,8EAA8E;AAE9E,SAAS,wBAAwB,CAAC,QAAkB,EAAE;IACpD,OAAO;QACL,OAAO,EAAE;YACP,IAAI,EAAE,EAAE,CAAC,EAAE,EAAE,CAAC,kBAAkB,CAAC,KAAK,IAAI,EAAE;gBAC1C,KAAK,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC;gBACd,MAAM,IAAI,KAAK,CAAC,eAAe,CAAC,CAAC;YACnC,CAAC,CAAC;SACH;KACF,CAAC;AACJ,CAAC;AAED,SAAS,iBAAiB,CACxB,WAA0B,EAC1B,QAAkB,EAAE;IAEpB,OAAO;QACL,OAAO,EAAE;YACP,IAAI,EAAE,EAAE,CAAC,EAAE,EAAE,CAAC,kBAAkB,CAAC,KAAK,IAAI,EAAE;gBAC1C,KAAK,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC;gBACd,IAAI,WAAW,KAAK,IAAI,EAAE,CAAC;oBACzB,OAAO,EAAE,KAAK,EAAE,EAAE,EAAE,CAAC;gBACvB,CAAC;gBACD,OAAO;oBACL,KAAK,EAAE;wBACL;4BACE,UAAU,EAAE,CAAC,EAAE,IAAI,EAAE,CAAC,EAAE,OAAO,EAAE,WAAW,EAAE,CAAC,EAAE,CAAC;yBACnD;qBACF;iBACF,CAAC;YACJ,CAAC,CAAC;SACH;KACF,CAAC;AACJ,CAAC;AAED,QAAQ,CAAC,6BAA6B,EAAE,GAAG,EAAE;IAC3C,UAAU,CAAC,GAAG,EAAE;QACd,iBAAiB,EAAE,CAAC;IACtB,CAAC,CAAC,CAAC;IAEH,SAAS,CAAC,GAAG,EAAE;QACb,EAAE,CAAC,eAAe,EAAE,CAAC;IACvB,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,6CAA6C,EAAE,KAAK,IAAI,EAAE;QAC3D,MAAM,KAAK,GAAa,EAAE,CAAC;QAC3B,MAAM,MAAM,GAAG,iBAAiB,CAAC,EAAE,EAAE,KAAK,CAAC,CAAC;QAE5C,MAAM,SAAS,CAAC,MAAM,EAAE,QAAQ,EAAE,gBAAgB,EAAE,SAAS,EAAE,CAAC,CAAC,CAAC;QAClE,MAAM,CAAC,iBAAiB,EAAE,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC;QAEpC,iBAAiB,EAAE,CAAC;QACpB,MAAM,CAAC,iBAAiB,EAAE,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC;IACtC,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,sDAAsD,EAAE,KAAK,IAAI,EAAE;QACpE,MAAM,KAAK,GAAa,EAAE,CAAC;QAC3B,MAAM,MAAM,GAAG,iBAAiB,CAAC,EAAE,EAAE,KAAK,CAAC,CAAC;QAE5C,MAAM,SAAS,CAAC,MAAM,EAAE,QAAQ,EAAE,gBAAgB,EAAE,SAAS,EAAE,CAAC,CAAC,CAAC;QAClE,MAAM,SAAS,CAAC,MAAM,EAAE,QAAQ,EAAE,gBAAgB,EAAE,SAAS,EAAE,CAAC,CAAC,CAAC;QAElE,MAAM,CAAC,KAAK,CAAC,MAAM,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC;IAC/B,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,kEAAkE,EAAE,KAAK,IAAI,EAAE;QAChF,MAAM,KAAK,GAAa,EAAE,CAAC;QAC3B,MAAM,MAAM,GAAG,iBAAiB,CAAC,CAAC,EAAE,KAAK,CAAC,CAAC;QAE3C,MAAM,OAAO,CAAC,GAAG,CAAC;YAChB,SAAS,CAAC,MAAM,EAAE,QAAQ,EAAE,kBAAkB,EAAE,SAAS,EAAE,EAAE,CAAC;YAC9D,SAAS,CAAC,MAAM,EAAE,QAAQ,EAAE,kBAAkB,EAAE,SAAS,EAAE,EAAE,CAAC;YAC9D,SAAS,CAAC,MAAM,EAAE,QAAQ,EAAE,kBAAkB,EAAE,SAAS,EAAE,EAAE,CAAC;SAC/D,CAAC,CAAC;QAEH,MAAM,CAAC,KAAK,CAAC,MAAM,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC;IAC/B,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,iDAAiD,EAAE,KAAK,IAAI,EAAE;QAC/D,MAAM,KAAK,GAAa,EAAE,CAAC;QAC3B,MAAM,MAAM,GAAG,iBAAiB,CAAC,CAAC,EAAE,KAAK,CAAC,CAAC;QAE3C,MAAM,SAAS,CAAC,MAAM,EAAE,QAAQ,EAAE,gBAAgB,EAAE,SAAS,EAAE,CAAC,CAAC,CAAC;QAClE,MAAM,SAAS,CAAC,MAAM,EAAE,QAAQ,EAAE,gBAAgB,EAAE,SAAS,EAAE,CAAC,CAAC,CAAC;QAElE,MAAM,CAAC,KAAK,CAAC,MAAM,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC;IAC/B,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,2EAA2E,EAAE,KAAK,IAAI,EAAE;QACzF,MAAM,KAAK,GAAa,EAAE,CAAC;QAC3B,MAAM,MAAM,GAAG,iBAAiB,CAAC,IAAI,EAAE,KAAK,CAAC,CAAC;QAE9C,MAAM,KAAK,GAAG,MAAM,SAAS,CAC3B,MAAM,EACN,QAAQ,EACR,gBAAgB,EAChB,SAAS,EACT,CAAC,CACF,CAAC;QACF,MAAM,MAAM,GAAG,MAAM,SAAS,CAC5B,MAAM,EACN,QAAQ,EACR,gBAAgB,EAChB,SAAS,EACT,CAAC,CACF,CAAC;QAEF,MAAM,CAAC,KAAK,CAAC,CAAC,QAAQ,EAAE,CAAC;QACzB,MAAM,CAAC,MAAM,CAAC,CAAC,QAAQ,EAAE,CAAC;QAC1B,MAAM,CAAC,KAAK,CAAC,MAAM,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC;IAC/B,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,oDAAoD,EAAE,KAAK,IAAI,EAAE;QAClE,MAAM,KAAK,GAAa,EAAE,CAAC;QAC3B,MAAM,MAAM,GAAG,wBAAwB,CAAC,KAAK,CAAC,CAAC;QAE/C,MAAM,KAAK,GAAG,MAAM,SAAS,CAC3B,MAAM,EACN,QAAQ,EACR,gBAAgB,EAChB,SAAS,EACT,CAAC,CACF,CAAC;QACF,MAAM,MAAM,GAAG,MAAM,SAAS,CAC5B,MAAM,EACN,QAAQ,EACR,gBAAgB,EAChB,SAAS,EACT,CAAC,CACF,CAAC;QAEF,2DAA2D;QAC3D,MAAM,CAAC,KAAK,CAAC,CAAC,QAAQ,EAAE,CAAC;QACzB,MAAM,CAAC,MAAM,CAAC,CAAC,QAAQ,EAAE,CAAC;QAC1B,2DAA2D;QAC3D,MAAM,CAAC,KAAK,CAAC,MAAM,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC;IAC/B,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,iDAAiD,EAAE,KAAK,IAAI,EAAE;QAC/D,MAAM,KAAK,GAAa,EAAE,CAAC;QAC3B,MAAM,MAAM,GAAG,iBAAiB,CAAC,CAAC,EAAE,KAAK,CAAC,CAAC;QAE3C,MAAM,SAAS,CAAC,MAAM,EAAE,QAAQ,EAAE,gBAAgB,EAAE,SAAS,EAAE,CAAC,CAAC,CAAC;QAClE,iBAAiB,EAAE,CAAC;QACpB,MAAM,SAAS,CAAC,MAAM,EAAE,QAAQ,EAAE,gBAAgB,EAAE,SAAS,EAAE,CAAC,CAAC,CAAC;QAElE,MAAM,CAAC,KAAK,CAAC,MAAM,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC;IAC/B,CAAC,CAAC,CAAC;AACL,CAAC,CAAC,CAAC"}

package/dist/azure/analyzer.d.ts

@@ -19,17 +19,29 @@
  * existing report formats keep working untouched.
  */
 import * as armResources from "@azure/arm-resources";
-import type { AzureConfig } from "./types.js";
+import type { Finding } from "../finding.js";
+import type { AzureConfig, AzureDetailedResourceReport } from "./types.js";
 import { type AnalysisResult, type Thresholds } from "../types.js";
 import { type Analyzer, type AzureClients } from "./analyzers/index.js";
 import { type MetricsCache } from "./utils.js";
 /**
- * Analyzes resources in multiple Azure subscriptions and generates a report.
+ * Analyzes resources in every configured Azure subscription and returns
+ * the structured report.
  *
- * @param config - Azure configuration with subscription IDs and settings
- * @param format - Output format (table, json, detailed-json, or lint)
+ * Phase 1 change: this function no longer emits a report to stdout. The
+ * orchestrator returns `AzureDetailedResourceReport[]` and the caller
+ * (the CLI today, future GUI / API consumers tomorrow) chooses how to
+ * render it via `generateReport`.
+ *
+ * Each entry carries both the legacy `analysis` summary and the unified
+ * `findings: Finding[]` so consumers can pick the level of detail they
+ * need. Azure Advisor recommendations and per-resource analyzer outputs
+ * are merged into the same entry when they refer to the same resource.
+ *
+ * @param config - Azure configuration with subscription IDs and settings.
+ *                 `config.sources` controls which analyzers run.
  */
-export declare function analyzeAzureResources(config: AzureConfig, format: "detailed-json" | "json" | "lint" | "table"): Promise<void>;
+export declare function analyzeAzureResources(config: AzureConfig): Promise<AzureDetailedResourceReport[]>;
 /**
  * Analyzes a single Azure resource by dispatching it to every registered
  * analyzer that supports it. Generic checks (missing tags, location
@@ -46,4 +58,5 @@ export declare function analyzeAzureResources(config: AzureConfig, format: "deta
  * @returns Analysis result with cost risk and reason
  */
 export declare function analyzeResource(resource: armResources.GenericResource, analyzers: Analyzer[], clients: AzureClients, metricsCache: MetricsCache | undefined, preferredLocation: string, timespanDays: number, thresholds: Thresholds, verbose?: boolean): Promise<AnalysisResult>;
+export declare function shouldIncludeAdvisorFindingForTags(finding: Finding, taggedResourceIds: ReadonlySet<string>, tagFilterActive: boolean): boolean;
 //# sourceMappingURL=analyzer.d.ts.map

package/dist/azure/analyzer.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"analyzer.d.ts","sourceRoot":"","sources":["../../src/azure/analyzer.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;;;;;;;;GAmBG;AAOH,OAAO,KAAK,YAAY,MAAM,sBAAsB,CAAC;AAKrD,OAAO,KAAK,EAAE,WAAW,EAA+B,MAAM,YAAY,CAAC;AAE3E,OAAO,EACL,KAAK,cAAc,EAGnB,KAAK,UAAU,EAChB,MAAM,aAAa,CAAC;AACrB,OAAO,EACL,KAAK,QAAQ,EAEb,KAAK,YAAY,EAElB,MAAM,sBAAsB,CAAC;AAE9B,OAAO,EAAe,KAAK,YAAY,EAAE,MAAM,YAAY,CAAC;AAI5D;;;;;GAKG;AACH,wBAAsB,qBAAqB,CACzC,MAAM,EAAE,WAAW,EACnB,MAAM,EAAE,eAAe,GAAG,MAAM,GAAG,MAAM,GAAG,OAAO,iBA6GpD;AAED;;;;;;;;;;;;;;GAcG;AACH,wBAAsB,eAAe,CACnC,QAAQ,EAAE,YAAY,CAAC,eAAe,EACtC,SAAS,EAAE,QAAQ,EAAE,EACrB,OAAO,EAAE,YAAY,EACrB,YAAY,EAAE,YAAY,YAAY,EACtC,iBAAiB,EAAE,MAAM,EACzB,YAAY,EAAE,MAAM,EACpB,UAAU,EAAE,UAAU,EACtB,OAAO,UAAQ,GACd,OAAO,CAAC,cAAc,CAAC,CA8CzB"}
+{"version":3,"file":"analyzer.d.ts","sourceRoot":"","sources":["../../src/azure/analyzer.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;;;;;;;;GAmBG;AASH,OAAO,KAAK,YAAY,MAAM,sBAAsB,CAAC;AAKrD,OAAO,KAAK,EAAE,OAAO,EAAE,MAAM,eAAe,CAAC;AAC7C,OAAO,KAAK,EACV,WAAW,EACX,2BAA2B,EAE5B,MAAM,YAAY,CAAC;AAGpB,OAAO,EACL,KAAK,cAAc,EAInB,KAAK,UAAU,EAChB,MAAM,aAAa,CAAC;AACrB,OAAO,EACL,KAAK,QAAQ,EAEb,KAAK,YAAY,EAIlB,MAAM,sBAAsB,CAAC;AAC9B,OAAO,EAAe,KAAK,YAAY,EAAE,MAAM,YAAY,CAAC;AAO5D;;;;;;;;;;;;;;;;GAgBG;AACH,wBAAsB,qBAAqB,CACzC,MAAM,EAAE,WAAW,GAClB,OAAO,CAAC,2BAA2B,EAAE,CAAC,CA4GxC;AAED;;;;;;;;;;;;;;GAcG;AACH,wBAAsB,eAAe,CACnC,QAAQ,EAAE,YAAY,CAAC,eAAe,EACtC,SAAS,EAAE,QAAQ,EAAE,EACrB,OAAO,EAAE,YAAY,EACrB,YAAY,EAAE,YAAY,YAAY,EACtC,iBAAiB,EAAE,MAAM,EACzB,YAAY,EAAE,MAAM,EACpB,UAAU,EAAE,UAAU,EACtB,OAAO,UAAQ,GACd,OAAO,CAAC,cAAc,CAAC,CA8CzB;AAED,wBAAgB,kCAAkC,CAChD,OAAO,EAAE,OAAO,EAChB,iBAAiB,EAAE,WAAW,CAAC,MAAM,CAAC,EACtC,eAAe,EAAE,OAAO,GACvB,OAAO,CAYT"}

package/dist/azure/analyzer.js

@@ -27,22 +27,41 @@ import * as armResources from "@azure/arm-resources";
 import { DefaultAzureCredential } from "@azure/identity";
 import { getLogger } from "@logtape/logtape";
 import pLimit from "p-limit";
+import { findingsFromAnalysisResult } from "../finding.js";
 import { DEFAULT_THRESHOLDS, mergeResults, } from "../types.js";
-import { createDefaultAnalyzers, } from "./analyzers/index.js";
-import { generateReport } from "./report.js";
+import { createDefaultAnalyzers, createDefaultSubscriptionAnalyzers, } from "./analyzers/index.js";
 import { matchesTags } from "./utils.js";
 const DEFAULT_CONCURRENCY = 8;
+const DEFAULT_SOURCES = ["advisor", "custom"];
+const RISK_ORDER = { high: 0, low: 2, medium: 1 };
 /**
- * Analyzes resources in multiple Azure subscriptions and generates a report.
+ * Analyzes resources in every configured Azure subscription and returns
+ * the structured report.
  *
- * @param config - Azure configuration with subscription IDs and settings
- * @param format - Output format (table, json, detailed-json, or lint)
+ * Phase 1 change: this function no longer emits a report to stdout. The
+ * orchestrator returns `AzureDetailedResourceReport[]` and the caller
+ * (the CLI today, future GUI / API consumers tomorrow) chooses how to
+ * render it via `generateReport`.
+ *
+ * Each entry carries both the legacy `analysis` summary and the unified
+ * `findings: Finding[]` so consumers can pick the level of detail they
+ * need. Azure Advisor recommendations and per-resource analyzer outputs
+ * are merged into the same entry when they refer to the same resource.
+ *
+ * @param config - Azure configuration with subscription IDs and settings.
+ *                 `config.sources` controls which analyzers run.
  */
-export async function analyzeAzureResources(config, format) {
+export async function analyzeAzureResources(config) {
     const logger = getLogger(["savemoney", "azure"]);
     const credential = new DefaultAzureCredential();
     const allReports = [];
+    const sources = config.sources ?? DEFAULT_SOURCES;
+    const customEnabled = sources.includes("custom");
+    const advisorEnabled = sources.includes("advisor");
     const analyzers = createDefaultAnalyzers();
+    const subscriptionAnalyzers = advisorEnabled
+        ? createDefaultSubscriptionAnalyzers()
+        : [];
     const thresholds = config.thresholds ?? DEFAULT_THRESHOLDS;
     // Normalise concurrency the same way p-limit does to keep maxInFlight
     // consistent. A raw value of 0/NaN would produce maxInFlight = 0/NaN and
@@ -58,6 +77,11 @@ export async function analyzeAzureResources(config, format) {
     for (const subscriptionId of config.subscriptionIds) {
         logger.info(`Analyzing subscription: ${subscriptionId}`);
         const sid = subscriptionId.trim();
+        // Per-subscription index keyed by lowercased resourceId so subscription-
+        // level analyzers (Advisor, future quotas, …) can merge their findings
+        // back into the matching resource report.
+        const reportsById = new Map();
+        const taggedResourceIds = new Set();
         // Fresh cache per subscription — bounds peak memory to one subscription's
         // worth of metrics and keeps concurrent analyzeAzureResources calls isolated.
         const runCache = new Map();
@@ -68,56 +92,60 @@ export async function analyzeAzureResources(config, format) {
             network: new NetworkManagementClient(credential, sid),
             webSite: new WebSiteManagementClient(credential, sid),
         };
-        const resourceClient = new armResources.ResourceManagementClient(credential, sid);
-        const inFlight = new Set();
-        // Use the async iterator to avoid loading all resources into memory at once.
-        for await (const resource of resourceClient.resources.list()) {
-            if (!matchesTags(resource, config.filterTags)) {
-                continue;
-            }
-            // Backpressure: wait for a slot before enqueuing the next task so that
-            // the inFlight Set stays bounded by maxInFlight instead of growing to the
-            // total resource count in the subscription.
-            while (inFlight.size >= maxInFlight) {
-                await Promise.race(inFlight).catch(() => undefined);
-            }
-            const task = limit(async () => {
-                const { costRisk, reason, suspectedUnused } = await analyzeResource(resource, analyzers, clients, runCache, config.preferredLocation, config.timespanDays, thresholds, config.verbose || false);
-                if (suspectedUnused) {
-                    allReports.push({
-                        analysis: {
-                            costRisk,
-                            reason: reason || "No specific findings.",
-                            suspectedUnused,
-                        },
-                        resource,
-                    });
-                }
+        if (customEnabled) {
+            await runPerResourceAnalysis({
+                analyzers,
+                clients,
+                config,
+                credential,
+                limit,
+                logger,
+                maxInFlight,
+                reports: allReports,
+                reportsById,
+                runCache,
+                sid,
+                taggedResourceIds,
+                thresholds,
             });
-            inFlight.add(task);
-            // Suppress the unhandled-rejection that would occur between task creation
-            // and the Promise.allSettled drain below. The .catch() handler is a no-op
-            // because the actual error is still visible to allSettled (which logs it)
-            // via the original `task` reference kept in inFlight.
-            void task.catch(() => undefined).finally(() => inFlight.delete(task));
         }
-        // Drain remaining tasks; surface any unexpected errors so they don't
-        // disappear silently and produce an incomplete report without a signal.
-        const results = await Promise.allSettled(inFlight);
-        for (const result of results) {
-            if (result.status === "rejected") {
-                logger.error(`Resource analysis failed: ${String(result.reason)}`);
-            }
+        if (!customEnabled && advisorEnabled && hasTagFilter(config.filterTags)) {
+            await collectTaggedResourceIds({
+                config,
+                credential,
+                sid,
+                taggedResourceIds,
+            });
+        }
+        if (advisorEnabled && subscriptionAnalyzers.length > 0) {
+            await runSubscriptionAnalyzers({
+                analyzers: subscriptionAnalyzers,
+                credential,
+                logger,
+                reports: allReports,
+                reportsById,
+                sid,
+                tagFilterActive: hasTagFilter(config.filterTags),
+                taggedResourceIds,
+                verbose: config.verbose ?? false,
+            });
         }
     }
-    // Sort to make the output more readable
+    // Sort to make the output more readable:
+    //  - Subscription-scoped findings (Reserved Instances, savings plans, ...)
+    //    sink to the bottom: they aggregate many recommendations into a single
+    //    fat row and are easier to consume after the per-resource rows.
+    //  - Within each group, sort by cost risk then by resource name.
     allReports.sort((a, b) => {
+        const aSub = isSubscriptionScopedReport(a);
+        const bSub = isSubscriptionScopedReport(b);
+        if (aSub !== bSub)
+            return aSub ? 1 : -1;
         if (a.analysis.costRisk === b.analysis.costRisk)
             return (a.resource.name ?? "").localeCompare(b.resource.name ?? "");
-        const order = { high: 0, low: 2, medium: 1 };
-        return order[a.analysis.costRisk] - order[b.analysis.costRisk];
+        return RISK_ORDER[a.analysis.costRisk] - RISK_ORDER[b.analysis.costRisk];
     });
-    await generateReport(allReports, format);
+    return allReports;
 }
 /**
  * Analyzes a single Azure resource by dispatching it to every registered
@@ -173,4 +201,223 @@ export async function analyzeResource(resource, analyzers, clients, metricsCache
     }
     return { ...result, reason: result.reason.trim() };
 }
+export function shouldIncludeAdvisorFindingForTags(finding, taggedResourceIds, tagFilterActive) {
+    if (!tagFilterActive) {
+        return true;
+    }
+    if (finding.source !== "advisor") {
+        return true;
+    }
+    if (!isResourceScopedFinding(finding.resourceId)) {
+        // Subscription-level findings are intentionally always global.
+        return true;
+    }
+    return taggedResourceIds.has(normalizeResourceId(finding.resourceId));
+}
+/**
+ * Derives a legacy `AnalysisResult` summary from a `Finding`, so the
+ * existing report formats keep working untouched on Advisor-only
+ * resources.
+ */
+function analysisFromFinding(finding) {
+    const trimmed = finding.reason.trim();
+    const reason = trimmed.endsWith(".") ? trimmed : `${trimmed}.`;
+    return {
+        costRisk: finding.severity,
+        reason,
+        suspectedUnused: true,
+    };
+}
+/**
+ * Builds a minimal `GenericResource` from a resource ID. Used when a
+ * subscription-level analyzer surfaces a resource the per-resource pass
+ * did not see — we have neither tags nor location, but `name` and `type`
+ * can be parsed deterministically from the resource ID structure.
+ *
+ * Handles three shapes:
+ *  - Fully qualified: /subscriptions/{sub}/resourceGroups/{rg}/providers/{provider}/{type}/{name}
+ *  - Resource-group-scoped: /subscriptions/{sub}/resourceGroups/{rg}
+ *  - Subscription-scoped: /subscriptions/{sub}
+ */
+function buildResourceStub(resourceId) {
+    const parts = resourceId.split("/").filter((s) => s.length > 0);
+    const providersIdx = parts.indexOf("providers");
+    if (providersIdx >= 0 && parts.length > providersIdx + 2) {
+        // Fully qualified resource ID.
+        const provider = parts[providersIdx + 1];
+        const tail = parts.slice(providersIdx + 2); // [type, name, subtype, subname, ...]
+        const typeSegments = [provider];
+        for (let i = 0; i < tail.length; i += 2) {
+            typeSegments.push(tail[i]);
+        }
+        return {
+            id: resourceId,
+            name: tail[tail.length - 1],
+            type: typeSegments.join("/"),
+        };
+    }
+    const rgIdx = parts.indexOf("resourceGroups");
+    if (rgIdx >= 0 && parts.length > rgIdx + 1) {
+        // Resource-group-scoped ID.
+        return {
+            id: resourceId,
+            name: parts[rgIdx + 1],
+            type: "Microsoft.Resources/resourceGroups",
+        };
+    }
+    const subIdx = parts.indexOf("subscriptions");
+    if (subIdx >= 0 && parts.length > subIdx + 1) {
+        // Subscription-scoped ID (e.g. Reserved Instance recommendations).
+        return {
+            id: resourceId,
+            name: parts[subIdx + 1],
+            type: "Microsoft.Subscription",
+        };
+    }
+    // Fallback for completely unknown shapes.
+    return { id: resourceId, name: parts[parts.length - 1], type: undefined };
+}
+async function collectTaggedResourceIds(args) {
+    const { config, credential, sid, taggedResourceIds } = args;
+    const resourceClient = new armResources.ResourceManagementClient(credential, sid);
+    for await (const resource of resourceClient.resources.list()) {
+        if (!matchesTags(resource, config.filterTags)) {
+            continue;
+        }
+        const resourceId = normalizeResourceId(resource.id);
+        if (resourceId) {
+            taggedResourceIds.add(resourceId);
+        }
+    }
+}
+function hasTagFilter(filterTags) {
+    return Boolean(filterTags && filterTags.size > 0);
+}
+function isResourceScopedFinding(resourceId) {
+    return /\/providers\//i.test(resourceId);
+}
+function isSubscriptionScopedReport(r) {
+    return r.resource.type === "Microsoft.Subscription";
+}
+/**
+ * Inserts a `Finding` into the right report entry, creating a stub
+ * resource entry on the fly when the finding refers to a resource that
+ * the per-resource pass did not analyze.
+ */
+function mergeFinding(finding, reports, reportsById) {
+    const idKey = finding.resourceId.toLowerCase();
+    const existing = reportsById.get(idKey);
+    if (existing) {
+        existing.findings = [...(existing.findings ?? []), finding];
+        const added = analysisFromFinding(finding);
+        // Use max costRisk (not last-wins) and join reasons with a space so we
+        // don't produce "Sentence one.Sentence two." when the existing reason is
+        // already trimmed (i.e. has no trailing separator space).
+        existing.analysis = {
+            costRisk: RISK_ORDER[existing.analysis.costRisk] <= RISK_ORDER[added.costRisk]
+                ? existing.analysis.costRisk
+                : added.costRisk,
+            reason: existing.analysis.reason && added.reason
+                ? `${existing.analysis.reason.trimEnd()} ${added.reason.trimStart()}`
+                : existing.analysis.reason || added.reason,
+            suspectedUnused: existing.analysis.suspectedUnused || added.suspectedUnused,
+        };
+        return;
+    }
+    const stub = buildResourceStub(finding.resourceId);
+    const report = {
+        analysis: analysisFromFinding(finding),
+        findings: [finding],
+        resource: stub,
+    };
+    reports.push(report);
+    reportsById.set(idKey, report);
+}
+function normalizeResourceId(resourceId) {
+    return (resourceId ?? "").trim().toLowerCase();
+}
+/**
+ * Runs the per-resource analyzer plugins against every resource in the
+ * given subscription. Extracted from `analyzeAzureResources` to keep that
+ * function readable now that subscription-level analyzers were added.
+ */
+async function runPerResourceAnalysis(args) {
+    const { analyzers, clients, config, credential, limit, logger, maxInFlight, reports, reportsById, runCache, sid, taggedResourceIds, thresholds, } = args;
+    const resourceClient = new armResources.ResourceManagementClient(credential, sid);
+    const inFlight = new Set();
+    // Use the async iterator to avoid loading all resources into memory at once.
+    for await (const resource of resourceClient.resources.list()) {
+        if (!matchesTags(resource, config.filterTags)) {
+            continue;
+        }
+        const taggedId = normalizeResourceId(resource.id);
+        if (taggedId) {
+            taggedResourceIds.add(taggedId);
+        }
+        // Backpressure: wait for a slot before enqueuing the next task so that
+        // the inFlight Set stays bounded by maxInFlight instead of growing to the
+        // total resource count in the subscription.
+        while (inFlight.size >= maxInFlight) {
+            await Promise.race(inFlight).catch(() => undefined);
+        }
+        const task = limit(async () => {
+            const analysis = await analyzeResource(resource, analyzers, clients, runCache, config.preferredLocation, config.timespanDays, thresholds, config.verbose || false);
+            if (analysis.suspectedUnused) {
+                const reason = analysis.reason || "No specific findings.";
+                const report = {
+                    analysis: { ...analysis, reason },
+                    findings: findingsFromAnalysisResult({
+                        reason,
+                        resourceId: resource.id ?? "",
+                        severity: analysis.costRisk,
+                        source: "custom",
+                    }),
+                    resource,
+                };
+                reports.push(report);
+                const idKey = (resource.id ?? "").toLowerCase();
+                if (idKey)
+                    reportsById.set(idKey, report);
+            }
+        });
+        inFlight.add(task);
+        // Suppress the unhandled-rejection that would occur between task creation
+        // and the Promise.allSettled drain below. The .catch() handler is a no-op
+        // because the actual error is still visible to allSettled (which logs it)
+        // via the original `task` reference kept in inFlight.
+        void task.catch(() => undefined).finally(() => inFlight.delete(task));
+    }
+    // Drain remaining tasks; surface any unexpected errors so they don't
+    // disappear silently and produce an incomplete report without a signal.
+    const results = await Promise.allSettled(inFlight);
+    for (const result of results) {
+        if (result.status === "rejected") {
+            logger.error(`Resource analysis failed: ${String(result.reason)}`);
+        }
+    }
+}
+/**
+ * Runs every subscription-level analyzer in parallel and merges their
+ * findings into the per-resource reports. Findings about resources that
+ * the per-resource pass did not surface (typical for Advisor, which
+ * reaches SQL DBs, Front Doors, etc.) produce new report entries with a
+ * minimal `GenericResource` stub derived from the resource ID.
+ */
+async function runSubscriptionAnalyzers(args) {
+    const { analyzers, credential, logger, reports, reportsById, sid, tagFilterActive, taggedResourceIds, verbose, } = args;
+    const allFindings = await Promise.all(analyzers.map((a) => a
+        .analyze({ credential, subscriptionId: sid, verbose })
+        .catch((err) => {
+        logger.error(`Subscription analyzer ${a.id} failed: ${String(err)}`);
+        return [];
+    })));
+    for (const findings of allFindings) {
+        for (const finding of findings) {
+            if (!shouldIncludeAdvisorFindingForTags(finding, taggedResourceIds, tagFilterActive)) {
+                continue;
+            }
+            mergeFinding(finding, reports, reportsById);
+        }
+    }
+}
 //# sourceMappingURL=analyzer.js.map