@pagopa/dx-savemoney 0.2.5 → 0.3.0

package/dist/schema.js.map

@@ -1 +1 @@
-{"version":3,"file":"schema.js","sourceRoot":"","sources":["../src/schema.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;;;;;;;GAkBG;AAEH,OAAO,EAAE,CAAC,EAAE,MAAM,KAAK,CAAC;AAExB,+EAA+E;AAE/E,MAAM,kBAAkB,GAAG,CAAC;KACzB,MAAM,CAAC;IACN,wEAAwE;IACxE,UAAU,EAAE,CAAC,CAAC,MAAM,EAAE,CAAC,OAAO,CAAC,CAAC,CAAC;IACjC,iGAAiG;IACjG,oBAAoB,EAAE,CAAC,CAAC,MAAM,EAAE,CAAC,OAAO,CAAC,IAAI,GAAG,IAAI,GAAG,CAAC,CAAC;CAC1D,CAAC;KACD,MAAM,EAAE,CAAC;AAEZ,MAAM,0BAA0B,GAAG,CAAC;KACjC,MAAM,CAAC;IACN,6EAA6E;IAC7E,UAAU,EAAE,CAAC,CAAC,MAAM,EAAE,CAAC,OAAO,CAAC,CAAC,CAAC;IACjC,iFAAiF;IACjF,aAAa,EAAE,CAAC,CAAC,MAAM,EAAE,CAAC,OAAO,CAAC,EAAE,CAAC;IACrC,qGAAqG;IACrG,iBAAiB,EAAE,CAAC,CAAC,MAAM,EAAE,CAAC,OAAO,CAAC,EAAE,CAAC;CAC1C,CAAC;KACD,MAAM,EAAE,CAAC;AAEZ,MAAM,4BAA4B,GAAG,CAAC;KACnC,MAAM,CAAC;IACN,2GAA2G;IAC3G,YAAY,EAAE,CAAC,CAAC,MAAM,EAAE,CAAC,OAAO,CAAC,SAAS,CAAC;IAC3C,wFAAwF;IACxF,WAAW,EAAE,CAAC,CAAC,MAAM,EAAE,CAAC,OAAO,CAAC,UAAU,CAAC;IAC3C,+GAA+G;IAC/G,YAAY,EAAE,CAAC,CAAC,MAAM,EAAE,CAAC,OAAO,CAAC,MAAM,CAAC;CACzC,CAAC;KACD,MAAM,EAAE,CAAC;AAEZ,MAAM,uBAAuB,GAAG,CAAC;KAC9B,MAAM,CAAC;IACN,sFAAsF;IACtF,kBAAkB,EAAE,CAAC,CAAC,MAAM,EAAE,CAAC,OAAO,CAAC,EAAE,CAAC;CAC3C,CAAC;KACD,MAAM,EAAE,CAAC;AAEZ,MAAM,wBAAwB,GAAG,CAAC;KAC/B,MAAM,CAAC;IACN,oGAAoG;IACpG,WAAW,EAAE,CAAC,CAAC,MAAM,EAAE,CAAC,OAAO,CAAC,OAAO,CAAC;CACzC,CAAC;KACD,MAAM,EAAE,CAAC;AAEZ,MAAM,0BAA0B,GAAG,CAAC;KACjC,MAAM,CAAC;IACN,uFAAuF;IACvF,SAAS,EAAE,CAAC,CAAC,MAAM,EAAE,CAAC,OAAO,CAAC,SAAS,CAAC;IACxC,+EAA+E;IAC/E,QAAQ,EAAE,CAAC,CAAC,MAAM,EAAE,CAAC,OAAO,CAAC,GAAG,CAAC;CAClC,CAAC;KACD,MAAM,EAAE,CAAC;AAEZ,gFAAgF;AAEhF,MAAM,CAAC,MAAM,gBAAgB,GAAG,CAAC;KAC9B,MAAM,CAAC;IACN,UAAU,EAAE,0BAA0B,CAAC,QAAQ,EAAE,CAAC,SAAS,CAAC,CAAC,CAAC,EAAE,EAAE,CAChE,0BAA0B,CAAC,KAAK,CAAC,CAAC,IAAI,EAAE,CAAC,CAC1C;IACD,YAAY,EAAE,4BAA4B,CAAC,QAAQ,EAAE,CAAC,SAAS,CAAC,CAAC,CAAC,EAAE,EAAE,CACpE,4BAA4B,CAAC,KAAK,CAAC,CAAC,IAAI,EAAE,CAAC,CAC5C;IACD,QAAQ,EAAE,wBAAwB,CAAC,QAAQ,EAAE,CAAC,SAAS,CAAC,CAAC,CAAC,EAAE,EAAE,CAC5D,wBAAwB,CAAC,KAAK,CAAC,CAAC,IAAI,EAAE,CAAC,CACxC;IACD,UAAU,EAAE,0BAA0B,CAAC,QAAQ,EAAE,CAAC,SAAS,CAAC,CAAC,CAAC,EAAE,EAAE,CAChE,0BAA0B,CAAC,KAAK,CAAC,CAAC,IAAI,EAAE,CAAC,CAC1C;IACD,OAAO,EAAE,uBAAuB,CAAC,QAAQ,EAAE,CAAC,SAAS,CAAC,CAAC,CAAC,EAAE,EAAE,CAC1D,uBAAuB,CAAC,KAAK,CAAC,CAAC,IAAI,EAAE,CAAC,CACvC;IACD,EAAE,EAAE,kBAAkB,CAAC,QAAQ,EAAE,CAAC,SAAS,CAAC,CAAC,CAAC,EAAE,EAAE,CAChD,kBAAkB,CAAC,KAAK,CAAC,CAAC,IAAI,EAAE,CAAC,CAClC;CACF,CAAC;KACD,MAAM,EAAE,CAAC;AAEZ,gFAAgF;AAEhF,MAAM,kBAAkB,GAAG,CAAC;KACzB,MAAM,CAAC;IACN,iBAAiB,EAAE,CAAC,CAAC,MAAM,EAAE,CAAC,OAAO,CAAC,YAAY,CAAC;IACnD,eAAe,EAAE,CAAC;SACf,KAAK,CAAC,CAAC,CAAC,MAAM,EAAE,CAAC;SACjB,GAAG,CACF,CAAC,EACD,wEAAwE,CACzE;IACH,UAAU,EAAE,gBAAgB,CAAC,QAAQ,EAAE,CAAC,SAAS,CAAC,CAAC,CAAC,EAAE,EAAE,CACtD,gBAAgB,CAAC,KAAK,CAAC,CAAC,IAAI,EAAE,CAAC,CAChC;IACD,YAAY,EAAE,CAAC,CAAC,MAAM,EAAE,CAAC,GAAG,EAAE,CAAC,QAAQ,EAAE,CAAC,OAAO,CAAC,EAAE,CAAC;CACtD,CAAC;KACD,MAAM,EAAE,CAAC;AAEZ;;;GAGG;AACH,MAAM,CAAC,MAAM,YAAY,GAAG,CAAC,CAAC,MAAM,CAAC,EAAE,KAAK,EAAE,kBAAkB,EAAE,CAAC,CAAC,MAAM,EAAE,CAAC"}
+{"version":3,"file":"schema.js","sourceRoot":"","sources":["../src/schema.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;;;;;;;GAkBG;AAEH,OAAO,EAAE,CAAC,EAAE,MAAM,KAAK,CAAC;AAExB,+EAA+E;AAE/E,MAAM,kBAAkB,GAAG,CAAC;KACzB,MAAM,CAAC;IACN,wEAAwE;IACxE,UAAU,EAAE,CAAC,CAAC,MAAM,EAAE,CAAC,OAAO,CAAC,CAAC,CAAC;IACjC,iGAAiG;IACjG,oBAAoB,EAAE,CAAC,CAAC,MAAM,EAAE,CAAC,OAAO,CAAC,IAAI,GAAG,IAAI,GAAG,CAAC,CAAC;CAC1D,CAAC;KACD,MAAM,EAAE,CAAC;AAEZ,MAAM,0BAA0B,GAAG,CAAC;KACjC,MAAM,CAAC;IACN,6EAA6E;IAC7E,UAAU,EAAE,CAAC,CAAC,MAAM,EAAE,CAAC,OAAO,CAAC,CAAC,CAAC;IACjC,iFAAiF;IACjF,aAAa,EAAE,CAAC,CAAC,MAAM,EAAE,CAAC,OAAO,CAAC,EAAE,CAAC;IACrC,qGAAqG;IACrG,iBAAiB,EAAE,CAAC,CAAC,MAAM,EAAE,CAAC,OAAO,CAAC,EAAE,CAAC;CAC1C,CAAC;KACD,MAAM,EAAE,CAAC;AAEZ,MAAM,4BAA4B,GAAG,CAAC;KACnC,MAAM,CAAC;IACN,2GAA2G;IAC3G,YAAY,EAAE,CAAC,CAAC,MAAM,EAAE,CAAC,OAAO,CAAC,SAAS,CAAC;IAC3C,wFAAwF;IACxF,WAAW,EAAE,CAAC,CAAC,MAAM,EAAE,CAAC,OAAO,CAAC,UAAU,CAAC;IAC3C,+GAA+G;IAC/G,YAAY,EAAE,CAAC,CAAC,MAAM,EAAE,CAAC,OAAO,CAAC,MAAM,CAAC;CACzC,CAAC;KACD,MAAM,EAAE,CAAC;AAEZ,MAAM,uBAAuB,GAAG,CAAC;KAC9B,MAAM,CAAC;IACN,sFAAsF;IACtF,kBAAkB,EAAE,CAAC,CAAC,MAAM,EAAE,CAAC,OAAO,CAAC,EAAE,CAAC;CAC3C,CAAC;KACD,MAAM,EAAE,CAAC;AAEZ,MAAM,wBAAwB,GAAG,CAAC;KAC/B,MAAM,CAAC;IACN,oGAAoG;IACpG,WAAW,EAAE,CAAC,CAAC,MAAM,EAAE,CAAC,OAAO,CAAC,OAAO,CAAC;CACzC,CAAC;KACD,MAAM,EAAE,CAAC;AAEZ,MAAM,0BAA0B,GAAG,CAAC;KACjC,MAAM,CAAC;IACN,uFAAuF;IACvF,SAAS,EAAE,CAAC,CAAC,MAAM,EAAE,CAAC,OAAO,CAAC,SAAS,CAAC;IACxC,+EAA+E;IAC/E,QAAQ,EAAE,CAAC,CAAC,MAAM,EAAE,CAAC,OAAO,CAAC,GAAG,CAAC;CAClC,CAAC;KACD,MAAM,EAAE,CAAC;AAEZ,gFAAgF;AAEhF,MAAM,CAAC,MAAM,gBAAgB,GAAG,CAAC;KAC9B,MAAM,CAAC;IACN,UAAU,EAAE,0BAA0B,CAAC,QAAQ,EAAE,CAAC,SAAS,CAAC,CAAC,CAAC,EAAE,EAAE,CAChE,0BAA0B,CAAC,KAAK,CAAC,CAAC,IAAI,EAAE,CAAC,CAC1C;IACD,YAAY,EAAE,4BAA4B,CAAC,QAAQ,EAAE,CAAC,SAAS,CAAC,CAAC,CAAC,EAAE,EAAE,CACpE,4BAA4B,CAAC,KAAK,CAAC,CAAC,IAAI,EAAE,CAAC,CAC5C;IACD,QAAQ,EAAE,wBAAwB,CAAC,QAAQ,EAAE,CAAC,SAAS,CAAC,CAAC,CAAC,EAAE,EAAE,CAC5D,wBAAwB,CAAC,KAAK,CAAC,CAAC,IAAI,EAAE,CAAC,CACxC;IACD,UAAU,EAAE,0BAA0B,CAAC,QAAQ,EAAE,CAAC,SAAS,CAAC,CAAC,CAAC,EAAE,EAAE,CAChE,0BAA0B,CAAC,KAAK,CAAC,CAAC,IAAI,EAAE,CAAC,CAC1C;IACD,OAAO,EAAE,uBAAuB,CAAC,QAAQ,EAAE,CAAC,SAAS,CAAC,CAAC,CAAC,EAAE,EAAE,CAC1D,uBAAuB,CAAC,KAAK,CAAC,CAAC,IAAI,EAAE,CAAC,CACvC;IACD,EAAE,EAAE,kBAAkB,CAAC,QAAQ,EAAE,CAAC,SAAS,CAAC,CAAC,CAAC,EAAE,EAAE,CAChD,kBAAkB,CAAC,KAAK,CAAC,CAAC,IAAI,EAAE,CAAC,CAClC;CACF,CAAC;KACD,MAAM,EAAE,CAAC;AAEZ,gFAAgF;AAEhF,MAAM,kBAAkB,GAAG,CAAC;KACzB,MAAM,CAAC;IACN;;;OAGG;IACH,WAAW,EAAE,CAAC,CAAC,MAAM,EAAE,CAAC,GAAG,EAAE,CAAC,QAAQ,EAAE,CAAC,QAAQ,EAAE;IACnD,iBAAiB,EAAE,CAAC,CAAC,MAAM,EAAE,CAAC,OAAO,CAAC,YAAY,CAAC;IACnD;;;;OAIG;IACH,OAAO,EAAE,CAAC;SACP,KAAK,CAAC,CAAC,CAAC,IAAI,CAAC,CAAC,SAAS,EAAE,QAAQ,CAAC,CAAC,CAAC;SACpC,QAAQ,EAAE;SACV,OAAO,CAAC,CAAC,SAAS,EAAE,QAAQ,CAAC,CAAC;IACjC,eAAe,EAAE,CAAC;SACf,KAAK,CAAC,CAAC,CAAC,MAAM,EAAE,CAAC;SACjB,GAAG,CACF,CAAC,EACD,wEAAwE,CACzE;IACH,UAAU,EAAE,gBAAgB,CAAC,QAAQ,EAAE,CAAC,SAAS,CAAC,CAAC,CAAC,EAAE,EAAE,CACtD,gBAAgB,CAAC,KAAK,CAAC,CAAC,IAAI,EAAE,CAAC,CAChC;IACD,YAAY,EAAE,CAAC,CAAC,MAAM,EAAE,CAAC,GAAG,EAAE,CAAC,QAAQ,EAAE,CAAC,OAAO,CAAC,EAAE,CAAC;CACtD,CAAC;KACD,MAAM,EAAE,CAAC;AAEZ;;;GAGG;AACH,MAAM,CAAC,MAAM,YAAY,GAAG,CAAC,CAAC,MAAM,CAAC,EAAE,KAAK,EAAE,kBAAkB,EAAE,CAAC,CAAC,MAAM,EAAE,CAAC"}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pagopa/dx-savemoney",
-  "version": "0.2.5",
+  "version": "0.3.0",
   "type": "module",
   "description": "Azure resource analyzer for finding unused or cost-inefficient resources.",
   "repository": {
@@ -27,6 +27,7 @@
     "DX"
   ],
   "dependencies": {
+    "@azure/arm-advisor": "^3.2.0",
     "@azure/arm-appcontainers": "^3.0.0",
     "@azure/arm-appservice": "^17.0.0",
     "@azure/arm-compute": "^23.3.0",
@@ -35,7 +36,9 @@
     "@azure/arm-resources": "^7.0.0",
     "@azure/identity": "^4.13.1",
     "@logtape/logtape": "^1.3.8",
+    "cli-table3": "^0.6.5",
     "js-yaml": "^4.1.1",
+    "p-limit": "^7.3.0",
     "zod": "^4.4.2"
   },
   "devDependencies": {

package/src/__tests__/finding.test.ts

@@ -0,0 +1,149 @@
+/**
+ * Tests for findingsFromAnalysisResult — verifies the adapter that converts
+ * a legacy `AnalysisResult.reason` string into a structured `Finding[]`.
+ *
+ * Behaviours covered:
+ * 1. Empty / whitespace-only reason → empty array.
+ * 2. Single sentence (with or without trailing period) → one finding.
+ * 3. Multi-sentence reason (". " separator) → one finding per sentence.
+ * 4. Trailing period on the whole string → not duplicated.
+ * 5. Custom `code` → propagated to every finding.
+ * 6. Omitted `code` → defaults to "custom.unknown".
+ * 7. Custom `source` → propagated.
+ * 8. Omitted `source` → defaults to "custom".
+ * 9. Every finding carries the correct `resourceId`, `severity`, `category`.
+ */
+
+import { describe, expect, it } from "vitest";
+
+import { findingsFromAnalysisResult } from "../finding.js";
+
+const BASE_ARGS = {
+  reason: "Low CPU usage.",
+  resourceId:
+    "/subscriptions/sub1/resourceGroups/rg/providers/Microsoft.Compute/virtualMachines/vm",
+  severity: "high" as const,
+};
+
+describe("findingsFromAnalysisResult", () => {
+  describe("empty / whitespace input", () => {
+    it("returns [] for an empty string", () => {
+      expect(findingsFromAnalysisResult({ ...BASE_ARGS, reason: "" })).toEqual(
+        [],
+      );
+    });
+
+    it("returns [] for a whitespace-only string", () => {
+      expect(
+        findingsFromAnalysisResult({ ...BASE_ARGS, reason: "   " }),
+      ).toEqual([]);
+    });
+
+    it("returns [] for a bare period", () => {
+      expect(findingsFromAnalysisResult({ ...BASE_ARGS, reason: "." })).toEqual(
+        [],
+      );
+    });
+  });
+
+  describe("single sentence", () => {
+    it("returns one finding with a trailing period", () => {
+      const result = findingsFromAnalysisResult({
+        ...BASE_ARGS,
+        reason: "VM is deallocated.",
+      });
+      expect(result).toHaveLength(1);
+      expect(result[0].reason).toBe("VM is deallocated.");
+    });
+
+    it("appends a trailing period when missing", () => {
+      const result = findingsFromAnalysisResult({
+        ...BASE_ARGS,
+        reason: "VM is deallocated",
+      });
+      expect(result).toHaveLength(1);
+      expect(result[0].reason).toBe("VM is deallocated.");
+    });
+  });
+
+  describe("multi-sentence reason", () => {
+    it("splits on '. ' into separate findings", () => {
+      const result = findingsFromAnalysisResult({
+        ...BASE_ARGS,
+        reason: "VM is deallocated. No tags found. Low CPU usage.",
+      });
+      expect(result).toHaveLength(3);
+      expect(result[0].reason).toBe("VM is deallocated.");
+      expect(result[1].reason).toBe("No tags found.");
+      expect(result[2].reason).toBe("Low CPU usage.");
+    });
+
+    it("does not create an extra empty finding for a trailing period", () => {
+      const result = findingsFromAnalysisResult({
+        ...BASE_ARGS,
+        reason: "Sentence one. Sentence two.",
+      });
+      expect(result).toHaveLength(2);
+    });
+  });
+
+  describe("code field", () => {
+    it("uses the provided code for every finding", () => {
+      const result = findingsFromAnalysisResult({
+        ...BASE_ARGS,
+        code: "vm.deallocated",
+        reason: "A. B.",
+      });
+      expect(result.every((f) => f.code === "vm.deallocated")).toBe(true);
+    });
+
+    it("defaults code to 'custom.unknown' when omitted", () => {
+      const result = findingsFromAnalysisResult(BASE_ARGS);
+      expect(result[0].code).toBe("custom.unknown");
+    });
+  });
+
+  describe("source field", () => {
+    it("uses the provided source for every finding", () => {
+      const result = findingsFromAnalysisResult({
+        ...BASE_ARGS,
+        source: "advisor",
+      });
+      expect(result.every((f) => f.source === "advisor")).toBe(true);
+    });
+
+    it("defaults source to 'custom' when omitted", () => {
+      const result = findingsFromAnalysisResult(BASE_ARGS);
+      expect(result[0].source).toBe("custom");
+    });
+  });
+
+  describe("static fields on every finding", () => {
+    it("propagates resourceId to every finding", () => {
+      const result = findingsFromAnalysisResult({
+        ...BASE_ARGS,
+        reason: "A. B.",
+      });
+      expect(result.every((f) => f.resourceId === BASE_ARGS.resourceId)).toBe(
+        true,
+      );
+    });
+
+    it("propagates severity to every finding", () => {
+      const result = findingsFromAnalysisResult({
+        ...BASE_ARGS,
+        reason: "A. B.",
+        severity: "medium",
+      });
+      expect(result.every((f) => f.severity === "medium")).toBe(true);
+    });
+
+    it("sets category to 'cost' on every finding", () => {
+      const result = findingsFromAnalysisResult({
+        ...BASE_ARGS,
+        reason: "A. B.",
+      });
+      expect(result.every((f) => f.category === "cost")).toBe(true);
+    });
+  });
+});

package/src/azure/__tests__/analyzer-tags.test.ts

@@ -0,0 +1,74 @@
+/**
+ * Unit tests for tag-filter behavior on Advisor findings.
+ *
+ * These tests exercise the pure helper used by the Azure analyzer
+ * orchestrator to keep filtering semantics explicit and stable.
+ */
+
+import { describe, expect, it } from "vitest";
+
+import type { Finding } from "../../finding.js";
+
+import { shouldIncludeAdvisorFindingForTags } from "../analyzer.js";
+
+function mkFinding(resourceId: string, source: Finding["source"]): Finding {
+  return {
+    category: "cost",
+    code: `${source}.test`,
+    reason: "Test finding.",
+    resourceId,
+    severity: "low",
+    source,
+  };
+}
+
+describe("shouldIncludeAdvisorFindingForTags", () => {
+  it("includes all findings when no tag filter is active", () => {
+    const finding = mkFinding(
+      "/subscriptions/sub1/resourceGroups/rg1/providers/Microsoft.Compute/virtualMachines/vm1",
+      "advisor",
+    );
+
+    expect(
+      shouldIncludeAdvisorFindingForTags(finding, new Set<string>(), false),
+    ).toBe(true);
+  });
+
+  it("keeps subscription-level Advisor findings global even with tag filters", () => {
+    const finding = mkFinding("/subscriptions/sub1", "advisor");
+
+    expect(
+      shouldIncludeAdvisorFindingForTags(finding, new Set<string>(), true),
+    ).toBe(true);
+  });
+
+  it("includes resource-level Advisor findings only when resource id is tag-matched", () => {
+    const finding = mkFinding(
+      "/subscriptions/sub1/resourceGroups/rg1/providers/Microsoft.Compute/virtualMachines/vm1",
+      "advisor",
+    );
+
+    const taggedResourceIds = new Set<string>([
+      "/subscriptions/sub1/resourcegroups/rg1/providers/microsoft.compute/virtualmachines/vm1",
+    ]);
+
+    expect(
+      shouldIncludeAdvisorFindingForTags(finding, taggedResourceIds, true),
+    ).toBe(true);
+  });
+
+  it("excludes resource-level Advisor findings when resource id is not tag-matched", () => {
+    const finding = mkFinding(
+      "/subscriptions/sub1/resourceGroups/rg1/providers/Microsoft.Compute/virtualMachines/vm2",
+      "advisor",
+    );
+
+    const taggedResourceIds = new Set<string>([
+      "/subscriptions/sub1/resourcegroups/rg1/providers/microsoft.compute/virtualmachines/vm1",
+    ]);
+
+    expect(
+      shouldIncludeAdvisorFindingForTags(finding, taggedResourceIds, true),
+    ).toBe(false);
+  });
+});

package/src/azure/__tests__/report.test.ts

@@ -136,3 +136,30 @@ describe("generateReport — lint format", () => {
     expect(calls[0]).toContain("0 issues found");
   });
 });
+
+describe("generateReport — table format", () => {
+  let logSpy: ReturnType<typeof vi.spyOn>;
+
+  beforeEach(() => {
+    logSpy = vi.spyOn(console, "log").mockImplementation(() => undefined);
+  });
+
+  afterEach(() => {
+    vi.restoreAllMocks();
+  });
+
+  it("renders without throwing for an empty report", async () => {
+    await expect(generateReport([], "table")).resolves.toBeUndefined();
+    // Table is always printed; the summary line ("0 issues found") follows.
+    expect(logSpy.mock.calls.length).toBeGreaterThanOrEqual(1);
+    const output = logSpy.mock.calls.map((c) => String(c[0])).join("\n");
+    expect(output).toContain("0 issues found");
+  });
+
+  it("includes resource name and reason in the rendered table", async () => {
+    await generateReport([HIGH_ENTRY], "table");
+    const output = logSpy.mock.calls.map((c) => String(c[0])).join("\n");
+    expect(output).toContain("vm-high");
+    expect(output).toContain("VM is deallocated");
+  });
+});

package/src/azure/__tests__/utils.test.ts

@@ -5,13 +5,24 @@
  * 3. Key missing on resource → exclude.
  * 4. Key present but wrong value → exclude.
  * 5. Multiple tags: all match → include; any mismatch → exclude.
+ *
+ * Tests for getMetric() cache behaviour:
+ * 6. resetMetricsCache() clears state between runs.
+ * 7. Concurrent calls for the same key coalesce into one network call.
+ * 8. A failed call is cached as a fulfilled null result (not retried silently).
  */
 
 import type { GenericResource } from "@azure/arm-resources";
 
-import { describe, expect, it } from "vitest";
+import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
 
-import { matchesTags } from "../utils.js";
+import {
+  _metricsCacheSize,
+  getMetric,
+  matchesTags,
+  type MonitorClientLike,
+  resetMetricsCache,
+} from "../utils.js";
 
 function makeResource(tags?: Record<string, string>): GenericResource {
   return { id: "r1", name: "res", tags };
@@ -122,3 +133,154 @@ describe("matchesTags", () => {
     });
   });
 });
+
+// ── metrics cache ──────────────────────────────────────────────────────────
+
+function makeFailingMonitorClient(calls: number[] = []): MonitorClientLike {
+  return {
+    metrics: {
+      list: vi.fn().mockImplementation(async () => {
+        calls.push(1);
+        throw new Error("network error");
+      }),
+    },
+  };
+}
+
+function makeMonitorClient(
+  returnValue: null | number,
+  calls: number[] = [],
+): MonitorClientLike {
+  return {
+    metrics: {
+      list: vi.fn().mockImplementation(async () => {
+        calls.push(1);
+        if (returnValue === null) {
+          return { value: [] };
+        }
+        return {
+          value: [
+            {
+              timeseries: [{ data: [{ average: returnValue }] }],
+            },
+          ],
+        };
+      }),
+    },
+  };
+}
+
+describe("getMetric — in-memory cache", () => {
+  beforeEach(() => {
+    resetMetricsCache();
+  });
+
+  afterEach(() => {
+    vi.restoreAllMocks();
+  });
+
+  it("resetMetricsCache clears all cached entries", async () => {
+    const calls: number[] = [];
+    const client = makeMonitorClient(42, calls);
+
+    await getMetric(client, "/res/1", "Percentage CPU", "Average", 7);
+    expect(_metricsCacheSize()).toBe(1);
+
+    resetMetricsCache();
+    expect(_metricsCacheSize()).toBe(0);
+  });
+
+  it("does not call the API a second time for the same key", async () => {
+    const calls: number[] = [];
+    const client = makeMonitorClient(10, calls);
+
+    await getMetric(client, "/res/1", "Percentage CPU", "Average", 7);
+    await getMetric(client, "/res/1", "Percentage CPU", "Average", 7);
+
+    expect(calls.length).toBe(1);
+  });
+
+  it("concurrent calls for the same key coalesce into one network call", async () => {
+    const calls: number[] = [];
+    const client = makeMonitorClient(5, calls);
+
+    await Promise.all([
+      getMetric(client, "/res/2", "Network In Total", "Average", 30),
+      getMetric(client, "/res/2", "Network In Total", "Average", 30),
+      getMetric(client, "/res/2", "Network In Total", "Average", 30),
+    ]);
+
+    expect(calls.length).toBe(1);
+  });
+
+  it("different keys result in separate network calls", async () => {
+    const calls: number[] = [];
+    const client = makeMonitorClient(1, calls);
+
+    await getMetric(client, "/res/a", "Percentage CPU", "Average", 7);
+    await getMetric(client, "/res/b", "Percentage CPU", "Average", 7);
+
+    expect(calls.length).toBe(2);
+  });
+
+  it("returns null and caches the null result when no data points are available", async () => {
+    const calls: number[] = [];
+    const client = makeMonitorClient(null, calls);
+
+    const first = await getMetric(
+      client,
+      "/res/3",
+      "Percentage CPU",
+      "Average",
+      7,
+    );
+    const second = await getMetric(
+      client,
+      "/res/3",
+      "Percentage CPU",
+      "Average",
+      7,
+    );
+
+    expect(first).toBeNull();
+    expect(second).toBeNull();
+    expect(calls.length).toBe(1);
+  });
+
+  it("a failing call is cached and returns null on retry", async () => {
+    const calls: number[] = [];
+    const client = makeFailingMonitorClient(calls);
+
+    const first = await getMetric(
+      client,
+      "/res/4",
+      "Percentage CPU",
+      "Average",
+      7,
+    );
+    const second = await getMetric(
+      client,
+      "/res/4",
+      "Percentage CPU",
+      "Average",
+      7,
+    );
+
+    // Both calls return null (error is swallowed by getMetric)
+    expect(first).toBeNull();
+    expect(second).toBeNull();
+    // Only one actual network call despite two getMetric calls
+    expect(calls.length).toBe(1);
+  });
+
+  it("after resetMetricsCache the API is called again", async () => {
+    const calls: number[] = [];
+    const client = makeMonitorClient(7, calls);
+
+    await getMetric(client, "/res/5", "Percentage CPU", "Average", 7);
+    resetMetricsCache();
+    await getMetric(client, "/res/5", "Percentage CPU", "Average", 7);
+
+    expect(calls.length).toBe(2);
+  });
+});