@pagopa/dx-cli 0.22.4 → 0.23.1

package/dist/domain/__tests__/info.test.js

@@ -1,77 +0,0 @@
-import { errAsync, okAsync } from "neverthrow";
-import { describe, expect, it } from "vitest";
-import { getInfo } from "../info.js";
-import { makeMockDependencies, makeMockPackageJson, makeMockRepositoryRoot, } from "./data.js";
-describe("getInfo", () => {
-    describe("packageManager", () => {
-        it("should return default packageManager (npm) when packageManager is not detected", async () => {
-            const mockPackageJson = makeMockPackageJson({
-                packageManager: undefined,
-            });
-            const mockDependencies = makeMockDependencies();
-            const repositoryRoot = makeMockRepositoryRoot();
-            mockDependencies.repositoryReader.findRepositoryRoot.mockReturnValue(okAsync(repositoryRoot));
-            mockDependencies.packageJsonReader.readPackageJson.mockReturnValue(okAsync(mockPackageJson));
-            mockDependencies.repositoryReader.fileExists.mockReturnValue(okAsync(false));
-            mockDependencies.repositoryReader.readFile.mockReturnValue(okAsync("22.0.0"));
-            const result = await getInfo(mockDependencies)();
-            expect(result.packageManager).toStrictEqual("npm");
-            expect(mockDependencies.repositoryReader.fileExists).nthCalledWith(1, "a/repo/root/pnpm-lock.yaml");
-            expect(mockDependencies.repositoryReader.fileExists).nthCalledWith(2, "a/repo/root/yarn.lock");
-            expect(mockDependencies.repositoryReader.fileExists).nthCalledWith(3, "a/repo/root/package-lock.json");
-        });
-        it("should return yarn when yarn.lock is present", async () => {
-            const mockPackageJson = makeMockPackageJson({
-                packageManager: undefined,
-            });
-            const mockDependencies = makeMockDependencies();
-            mockDependencies.packageJsonReader.readPackageJson.mockReturnValue(okAsync(mockPackageJson));
-            mockDependencies.repositoryReader.fileExists
-                .mockReturnValueOnce(okAsync(false))
-                .mockReturnValueOnce(okAsync(true)); // yarn lock file exists
-            mockDependencies.repositoryReader.readFile.mockReturnValue(okAsync("22.0.0"));
-            const repositoryRoot = makeMockRepositoryRoot();
-            mockDependencies.repositoryReader.findRepositoryRoot.mockReturnValue(okAsync(repositoryRoot));
-            const result = await getInfo(mockDependencies)();
-            expect(result.packageManager).toStrictEqual("yarn");
-            expect(mockDependencies.repositoryReader.fileExists).nthCalledWith(1, "a/repo/root/pnpm-lock.yaml");
-            expect(mockDependencies.repositoryReader.fileExists).nthCalledWith(2, "a/repo/root/yarn.lock");
-            expect(mockDependencies.repositoryReader.fileExists).not.toHaveBeenCalledWith("a/repo/root/package-lock.json");
-        });
-    });
-    it("should return all info", async () => {
-        const mockPackageJson = makeMockPackageJson({
-            devDependencies: new Map([["turbo", "^2.5.0"]]),
-        });
-        const repositoryRoot = makeMockRepositoryRoot();
-        const mockDependencies = makeMockDependencies();
-        mockDependencies.repositoryReader.findRepositoryRoot.mockReturnValue(okAsync(repositoryRoot));
-        mockDependencies.packageJsonReader.readPackageJson.mockReturnValue(okAsync(mockPackageJson));
-        mockDependencies.repositoryReader.readFile
-            .mockReturnValueOnce(okAsync("\n22.0.0\n"))
-            .mockReturnValueOnce(okAsync("1.0.0\n"));
-        const result = await getInfo(mockDependencies)();
-        expect(result).toStrictEqual({
-            node: "22.0.0",
-            packageManager: "pnpm",
-            terraform: "1.0.0",
-            turbo: "^2.5.0",
-        });
-        expect(mockDependencies.repositoryReader.readFile).toHaveBeenCalledWith("a/repo/root/.node-version");
-        expect(mockDependencies.repositoryReader.readFile).toHaveBeenCalledWith("a/repo/root/.terraform-version");
-    });
-    it("should only required information", async () => {
-        const repositoryRoot = makeMockRepositoryRoot();
-        const mockDependencies = makeMockDependencies();
-        mockDependencies.repositoryReader.findRepositoryRoot.mockReturnValue(okAsync(repositoryRoot));
-        mockDependencies.packageJsonReader.readPackageJson.mockReturnValue(okAsync(makeMockPackageJson()));
-        mockDependencies.repositoryReader.readFile.mockReturnValue(errAsync(new Error("File not found")));
-        const result = await getInfo(mockDependencies)();
-        expect(result).toStrictEqual({
-            node: undefined,
-            packageManager: "pnpm",
-            terraform: undefined,
-            turbo: undefined,
-        });
-    });
-});

package/dist/domain/__tests__/package-json.test.d.ts

@@ -1 +0,0 @@
-export {};

package/dist/domain/__tests__/package-json.test.js

@@ -1,39 +0,0 @@
-import { errAsync, ok, okAsync } from "neverthrow";
-import { describe, expect, it } from "vitest";
-import { checkMonorepoScripts } from "../package-json.js";
-import { makeMockDependencies, makeMockRepositoryRoot } from "./data.js";
-describe("checkMonorepoScripts", () => {
-    const repositoryRoot = makeMockRepositoryRoot();
-    it("should return error result when getScripts fails", async () => {
-        const deps = makeMockDependencies();
-        const errorMessage = "Oh No!";
-        deps.packageJsonReader.getScripts.mockReturnValueOnce(errAsync(new Error(errorMessage)));
-        const result = await checkMonorepoScripts(deps, repositoryRoot);
-        expect(result.isErr()).toBe(true);
-    });
-    it("should return ok result with successful validation when all required scripts are present", async () => {
-        const deps = makeMockDependencies();
-        const scripts = new Map()
-            .set("build", "eslint .")
-            .set("code-review", "eslint .");
-        deps.packageJsonReader.getScripts.mockReturnValueOnce(okAsync(scripts));
-        deps.packageJsonReader.getRootRequiredScripts.mockReturnValueOnce(new Map().set("code-review", "eslint ."));
-        const result = await checkMonorepoScripts(deps, repositoryRoot);
-        expect(result).toStrictEqual(ok({
-            checkName: "Monorepo Scripts",
-            isValid: true,
-            successMessage: "Monorepo scripts are correctly set up",
-        }));
-    });
-    it("should return ok result with failed validation when required scripts are missing", async () => {
-        const deps = makeMockDependencies();
-        deps.packageJsonReader.getScripts.mockReturnValueOnce(okAsync(new Map()));
-        deps.packageJsonReader.getRootRequiredScripts.mockReturnValueOnce(new Map().set("code-review", "eslint ."));
-        const result = await checkMonorepoScripts(deps, repositoryRoot);
-        expect(result).toStrictEqual(ok({
-            checkName: "Monorepo Scripts",
-            errorMessage: "Missing required scripts: code-review",
-            isValid: false,
-        }));
-    });
-});

package/dist/domain/__tests__/repository.test.d.ts

@@ -1 +0,0 @@
-export {};

package/dist/domain/__tests__/repository.test.js

@@ -1,111 +0,0 @@
-import { errAsync, ok, okAsync } from "neverthrow";
-import { describe, expect, it } from "vitest";
-import { checkNxConfig, checkPreCommitConfig } from "../repository.js";
-import { makeMockConfig, makeMockDependencies, makeMockRepositoryRoot, } from "./data.js";
-describe("checkPreCommitConfig", () => {
-    it("should return ok result with successful validation when .pre-commit-config.yaml exists", async () => {
-        const deps = makeMockDependencies();
-        const repositoryRoot = makeMockRepositoryRoot();
-        deps.repositoryReader.fileExists.mockReturnValueOnce(okAsync(true));
-        const result = await checkPreCommitConfig(deps, repositoryRoot);
-        expect(result).toStrictEqual(ok({
-            checkName: "Pre-commit Configuration",
-            isValid: true,
-            successMessage: "Pre-commit configuration is present in the repository root",
-        }));
-        expect(deps.repositoryReader.fileExists).toHaveBeenCalledWith("a/repo/root/.pre-commit-config.yaml");
-    });
-    it("should return ok result with failed validation when .pre-commit-config.yaml does not exist", async () => {
-        const deps = makeMockDependencies();
-        const repositoryRoot = makeMockRepositoryRoot();
-        const errorMessage = ".pre-commit-config.yaml not found in repository root. Make sure to have pre-commit configured for the repository.";
-        deps.repositoryReader.fileExists.mockReturnValueOnce(errAsync(new Error(errorMessage)));
-        const result = await checkPreCommitConfig(deps, repositoryRoot);
-        expect(result).toStrictEqual(ok({
-            checkName: "Pre-commit Configuration",
-            errorMessage,
-            isValid: false,
-        }));
-    });
-});
-describe("checkNxConfig", () => {
-    const config = makeMockConfig();
-    const repositoryRoot = makeMockRepositoryRoot();
-    it("should return ok result with successful validation when nx.json exists and nx dependency is present", async () => {
-        const deps = makeMockDependencies();
-        deps.repositoryReader.fileExists.mockReturnValueOnce(okAsync(true));
-        deps.packageJsonReader.getDependencies.mockReturnValueOnce(okAsync(new Map().set("nx", "^22.6.1")));
-        const result = await checkNxConfig(deps, repositoryRoot, config);
-        expect(result).toStrictEqual(ok({
-            checkName: "Nx Configuration",
-            isValid: true,
-            successMessage: "Nx configuration is present in the monorepo root and Nx dependency is installed",
-        }));
-        expect(deps.repositoryReader.fileExists).toHaveBeenCalledWith("a/repo/root/nx.json");
-    });
-    it("should return ok result with failed validation when nx.json exists but Nx dependency is missing", async () => {
-        const deps = makeMockDependencies();
-        deps.repositoryReader.fileExists.mockReturnValueOnce(okAsync(true));
-        deps.packageJsonReader.getDependencies.mockReturnValueOnce(okAsync(new Map().set("eslint", "^8.0.0")));
-        const result = await checkNxConfig(deps, repositoryRoot, config);
-        expect(result).toStrictEqual(ok({
-            checkName: "Nx Configuration",
-            errorMessage: "Nx dependency not found in devDependencies. Please add 'nx' to your devDependencies.",
-            isValid: false,
-        }));
-    });
-    it("should return ok result with failed validation when nx.json does not exist", async () => {
-        const deps = makeMockDependencies();
-        const errorMessage = "nx.json not found in repository root. Make sure to have Nx configured for the monorepo.";
-        deps.repositoryReader.fileExists.mockReturnValueOnce(errAsync(new Error(errorMessage)));
-        const result = await checkNxConfig(deps, repositoryRoot, config);
-        expect(result).toStrictEqual(ok({
-            checkName: "Nx Configuration",
-            errorMessage,
-            isValid: false,
-        }));
-    });
-    it("should return ok result with failed validation when fileExists returns ok(false)", async () => {
-        const deps = makeMockDependencies();
-        deps.repositoryReader.fileExists.mockReturnValueOnce(okAsync(false));
-        const result = await checkNxConfig(deps, repositoryRoot, config);
-        expect(result).toStrictEqual(ok({
-            checkName: "Nx Configuration",
-            errorMessage: "nx.json not found in repository root. Make sure to have Nx configured for the monorepo.",
-            isValid: false,
-        }));
-    });
-    it("should return the error message when nx is not listed in devDependencies", async () => {
-        const deps = makeMockDependencies();
-        deps.repositoryReader.fileExists.mockReturnValueOnce(okAsync(true));
-        deps.packageJsonReader.getDependencies.mockReturnValueOnce(okAsync(new Map().set("eslint", "^8.0.0")));
-        const result = await checkNxConfig(deps, repositoryRoot, config);
-        expect(result).toStrictEqual(ok({
-            checkName: "Nx Configuration",
-            errorMessage: "Nx dependency not found in devDependencies. Please add 'nx' to your devDependencies.",
-            isValid: false,
-        }));
-    });
-    it("should return the error message when nx version is less than minimum", async () => {
-        const deps = makeMockDependencies();
-        deps.repositoryReader.fileExists.mockReturnValueOnce(okAsync(true));
-        deps.packageJsonReader.getDependencies.mockReturnValueOnce(okAsync(new Map().set("nx", "1.0.0")));
-        const result = await checkNxConfig(deps, repositoryRoot, config);
-        expect(result).toStrictEqual(ok({
-            checkName: "Nx Configuration",
-            errorMessage: `Nx version (1.0.0) is too low. Minimum required version is ${config.minVersions.nx}.`,
-            isValid: false,
-        }));
-    });
-    it("should return the success message when nx version is ok", async () => {
-        const deps = makeMockDependencies();
-        deps.repositoryReader.fileExists.mockReturnValueOnce(okAsync(true));
-        deps.packageJsonReader.getDependencies.mockReturnValueOnce(okAsync(new Map().set("nx", config.minVersions.nx)));
-        const result = await checkNxConfig(deps, repositoryRoot, config);
-        expect(result).toStrictEqual(ok({
-            checkName: "Nx Configuration",
-            isValid: true,
-            successMessage: "Nx configuration is present in the monorepo root and Nx dependency is installed",
-        }));
-    });
-});

package/dist/domain/__tests__/workspace.test.d.ts

@@ -1 +0,0 @@
-export {};

package/dist/domain/__tests__/workspace.test.js

@@ -1,57 +0,0 @@
-import { err, ok } from "neverthrow";
-import { describe, expect, it } from "vitest";
-import { checkWorkspaces, workspaceSchema } from "../workspace.js";
-import { makeMockDependencies } from "./data.js";
-describe("checkWorkspaces", () => {
-    const monorepoDir = "/path/to/monorepo";
-    const validWorkspaces = [
-        workspaceSchema.parse({
-            name: "workspace1",
-            path: "/path/to/workspace1",
-        }),
-        workspaceSchema.parse({
-            name: "workspace2",
-            path: "/path/to/workspace2",
-        }),
-    ];
-    it("should return the list of workspaces", async () => {
-        const deps = makeMockDependencies();
-        deps.repositoryReader.getWorkspaces.mockResolvedValueOnce(ok(validWorkspaces));
-        const result = await checkWorkspaces(deps, monorepoDir);
-        expect(result).toStrictEqual(ok({
-            checkName: "Workspaces",
-            isValid: true,
-            successMessage: "Found 2 workspaces",
-        }));
-    });
-    it("should return error when getWorkspaces fails", async () => {
-        const deps = makeMockDependencies();
-        deps.repositoryReader.getWorkspaces.mockResolvedValueOnce(err(new Error("Failed to get workspaces")));
-        const result = await checkWorkspaces(deps, monorepoDir);
-        expect(result).toStrictEqual(ok({
-            checkName: "Workspaces",
-            errorMessage: "Something is wrong with the workspaces configuration. If you need help, please contact the DevEx team.",
-            isValid: false,
-        }));
-    });
-    it("should return success when workspaces are found", async () => {
-        const deps = makeMockDependencies();
-        deps.repositoryReader.getWorkspaces.mockResolvedValueOnce(ok([validWorkspaces[0]]));
-        const result = await checkWorkspaces(deps, monorepoDir);
-        expect(result).toStrictEqual(ok({
-            checkName: "Workspaces",
-            isValid: true,
-            successMessage: "Found 1 workspace",
-        }));
-    });
-    it("should return error when no workspace configuration is found", async () => {
-        const deps = makeMockDependencies();
-        deps.repositoryReader.getWorkspaces.mockResolvedValueOnce(ok([]));
-        const result = await checkWorkspaces(deps, monorepoDir);
-        expect(result).toStrictEqual(ok({
-            checkName: "Workspaces",
-            errorMessage: "No workspace configuration found. Make sure to configure workspaces in pnpm-workspace.yaml.",
-            isValid: false,
-        }));
-    });
-});

package/dist/use-cases/__tests__/apply-codemod.test.d.ts

@@ -1 +0,0 @@
-export {};

package/dist/use-cases/__tests__/apply-codemod.test.js

@@ -1,71 +0,0 @@
-import { errAsync, okAsync } from "neverthrow";
-import { describe, expect, it, vi } from "vitest";
-import { applyCodemodById } from "../apply-codemod.js";
-const info = vi.fn().mockResolvedValue({
-    packageManager: "npm",
-});
-describe("applyCodemodById", () => {
-    it("applies the codemod when found", async () => {
-        const apply = vi.fn().mockResolvedValue(undefined);
-        const codemod = {
-            apply,
-            description: "test codemod",
-            id: "foo",
-        };
-        const registry = {
-            getAll: vi.fn(),
-            getById: vi
-                .fn()
-                .mockReturnValue(okAsync(codemod)),
-        };
-        const result = await applyCodemodById(registry, info)("foo");
-        expect(result.isOk()).toBe(true);
-        expect(apply).toHaveBeenCalledTimes(1);
-    });
-    it("returns an error when codemod is not found", async () => {
-        const registry = {
-            getAll: vi.fn(),
-            getById: vi
-                .fn()
-                .mockReturnValue(okAsync(undefined)),
-        };
-        const result = await applyCodemodById(registry, info)("missing-id");
-        expect(result.isErr()).toBe(true);
-        const value = result.isErr() ? result.error : null;
-        expect(value).toBeInstanceOf(Error);
-        expect(value?.message).toBe("Codemod with id missing-id not found");
-    });
-    it("propagates getById errors", async () => {
-        const registryError = new Error("registry failed");
-        const registry = {
-            getAll: vi.fn(),
-            getById: vi
-                .fn()
-                .mockReturnValue(errAsync(registryError)),
-        };
-        const result = await applyCodemodById(registry, info)("foo");
-        expect(result.isErr()).toBe(true);
-        const value = result.isErr() ? result.error : null;
-        expect(value).toBeInstanceOf(Error);
-        expect(value?.message).toContain(registryError.message);
-    });
-    it("propagates apply errors", async () => {
-        const applyError = new Error("apply failed");
-        const codemod = {
-            apply: vi.fn().mockRejectedValue(applyError),
-            description: "test codemod",
-            id: "foo",
-        };
-        const registry = {
-            getAll: vi.fn(),
-            getById: vi
-                .fn()
-                .mockReturnValue(okAsync(codemod)),
-        };
-        const result = await applyCodemodById(registry, info)("foo");
-        expect(result.isErr()).toBe(true);
-        const value = result.isErr() ? result.error : null;
-        expect(value).toBeInstanceOf(Error);
-        expect(value?.message).toContain(applyError.message);
-    });
-});

package/dist/use-cases/__tests__/list-codemods.test.d.ts

@@ -1 +0,0 @@
-export {};

package/dist/use-cases/__tests__/list-codemods.test.js

@@ -1,37 +0,0 @@
-import { errAsync, okAsync } from "neverthrow";
-import { describe, expect, it, vi } from "vitest";
-import { listCodemods } from "../list-codemods.js";
-describe("listCodemods", () => {
-    it("returns codemods from the registry", async () => {
-        const codemods = [
-            {
-                apply: vi.fn().mockResolvedValue(undefined),
-                description: "a",
-                id: "a",
-            },
-            {
-                apply: vi.fn().mockResolvedValue(undefined),
-                description: "b",
-                id: "b",
-            },
-        ];
-        const registry = {
-            getAll: vi.fn().mockReturnValue(okAsync(codemods)),
-            getById: vi.fn(),
-        };
-        const result = await listCodemods(registry)();
-        expect(result.isOk()).toBe(true);
-        expect(registry.getAll).toHaveBeenCalledTimes(1);
-    });
-    it("propagates registry errors", async () => {
-        const error = new Error("boom");
-        const registry = {
-            getAll: vi.fn().mockReturnValue(errAsync(error)),
-            getById: vi.fn(),
-        };
-        const result = await listCodemods(registry)();
-        expect(result.isErr()).toBe(true);
-        const value = result.isErr() ? result.error : null;
-        expect(value).toBe(error);
-    });
-});

package/dist/use-cases/__tests__/request-authorization.test.d.ts

@@ -1,4 +0,0 @@
-/**
- * Tests for the requestAuthorization use case.
- */
-export {};

package/dist/use-cases/__tests__/request-authorization.test.js

@@ -1,43 +0,0 @@
-/**
- * Tests for the requestAuthorization use case.
- */
-import { errAsync, okAsync } from "neverthrow";
-import { describe, expect, it } from "vitest";
-import { mock } from "vitest-mock-extended";
-import { AuthorizationError, AuthorizationResult, requestAuthorizationInputSchema, } from "../../domain/authorization.js";
-import { requestAuthorization } from "../request-authorization.js";
-const makeSampleInput = () => requestAuthorizationInputSchema.parse({
-    bootstrapIdentityId: "test-bootstrap-identity-id",
-    envShort: "d",
-    prefix: "test",
-    repoName: "test-repo",
-    subscriptionName: "test-subscription",
-});
-describe("requestAuthorization", () => {
-    it("should return the authorization result on success", async () => {
-        const authorizationService = mock();
-        const input = makeSampleInput();
-        const expectedResult = new AuthorizationResult("https://github.com/pagopa/eng-azure-authorization/pull/42");
-        authorizationService.requestAuthorization.mockReturnValue(okAsync(expectedResult));
-        const result = await requestAuthorization(authorizationService)(input);
-        expect(result.isOk()).toBe(true);
-        expect(result._unsafeUnwrap().url).toBe("https://github.com/pagopa/eng-azure-authorization/pull/42");
-        expect(authorizationService.requestAuthorization).toHaveBeenCalledWith(input);
-    });
-    it("should propagate errors from the authorization service", async () => {
-        const authorizationService = mock();
-        const input = makeSampleInput();
-        authorizationService.requestAuthorization.mockReturnValue(errAsync(new AuthorizationError("Unable to update file")));
-        const result = await requestAuthorization(authorizationService)(input);
-        expect(result.isErr()).toBe(true);
-        expect(result._unsafeUnwrapErr()).toBeInstanceOf(AuthorizationError);
-    });
-    it("should propagate generic authorization errors", async () => {
-        const authorizationService = mock();
-        const input = makeSampleInput();
-        authorizationService.requestAuthorization.mockReturnValue(errAsync(new AuthorizationError("Something went wrong")));
-        const result = await requestAuthorization(authorizationService)(input);
-        expect(result.isErr()).toBe(true);
-        expect(result._unsafeUnwrapErr()).toBeInstanceOf(AuthorizationError);
-    });
-});