@ordergroove/offers 2.36.0 → 2.36.1-alpha-PR-834-3.10

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@ordergroove/offers",
-  "version": "2.36.0",
+  "version": "2.36.1-alpha-PR-834-3.10+62a84189",
   "description": "offer state component",
   "author": "Eugenio Lattanzio <eugenio63@gmail.com>",
   "homepage": "https://github.com/ordergroove/plush-toys#readme",
@@ -48,5 +48,5 @@
     "@ordergroove/offers-templates": "^0.9.6",
     "@types/lodash.memoize": "^4.1.9"
   },
-  "gitHead": "3d4c898b8dffb8c106a36e1f3eaa9c7291e70702"
+  "gitHead": "62a841892ab3c4e0357e8a5d3a11d9471cacb5ef"
 }

package/src/components/Offer.js

@@ -319,23 +319,23 @@ export class Offer extends TemplateElement {
     return this.preview || window.og.previewMode;
   }
 
-  get shouldRenderOffer() {
+  get shouldEnableOffer() {
     // currently, only the shopify reducer populates storeCurrency
     if (this.config && this.config.storeCurrency && this.config.merchantSettings) {
-      const shouldRender =
+      const shouldEnable =
         this.config.merchantSettings.multicurrency_enabled ||
         this.config.storeCurrency === this.config.merchantSettings.currency_code;
-      if (!shouldRender) {
+      if (!shouldEnable) {
         logMulticurrencyWarning(this.config.storeCurrency, this.config.merchantSettings.currency_code);
       }
-      return shouldRender;
+      return shouldEnable;
     }
 
     return true;
   }
 
   render() {
-    return this.shouldRenderOffer
+    return this.shouldEnableOffer
       ? html`
           <slot></slot>
         `

package/src/shopify/shopifyMiddleware.ts

@@ -346,6 +346,7 @@ export function getSubscribedFrequency(productId, store) {
  */
 function synchronizeSellingPlan(store: any, offerElement?: HTMLElement) {
   if (offerElement.isCart) return; // hidden inputs are used when product page, not cart.
+  if (!offerElement.shouldEnableOffer) return; // do not set a selling plan if we're hiding the offer
 
   [...document.querySelectorAll('form[action$="/cart/add"] [name=id]')].forEach((productIdInput: HTMLInputElement) => {
     const productId = productIdInput.value;