@ordergroove/offers 2.35.2 → 2.35.4

package/src/core/__tests__/actions.spec.js

@@ -24,7 +24,7 @@ import {
 import * as constants from '../constants';
 import { api } from '../api';
 
-describe('redux actions', function() {
+describe('redux actions', function () {
   it('setEnvironment should return dev payload given dev env', () => {
     expect(setEnvironment('dev')).toEqual({
       type: 'SET_ENVIRONMENT_DEV',
@@ -165,7 +165,7 @@ describe('redux actions', function() {
         sessionId: 'the sessionId',
         environment: { apiUrl: 'the environment.apiUrl' }
       });
-      const fetchOfferSpy = spyOn(api, 'fetchOffer').and.returnValue(Promise.resolve({ hey: 'ho' }));
+      const fetchOfferSpy = spyOn(api, 'fetchOffer').and.resolveTo({ hey: 'ho' });
       await fetchOffer('the product')(this.dispatch, getState);
       expect(fetchOfferSpy).toHaveBeenCalledWith(
         'the environment.apiUrl',
@@ -177,7 +177,7 @@ describe('redux actions', function() {
     });
 
     it('should dispatch the receiveOffer if api returns', async () => {
-      const fetchOfferSpy = spyOn(api, 'fetchOffer').and.returnValue(Promise.resolve({ hey: 'ho' }));
+      const fetchOfferSpy = spyOn(api, 'fetchOffer').and.resolveTo({ hey: 'ho' });
 
       await fetchOffer('yum product')(this.dispatch, this.getState);
 
@@ -189,7 +189,7 @@ describe('redux actions', function() {
     });
 
     it('should dispatch fetchResponseError if api fails', async () => {
-      const fetchOfferSpy = spyOn(api, 'fetchOffer').and.returnValue(Promise.reject(Error({ hey: 'ho' })));
+      const fetchOfferSpy = spyOn(api, 'fetchOffer').and.rejectWith(Error({ hey: 'ho' }));
       await fetchOffer('yum product')(this.dispatch, this.getState);
 
       expect(this.dispatch.calls.count()).toEqual(3);
@@ -243,7 +243,7 @@ describe('redux actions', function() {
 
     it('fetchAuth should dispatch requestOffer if authUrl and call authResolver', async () => {
       const dispatch = jasmine.createSpy('dispatch');
-      const authResolver = jasmine.createSpy('authResolver').and.returnValue(Promise.resolve({}));
+      const authResolver = jasmine.createSpy('authResolver').and.resolveTo({});
       const getState = jasmine.createSpy('getState').and.returnValue({
         merchantId: 'yum merchant id',
         authUrl: 'some auth url'
@@ -259,12 +259,12 @@ describe('redux actions', function() {
 
     it('fetchAuth should dispatch receiveOffer authResolver succed', async () => {
       const dispatch = jasmine.createSpy('dispatch');
-      const authResolver = jasmine.createSpy('authResolver').and.returnValue(
-        Promise.resolve({
+      const authResolver = jasmine.createSpy('authResolver').and.resolveTo(
+        {
           sig_field: 'sig_field',
           sig: 'sig',
           ts: 'ts'
-        })
+        }
       );
       const getState = jasmine.createSpy('getState').and.returnValue({
         merchantId: 'yum merchant id',
@@ -277,7 +277,7 @@ describe('redux actions', function() {
 
     it('fetchAuth should dispatch unauthorized if authResolver reject', async () => {
       const dispatch = jasmine.createSpy('dispatch');
-      const authResolver = jasmine.createSpy('authResolver').and.returnValue(Promise.reject(new Error('some reason')));
+      const authResolver = jasmine.createSpy('authResolver').and.rejectWith(new Error('some reason'));
       const getState = jasmine.createSpy('getState').and.returnValue({
         merchantId: 'yum merchant id',
         authUrl: 'some auth url'
@@ -291,7 +291,7 @@ describe('redux actions', function() {
 
 describe('actions.iu', () => {
   it('createIu should dispatch request and receive actions', async () => {
-    const fetchSpy = spyOn(api, 'createOneTime').and.returnValue(Promise.resolve({ hey: 'ho' }));
+    const fetchSpy = spyOn(api, 'createOneTime').and.resolveTo({ hey: 'ho' });
     const dispatch = jasmine.createSpy('dispatch');
     const getState = jasmine
       .createSpy('getState')
@@ -316,7 +316,7 @@ describe('actions.iu', () => {
   });
 
   it('createIu should not call api if previewMode', async () => {
-    const fetchSpy = spyOn(api, 'createOneTime').and.returnValue(Promise.resolve({ hey: 'ho' }));
+    const fetchSpy = spyOn(api, 'createOneTime').and.resolveTo({ hey: 'ho' });
     const dispatch = jasmine.createSpy('dispatch');
     const getState = jasmine.createSpy('getState').and.returnValue({
       previewUpsellOffer: true,
@@ -343,8 +343,8 @@ describe('actions.iu', () => {
   });
 
   it('createIu should dispatch create subscription', async () => {
-    const fetchSpy = spyOn(api, 'createOneTime').and.returnValue(Promise.resolve({ hey: 'hokk' }));
-    spyOn(api, 'convertOneTimeToSubscription').and.returnValue(Promise.resolve({ hey: 'hwwo' }));
+    const fetchSpy = spyOn(api, 'createOneTime').and.resolveTo({ hey: 'hokk' });
+    spyOn(api, 'convertOneTimeToSubscription').and.resolveTo({ hey: 'hwwo' });
     const dispatch = jasmine.createSpy('dispatch').and.returnValue({ the: 'item' });
     const getState = jasmine
       .createSpy('getState')

package/src/core/__tests__/connect.spec.js

@@ -1,3 +1,4 @@
+/* eslint-disable jasmine/no-unsafe-spy */
 import { connect, createRecalcProps, resolveStore, setStore, unsetStore } from '../connect';
 
 describe('connect', () => {

package/src/core/__tests__/localStorage.spec.js

@@ -45,7 +45,7 @@ describe('loadState', () => {
     expect(loadState()).toBe(undefined);
   });
 
-  it('should return undefined on empty state', () => {
+  it('should return object for populated state', () => {
     const yum = {
       sessionId: 'yum',
       optedin: 'yum2',
@@ -74,20 +74,20 @@ describe('saveState', () => {
     setItemSpy = spyOn(Object.getPrototypeOf(localStorage), 'setItem');
   });
 
-  it('should not save empty state', function() {
+  it('should not save empty state', function () {
     ['', false, {}, null, undefined].forEach(saveState);
     expect(getItemSpy).not.toHaveBeenCalled();
     expect(setItemSpy).not.toHaveBeenCalled();
   });
 
-  it('should not save if same state', function() {
+  it('should not save if same state', function () {
     getItemSpy.and.returnValue(JSON.stringify({ sessionId: 'yum' }));
     saveState({ sessionId: 'yum' });
     expect(getItemSpy).toHaveBeenCalledWith(STORE_ROOT);
     expect(setItemSpy).not.toHaveBeenCalled();
   });
 
-  it('should save if different state', function() {
+  it('should save if different state', function () {
     const payload = { sessionId: 'yum' };
     saveState(payload);
     expect(getItemSpy).toHaveBeenCalledWith(STORE_ROOT);

package/src/core/__tests__/middleware.spec.js

@@ -45,29 +45,29 @@ describe('middleware', () => {
 
   describe('conditionals', () => {
     describe('expression a', () => {
-      beforeEach(function() {
+      beforeEach(function () {
         this.underTest = conditionals[0].expressions[0];
       });
 
-      it('should return true given type is constants.OPTIN_PRODUCT', function() {
+      it('should return true given type is constants.OPTIN_PRODUCT', function () {
         expect(this.underTest({ type: constants.OPTIN_PRODUCT })).toBe(true);
       });
 
-      it('should return false given type is not constants.OPTIN_PRODUCT', function() {
+      it('should return false given type is not constants.OPTIN_PRODUCT', function () {
         expect(this.underTest({ type: 'not constants.OPTIN_PRODUCT' })).toBe(false);
       });
 
-      it('should return false given type is not defined', function() {
+      it('should return false given type is not defined', function () {
         expect(this.underTest()).toBe(false);
       });
     });
 
     describe('expression b', () => {
-      beforeEach(function() {
+      beforeEach(function () {
         this.underTest = conditionals[0].expressions[1];
       });
 
-      it('should return false given type is not constants.PRODUCT_CHANGE_FREQUENCY and optedin does not contain same product', function() {
+      it('should return false given type is not constants.PRODUCT_CHANGE_FREQUENCY and optedin does not contain same product', function () {
         const action = {
           type: 'not constants.PRODUCT_CHANGE_FREQUENCY',
           payload: {
@@ -83,7 +83,7 @@ describe('middleware', () => {
         expect(this.underTest(action, state)).toBe(false);
       });
 
-      it('should return false given type is not constants.PRODUCT_CHANGE_FREQUENCY and optedin contains same product', function() {
+      it('should return false given type is not constants.PRODUCT_CHANGE_FREQUENCY and optedin contains same product', function () {
         const action = {
           type: 'not constants.PRODUCT_CHANGE_FREQUENCY',
           payload: {
@@ -103,7 +103,7 @@ describe('middleware', () => {
         expect(this.underTest(action, state)).toBe(false);
       });
 
-      it('should return true given type is constants.PRODUCT_CHANGE_FREQUENCY', function() {
+      it('should return true given type is constants.PRODUCT_CHANGE_FREQUENCY', function () {
         const action = {
           type: constants.PRODUCT_CHANGE_FREQUENCY,
           payload: {
@@ -125,19 +125,19 @@ describe('middleware', () => {
     });
 
     describe('expression c', () => {
-      beforeEach(function() {
+      beforeEach(function () {
         this.underTest = conditionals[1].expressions[0];
       });
 
-      it('should return true given type is constants.OPTOUT_PRODUCT', function() {
+      it('should return true given type is constants.OPTOUT_PRODUCT', function () {
         expect(this.underTest({ type: constants.OPTOUT_PRODUCT })).toBe(true);
       });
 
-      it('should return false given type is not constants.OPTOUT_PRODUCT', function() {
+      it('should return false given type is not constants.OPTOUT_PRODUCT', function () {
         expect(this.underTest({ type: 'not constants.OPTOUT_PRODUCT' })).toBe(false);
       });
 
-      it('should return false given type is not defined', function() {
+      it('should return false given type is not defined', function () {
         expect(this.underTest()).toBe(false);
       });
     });

package/src/core/actions-preview.js

@@ -264,7 +264,7 @@ export const setPreviewPrepaid = (isPreview, productId, offer) =>
   };
 
 export const setPreview = (value, oldValue, offer) =>
-  async function(dispatch, _getState) {
+  async function (dispatch, _getState) {
     await dispatch({ type: constants.LOCAL_STORAGE_CLEAR });
     await dispatch({
       type: constants.SET_PREVIEW_STANDARD_OFFER,

package/src/core/actions.js

@@ -256,18 +256,20 @@ export const createIu = (product, order, quantity, subscribed = false, initialFr
 
     dispatch(requestAction);
 
-    return (previewUpsellOffer
-      ? Promise.resolve({ legoUrl, product, order, quantity, offer })
-      : api.createOneTime(legoUrl, auth, product.id, order, quantity, offer)
+    return (
+      previewUpsellOffer
+        ? Promise.resolve({ legoUrl, product, order, quantity, offer })
+        : api.createOneTime(legoUrl, auth, product.id, order, quantity, offer)
     )
       .then(
         item => {
           dispatch(receiveCreateOneTime(item));
           if (subscribed) {
             dispatch(requestConvertOneTimeToSubscription(item, frequency));
-            return (previewUpsellOffer
-              ? Promise.resolve({ item, frequency })
-              : api.convertOneTimeToSubscription(legoUrl, auth, item, frequency, offer)
+            return (
+              previewUpsellOffer
+                ? Promise.resolve({ item, frequency })
+                : api.convertOneTimeToSubscription(legoUrl, auth, item, frequency, offer)
             ).then(
               response => dispatch(receiveConvertOneTime(response, product)),
               err => dispatch(fetchResponseError(err))

package/src/core/api.js

@@ -2,7 +2,10 @@ import memoize from 'lodash.memoize';
 
 const memoizeKey = (...args) => JSON.stringify(args);
 
-export const withFetchJson = cb => (...args) => fetch(...cb(...args)).then(res => res.json());
+export const withFetchJson =
+  cb =>
+  (...args) =>
+    fetch(...cb(...args)).then(res => res.json());
 
 export const withHost = cb => {
   return (host, ...extra) => {
@@ -134,18 +137,7 @@ export const parseFrequency = raw => {
 
 export const isFrequencyValid = it => it.match(/^\d+_\d$/);
 export const compareFrequencies = (a, b) =>
-  String.prototype.localeCompare.call(
-    a &&
-      a
-        .split('_')
-        .reverse()
-        .join('_'),
-    b &&
-      b
-        .split('_')
-        .reverse()
-        .join('_')
-  );
+  String.prototype.localeCompare.call(a && a.split('_').reverse().join('_'), b && b.split('_').reverse().join('_'));
 
 export const parseFrequenciesList = value =>
   [...new Set(value && value.split(/\s+/))].filter(isFrequencyValid).sort(compareFrequencies);

package/src/core/connect.js

@@ -21,41 +21,43 @@ export const createRecalcProps = (mapStateToProps, mapDispatchToProps) => obj =>
  * TODO this component can be coded as regular connect function. Instead of making the component
  * tied to stateChanged connect can accept mapStateToProps?, mapDispatchToProps?
  */
-export const connect = (mapStateToProps, mapDispatchToProps = defaultMapDispatchToProps) => baseElement => {
-  const preparedDispatch =
-    typeof mapDispatchToProps === 'function'
-      ? mapDispatchToProps
-      : dispatch => bindActionCreators(mapDispatchToProps, dispatch);
+export const connect =
+  (mapStateToProps, mapDispatchToProps = defaultMapDispatchToProps) =>
+  baseElement => {
+    const preparedDispatch =
+      typeof mapDispatchToProps === 'function'
+        ? mapDispatchToProps
+        : dispatch => bindActionCreators(mapDispatchToProps, dispatch);
 
-  const recalcProps = createRecalcProps(mapStateToProps, preparedDispatch);
+    const recalcProps = createRecalcProps(mapStateToProps, preparedDispatch);
 
-  return class extends baseElement {
-    get store() {
-      return storeInstance;
-    }
-
-    connectedCallback() {
-      if (super.connectedCallback) {
-        super.connectedCallback();
+    return class extends baseElement {
+      get store() {
+        return storeInstance;
       }
 
-      this._storeUnsubscribe = resolveStore(this).subscribe(() => recalcProps(this));
-      recalcProps(this);
-    }
+      connectedCallback() {
+        if (super.connectedCallback) {
+          super.connectedCallback();
+        }
 
-    attributeChangedCallback(name, old, value) {
-      if (super.attributeChangedCallback) super.attributeChangedCallback(name, old, value);
-      if (this._storeUnsubscribe && old !== value) recalcProps(this);
-    }
+        this._storeUnsubscribe = resolveStore(this).subscribe(() => recalcProps(this));
+        recalcProps(this);
+      }
 
-    disconnectedCallback() {
-      this._storeUnsubscribe();
-      if (super.disconnectedCallback) {
-        super.disconnectedCallback();
+      attributeChangedCallback(name, old, value) {
+        if (super.attributeChangedCallback) super.attributeChangedCallback(name, old, value);
+        if (this._storeUnsubscribe && old !== value) recalcProps(this);
       }
-    }
+
+      disconnectedCallback() {
+        this._storeUnsubscribe();
+        if (super.disconnectedCallback) {
+          super.disconnectedCallback();
+        }
+      }
+    };
   };
-};
 /**
  * This api will change asap
  * @deprecated

package/src/core/middleware.js

@@ -9,18 +9,18 @@ export const dispatchEvent = (name, detail, el = document) =>
     })
   );
 
-export const dispatchOptinChangedEvent = optedIn => ({
-  payload: { product: { id: productId, components } = {} } = {}
-} = {}) =>
-  setTimeout(
-    () =>
-      dispatchEvent('optin-changed', {
-        productId,
-        components,
-        optedIn
-      }),
-    0
-  );
+export const dispatchOptinChangedEvent =
+  optedIn =>
+  ({ payload: { product: { id: productId, components } = {} } = {} } = {}) =>
+    setTimeout(
+      () =>
+        dispatchEvent('optin-changed', {
+          productId,
+          components,
+          optedIn
+        }),
+      0
+    );
 
 export const conditionals = [
   {

package/src/core/reducer.js

@@ -366,9 +366,9 @@ export const locale = (
     upsellModalCancelLabel: 'Cancel',
     defaultFrequencyCopy: '(Most Popular)',
     frequencyPeriods: {
-      '1': 'day',
-      '2': 'week',
-      '3': 'month'
+      1: 'day',
+      2: 'week',
+      3: 'month'
     },
     prepaidOptInLabel: 'Prepaid Subscription',
     prepaidShipmentsLabel: 'Number of prepaid shipments'

package/src/core/utils.ts

@@ -149,10 +149,10 @@ export function getOrCreateHidden(parent, name, value) {
  * @returns {[any, any[]]} - a two item array where the first item is the matching product and the second is the remaining items from the original state.
  */
 export function getMatchingProductIfExists(state, product) {
-  const [[oldone], rest] = state.reduce((acc, val) => acc[isSameProduct(product, val) ? 0 : 1].push(val) && acc, [
-    [],
-    []
-  ]);
+  const [[oldone], rest] = state.reduce(
+    (acc, val) => acc[isSameProduct(product, val) ? 0 : 1].push(val) && acc,
+    [[], []]
+  );
 
   return [oldone || {}, rest || []];
 }

package/src/run-tests.js

@@ -1,6 +1,6 @@
 import { TestWizard } from './components/TestWizard';
 
-export default function() {
+export default function () {
   const name = 'og-test-wizard';
   if (!customElements.get(name)) {
     customElements.define(name, TestWizard);

package/src/shopify/__tests__/shopifyReducer.spec.js

@@ -437,7 +437,7 @@ describe('config', () => {
     );
     expect(actual).toEqual({
       prepaidSellingPlans: {
-        '43017264201944': [
+        43017264201944: [
           {
             numberShipments: 4,
             sellingPlan: '2146042072'
@@ -479,13 +479,13 @@ describe('config', () => {
     const actual = config(
       {
         prepaidSellingPlans: {
-          '43017264201946': [
+          43017264201946: [
             {
               numberShipments: 1,
               sellingPlan: '2146042072'
             }
           ],
-          '43017264201944': [
+          43017264201944: [
             {
               numberShipments: 4,
               sellingPlan: '2146042071'
@@ -504,19 +504,19 @@ describe('config', () => {
     );
     expect(actual).toEqual({
       prepaidSellingPlans: {
-        '43017264201944': [
+        43017264201944: [
           {
             numberShipments: 4,
             sellingPlan: '2146042071'
           }
         ],
-        '43017264201946': [
+        43017264201946: [
           {
             numberShipments: 3,
             sellingPlan: '2146042072'
           }
         ],
-        '43017264201945': [
+        43017264201945: [
           {
             numberShipments: 5,
             sellingPlan: '2146042073'
@@ -2063,7 +2063,7 @@ describe('productPlans', () => {
     });
   });
 
-  it('should convert product plan values into non-USD currencies given action SETUP_PRODUCT with GBP currency', () => {
+  it('should convert product plan values into non-USD currencies given action SETUP_CART with GBP currency', () => {
     const actual = productPlans({}, getSetupCartActionForRegularProduct('GBP'));
 
     expect(actual).toEqual({

package/src/shopify/shopifyMiddleware.ts

@@ -39,7 +39,7 @@ type SetupCartPayload = ShopifyCart;
 const DEFAULT_SHOPIFY_CART_AJAX_SECTIONS =
   '[id^="shopify-section-"][id$=__cart-items], [id^="shopify-section-"][id$="__cart-footer"],#cart-live-region-text,#cart-icon-bubble';
 const makeSyncProductId = offer =>
-  debounce(100, false, function(form) {
+  debounce(100, false, function (form) {
     const { id } = Object.fromEntries([...new FormData(form).entries()]);
     if (id) {
       offer.setAttribute('product', id);
@@ -142,7 +142,7 @@ export function guessProductHandle(offer): string {
   );
 }
 
-const getProduct = memoize(async function(handle: string): Promise<ShopifyProductEntity> {
+const getProduct = memoize(async function (handle: string): Promise<ShopifyProductEntity> {
   return (await fetch(`${PRODUCTS_URL}${handle}.js`)).json();
 });
 

package/src/shopify/shopifyReducer.js

@@ -246,13 +246,7 @@ export const config = (
   action
 ) => {
   if (constants.RECEIVE_PRODUCT_PLANS === action.type) {
-    const frequencies = [
-      ...new Set(
-        Object.values(action.payload)
-          .map(Object.keys)
-          .flat()
-      )
-    ];
+    const frequencies = [...new Set(Object.values(action.payload).map(Object.keys).flat())];
     return {
       ...state,
       frequencies

package/src/test-mode.js

@@ -14,11 +14,11 @@ export const enable = () => {
   let keysCounter = 0;
   document.addEventListener(
     'keyup',
-    async function(e) {
+    async function (e) {
       const key = e.which;
       if (key === keys[keysCounter]) {
         const currentkeys = keys[keysCounter];
-        setTimeout(function() {
+        setTimeout(function () {
           if (keysCounter <= currentkeys) keysCounter = 0;
         }, 5000);
         keysCounter += 1;

package/tsconfig.json

@@ -21,10 +21,7 @@
   ],
   "typedocOptions": {
     "name": "SMI",
-    "entryPoints": [
-      "./src/index.ts",
-      "./src/shopify.ts",
-    ],
+    "entryPoints": ["./src/index.ts", "./src/shopify.ts"],
     "out": "docs/",
     "readme": "none",
     "disableSources": true,