@ordergroove/offers 2.35.2 → 2.35.3

package/CHANGELOG.md

@@ -3,6 +3,14 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [2.35.3](https://github.com/ordergroove/plush-toys/compare/@ordergroove/offers@2.35.2...@ordergroove/offers@2.35.3) (2023-12-07)
+
+**Note:** Version bump only for package @ordergroove/offers
+
+
+
+
+
 ## [2.35.2](https://github.com/ordergroove/plush-toys/compare/@ordergroove/offers@2.35.1...@ordergroove/offers@2.35.2) (2023-12-05)
 
 **Note:** Version bump only for package @ordergroove/offers

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@ordergroove/offers",
-  "version": "2.35.2",
+  "version": "2.35.3",
   "description": "offer state component",
   "author": "Eugenio Lattanzio <eugenio63@gmail.com>",
   "homepage": "https://github.com/ordergroove/plush-toys#readme",
@@ -35,7 +35,7 @@
     }
   ],
   "dependencies": {
-    "@ordergroove/auth": "^2.3.1",
+    "@ordergroove/auth": "^2.3.2",
     "@ordergroove/offers-live-editor": "^0.6.5",
     "lit-element": "^2.1.0",
     "lodash.memoize": "^4.1.2",
@@ -48,5 +48,5 @@
     "@ordergroove/offers-templates": "^0.9.3",
     "@types/lodash.memoize": "^4.1.9"
   },
-  "gitHead": "d1e06c5dec3c827713005c7a2d3558f9ed0d2431"
+  "gitHead": "521fa43f980842f76be9c12ab20ed6473ab905f7"
 }

package/src/components/__tests__/OG.fspec.js

@@ -195,6 +195,7 @@ describe('Offer', function() {
       element = document.querySelector('og-select-frequency');
       await element.updateComplete;
       await new Promise(r => setTimeout(r, 10));
+      // eslint-disable-next-line jasmine/no-expect-in-setup-teardown
       expect(fetch).toHaveBeenCalledTimes(1);
     });
 

package/src/core/__tests__/actions.spec.js

@@ -165,7 +165,7 @@ describe('redux actions', function() {
         sessionId: 'the sessionId',
         environment: { apiUrl: 'the environment.apiUrl' }
       });
-      const fetchOfferSpy = spyOn(api, 'fetchOffer').and.returnValue(Promise.resolve({ hey: 'ho' }));
+      const fetchOfferSpy = spyOn(api, 'fetchOffer').and.resolveTo({ hey: 'ho' });
       await fetchOffer('the product')(this.dispatch, getState);
       expect(fetchOfferSpy).toHaveBeenCalledWith(
         'the environment.apiUrl',
@@ -177,7 +177,7 @@ describe('redux actions', function() {
     });
 
     it('should dispatch the receiveOffer if api returns', async () => {
-      const fetchOfferSpy = spyOn(api, 'fetchOffer').and.returnValue(Promise.resolve({ hey: 'ho' }));
+      const fetchOfferSpy = spyOn(api, 'fetchOffer').and.resolveTo({ hey: 'ho' });
 
       await fetchOffer('yum product')(this.dispatch, this.getState);
 
@@ -189,7 +189,7 @@ describe('redux actions', function() {
     });
 
     it('should dispatch fetchResponseError if api fails', async () => {
-      const fetchOfferSpy = spyOn(api, 'fetchOffer').and.returnValue(Promise.reject(Error({ hey: 'ho' })));
+      const fetchOfferSpy = spyOn(api, 'fetchOffer').and.rejectWith(Error({ hey: 'ho' }));
       await fetchOffer('yum product')(this.dispatch, this.getState);
 
       expect(this.dispatch.calls.count()).toEqual(3);
@@ -243,7 +243,7 @@ describe('redux actions', function() {
 
     it('fetchAuth should dispatch requestOffer if authUrl and call authResolver', async () => {
       const dispatch = jasmine.createSpy('dispatch');
-      const authResolver = jasmine.createSpy('authResolver').and.returnValue(Promise.resolve({}));
+      const authResolver = jasmine.createSpy('authResolver').and.resolveTo({});
       const getState = jasmine.createSpy('getState').and.returnValue({
         merchantId: 'yum merchant id',
         authUrl: 'some auth url'
@@ -259,12 +259,12 @@ describe('redux actions', function() {
 
     it('fetchAuth should dispatch receiveOffer authResolver succed', async () => {
       const dispatch = jasmine.createSpy('dispatch');
-      const authResolver = jasmine.createSpy('authResolver').and.returnValue(
-        Promise.resolve({
+      const authResolver = jasmine.createSpy('authResolver').and.resolveTo(
+        {
           sig_field: 'sig_field',
           sig: 'sig',
           ts: 'ts'
-        })
+        }
       );
       const getState = jasmine.createSpy('getState').and.returnValue({
         merchantId: 'yum merchant id',
@@ -277,7 +277,7 @@ describe('redux actions', function() {
 
     it('fetchAuth should dispatch unauthorized if authResolver reject', async () => {
       const dispatch = jasmine.createSpy('dispatch');
-      const authResolver = jasmine.createSpy('authResolver').and.returnValue(Promise.reject(new Error('some reason')));
+      const authResolver = jasmine.createSpy('authResolver').and.rejectWith(new Error('some reason'));
       const getState = jasmine.createSpy('getState').and.returnValue({
         merchantId: 'yum merchant id',
         authUrl: 'some auth url'
@@ -291,7 +291,7 @@ describe('redux actions', function() {
 
 describe('actions.iu', () => {
   it('createIu should dispatch request and receive actions', async () => {
-    const fetchSpy = spyOn(api, 'createOneTime').and.returnValue(Promise.resolve({ hey: 'ho' }));
+    const fetchSpy = spyOn(api, 'createOneTime').and.resolveTo({ hey: 'ho' });
     const dispatch = jasmine.createSpy('dispatch');
     const getState = jasmine
       .createSpy('getState')
@@ -316,7 +316,7 @@ describe('actions.iu', () => {
   });
 
   it('createIu should not call api if previewMode', async () => {
-    const fetchSpy = spyOn(api, 'createOneTime').and.returnValue(Promise.resolve({ hey: 'ho' }));
+    const fetchSpy = spyOn(api, 'createOneTime').and.resolveTo({ hey: 'ho' });
     const dispatch = jasmine.createSpy('dispatch');
     const getState = jasmine.createSpy('getState').and.returnValue({
       previewUpsellOffer: true,
@@ -343,8 +343,8 @@ describe('actions.iu', () => {
   });
 
   it('createIu should dispatch create subscription', async () => {
-    const fetchSpy = spyOn(api, 'createOneTime').and.returnValue(Promise.resolve({ hey: 'hokk' }));
-    spyOn(api, 'convertOneTimeToSubscription').and.returnValue(Promise.resolve({ hey: 'hwwo' }));
+    const fetchSpy = spyOn(api, 'createOneTime').and.resolveTo({ hey: 'hokk' });
+    spyOn(api, 'convertOneTimeToSubscription').and.resolveTo({ hey: 'hwwo' });
     const dispatch = jasmine.createSpy('dispatch').and.returnValue({ the: 'item' });
     const getState = jasmine
       .createSpy('getState')

package/src/core/__tests__/connect.spec.js

@@ -1,3 +1,4 @@
+/* eslint-disable jasmine/no-unsafe-spy */
 import { connect, createRecalcProps, resolveStore, setStore, unsetStore } from '../connect';
 
 describe('connect', () => {

package/src/core/__tests__/localStorage.spec.js

@@ -45,7 +45,7 @@ describe('loadState', () => {
     expect(loadState()).toBe(undefined);
   });
 
-  it('should return undefined on empty state', () => {
+  it('should return object for populated state', () => {
     const yum = {
       sessionId: 'yum',
       optedin: 'yum2',

package/src/shopify/__tests__/shopifyReducer.spec.js

@@ -2063,7 +2063,7 @@ describe('productPlans', () => {
     });
   });
 
-  it('should convert product plan values into non-USD currencies given action SETUP_PRODUCT with GBP currency', () => {
+  it('should convert product plan values into non-USD currencies given action SETUP_CART with GBP currency', () => {
     const actual = productPlans({}, getSetupCartActionForRegularProduct('GBP'));
 
     expect(actual).toEqual({