@openui5/sap.ui.core 1.117.0 → 1.118.0

package/test/sap/ui/core/qunit/opa/OpaPlugin.qunit.js

@@ -10,8 +10,8 @@ sap.ui.define([
 	"sap/m/Dialog",
 	"sap/ui/core/mvc/View",
 	"sap/ui/core/mvc/XMLView",
-	"sap/ui/core/Fragment",
 	"./utils/view",
+	"sap/ui/qunit/utils/nextUIUpdate",
 	"sap/base/Log"
 ], function (OpaPlugin,
 			 Interactable,
@@ -23,8 +23,8 @@ sap.ui.define([
 			 Dialog,
 			 View,
 			 XMLView,
-			 Fragment,
 			 viewUtils,
+			 nextUIUpdate,
 			 Log) {
 	"use strict";
 
@@ -43,10 +43,10 @@ sap.ui.define([
 		}
 	});
 
-	QUnit.test("Should retrieve a control by a global id", function(assert) {
+	QUnit.test("Should retrieve a control by a global id", async function(assert) {
 		// Arrange
 		this.oButton.placeAt("qunit-fixture");
-		sap.ui.getCore().applyChanges();
+		await nextUIUpdate();
 
 		// Act
 		var oRetrievedButton = this.oPlugin.getMatchingControls({ id : this.sId });
@@ -100,14 +100,14 @@ sap.ui.define([
 		assert.strictEqual(oRetrievedButton, this.oButton);
 	});
 
-	QUnit.test("Should retrieve multiple controls by global id's", function(assert) {
+	QUnit.test("Should retrieve multiple controls by global id's", async function(assert) {
 		// Arrange
 		var oButton = new Button(),
 			oButton2 = new Button();
 
 		oButton.placeAt("qunit-fixture");
 		oButton2.placeAt("qunit-fixture");
-		sap.ui.getCore().applyChanges();
+		await nextUIUpdate();
 
 		// System under Test
 		var oPlugin = new OpaPlugin();
@@ -125,14 +125,14 @@ sap.ui.define([
 		oButton2.destroy();
 	});
 
-	QUnit.test("Should retrieve multiple controls by global id's with regexp", function(assert) {
+	QUnit.test("Should retrieve multiple controls by global id's with regexp", async function(assert) {
 		// Arrange
 		var oButton = new Button(),
 			oButton2 = new Button();
 
 		oButton.placeAt("qunit-fixture");
 		oButton2.placeAt("qunit-fixture");
-		sap.ui.getCore().applyChanges();
+		await nextUIUpdate();
 
 		// System under Test
 		var oPlugin = new OpaPlugin();
@@ -197,7 +197,7 @@ sap.ui.define([
 			this.oButton2.placeAt("qunit-fixture");
 			this.oCheckBox.placeAt("qunit-fixture");
 
-			sap.ui.getCore().applyChanges();
+			return nextUIUpdate();
 		},
 		afterEach : function() {
 			this.fnLogSpy.restore();
@@ -326,6 +326,9 @@ sap.ui.define([
 		});
 
 		assert.strictEqual(oResult.length, 0, "Result was null");
+		/**
+		 * @deprecated since 1.56 together with lazy loading as it implies sync loading
+		 */
 		sinon.assert.calledWith(this.fnLogSpy, "The control type sap.m.MessageToast must be a function.");
 	});
 
@@ -375,14 +378,12 @@ sap.ui.define([
 	});
 
 	QUnit.module("OpaPlugin - Controls in a view", {
-		beforeEach: function (assert) {
+		beforeEach: async function (assert) {
 			// Note: This test is executed with QUnit 1 and QUnit 2.
 			//       We therefore cannot rely on the built-in promise handling of QUnit 2.
-			var done = assert.async();
-			viewUtils.createXmlView("bar", "myFooBarView").then(function(oView) {
+			await viewUtils.createXmlView("bar", "myFooBarView").then(function(oView) {
 				this.oView = oView.placeAt("qunit-fixture");
-				sap.ui.getCore().applyChanges();
-				done();
+				return nextUIUpdate();
 			}.bind(this), function(oErr) {
 				assert.strictEqual(oErr, undefined, "failed to load view");
 			});
@@ -782,16 +783,14 @@ sap.ui.define([
 			].join('');
 			// Note: This test is executed with QUnit 1 and QUnit 2.
 			//       We therefore cannot rely on the built-in promise handling of QUnit 2.
-			var done = assert.async();
-			XMLView.create({
+			return XMLView.create({
 				id: "viewWithDialog",
 				definition: sViewContent
 			}).then(function(oView) {
 				this.oView = oView
 					.setViewName("testView")
 					.placeAt("qunit-fixture");
-				sap.ui.getCore().applyChanges();
-				done();
+				return nextUIUpdate();
 			}.bind(this), function(oErr) {
 				assert.strictEqual(oErr, undefined, "failed to load view");
 			});
@@ -881,7 +880,7 @@ sap.ui.define([
 		beforeEach: function () {
 			this.oPlugin =  new OpaPlugin();
 			this.oButton = new Button("foo").placeAt("qunit-fixture");
-			sap.ui.getCore().applyChanges();
+			return nextUIUpdate();
 		},
 		afterEach: function () {
 			this.oPlugin.destroy();
@@ -1011,16 +1010,13 @@ sap.ui.define([
 		beforeEach: function (assert) {
 			// Note: This test is executed with QUnit 1 and QUnit 2.
 			//       We therefore cannot rely on the built-in promise handling of QUnit 2.
-			var done = assert.async();
-			viewUtils.createXmlView("sample.viewNamespace.viewName", "myViewSample").then(function(oView) {
+			this.oPlugin = new OpaPlugin();
+			return viewUtils.createXmlView("sample.viewNamespace.viewName", "myViewSample").then(function(oView) {
 				this.oView = oView.placeAt("qunit-fixture");
-				sap.ui.getCore().applyChanges();
-				done();
+				return nextUIUpdate();
 			}.bind(this), function(oErr) {
 				assert.strictEqual(oErr, undefined, "failed to load view");
 			});
-
-			this.oPlugin = new OpaPlugin();
 		},
 		afterEach: function () {
 			this.oView.destroy();
@@ -1061,8 +1057,7 @@ sap.ui.define([
 			this.sViewName = "sample.viewNamespace.viewName";
 			// Note: This test is executed with QUnit 1 and QUnit 2.
 			//       We therefore cannot rely on the built-in promise handling of QUnit 2.
-			var done = assert.async();
-			Promise.all([
+			return Promise.all([
 				viewUtils.createXmlView(this.sViewName, "mySampleView"),
 				viewUtils.createXmlView(this.sViewName, "myOtherView"),
 				viewUtils.createXmlView("differentName", "myDifferentlyNamedView")
@@ -1070,8 +1065,7 @@ sap.ui.define([
 				this.oSampleView = aViews[0].placeAt("qunit-fixture");
 				this.oDuplicateView = aViews[1].placeAt("qunit-fixture");
 				this.oDifferentView = aViews[2].placeAt("qunit-fixture");
-				sap.ui.getCore().applyChanges();
-				done();
+				return nextUIUpdate();
 			}.bind(this), function(oErr) {
 				assert.strictEqual(oErr, undefined, "failed to load view");
 			});
@@ -1100,17 +1094,14 @@ sap.ui.define([
 
 		// Note: This test is executed with QUnit 1 and QUnit 2.
 		//       We therefore cannot rely on the built-in promise handling of QUnit 2.
-		var done = assert.async();
-		viewUtils.createXmlView(this.sViewName, "myOtherView").then(function(oView) {
+		return viewUtils.createXmlView(this.sViewName, "myOtherView").then(async function(oView) {
 			this.oDuplicateView = oView;  // do not render view
-			sap.ui.getCore().applyChanges();
+			await nextUIUpdate();
 
 			assert.strictEqual(aViews.length, 3, "Should find all controls of type View");
 			assert.strictEqual(oMatchedView.getId(), "mySampleView", "Should match only rendered views");
 			sinon.assert.calledWith(this.fnLogSpy, "Found 2 views with viewName '" + this.sViewName + "'");
 			sinon.assert.calledWith(this.fnLogSpy, "Found 1 visible views with viewName '" + this.sViewName + "'");
-
-			done();
 		}.bind(this), function(oErr) {
 			assert.strictEqual(oErr, undefined, "failed to load view");
 		});
@@ -1140,14 +1131,12 @@ sap.ui.define([
 		beforeEach: function (assert) {
 			// Note: This test is executed with QUnit 1 and QUnit 2.
 			//       We therefore cannot rely on the built-in promise handling of QUnit 2.
-			var done = assert.async(assert);
-			viewUtils.createXmlView("testViewName", "myView", {
+			return viewUtils.createXmlView("testViewName", "myView", {
 				id: "testFragment",
 				name: "fixture.OpaPlugin"
 			}).then(function(oView) {
 				this.oView = oView.placeAt("qunit-fixture");
-				sap.ui.getCore().applyChanges();
-				done();
+				return nextUIUpdate();
 			}.bind(this), function(oErr) {
 				assert.strictEqual(oErr, undefined, "failed to load view");
 			});
@@ -1172,14 +1161,12 @@ sap.ui.define([
 			].join('');
 			// Note: This test is executed with QUnit 1 and QUnit 2.
 			//       We therefore cannot rely on the built-in promise handling of QUnit 2.
-			var done = assert.async();
-			XMLView.create({
+			return XMLView.create({
 				id: "myView",
 				definition: sView
 			}).then(function(oView) {
 				this.oView = oView.placeAt("qunit-fixture");
-				sap.ui.getCore().applyChanges();
-				done();
+				return nextUIUpdate();
 			}.bind(this), function(oErr) {
 				assert.strictEqual(oErr, undefined, "failed to load view");
 			});

package/test/sap/ui/core/qunit/opa/RecordReplay.qunit.js

@@ -12,16 +12,16 @@ sap.ui.define([
 	'sap/m/SearchField',
 	"sap/ui/thirdparty/jquery",
 	'sap/m/App',
-	'sap/ui/core/mvc/XMLView'
-], function (RecordReplay, _autoWaiter, _autoWaiterAsync, ListItem, Button, Input, MultiInput, OverflowToolbar, Popover, SearchField, $, App, XMLView) {
+	'sap/ui/core/mvc/XMLView',
+	"sap/ui/qunit/utils/nextUIUpdate"
+], function (RecordReplay, _autoWaiter, _autoWaiterAsync, ListItem, Button, Input, MultiInput, OverflowToolbar, Popover, SearchField, $, App, XMLView, nextUIUpdate) {
 	"use strict";
 
 	QUnit.module("RecordReplay - control selector", {
 		beforeEach: function (assert) {
 			// Note: This test is executed with QUnit 1 and QUnit 2.
 			//       We therefore cannot rely on the built-in promise handling of QUnit 2.
-			var done = assert.async();
-			XMLView.create({
+			return XMLView.create({
 				id: "myView",
 				definition:
 					'<mvc:View xmlns:core="sap.ui.core" xmlns:mvc="sap.ui.core.mvc" xmlns="sap.m">' +
@@ -34,8 +34,7 @@ sap.ui.define([
 					'</mvc:View>'
 			}).then(function(oView) {
 				this.oView = oView.placeAt("qunit-fixture");
-				sap.ui.getCore().applyChanges();
-				done();
+				return nextUIUpdate();
 			}.bind(this), function(oErr) {
 				assert.strictEqual(oErr, undefined, "failed to load view");
 			});
@@ -72,7 +71,7 @@ sap.ui.define([
 			this.oSearchFieldMulti = new SearchField("mySecondSearch", {placeholder: "Multi"});
 			this.oSearchField.placeAt("qunit-fixture");
 			this.oSearchFieldMulti.placeAt("qunit-fixture");
-			sap.ui.getCore().applyChanges();
+			return nextUIUpdate();
 		},
 		afterEach: function () {
 			this.oSearchField.destroy();
@@ -174,7 +173,7 @@ sap.ui.define([
 			this.oSearchField = new SearchField();
 			this.oSearchField.attachSearch(this.oActionSpy);
 			this.oSearchField.placeAt("qunit-fixture");
-			sap.ui.getCore().applyChanges();
+			return nextUIUpdate();
 		},
 		afterEach: function () {
 			this.oSearchField.destroy();
@@ -207,7 +206,7 @@ sap.ui.define([
 		}.bind(this));
 	});
 
-	QUnit.test("Should open Suggestions Popover through EnterText Action on MultiInput", function (assert) {
+	QUnit.test("Should open Suggestions Popover through EnterText Action on MultiInput", async function (assert) {
 		var fnDone = assert.async(),
 			oMultiInput = new MultiInput({
 				value: "",
@@ -228,7 +227,7 @@ sap.ui.define([
 			fnDone();
 		});
 		oMultiInput.placeAt("qunit-fixture");
-		sap.ui.getCore().applyChanges();
+		await nextUIUpdate();
 
 		RecordReplay.interactWithControl({
 			selector: {controlType: "sap.m.MultiInput"},
@@ -238,7 +237,7 @@ sap.ui.define([
 		});
 	});
 
-	QUnit.test("Should enter text in Popover - Popover should remain open", function (assert) {
+	QUnit.test("Should enter text in Popover - Popover should remain open", async function (assert) {
 		var fnDone = assert.async(),
 			oButton = new Button({
 				id: "open"
@@ -257,7 +256,7 @@ sap.ui.define([
 			});
 
 		oButton.placeAt("qunit-fixture");
-		sap.ui.getCore().applyChanges();
+		await nextUIUpdate();
 
 		oPopover.openBy(oButton);
 		oPopover.$().css("display", "block");
@@ -295,7 +294,7 @@ sap.ui.define([
 		});
 	});
 
-	QUnit.test("Should interact with Control with provided idSuffix", function (assert) {
+	QUnit.test("Should interact with Control with provided idSuffix", async function (assert) {
 		var fnDone = assert.async(),
 			oOFT = new OverflowToolbar({
 				content: [
@@ -306,7 +305,7 @@ sap.ui.define([
 			oPopover = oOFT._getPopover();
 
 		oOFT.placeAt("qunit-fixture");
-		sap.ui.getCore().applyChanges();
+		await nextUIUpdate();
 
 		oPopover.attachAfterOpen(function () {
 			assert.ok(true, "Overflow button of OverflowToolbar is pressed");

package/test/sap/ui/core/qunit/opa/_ControlFinder.qunit.js

@@ -10,8 +10,9 @@ sap.ui.define([
 	"sap/m/Dialog",
 	"sap/ui/model/json/JSONModel",
 	"sap/ui/test/matchers/PropertyStrictEquals",
-	"sap/ui/test/_LogCollector"
-], function ($, _ControlFinder,  mobileLibrary, Button, SearchField, List, ObjectListItem, Dialog, JSONModel, PropertyStrictEquals, _LogCollector) {
+	"sap/ui/test/_LogCollector",
+	"sap/ui/qunit/utils/nextUIUpdate"
+], function ($, _ControlFinder,  mobileLibrary, Button, SearchField, List, ObjectListItem, Dialog, JSONModel, PropertyStrictEquals, _LogCollector, nextUIUpdate) {
 	"use strict";
 
 	// shortcut for sap.m.ButtonType
@@ -36,7 +37,7 @@ sap.ui.define([
 			this.oButton.placeAt("qunit-fixture");
 			this.oButtonWithSpecialId.placeAt("qunit-fixture");
 			this.oObjectListItem.placeAt("qunit-fixture");
-			sap.ui.getCore().applyChanges();
+			return nextUIUpdate();
 		},
 		afterEach: function () {
 			this.oButton.destroy();
@@ -236,7 +237,7 @@ sap.ui.define([
 			this.oSearchField = new SearchField("myId");
 			this.oSearchField.placeAt("qunit-fixture");
 			this.oList.placeAt("qunit-fixture");
-			sap.ui.getCore().applyChanges();
+			return nextUIUpdate();
 		},
 		afterEach: function () {
 			this.oSearchField.destroy();

package/test/sap/ui/core/qunit/opa/actions/Action.qunit.js

@@ -3,8 +3,9 @@
 
 sap.ui.define([
 	"sap/ui/test/actions/Action",
-	"sap/ui/core/Control"
-], function(Action, Control){
+	"sap/ui/core/Control",
+	"sap/ui/qunit/utils/nextUIUpdate"
+], function(Action, Control, nextUIUpdate){
 	"use strict";
 
 	var MyControl = Control.extend("my.Control", {
@@ -39,8 +40,8 @@ sap.ui.define([
 		beforeEach: function () {
 			var oMyControl = new MyControl("myId");
 			oMyControl.placeAt("qunit-fixture");
-			sap.ui.getCore().applyChanges();
 			this.oMyControl = oMyControl;
+			return nextUIUpdate();
 		},
 		afterEach: function () {
 			this.oMyControl.destroy();
@@ -86,14 +87,14 @@ sap.ui.define([
 
 	});
 
-	QUnit.test("Artificial focus should synchronously trigger focusout for the old focused", function (assert) {
+	QUnit.test("Artificial focus should synchronously trigger focusout for the old focused", async function (assert) {
 		var oAction = new Action();
 		var async = assert.async();
 		var oInitiallyFocused = this.oMyControl;
 		var oNewlyFocused = new MyControl("myId2");
 
 		oNewlyFocused.placeAt("qunit-fixture");
-		sap.ui.getCore().applyChanges();
+		await nextUIUpdate();
 
 		oInitiallyFocused.focus();
 		oInitiallyFocused.onsapfocusleave = sinon.spy();

package/test/sap/ui/core/qunit/opa/actions/EnterText.qunit.js

@@ -15,7 +15,8 @@ sap.ui.define([
 	"sap/ui/test/opaQunit",
 	"sap/m/library",
 	"sap/ui/thirdparty/jquery",
-	"sap/base/strings/capitalize"
+	"sap/base/strings/capitalize",
+	"sap/ui/qunit/utils/nextUIUpdate"
 ], function (
 	extend,
 	EnterText,
@@ -32,7 +33,8 @@ sap.ui.define([
 	opaTest,
 	mobileLibrary,
 	$,
-	capitalize) {
+	capitalize,
+	nextUIUpdate) {
 	"use strict";
 
 	var InputType = mobileLibrary.InputType;
@@ -92,7 +94,7 @@ sap.ui.define([
 		clearTextFirst: true
 	}].forEach(function (testInfo) {
 
-		function testBobyForValidAction(bClearText, assert) {
+		async function testBobyForValidAction(bClearText, assert) {
 			var fnDone = assert.async();
 			var sTextToEnter = testInfo.textToEnter || "foo";
 			var sTextBeforeAction = testInfo.textInControl || "A";
@@ -112,7 +114,7 @@ sap.ui.define([
 			var fnOnSapFocusLeaveSpy = sinon.spy(oControl, "onsapfocusleave");
 
 			oControl.placeAt("qunit-fixture");
-			sap.ui.getCore().applyChanges();
+			await nextUIUpdate();
 
 			var oEnterText = new EnterText({
 				text: sTextToEnter,
@@ -155,22 +157,22 @@ sap.ui.define([
 
 		if (!testInfo.clearTextFirst) {
 			QUnit.test("Should enter a text and preserve the value in a " + testInfo.Control.getMetadata().getName(), function (assert) {
-				testBobyForValidAction.call(this, false, assert);
+				return testBobyForValidAction.call(this, false, assert);
 			});
 		}
 
 		QUnit.test("Should enter a text and clear the value in a " + testInfo.Control.getMetadata().getName(), function (assert) {
-			testBobyForValidAction.call(this, true, assert);
+			return testBobyForValidAction.call(this, true, assert);
 		});
 
-		function testBodyForInvalidAction(fnModifyControl, assert) {
+		async function testBodyForInvalidAction(fnModifyControl, assert) {
 			var fnDone = assert.async();
 			fnModifyControl();
 			var fnOnLiveChange = testInfo.liveChangeEventParameter ? sinon.spy(this.oControl, "fireLiveChange") : sinon.spy();
 			var fnOnChange = sinon.spy(this.oControl, "on" + capitalize(testInfo.changeEvent));
 
 			this.oControl.placeAt("qunit-fixture");
-			sap.ui.getCore().applyChanges();
+			await nextUIUpdate();
 
 			var oEnterText = new EnterText({
 				text: testInfo.textToEnter || "foo"
@@ -193,7 +195,7 @@ sap.ui.define([
 			this.oControl = oControl; // should be destroyed at end of test
 
 			if (oControl.getMetadata()._mAllProperties.editable) {
-				testBodyForInvalidAction.call(this, function () {
+				return testBodyForInvalidAction.call(this, function () {
 					oControl.setEditable(false);
 				}, assert);
 			} else {
@@ -201,26 +203,26 @@ sap.ui.define([
 			}
 		});
 
-		QUnit.test("Should not enter text when " + testInfo.Control.getMetadata().getName() + " is not enabled", function (assert) {
+		QUnit.test("Should not enter text when " + testInfo.Control.getMetadata().getName() + " is not enabled", async function (assert) {
 			this.sTextBeforeAction = testInfo.textInControl || "A";
 			var oControl = new testInfo.Control({
 				value: this.sTextBeforeAction
 			});
 			this.oControl = oControl; // should be destroyed at end of test
 
-			testBodyForInvalidAction.call(this, function () {
+			await testBodyForInvalidAction.call(this, function () {
 				oControl.setEnabled(false);
 			}, assert);
 			oControl.setEnabled(false);
 		});
 	});
 
-	QUnit.test("Should not fire enter on a control", function (assert) {
+	QUnit.test("Should not fire enter on a control", async function (assert) {
 		this.oControl = new Input();
 		var fnEnterSpy = sinon.spy(this.oControl, "onsapenter");
 
 		this.oControl.placeAt("qunit-fixture");
-		sap.ui.getCore().applyChanges();
+		await nextUIUpdate();
 
 		new EnterText({ text: "foo" }).executeOn(this.oControl);
 
@@ -238,7 +240,6 @@ sap.ui.define([
 			]
 		});
 		this.oControl.placeAt("qunit-fixture");
-		sap.ui.getCore().applyChanges();
 
 		var sTextInControl = "T";
 		oOpa.waitFor({
@@ -258,11 +259,11 @@ sap.ui.define([
 		});
 	});
 
-	QUnit.test("Should enter binding symbols", function (assert) {
+	QUnit.test("Should enter binding symbols", async function (assert) {
 		this.oControl = new Input();
 
 		this.oControl.placeAt("qunit-fixture");
-		sap.ui.getCore().applyChanges();
+		await nextUIUpdate();
 
 		new EnterText({ text: "{" }).executeOn(this.oControl);
 
@@ -276,7 +277,7 @@ sap.ui.define([
 			this.oErrorLog = sinon.spy(this.oEnterText.oLogger, "error");
 			this.oControl = new Input();
 			this.oControl.placeAt("qunit-fixture");
-			sap.ui.getCore().applyChanges();
+			return nextUIUpdate();
 		},
 		afterEach: function () {
 			this.oDebugLog.restore();
@@ -285,9 +286,9 @@ sap.ui.define([
 		}
 	});
 
-	QUnit.test("Should log an error if a control is not rendered", function (assert) {
+	QUnit.test("Should log an error if a control is not rendered", async function (assert) {
 		this.oControl.destroy();
-		sap.ui.getCore().applyChanges();
+		await nextUIUpdate();
 
 		this.oEnterText.setText("foo");
 
@@ -334,7 +335,7 @@ sap.ui.define([
 		beforeEach: function () {
 			this.oStepInput = new StepInput();
 			this.oStepInput.placeAt("qunit-fixture");
-			sap.ui.getCore().applyChanges();
+			return nextUIUpdate();
 		},
 		afterEach: function () {
 			this.oStepInput.destroy();
@@ -373,7 +374,7 @@ sap.ui.define([
 			});
 			$("#qunit-fixture").css("position", "static");
 			this.target.placeAt("qunit-fixture");
-			sap.ui.getCore().applyChanges();
+			return nextUIUpdate();
 		},
 		afterEach: function () {
 			this.target.destroy();