@opengsd/gsd-pi 1.0.1 → 1.0.2

package/src/resources/extensions/gsd/tests/integration/queue-reorder-e2e.test.ts

@@ -1,335 +0,0 @@
-/**
- * End-to-end integration tests for the Queue Reorder feature.
- *
- * Verifies the full chain: QUEUE-ORDER.json + findMilestoneIds() + deriveState()
- * + depends_on removal from CONTEXT.md files.
- *
- * These tests simulate what happens when a user reorders milestones and confirms:
- * 1. QUEUE-ORDER.json is written with the new order
- * 2. depends_on is removed from CONTEXT.md frontmatter
- * 3. deriveState() picks the correct milestone as active
- * 4. A fresh deriveState() call (simulating new session) also works
- */
-
-import { describe, test } from 'node:test';
-import assert from 'node:assert/strict';
-import { mkdtempSync, mkdirSync, rmSync, writeFileSync, readFileSync, existsSync } from 'node:fs';
-import { join } from 'node:path';
-import { tmpdir } from 'node:os';
-
-import { deriveState, invalidateStateCache } from '../../state.ts';
-import { findMilestoneIds } from '../../guided-flow.ts';
-import { saveQueueOrder, loadQueueOrder } from '../../queue-order.ts';
-import { parseContextDependsOn } from '../../files.ts';
-// ─── Fixture Helpers ───────────────────────────────────────────────────────
-
-function createFixtureBase(): string {
-  const base = mkdtempSync(join(tmpdir(), 'gsd-reorder-e2e-'));
-  mkdirSync(join(base, '.gsd', 'milestones'), { recursive: true });
-  return base;
-}
-
-function cleanup(base: string): void {
-  rmSync(base, { recursive: true, force: true });
-}
-
-function writeMilestoneDir(base: string, mid: string): void {
-  mkdirSync(join(base, '.gsd', 'milestones', mid), { recursive: true });
-}
-
-function writeContext(base: string, mid: string, frontmatter: string, body: string = ''): void {
-  const dir = join(base, '.gsd', 'milestones', mid);
-  mkdirSync(dir, { recursive: true });
-  const fm = frontmatter ? `---\n${frontmatter}\n---\n\n` : '';
-  writeFileSync(join(dir, `${mid}-CONTEXT.md`), `${fm}# ${mid}: Test\n\n${body}`);
-}
-
-function writeCompleteMilestone(base: string, mid: string): void {
-  const dir = join(base, '.gsd', 'milestones', mid);
-  mkdirSync(dir, { recursive: true });
-  writeFileSync(join(dir, `${mid}-ROADMAP.md`), `# ${mid}: Complete
-
-**Vision:** Done.
-
-## Slices
-
-- [x] **S01: Done** \`risk:low\` \`depends:[]\`
-  > After this: Done.
-`);
-  writeFileSync(join(dir, `${mid}-VALIDATION.md`), `---\nverdict: pass\nremediation_round: 0\n---\n\n# Validation\nPassed.`);
-  writeFileSync(join(dir, `${mid}-SUMMARY.md`), `# ${mid} Summary\n\nComplete.`);
-}
-
-function readContextFile(base: string, mid: string): string {
-  return readFileSync(join(base, '.gsd', 'milestones', mid, `${mid}-CONTEXT.md`), 'utf-8');
-}
-
-// ═══════════════════════════════════════════════════════════════════════════
-// Test: Queue order changes milestone activation
-// ═══════════════════════════════════════════════════════════════════════════
-
-
-describe('queue-reorder-e2e', () => {
-test('E2E: queue-order changes active milestone', async () => {
-  const base = createFixtureBase();
-  try {
-    // Setup: M007 complete, M008 and M009 pending (no context, no roadmap)
-    writeCompleteMilestone(base, 'M007');
-    writeMilestoneDir(base, 'M008');
-    writeContext(base, 'M008', '', 'Multi-Session Parallel Orchestration');
-    writeMilestoneDir(base, 'M009');
-    writeContext(base, 'M009', '', 'Context-Budget Visibility');
-
-    // Without custom order: M008 comes first (numeric sort)
-    invalidateStateCache();
-    const stateBefore = await deriveState(base);
-    assert.deepStrictEqual(stateBefore.activeMilestone?.id, 'M008', 'before reorder: M008 is active');
-
-    // Save custom order: M009 before M008
-    saveQueueOrder(base, ['M009', 'M008']);
-
-    // With custom order: M009 should be active
-    invalidateStateCache();
-    const stateAfter = await deriveState(base);
-    assert.deepStrictEqual(stateAfter.activeMilestone?.id, 'M009', 'after reorder: M009 is active');
-
-    // findMilestoneIds respects the order
-    const ids = findMilestoneIds(base);
-    const m008Idx = ids.indexOf('M008');
-    const m009Idx = ids.indexOf('M009');
-    assert.ok(m009Idx < m008Idx, 'findMilestoneIds: M009 comes before M008');
-
-  } finally {
-    cleanup(base);
-  }
-});
-
-// ═══════════════════════════════════════════════════════════════════════════
-// Test: Reorder + depends_on removal = correct state
-// ═══════════════════════════════════════════════════════════════════════════
-test('E2E: reorder with depends_on removal', async () => {
-  const base = createFixtureBase();
-  try {
-    // Setup: M007 complete, M008 depends_on M009, M009 no deps
-    writeCompleteMilestone(base, 'M007');
-    writeContext(base, 'M008', 'depends_on: [M009]', 'Multi-Session Parallel');
-    writeContext(base, 'M009', '', 'Context-Budget Visibility');
-
-    // Before: M008 depends on M009, so deriveState skips M008, M009 is active
-    invalidateStateCache();
-    const stateBefore = await deriveState(base);
-    assert.deepStrictEqual(stateBefore.activeMilestone?.id, 'M009', 'before: M009 active (M008 dep-blocked)');
-
-    // Simulate reorder confirm: save order M009→M008, remove depends_on from M008
-    saveQueueOrder(base, ['M009', 'M008']);
-
-    // Remove depends_on from M008-CONTEXT.md (simulating what handleQueueReorder does)
-    const contextContent = readContextFile(base, 'M008');
-    const newContent = contextContent.replace(/---\ndepends_on: \[M009\]\n---\n\n/, '');
-    writeFileSync(join(base, '.gsd', 'milestones', 'M008', 'M008-CONTEXT.md'), newContent);
-
-    // Verify: depends_on is gone
-    const updatedContent = readContextFile(base, 'M008');
-    const deps = parseContextDependsOn(updatedContent);
-    assert.deepStrictEqual(deps.length, 0, 'depends_on removed from M008-CONTEXT.md');
-
-    // Verify: deriveState still picks M009 (it's first in queue order)
-    invalidateStateCache();
-    const stateAfter = await deriveState(base);
-    assert.deepStrictEqual(stateAfter.activeMilestone?.id, 'M009', 'after: M009 still active (first in queue)');
-
-    // Verify: M008 is now pending (not dep-blocked)
-    const m008Entry = stateAfter.registry.find(m => m.id === 'M008');
-    assert.deepStrictEqual(m008Entry?.status, 'pending', 'M008 is pending (not dep-blocked)');
-    assert.ok(!m008Entry?.dependsOn || m008Entry.dependsOn.length === 0, 'M008 has no dependsOn');
-
-  } finally {
-    cleanup(base);
-  }
-});
-
-// ═══════════════════════════════════════════════════════════════════════════
-// Test: Fresh deriveState (simulating new session) respects queue order
-// ═══════════════════════════════════════════════════════════════════════════
-test('E2E: fresh session respects queue order', async () => {
-  const base = createFixtureBase();
-  try {
-    writeCompleteMilestone(base, 'M007');
-    writeContext(base, 'M008', '', 'Parallel Orchestration');
-    writeContext(base, 'M009', '', 'Budget Visibility');
-
-    // Save queue order
-    saveQueueOrder(base, ['M009', 'M008']);
-
-    // Simulate fresh session — invalidate all caches
-    invalidateStateCache();
-
-    // Derive state — should read QUEUE-ORDER.json from disk
-    const state = await deriveState(base);
-    assert.deepStrictEqual(state.activeMilestone?.id, 'M009', 'fresh session: M009 is active');
-
-    // Verify queue order persisted
-    const order = loadQueueOrder(base);
-    assert.deepStrictEqual(order, ['M009', 'M008'], 'QUEUE-ORDER.json persisted correctly');
-
-  } finally {
-    cleanup(base);
-  }
-});
-
-// ═══════════════════════════════════════════════════════════════════════════
-// Test: Queue order with newly added milestones
-// ═══════════════════════════════════════════════════════════════════════════
-test('E2E: new milestones appended to queue', async () => {
-  const base = createFixtureBase();
-  try {
-    writeCompleteMilestone(base, 'M007');
-    writeContext(base, 'M008', '', 'Parallel');
-    writeContext(base, 'M009', '', 'Visibility');
-
-    // Custom order only has M009, M008
-    saveQueueOrder(base, ['M009', 'M008']);
-
-    // Add M010 (not in queue order)
-    writeContext(base, 'M010', '', 'New feature');
-
-    invalidateStateCache();
-    const ids = findMilestoneIds(base);
-
-    // M009 first, M008 second, M010 appended at end
-    const m009Idx = ids.indexOf('M009');
-    const m008Idx = ids.indexOf('M008');
-    const m010Idx = ids.indexOf('M010');
-    assert.ok(m009Idx < m008Idx, 'M009 before M008');
-    assert.ok(m008Idx < m010Idx, 'M008 before M010 (new milestone appended)');
-
-    // M009 is still active (first non-complete in queue order)
-    const state = await deriveState(base);
-    assert.deepStrictEqual(state.activeMilestone?.id, 'M009', 'M009 still active after M010 added');
-
-  } finally {
-    cleanup(base);
-  }
-});
-
-// ═══════════════════════════════════════════════════════════════════════════
-// Test: No queue order file = default numeric sort (backward compat)
-// ═══════════════════════════════════════════════════════════════════════════
-test('E2E: backward compat without QUEUE-ORDER.json', async () => {
-  const base = createFixtureBase();
-  try {
-    writeCompleteMilestone(base, 'M007');
-    writeContext(base, 'M008', '', 'Parallel');
-    writeContext(base, 'M009', '', 'Visibility');
-
-    // No QUEUE-ORDER.json — default numeric sort
-    invalidateStateCache();
-    const state = await deriveState(base);
-    assert.deepStrictEqual(state.activeMilestone?.id, 'M008', 'no queue order: M008 active (numeric)');
-
-    const ids = findMilestoneIds(base);
-    assert.ok(ids.indexOf('M008') < ids.indexOf('M009'), 'default sort: M008 before M009');
-
-  } finally {
-    cleanup(base);
-  }
-});
-
-// ═══════════════════════════════════════════════════════════════════════════
-// Test: non-milestone directories are filtered out (#1494)
-// ═══════════════════════════════════════════════════════════════════════════
-test('E2E: non-milestone directories filtered from findMilestoneIds (#1494)', () => {
-  const base = createFixtureBase();
-  try {
-    writeContext(base, 'M001', '', 'First');
-    writeContext(base, 'M002', '', 'Second');
-    // Create a rogue non-milestone directory
-    mkdirSync(join(base, '.gsd', 'milestones', 'slices'), { recursive: true });
-    mkdirSync(join(base, '.gsd', 'milestones', 'temp-backup'), { recursive: true });
-
-    invalidateStateCache();
-    const ids = findMilestoneIds(base);
-    assert.deepStrictEqual(ids.length, 2, 'only M001 and M002 returned');
-    assert.ok(!ids.includes('slices'), 'slices directory excluded');
-    assert.ok(!ids.includes('temp-backup'), 'temp-backup directory excluded');
-    assert.ok(ids.includes('M001'), 'M001 included');
-    assert.ok(ids.includes('M002'), 'M002 included');
-  } finally {
-    cleanup(base);
-  }
-});
-
-// ═══════════════════════════════════════════════════════════════════════════
-// Test: depends_on inline array format removal
-// ═══════════════════════════════════════════════════════════════════════════
-test('E2E: depends_on inline format preserved after partial removal', () => {
-  const base = createFixtureBase();
-  try {
-    writeCompleteMilestone(base, 'M007');
-    // M008 depends on both M009 and M010
-    writeContext(base, 'M008', 'depends_on: [M009, M010]', 'Parallel');
-    writeContext(base, 'M009', '', 'Visibility');
-    writeContext(base, 'M010', '', 'Other');
-
-    // Verify both deps are parsed
-    const contentBefore = readContextFile(base, 'M008');
-    const depsBefore = parseContextDependsOn(contentBefore);
-    assert.deepStrictEqual(depsBefore.length, 2, 'M008 has 2 deps before');
-
-    // Simulate removing only M009 dep (keep M010)
-    const content = readContextFile(base, 'M008');
-    const updated = content.replace('depends_on: [M009, M010]', 'depends_on: [M010]');
-    writeFileSync(join(base, '.gsd', 'milestones', 'M008', 'M008-CONTEXT.md'), updated);
-
-    // Verify only M010 remains
-    const contentAfter = readContextFile(base, 'M008');
-    const depsAfter = parseContextDependsOn(contentAfter);
-    assert.deepStrictEqual(depsAfter.length, 1, 'M008 has 1 dep after removal');
-    assert.deepStrictEqual(depsAfter[0], 'M010', 'remaining dep is M010');
-
-  } finally {
-    cleanup(base);
-  }
-});
-
-test('E2E: DB-backed path respects queue order (#2556)', async () => {
-    // Regression test for #2556: getActiveMilestoneId and deriveStateFromDb
-    // used lexicographic sort instead of queue order, causing a deadlock when
-    // the dispatch guard (which respects queue order) blocked completion.
-    const base = createFixtureBase();
-    try {
-      const { openDatabase, closeDatabase, insertMilestone, isDbAvailable } = await import('../../gsd-db.ts');
-      const dbPath = join(base, '.gsd', 'gsd.db');
-
-      // Create milestone directories (required for findMilestoneIds)
-      writeMilestoneDir(base, 'M006');
-      writeContext(base, 'M006', '', 'Earlier milestone');
-      writeMilestoneDir(base, 'M008');
-      writeContext(base, 'M008', '', 'Later milestone');
-
-      // Open DB and insert milestones
-      openDatabase(dbPath);
-      try {
-        insertMilestone({ id: 'M006', title: 'Earlier', status: 'active' });
-        insertMilestone({ id: 'M008', title: 'Later', status: 'active' });
-
-        // Set queue order: M008 should come FIRST (user reordered via /gsd queue)
-        saveQueueOrder(base, ['M008', 'M006']);
-
-        // deriveState should pick M008 (queue-first), not M006 (ID-first)
-        invalidateStateCache();
-        const state = await deriveState(base);
-        assert.equal(
-          state.activeMilestone?.id,
-          'M008',
-          'DB-backed deriveState must respect queue order — M008 is queued first',
-        );
-      } finally {
-        if (isDbAvailable()) closeDatabase();
-      }
-    } finally {
-      cleanup(base);
-    }
-});
-
-});

package/src/resources/extensions/gsd/tests/integration/worktree-e2e.test.ts

@@ -1,248 +0,0 @@
-/**
- * worktree-e2e.test.ts -- End-to-end tests for worktree-isolated git flow.
- *
- * Covers cross-cutting groups not tested by individual slice tests:
- *   1. Full lifecycle chain (create -> slice commits -> merge to milestone -> merge to main)
- *   2. Self-heal: abortAndReset cleans up failed merges
- *   3. Doctor detection of orphaned worktrees
- */
-
-import {
-  mkdtempSync, mkdirSync, writeFileSync, rmSync,
-  existsSync, realpathSync,
-} from "node:fs";
-import { join } from "node:path";
-import { tmpdir } from "node:os";
-import { execSync } from "node:child_process";
-
-import {
-  createAutoWorktree,
-  mergeMilestoneToMain,
-} from "../../auto-worktree.ts";
-import { getSliceBranchName } from "../../worktree.ts";
-import { abortAndReset } from "../../git-self-heal.ts";
-import { runGSDDoctor } from "../../doctor.ts";
-import { describe, test } from 'node:test';
-import assert from 'node:assert/strict';
-
-
-// ---- Helpers ----
-
-function run(cmd: string, cwd: string): string {
-  return execSync(cmd, { cwd, stdio: ["ignore", "pipe", "pipe"], encoding: "utf-8" }).trim();
-}
-
-function createTempRepo(): string {
-  const dir = realpathSync(mkdtempSync(join(tmpdir(), "wt-e2e-test-")));
-  run("git init", dir);
-  run("git config user.email test@test.com", dir);
-  run("git config user.name Test", dir);
-  writeFileSync(join(dir, "README.md"), "# test\n");
-  mkdirSync(join(dir, ".gsd"), { recursive: true });
-  writeFileSync(join(dir, ".gsd", "STATE.md"), "# State\n");
-  run("git add .", dir);
-  run("git commit -m init", dir);
-  run("git branch -M main", dir);
-  return dir;
-}
-
-function makeRoadmap(
-  milestoneId: string,
-  title: string,
-  slices: Array<{ id: string; title: string }>,
-): string {
-  const sliceLines = slices.map(s => `- [x] **${s.id}: ${s.title}**`).join("\n");
-  return `# ${milestoneId}: ${title}\n\n## Slices\n${sliceLines}\n`;
-}
-
-function addSliceToMilestone(
-  _repo: string,
-  wtPath: string,
-  milestoneId: string,
-  sliceId: string,
-  _sliceTitle: string,
-  commits: Array<{ file: string; content: string; message: string }>,
-): void {
-  const normalizedPath = wtPath.replaceAll("\\", "/");
-  const marker = "/.gsd/worktrees/";
-  const idx = normalizedPath.indexOf(marker);
-  const worktreeName = idx !== -1 ? normalizedPath.slice(idx + marker.length).split("/")[0] : null;
-
-  const sliceBranch = getSliceBranchName(milestoneId, sliceId, worktreeName);
-
-  run(`git checkout -b ${sliceBranch}`, wtPath);
-  for (const c of commits) {
-    writeFileSync(join(wtPath, c.file), c.content);
-    run("git add .", wtPath);
-    run(`git commit -m "${c.message}"`, wtPath);
-  }
-  run(`git checkout milestone/${milestoneId}`, wtPath);
-  run(`git merge --no-ff ${sliceBranch} -m "merge ${sliceId}"`, wtPath);
-}
-
-describe('worktree-e2e', async () => {
-  const savedCwd = process.cwd();
-  const tempDirs: string[] = [];
-
-  try {
-    // ================================================================
-    // Group 1: Full lifecycle chain
-    // ================================================================
-    console.log("\n=== Full lifecycle: worktree -> slices -> milestone merge -> main ===");
-    {
-      const repo = createTempRepo();
-      tempDirs.push(repo);
-
-      // Count commits on main before
-      const mainLogBefore = run("git log --oneline main", repo);
-      const commitCountBefore = mainLogBefore.split("\n").length;
-
-      // Create worktree for M001
-      const wtPath = createAutoWorktree(repo, "M001");
-      tempDirs.push(wtPath);
-      assert.ok(existsSync(wtPath), "worktree directory created");
-
-      // Add two slices with commits
-      addSliceToMilestone(repo, wtPath, "M001", "S01", "Add auth", [
-        { file: "auth.ts", content: "export const auth = true;\n", message: "feat: add auth" },
-      ]);
-      addSliceToMilestone(repo, wtPath, "M001", "S02", "Add dashboard", [
-        { file: "dash.ts", content: "export const dash = true;\n", message: "feat: add dashboard" },
-      ]);
-
-      // Build roadmap content
-      const roadmapContent = makeRoadmap("M001", "First milestone", [
-        { id: "S01", title: "Add auth" },
-        { id: "S02", title: "Add dashboard" },
-      ]);
-
-      // Merge milestone to main
-      process.chdir(wtPath);
-      const result = mergeMilestoneToMain(repo, "M001", roadmapContent);
-      process.chdir(savedCwd);
-
-      // Assert exactly one new commit on main
-      const mainLogAfter = run("git log --oneline main", repo);
-      const commitCountAfter = mainLogAfter.split("\n").length;
-      assert.deepStrictEqual(commitCountAfter, commitCountBefore + 1, "exactly one new commit on main");
-
-      // Commit message contains both slice titles
-      const lastCommitMsg = run("git log -1 --format=%B main", repo);
-      assert.match(lastCommitMsg, /Add auth/, "commit message contains S01 title");
-      assert.match(lastCommitMsg, /Add dashboard/, "commit message contains S02 title");
-
-      // Worktree directory removed
-      assert.ok(!existsSync(wtPath), "worktree directory removed after merge");
-
-      // Milestone branch deleted
-      const branches = run("git branch", repo);
-      assert.ok(!branches.includes("milestone/M001"), "milestone branch deleted");
-    }
-
-    // ================================================================
-    // Group 2: Self-heal (abortAndReset)
-    // ================================================================
-    console.log("\n=== Self-heal ===");
-    {
-      const repo = createTempRepo();
-      tempDirs.push(repo);
-
-      // Create conflicting branches
-      run("git checkout -b feature", repo);
-      writeFileSync(join(repo, "conflict.txt"), "feature content\n");
-      run("git add .", repo);
-      run("git commit -m feature", repo);
-      run("git checkout main", repo);
-      writeFileSync(join(repo, "conflict.txt"), "main content\n");
-      run("git add .", repo);
-      run("git commit -m main-change", repo);
-
-      // Trigger merge conflict
-      try { run("git merge feature", repo); } catch { /* expected */ }
-      assert.ok(existsSync(join(repo, ".git", "MERGE_HEAD")), "MERGE_HEAD exists before abort");
-
-      const abortResult = abortAndReset(repo);
-      assert.ok(!existsSync(join(repo, ".git", "MERGE_HEAD")), "MERGE_HEAD removed after abort");
-      assert.ok(abortResult.cleaned.length > 0, "abortAndReset reports cleaned items");
-    }
-
-    // ================================================================
-    // Group 3: Doctor detects orphaned worktrees
-    // Skip on Windows: git worktree path resolution in temp dirs uses
-    // UNC/8.3 forms that don't match after normalization.
-    // ================================================================
-    if (process.platform !== "win32") {
-    console.log("\n=== Doctor: orphaned worktree detection ===");
-    {
-      // Build a repo with a completed milestone
-      const repo = createTempRepo();
-      tempDirs.push(repo);
-
-      // Create completed milestone roadmap
-      const msDir = join(repo, ".gsd", "milestones", "M001");
-      mkdirSync(msDir, { recursive: true });
-      writeFileSync(join(msDir, "ROADMAP.md"), `---
-id: M001
-title: "Test Milestone"
----
-
-# M001: Test Milestone
-
-## Vision
-Test
-
-## Success Criteria
-- Done
-
-## Slices
-- [x] **S01: Test slice** \`risk:low\` \`depends:[]\`
-  > After this: done
-
-## Boundary Map
-_None_
-`);
-      writeFileSync(join(msDir, "M001-SUMMARY.md"), `---
-id: M001
-title: "Test Milestone"
-status: complete
-completed_at: 2026-04-18T00:00:00Z
----
-
-# M001: Test Milestone
-
-Completed.
-`);
-      run("git add -A", repo);
-      run("git commit -m \"add milestone\"", repo);
-
-      // Create orphaned worktree
-      mkdirSync(join(repo, ".gsd", "worktrees"), { recursive: true });
-      run("git worktree add -b milestone/M001 .gsd/worktrees/M001", repo);
-
-      // Detect
-      const detect = await runGSDDoctor(repo, { isolationMode: "worktree" });
-      const orphanIssues = detect.issues.filter(i => i.code === "orphaned_auto_worktree");
-      assert.ok(orphanIssues.length > 0, "doctor detects orphaned worktree");
-      assert.deepStrictEqual(orphanIssues[0]?.unitId, "M001", "orphaned worktree unitId is M001");
-
-      // Fix
-      const fixed = await runGSDDoctor(repo, { fix: true, isolationMode: "worktree" });
-      assert.ok(
-        fixed.fixesApplied.some(f => f.includes("removed orphaned worktree")),
-        "doctor fix removes orphaned worktree",
-      );
-
-      // Verify gone
-      const wtList = run("git worktree list", repo);
-      assert.ok(!wtList.includes("milestone/M001"), "worktree gone after doctor fix");
-    }
-    } else {
-      console.log("\n=== Doctor: orphaned worktree detection (skipped on Windows) ===");
-    }
-  } finally {
-    process.chdir(savedCwd);
-    for (const d of tempDirs) {
-      try { rmSync(d, { recursive: true, force: true }); } catch { /* ignore */ }
-    }
-  }
-});