@opengsd/gsd-pi 1.0.1 → 1.0.2

package/src/resources/extensions/gsd/tests/integration/doctor-false-positives.test.ts

@@ -1,243 +0,0 @@
-import { describe, test } from 'node:test';
-import assert from 'node:assert/strict';
-import { mkdtempSync, mkdirSync, rmSync, writeFileSync, existsSync, readdirSync } from "node:fs";
-import { join } from "node:path";
-import { tmpdir } from "node:os";
-
-import { runGSDDoctor } from "../../doctor.js";
-import { parsePlan } from "../../parsers-legacy.js";
-
-// ── Helpers ─────────────────────────────────────────────────────────────────
-
-function makeBase(): { base: string; gsd: string; mDir: string } {
-  const base = mkdtempSync(join(tmpdir(), "gsd-doctor-fp-"));
-  const gsd = join(base, ".gsd");
-  const mDir = join(gsd, "milestones", "M001");
-  mkdirSync(join(mDir, "slices"), { recursive: true });
-  return { base, gsd, mDir };
-}
-
-function writeRoadmap(mDir: string, content: string): void {
-  writeFileSync(join(mDir, "M001-ROADMAP.md"), content);
-}
-
-function writeSlice(mDir: string, sliceId: string, planContent: string): string {
-  const sDir = join(mDir, "slices", sliceId);
-  const tDir = join(sDir, "tasks");
-  mkdirSync(tDir, { recursive: true });
-  writeFileSync(join(sDir, `${sliceId}-PLAN.md`), planContent);
-  return sDir;
-}
-
-describe('doctor false-positives (#3105)', async () => {
-
-  // ═══════════════════════════════════════════════════════════════════════════
-  // Bug 1: Orphaned worktree directory recreated by appendDoctorHistory
-  // ═══════════════════════════════════════════════════════════════════════════
-
-  test('Bug 1: orphaned worktree check ignores dirs containing only .gsd/doctor-history.jsonl', async () => {
-    // Simulate: a worktree dir that only contains .gsd/doctor-history.jsonl
-    // (created by appendDoctorHistory writing to the worktree-scoped path).
-    // The orphan check should NOT warn about this directory.
-    const { base, gsd } = makeBase();
-    writeRoadmap(join(gsd, "milestones", "M001"), `# M001: Test\n\n## Slices\n- [ ] **S01: Slice** \`risk:low\` \`depends:[]\`\n  > After this: done\n`);
-    writeSlice(join(gsd, "milestones", "M001"), "S01", "# S01: Slice\n\n**Goal:** G\n**Demo:** D\n\n## Tasks\n- [ ] **T01: Task** `est:10m`\n  Pending.\n");
-
-    // Create a worktree directory that only has .gsd/doctor-history.jsonl
-    const wtDir = join(gsd, "worktrees", "M042");
-    const wtGsdDir = join(wtDir, ".gsd");
-    mkdirSync(wtGsdDir, { recursive: true });
-    writeFileSync(join(wtGsdDir, "doctor-history.jsonl"), '{"ts":"2026-01-01","ok":true}\n');
-
-    const result = await runGSDDoctor(base, { fix: false });
-
-    // Should NOT produce worktree_directory_orphaned for a dir that only has doctor history
-    const orphanIssues = result.issues.filter(
-      i => i.code === "worktree_directory_orphaned" && i.unitId === "M042"
-    );
-    assert.equal(orphanIssues.length, 0,
-      "should not warn about worktree dir that only contains .gsd/doctor-history.jsonl");
-
-    rmSync(base, { recursive: true, force: true });
-  });
-
-  // ═══════════════════════════════════════════════════════════════════════════
-  // Bug 2: blocker_discovered + all tasks done = unfixable deadlock
-  // ═══════════════════════════════════════════════════════════════════════════
-
-  test('Bug 2: blocker_discovered with all tasks done should not warn (implicitly resolved)', async () => {
-    // Scenario: blocker was discovered and resolved within the same task.
-    // blocker_discovered: true, no REPLAN, but all tasks are done.
-    // Neither blocker_discovered_no_replan nor stale_replan_file should fire.
-    const { base, mDir } = makeBase();
-    writeRoadmap(mDir, `# M001: Blocker Test\n\n## Slices\n- [ ] **S01: Slice** \`risk:low\` \`depends:[]\`\n  > After this: done\n`);
-    const sDir = writeSlice(mDir, "S01",
-      "# S01: Slice\n\n**Goal:** G\n**Demo:** D\n\n## Tasks\n- [x] **T01: Task** `est:10m`\n  Done.\n");
-    writeFileSync(join(sDir, "tasks", "T01-SUMMARY.md"), `---
-id: T01
-parent: S01
-milestone: M001
-provides: []
-requires: []
-affects: []
-key_files: []
-key_decisions: []
-patterns_established: []
-observability_surfaces: []
-drill_down_paths: []
-duration: 10m
-verification_result: passed
-completed_at: 2026-01-01T00:00:00Z
-blocker_discovered: true
----
-
-# T01: Task
-
-**Done**
-
-## What Happened
-Found a blocker, resolved it in-task.
-
-## Diagnostics
-- log
-`);
-
-    const result = await runGSDDoctor(base, { fix: false });
-
-    // Should NOT produce blocker_discovered_no_replan when all tasks are done
-    const blockerIssues = result.issues.filter(i => i.code === "blocker_discovered_no_replan");
-    assert.equal(blockerIssues.length, 0,
-      "should not warn about blocker_discovered when all tasks are done (blocker was implicitly resolved)");
-
-    // Also should NOT produce stale_replan_file (no REPLAN exists, so this shouldn't fire anyway)
-    const staleReplanIssues = result.issues.filter(i => i.code === "stale_replan_file");
-    assert.equal(staleReplanIssues.length, 0,
-      "should not produce stale_replan_file when no REPLAN exists");
-
-    rmSync(base, { recursive: true, force: true });
-  });
-
-  test('Bug 2: blocker_discovered with incomplete tasks should still warn', async () => {
-    // Sanity check: when there IS an incomplete task and blocker_discovered, warn as before.
-    const { base, mDir } = makeBase();
-    writeRoadmap(mDir, `# M001: Blocker Warn Test\n\n## Slices\n- [ ] **S01: Slice** \`risk:low\` \`depends:[]\`\n  > After this: done\n`);
-    const sDir = writeSlice(mDir, "S01",
-      "# S01: Slice\n\n**Goal:** G\n**Demo:** D\n\n## Tasks\n- [x] **T01: Task A** `est:10m`\n  Done.\n- [ ] **T02: Task B** `est:10m`\n  Pending.\n");
-    writeFileSync(join(sDir, "tasks", "T01-SUMMARY.md"), `---
-id: T01
-parent: S01
-milestone: M001
-provides: []
-requires: []
-affects: []
-key_files: []
-key_decisions: []
-patterns_established: []
-observability_surfaces: []
-drill_down_paths: []
-duration: 10m
-verification_result: passed
-completed_at: 2026-01-01T00:00:00Z
-blocker_discovered: true
----
-
-# T01: Task A
-
-**Done**
-
-## What Happened
-Found blocker, but T02 is still pending.
-
-## Diagnostics
-- log
-`);
-
-    const result = await runGSDDoctor(base, { fix: false });
-
-    const blockerIssues = result.issues.filter(i => i.code === "blocker_discovered_no_replan");
-    assert.ok(blockerIssues.length > 0,
-      "should still warn about blocker_discovered when some tasks are not done");
-
-    rmSync(base, { recursive: true, force: true });
-  });
-
-  // ═══════════════════════════════════════════════════════════════════════════
-  // Bug 3: Multi-task plan — T02+ outside ## Tasks section
-  // ═══════════════════════════════════════════════════════════════════════════
-
-  test('Bug 3: parsePlan finds all tasks even when interleaved with detail sections', () => {
-    // Multi-task plan where T02 checkbox appears after T01's ## Steps heading,
-    // which ends the ## Tasks section for extractSection().
-    const planContent = `# S01: Demo Slice
-
-**Goal:** Build the demo
-**Demo:** Run it
-
-## Must-Haves
-- Feature A
-
-## Tasks
-- [x] **T01: First task** \`est:30m\`
-  Implement the first thing.
-## Steps
-1. Step one
-2. Step two
-## Must-Haves
-- Requirement A
-- [x] **T02: Second task** \`est:1h\`
-  Implement the second thing.
-## Steps
-1. Step one
-2. Step two
-`;
-
-    const plan = parsePlan(planContent);
-    const taskIds = plan.tasks.map(t => t.id);
-
-    assert.ok(taskIds.includes("T01"), "should find T01");
-    assert.ok(taskIds.includes("T02"), "should find T02 even when after T01 detail headings");
-    assert.equal(plan.tasks.length, 2, "should find exactly 2 tasks");
-  });
-
-  test('Bug 3: task_file_not_in_plan should not fire for T02 in multi-task plan', async () => {
-    const { base, mDir } = makeBase();
-    writeRoadmap(mDir, `# M001: Multi-Task Test\n\n## Slices\n- [ ] **S01: Slice** \`risk:low\` \`depends:[]\`\n  > After this: done\n`);
-
-    // Plan with interleaved headings (the problematic format)
-    const sDir = writeSlice(mDir, "S01", `# S01: Demo Slice
-
-**Goal:** Build the demo
-**Demo:** Run it
-
-## Must-Haves
-- Feature A
-
-## Tasks
-- [x] **T01: First task** \`est:30m\`
-  Implement the first thing.
-## Steps
-1. Step one
-## Must-Haves
-- Req A
-- [x] **T02: Second task** \`est:1h\`
-  Implement the second thing.
-## Steps
-1. Step one
-`);
-
-    // Both tasks have summaries on disk
-    writeFileSync(join(sDir, "tasks", "T01-SUMMARY.md"), "---\nstatus: done\ncompleted_at: 2026-01-01T00:00:00Z\n---\n# T01\nDone.\n");
-    writeFileSync(join(sDir, "tasks", "T02-SUMMARY.md"), "---\nstatus: done\ncompleted_at: 2026-01-01T00:00:00Z\n---\n# T02\nDone.\n");
-
-    const result = await runGSDDoctor(base, { fix: false });
-
-    // T02 should NOT be flagged as "not in plan"
-    const notInPlan = result.issues.filter(
-      i => i.code === "task_file_not_in_plan" && i.message.includes("T02")
-    );
-    assert.equal(notInPlan.length, 0,
-      "should not report T02 as 'not in plan' when it exists in the interleaved plan format");
-
-    rmSync(base, { recursive: true, force: true });
-  });
-});

package/src/resources/extensions/gsd/tests/integration/doctor-fixlevel.test.ts

@@ -1,263 +0,0 @@
-/**
- * Tests that doctor's fixLevel option correctly separates task-level
- * bookkeeping from completion state transitions.
- *
- * With reconciliation codes removed (S06), doctor no longer creates
- * summary stubs, UAT stubs, or flips checkboxes. These tests verify
- * the fix infrastructure still works for remaining fixable codes
- * (e.g. delimiter_in_title, missing_tasks_dir) and that removed
- * reconciliation codes are truly absent.
- */
-
-import { mkdirSync, writeFileSync, rmSync, readFileSync, existsSync } from "node:fs";
-import { join } from "node:path";
-import { tmpdir } from "node:os";
-import test from "node:test";
-import assert from "node:assert/strict";
-import { runGSDDoctor } from "../../doctor.ts";
-import { closeDatabase, insertMilestone, insertSlice, openDatabase } from "../../gsd-db.ts";
-
-function makeTmp(name: string): string {
-  const dir = join(tmpdir(), `doctor-fixlevel-${name}-${Date.now()}-${Math.random().toString(36).slice(2)}`);
-  mkdirSync(dir, { recursive: true });
-  return dir;
-}
-
-/**
- * Build a minimal .gsd structure: milestone with one slice, one task
- * marked done with a summary — but no slice summary and roadmap unchecked.
- * Previously this triggered reconciliation; now it should produce no
- * reconciliation issue codes.
- */
-function buildScaffold(base: string) {
-  const gsd = join(base, ".gsd");
-  const m = join(gsd, "milestones", "M001");
-  const s = join(m, "slices", "S01", "tasks");
-  mkdirSync(s, { recursive: true });
-
-  writeFileSync(join(m, "M001-ROADMAP.md"), `# M001: Test
-
-## Slices
-
-- [ ] **S01: Test Slice** \`risk:low\` \`depends:[]\`
-  > Demo text
-`);
-
-  writeFileSync(join(m, "slices", "S01", "S01-PLAN.md"), `# S01: Test Slice
-
-**Goal:** test
-
-## Tasks
-
-- [x] **T01: Do stuff** \`est:5m\`
-`);
-
-  writeFileSync(join(s, "T01-SUMMARY.md"), `---
-id: T01
-parent: S01
-milestone: M001
-duration: 5m
-verification_result: passed
-completed_at: 2026-01-01
----
-
-# T01: Do stuff
-
-Done.
-`);
-}
-
-const REMOVED_CODES = [
-  "task_done_missing_summary",
-  "task_summary_without_done_checkbox",
-  "all_tasks_done_missing_slice_summary",
-  "all_tasks_done_missing_slice_uat",
-  "all_tasks_done_roadmap_not_checked",
-  "slice_checked_missing_summary",
-  "slice_checked_missing_uat",
-];
-
-test("fixLevel:task — no reconciliation issue codes are reported", async (t) => {
-  const tmp = makeTmp("task-level");
-  t.after(() => rmSync(tmp, { recursive: true, force: true }));
-
-  buildScaffold(tmp);
-
-  const report = await runGSDDoctor(tmp, { fix: true, fixLevel: "task" });
-
-  const codes = report.issues.map(i => i.code);
-  for (const removed of REMOVED_CODES) {
-    assert.ok(!codes.includes(removed as any), `should NOT report removed code: ${removed}`);
-  }
-});
-
-test("fixLevel:all — no reconciliation issue codes are reported", async (t) => {
-  const tmp = makeTmp("all-level");
-  t.after(() => rmSync(tmp, { recursive: true, force: true }));
-
-  buildScaffold(tmp);
-
-  const report = await runGSDDoctor(tmp, { fix: true });
-
-  const codes = report.issues.map(i => i.code);
-  for (const removed of REMOVED_CODES) {
-    assert.ok(!codes.includes(removed as any), `should NOT report removed code: ${removed}`);
-  }
-
-  // Summary and UAT stubs should NOT be created (no reconciliation)
-  const sliceSummaryPath = join(tmp, ".gsd", "milestones", "M001", "slices", "S01", "S01-SUMMARY.md");
-  assert.ok(!existsSync(sliceSummaryPath), "should NOT have created summary stub");
-
-  // Roadmap should remain unchecked (no reconciliation)
-  const roadmapContent = readFileSync(join(tmp, ".gsd", "milestones", "M001", "M001-ROADMAP.md"), "utf8");
-  assert.ok(roadmapContent.includes("- [ ] **S01"), "roadmap should remain unchecked");
-});
-
-test("legacy roadmap fallback: future slices are treated as pending, active slice is not", async (t) => {
-  const tmp = makeTmp("legacy-pending-fallback");
-  t.after(() => {
-    try { closeDatabase(); } catch { /* noop */ }
-    rmSync(tmp, { recursive: true, force: true });
-  });
-
-  // Force the legacy parser branch.
-  try { closeDatabase(); } catch { /* noop */ }
-
-  const gsd = join(tmp, ".gsd");
-  const m = join(gsd, "milestones", "M001");
-  const s01 = join(m, "slices", "S01", "tasks");
-  mkdirSync(s01, { recursive: true });
-
-  writeFileSync(join(m, "M001-ROADMAP.md"), `# M001: Test
-
-## Slices
-
-- [x] **S01: Done Slice** \`risk:low\` \`depends:[]\`
-  > Done
-- [ ] **S02: Active Slice** \`risk:medium\` \`depends:[S01]\`
-  > In progress
-- [ ] **S03: Future Slice** \`risk:low\` \`depends:[S02]\`
-  > Later
-- [ ] **S04: Future Slice Two** \`risk:low\` \`depends:[S03]\`
-  > Later
-`);
-
-  writeFileSync(join(m, "slices", "S01", "S01-PLAN.md"), `# S01: Done Slice
-
-**Goal:** done
-
-## Tasks
-
-- [x] **T01: Done task** \`est:5m\`
-`);
-
-  // Active slice exists in state/registry but has no directory yet — this should
-  // still be reported as a real error, while future untouched slices should be skipped.
-  const report = await runGSDDoctor(tmp, { scope: "M001" });
-  const missingSliceDirUnits = report.issues
-    .filter(i => i.code === "missing_slice_dir")
-    .map(i => i.unitId)
-    .sort();
-
-  assert.deepStrictEqual(
-    missingSliceDirUnits,
-    ["M001/S02"],
-    "legacy fallback should only report the active slice, not future unstarted slices",
-  );
-
-  const missingTasksDirUnits = report.issues
-    .filter(i => i.code === "missing_tasks_dir")
-    .map(i => i.unitId)
-    .sort();
-
-  assert.deepStrictEqual(
-    missingTasksDirUnits,
-    [],
-    "future slices without directories should be skipped before missing_tasks_dir checks",
-  );
-});
-
-test("db skipped slices do not report missing directories", async (t) => {
-  const tmp = makeTmp("skipped-slice-dir");
-  t.after(() => {
-    try { closeDatabase(); } catch { /* noop */ }
-    rmSync(tmp, { recursive: true, force: true });
-  });
-
-  const gsd = join(tmp, ".gsd");
-  const m = join(gsd, "milestones", "M001");
-  mkdirSync(m, { recursive: true });
-
-  writeFileSync(join(m, "M001-ROADMAP.md"), `# M001: Test
-
-## Slices
-
-- [ ] **S05: Skipped Slice** \`risk:low\` \`depends:[]\`
-  > Intentionally skipped
-`);
-
-  openDatabase(join(gsd, "gsd.db"));
-  insertMilestone({ id: "M001", title: "Test", status: "active" });
-  insertSlice({ id: "S05", milestoneId: "M001", title: "Skipped Slice", status: "skipped", sequence: 5 });
-
-  const report = await runGSDDoctor(tmp, { scope: "M001" });
-  const missingDirIssues = report.issues.filter(
-    i =>
-      (i.code === "missing_slice_dir" || i.code === "missing_tasks_dir") &&
-      i.unitId === "M001/S05",
-  );
-
-  assert.deepStrictEqual(
-    missingDirIssues,
-    [],
-    "skipped slices should not require slice or tasks directories",
-  );
-});
-
-test("doctor source treats skipped DB slices as closed and directory-optional", () => {
-  const doctorSource = readFileSync(join(process.cwd(), "src/resources/extensions/gsd/doctor.ts"), "utf8");
-  assert.match(
-    doctorSource,
-    /done:\s*isClosedStatus\(s\.status\)/,
-    "doctor should normalize skipped DB slices through isClosedStatus()",
-  );
-  assert.match(
-    doctorSource,
-    /if \(slice\.pending \|\| slice\.skipped\) continue;/,
-    "doctor should skip missing-directory checks for skipped slices",
-  );
-});
-
-test("fixLevel:all — delimiter_in_title still fixable", async (t) => {
-  const tmp = makeTmp("delimiter-fix");
-  t.after(() => rmSync(tmp, { recursive: true, force: true }));
-
-  const gsd = join(tmp, ".gsd");
-  const m = join(gsd, "milestones", "M001");
-  const s = join(m, "slices", "S01", "tasks");
-  mkdirSync(s, { recursive: true });
-
-  // Roadmap with em dash in milestone title (should still be fixable)
-  writeFileSync(join(m, "M001-ROADMAP.md"), `# M001: Foundation \u2014 Build Core
-
-## Slices
-
-- [ ] **S01: Test Slice** \`risk:low\` \`depends:[]\`
-  > Demo
-`);
-
-  writeFileSync(join(m, "slices", "S01", "S01-PLAN.md"), `# S01: Test Slice
-
-**Goal:** test
-
-## Tasks
-
-- [ ] **T01: Do stuff** \`est:5m\`
-`);
-
-  const report = await runGSDDoctor(tmp, { fix: true });
-
-  // The milestone-level delimiter is auto-fixed, but the report may or may not include it
-  // depending on whether it was fixed successfully. Just verify it ran without crashing.
-  assert.ok(report.issues !== undefined, "doctor produces a report");
-});

package/src/resources/extensions/gsd/tests/integration/doctor-git-symlink-cwd.test.ts

@@ -1,90 +0,0 @@
-import assert from "node:assert/strict";
-import { execSync } from "node:child_process";
-import { mkdtempSync, mkdirSync, realpathSync, rmSync, symlinkSync, writeFileSync } from "node:fs";
-import { tmpdir } from "node:os";
-import { join } from "node:path";
-import { test } from "node:test";
-
-import { runGSDDoctor } from "../../doctor.ts";
-
-function run(cmd: string, cwd: string): string {
-  return execSync(cmd, { cwd, stdio: ["ignore", "pipe", "pipe"], encoding: "utf-8" }).trim();
-}
-
-function createRepoWithCompletedMilestone(): string {
-  const dir = realpathSync(mkdtempSync(join(tmpdir(), "doc-git-symlink-cwd-")));
-  run("git init", dir);
-  run("git config user.email test@test.com", dir);
-  run("git config user.name Test", dir);
-
-  writeFileSync(join(dir, "README.md"), "# test\n");
-  run("git add .", dir);
-  run("git commit -m init", dir);
-  run("git branch -M main", dir);
-
-  const milestoneDir = join(dir, ".gsd", "milestones", "M001");
-  mkdirSync(milestoneDir, { recursive: true });
-  writeFileSync(join(milestoneDir, "ROADMAP.md"), `---
-id: M001
-title: "Test Milestone"
----
-
-# M001: Test Milestone
-
-## Vision
-Test
-
-## Success Criteria
-- Done
-
-## Slices
-- [x] **S01: Test slice** \`risk:low\` \`depends:[]\`
-  > After this: done
-
-## Boundary Map
-_None_
-`);
-  writeFileSync(join(milestoneDir, "M001-SUMMARY.md"), `---
-id: M001
-title: "Test Milestone"
-status: complete
-completed_at: 2026-04-18T00:00:00Z
----
-
-# M001: Test Milestone
-
-Completed.
-`);
-
-  run("git add -A", dir);
-  run("git commit -m \"add milestone\"", dir);
-
-  return dir;
-}
-
-test("doctor removes orphaned milestone worktree when cwd uses a symlink alias", { skip: process.platform === "win32" }, async (t) => {
-  const previousCwd = process.cwd();
-  const dir = createRepoWithCompletedMilestone();
-  const alias = join(tmpdir(), `doc-git-alias-${Date.now()}-${Math.random().toString(16).slice(2)}`);
-
-  t.after(() => {
-    try { process.chdir(previousCwd); } catch { process.chdir(tmpdir()); }
-    rmSync(alias, { recursive: true, force: true });
-    rmSync(dir, { recursive: true, force: true });
-  });
-
-  mkdirSync(join(dir, ".gsd", "worktrees"), { recursive: true });
-  run("git worktree add -b milestone/M001 .gsd/worktrees/M001", dir);
-
-  symlinkSync(dir, alias);
-  process.chdir(join(alias, ".gsd", "worktrees", "M001"));
-
-  const fixed = await runGSDDoctor(dir, { fix: true, isolationMode: "worktree" });
-  assert.ok(
-    fixed.fixesApplied.some(f => f.includes("removed orphaned worktree")),
-    `removes orphaned worktree even when cwd uses a symlink alias (got: ${JSON.stringify(fixed.fixesApplied)})`,
-  );
-
-  const wtList = run("git worktree list", dir);
-  assert.ok(!wtList.includes("milestone/M001"), "worktree removed after symlink-cwd fix");
-});