@opengsd/gsd-pi 1.0.1 → 1.0.2

package/src/resources/extensions/gsd/tests/discuss-queued-milestones.test.ts

@@ -1,170 +0,0 @@
-/**
- * discuss-queued-milestones.test.ts — Tests for #2307.
- *
- * /gsd discuss was previously gated on state.activeMilestone, which prevented
- * users from discussing queued (pending) milestones during roadmap grooming.
- *
- * These tests verify:
- *   1. deriveState correctly identifies pending milestones (the set the picker
- *      will show when no active milestone is present)
- *   2. resolveMilestoneFile correctly resolves context artifacts for pending
- *      milestones so the picker can report their discussion state
- *   3. The guided-flow.ts source code no longer hard-exits when no active
- *      milestone exists but pending milestones are present
- *   4. The helper functions for queued discuss exist in the source
- */
-
-import { describe, test, afterEach } from "node:test";
-import assert from "node:assert/strict";
-import { mkdtempSync, mkdirSync, rmSync, writeFileSync } from "node:fs";
-import { join } from "node:path";
-import { tmpdir } from "node:os";
-
-import { deriveState } from "../state.ts";
-import { invalidateAllCaches } from "../cache.ts";
-import { resolveMilestoneFile } from "../paths.ts";
-
-// ─── Fixture Helpers ──────────────────────────────────────────────────────────
-
-function createBase(): string {
-  const base = mkdtempSync(join(tmpdir(), "gsd-discuss-queued-"));
-  mkdirSync(join(base, ".gsd", "milestones"), { recursive: true });
-  return base;
-}
-
-function cleanup(base: string): void {
-  rmSync(base, { recursive: true, force: true });
-}
-
-function writeMilestoneDir(base: string, mid: string): void {
-  mkdirSync(join(base, ".gsd", "milestones", mid), { recursive: true });
-}
-
-function writeContext(base: string, mid: string, content: string): void {
-  writeMilestoneDir(base, mid);
-  writeFileSync(join(base, ".gsd", "milestones", mid, `${mid}-CONTEXT.md`), content);
-}
-
-function writeContextDraft(base: string, mid: string, content: string): void {
-  writeMilestoneDir(base, mid);
-  writeFileSync(join(base, ".gsd", "milestones", mid, `${mid}-CONTEXT-DRAFT.md`), content);
-}
-
-function writeRoadmap(base: string, mid: string, content: string): void {
-  writeMilestoneDir(base, mid);
-  writeFileSync(join(base, ".gsd", "milestones", mid, `${mid}-ROADMAP.md`), content);
-}
-
-// ─── Tests ────────────────────────────────────────────────────────────────────
-
-describe("discuss-queued-milestones (#2307)", () => {
-
-  test("1. pending milestones appear in registry when active milestone exists", async () => {
-    const base = createBase();
-    try {
-      // M001: active — has context + roadmap with a slice
-      writeContext(base, "M001", "# M001: Active\nContext here.");
-      writeRoadmap(base, "M001",
-        "# M001: Active\n\n## Slices\n- [ ] **S01: Do work** `risk:low` `depends:[]`\n  > After this: works\n");
-
-      // M002: pending — context only, no roadmap
-      writeContext(base, "M002", "# M002: Queued\nFuture work.");
-
-      // M003: pending — draft context only
-      writeContextDraft(base, "M003", "# M003: Draft\nSeed material.");
-
-      invalidateAllCaches();
-      const state = await deriveState(base);
-
-      assert.ok(!!state.activeMilestone, "M001 should be the active milestone");
-      assert.strictEqual(state.activeMilestone?.id, "M001");
-
-      const pendingIds = state.registry
-        .filter(m => m.status === "pending")
-        .map(m => m.id);
-
-      assert.ok(pendingIds.includes("M002"), "M002 should be pending");
-      assert.ok(pendingIds.includes("M003"), "M003 should be pending");
-    } finally {
-      cleanup(base);
-    }
-  });
-
-  test("2. first context-only milestone is active, subsequent ones are pending", async () => {
-    const base = createBase();
-    try {
-      // M001: first milestone with context but no roadmap — deriveState marks it active
-      writeContext(base, "M001", "# M001: First\nContext here.");
-      // M002: will be pending since M001 is active
-      writeContext(base, "M002", "# M002: Second\nMore future work.");
-
-      invalidateAllCaches();
-      const state = await deriveState(base);
-
-      // deriveState makes the first unfinished milestone "active" even without a roadmap
-      assert.ok(!!state.activeMilestone, "first milestone should be active");
-      assert.strictEqual(state.activeMilestone?.id, "M001", "M001 is the active milestone");
-
-      const pendingIds = state.registry
-        .filter(m => m.status === "pending")
-        .map(m => m.id);
-
-      assert.ok(pendingIds.includes("M002"),
-        "M002 should be pending — it comes after the active M001");
-    } finally {
-      cleanup(base);
-    }
-  });
-
-  test("3. resolveMilestoneFile finds CONTEXT.md for pending milestone", (t) => {
-    const base = createBase();
-    try {
-      writeContext(base, "M002", "# M002: Queued\nContent.");
-
-      const contextFile = resolveMilestoneFile(base, "M002", "CONTEXT");
-      assert.ok(contextFile !== null, "resolveMilestoneFile should find CONTEXT.md for M002");
-      assert.ok(contextFile!.endsWith("M002-CONTEXT.md"),
-        "resolved path should point to M002-CONTEXT.md");
-    } finally {
-      cleanup(base);
-    }
-  });
-
-  test("4. resolveMilestoneFile finds CONTEXT-DRAFT.md for pending milestone", (t) => {
-    const base = createBase();
-    try {
-      writeContextDraft(base, "M003", "# M003: Draft\nSeed content.");
-
-      const draftFile = resolveMilestoneFile(base, "M003", "CONTEXT-DRAFT");
-      assert.ok(draftFile !== null, "resolveMilestoneFile should find CONTEXT-DRAFT.md for M003");
-      assert.ok(draftFile!.endsWith("M003-CONTEXT-DRAFT.md"),
-        "resolved path should point to M003-CONTEXT-DRAFT.md");
-    } finally {
-      cleanup(base);
-    }
-  });
-
-  test("5. resolveMilestoneFile returns null when pending milestone has no context", (t) => {
-    const base = createBase();
-    try {
-      writeMilestoneDir(base, "M004");
-
-      const contextFile = resolveMilestoneFile(base, "M004", "CONTEXT");
-      assert.strictEqual(contextFile, null,
-        "resolveMilestoneFile should return null when no CONTEXT.md exists");
-
-      const draftFile = resolveMilestoneFile(base, "M004", "CONTEXT-DRAFT");
-      assert.strictEqual(draftFile, null,
-        "resolveMilestoneFile should return null when no CONTEXT-DRAFT.md exists");
-    } finally {
-      cleanup(base);
-    }
-  });
-
-  // The earlier tests 6-13 source-grepped guided-flow.ts for identifier
-  // names (showDiscussQueuedMilestone, dispatchDiscussForMilestone),
-  // UI-copy strings ("[queued]", "Discuss a queued milestone"), and
-  // regex-on-function-body assertions for the #3150 routing — all
-  // structural rather than behavioural (Refs #4826). They were dropped
-  // when this file was tightened against handler-level assertions.
-});

package/src/resources/extensions/gsd/tests/dispatch-uat-last-completed.test.ts

@@ -1,206 +0,0 @@
-// Regression test for #1693 — /gsd dispatch uat targets the last completed
-// slice from the roadmap instead of state.activeSlice (which has already
-// advanced to the next incomplete slice).
-
-import test from "node:test";
-import assert from "node:assert/strict";
-import { mkdtempSync, mkdirSync, rmSync, writeFileSync } from "node:fs";
-import { join } from "node:path";
-import { tmpdir } from "node:os";
-
-import { dispatchDirectPhase } from "../auto-direct-dispatch.ts";
-import { invalidateStateCache } from "../state.ts";
-
-function createFixture(): string {
-  const base = mkdtempSync(join(tmpdir(), "gsd-dispatch-uat-"));
-
-  // Milestone M001 with two slices: S01 done, S02 incomplete
-  const milestoneDir = join(base, ".gsd", "milestones", "M001");
-  mkdirSync(milestoneDir, { recursive: true });
-
-  writeFileSync(
-    join(milestoneDir, "M001-CONTEXT.md"),
-    "# M001: Test Milestone\n\nContext.\n",
-  );
-
-  writeFileSync(
-    join(milestoneDir, "M001-ROADMAP.md"),
-    [
-      "# M001: Test Milestone",
-      "",
-      "## Slices",
-      "",
-      "- [x] **S01: Completed slice** `risk:low` `depends:[]`",
-      "- [ ] **S02: Active slice** `risk:low` `depends:[S01]`",
-      "",
-    ].join("\n"),
-  );
-
-  // S01 has a UAT file (this is the one dispatch should target)
-  const s01Dir = join(milestoneDir, "slices", "S01");
-  mkdirSync(s01Dir, { recursive: true });
-  writeFileSync(
-    join(s01Dir, "S01-UAT.md"),
-    "# UAT\n\n## UAT Type\n\n- UAT mode: artifact-driven\n\n## Scenarios\n\n- Check output\n",
-  );
-  // S01 needs a PLAN with completed tasks so deriveState considers it done
-  writeFileSync(
-    join(s01Dir, "S01-PLAN.md"),
-    "# S01 Plan\n\n## Tasks\n\n- [x] **T01: Task one** `effort:low`\n",
-  );
-  const t01Dir = join(s01Dir, "tasks", "T01");
-  mkdirSync(t01Dir, { recursive: true });
-  writeFileSync(join(t01Dir, "T01-PLAN.md"), "# T01 Plan\n\nDo the thing.\n");
-
-  // S02 has a plan but incomplete tasks — this is where activeSlice points
-  const s02Dir = join(milestoneDir, "slices", "S02");
-  mkdirSync(s02Dir, { recursive: true });
-  writeFileSync(
-    join(s02Dir, "S02-PLAN.md"),
-    "# S02 Plan\n\n## Tasks\n\n- [ ] **T01: Task one** `effort:low`\n",
-  );
-  const s02t01Dir = join(s02Dir, "tasks", "T01");
-  mkdirSync(s02t01Dir, { recursive: true });
-  writeFileSync(join(s02t01Dir, "T01-PLAN.md"), "# T01 Plan\n\nDo the thing.\n");
-
-  return base;
-}
-
-test("dispatch uat targets last completed slice, not activeSlice (#1693)", async (t) => {
-  const base = createFixture();
-  invalidateStateCache();
-
-  const notifications: { message: string; level: string }[] = [];
-  let sentPrompt: string | undefined;
-
-  const ctx = {
-    ui: {
-      notify: (message: string, level: string) => {
-        notifications.push({ message, level });
-      },
-    },
-    newSession: async () => ({ cancelled: false }),
-  } as any;
-
-  const pi = {
-    sendMessage: (msg: { content: string }, _opts: unknown) => {
-      sentPrompt = msg.content;
-    },
-  } as any;
-
-  t.after(() => rmSync(base, { recursive: true, force: true }));
-
-  await dispatchDirectPhase(ctx, pi, "uat", base);
-
-  // Should have dispatched (sendMessage called)
-  assert.ok(sentPrompt, "sendMessage should have been called with a prompt");
-
-  // The dispatch notification should reference M001/S01 (completed), not M001/S02 (active)
-  const dispatchNotification = notifications.find(n => n.message.startsWith("Dispatching"));
-  assert.ok(dispatchNotification, "dispatch notification should be present");
-  assert.match(
-    dispatchNotification.message,
-    /M001\/S01/,
-    "dispatch should target completed slice S01, not active slice S02",
-  );
-  assert.doesNotMatch(
-    dispatchNotification.message,
-    /M001\/S02/,
-    "dispatch should NOT target active (next incomplete) slice S02",
-  );
-});
-
-test("dispatch validate-milestone targets milestone validation, not run-uat", async (t) => {
-  const base = createFixture();
-  invalidateStateCache();
-
-  const notifications: { message: string; level: string }[] = [];
-  let sentPrompt: string | undefined;
-
-  const ctx = {
-    ui: {
-      notify: (message: string, level: string) => {
-        notifications.push({ message, level });
-      },
-    },
-    newSession: async () => ({ cancelled: false }),
-  } as any;
-
-  const pi = {
-    sendMessage: (msg: { content: string }, _opts: unknown) => {
-      sentPrompt = msg.content;
-    },
-  } as any;
-
-  t.after(() => rmSync(base, { recursive: true, force: true }));
-
-  await dispatchDirectPhase(ctx, pi, "validate-milestone", base);
-
-  assert.ok(sentPrompt, "sendMessage should have been called with a validation prompt");
-  const dispatchNotification = notifications.find(n => n.message.startsWith("Dispatching"));
-  assert.ok(dispatchNotification, "dispatch notification should be present");
-  assert.match(dispatchNotification.message, /validate-milestone/, "dispatch should run milestone validation");
-  assert.match(dispatchNotification.message, /M001/, "dispatch should target the milestone");
-  assert.doesNotMatch(dispatchNotification.message, /M001\/S01/, "validation dispatch should not target slice UAT");
-});
-
-test("dispatch uat warns when no completed slices exist", async (t) => {
-  const base = mkdtempSync(join(tmpdir(), "gsd-dispatch-uat-none-"));
-  invalidateStateCache();
-
-  const milestoneDir = join(base, ".gsd", "milestones", "M001");
-  mkdirSync(milestoneDir, { recursive: true });
-
-  writeFileSync(
-    join(milestoneDir, "M001-CONTEXT.md"),
-    "# M001: Test Milestone\n\nContext.\n",
-  );
-
-  writeFileSync(
-    join(milestoneDir, "M001-ROADMAP.md"),
-    [
-      "# M001: Test",
-      "",
-      "## Slices",
-      "",
-      "- [ ] **S01: First** `risk:low` `depends:[]`",
-      "",
-    ].join("\n"),
-  );
-
-  // S01 needs a plan so state derivation doesn't stop at planning phase
-  const s01Dir = join(milestoneDir, "slices", "S01");
-  mkdirSync(s01Dir, { recursive: true });
-  writeFileSync(
-    join(s01Dir, "S01-PLAN.md"),
-    "# S01 Plan\n\n## Tasks\n\n- [ ] **T01: Task** `effort:low`\n",
-  );
-  const t01Dir = join(s01Dir, "tasks", "T01");
-  mkdirSync(t01Dir, { recursive: true });
-  writeFileSync(join(t01Dir, "T01-PLAN.md"), "# T01 Plan\n");
-
-  const notifications: { message: string; level: string }[] = [];
-
-  const ctx = {
-    ui: {
-      notify: (message: string, level: string) => {
-        notifications.push({ message, level });
-      },
-    },
-    newSession: async () => ({ cancelled: false }),
-  } as any;
-
-  const pi = {
-    sendMessage: () => {
-      assert.fail("sendMessage should not be called when no completed slices");
-    },
-  } as any;
-
-  t.after(() => rmSync(base, { recursive: true, force: true }));
-
-  await dispatchDirectPhase(ctx, pi, "uat", base);
-
-  const warning = notifications.find(n => n.level === "warning");
-  assert.ok(warning, "should show a warning notification");
-  assert.match(warning.message, /no completed slices/, "warning should mention no completed slices");
-});

package/src/resources/extensions/gsd/tests/draft-promotion.test.ts

@@ -1,149 +0,0 @@
-import { mkdtempSync, mkdirSync, rmSync, writeFileSync, existsSync } from "node:fs";
-import { join } from "node:path";
-import { tmpdir } from "node:os";
-
-import { deriveState } from "../state.js";
-import { resolveMilestoneFile } from "../paths.js";
-import { invalidateAllCaches } from "../cache.js";
-
-let passed = 0;
-let failed = 0;
-
-function assert(condition: boolean, message: string): void {
-  if (condition) {
-    passed++;
-  } else {
-    failed++;
-    console.error(`  FAIL: ${message}`);
-  }
-}
-
-// ─── Full state transition: needs-discussion → pre-planning ─────────────
-
-console.log("=== Draft promotion: full state transition ===");
-
-const tmpBase = mkdtempSync(join(tmpdir(), "gsd-draft-promotion-test-"));
-const gsd = join(tmpBase, ".gsd");
-
-mkdirSync(join(gsd, "milestones", "M001"), { recursive: true });
-
-// Step 1: Create CONTEXT-DRAFT.md only → needs-discussion
-const draftPath = join(gsd, "milestones", "M001", "M001-CONTEXT-DRAFT.md");
-writeFileSync(draftPath, "# M001: Draft\n\nSeed material.\n");
-
-const state1 = await deriveState(tmpBase);
-assert(
-  state1.phase === "needs-discussion",
-  `draft-only should be 'needs-discussion', got: "${state1.phase}"`,
-);
-
-// Step 2: Write CONTEXT.md (simulating discussion output) → pre-planning
-const contextPath = join(gsd, "milestones", "M001", "M001-CONTEXT.md");
-writeFileSync(contextPath, "# M001: Full Context\n\nDeep discussion output.\n");
-
-invalidateAllCaches();
-const state2 = await deriveState(tmpBase);
-assert(
-  state2.phase === "pre-planning",
-  `after CONTEXT.md written, should be 'pre-planning', got: "${state2.phase}"`,
-);
-
-// Step 3: Simulate draft cleanup (what checkAutoStartAfterDiscuss does)
-const resolvedDraft = resolveMilestoneFile(tmpBase, "M001", "CONTEXT-DRAFT");
-assert(
-  resolvedDraft !== null && resolvedDraft !== undefined,
-  "CONTEXT-DRAFT.md should still exist before cleanup",
-);
-
-// Delete the draft (simulating the cleanup in checkAutoStartAfterDiscuss)
-const { unlinkSync } = await import("node:fs");
-try {
-  if (resolvedDraft) unlinkSync(resolvedDraft);
-} catch { /* non-fatal */ }
-
-assert(
-  !existsSync(draftPath),
-  "CONTEXT-DRAFT.md should be deleted after promotion cleanup",
-);
-
-// Step 4: After cleanup, state is still pre-planning (CONTEXT.md exists)
-invalidateAllCaches();
-const state3 = await deriveState(tmpBase);
-assert(
-  state3.phase === "pre-planning",
-  `after cleanup, should still be 'pre-planning', got: "${state3.phase}"`,
-);
-
-// ─── No-draft case: cleanup is a no-op ──────────────────────────────────
-
-console.log("=== No-draft cleanup: no-op ===");
-
-const tmpBase2 = mkdtempSync(join(tmpdir(), "gsd-draft-promotion-noop-"));
-const gsd2 = join(tmpBase2, ".gsd");
-
-mkdirSync(join(gsd2, "milestones", "M001"), { recursive: true });
-writeFileSync(
-  join(gsd2, "milestones", "M001", "M001-CONTEXT.md"),
-  "# M001: Normal\n\nStandard discussion output.\n",
-);
-
-// No CONTEXT-DRAFT.md exists — cleanup should be a no-op
-const noDraft = resolveMilestoneFile(tmpBase2, "M001", "CONTEXT-DRAFT");
-assert(
-  noDraft === null || noDraft === undefined,
-  "no CONTEXT-DRAFT.md should exist for standard discussion milestone",
-);
-
-// deriveState should return pre-planning normally
-const state4 = await deriveState(tmpBase2);
-assert(
-  state4.phase === "pre-planning",
-  `standard discussion milestone should be 'pre-planning', got: "${state4.phase}"`,
-);
-
-// ─── Both files exist → CONTEXT.md wins, draft cleanup works ───────────
-
-console.log("=== Both files: CONTEXT wins, draft cleanable ===");
-
-const tmpBase3 = mkdtempSync(join(tmpdir(), "gsd-draft-promotion-both-"));
-const gsd3 = join(tmpBase3, ".gsd");
-
-mkdirSync(join(gsd3, "milestones", "M001"), { recursive: true });
-writeFileSync(
-  join(gsd3, "milestones", "M001", "M001-CONTEXT.md"),
-  "# M001: Full\n\nFull context.\n",
-);
-const bothDraftPath = join(gsd3, "milestones", "M001", "M001-CONTEXT-DRAFT.md");
-writeFileSync(bothDraftPath, "# M001: Draft\n\nStale draft.\n");
-
-const state5 = await deriveState(tmpBase3);
-assert(
-  state5.phase === "pre-planning",
-  `both files: CONTEXT.md wins, should be 'pre-planning', got: "${state5.phase}"`,
-);
-
-// Cleanup the stale draft
-const bothDraft = resolveMilestoneFile(tmpBase3, "M001", "CONTEXT-DRAFT");
-try {
-  if (bothDraft) unlinkSync(bothDraft);
-} catch { /* non-fatal */ }
-
-assert(
-  !existsSync(bothDraftPath),
-  "stale CONTEXT-DRAFT.md should be deleted in both-files case",
-);
-
-// Note: source-grep assertions removed per CONTRIBUTING.md (no asserting against
-// readFileSync of source). The behavioral scenarios above already exercise the
-// CONTEXT-DRAFT cleanup path end-to-end via the actual filesystem state.
-
-// ─── Cleanup ──────────────────────────────────────────────────────────
-
-rmSync(tmpBase, { recursive: true, force: true });
-rmSync(tmpBase2, { recursive: true, force: true });
-rmSync(tmpBase3, { recursive: true, force: true });
-
-// ─── Results ──────────────────────────────────────────────────────────
-
-console.log(`\ndraft-promotion: ${passed} passed, ${failed} failed`);
-if (failed > 0) process.exit(1);