@opengsd/gsd-pi 1.0.1 → 1.0.2

package/src/resources/extensions/gsd/tests/auto-discuss-milestone-deadlock-4973.test.ts

@@ -1,4 +1,4 @@
-// GSD-2 + Regression tests for auto-mode discuss-milestone write-gate deadlock (#4973)
+// gsd-pi + Regression tests for auto-mode discuss-milestone write-gate deadlock (#4973)
 //
 // The depth-verification write-gate in write-gate.ts:415-443 blocks
 // gsd_summary_save({artifact_type:"CONTEXT"}) until markDepthVerified() is

package/src/resources/extensions/gsd/tests/auto-loop-no-copy-artifacts.test.ts

@@ -1,4 +1,4 @@
-// gsd-2 + Phase C deletion regression: createAutoWorktree no longer copies .gsd/
+// gsd-pi + Phase C deletion regression: createAutoWorktree no longer copies .gsd/
 //
 // Verifies that createAutoWorktree on a project with a real (non-symlinked)
 // .gsd/ does NOT populate .gsd/milestones/ inside the worktree. Pre-Phase-C,

package/src/resources/extensions/gsd/tests/auto-loop-symlink-worktree.test.ts

@@ -1,4 +1,4 @@
-// gsd-2 + Symlinked .gsd worktree-loop reproduction (Phase A pt 2 follow-up to PR #5236)
+// gsd-pi + Symlinked .gsd worktree-loop reproduction (Phase A pt 2 follow-up to PR #5236)
 //
 // Regression coverage for the auto-mode loop bug observed on projects whose
 // .gsd/ is a symlink into ~/.gsd/projects/<hash>/ (the external-state layout).

package/src/resources/extensions/gsd/tests/auto-loop.test.ts

@@ -1,4 +1,4 @@
-// Project/App: GSD-2
+// Project/App: gsd-pi
 // File Purpose: Auto-loop execution, dispatch, recovery, and cancellation regression tests.
 
 import test, { mock } from "node:test";
@@ -21,6 +21,7 @@ import {
   isSessionSwitchAbortGraceActive,
 } from "../auto/resolve.js";
 import { runUnit, shouldDeferUnitFailsafeTimeout } from "../auto/run-unit.js";
+import { scheduleAutoWakeup, _resetAutoWakeupsForTest } from "../auto/schedule-wakeup.js";
 import { writeUnitRuntimeRecord, readUnitRuntimeRecord } from "../unit-runtime.js";
 import { autoLoop } from "../auto/loop.js";
 import { runDispatch, runUnitPhase } from "../auto/phases.js";
@@ -53,11 +54,14 @@ async function drainMicrotasks(turns = 20): Promise<void> {
 async function waitForMicrotasks(
   condition: () => boolean,
   label: string,
-  turns = 500,
+  turns = 5000,
 ): Promise<void> {
   for (let i = 0; i < turns; i++) {
     if (condition()) return;
     await Promise.resolve();
+    if (i % 25 === 24) {
+      await new Promise<void>((resolve) => setImmediate(resolve));
+    }
   }
   assert.fail(`Timed out waiting for ${label}`);
 }
@@ -187,6 +191,61 @@ test("resolveAgentEnd resolves a pending runUnit promise", async () => {
   assert.deepEqual(result.event, event);
 });
 
+test("runUnit honors ScheduleWakeup by continuing the same unit session", async () => {
+  _resetPendingResolve();
+  _resetAutoWakeupsForTest();
+
+  const ctx = {
+    ...makeMockCtx(),
+    ui: {
+      notify: () => {},
+      setStatus: () => {},
+      setWorkingMessage: () => {},
+    },
+    sessionManager: {
+      getEntries: () => [],
+    },
+    modelRegistry: {
+      getProviderAuthMode: () => undefined,
+      isProviderRequestReady: () => true,
+    },
+  } as any;
+  const pi = makeMockPi();
+  const s = makeMockSession();
+  const firstEvent = makeEvent([{ role: "assistant", content: "submitted job" }]);
+  const secondEvent = makeEvent([{ role: "assistant", content: "job finished" }]);
+
+  const resultPromise = runUnit(
+    ctx,
+    pi,
+    s,
+    "execute-task",
+    "M001/S01/T01",
+    "submit external job",
+  );
+
+  await waitForMicrotasks(() => pi.calls.length === 1, "initial unit dispatch");
+  scheduleAutoWakeup({
+    basePath: s.basePath,
+    unitType: "execute-task",
+    unitId: "M001/S01/T01",
+    delayMs: 0,
+    prompt: "check external job and write the task summary if complete",
+    reason: "poll external job",
+    createdAt: Date.now(),
+  });
+  resolveAgentEnd(firstEvent);
+
+  await waitForMicrotasks(() => pi.calls.length === 2, "scheduled wakeup dispatch");
+  assert.equal((pi.calls[1] as any[])[0].content, "check external job and write the task summary if complete");
+  resolveAgentEnd(secondEvent);
+
+  const result = await resultPromise;
+  assert.equal(result.status, "completed");
+  assert.deepEqual(result.event, secondEvent);
+  assert.equal(pi.calls.length, 2);
+});
+
 test("runUnit suppresses the global working-message loader for auto dashboard runs", async () => {
   _resetPendingResolve();
   const workingMessages: unknown[] = [];
@@ -2450,8 +2509,8 @@ test("autoLoop handles verification retry by continuing loop", async (t) => {
       },
       postUnitPostVerification: async () => {
         deps.callLog.push("postUnitPostVerification");
-        // After the retry cycle completes, deactivate
-        s.active = false;
+        // After the retry cycle completes, deactivate.
+        if (verifyCallCount >= 2) s.active = false;
         return "continue" as const;
       },
     });
@@ -5445,7 +5504,7 @@ test("autoLoop classifies ModelPolicyDispatchBlockedError as blocked, not a retr
   // Capture onTurnResult to assert blocked-unit identity is propagated to
   // the uokObserver. Without the fix, observedUnitType/Id are unset because
   // the throw happens inside dispatch before the success-path assignments
-  // at loop.ts:453/631/647 (#4959 / CodeRabbit Minor).
+  // at loop.ts:453/631/647 (#4959).
   const turnResults: Array<{ unitType?: string; unitId?: string; status: string }> = [];
 
   const deps = makeMockDeps({
@@ -5495,7 +5554,7 @@ test("autoLoop classifies ModelPolicyDispatchBlockedError as blocked, not a retr
 
   // Blocked-unit identity must reach uokObserver.onTurnResult — the typed
   // error already carries it, the loop must thread it into observedUnitType/Id
-  // before finishTurn is called (#4959 / CodeRabbit Minor).
+  // before finishTurn is called (#4959).
   const pausedTurn = turnResults.find(r => r.status === "paused");
   assert.ok(pausedTurn, "uokObserver should observe a paused turn for the blocked unit");
   assert.equal(pausedTurn!.unitType, "research-slice", "onTurnResult must receive the blocked unitType from the typed error");

package/src/resources/extensions/gsd/tests/auto-model-selection-tool-poisoning.test.ts

@@ -128,7 +128,7 @@ test("vacuous-truth (a): unit type with empty workflow-required tools → dispat
   try {
     // `refine-slice` is not in the getRequiredWorkflowToolsForAutoUnit switch
     // → returns []. Exercises the empty-requiredTools branch in
-    // applyModelPolicyFilter (CodeRabbit Minor: existing test used
+    // applyModelPolicyFilter (existing test used
     // gate-evaluate which has non-empty required tools and never hit this path).
     //
     // PREFERENCES with tier_models is required so resolvePreferredModelConfig
@@ -269,8 +269,8 @@ test("cross-unit poisoning: prior unit narrowing must not deny next unit's eligi
 // ─── 3a. Genuinely-impossible: tool-compatibility denial path ────────────────
 //
 // Exercises the real `getRequiredWorkflowToolsForAutoUnit` →
-// `filterToolsForProvider` path that #4959 was about (CodeRabbit Minor:
-// existing 3b test used cross-provider denial which never hit this path).
+// `filterToolsForProvider` path that #4959 was about — existing 3b test used
+// cross-provider denial which never hit this path.
 // Registers `gsd_plan_slice` as `producesImages: true`, then offers only an
 // `ollama-chat` candidate (which has `imageToolResults: false`) — the
 // workflow-required tool is incompatible with the candidate's API, so the
@@ -509,7 +509,7 @@ test("error carries deny reason fragment from applyModelPolicyFilter", async ()
   }
 });
 
-// ─── 6. Lifecycle: clearToolBaseline forces recapture (CodeRabbit Major) ─────
+// ─── 6. Lifecycle: clearToolBaseline forces recapture (#4959) ─────
 //
 // The WeakMap baseline is keyed per `pi` instance, but auto sessions are NOT
 // 1:1 with `pi` instances — a single `pi` can host multiple `/gsd auto` runs

package/src/resources/extensions/gsd/tests/auto-orchestrator.test.ts

@@ -1,4 +1,4 @@
-// Project/App: GSD-2
+// Project/App: gsd-pi
 // File Purpose: Auto Orchestration module contract and ADR-015 invariant sequence tests.
 
 import test from "node:test";

package/src/resources/extensions/gsd/tests/auto-pause-double-entry-guard.test.ts

@@ -10,7 +10,7 @@ import { mkdtempSync, rmSync } from "node:fs";
 import { tmpdir } from "node:os";
 import { join } from "node:path";
 
-import { pauseAuto, isAutoActive } from "../auto.ts";
+import { capturePauseAutoUnitIdentity, pauseAuto, isAutoActive } from "../auto.ts";
 import { autoSession } from "../auto-runtime-state.ts";
 import { _isPauseOriginCancelledResult } from "../auto/phases.ts";
 
@@ -74,3 +74,77 @@ test("transient-abort errorContext is not classified as pause-origin cancellatio
     "not paused = not pause-origin regardless of errorContext",
   );
 });
+
+test("pauseAuto ignores stale pre-dispatch pause once a new unit is active", async () => {
+  autoSession.reset();
+  autoSession.active = true;
+  autoSession.currentUnit = {
+    type: "research-slice",
+    id: "M011/S05",
+    startedAt: 500,
+  };
+
+  try {
+    await pauseAuto(undefined, undefined, undefined, { expectedCurrentUnit: null });
+
+    assert.equal(autoSession.active, true);
+    assert.equal(autoSession.paused, false);
+    assert.deepEqual(autoSession.currentUnit, {
+      type: "research-slice",
+      id: "M011/S05",
+      startedAt: 500,
+    });
+  } finally {
+    autoSession.reset();
+  }
+});
+
+test("pauseAuto ignores stale pause for a superseded unit identity", async () => {
+  autoSession.reset();
+  autoSession.active = true;
+  autoSession.currentUnit = {
+    type: "research-slice",
+    id: "M011/S05",
+    startedAt: 500,
+  };
+
+  try {
+    await pauseAuto(undefined, undefined, undefined, {
+      expectedCurrentUnit: {
+        type: "plan-slice",
+        id: "M011/S04",
+        startedAt: 100,
+      },
+    });
+
+    assert.equal(autoSession.active, true);
+    assert.equal(autoSession.paused, false);
+    assert.deepEqual(autoSession.currentUnit, {
+      type: "research-slice",
+      id: "M011/S05",
+      startedAt: 500,
+    });
+  } finally {
+    autoSession.reset();
+  }
+});
+
+test("pauseAuto still pauses when the expected unit identity matches", async () => {
+  autoSession.reset();
+  autoSession.active = true;
+  autoSession.currentUnit = {
+    type: "research-slice",
+    id: "M011/S05",
+    startedAt: 500,
+  };
+  const expectedCurrentUnit = capturePauseAutoUnitIdentity();
+
+  try {
+    await pauseAuto(undefined, undefined, undefined, { expectedCurrentUnit });
+
+    assert.equal(autoSession.active, false);
+    assert.equal(autoSession.paused, true);
+  } finally {
+    autoSession.reset();
+  }
+});

package/src/resources/extensions/gsd/tests/auto-paused-ui-cleanup.test.ts

@@ -1,4 +1,4 @@
-// Project/App: GSD-2
+// Project/App: gsd-pi
 // File Purpose: Behavior tests for auto-loop cleanup after paused provider exits.
 import { test } from "node:test";
 import assert from "node:assert/strict";

package/src/resources/extensions/gsd/tests/auto-phases-lifecycle.test.ts

@@ -1,4 +1,4 @@
-// Project/App: GSD-2
+// Project/App: gsd-pi
 // File Purpose: Auto-loop phase lifecycle regression tests.
 import test from "node:test";
 import assert from "node:assert/strict";
@@ -7,7 +7,7 @@ import { mkdirSync, mkdtempSync, rmSync, writeFileSync } from "node:fs";
 import { join } from "node:path";
 import { tmpdir } from "node:os";
 
-import { runFinalize } from "../auto/phases.ts";
+import { resolveDispatchRecoveryAttempts, runFinalize } from "../auto/phases.ts";
 import { AutoSession } from "../auto/session.ts";
 import { readUnitRuntimeRecord, writeUnitRuntimeRecord } from "../unit-runtime.ts";
 import { captureRootDirtySnapshot } from "../root-write-leak-guard.ts";
@@ -25,6 +25,26 @@ function initRepo(root: string): void {
   runGit(root, ["commit", "-m", "chore: init"]);
 }
 
+test("resolveDispatchRecoveryAttempts preserves cross-session recovery attempts before in-session recovery", () => {
+  const recoveryCounts = new Map<string, number>();
+
+  assert.equal(
+    resolveDispatchRecoveryAttempts(recoveryCounts, "execute-task", "M001/S01/T01"),
+    undefined,
+  );
+});
+
+test("resolveDispatchRecoveryAttempts resets after recovery ran in the current session", () => {
+  const recoveryCounts = new Map<string, number>([
+    ["execute-task/M001/S01/T01", 1],
+  ]);
+
+  assert.equal(
+    resolveDispatchRecoveryAttempts(recoveryCounts, "execute-task", "M001/S01/T01"),
+    0,
+  );
+});
+
 async function runSuccessfulFinalize(s: AutoSession) {
   const unit = s.currentUnit;
   assert.ok(unit, "test setup must provide currentUnit");

package/src/resources/extensions/gsd/tests/auto-post-unit-step-message.test.ts

@@ -1,4 +1,4 @@
-// Project/App: GSD-2
+// Project/App: gsd-pi
 // File Purpose: Tests for step-mode completion messages in auto-post-unit.
 
 import test from "node:test";

package/src/resources/extensions/gsd/tests/auto-project-root-env.test.ts

@@ -1,4 +1,4 @@
-// Project/App: GSD-2
+// Project/App: gsd-pi
 // File Purpose: Behavior tests for auto-mode project-root environment cleanup.
 import test from "node:test";
 import assert from "node:assert/strict";

package/src/resources/extensions/gsd/tests/auto-recovery.test.ts

@@ -1,4 +1,4 @@
-// Project/App: GSD-2
+// Project/App: gsd-pi
 // File Purpose: Tests auto-mode artifact verification and recovery behavior.
 import test, { afterEach } from "node:test";
 import assert from "node:assert/strict";
@@ -893,57 +893,6 @@ test("verifyExpectedArtifact execute-task requires checked checkbox or DB status
   }
 });
 
-// ─── #793: invalidateAllCaches unblocks skip-loop ─────────────────────────
-// When the skip-loop breaker fires, it must call invalidateAllCaches() (not
-// just invalidateStateCache()) to clear path/parse caches that deriveState
-// depends on. Without this, even after cache invalidation, deriveState reads
-// stale directory listings and returns the same unit, looping forever.
-test("#793: invalidateAllCaches clears all caches so deriveState sees fresh disk state", async () => {
-  const base = makeTmpBase();
-  try {
-    const mid = "M001";
-    const sid = "S01";
-    const planDir = join(base, ".gsd", "milestones", mid, "slices", sid);
-    const tasksDir = join(planDir, "tasks");
-    mkdirSync(tasksDir, { recursive: true });
-    mkdirSync(join(base, ".gsd", "milestones", mid), { recursive: true });
-
-    writeFileSync(
-      join(base, ".gsd", "milestones", mid, `${mid}-ROADMAP.md`),
-      `# M001: Test Milestone\n\n**Vision:** test.\n\n## Slices\n\n- [ ] **${sid}: Slice One** \`risk:low\` \`depends:[]\`\n  > After this: done.\n`,
-    );
-    const planUnchecked = `# ${sid}: Slice One\n\n**Goal:** test.\n\n## Tasks\n\n- [ ] **T01: Task One** \`est:10m\`\n- [ ] **T02: Task Two** \`est:10m\`\n`;
-    writeFileSync(join(planDir, `${sid}-PLAN.md`), planUnchecked);
-    writeFileSync(join(tasksDir, "T01-PLAN.md"), "# T01: Task One\n\n**Goal:** t\n\n## Steps\n- step\n\n## Verification\n- v\n");
-    writeFileSync(join(tasksDir, "T02-PLAN.md"), "# T02: Task Two\n\n**Goal:** t\n\n## Steps\n- step\n\n## Verification\n- v\n");
-
-    // Warm all caches
-    const state1 = await deriveState(base);
-    assert.equal(state1.activeTask?.id, "T01", "initial: T01 is active");
-
-    // Simulate task completion on disk (what the LLM does)
-    const planChecked = `# ${sid}: Slice One\n\n**Goal:** test.\n\n## Tasks\n\n- [x] **T01: Task One** \`est:10m\`\n- [ ] **T02: Task Two** \`est:10m\`\n`;
-    writeFileSync(join(planDir, `${sid}-PLAN.md`), planChecked);
-    writeFileSync(join(tasksDir, "T01-SUMMARY.md"), "---\nid: T01\n---\n# Summary\n");
-
-    // invalidateStateCache alone: _stateCache cleared but path/parse caches warm
-    invalidateStateCache();
-
-    // invalidateAllCaches: all caches cleared — deriveState must re-read disk
-    invalidateAllCaches();
-    const state2 = await deriveState(base);
-
-    // After full invalidation, T01 should be complete and T02 should be next
-    assert.notEqual(state2.activeTask?.id, "T01", "#793: T01 not re-dispatched after full invalidation");
-
-    // Verify the caches are truly cleared by calling clearParseCache and clearPathCache
-    // do not throw (they should be no-ops after invalidateAllCaches already cleared them)
-    clearParseCache(); // no-op, but should not throw
-    assert.ok(true, "clearParseCache after invalidateAllCaches is safe");
-  } finally {
-    cleanup(base);
-  }
-});
 
 // ─── hasImplementationArtifacts (#1703) ───────────────────────────────────
 

package/src/resources/extensions/gsd/tests/auto-runtime-state.test.ts

@@ -1,4 +1,4 @@
-// Project/App: GSD-2
+// Project/App: gsd-pi
 // File Purpose: Auto runtime state snapshot regression tests.
 
 import test from "node:test";

package/src/resources/extensions/gsd/tests/auto-session-scope.test.ts

@@ -1,4 +1,4 @@
-// GSD-2 + Tests for MilestoneScope threading through AutoSession state (C2)
+// gsd-pi + Tests for MilestoneScope threading through AutoSession state (C2)
 //
 // Strategy: construct AutoSession directly + call createWorkspace/scopeMilestone
 // to mirror the rebuildScope() helper in auto.ts — avoids importing the full

package/src/resources/extensions/gsd/tests/auto-start-clean-runtime-db-gated.test.ts

@@ -1,4 +1,4 @@
-// GSD-2 auto-start regression test: cleanStaleRuntimeUnits is DB-gated (#4663)
+// gsd-pi auto-start regression test: cleanStaleRuntimeUnits is DB-gated (#4663)
 
 import { describe, test } from "node:test";
 import assert from "node:assert/strict";

package/src/resources/extensions/gsd/tests/auto-start-orphan-bootstrap.test.ts

@@ -1,4 +1,4 @@
-// Project/App: GSD-2
+// Project/App: gsd-pi
 // File Purpose: Bootstrap behavior tests for completed milestone orphan merges.
 import test from "node:test";
 import assert from "node:assert/strict";

package/src/resources/extensions/gsd/tests/auto-start-time-persistence.test.ts

@@ -1,4 +1,4 @@
-// GSD2 — Verify autoStartTime is carried through dashboard state
+// gsd-pi — Verify autoStartTime is carried through dashboard state
 
 import test from "node:test";
 import assert from "node:assert/strict";

package/src/resources/extensions/gsd/tests/auto-start-validation-block.test.ts

@@ -1,4 +1,4 @@
-// Project/App: GSD-2
+// Project/App: gsd-pi
 // File Purpose: Regression tests for auto-start validation block handling.
 
 import test from "node:test";

package/src/resources/extensions/gsd/tests/auto-status-message.test.ts

@@ -1,4 +1,4 @@
-// Project/App: GSD-2
+// Project/App: gsd-pi
 // File Purpose: Visual contract tests for compact GSD status notification cards.
 
 import test from "node:test";

package/src/resources/extensions/gsd/tests/auto-stop-notification.test.ts

@@ -1,4 +1,4 @@
-// Project/App: GSD-2
+// Project/App: gsd-pi
 // File Purpose: Regression tests for auto-mode stop notification formatting.
 
 import test from "node:test";

package/src/resources/extensions/gsd/tests/auto-unit-closeout.test.ts

@@ -1,4 +1,4 @@
-// Project/App: GSD-2
+// Project/App: gsd-pi
 // File Purpose: Regression tests for auto-unit closeout activity classification.
 
 import test from "node:test";

package/src/resources/extensions/gsd/tests/auto-workers.test.ts

@@ -1,4 +1,4 @@
-// gsd-2 + Auto-mode worker registry tests (Phase B coordination)
+// gsd-pi + Auto-mode worker registry tests (Phase B coordination)
 
 import test from "node:test";
 import assert from "node:assert/strict";

package/src/resources/extensions/gsd/tests/auto-worktree-registry.test.ts

@@ -1,4 +1,4 @@
-// GSD-2 + Unit tests for the workspace registry that replaced the originalBase singleton
+// gsd-pi + Unit tests for the workspace registry that replaced the originalBase singleton
 
 import { describe, test, beforeEach } from "node:test";
 import assert from "node:assert/strict";

package/src/resources/extensions/gsd/tests/auto-worktree-repair.test.ts

@@ -1,4 +1,4 @@
-// Project/App: GSD-2
+// Project/App: gsd-pi
 // File Purpose: Regression tests for safe auto-mode milestone worktree repair.
 
 import test from "node:test";

package/src/resources/extensions/gsd/tests/auto-wrapup-inflight-guard.test.ts

@@ -1,4 +1,4 @@
-// GSD-2 — Regression tests for #3512: gsd-auto-wrapup mid-turn interruption
+// gsd-pi — Regression tests for #3512: gsd-auto-wrapup mid-turn interruption
 // Copyright (c) 2026 Jeremy McSpadden <jeremy@fluxlabs.net>
 
 import { describe, test } from "node:test";

package/src/resources/extensions/gsd/tests/brief-command.test.ts

@@ -1,4 +1,4 @@
-// GSD-2 + /gsd brief command behavior tests
+// gsd-pi + /gsd brief command behavior tests
 
 import test from "node:test";
 import assert from "node:assert/strict";

package/src/resources/extensions/gsd/tests/browser-tools-compatibility-declarations.test.ts

@@ -1,4 +1,4 @@
-// GSD-2 — ADR-005 Phase 2: Verify browser tool compatibility declarations.
+// gsd-pi — ADR-005 Phase 2: Verify browser tool compatibility declarations.
 //
 // Locks in the declarations that always-image-producing browser tools
 // (browser_screenshot, browser_zoom_region) carry `producesImages: true` so

package/src/resources/extensions/gsd/tests/bundled-skill-triggers.test.ts

@@ -1,4 +1,4 @@
-// GSD-2 — BUNDLED_SKILL_TRIGGERS regression test
+// gsd-pi — BUNDLED_SKILL_TRIGGERS regression test
 //
 // Guards the skill-trigger table in system-context.ts against accidental
 // regression. Every entry must have a non-empty trigger + skill, and the

package/src/resources/extensions/gsd/tests/check-auto-start-pending-gate.test.ts

@@ -1,4 +1,4 @@
-// GSD-2 + Regression tests for checkAutoStartAfterDiscuss Gate 1a (R2)
+// gsd-pi + Regression tests for checkAutoStartAfterDiscuss Gate 1a (R2)
 //
 // When a depth-verification gate is still pending (the LLM emitted the
 // confirmation question via ask_user_questions or plain chat but the user has

package/src/resources/extensions/gsd/tests/check-auto-start-ready-guard.test.ts

@@ -1,4 +1,4 @@
-// GSD-2 + Regression tests for checkAutoStartAfterDiscuss "ready" notify guard (R3b)
+// gsd-pi + Regression tests for checkAutoStartAfterDiscuss "ready" notify guard (R3b)
 //
 // Belt-and-suspenders: even when CONTEXT.md and STATE.md exist on disk, the
 // "Milestone X ready." success notify must not fire when the milestone DB row

package/src/resources/extensions/gsd/tests/closeout-git-deferral.test.ts

@@ -1,4 +1,4 @@
-// Project/App: GSD-2
+// Project/App: gsd-pi
 // File Purpose: Tests closeout git action deferral policy for auto-mode units.
 
 import test from "node:test";

package/src/resources/extensions/gsd/tests/closeout-recovery.test.ts

@@ -1,4 +1,4 @@
-// Project/App: GSD-2
+// Project/App: gsd-pi
 // File Purpose: Closeout git recovery regression tests.
 
 import test from "node:test";

package/src/resources/extensions/gsd/tests/cmux.test.ts

@@ -1,4 +1,4 @@
-// Project/App: GSD-2
+// Project/App: gsd-pi
 // File Purpose: Unit tests for cmux integration, layout, and CLI isolation.
 import test, { describe, beforeEach, afterEach } from "node:test";
 import assert from "node:assert/strict";

package/src/resources/extensions/gsd/tests/command-queue.test.ts

@@ -1,4 +1,4 @@
-// gsd-2 + Command queue tests (Phase B coordination — IPC inbox + broadcast NULL semantics)
+// gsd-pi + Command queue tests (Phase B coordination — IPC inbox + broadcast NULL semantics)
 
 import test from "node:test";
 import assert from "node:assert/strict";

package/src/resources/extensions/gsd/tests/commands-dispatcher-unmerged-milestone.test.ts

@@ -1,4 +1,4 @@
-// Project/App: GSD-2
+// Project/App: gsd-pi
 // File Purpose: Dispatcher regression tests for completed-but-unmerged milestone branches.
 
 import test from "node:test";

package/src/resources/extensions/gsd/tests/commands-dispatcher-validation-block.test.ts

@@ -1,4 +1,4 @@
-// Project/App: GSD-2
+// Project/App: gsd-pi
 // File Purpose: Dispatcher regression tests for validation-blocked milestones.
 
 import test from "node:test";

package/src/resources/extensions/gsd/tests/commands-extensions-version-compare.test.ts

@@ -1,4 +1,4 @@
-// GSD2 — Regression test for Issue #4946 isVersionGreater (commands-extensions.ts)
+// gsd-pi — Regression test for Issue #4946 isVersionGreater (commands-extensions.ts)
 //
 // Covers the inline npm-version comparator that replaced the `semver` import in
 // commands-extensions.ts. The original import broke `tsc -p tsconfig.json` whenever

package/src/resources/extensions/gsd/tests/commands-extract-learnings.test.ts

@@ -1,4 +1,4 @@
-// GSD2 commands-extract-learnings tests
+// gsd-pi commands-extract-learnings tests
 import { describe, it, beforeEach, afterEach } from "node:test";
 import assert from "node:assert/strict";
 import { mkdirSync, writeFileSync, rmSync, readFileSync } from "node:fs";

package/src/resources/extensions/gsd/tests/complete-milestone-excerpt.test.ts

@@ -1,4 +1,4 @@
-// GSD-2 — #4780: slice-summary excerpts replace full inlining in
+// gsd-pi — #4780: slice-summary excerpts replace full inlining in
 // buildCompleteMilestonePrompt. Verify (a) the excerpt helper emits
 // frontmatter fields + section heads + on-demand path, (b) the closer
 // prompt lists all slice SUMMARY paths under "On-demand Slice Summaries",
@@ -196,13 +196,13 @@ test("#4780 excerpt: missing file reports not-found fallback", async (t) => {
   assert.match(out, /not found — file does not exist yet/);
 });
 
-test("#4780 excerpt: section bodies are capped (coderabbit review)", async (t) => {
+test("#4780 excerpt: section bodies are capped", async (t) => {
   const base = createBase();
   t.after(() => cleanup(base));
   invalidateAllCaches();
 
   // Long Follow-ups section (~4.8KB) would balloon the excerpt without
-  // the cap — regression coverage for the coderabbit finding on #4908.
+  // the cap — regression coverage for #4908.
   const longFollowUps = "A verbose follow-up bullet that keeps restating the same point. ".repeat(60);
   const content = [
     "---",

package/src/resources/extensions/gsd/tests/complete-milestone-prompt-rendering.test.ts

@@ -1,4 +1,4 @@
-// Project/App: GSD-2
+// Project/App: gsd-pi
 // File Purpose: Verifies the complete milestone prompt renders required completion and verification guardrails.
 
 import test from "node:test";

package/src/resources/extensions/gsd/tests/complete-slice-composer.test.ts

@@ -1,4 +1,4 @@
-// GSD-2 — #4782 phase 3 batch 3: complete-slice migrated through composer.
+// gsd-pi — #4782 phase 3 batch 3: complete-slice migrated through composer.
 
 import test from "node:test";
 import assert from "node:assert/strict";