@openfin/core 30.74.6 → 30.74.8

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@openfin/core",
-    "version": "30.74.6",
+    "version": "30.74.8",
     "license": "SEE LICENSE IN LICENSE.MD",
     "main": "./src/mock.js",
     "types": "./src/mock.d.ts",

package/src/api/platform/layout/Factory.js

@@ -10,7 +10,7 @@ var __classPrivateFieldSet = (this && this.__classPrivateFieldSet) || function (
     if (typeof state === "function" ? receiver !== state || !f : !state.has(receiver)) throw new TypeError("Cannot write private member to an object whose class did not declare it");
     return (kind === "a" ? f.call(receiver, value) : f ? f.value = value : state.set(receiver, value)), value;
 };
-var _LayoutModule_layoutManager;
+var _LayoutModule_layoutManager, _LayoutModule_layoutInitializationAttempted;
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.LayoutModule = void 0;
 /* eslint-disable no-undef, import/prefer-default-export */
@@ -91,6 +91,7 @@ class LayoutModule extends base_1.Base {
     constructor() {
         super(...arguments);
         _LayoutModule_layoutManager.set(this, void 0);
+        _LayoutModule_layoutInitializationAttempted.set(this, false);
         /**
          * Initialize the window's Layout.  Must be called from a custom window that has a 'layout' option set upon creation of that window.
          * If a containerId is not provided, this method attempts to find an element with the id `layout-container`.
@@ -109,9 +110,10 @@ class LayoutModule extends base_1.Base {
             if (!this.fin.me.isWindow) {
                 throw new Error('Layout.init can only be called from a Window context.');
             }
-            else if (__classPrivateFieldGet(this, _LayoutModule_layoutManager, "f")) {
+            else if (__classPrivateFieldGet(this, _LayoutModule_layoutInitializationAttempted, "f")) {
                 throw new Error('Layout for this window already initialized, please use Layout.replace call to replace the layout.');
             }
+            __classPrivateFieldSet(this, _LayoutModule_layoutInitializationAttempted, true, "f");
             // We need to go through environment to make sure it is only imported/bundled in OpenFin.
             const ManagerConstructor = await this.wire.environment.getManagerConstructor();
             const viewOverlay = new view_overlay_1.ViewOverlay(this.wire);
@@ -203,4 +205,4 @@ class LayoutModule extends base_1.Base {
     }
 }
 exports.LayoutModule = LayoutModule;
-_LayoutModule_layoutManager = new WeakMap();
+_LayoutModule_layoutManager = new WeakMap(), _LayoutModule_layoutInitializationAttempted = new WeakMap();

package/src/api/platform/layout/controllers/layout-entities-controller.d.ts

@@ -102,10 +102,10 @@ export declare class LayoutEntitiesController {
      * Creates a new adjacent 'stack' and adds the views to it at the specified position
      * @param targetId Entity id of the content item to add a stack adjacent to it
      * @param views List of identities or view creation options of the views to include in the stack
-     * @param options Creation options, defaults to position: 'right'
+     * @param options Creation options, defaults to { position: 'right' }
      * @returns the Entity Id of the new stack
      */
-    createAdjacentStack: (targetId: string, views: ViewCreationOrReference[], options: {
+    createAdjacentStack: (targetId: string, views: ViewCreationOrReference[], { position }?: {
         position?: OpenFin.LayoutPosition;
     }) => Promise<string>;
     getAdjacentStacks: ({ targetId, edge }: {

package/src/api/platform/layout/controllers/layout-entities-controller.js

@@ -148,14 +148,13 @@ class LayoutEntitiesController {
          * Creates a new adjacent 'stack' and adds the views to it at the specified position
          * @param targetId Entity id of the content item to add a stack adjacent to it
          * @param views List of identities or view creation options of the views to include in the stack
-         * @param options Creation options, defaults to position: 'right'
+         * @param options Creation options, defaults to { position: 'right' }
          * @returns the Entity Id of the new stack
          */
-        this.createAdjacentStack = async (targetId, views, options) => {
-            if (views.length === 0) {
-                throw new Error('Cannot create stack with empty view array.');
+        this.createAdjacentStack = async (targetId, views, { position = 'right' } = {}) => {
+            if (!Array.isArray(views) || views.length === 0) {
+                throw new Error('The parameter "views" must be an array with at least 1 element.');
             }
-            const { position = 'right' } = options;
             if (!['top', 'bottom', 'left', 'right'].includes(position)) {
                 throw new Error(`Invalid position '${position}' specified.`);
             }

package/src/api/platform/layout/utils/layout-traversal.d.ts

@@ -1,4 +1,4 @@
 import type * as OpenFin from '../../../../OpenFin';
 export declare const getAdjacentItem: (component: GoldenLayout.ContentItem, edge: OpenFin.LayoutPosition) => GoldenLayout.ContentItem | undefined;
-export declare const doShareEdge: (a: GoldenLayout.ContentItem, b: GoldenLayout.ContentItem, edge: OpenFin.LayoutPosition) => boolean;
+export declare const doShareEdge: (from: GoldenLayout.ContentItem, to: GoldenLayout.ContentItem, edge: OpenFin.LayoutPosition) => boolean;
 export declare const getAdjacentStacks: (item: GoldenLayout.ContentItem, edge: OpenFin.LayoutPosition) => GoldenLayout.ContentItem[];

package/src/api/platform/layout/utils/layout-traversal.js

@@ -18,19 +18,19 @@ const getAdjacentItem = (component, edge) => {
     return (0, exports.getAdjacentItem)(parent, edge);
 };
 exports.getAdjacentItem = getAdjacentItem;
-const doShareEdge = (a, b, edge) => {
+const doShareEdge = (from, to, edge) => {
     var _a, _b;
-    const boundsA = (_a = a.element.get(0)) === null || _a === void 0 ? void 0 : _a.getBoundingClientRect();
-    const boundsB = (_b = b.element.get(0)) === null || _b === void 0 ? void 0 : _b.getBoundingClientRect();
-    if (!boundsA || !boundsB) {
+    const boundsFrom = (_a = from.element.get(0)) === null || _a === void 0 ? void 0 : _a.getBoundingClientRect();
+    const boundsTo = (_b = to.element.get(0)) === null || _b === void 0 ? void 0 : _b.getBoundingClientRect();
+    if (!boundsFrom || !boundsTo) {
         return false;
     }
     if (['top', 'bottom'].includes(edge)) {
-        return ((boundsB.left >= boundsA.left && boundsB.left < boundsA.right) ||
-            (boundsB.right > boundsA.left && boundsB.right <= boundsA.right));
+        const horizontallyOutOfBounds = boundsFrom.right < boundsTo.left || boundsFrom.left > boundsTo.right;
+        return !horizontallyOutOfBounds;
     }
-    return ((boundsB.top >= boundsA.top && boundsB.top < boundsA.bottom) ||
-        (boundsB.bottom > boundsA.top && boundsB.bottom <= boundsA.bottom));
+    const verticallyOutOfBounds = boundsFrom.bottom < boundsTo.top || boundsFrom.top > boundsTo.bottom;
+    return !verticallyOutOfBounds;
 };
 exports.doShareEdge = doShareEdge;
 const getAdjacentStacks = (item, edge) => {