@needle-tools/engine 2.59.0-pre → 2.59.1-pre

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@needle-tools/engine",
-    "version": "2.59.0-pre",
+    "version": "2.59.1-pre",
     "description": "Needle Engine is a web-based runtime for 3D apps. It runs on your machine for development, and can be deployed anywhere. It is flexible, extensible, and collaboration and XR come naturally.",
     "main": "dist/needle-engine.umd.cjs",
     "module": "dist/needle-engine.js",
@@ -47,7 +47,7 @@
         "peerjs": "1.3.2",
         "simplex-noise": "^4.0.1",
         "stats.js": "^0.17.0",
-        "three": "npm:@needle-tools/three@^0.146.4",
+        "three": "npm:@needle-tools/three@^0.146.5",
         "three-mesh-ui": "^6.4.5",
         "three.quarks": "^0.7.3",
         "uuid": "^9.0.0",
@@ -56,7 +56,7 @@
     "devDependencies": {
         "@babel/runtime": "^7.16.0",
         "@luncheon/esbuild-plugin-gzip": "^0.1.0",
-        "@needle-tools/gltf-transform-extensions": "^0.10.8-pre",
+        "@needle-tools/gltf-transform-extensions": "^0.10.9-pre",
         "@needle-tools/needle-component-compiler": "1.9.3",
         "@needle-tools/helper": "^0.2.1-pre",
         "@types/three": "0.146.0",

package/src/engine/engine_networking_utils.ts

@@ -4,8 +4,12 @@
 // for (let url of testUrls)
 //     console.log("Testing url: " + url, isLocalNetwork(url));
 
+const localNetworkResults = new Map<string, boolean>();
+
 export function isLocalNetwork(hostname = window.location.hostname) {
+    if(localNetworkResults.has(hostname)) return localNetworkResults.get(hostname);
     const isLocalNetwork = new RegExp("[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}|localhost", "gm").test(hostname);
+    localNetworkResults.set(hostname, isLocalNetwork);
     if (isLocalNetwork === true) return true;
     return false;
 }

package/src/engine/extensions/NEEDLE_lightmaps.ts

@@ -73,11 +73,12 @@ export class NEEDLE_lightmaps implements GLTFLoaderPlugin {
                                         else 
                                             tex.encoding = LinearEncoding;
 
-                                        // not sure why, but seems EXR-loaded float textures need to be flipped
-                                        if (entry.type === LightmapType.Skybox) {
-                                            if (tex.type == FloatType || tex.type == HalfFloatType)
-                                                tex.flipY = true;
-                                        }
+                                            
+                                        // Dont flip skybox textures anymore - previously we exported them flipped when baking in Unity but now we allow to pass through export without re-baking exisitng skybox textures if they use default values. So we expect textures to be NOT flipped anymore
+                                        // if (entry.type === LightmapType.Skybox) {
+                                        //     if (tex.type == FloatType || tex.type == HalfFloatType)
+                                        //         tex.flipY = true;
+                                        // }
 
                                         this.registry.registerTexture(this.source, entry.type, tex, entry.index);
                                     }

package/src/engine-components/SpectatorCamera.ts

@@ -15,6 +15,7 @@ import { RaycastOptions } from "../engine/engine_physics";
 import { RoomEvents } from "../engine/engine_networking";
 import { ICamera } from "../engine/engine_types";
 import { IModel } from "../engine/engine_networking_types";
+import { serializable } from "../engine/engine_serialization";
 
 
 export enum SpectatorMode {
@@ -28,6 +29,10 @@ export class SpectatorCamera extends Behaviour {
 
     cam: Camera | null = null;
 
+    /** when enabled pressing F will send a request to all connected users to follow me, ESC to stop */
+    @serializable()
+    useKeys: boolean = true;
+
     private _mode: SpectatorMode = SpectatorMode.FirstPerson;
 
     get mode() { return this._mode; }
@@ -448,7 +453,8 @@ class SpectatorSelectionController {
         this.context = context;
         this.spectator = spectator;
         console.log("Click other avatars or cameras to follow them. Press ESC to exit spectator mode.");
-        window.addEventListener("keydown", (evt) => {
+        this.context.domElement.addEventListener("keydown", (evt) => {
+            if(!this.spectator.useKeys) return;
             const key = evt.key;
             if (key === "Escape") {
                 this.spectator.stopSpectating();
@@ -544,7 +550,8 @@ class SpectatorCamNetworking {
         this.context.connection.beginListen("spectator-follower-changed", this._followerEventMethod);
         this.context.connection.beginListen("spectator-request-follow", this._requestFollowMethod);
         this.context.connection.beginListen(RoomEvents.JoinedRoom, this._joinedRoomMethod);
-        document.addEventListener("keydown", evt => {
+        this.context.domElement.addEventListener("keydown", evt => {
+            if(!this.spectator.useKeys) return;
             if (evt.key === "f") {
                 this.onRequestFollowMe();
             }

package/src/engine-components/SyncedRoom.ts

@@ -20,8 +20,12 @@ export class SyncedRoom extends Behaviour {
 
     private _roomPrefix?: string;
 
+    public get RoomPrefix(): string | undefined {
+        return this._roomPrefix;
+    }
+
     awake() {
-        if(debug) console.log("Room", this.roomName, this.urlParameterName, this.joinRandomRoom, this.requireRoomParameter, this.autoRejoin);
+        if (debug) console.log("Room", this.roomName, this.urlParameterName, this.joinRandomRoom, this.requireRoomParameter, this.autoRejoin);
         if (this._roomPrefix === undefined) {
             this._roomPrefix = this.roomName;
             this.roomName = "";