@mindrian_os/install 1.13.0-beta.17 → 1.13.0-beta.21

package/lib/memory/skill-vs-code-drift.test.cjs

@@ -0,0 +1,257 @@
+#!/usr/bin/env node
+'use strict';
+
+/*
+ * Copyright (c) 2026 Mindrian. BSL 1.1.
+ *
+ * Phase 121.5-02 Task 2 -- skill-vs-code-drift checker test suite
+ * =================================================================
+ * Tests scripts/check-skill-vs-code-drift.cjs. The checker scans
+ * skills/ui-system/SKILL.md against the shipped renderer / glyph / shape
+ * code in lib/render/render-v2.cjs and asserts:
+ *   - Every F.N shape implemented in code is documented in SKILL.md
+ *   - SKILL.md cross-references Canon Part 3 + Canon Part 10 + the dual
+ *     palette source (JTBD-PALETTES) + the ODD 4 resolution paragraph
+ *   - The three required sidecar rules files exist
+ *
+ * Tests 1, 4, 5, 6, 8 run against the LIVE repo (Task 1 output).
+ * Tests 2, 3, 7 use synthetic fixtures via fs.mkdtempSync to exercise the
+ * drift-detection paths without touching the real repo.
+ *
+ * Canon Part 7 invariant: this test asserts the reconciliation lands as
+ * data, not as promise. A future drift will fail the checker at PR time,
+ * not at audit time.
+ *
+ * No em-dashes, no emoji (per skills/ui-system/SKILL.md §3).
+ */
+
+const fs = require('fs');
+const path = require('path');
+const os = require('os');
+
+const CHECKER_PATH = path.join(__dirname, '..', '..', 'scripts', 'check-skill-vs-code-drift.cjs');
+const REPO_ROOT = path.join(__dirname, '..', '..');
+const REAL_SKILL = path.join(REPO_ROOT, 'skills', 'ui-system', 'SKILL.md');
+const REAL_CODE = path.join(REPO_ROOT, 'lib', 'render', 'render-v2.cjs');
+const REAL_RULES_DIR = path.join(REPO_ROOT, 'skills', 'ui-system', 'rules');
+
+let passed = 0;
+let failed = 0;
+const failures = [];
+
+function assert(cond, msg) {
+  if (cond) {
+    passed++;
+  } else {
+    failed++;
+    failures.push(msg);
+    console.error('  FAIL: ' + msg);
+  }
+}
+
+function test(label, fn) {
+  console.log('--- ' + label + ' ---');
+  try {
+    fn();
+    console.log('  passed');
+  } catch (e) {
+    failed++;
+    failures.push(label + ': ' + e.message);
+    console.error('  THREW: ' + e.message);
+  }
+}
+
+function loadChecker() {
+  // Bust require-cache so changes to the checker module surface immediately.
+  delete require.cache[require.resolve(CHECKER_PATH)];
+  return require(CHECKER_PATH);
+}
+
+function stageFixture(opts) {
+  const tmp = fs.mkdtempSync(path.join(os.tmpdir(), 'skill-drift-fixture-'));
+  const skillPath = path.join(tmp, 'SKILL.md');
+  const codePath = path.join(tmp, 'render-v2.cjs');
+  const rulesDir = path.join(tmp, 'rules');
+  fs.mkdirSync(rulesDir, { recursive: true });
+  fs.writeFileSync(skillPath, opts.skill || '');
+  if (typeof opts.code === 'string') fs.writeFileSync(codePath, opts.code);
+  if (Array.isArray(opts.rulesFiles)) {
+    for (const f of opts.rulesFiles) {
+      fs.writeFileSync(path.join(rulesDir, f), 'stub\n');
+    }
+  }
+  return { tmp, skillPath, codePath, rulesDir };
+}
+
+// ===========================================================================
+// Test 1: clean repo (live files) -> valid:true
+// ===========================================================================
+test('Test 1: clean repo lives at green (Task 1 output)', () => {
+  const { check } = loadChecker();
+  const result = check();
+  assert(result && typeof result === 'object', 'check() returned object');
+  assert(result.valid === true,
+    'live repo valid=true (got ' + result.valid + '); missing_in_skill=' +
+    JSON.stringify(result.missing_in_skill) + ' missing_crossrefs=' +
+    JSON.stringify(result.missing_crossrefs) + ' missing_rules=' +
+    JSON.stringify(result.missing_rules_files));
+  assert(Array.isArray(result.missing_in_skill), 'missing_in_skill is array');
+  assert(Array.isArray(result.missing_in_code), 'missing_in_code is array');
+  assert(Array.isArray(result.missing_crossrefs), 'missing_crossrefs is array');
+  assert(Array.isArray(result.missing_rules_files), 'missing_rules_files is array');
+});
+
+// ===========================================================================
+// Test 2: SKILL.md lists F.7 (bogus); code has no F.7 -> code-missing flagged
+// in missing_in_code (NOT fatal); valid stays true UNLESS other failures.
+// To make the test exercise a FATAL drift, we also strip code F.0 so it
+// appears in SKILL but missing from code -- producing the asymmetric severity
+// behavior: missing_in_code on its own does NOT flip valid. We then verify
+// the inverse (Test 3) where SKILL is missing code shapes -> valid:false.
+// ===========================================================================
+test('Test 2: SKILL with extra F.7 but code lacks it -> missing_in_code flag (non-fatal)', () => {
+  const { check } = loadChecker();
+  const fixture = stageFixture({
+    skill: '# stub\n\nShape F.0 here.\nShape F.1 here.\nShape F.7 bogus.\n\nCanon Part 3\nCanon Part 10\nJTBD-PALETTES\nODD 4 resolution\n',
+    code: 'F.0 F.1\n',
+    rulesFiles: ['shape-f-zero-and-six.md', 'dual-palette.md', 'glyph-disambiguation.md'],
+  });
+  const result = check({
+    skillPath: fixture.skillPath,
+    codePath: fixture.codePath,
+    rulesDir: fixture.rulesDir,
+  });
+  // SKILL has F.0, F.1, F.7 -- code has F.0, F.1. F.7 is in skill but not in code.
+  assert(result.missing_in_code.indexOf('F.7') !== -1,
+    'F.7 present in SKILL but missing in code (got missing_in_code=' +
+    JSON.stringify(result.missing_in_code) + ')');
+  // missing_in_code alone does NOT flip valid (asymmetric severity per plan).
+  assert(result.valid === true,
+    'missing_in_code alone is non-fatal -> valid stays true (got ' + result.valid + ')');
+});
+
+// ===========================================================================
+// Test 3: code implements F.6 but SKILL.md does NOT document it -> valid:false
+// ===========================================================================
+test('Test 3: code has F.6 but SKILL lacks it -> valid:false', () => {
+  const { check } = loadChecker();
+  const fixture = stageFixture({
+    skill: '# stub\n\nShape F.0\nShape F.1\nShape F.2\nShape F.3\nShape F.4\nShape F.5\n\nCanon Part 3\nCanon Part 10\nJTBD-PALETTES\nODD 4 resolution\n',
+    code: 'F.0 F.1 F.2 F.3 F.4 F.5 F.6\n',
+    rulesFiles: ['shape-f-zero-and-six.md', 'dual-palette.md', 'glyph-disambiguation.md'],
+  });
+  const result = check({
+    skillPath: fixture.skillPath,
+    codePath: fixture.codePath,
+    rulesDir: fixture.rulesDir,
+  });
+  assert(result.missing_in_skill.indexOf('F.6') !== -1,
+    'F.6 implemented in code but missing from SKILL (got missing_in_skill=' +
+    JSON.stringify(result.missing_in_skill) + ')');
+  assert(result.valid === false,
+    'SKILL missing code-shipped F.6 is FATAL -> valid:false (got ' + result.valid + ')');
+});
+
+// ===========================================================================
+// Test 4: live SKILL.md cross-references lib/render/JTBD-PALETTES.md (grep)
+// ===========================================================================
+test('Test 4: live SKILL.md cross-references JTBD-PALETTES', () => {
+  const txt = fs.readFileSync(REAL_SKILL, 'utf8');
+  assert(txt.indexOf('JTBD-PALETTES') !== -1,
+    'SKILL.md mentions JTBD-PALETTES (the Phase 102 source-of-truth file)');
+});
+
+// ===========================================================================
+// Test 5: live SKILL.md contains ODD 4 resolution paragraph
+// ===========================================================================
+test('Test 5: live SKILL.md contains ODD 4 resolution', () => {
+  const txt = fs.readFileSync(REAL_SKILL, 'utf8');
+  assert(txt.indexOf('ODD 4 resolution') !== -1,
+    'SKILL.md contains ODD 4 resolution paragraph (the glyph + word disambiguation carve-out)');
+});
+
+// ===========================================================================
+// Test 6: live SKILL.md contains Canon Part 3 AND Canon Part 10 cross-refs
+// ===========================================================================
+test('Test 6: live SKILL.md cross-references Canon Part 3 + Part 10', () => {
+  const txt = fs.readFileSync(REAL_SKILL, 'utf8');
+  assert(txt.indexOf('Canon Part 3') !== -1, 'SKILL.md cross-references Canon Part 3');
+  assert(txt.indexOf('Canon Part 10') !== -1, 'SKILL.md cross-references Canon Part 10');
+});
+
+// ===========================================================================
+// Test 7: three sidecar rules files exist (synthetic fixture w/ NONE missing)
+// vs synthetic fixture missing one -> valid:false
+// ===========================================================================
+test('Test 7: missing sidecar rules file -> valid:false', () => {
+  const { check } = loadChecker();
+  // Fixture with ALL three rules files -> valid (assuming other checks pass).
+  const all = stageFixture({
+    skill: '# stub\n\nShape F.0\n\nCanon Part 3\nCanon Part 10\nJTBD-PALETTES\nODD 4 resolution\n',
+    code: 'F.0\n',
+    rulesFiles: ['shape-f-zero-and-six.md', 'dual-palette.md', 'glyph-disambiguation.md'],
+  });
+  const ok = check({
+    skillPath: all.skillPath,
+    codePath: all.codePath,
+    rulesDir: all.rulesDir,
+  });
+  assert(ok.valid === true,
+    'all 3 rules files + cross-refs + matched shapes -> valid:true (got ' + ok.valid +
+    '; missing_rules_files=' + JSON.stringify(ok.missing_rules_files) + ')');
+  // Fixture missing dual-palette.md -> valid:false.
+  const missing = stageFixture({
+    skill: '# stub\n\nShape F.0\n\nCanon Part 3\nCanon Part 10\nJTBD-PALETTES\nODD 4 resolution\n',
+    code: 'F.0\n',
+    rulesFiles: ['shape-f-zero-and-six.md', 'glyph-disambiguation.md'],
+  });
+  const bad = check({
+    skillPath: missing.skillPath,
+    codePath: missing.codePath,
+    rulesDir: missing.rulesDir,
+  });
+  assert(bad.missing_rules_files.indexOf('dual-palette.md') !== -1,
+    'missing dual-palette.md detected (got missing_rules_files=' +
+    JSON.stringify(bad.missing_rules_files) + ')');
+  assert(bad.valid === false,
+    'missing rules file is FATAL -> valid:false (got ' + bad.valid + ')');
+});
+
+// ===========================================================================
+// Test 8: --json mode emits structured drift report
+// ===========================================================================
+test('Test 8: --json mode emits structured report', () => {
+  const { execFileSync } = require('child_process');
+  const out = execFileSync('node', [CHECKER_PATH, '--json'], { encoding: 'utf8' });
+  let parsed;
+  try {
+    parsed = JSON.parse(out);
+  } catch (e) {
+    assert(false, '--json output is parseable JSON; got: ' + out.slice(0, 200));
+    return;
+  }
+  assert(typeof parsed.valid === 'boolean', '--json emits valid:boolean');
+  assert(Array.isArray(parsed.missing_in_skill), '--json emits missing_in_skill[]');
+  assert(Array.isArray(parsed.missing_in_code), '--json emits missing_in_code[]');
+  assert(Array.isArray(parsed.missing_crossrefs), '--json emits missing_crossrefs[]');
+  assert(Array.isArray(parsed.missing_rules_files), '--json emits missing_rules_files[]');
+});
+
+// ===========================================================================
+// Summary
+// ===========================================================================
+console.log('');
+console.log('========================================');
+console.log('  skill-vs-code-drift test suite');
+console.log('========================================');
+console.log('  Passed: ' + passed);
+console.log('  Failed: ' + failed);
+if (failed > 0) {
+  console.log('');
+  console.log('  Failures:');
+  for (const f of failures) {
+    console.log('    - ' + f);
+  }
+  process.exit(1);
+}
+process.exit(0);

package/lib/memory/soft-alias.test.cjs

@@ -0,0 +1,144 @@
+#!/usr/bin/env node
+/*
+ * Phase 121.5-08 Plan -- soft-alias-runner unit tests.
+ *
+ * Behavior contract (per plan):
+ *   T1: softAliasRun({from, to, args}) returns a JSON envelope with the
+ *       redirect target, the deprecation note, the args, and ok: true.
+ *   T2: The deprecation note follows Larry voice: starts with "Deprecated. "
+ *       and names the new command, and mentions v1.14.0 removal.
+ *   T3: NO em-dash characters (U+2014) anywhere in the deprecation note.
+ *   T4: softAliasRun({from, to, args}) returns {redirect, args, ok: true}
+ *       shape suitable for the LLM to act on.
+ *   T8a: commands/mos.md exists.
+ *   T8b: commands/mos.md declares body_shape: E (Action Report).
+ *   T9: Each of the 5 soft-alias stub commands (heal, query, organize,
+ *       hmi-status, visualize) carries the "Deprecated" body marker AND
+ *       names the canonical target.
+ *   T10a: commands/diagnostics.md carries the "Renamed" rename note + names
+ *       /mos:fingerprint as the v1.14.0 target.
+ *   T10b: diagnostics.md frontmatter has renaming_to: fingerprint.
+ *
+ * No em-dash check covers every soft-alias stub body.
+ *
+ * Hermetic: reads only the live repo files via fs.readFileSync. No network,
+ * no spawn (the runner's emitForLLM uses process.stdout, but we test
+ * softAliasRun directly).
+ */
+'use strict';
+
+const fs = require('fs');
+const path = require('path');
+
+const REPO_ROOT = path.resolve(__dirname, '..', '..');
+const RUNNER = require(path.join(REPO_ROOT, 'scripts', 'soft-alias-runner.cjs'));
+
+let pass = 0;
+let fail = 0;
+const failures = [];
+
+function assert(cond, name, detail) {
+  if (cond) {
+    pass++;
+    console.log('PASS  ' + name);
+  } else {
+    fail++;
+    failures.push(name + (detail ? ' -- ' + detail : ''));
+    console.log('FAIL  ' + name + (detail ? ' -- ' + detail : ''));
+  }
+}
+
+// --- T1: redirect target + JSON envelope shape ---
+{
+  const r = RUNNER.softAliasRun({ from: 'heal', to: 'doctor --heal-room', args: ['--dry-run'] });
+  assert(r && typeof r === 'object', 'T1: returns an object', JSON.stringify(r));
+  assert(r.redirect === '/mos:doctor --heal-room', 'T1: redirect is /mos:doctor --heal-room', r.redirect);
+  assert(Array.isArray(r.args) && r.args[0] === '--dry-run', 'T1: args list preserved', JSON.stringify(r.args));
+  assert(r.ok === true, 'T1: ok=true');
+  assert(typeof r.deprecation_note === 'string' && r.deprecation_note.length > 0, 'T1: deprecation_note non-empty');
+}
+
+// --- T2: Larry voice: starts with "Deprecated. " + names new command + v1.14.0 ---
+{
+  const r = RUNNER.softAliasRun({ from: 'query', to: 'graph', args: [] });
+  assert(r.deprecation_note.indexOf('Deprecated. ') === 0, 'T2: starts with "Deprecated. "', r.deprecation_note);
+  assert(r.deprecation_note.indexOf('/mos:graph') >= 0, 'T2: names the new command (/mos:graph)', r.deprecation_note);
+  assert(/v1\.14\.0/.test(r.deprecation_note), 'T2: mentions v1.14.0 removal', r.deprecation_note);
+}
+
+// --- T3: NO em-dash anywhere in the note ---
+{
+  const samples = [
+    RUNNER.softAliasRun({ from: 'heal', to: 'doctor --heal-room', args: [] }),
+    RUNNER.softAliasRun({ from: 'query', to: 'graph', args: [] }),
+    RUNNER.softAliasRun({ from: 'organize', to: 'rooms organize', args: [] }),
+    RUNNER.softAliasRun({ from: 'hmi-status', to: 'doctor --ui-compliance --json', args: [] }),
+    RUNNER.softAliasRun({ from: 'visualize', to: 'dashboard --mermaid', args: [] }),
+  ];
+  for (const r of samples) {
+    assert(r.deprecation_note.indexOf('—') < 0,
+      'T3: no em-dash in note (from=' + (r && r.redirect) + ')',
+      r.deprecation_note);
+  }
+}
+
+// --- T4: shape is consumable by LLM ---
+{
+  const r = RUNNER.softAliasRun({ from: 'organize', to: 'rooms organize', args: ['propose'] });
+  const keys = Object.keys(r).sort();
+  const required = ['args', 'deprecation_note', 'ok', 'redirect'];
+  for (const k of required) {
+    assert(keys.indexOf(k) >= 0, 'T4: envelope has key "' + k + '"', JSON.stringify(keys));
+  }
+}
+
+// --- T8: commands/mos.md exists + body_shape: E ---
+{
+  const mosPath = path.join(REPO_ROOT, 'commands', 'mos.md');
+  assert(fs.existsSync(mosPath), 'T8a: commands/mos.md exists', mosPath);
+  if (fs.existsSync(mosPath)) {
+    const body = fs.readFileSync(mosPath, 'utf8');
+    // Accept body_shape: E OR body_shape: E (Action Report) form
+    assert(/^body_shape:\s*E(\s|$|\b)/m.test(body), 'T8b: declares body_shape: E', body.slice(0, 400));
+    assert(/state-aware router/i.test(body), 'T8c: body mentions "state-aware router"');
+    assert(body.indexOf('—') < 0, 'T8d: NO em-dash in commands/mos.md');
+  }
+}
+
+// --- T9: 5 soft-alias stubs carry "Deprecated" + name their canonical target ---
+{
+  const stubs = [
+    { file: 'commands/heal.md', target: '/mos:doctor --heal-room' },
+    { file: 'commands/query.md', target: '/mos:graph' },
+    { file: 'commands/organize.md', target: '/mos:rooms organize' },
+    { file: 'commands/hmi-status.md', target: '/mos:doctor --ui-compliance' },
+    { file: 'commands/visualize.md', target: '/mos:dashboard --mermaid' },
+  ];
+  for (const s of stubs) {
+    const p = path.join(REPO_ROOT, s.file);
+    const body = fs.readFileSync(p, 'utf8');
+    assert(/Deprecated/.test(body), 'T9: ' + s.file + ' body has "Deprecated"', body.slice(0, 200));
+    assert(body.indexOf(s.target) >= 0, 'T9: ' + s.file + ' names target ' + s.target);
+    assert(body.indexOf('—') < 0, 'T9: ' + s.file + ' has no em-dash');
+    assert(/^deprecated:\s*true/m.test(body), 'T9: ' + s.file + ' frontmatter deprecated: true');
+  }
+}
+
+// --- T10: diagnostics.md is a RENAME (not fold) to /mos:fingerprint ---
+{
+  const p = path.join(REPO_ROOT, 'commands', 'diagnostics.md');
+  const body = fs.readFileSync(p, 'utf8');
+  assert(/Renamed/.test(body), 'T10a: diagnostics.md body has "Renamed"');
+  assert(body.indexOf('/mos:fingerprint') >= 0, 'T10b: diagnostics.md names /mos:fingerprint');
+  assert(/^renaming_to:\s*fingerprint/m.test(body), 'T10c: diagnostics.md frontmatter renaming_to: fingerprint');
+  assert(body.indexOf('—') < 0, 'T10d: diagnostics.md has no em-dash');
+}
+
+console.log('');
+console.log('soft-alias.test.cjs: ' + pass + ' passed, ' + fail + ' failed');
+if (fail > 0) {
+  console.log('FAILURES:');
+  for (const f of failures) console.log('  - ' + f);
+  process.exit(1);
+}
+process.exit(0);