@mikro-orm/sql 7.0.17 → 7.0.18-dev.1

package/schema/DatabaseTable.js

@@ -1,4 +1,5 @@
 import { DecimalType, EntitySchema, isRaw, ReferenceKind, t, Type, UnknownType, Utils, } from '@mikro-orm/core';
+import { toEntityPartitionBy } from './partitioning.js';
 /**
  * @internal
  */
@@ -8,10 +9,19 @@ export class DatabaseTable {
     #columns = {};
     #indexes = [];
     #checks = [];
+    #triggers = [];
     #foreignKeys = {};
     #platform;
     nativeEnums = {}; // for postgres
     comment;
+    partitioning;
+    /**
+     * Effective collation the column defaults to when no explicit `COLLATE` is set on a column.
+     * For MySQL/MariaDB this is the table collation; for PostgreSQL and MSSQL this is the database default;
+     * SQLite has no configurable default. Used by `SchemaComparator.diffCollation` to avoid flapping
+     * when a property explicitly names the default collation.
+     */
+    collation;
     constructor(platform, name, schema) {
         this.name = name;
         this.schema = schema;
@@ -35,6 +45,16 @@ export class DatabaseTable {
     getChecks() {
         return this.#checks;
     }
+    getPartitioning() {
+        return this.partitioning;
+    }
+    /** @internal */
+    setPartitioning(partitioning) {
+        this.partitioning = partitioning;
+    }
+    getTriggers() {
+        return this.#triggers;
+    }
     /** @internal */
     setIndexes(indexes) {
         this.#indexes = indexes;
@@ -44,6 +64,10 @@ export class DatabaseTable {
         this.#checks = checks;
     }
     /** @internal */
+    setTriggers(triggers) {
+        this.#triggers = triggers;
+    }
+    /** @internal */
     setForeignKeys(fks) {
         this.#foreignKeys = fks;
     }
@@ -113,6 +137,7 @@ export class DatabaseTable {
                 default: prop.defaultRaw,
                 enumItems: prop.nativeEnumName || prop.items?.every(i => typeof i === 'string') ? prop.items : undefined,
                 comment: prop.comment,
+                collation: prop.collation,
                 extra: prop.extra,
                 ignoreSchemaChanges: prop.ignoreSchemaChanges,
             };
@@ -185,6 +210,7 @@ export class DatabaseTable {
         const { fksOnColumnProps, fksOnStandaloneProps, columnFks, fkIndexes, nullableForeignKeys, skippedColumnNames } = this.foreignKeysToProps(namingStrategy, scalarPropertiesForRelations);
         const name = namingStrategy.getEntityName(this.name, this.schema);
         const schema = new EntitySchema({ name, collection: this.name, schema: this.schema, comment: this.comment });
+        schema.meta.partitionBy = toEntityPartitionBy(this.partitioning, this.name, this.schema);
         const compositeFkIndexes = {};
         const compositeFkUniques = {};
         const potentiallyUnmappedIndexes = this.#indexes.filter(index => !index.primary && // Skip primary index. Whether it's in use by scalar column or FK, it's already mapped.
@@ -204,6 +230,7 @@ export class DatabaseTable {
                 name: index.keyName,
                 deferMode: index.deferMode,
                 expression: index.expression,
+                where: index.where,
                 // Advanced index options - convert column names to property names
                 columns: index.columns?.map(col => ({
                     ...col,
@@ -234,7 +261,7 @@ export class DatabaseTable {
                 index.invisible ||
                 index.disabled ||
                 index.clustered;
-            const isTrivial = !index.deferMode && !index.expression && !hasAdvancedOptions;
+            const isTrivial = !index.deferMode && !index.expression && !index.where && !hasAdvancedOptions;
             if (isTrivial) {
                 // Index is for FK. Map to the FK prop and move on.
                 const fkForIndex = fkIndexes.get(index);
@@ -606,6 +633,12 @@ export class DatabaseTable {
     hasCheck(checkName) {
         return !!this.getCheck(checkName);
     }
+    getTrigger(triggerName) {
+        return this.#triggers.find(t => t.name === triggerName);
+    }
+    hasTrigger(triggerName) {
+        return !!this.getTrigger(triggerName);
+    }
     getPrimaryKey() {
         return this.#indexes.find(i => i.primary);
     }
@@ -640,6 +673,7 @@ export class DatabaseTable {
             columnOptions.scale = column.scale;
             columnOptions.extra = column.extra;
             columnOptions.comment = column.comment;
+            columnOptions.collation = column.collation;
             columnOptions.enum = !!column.enumItems?.length;
             columnOptions.items = column.enumItems;
         }
@@ -706,6 +740,7 @@ export class DatabaseTable {
             scale: column.scale,
             extra: column.extra,
             comment: column.comment,
+            collation: column.collation,
             index: index ? index.keyName : undefined,
             unique: unique ? unique.keyName : undefined,
             enum: !!column.enumItems?.length,
@@ -870,16 +905,25 @@ export class DatabaseTable {
         if (index.fillFactor != null && (index.fillFactor < 0 || index.fillFactor > 100)) {
             throw new Error(`fillFactor must be between 0 and 100, got ${index.fillFactor} for index '${name}' on entity '${meta.className}'`);
         }
+        // The `expression` escape hatch takes the full index definition as raw SQL; combining it
+        // with `where` is dialect-dependent (PG/Oracle/MySQL drop `where`, MSSQL appends it) so we
+        // reject the combination up-front and ask users to inline the predicate into `expression`.
+        if (index.expression && index.where != null) {
+            throw new Error(`Index '${name}' on entity '${meta.className}': cannot combine \`expression\` with \`where\` — inline the WHERE clause into the \`expression\` escape hatch, or drop \`expression\` and use structured \`properties\` + \`where\`.`);
+        }
+        const where = this.processIndexWhere(index.where, meta);
         this.#indexes.push({
             keyName: name,
             columnNames: properties,
             composite: properties.length > 1,
-            // JSON columns can have unique index but not unique constraint, and we need to distinguish those, so we can properly drop them
-            constraint: type !== 'index' && !properties.some((d) => d.includes('.')),
+            // JSON columns can have unique index but not unique constraint, and we need to distinguish those, so we can properly drop them.
+            // Partial indexes (`where`) must use CREATE [UNIQUE] INDEX form — constraints can't carry predicates.
+            constraint: type !== 'index' && !properties.some((d) => d.includes('.')) && !where,
             primary: type === 'primary',
             unique: type !== 'index',
             type: index.type,
             expression: this.processIndexExpression(name, index.expression, meta),
+            where,
             options: index.options,
             deferMode: index.deferMode,
             columns,
@@ -890,9 +934,21 @@ export class DatabaseTable {
             clustered: index.clustered,
         });
     }
+    processIndexWhere(where, meta) {
+        if (where == null) {
+            return undefined;
+        }
+        // The driver is always an `AbstractSqlDriver` here — `DatabaseTable` is only instantiated
+        // by SQL-side schema code, so the platform's config-bound driver is guaranteed to be one.
+        const driver = this.#platform.getConfig().getDriver();
+        return driver.renderPartialIndexWhere(meta.class, where);
+    }
     addCheck(check) {
         this.#checks.push(check);
     }
+    addTrigger(trigger) {
+        this.#triggers.push(trigger);
+    }
     toJSON() {
         const columns = this.#columns;
         // locale-independent comparison so the snapshot is stable across machines
@@ -939,6 +995,7 @@ export class DatabaseTable {
                 scale: fixedPrecision ? null : (c.scale ?? null),
                 default: c.default ?? null,
                 comment: c.comment ?? null,
+                collation: c.collation ?? null,
                 enumItems: c.enumItems ?? [],
                 mappedType: Utils.keys(t).find(k => t[k] === c.mappedType.constructor),
             };
@@ -1012,6 +1069,7 @@ export class DatabaseTable {
         };
         const sortedIndexes = [...this.#indexes].sort((a, b) => byString(a.keyName, b.keyName)).map(normalizeIndex);
         const sortedChecks = [...this.#checks].sort((a, b) => byString(a.name, b.name)).map(normalizeCheck);
+        const sortedTriggers = [...this.#triggers].sort((a, b) => byString(a.name, b.name));
         const sortedForeignKeys = Object.fromEntries(Object.entries(this.#foreignKeys)
             .sort(([a], [b]) => byString(a, b))
             .map(([k, v]) => [k, normalizeFk(v)]));
@@ -1021,6 +1079,7 @@ export class DatabaseTable {
             columns: columnsMapped,
             indexes: sortedIndexes,
             checks: sortedChecks,
+            triggers: sortedTriggers,
             foreignKeys: sortedForeignKeys,
             // emit `comment` even when unset so introspection (which always reads it) matches metadata
             comment: this.comment ?? null,

package/schema/SchemaComparator.d.ts

@@ -17,6 +17,15 @@ export declare class SchemaComparator {
      * stored in toSchema.
      */
     compare(fromSchema: DatabaseSchema, toSchema: DatabaseSchema, inverseDiff?: SchemaDifference): SchemaDifference;
+    private compareRoutines;
+    private diffRoutine;
+    /** Strips outer `BEGIN ... END` and trailing semicolons so the comparator doesn't churn on cosmetic round-trip differences. */
+    private normaliseBody;
+    private diffRoutineParams;
+    /** Engines drop length/precision modifiers and use different aliases for the same logical type — canonicalise both sides. */
+    private normaliseParamType;
+    private static readonly PARAM_TYPE_ALIASES;
+    private diffRoutineReturns;
     /**
      * Returns the difference between the tables fromTable and toTable.
      * If there are no differences this method returns the boolean false.
@@ -39,6 +48,15 @@ export declare class SchemaComparator {
     diffColumn(fromColumn: Column, toColumn: Column, fromTable: DatabaseTable, logging?: boolean): Set<string>;
     diffEnumItems(items1?: string[], items2?: string[]): boolean;
     diffComment(comment1?: string, comment2?: string): boolean;
+    /**
+     * `from` is the introspected DB state, `to` is the target metadata. A column-level `COLLATE`
+     * clause naming the table/database default is just verbose syntax for inheriting that default,
+     * so both sides are normalized — anything matching `tableDefault` collapses to `undefined` and
+     * compares equal to "no explicit collation". Comparison is case-insensitive on dialects that
+     * treat collation identifiers as case-insensitive (MySQL/MSSQL/SQLite); PostgreSQL's
+     * `pg_collation.collname` is case-sensitive and is compared verbatim.
+     */
+    diffCollation(fromCollation?: string, toCollation?: string, tableDefault?: string): boolean;
     /**
      * Finds the difference between the indexes index1 and index2.
      * Compares index1 with index2 and returns index2 if there are any differences or false in case there are no differences.
@@ -69,6 +87,7 @@ export declare class SchemaComparator {
      * @see https://github.com/mikro-orm/mikro-orm/issues/7308
      */
     private diffViewExpression;
+    private diffTrigger;
     parseJsonDefault(defaultValue?: string | null): Dictionary | string | null;
     hasSameDefaultValue(from: Column, to: Column): boolean;
     private mapColumnToProperty;

package/schema/SchemaComparator.js

@@ -1,5 +1,6 @@
 import { ArrayType, BooleanType, DateTimeType, inspect, JsonType, parseJsonSafe, Utils, } from '@mikro-orm/core';
 import { DatabaseTable } from './DatabaseTable.js';
+import { diffPartitioning } from './partitioning.js';
 /**
  * Compares two Schemas and return an instance of SchemaDifference.
  */
@@ -27,6 +28,9 @@ export class SchemaComparator {
             newViews: {},
             changedViews: {},
             removedViews: {},
+            newRoutines: {},
+            changedRoutines: {},
+            removedRoutines: {},
             orphanedForeignKeys: [],
             newNativeEnums: [],
             removedNativeEnums: [],
@@ -162,8 +166,151 @@ export class SchemaComparator {
                 diff.changedTables[viewName] = tableDiff;
             }
         }
+        this.compareRoutines(fromSchema, toSchema, diff);
         return diff;
     }
+    compareRoutines(fromSchema, toSchema, diff) {
+        // Case-fold so user-written `'sql_hash'` matches Oracle's introspected `'SQL_HASH'`.
+        const routineKey = (r) => ((r.schema ? `${r.schema}.` : '') + r.name).toLowerCase();
+        const fromByKey = new Map(fromSchema.getRoutines().map(r => [routineKey(r), r]));
+        const toByKey = new Map(toSchema.getRoutines().map(r => [routineKey(r), r]));
+        for (const [key, toRoutine] of toByKey) {
+            const fromRoutine = fromByKey.get(key);
+            if (!fromRoutine) {
+                diff.newRoutines[key] = toRoutine;
+                this.log(`routine ${key} added`);
+                continue;
+            }
+            if (this.diffRoutine(fromRoutine, toRoutine)) {
+                diff.changedRoutines[key] = { from: fromRoutine, to: toRoutine };
+                this.log(`routine ${key} changed`, { fromRoutine, toRoutine });
+            }
+        }
+        for (const [key, fromRoutine] of fromByKey) {
+            if (!toByKey.has(key)) {
+                diff.removedRoutines[key] = fromRoutine;
+                this.log(`routine ${key} removed`);
+            }
+        }
+    }
+    diffRoutine(from, to) {
+        const ignore = new Set(to.ignoreSchemaChanges ?? []);
+        if (from.type !== to.type) {
+            this.log(`routine ${from.name}: type ${from.type} -> ${to.type}`);
+            return true;
+        }
+        if (!ignore.has('body') && from.expression == null && to.expression == null) {
+            const a = this.normaliseBody(from.body);
+            const b = this.normaliseBody(to.body);
+            if (a !== b) {
+                this.log(`routine ${from.name}: body differs`, { from: a, to: b });
+                return true;
+            }
+        }
+        if (!ignore.has('comment') && (from.comment ?? '') !== (to.comment ?? '')) {
+            return true;
+        }
+        // For security/deterministic/definer, unset on the metadata side means "don't care": the
+        // DB always has some server default, comparing it would force a drop+create on every run.
+        if (!ignore.has('security') && to.security != null && from.security !== to.security) {
+            return true;
+        }
+        if (!ignore.has('deterministic') &&
+            to.deterministic != null &&
+            (from.deterministic ?? false) !== to.deterministic) {
+            return true;
+        }
+        if (!ignore.has('definer') && to.definer != null && from.definer !== to.definer) {
+            return true;
+        }
+        // `language` (PG) / `dataAccess` (MySQL) follow the same to-side-wins policy: only diff when
+        // the metadata explicitly declares them, otherwise the create DDL's defaults will line up with
+        // whatever the engine introspected.
+        if (to.language != null && (from.language ?? '').toLowerCase() !== to.language.toLowerCase()) {
+            this.log(`routine ${from.name}: language ${from.language} -> ${to.language}`);
+            return true;
+        }
+        if (to.dataAccess != null && from.dataAccess !== to.dataAccess) {
+            this.log(`routine ${from.name}: dataAccess ${from.dataAccess} -> ${to.dataAccess}`);
+            return true;
+        }
+        if (this.diffRoutineParams(from.params, to.params)) {
+            this.log(`routine ${from.name}: params differ`, { from: from.params, to: to.params });
+            return true;
+        }
+        if (this.diffRoutineReturns(from.returns, to.returns)) {
+            this.log(`routine ${from.name}: returns differ`, { from: from.returns, to: to.returns });
+            return true;
+        }
+        return false;
+    }
+    /** Strips outer `BEGIN ... END` and trailing semicolons so the comparator doesn't churn on cosmetic round-trip differences. */
+    normaliseBody(body) {
+        let result = (body ?? '').replace(/\s+/g, ' ').trim();
+        const beginEnd = /^begin\s+([\s\S]*?)\s*end\s*;?\s*$/i.exec(result);
+        if (beginEnd) {
+            result = beginEnd[1].trim();
+        }
+        return result.replace(/;+\s*$/, '').trim();
+    }
+    diffRoutineParams(from, to) {
+        if (from.length !== to.length) {
+            return true;
+        }
+        for (let i = 0; i < from.length; i++) {
+            const a = from[i];
+            const b = to[i];
+            if (a.name.toLowerCase() !== b.name.toLowerCase() ||
+                this.normaliseParamType(a.type) !== this.normaliseParamType(b.type) ||
+                a.direction !== b.direction) {
+                return true;
+            }
+            // Asymmetric: drivers don't currently introspect param nullability, so the from side is
+            // always undefined; comparing eagerly would churn metadata-declared `nullable: true`.
+            if (a.nullable != null && !!a.nullable !== !!b.nullable) {
+                return true;
+            }
+        }
+        return false;
+    }
+    /** Engines drop length/precision modifiers and use different aliases for the same logical type — canonicalise both sides. */
+    normaliseParamType(type) {
+        const lengthMatch = /^([^()]+)\(([^)]*)\)\s*$/.exec(type);
+        const base = (lengthMatch ? lengthMatch[1] : type).trim().toLowerCase();
+        const aliased = SchemaComparator.PARAM_TYPE_ALIASES[base] ?? base;
+        const length = lengthMatch ? Number.parseInt(lengthMatch[2].split(',')[0].trim(), 10) : NaN;
+        const options = Number.isFinite(length) ? { length } : {};
+        return this.#platform.normalizeColumnType(aliased, options).toLowerCase();
+    }
+    static PARAM_TYPE_ALIASES = {
+        int: 'integer',
+        int4: 'integer',
+        int8: 'bigint',
+        int2: 'smallint',
+        bool: 'boolean',
+        'character varying': 'varchar',
+        bpchar: 'char',
+        float8: 'double precision',
+        float4: 'real',
+        // Oracle's USER_ARGUMENTS reports `REF CURSOR`; users declare `sys_refcursor`.
+        'ref cursor': 'sys_refcursor',
+    };
+    diffRoutineReturns(from, to) {
+        if (from == null && to == null) {
+            return false;
+        }
+        if (from == null || to == null) {
+            return true;
+        }
+        if (this.normaliseParamType(from.type) !== this.normaliseParamType(to.type)) {
+            return true;
+        }
+        // Engines report function returns as nullable; only diff when metadata explicitly declares it.
+        if (to.nullable != null && (from.nullable ?? false) !== to.nullable) {
+            return true;
+        }
+        return false;
+    }
     /**
      * Returns the difference between the tables fromTable and toTable.
      * If there are no differences this method returns the boolean false.
@@ -176,14 +323,17 @@ export class SchemaComparator {
             addedForeignKeys: {},
             addedIndexes: {},
             addedChecks: {},
+            addedTriggers: {},
             changedColumns: {},
             changedForeignKeys: {},
             changedIndexes: {},
             changedChecks: {},
+            changedTriggers: {},
             removedColumns: {},
             removedForeignKeys: {},
             removedIndexes: {},
             removedChecks: {},
+            removedTriggers: {},
             renamedColumns: {},
             renamedIndexes: {},
             fromTable,
@@ -197,6 +347,17 @@ export class SchemaComparator {
             });
             changes++;
         }
+        if (diffPartitioning(fromTable.getPartitioning(), toTable.getPartitioning(), this.#platform.getDefaultSchemaName())) {
+            tableDifferences.changedPartitioning = {
+                from: fromTable.getPartitioning(),
+                to: toTable.getPartitioning(),
+            };
+            this.log(`table partitioning changed for ${tableDifferences.name}`, {
+                fromPartitioning: fromTable.getPartitioning(),
+                toPartitioning: toTable.getPartitioning(),
+            });
+            changes++;
+        }
         const fromTableColumns = fromTable.getColumns();
         const toTableColumns = toTable.getColumns();
         // See if all the columns in "from" table exist in "to" table
@@ -263,6 +424,19 @@ export class SchemaComparator {
             if (!this.diffIndex(index, toTableIndex)) {
                 continue;
             }
+            // Constraint-vs-index form mismatch needs drop+create with the OLD form's drop SQL,
+            // which `changedIndexes` (uses new form only) can't do. Primary keys stay on the
+            // changed path which emits `add primary key`.
+            if (!index.primary && !!index.constraint !== !!toTableIndex.constraint) {
+                tableDifferences.removedIndexes[index.keyName] = index;
+                tableDifferences.addedIndexes[index.keyName] = toTableIndex;
+                this.log(`index ${index.keyName} changed form in table ${tableDifferences.name}`, {
+                    fromTableIndex: index,
+                    toTableIndex,
+                });
+                changes += 2;
+                continue;
+            }
             tableDifferences.changedIndexes[index.keyName] = toTableIndex;
             this.log(`index ${index.keyName} changed in table ${tableDifferences.name}`, {
                 fromTableIndex: index,
@@ -309,6 +483,33 @@ export class SchemaComparator {
             tableDifferences.changedChecks[check.name] = toTableCheck;
             changes++;
         }
+        const fromTableTriggers = fromTable.getTriggers();
+        const toTableTriggers = toTable.getTriggers();
+        for (const trigger of toTableTriggers) {
+            if (fromTable.hasTrigger(trigger.name)) {
+                continue;
+            }
+            tableDifferences.addedTriggers[trigger.name] = trigger;
+            this.log(`trigger ${trigger.name} added to table ${tableDifferences.name}`, { trigger });
+            changes++;
+        }
+        for (const trigger of fromTableTriggers) {
+            if (!toTable.hasTrigger(trigger.name)) {
+                tableDifferences.removedTriggers[trigger.name] = trigger;
+                this.log(`trigger ${trigger.name} removed from table ${tableDifferences.name}`);
+                changes++;
+                continue;
+            }
+            const toTableTrigger = toTable.getTrigger(trigger.name);
+            if (this.diffTrigger(trigger, toTableTrigger)) {
+                this.log(`trigger ${trigger.name} changed in table ${tableDifferences.name}`, {
+                    fromTableTrigger: trigger,
+                    toTableTrigger,
+                });
+                tableDifferences.changedTriggers[trigger.name] = toTableTrigger;
+                changes++;
+            }
+        }
         const fromForeignKeys = { ...fromTable.getForeignKeys() };
         const toForeignKeys = { ...toTable.getForeignKeys() };
         for (const fromConstraint of Object.values(fromForeignKeys)) {
@@ -516,6 +717,11 @@ export class SchemaComparator {
             log(`'comment' changed for column ${fromTable.name}.${fromColumn.name}`, { fromColumn, toColumn });
             changedProperties.add('comment');
         }
+        if (!(fromColumn.ignoreSchemaChanges?.includes('collation') || toColumn.ignoreSchemaChanges?.includes('collation')) &&
+            this.diffCollation(fromColumn.collation, toColumn.collation, fromTable.collation)) {
+            log(`'collation' changed for column ${fromTable.name}.${fromColumn.name}`, { fromColumn, toColumn });
+            changedProperties.add('collation');
+        }
         const isNonNativeEnumArray = !(fromColumn.nativeEnumName || toColumn.nativeEnumName) &&
             (fromColumn.mappedType instanceof ArrayType || toColumn.mappedType instanceof ArrayType);
         if (!isNonNativeEnumArray && this.diffEnumItems(fromColumn.enumItems, toColumn.enumItems)) {
@@ -537,12 +743,26 @@ export class SchemaComparator {
         // eslint-disable-next-line eqeqeq
         return comment1 != comment2 && !(comment1 == null && comment2 === '') && !(comment2 == null && comment1 === '');
     }
+    /**
+     * `from` is the introspected DB state, `to` is the target metadata. A column-level `COLLATE`
+     * clause naming the table/database default is just verbose syntax for inheriting that default,
+     * so both sides are normalized — anything matching `tableDefault` collapses to `undefined` and
+     * compares equal to "no explicit collation". Comparison is case-insensitive on dialects that
+     * treat collation identifiers as case-insensitive (MySQL/MSSQL/SQLite); PostgreSQL's
+     * `pg_collation.collname` is case-sensitive and is compared verbatim.
+     */
+    diffCollation(fromCollation, toCollation, tableDefault) {
+        const fold = this.#platform.caseInsensitiveCollationNames() ? (s) => s.toLowerCase() : (s) => s;
+        const norm = (c) => c && tableDefault && fold(c) === fold(tableDefault) ? undefined : c == null ? undefined : fold(c);
+        return norm(fromCollation) !== norm(toCollation);
+    }
     /**
      * Finds the difference between the indexes index1 and index2.
      * Compares index1 with index2 and returns index2 if there are any differences or false in case there are no differences.
      */
     diffIndex(index1, index2) {
-        // if one of them is a custom expression or full text index, compare only by name
+        // Opaque raw expressions (`expression` escape hatch) and full-text indexes can't be
+        // compared structurally — fall back to name-only matching.
         if (index1.expression || index2.expression || index1.type === 'fulltext' || index2.type === 'fulltext') {
             return index1.keyName !== index2.keyName;
         }
@@ -593,6 +813,11 @@ export class SchemaComparator {
         if (!!index1.clustered !== !!index2.clustered) {
             return false;
         }
+        // Compare WHERE predicate of partial indexes structurally (whitespace/quoting/casing
+        // are normalized via the same helper used for check constraints).
+        if (this.diffExpression(index1.where ?? '', index2.where ?? '')) {
+            return false;
+        }
         if (!index1.unique && !index1.primary) {
             // this is a special case: If the current key is neither primary or unique, any unique or
             // primary key will always have the same effect for the index and there cannot be any constraint
@@ -714,6 +939,30 @@ export class SchemaComparator {
         }
         return true;
     }
+    diffTrigger(from, to) {
+        // Raw DDL expression cannot be meaningfully compared to introspected
+        // trigger metadata, so skip diffing when the metadata side uses it.
+        if (to.expression) {
+            // Both sides have expression — compare the raw DDL directly
+            if (from.expression) {
+                return this.diffExpression(from.expression, to.expression);
+            }
+            // Only metadata side has expression — the raw DDL cannot be compared to
+            // introspected metadata. Changes to the expression value won't be detected;
+            // drop and recreate the trigger manually to apply expression changes.
+            return false;
+        }
+        if (from.timing !== to.timing || from.forEach !== to.forEach) {
+            return true;
+        }
+        if ([...from.events].sort().join(',') !== [...to.events].sort().join(',')) {
+            return true;
+        }
+        if ((from.when ?? '') !== (to.when ?? '')) {
+            return true;
+        }
+        return this.diffExpression(from.body, to.body);
+    }
     parseJsonDefault(defaultValue) {
         /* v8 ignore next */
         if (!defaultValue) {