@manyos/smileconnect-api 1.56.0 → 1.57.1

package/app.js

@@ -264,7 +264,8 @@ app.use(function (req, res, next) {
 //set globalscript params
 app.use(function (req, res, next) {
     req.globalScriptParams = {
-        query: req.query
+        query: req.query,
+        user: req.user
     }
     // Für Scripte einen globalen parameter bereitstellen, der den org. Body enthält. Damit hat man auch noch in Post Scripten Zugriff auf customAttributes die beim Mapping entfernt werden.
     if (req.body) {

package/conf/clients.json

@@ -1994,7 +1994,8 @@
           "Class Location",
           "Class Cost",
           "Department",
-          "Class Start Date & Time"
+          "Class Start Date & Time",
+          "Name"
         ]
       },
       "custom_CTM:People": {
@@ -2009,9 +2010,7 @@
             "postMapping": []
           },
           "PUT": {
-            "preMapping": [
-              "slash"
-            ],
+            "preMapping": [],
             "postMapping": [],
             "afterExecution": []
           },
@@ -2075,6 +2074,9 @@
         "fields_AST:ComputerSystem": [
           "DNS Host Name"
         ],
+        "fields_AST:Cluster": [
+          "InstanceId"
+        ],
         "fields_AST:LANEndpoint": [
           "MACAddress"
         ],
@@ -2086,21 +2088,12 @@
         ],
         "scripts": {
           "GET": {
-            "preMapping": [
-              "script1",
-              "script2"
-            ],
-            "postMapping": [
-              "script1"
-            ]
+            "preMapping": [],
+            "postMapping": []
           },
           "POST": {
-            "preMapping": [
-              "scriptPutPre"
-            ],
-            "postMapping": [
-              "scriptPutPost"
-            ]
+            "preMapping": [],
+            "postMapping": []
           }
         }
       },
@@ -2325,7 +2318,7 @@
         "scripts": {
           "GET": {
             "preMapping": [
-              "p2"
+              "createRecord"
             ],
             "postMapping": [],
             "afterExecution": []

package/conf/mapping.json

@@ -77,6 +77,12 @@
       "newName": "macAddress"
     }
   ],
+  "cmdbobject_AST:Cluster": [
+    {
+      "oldName": "InstanceId",
+      "newName": "id"
+    }
+  ],
   "change": [
     {
       "oldName": "Infrastructure Change ID",

package/controller/cmdbobjectController.js

@@ -342,7 +342,7 @@ async function updateCmdbObject(ticketConfig, clientConfig, id, ciData, classId,
         await scriptController.runScripts(scripts.postMapping, ciData, clientConfig.clientId, globalScriptParams);
     }
 
-    const update = await arquery.updateEntry(formName, ci['Request ID'], ciData);
+    const update = await arquery.updateEntry(formName, ci['Request ID'], ciData, clientConfig.options);
 
     //run afterExecution
     if (scripts && scripts.afterExecution) {
@@ -403,27 +403,34 @@ async function createCmdbObject(assetConfig, clientConfig, classId, ciData, glob
 
     const mapping = getClassMapping(classId);
 
-    const classFields = getClassFields(clientConfig, classId)
+    const classFields = getClassFields(clientConfig, classId);
 
-    //Constants work only on new.
-    ciData = mappingUtil.applyMapping2Remedy(ciData, mapping, undefined, classFields);
+    const reconIdField = await config.getFormFieldById(classId, 400129200);
+    const instanceIdField = await config.getFormFieldById(classId, 179);
+    const dataSetIdField = await config.getFormFieldById(classId, 400127400);
 
-    //run postMapping
-    if (scripts && scripts.postMapping) {
-        await scriptController.runScripts(scripts.postMapping, ciData, clientConfig.clientId, globalScriptParams);
+    if (!reconIdField || !instanceIdField || !dataSetIdField) {
+        throw ({message: "RecondId, InstanceId or Dataset not found on form", field:{reconIdField, instanceIdField, dataSetIdField}})
     }
+    //Constants work only on new.
+    ciData = mappingUtil.applyMapping2Remedy(ciData, mapping, undefined, classFields);
 
     //Default to BMC.ASSET if no Dataset is provided
-    if (!ciData['Data Set Id']) {
-        ciData['Data Set Id'] = "BMC.ASSET"
+    if (!ciData[dataSetIdField.name]) {
+        ciData[dataSetIdField.name] = "BMC.ASSET"
     }
     //Add reconId only for Asset Dataset
-    if (ciData['Data Set Id'] === "BMC.ASSET") {
-        ciData['400129200'] = reconId;
+    if (ciData[dataSetIdField.name] === "BMC.ASSET") {
+        ciData[reconIdField.name] = reconId;
+    }
+    ciData[instanceIdField.name] = instanceId;
+
+    //run postMapping
+    if (scripts && scripts.postMapping) {
+        await scriptController.runScripts(scripts.postMapping, ciData, clientConfig.clientId, globalScriptParams);
     }
-    ciData['Instance Id'] = instanceId;
 
-    const update = await arquery.createEntry(classId, ciData);
+    const update = await arquery.createEntry(classId, ciData, clientConfig.options);
 
     //run afterExecution
     if (scripts && scripts.afterExecution) {

package/controller/customFormController.js

@@ -181,7 +181,7 @@ async function updateRecord(formConfig, clientConfig, id, recordData, globalScri
 
     const internalId = await getInternalId(formConfig, clientConfig, id)
 
-    const update = await arquery.updateEntry(formConfig.formName, internalId, recordData);
+    const update = await arquery.updateEntry(formConfig.formName, internalId, recordData, clientConfig.options);
 
     //run afterExecution
     if (scripts && scripts.afterExecution) {

package/controller/taskController.js

@@ -445,7 +445,7 @@ async function updateTask(clientConfig, id, taskData, globalScriptParams) {
         await scriptController.runScripts(scripts.postMapping, taskData, clientConfig.clientId, globalScriptParams);
     }
 
-    const result = await arquery.updateEntry('TMS:Task', id, taskData);
+    const result = await arquery.updateEntry('TMS:Task', id, taskData, clientConfig.options);
 
     //flow update
     const taskQuery = `'1' = "${id}"`

package/controller/ticketController.js

@@ -44,7 +44,7 @@ async function createTicket(ticketConfig, clientConfig, data, globalScriptParams
 
     const result = await arquery.createEntry(ticketConfig.forms.new, data, clientConfig.options)
 
-    log.debug('TicketCreateResult', result.data);
+    log.debug('TicketCreateResult', result);
     const ticketCreateId = Object.values(result)[0];
     //Find change id
     const resultInterfaceCreate = await arquery.executeARQuery(ticketConfig.forms.new, null, "'1'=\"" + ticketCreateId + "\"", ticketConfig.ticketIdField, clientConfig.options)
@@ -123,6 +123,8 @@ async function handleTicket(ticketConfig, ticket, mapping, clientConfig, include
         scripts = allScripts.GET || [];
     }
 
+    globalScriptParams.id = ticket[ticketConfig.requestIdField]
+
     const requestType = ticketConfig.requestType;
     if (requestType === 'incident') {
         checkFieldsIncident(ticket, globalRelationObjects);
@@ -312,7 +314,7 @@ async function updateTicket(ticketConfig, clientConfig, id, ticketData, globalSc
         relations.keepCIs = [ticket.data.serviceReconId]
     }
     //todo Abfangen wenn getTicket nichts liefert.
-    const update = await arquery.updateEntry(ticketConfig.forms.regular, ticket.data.internalId, ticketData);
+    const update = await arquery.updateEntry(ticketConfig.forms.regular, ticket.data.internalId, ticketData, clientConfig.options);
     await ticketCIRelationController.updateRelations(ticketConfig, clientConfig, id, relations);
     //run afterExecution
     if (scripts && scripts.afterExecution) {

package/docs/_sidebar.md

@@ -11,6 +11,7 @@
   - [Mapping](configuration/mapping)
   - [Client Configuration](configuration/clients)
   - [Events](configuration/events)
+  - [Webhooks](configuration/webhooks)
 
 - Data manipulation
 

package/docs/adapter.md

@@ -308,6 +308,9 @@ e.g.
 }
 ```
 
+* impersonateUser
+
+Can be used to set the user during adapter calls.
 
 * countOnly (only search)
 
@@ -320,6 +323,7 @@ const options = {
     limit: 100,
     offset: 100,
     dafeFormat: "yyyy-MM-dd HH:mm:ss.SSSZ",
+    impersonateUser: "Allen",
     sort: {
         "Name": 1,
         "Status": -1

package/docs/configuration/config.md

@@ -312,6 +312,21 @@ ADMIN_USERS=username1, username2
 
 Loglevel of the api. Defaults to *error*
 
+## Certificates
+
+### NODE_EXTRA_CA_CERTS
+
+If you need to validate custom certificates in your webhooks you can define a file with them here.
+
+Sample:
+
+*NODE_EXTRA_CA_CERTS = "/home/node/app/ssl/Chain.crt"*
+
+This file needs to be available within the container.
+
+[See also](https://nodejs.org/api/cli.html#node_extra_ca_certsfile)
+
+
 # GUI
 
 ## SMILEconnect
@@ -381,3 +396,15 @@ Use this to disable modules in SMILEconnect.
 
 Sample:
 *REACT_APP_DISABLED_MODULES=workOrder,problem*
+
+### REACT_APP_MAPPING_SYNC
+If you need to disable the Field Sync from Form mapping to new mapping (for example incident to newIncident),
+you can set this parameter to DISABLE
+Sample:
+*REACT_APP_MAPPING_SYNC=DISABLE*
+
+### REACT_APP_MAPPING_SYNC_CHECK 
+If you need to disable the Field Sync Warning From form mapping to new mapping (for example incident to newIncident),
+you can set this parameter to DISABLE.
+Sample:
+*REACT_APP_MAPPING_SYNC_CHECK=DISABLE*

package/docs/configuration/webhooks.md

@@ -0,0 +1,97 @@
+# Webhooks
+
+## Sample
+
+```json
+[
+  {
+  "client": "isms",
+  "webhooks": [
+    {
+      "name": "allInc",
+      "url": "https://myUrl.example.com",
+      "event": "INC",
+      "secret": "123geheim",
+      "insecure": false,
+      "jsonSpace": 2,
+      "auth": {
+        "type": "basic",
+        "user": "user123",
+        "password": "pass123"
+      },
+      "scripts": [
+        "p1",
+        "p4"
+      ]
+    }
+  ]
+  }
+]
+```
+
+## Configuration Options
+
+### name
+
+Name of the webhook.
+
+### url
+
+Url that will be called. All webhooks will be sent as POST requests.
+
+### event
+
+The event that the webhook subscribed to. The system will check if the definition is contained in the actual event.
+
+e.g. 
+
+* INC will capture all Incident events.
+* modified will capture all modified events.
+
+### secret
+
+This mechanism can be used if the webhook endpoint does not support authentication but still wants to verify that the sent webhook is valid and was sent by your system.
+
+If set the body of the request will hashed and the signature will be added to the header as *x-isapi-signature* in the format *algorithm:signature*
+
+e.g. The following body with the secret *123geheim* will generate the below signature header.
+
+```json
+{
+  "event": "TestOnly",
+  "objectId": "Test1234",
+  "objectId2": "Test1234.3"
+}
+```
+
+"x-isapi-signature": "sha256:66976bf984b48cd18441b489c50a886dcf51f910e82d3736e8c5e00110c3df95"
+
+### insecure
+
+Disables SSL certification validation. Use this with caution.
+
+### jsonSpace
+
+When set the body of the webhook will be formatted with spaces.
+
+### auth
+
+If your endpoint requires authentication this can be used.
+
+#### type
+
+Type of authentication. Currently only basic is supported.
+
+#### user
+
+Username for basic authentication.
+
+#### password
+
+Passwort for basic authentication.
+
+###
+
+### scripts
+
+An array of scripts that are executed when the webhook is fired. Can be used to transform data or to populate the outbound request with ticket data.

package/docs/releases.md

@@ -2,6 +2,18 @@
 
 ## API 
 
+### 1.57.1 - 25.03.22
+Remove misleading error from CustomFormMappings
+
+### 1.57.0 - 25.03.22
+
+Add impersonate to update requests.
+Impersonate works not on the following requests:
+- Add/Read Attachments
+- Ticket/CI Relations
+
+Make DatasetId-, ReconId- & InstanceId-Fields dynamic on CMDBCreate Operations
+
 ### 1.56.0 - 03.03.22
 Support Script Rename with references
 Add event to globalScriptParams
@@ -182,12 +194,16 @@ Update Record added to [Remedy Adapter](adapter#remedy).
 The eventmanager will check all outbound webhooks for an event. If one fails, the whole Event will be set to error and the details will be added to the error message.
 
 ## GUI
+### 1.9.2 - 08.03.22
+Fixed: Sync mapping not working correctly in some situations
+Feat: Mapping: Added warning to "new" Form mapping, if a mapping is missing (you can disble this with parameter REACT_APP_MAPPING_SYNC_CHECK=DISABLE
+Feat: Use the following Parameter to disable sync from module mapping to new mapping REACT_APP_MAPPING_SYNC=DISABLE
 
-### 1.8.2 - 2.3.22
+### 1.8.2 - 02.03.22
 Fixed: delete webhooks for client when client is deleted
 Fixed: delete button / menu is hidden when client or scriptname is too long 
 
-### 1.8.0 - 3.2.22
+### 1.8.0 - 03.02.22
 Fixed wrong Script Config for Custom Form Scripts (attribute clients instead of scripts)
 Fixed Scrolling
 Fixed navigation error from "Import/Export" to a client

package/docs/scripts.md

@@ -115,8 +115,12 @@ Global script params are set by the application and handed over to the script. T
 
 **classId**: the classId of cmdbobjects. Only set in POST & PUT actions
 
+**event**: the event that this transaction creates. e.g. INC_Create, CHG_TAS_Modify
+
 **sourceData**: Contains the original body for PUT/POST request. This can be used scripts to access custom data that was removed during mapping.
 
+**user**: Contains the full configuration of the client. The attribute user.config.options.impersonateUser might be overwritten by the dynamic passed value if user.config.options.allowDynamicImpersonate ist set to true. 
+
 ```json
 {
     "query": {
@@ -127,13 +131,42 @@ Global script params are set by the application and handed over to the script. T
     "sourceData": {
         "data": {
           "summary": "Short summary",
-          "notes": "Some details here",
+          "notes": "Some details here"
         },
         "customData": {
           "foo": "bar"
         }
     },
-    "id": "INC000000001507"
+    "event": "INC_Modify",
+    "id": "INC000000001507",
+    "user": {
+      "id": "255e90dc-73ab-42d9-b952-60cec716c4e8",
+      "azp": "isms",
+      "scope": "profile issm",
+      "exp": 1648203329,
+      "config": {
+        "options": {
+          "dateFormat": "dd.MM.yyyy HH:mm.ss",
+          "clientLimit": 100000,
+          "impersonateUser": "Bob",
+          "allowDynamicImpersonate": true,
+          "translateSelectionFields": false
+        },
+        "custom_Sample:Enrollments": {
+          "basequery": "1=1",
+          "fields": [
+            "Enrollment ID",
+            "Enrollee Login",
+            "Class ID",
+            "Class Title",
+            "Class Location",
+            "Class Cost",
+            "Department",
+            "Class Start Date & Time"
+          ]
+        }
+      }
+    }
 }
 ```
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@manyos/smileconnect-api",
-  "version": "1.56.0",
+  "version": "1.57.1",
   "description": "A proxy and abstraction layer for BMCs IT Service Management Suite",
   "main": "app.js",
   "scripts": {

package/util/arquery.js

@@ -362,7 +362,7 @@ function applyMapping(entryData, mapping, constants) {
     return entryData;
 }
 
-function updateEntry(form, id, entryData) {
+function updateEntry(form, id, entryData, clientOptions) {
     let port = 0;
     if (process.env.AR_PORT && process.env.AR_PORT != undefined)
         port = process.env.AR_PORT;
@@ -376,13 +376,16 @@ function updateEntry(form, id, entryData) {
     log.debug('New Entry', myEntry);
     //log.debug('object', Object.keys(entryData));
     return new Promise((resolve, reject) => {
-        const uri = process.env.BASEURL
+        let uri = process.env.BASEURL
             + "/" + process.env.AR_SERVER
             + "/" + form
             + "?port=" + port;
 
+        if (clientOptions && clientOptions.impersonateUser) {
+            uri = uri + "&impersonateUser=" + clientOptions.impersonateUser;
+        }
 
-        var options = {
+        const options = {
             method: 'PUT',
             uri: uri,
             body: myEntry,

package/util/config.js

@@ -583,6 +583,15 @@ function getFields(form) {
     });
 }
 
+async function getFormFieldById(form, fieldId) {
+    const formFields = await getFields(form);
+    if (formFields && Array.isArray(formFields)) {
+        return formFields.find(item => item.fieldId === fieldId)
+    } else {
+        return null
+    }
+}
+
 const ticketConfig = {
     "workorders": {
         "forms": {
@@ -689,5 +698,6 @@ module.exports = {
     ticketConfig,
     getCustomFormMapping,
     setCustomFormMapping,
-    getDesignPackage
+    getDesignPackage,
+    getFormFieldById
 };

package/util/mappingUtil.js

@@ -153,7 +153,7 @@ function applyCustomFormMapping2Remedy(entryData, mapping, constants, fields) {
                 delete entryData[mappedName];
             }
         } catch (e) {
-            log.error('mappingError', e)
+            //log.error('mappingError', e)
         }
     })