@manyos/smileconnect-api 1.55.3 → 1.55.4

package/docs/releases.md

@@ -2,6 +2,9 @@
 
 ## API 
 
+### 1.55.4 - 02.03.22
+Fix error when scripts with space in name are deleted  
+
 ### 1.55.3 - 01.03.22
 Ensure TTL of 0 disables cache for Remedy Adapter
 
@@ -170,6 +173,10 @@ The eventmanager will check all outbound webhooks for an event. If one fails, th
 
 ## GUI
 
+### 1.8.2 - 3.3.22
+Fixed: delete webhooks for client if client is deleted
+Fixed: delete button / menu is hidden if client or scriptname is to long 
+
 ### 1.8.0 - 3.2.22
 Fixed wrong Script Config for Custom Form Scripts (attribute clients instead of scripts)
 Fixed Scrolling

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@manyos/smileconnect-api",
-  "version": "1.55.3",
+  "version": "1.55.4",
   "description": "A proxy and abstraction layer for BMCs IT Service Management Suite",
   "main": "app.js",
   "scripts": {

package/routes/scriptRoutes.js

@@ -13,6 +13,10 @@ const {throwSchemaError} = require('../util/responsehandler');
 module.exports = (function() {
     const scriptRoutes = require('express').Router();
 
+    function decodeScriptName(path) {
+        return decodeURI(path).replace(`/`,"")
+    }
+
     scriptRoutes.get('/',
         isAuthorizedAdmin,
         function (req, res, next) {
@@ -35,7 +39,7 @@ module.exports = (function() {
     });
 
     scriptRoutes.get('/:scriptId*', isAuthorizedAdmin, async function (req, res, next) {
-        const scriptId = req.path.replace(`/`,"");
+        const scriptId = decodeScriptName(req.path);
         eventLog.setEventData(
             req,
             CONSTANTS.EVENT_BASE_SCRIPT,
@@ -75,7 +79,7 @@ module.exports = (function() {
             const errors = validationResult(req);
             throwSchemaError(errors);
 
-            const scriptId = req.path.replace(`/`,"");
+            const scriptId = decodeScriptName(req.path);
 
             eventLog.setEventData(
                 req,
@@ -94,7 +98,7 @@ module.exports = (function() {
         });
 
     scriptRoutes.delete('/:scriptId*', isAuthorizedAdmin, function (req, res, next) {
-        const scriptId = req.path.replace(`/`,"");
+        const scriptId = decodeScriptName(req.path);
         eventLog.setEventData(
             req,
             CONSTANTS.EVENT_BASE_SCRIPT,

package/conf/scripts/p1.js

@@ -1,11 +0,0 @@
-const allowedCats = [
-    "Request",
-    "Failure"
-];
-
-//Validate opsCat1
-if (requestData.opsCat1 && !allowedCats.find(element => element === requestData.opsCat1)) {
-    reject(`opsCat1 ${requestData.opsCat1} not in allowed values ${allowedCats}`);
-}
-requestData.summary = `Da kam an: ${requestData.summary}`
-resolve();